Re: [Qemu-devel] [PATCH qom-next 2/7] qom: Add get_id

2012-06-08 Thread Andreas Färber
Am 08.06.2012 03:22, schrieb Anthony Liguori: > On 06/08/2012 03:31 AM, Andreas Färber wrote: >> From: Paolo Bonzini >> >> Some classes may present objects differently in errors, for example if >> they >> are not part of the composition tree or if they are not assigned an id by >> the user. Let th

Re: [Qemu-devel] [PATCH qom-next 2/7] qom: Add get_id

2012-06-08 Thread Anthony Liguori
On 06/08/2012 03:11 PM, Andreas Färber wrote: Am 08.06.2012 03:22, schrieb Anthony Liguori: On 06/08/2012 03:31 AM, Andreas Färber wrote: From: Paolo Bonzini Some classes may present objects differently in errors, for example if they are not part of the composition tree or if they are not assi

Re: [Qemu-devel] [PATCH v3 06/29] build: move libobj-y variable to nested Makefile.objs

2012-06-08 Thread Andreas Färber
Am 08.06.2012 01:18, schrieb Paolo Bonzini: > Il 07/06/2012 23:10, Blue Swirl ha scritto: >>> diff --git a/target-sparc/Makefile.objs b/target-sparc/Makefile.objs >>> index c574c9e..3556d13 100644 >>> --- a/target-sparc/Makefile.objs >>> +++ b/target-sparc/Makefile.objs >>> @@ -1 +1,7 @@ >>> -# sti

Re: [Qemu-devel] [PATCH qom-next 2/7] qom: Add get_id

2012-06-08 Thread Andreas Färber
Am 08.06.2012 09:44, schrieb Anthony Liguori: > On 06/08/2012 03:11 PM, Andreas Färber wrote: >> Am 08.06.2012 03:22, schrieb Anthony Liguori: >>> On 06/08/2012 03:31 AM, Andreas Färber wrote: From: Paolo Bonzini Some classes may present objects differently in errors, for example if

Re: [Qemu-devel] [PATCH qom-next 04/59] pc: Add CPU as /machine/cpu[n]

2012-06-08 Thread Igor Mammedov
On Wed, May 23, 2012 at 05:07:27AM +0200, Andreas Färber wrote: > Using the cpu_index, give the X86CPU a canonical path. > This must be done before initializing the APIC. > > Signed-off-by: Igor Mammedov > Signed-off-by: Andreas Färber > --- > hw/pc.c | 12 > 1 files changed, 12

Re: [Qemu-devel] [PATCH 02/12] qcow2: fix the byte endian convertion

2012-06-08 Thread Kevin Wolf
Am 07.06.2012 09:13, schrieb Michael Tokarev: > On 04.06.2012 15:13, Kevin Wolf wrote: >> From: Zhi Yong Wu >> >> Signed-off-by: Zhi Yong Wu >> Reviewed-by: Stefan Hajnoczi >> Signed-off-by: Kevin Wolf > > It appears to be a good candidate for -stable, no? No, it's merely cosmetic. cpu_to_be6

Re: [Qemu-devel] [RFC PATCH] qemu pci: pci_add_capability enhancement to prevent damaging config space

2012-06-08 Thread Alexey Kardashevskiy
Yet another try :) Normally the pci_add_capability is called on devices to add new capability. This is ok for emulated devices which capabilities list is being built by QEMU. In the case of VFIO the capability may already exist and adding new capability into the beginning of the linked list may c

Re: [Qemu-devel] [PATCH 5/6] fdc: use LOG_UNIMP logging

2012-06-08 Thread Kevin Wolf
Am 07.06.2012 23:07, schrieb Blue Swirl: > On Mon, Jun 4, 2012 at 9:36 AM, Kevin Wolf wrote: >> Am 03.06.2012 19:38, schrieb Blue Swirl: >>> Convert uses of FLOPPY_ERROR to either FLOPPY_DPRINTF >>> (for implemented cases) or to use LOG_UNIMP (unimplemented). >>> >>> Signed-off-by: Blue Swirl >>

[Qemu-devel] [RFC] Proposal: PCI/PCIe: inbound BAR0 emulation for PCI controller (Root Complex)

2012-06-08 Thread Bhushan Bharat-R65777
Hi All, When Freescale PCI controller configured in Root Complex mode then, its configuration header (type 1) have one inbound BAR (BAR0, called as CCSRBAR). And rest of BARs (inbound and outbound) are supported by ATMU registers, which are outside the Type 1 configuration header. This BAR0 of

Re: [Qemu-devel] buildbot failure in qemu on block_mingw32

2012-06-08 Thread Stefan Hajnoczi
On Fri, Jun 8, 2012 at 2:54 AM, wrote: > The Buildbot has detected a new failure on builder block_mingw32 while > building qemu. > Full details are available at: >  http://buildbot.b1-systems.de/qemu/builders/block_mingw32/builds/237 Hi Max, Looks like an xtensa issue, just wanted to draw your

Re: [Qemu-devel] [PATCH qom-next 04/59] pc: Add CPU as /machine/cpu[n]

2012-06-08 Thread Andreas Färber
Am 08.06.2012 10:20, schrieb Igor Mammedov: > On Wed, May 23, 2012 at 05:07:27AM +0200, Andreas Färber wrote: >> Using the cpu_index, give the X86CPU a canonical path. >> This must be done before initializing the APIC. >> >> Signed-off-by: Igor Mammedov >> Signed-off-by: Andreas Färber >> --- >>

Re: [Qemu-devel] [RFC] QOMification of AXI stream

2012-06-08 Thread Paul Brook
> Im looking to QOMifying and refactoring the AXI stream interfaces > between the AXI ethernet and AXI DMA modules. I could use some > guidance on how to do this as I can think of about 6 different > solutions. Sources are hw/xilinx_axienet.c and hw/xilinx_axidma.c. > >... > > So what im proposing

Re: [Qemu-devel] [RFC] QOMification of AXI stream

2012-06-08 Thread Peter Maydell
On 8 June 2012 10:13, Paul Brook wrote: > Of course we then hit the usual problem with QOM that we can only link to > objects, and it's impossible to expose multiple interfaces of the same type. I'm pretty sure Anthony claimed this was entirely possible -- presumably that's how Pins are going to

Re: [Qemu-devel] [RFC] QOMification of AXI stream

2012-06-08 Thread Andreas Färber
Am 08.06.2012 06:23, schrieb Peter Crosthwaite: > Each of the two core has three interfaces (+interrupt pins): > > 1: Sysbus attachment for device control > 2: AXI stream TX link > 3: AXI stream RX link [...] > struct XilinxDMAConnection { > void *dma; > void *client; > > DMAPushFn to

Re: [Qemu-devel] [PULL 00/12] Block patches

2012-06-08 Thread Kevin Wolf
Am 07.06.2012 03:17, schrieb Anthony Liguori: > On 06/04/2012 07:13 PM, Kevin Wolf wrote: >> The following changes since commit 8cc9b43f7c5f826b39af4b012ad89bb55faac29c: >> >>target-microblaze: lwx/swx: first implementation (2012-06-04 10:19:46 >> +0200) >> >> are available in the git reposito

[Qemu-devel] [PATCH] xtensa_lx60: add missing #include "blockdev.h"

2012-06-08 Thread Max Filippov
This should fix the following build failure: /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c: In function 'lx_init': /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c:212: warning: implicit declaration of function 'drive_get' /home/buildbot/slave-public/block_ming

Re: [Qemu-devel] buildbot failure in qemu on block_mingw32

2012-06-08 Thread Max Filippov
On Fri, Jun 8, 2012 at 1:07 PM, Stefan Hajnoczi wrote: > On Fri, Jun 8, 2012 at 2:54 AM,   wrote: >> The Buildbot has detected a new failure on builder block_mingw32 while >> building qemu. >> Full details are available at: >>  http://buildbot.b1-systems.de/qemu/builders/block_mingw32/builds/237

[Qemu-devel] [PATCH 3/3] configure: report missing libraries for virtfs

2012-06-08 Thread Stefan Hajnoczi
From: Harsh Prateek Bora Signed-off-by: Harsh Prateek Bora Signed-off-by: Stefan Hajnoczi --- configure |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 76dd57f..e8f0172 100755 --- a/configure +++ b/configure @@ -2915,7 +2915,8 @@ if test "$s

[Qemu-devel] [PATCH 2/3] trace/simple.c: fix deprecated glib2 interface

2012-06-08 Thread Stefan Hajnoczi
From: Harsh Prateek Bora Signed-off-by: Harsh Prateek Bora Signed-off-by: Stefan Hajnoczi --- trace/simple.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/trace/simple.c b/trace/simple.c index 33ae486..b4a3c6e 100644 --- a/trace/simple.c +++ b/trace/simple.c @@ -16

Re: [Qemu-devel] [PATCH 0/2] Configure and build fix for VirtFS

2012-06-08 Thread Stefan Hajnoczi
On Fri, Jun 08, 2012 at 03:20:41AM +0530, Harsh Prateek Bora wrote: > Minor fixes: > > > 1) glib2 deprecated g_atomic_int_exchange_and_add in favour of > g_atomic_int_add >since ver 2.30 and therefore build breaks with newer glib2 library. > 2) Configure needs to report appropria

[Qemu-devel] [PATCH 1/3] Clarify comments of tb_invalidate_phys_[page_]range

2012-06-08 Thread Stefan Hajnoczi
From: Jan Kiszka They could suggest that all TBs of the page containing the range would be invalidated. Signed-off-by: Jan Kiszka Signed-off-by: Stefan Hajnoczi --- exec.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/exec.c b/exec.c index 1b65

[Qemu-devel] [PULL 0/3] Trivial patches for May 2 to June 8 2012

2012-06-08 Thread Stefan Hajnoczi
Now that the tree is open, let's get trivial patches moving! Only a couple so far... The following changes since commit 083dbf489d1b0592e910ecfb90b3858c23e49ab7: target-microblaze: fix swx build breakage (2012-06-07 10:12:00 +0200) are available in the git repository at: git://github.com/

Re: [Qemu-devel] [PATCH] xtensa_lx60: add missing #include "blockdev.h"

2012-06-08 Thread Stefan Hajnoczi
On Fri, Jun 8, 2012 at 10:50 AM, Max Filippov wrote: > This should fix the following build failure: > > /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c: In function > 'lx_init': > /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c:212: > warning: implicit declarati

Re: [Qemu-devel] [PULL] iov* function rework (one more time)

2012-06-08 Thread Kevin Wolf
Am 07.06.2012 19:53, schrieb Michael Tokarev: > The following changes since commit 083dbf489d1b0592e910ecfb90b3858c23e49ab7: > > target-microblaze: fix swx build breakage (2012-06-07 10:12:00 +0200) > > are available in the git repository at: > > git://git.corpit.ru/qemu.git mjt-iov > > for

Re: [Qemu-devel] [PATCH] configure: Fix build for some versions of glibc (9pfs)

2012-06-08 Thread Stefano Stabellini
On Thu, 7 Jun 2012, Stefan Weil wrote: > Some versions declare open_by_handle_at, but don't define AT_EMPTY_PATH. > Extend the check in configure to test both preconditions. > > Signed-off-by: Stefan Weil I have just noticed that this issue also affects QEMU 1.0.x, but we don't have a check for

Re: [Qemu-devel] [PATCH v2 00/41] postcopy live migration

2012-06-08 Thread Juan Quintela
Anthony Liguori wrote: >> TODO >> >> - benchmark/evaluation. Especially how async page fault affects the result. > > I don't mean to beat on a dead horse, but I really don't understand > the point of postcopy migration other than the fact that it's > possible. It's a lot of code and a new AB

Re: [Qemu-devel] [PATCH qom-next 04/59] pc: Add CPU as /machine/cpu[n]

2012-06-08 Thread Jan Kiszka
On 2012-06-08 11:11, Andreas Färber wrote: >>From what I understand about the x86 modeling, the only case this > matters is if you hot-unplug CPU 0, right? Question is, what happens > with the APIC then? I would guess the remaining n-1 CPUs still want to > access the APIC APICs are per-CPU, each h

Re: [Qemu-devel] [PATCH 0/3][v17] megasas: LSI Megaraid SAS HBA emulation

2012-06-08 Thread Andreas Färber
Am 08.06.2012 01:24, schrieb Paolo Bonzini: > Il 29/05/2012 14:22, Paolo Bonzini ha scritto: >> Il 29/05/2012 13:51, Hannes Reinecke ha scritto: >>> This is an updated patchset for megasas. Upon popular demand >>> I've split it into three parts, the header file, the emulation >>> itself, and a patc

Re: [Qemu-devel] [PATCH v2 00/41] postcopy live migration

2012-06-08 Thread Avi Kivity
On 06/08/2012 01:16 PM, Juan Quintela wrote: > Anthony Liguori wrote: > >> TODO > >> > >> - benchmark/evaluation. Especially how async page fault affects the result. > > > > I don't mean to beat on a dead horse, but I really don't understand > > the point of postcopy migration other than the

Re: [Qemu-devel] [PATCH v5 2/2] net: add the support for -netdev socket, listen

2012-06-08 Thread Stefan Hajnoczi
On Thu, Jun 7, 2012 at 3:54 PM, wrote: > @@ -86,7 +82,16 @@ static void net_socket_send(void *opaque) >         /* end of connection */ >     eoc: >         qemu_set_fd_handler(s->fd, NULL, NULL, NULL); > +        qemu_set_fd_handler(s->listen_fd, net_socket_accept, NULL, s); What happens when t

Re: [Qemu-devel] [PATCH qom-next 04/59] pc: Add CPU as /machine/cpu[n]

2012-06-08 Thread Andreas Färber
Am 08.06.2012 12:21, schrieb Jan Kiszka: > On 2012-06-08 11:11, Andreas Färber wrote: >> >From what I understand about the x86 modeling, the only case this >> matters is if you hot-unplug CPU 0, right? Question is, what happens >> with the APIC then? I would guess the remaining n-1 CPUs still want

Re: [Qemu-devel] CoW image commit+shrink(= make_empty) support

2012-06-08 Thread Kevin Wolf
Am 07.06.2012 08:19, schrieb Taisuke Yamada: > I attended Paolo Bonzini's qemu session ("Live Disk Operations: Juggling > Data and Trying to go Unnoticed") in LinuxCon Japan, and he adviced me > to post the bits I have regarding my question on qemu's support on shrinking > CoW image. > > Here's m

Re: [Qemu-devel] [PATCH] xtensa_lx60: add missing #include "blockdev.h"

2012-06-08 Thread Stefan Weil
Am 08.06.2012 12:08, schrieb Stefan Hajnoczi: On Fri, Jun 8, 2012 at 10:50 AM, Max Filippov wrote: This should fix the following build failure: /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c: In function 'lx_init': /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx

Re: [Qemu-devel] [PATCH qom-next 04/59] pc: Add CPU as /machine/cpu[n]

2012-06-08 Thread Andreas Färber
Am 08.06.2012 12:36, schrieb Andreas Färber: > Am 08.06.2012 12:21, schrieb Jan Kiszka: >> On 2012-06-08 11:11, Andreas Färber wrote: >>> >From what I understand about the x86 modeling, the only case this >>> matters is if you hot-unplug CPU 0, right? Question is, what happens >>> with the APIC the

Re: [Qemu-devel] [PATCH 1/3] qmp/hmp: Add QMP getfd command that returns fd

2012-06-08 Thread Daniel P. Berrange
On Wed, Jun 06, 2012 at 10:04:23AM -0400, Corey Bryant wrote: > > > On 06/05/2012 02:30 PM, Luiz Capitulino wrote: > >On Mon, 4 Jun 2012 09:10:08 -0400 > >Corey Bryant wrote: > > > >>This patch adds QMP support for the getfd command using the QAPI framework. > >>Like the HMP getfd command, it i

Re: [Qemu-devel] [PATCH v2 33/41] postcopy: introduce -postcopy and -postcopy-flags option

2012-06-08 Thread Juan Quintela
Isaku Yamahata wrote: > This patch prepares for postcopy livemigration. > It introduces -postcopy option and its internal flag, migration_postcopy. > It introduces -postcopy-flags for chaging the behavior of incoming postcopy > mainly for benchmark/debug. Why do we need postcopy flag? -incoming

Re: [Qemu-devel] [RFC PATCH] qemu pci: pci_add_capability enhancement to prevent damaging config space

2012-06-08 Thread Jan Kiszka
On 2012-06-08 10:47, Alexey Kardashevskiy wrote: > Yet another try :) > > Normally the pci_add_capability is called on devices to add new > capability. This is ok for emulated devices which capabilities list > is being built by QEMU. > > In the case of VFIO the capability may already exist and ad

Re: [Qemu-devel] [PATCH 11/13] Move pci_parse_devaddr to qdev-properties

2012-06-08 Thread Jan Kiszka
On 2012-06-07 17:56, Andreas Färber wrote: > Am 07.06.2012 17:11, schrieb Jan Kiszka: >> On 2012-06-07 14:57, Andreas Färber wrote: >>> These last three patches collide with Paolo's QOM properties >>> refactoring: qdev properties are being generalized to Object and >>> on my GitHub "realize" branc

Re: [Qemu-devel] [PATCH] xtensa_lx60: add missing #include "blockdev.h"

2012-06-08 Thread Stefan Hajnoczi
On Fri, Jun 8, 2012 at 11:43 AM, Stefan Weil wrote: > Am 08.06.2012 12:08, schrieb Stefan Hajnoczi: > >> On Fri, Jun 8, 2012 at 10:50 AM, Max Filippov  wrote: >>> >>> This should fix the following build failure: >>> >>> /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c: In >>> funct

Re: [Qemu-devel] [libvirt] [PATCH qom-next 2/7] qom: Add get_id

2012-06-08 Thread Daniel P. Berrange
On Fri, Jun 08, 2012 at 10:17:05AM +0200, Andreas Färber wrote: > Am 08.06.2012 09:44, schrieb Anthony Liguori: > > On 06/08/2012 03:11 PM, Andreas Färber wrote: > > Since qdev->id is NULL 90% of the time, I don't think a user can > > realistically rely on it. I don't think changing the type of th

Re: [Qemu-devel] [RFC] Proposal: PCI/PCIe: inbound BAR0 emulation for PCI controller (Root Complex)

2012-06-08 Thread Benjamin Herrenschmidt
On Fri, 2012-06-08 at 09:03 +, Bhushan Bharat-R65777 wrote: > Hi All, > > When Freescale PCI controller configured in Root Complex mode then, > its configuration header (type 1) have one inbound BAR (BAR0, called > as CCSRBAR). And rest of BARs (inbound and outbound) are supported by > ATMU re

Re: [Qemu-devel] [RFC PATCH] qemu pci: pci_add_capability enhancement to prevent damaging config space

2012-06-08 Thread Alexey Kardashevskiy
08.06.2012 20:56, Jan Kiszka написал: > On 2012-06-08 10:47, Alexey Kardashevskiy wrote: >> Yet another try :) >> >> Normally the pci_add_capability is called on devices to add new >> capability. This is ok for emulated devices which capabilities list >> is being built by QEMU. >> >> In the case of

Re: [Qemu-devel] [RFC PATCH] qemu pci: pci_add_capability enhancement to prevent damaging config space

2012-06-08 Thread Jan Kiszka
On 2012-06-08 13:16, Alexey Kardashevskiy wrote: > 08.06.2012 20:56, Jan Kiszka написал: >> On 2012-06-08 10:47, Alexey Kardashevskiy wrote: >>> Yet another try :) >>> >>> Normally the pci_add_capability is called on devices to add new >>> capability. This is ok for emulated devices which capabilit

Re: [Qemu-devel] [RFC] Proposal: PCI/PCIe: inbound BAR0 emulation for PCI controller (Root Complex)

2012-06-08 Thread Bhushan Bharat-R65777
Just adding Alex Graf and qemu-ppc@. Will add my response in reply. > -Original Message- > From: Benjamin Herrenschmidt [mailto:b...@kernel.crashing.org] > Sent: Friday, June 08, 2012 4:32 PM > To: Bhushan Bharat-R65777 > Cc: qemu-devel@nongnu.org; Wood Scott-B07421; Yoder Stuart-B08248

Re: [Qemu-devel] [PATCH qom-next 04/59] pc: Add CPU as /machine/cpu[n]

2012-06-08 Thread Igor Mammedov
On Fri, Jun 08, 2012 at 12:36:18PM +0200, Andreas Färber wrote: > Am 08.06.2012 12:21, schrieb Jan Kiszka: > > On 2012-06-08 11:11, Andreas Färber wrote: > >> >From what I understand about the x86 modeling, the only case this > >> matters is if you hot-unplug CPU 0, right? Question is, what happens

Re: [Qemu-devel] [PATCH] s390x: fix s390 virtio aliases

2012-06-08 Thread Alexander Graf
On 31.05.2012, at 12:42, Christian Borntraeger wrote: > On 18/05/12 02:43, Alexander Graf wrote: >> Some of the virtio devices have the same frontend name, but actually >> implement different devices behind the scenes through aliases. >> >> The indicator which device type to use is the architect

Re: [Qemu-devel] [PATCH qom-next 2/7] qom: Add get_id

2012-06-08 Thread Eric Blake
On 06/08/2012 01:44 AM, Anthony Liguori wrote: > Since qdev->id is NULL 90% of the time, I don't think a user can > realistically rely on it. I don't think changing the type of the data > in the error is going to be a problem. > > Doesn't libvirt ignore the contents of an error object? Libvirt

Re: [Qemu-devel] [PATCH 11/13] Move pci_parse_devaddr to qdev-properties

2012-06-08 Thread Andreas Färber
Am 08.06.2012 12:57, schrieb Jan Kiszka: > On 2012-06-07 17:56, Andreas Färber wrote: >> Am 07.06.2012 17:11, schrieb Jan Kiszka: >>> On 2012-06-07 14:57, Andreas Färber wrote: These last three patches collide with Paolo's QOM properties refactoring: qdev properties are being generalized

Re: [Qemu-devel] [PATCH qom-next 04/59] pc: Add CPU as /machine/cpu[n]

2012-06-08 Thread Igor Mammedov
On Fri, Jun 08, 2012 at 11:11:11AM +0200, Andreas Färber wrote: > Am 08.06.2012 10:20, schrieb Igor Mammedov: > > On Wed, May 23, 2012 at 05:07:27AM +0200, Andreas Färber wrote: > > This is touching on a core QOM question: Can we link<> during initfn? > That's what you're trying to do for the APIC

Re: [Qemu-devel] [PATCH] xtensa_lx60: add missing #include "blockdev.h"

2012-06-08 Thread Stefan Weil
Am 08.06.2012 12:57, schrieb Stefan Hajnoczi: On Fri, Jun 8, 2012 at 11:43 AM, Stefan Weil wrote: Am 08.06.2012 12:08, schrieb Stefan Hajnoczi: On Fri, Jun 8, 2012 at 10:50 AM, Max Filippovwrote: This should fix the following build failure: /home/buildbot/slave-public/block_mingw32/bui

Re: [Qemu-devel] [PATCH 4/6] qemu-log: use LOG_UNIMP for some target CPU cases

2012-06-08 Thread Alexander Graf
On 03.06.2012, at 19:38, Blue Swirl wrote: > Use LOG_UNIMP for some target CPU cases. Looks reasonable to me. Acked-by: Alexander Graf Alex

Re: [Qemu-devel] [PATCH 11/13] Move pci_parse_devaddr to qdev-properties

2012-06-08 Thread Jan Kiszka
On 2012-06-08 14:03, Andreas Färber wrote: > Am 08.06.2012 12:57, schrieb Jan Kiszka: >> On 2012-06-07 17:56, Andreas Färber wrote: >>> Am 07.06.2012 17:11, schrieb Jan Kiszka: On 2012-06-07 14:57, Andreas Färber wrote: > These last three patches collide with Paolo's QOM properties >

Re: [Qemu-devel] [PATCH 11/13] Move pci_parse_devaddr to qdev-properties

2012-06-08 Thread Andreas Färber
Am 08.06.2012 14:14, schrieb Jan Kiszka: > On 2012-06-08 14:03, Andreas Färber wrote: >> Can't understand that you're trying to push your v1 so hard now when our >> series have been on the list for much longer. ;) > > I explained the reason, and I think my patches (minus the dropped one) > are rea

Re: [Qemu-devel] [PATCH qom-next 04/59] pc: Add CPU as /machine/cpu[n]

2012-06-08 Thread Andreas Färber
Am 08.06.2012 13:36, schrieb Igor Mammedov: > On Fri, Jun 08, 2012 at 12:36:18PM +0200, Andreas Färber wrote: >> Am 08.06.2012 12:21, schrieb Jan Kiszka: >>> On 2012-06-08 11:11, Andreas Färber wrote: >From what I understand about the x86 modeling, the only case this matters is if you hot

Re: [Qemu-devel] [PATCH qom-next 04/59] pc: Add CPU as /machine/cpu[n]

2012-06-08 Thread Andreas Färber
Am 08.06.2012 14:05, schrieb Igor Mammedov: > On Fri, Jun 08, 2012 at 11:11:11AM +0200, Andreas Färber wrote: >> Another factor that is making this slightly difficult is that there are >> three APIC subclasses. Currently they all have an instance_size of >> sizeof(APICCommonState) so it could be cr

Re: [Qemu-devel] [PATCH qom-next 04/59] pc: Add CPU as /machine/cpu[n]

2012-06-08 Thread Jan Kiszka
On 2012-06-08 14:34, Andreas Färber wrote: > Am 08.06.2012 14:05, schrieb Igor Mammedov: >> On Fri, Jun 08, 2012 at 11:11:11AM +0200, Andreas Färber wrote: >>> Another factor that is making this slightly difficult is that there are >>> three APIC subclasses. Currently they all have an instance_size

Re: [Qemu-devel] CoW image commit+shrink(= make_empty) support

2012-06-08 Thread Stefan Hajnoczi
On Thu, Jun 7, 2012 at 3:14 PM, Jeff Cody wrote: > On 06/07/2012 02:19 AM, Taisuke Yamada wrote: >> I attended Paolo Bonzini's qemu session ("Live Disk Operations: Juggling >> Data and Trying to go Unnoticed") in LinuxCon Japan, and he adviced me >> to post the bits I have regarding my question on

Re: [Qemu-devel] [PATCH] xtensa_lx60: add missing #include "blockdev.h"

2012-06-08 Thread Stefan Hajnoczi
On Fri, Jun 8, 2012 at 1:05 PM, Stefan Weil wrote: > Am 08.06.2012 12:57, schrieb Stefan Hajnoczi: > >> On Fri, Jun 8, 2012 at 11:43 AM, Stefan Weil  wrote: >>> >>> Am 08.06.2012 12:08, schrieb Stefan Hajnoczi: >>> On Fri, Jun 8, 2012 at 10:50 AM, Max Filippov  wrote: > > > T

Re: [Qemu-devel] [PATCH 11/13] Move pci_parse_devaddr to qdev-properties

2012-06-08 Thread Jan Kiszka
On 2012-06-08 14:18, Andreas Färber wrote: > Am 08.06.2012 14:14, schrieb Jan Kiszka: >> On 2012-06-08 14:03, Andreas Färber wrote: >>> Can't understand that you're trying to push your v1 so hard now when our >>> series have been on the list for much longer. ;) >> >> I explained the reason, and I t

Re: [Qemu-devel] [PATCH 05/31] dt: add helper for phandle enumeration

2012-06-08 Thread Alexander Graf
On 07.06.2012, at 02:28, Peter Crosthwaite wrote: > On Thu, Jun 7, 2012 at 1:58 AM, Alexander Graf wrote: >> On 06/06/2012 07:11 AM, Peter Crosthwaite wrote: >>> >>> On Wed, 2012-06-06 at 01:52 +0200, Alexander Graf wrote: This patch adds a helper to search for a node's phandle by it

Re: [Qemu-devel] [PATCH qom-next 04/59] pc: Add CPU as /machine/cpu[n]

2012-06-08 Thread Igor Mammedov
- Original Message - > From: "Jan Kiszka" > To: "Andreas Färber" > Cc: "Igor Mammedov" , "Anthony Liguori" > , qemu-devel@nongnu.org, "Igor > Mammedov" , "Paolo Bonzini" > Sent: Friday, June 8, 2012 2:36:53 PM > Subject: Re: [Qemu-devel] [PATCH qom-next 04/59] pc: Add CPU as > /m

[Qemu-devel] [PATCH v2 06/13] pci: Add INTx routing notifier

2012-06-08 Thread Jan Kiszka
This per-device notifier shall be triggered by any interrupt router along the path of a device's legacy interrupt signal on routing changes. For simplicity reasons and as this is a slow path anyway, no further details on the routing changes are provided. Instead, the callback is expected to use pci

Re: [Qemu-devel] [PATCH qom-next 04/59] pc: Add CPU as /machine/cpu[n]

2012-06-08 Thread Jan Kiszka
On 2012-06-08 14:47, Igor Mammedov wrote: > - Original Message - >> From: "Jan Kiszka" >> To: "Andreas Färber" >> Cc: "Igor Mammedov" , "Anthony Liguori" >> , qemu-devel@nongnu.org, "Igor >> Mammedov" , "Paolo Bonzini" >> Sent: Friday, June 8, 2012 2:36:53 PM >> Subject: Re: [Qemu-devel

Re: [Qemu-devel] [PATCH v3 08/16] target-or32: Add translation routines

2012-06-08 Thread Max Filippov
Hi Jia. On Fri, Jun 8, 2012 at 4:00 AM, Jia Liu wrote: [...] >>> +    case 0x0009: >>> +        switch (op1) { >>> +        case 0x03:   /*l.div*/ >>> +            LOG_DIS("l.div r%d, r%d, r%d\n", rd, ra, rb); >>> +            { >>> +                TCGv_i32 sr_ove; >>> +                int lab

Re: [Qemu-devel] [Qemu-ppc] [PATCH 02/31] dt: add helpers for 2, 3 and 4 cell adds

2012-06-08 Thread Alexander Graf
On 07.06.2012, at 14:13, David Gibson wrote: > On Thu, Jun 07, 2012 at 01:27:56PM +0200, Alexander Graf wrote: >> >> On 07.06.2012, at 01:45, David Gibson wrote: >> >>> [snip] > You mean internally? Yeah, probably. Externally? The point of these > helpers is to make the code look less c

Re: [Qemu-devel] [PATCH] xtensa_lx60: add missing #include "blockdev.h"

2012-06-08 Thread Kevin Wolf
Am 08.06.2012 14:05, schrieb Stefan Weil: > Am 08.06.2012 12:57, schrieb Stefan Hajnoczi: >> On Fri, Jun 8, 2012 at 11:43 AM, Stefan Weil wrote: >>> Am 08.06.2012 12:08, schrieb Stefan Hajnoczi: >>> On Fri, Jun 8, 2012 at 10:50 AM, Max Filippovwrote: > > This should fix the follow

Re: [Qemu-devel] [PATCH qom-next 04/59] pc: Add CPU as /machine/cpu[n]

2012-06-08 Thread Andreas Färber
Am 08.06.2012 14:52, schrieb Jan Kiszka: > On 2012-06-08 14:47, Igor Mammedov wrote: >> - Original Message - >>> From: "Jan Kiszka" >>> To: "Andreas Färber" >>> Cc: "Igor Mammedov" , "Anthony Liguori" >>> , qemu-devel@nongnu.org, "Igor >>> Mammedov" , "Paolo Bonzini" >>> Sent: Friday, J

Re: [Qemu-devel] [RFC] QOMification of AXI stream

2012-06-08 Thread Paul Brook
> On 8 June 2012 10:13, Paul Brook wrote: > > Of course we then hit the usual problem with QOM that we can only link to > > objects, and it's impossible to expose multiple interfaces of the same > > type. > > I'm pretty sure Anthony claimed this was entirely possible -- > presumably that's how Pi

Re: [Qemu-devel] [PATCH 1/3] qmp/hmp: Add QMP getfd command that returns fd

2012-06-08 Thread Corey Bryant
On 06/08/2012 06:46 AM, Daniel P. Berrange wrote: On Wed, Jun 06, 2012 at 10:04:23AM -0400, Corey Bryant wrote: On 06/05/2012 02:30 PM, Luiz Capitulino wrote: On Mon, 4 Jun 2012 09:10:08 -0400 Corey Bryant wrote: This patch adds QMP support for the getfd command using the QAPI framewor

Re: [Qemu-devel] CoW image commit+shrink(= make_empty) support

2012-06-08 Thread Jeff Cody
On 06/08/2012 08:42 AM, Stefan Hajnoczi wrote: > On Thu, Jun 7, 2012 at 3:14 PM, Jeff Cody wrote: >> On 06/07/2012 02:19 AM, Taisuke Yamada wrote: >>> I attended Paolo Bonzini's qemu session ("Live Disk Operations: Juggling >>> Data and Trying to go Unnoticed") in LinuxCon Japan, and he adviced me

Re: [Qemu-devel] [PATCH v4 06/16] net: Remove vlan qdev property

2012-06-08 Thread Stefan Hajnoczi
On Mon, Jun 4, 2012 at 6:29 AM, wrote: > From: Stefan Hajnoczi > > The vlan feature is implemented using hubs and no longer uses > special-purpose VLANState structs that are accessible as qdev > properties. > > Signed-off-by: Stefan Hajnoczi > Signed-off-by: Zhi Yong Wu > --- >  hw/qdev-proper

Re: [Qemu-devel] [PULL 1.2 00/16] hub-based networking patches

2012-06-08 Thread Stefan Hajnoczi
On Mon, Jun 4, 2012 at 9:30 AM, Stefan Hajnoczi wrote: > On Mon, Jun 04, 2012 at 01:23:10PM +0800, Zhi Yong Wu wrote: >> On Mon, Jun 4, 2012 at 12:51 PM, Anthony Liguori wrote: >> > On 06/04/2012 10:46 AM, zwu.ker...@gmail.com wrote: >> >> >> >> From: Zhi Yong Wu >> >> >> >> All comments from oth

Re: [Qemu-devel] [PATCH v3 08/16] target-or32: Add translation routines

2012-06-08 Thread Andreas Färber
Am 08.06.2012 14:56, schrieb Max Filippov: > On Fri, Jun 8, 2012 at 4:00 AM, Jia Liu wrote: > >>{ >>TCGv_i64 t0 = tcg_temp_new(); >>TCGv_i64 t1 = tcg_temp_new(); >>TCGv_i64 t2 = tcg_temp_new(); >>tcg_gen_mul_tl(t0, cpu_R[ra], cpu_R[rb]); >

Re: [Qemu-devel] [PATCH v3 08/16] target-or32: Add translation routines

2012-06-08 Thread Andreas Färber
Am 08.06.2012 15:28, schrieb Andreas Färber: > Am 08.06.2012 14:56, schrieb Max Filippov: >> On Fri, Jun 8, 2012 at 4:00 AM, Jia Liu wrote: >> >>>{ >>>TCGv_i64 t0 = tcg_temp_new(); >>>TCGv_i64 t1 = tcg_temp_new(); >>>TCGv_i64 t2 = tcg_temp_new(); >>>

Re: [Qemu-devel] [PATCH] MIPS/user: Fix reset CPU state initialization

2012-06-08 Thread Meador Inge
On 06/07/2012 08:04 PM, Maciej W. Rozycki wrote: > This change updates the CPU reset sequence to use a common piece of code > that figures out CPU state flags, fixing the problem with MIPS_HFLAG_COP1X > not being set where applicable that causes floating-point MADD family > instructions (and o

Re: [Qemu-devel] [RFC] QOMification of AXI stream

2012-06-08 Thread Anthony Liguori
On 06/08/2012 09:13 PM, Paul Brook wrote: On 8 June 2012 10:13, Paul Brook wrote: Of course we then hit the usual problem with QOM that we can only link to objects, and it's impossible to expose multiple interfaces of the same type. I'm pretty sure Anthony claimed this was entirely possible -

Re: [Qemu-devel] [PATCH 0/4] linux-user: Option parser cleanup

2012-06-08 Thread Meador Inge
Ping ^ 3. On 05/07/2012 09:44 AM, Meador Inge wrote: > Ping ^ 2. > > On 04/04/2012 09:30 PM, Meador Inge wrote: >> Ping. Any comments on this series? >> >> On 03/27/2012 05:44 PM, Meador Inge wrote: >>> This series is focused at cleaning up a few issues in the >>> GNU/Linux usermode driver's opt

Re: [Qemu-devel] [RFC] QOMification of AXI stream

2012-06-08 Thread Anthony Liguori
On 06/08/2012 05:13 PM, Paul Brook wrote: Im looking to QOMifying and refactoring the AXI stream interfaces between the AXI ethernet and AXI DMA modules. I could use some guidance on how to do this as I can think of about 6 different solutions. Sources are hw/xilinx_axienet.c and hw/xilinx_axidma

Re: [Qemu-devel] [RFC] QOMification of AXI stream

2012-06-08 Thread Paul Brook
> >> So what im proposing is AXI stream is implemented as a unidirectional > >> point to point bus. The xilinx ethernet system would consist of two of > >> these buses one for tx, one for rx. > > > > I thought the idea was that with QOM the bus/device model would go away. > > The DMA controller im

Re: [Qemu-devel] CoW image commit+shrink(= make_empty) support

2012-06-08 Thread Stefan Hajnoczi
On Fri, Jun 8, 2012 at 2:19 PM, Jeff Cody wrote: > On 06/08/2012 08:42 AM, Stefan Hajnoczi wrote: >> On Thu, Jun 7, 2012 at 3:14 PM, Jeff Cody wrote: >>> On 06/07/2012 02:19 AM, Taisuke Yamada wrote: >> We want to commit snap1.qcow2 down into vm001.img while the guest is running: >> >> vm001.img

Re: [Qemu-devel] [Xen-devel] [PATCH, v3] qemu/xendisk: set maximum number of grants to be used

2012-06-08 Thread Ian Jackson
Stefano Stabellini writes ("Re: [Xen-devel] [PATCH, v3] qemu/xendisk: set maximum number of grants to be used"): > On Thu, 31 May 2012, Jan Beulich wrote: > > > It should be applied to qemu-xen-traditional too. > > > > And the other one ("qemu/xendisk: properly update stats in > > ioreq_release()

Re: [Qemu-devel] [RFC] QOMification of AXI stream

2012-06-08 Thread Peter Maydell
On 8 June 2012 14:41, Anthony Liguori wrote: > On 06/08/2012 05:13 PM, Paul Brook wrote: >> Of course we then hit the usual problem with QOM that we can only link to >> objects, and it's impossible to expose multiple interfaces of the same >> type. > No, QOM supports multiple inheritance of inter

Re: [Qemu-devel] [PATCH 11/13] Move pci_parse_devaddr to qdev-properties

2012-06-08 Thread Anthony Liguori
On 06/07/2012 08:57 PM, Andreas Färber wrote: Am 04.06.2012 10:52, schrieb Jan Kiszka: We will some use this function also for property parsing, so move it over unmodified and rename it. Signed-off-by: Jan Kiszka These last three patches collide with Paolo's QOM properties refactoring: qdev p

Re: [Qemu-devel] [PATCH v3 7/7] qcow2: always operate caches in writeback mode

2012-06-08 Thread Kevin Wolf
Am 06.06.2012 00:04, schrieb Paolo Bonzini: > Writethrough does not need special-casing anymore in the qcow2 caches. > The block layer adds flushes after every guest-initiated data write, > and these will also flush the qcow2 caches to the OS. > > Signed-off-by: Paolo Bonzini > diff --git a/bloc

Re: [Qemu-devel] [RFC] QOMification of AXI stream

2012-06-08 Thread Paul Brook
> >>> Of course we then hit the usual problem with QOM that we can only link > >>> to objects, and it's impossible to expose multiple interfaces of the > >>> same type. > >> > >> I'm pretty sure Anthony claimed this was entirely possible -- > >> presumably that's how Pins are going to work. > > >

Re: [Qemu-devel] [PULL v3 00/29] per-directory Makefile.objs snippets, limit vpath (ab)use

2012-06-08 Thread Anthony Liguori
On 06/07/2012 03:39 PM, Paolo Bonzini wrote: The following changes since commit 349417004a0f7cf5518a998dca755cd06f6c212b: Merge remote-tracking branch 'qmp/queue/qmp' into staging (2012-06-06 20:57:56 +0800) are available in the git repository at: Pulled. Thanks. Regards, Anthony Liguo

Re: [Qemu-devel] [RFC PATCH] qemu pci: pci_add_capability enhancement to prevent damaging config space

2012-06-08 Thread Alexey Kardashevskiy
08.06.2012 21:30, Jan Kiszka пишет: > On 2012-06-08 13:16, Alexey Kardashevskiy wrote: >> 08.06.2012 20:56, Jan Kiszka написал: >>> On 2012-06-08 10:47, Alexey Kardashevskiy wrote: Yet another try :) Normally the pci_add_capability is called on devices to add new capability. Thi

Re: [Qemu-devel] [PULL 00/12] Block patches

2012-06-08 Thread Anthony Liguori
On 06/08/2012 05:48 PM, Kevin Wolf wrote: Am 07.06.2012 03:17, schrieb Anthony Liguori: On 06/04/2012 07:13 PM, Kevin Wolf wrote: The following changes since commit 8cc9b43f7c5f826b39af4b012ad89bb55faac29c: target-microblaze: lwx/swx: first implementation (2012-06-04 10:19:46 +0200) are a

Re: [Qemu-devel] [RFC] QOMification of AXI stream

2012-06-08 Thread Anthony Liguori
On 06/08/2012 12:23 PM, Peter Crosthwaite wrote: Hi all, Im looking to QOMifying and refactoring the AXI stream interfaces between the AXI ethernet and AXI DMA modules. I could use some guidance on how to do this as I can think of about 6 different solutions. Sources are hw/xilinx_axienet.c and

Re: [Qemu-devel] [PATCH v5 2/2] net: add the support for -netdev socket, listen

2012-06-08 Thread Zhi Yong Wu
On Fri, Jun 8, 2012 at 6:31 PM, Stefan Hajnoczi wrote: > On Thu, Jun 7, 2012 at 3:54 PM,   wrote: >> @@ -86,7 +82,16 @@ static void net_socket_send(void *opaque) >>         /* end of connection */ >>     eoc: >>         qemu_set_fd_handler(s->fd, NULL, NULL, NULL); >> +        qemu_set_fd_handler(

Re: [Qemu-devel] [PATCH 11/13] Move pci_parse_devaddr to qdev-properties

2012-06-08 Thread Michael S. Tsirkin
On Fri, Jun 08, 2012 at 02:45:47PM +0200, Jan Kiszka wrote: > On 2012-06-08 14:18, Andreas Färber wrote: > > Am 08.06.2012 14:14, schrieb Jan Kiszka: > >> On 2012-06-08 14:03, Andreas Färber wrote: > >>> Can't understand that you're trying to push your v1 so hard now when our > >>> series have been

Re: [Qemu-devel] [RFC] QOMification of AXI stream

2012-06-08 Thread Anthony Liguori
On 06/08/2012 09:59 PM, Paul Brook wrote: Of course we then hit the usual problem with QOM that we can only link to objects, and it's impossible to expose multiple interfaces of the same type. I'm pretty sure Anthony claimed this was entirely possible -- presumably that's how Pins are going to

Re: [Qemu-devel] [PATCH 11/13] Move pci_parse_devaddr to qdev-properties

2012-06-08 Thread Anthony Liguori
On 06/08/2012 10:17 PM, Michael S. Tsirkin wrote: On Fri, Jun 08, 2012 at 02:45:47PM +0200, Jan Kiszka wrote: On 2012-06-08 14:18, Andreas Färber wrote: Am 08.06.2012 14:14, schrieb Jan Kiszka: On 2012-06-08 14:03, Andreas Färber wrote: Can't understand that you're trying to push your v1 so h

Re: [Qemu-devel] [PATCH v5 2/2] net: add the support for -netdev socket, listen

2012-06-08 Thread Stefan Hajnoczi
On Fri, Jun 8, 2012 at 3:15 PM, Zhi Yong Wu wrote: > On Fri, Jun 8, 2012 at 6:31 PM, Stefan Hajnoczi wrote: >> On Thu, Jun 7, 2012 at 3:54 PM,   wrote: >>> @@ -86,7 +82,16 @@ static void net_socket_send(void *opaque) >>>         /* end of connection */ >>>     eoc: >>>         qemu_set_fd_handler

Re: [Qemu-devel] CoW image commit+shrink(= make_empty) support

2012-06-08 Thread Jeff Cody
On 06/08/2012 09:53 AM, Stefan Hajnoczi wrote: > On Fri, Jun 8, 2012 at 2:19 PM, Jeff Cody wrote: >> On 06/08/2012 08:42 AM, Stefan Hajnoczi wrote: >>> On Thu, Jun 7, 2012 at 3:14 PM, Jeff Cody wrote: On 06/07/2012 02:19 AM, Taisuke Yamada wrote: >>> We want to commit snap1.qcow2 down into v

Re: [Qemu-devel] [PATCH v5 2/2] net: add the support for -netdev socket, listen

2012-06-08 Thread Zhi Yong Wu
On Fri, Jun 8, 2012 at 10:20 PM, Stefan Hajnoczi wrote: > On Fri, Jun 8, 2012 at 3:15 PM, Zhi Yong Wu wrote: >> On Fri, Jun 8, 2012 at 6:31 PM, Stefan Hajnoczi wrote: >>> On Thu, Jun 7, 2012 at 3:54 PM,   wrote: @@ -86,7 +82,16 @@ static void net_socket_send(void *opaque)         /* en

Re: [Qemu-devel] [RFC PATCH] qemu pci: pci_add_capability enhancement to prevent damaging config space

2012-06-08 Thread Jan Kiszka
On 2012-06-08 16:00, Alexey Kardashevskiy wrote: > 08.06.2012 21:30, Jan Kiszka пишет: >> On 2012-06-08 13:16, Alexey Kardashevskiy wrote: >>> 08.06.2012 20:56, Jan Kiszka написал: On 2012-06-08 10:47, Alexey Kardashevskiy wrote: > Yet another try :) > > Normally the pci_add_capabi

Re: [Qemu-devel] [PATCH v5 2/2] net: add the support for -netdev socket, listen

2012-06-08 Thread Zhi Yong Wu
On Fri, Jun 8, 2012 at 10:20 PM, Stefan Hajnoczi wrote: > On Fri, Jun 8, 2012 at 3:15 PM, Zhi Yong Wu wrote: >> On Fri, Jun 8, 2012 at 6:31 PM, Stefan Hajnoczi wrote: >>> On Thu, Jun 7, 2012 at 3:54 PM,   wrote: @@ -86,7 +82,16 @@ static void net_socket_send(void *opaque)         /* en

Re: [Qemu-devel] [PATCH v3 0/7] Manual writethrough cache and cache mode toggle

2012-06-08 Thread Stefan Hajnoczi
On Tue, Jun 5, 2012 at 11:04 PM, Paolo Bonzini wrote: > This is v3 of the alternative implementation of writethrough caching > for QEMU 1.2.  By always opening drivers in writethrough mode and s/writethrough/writeback/ > doing flushes manually after every write, it achieves three objectives: St

Re: [Qemu-devel] [PATCH v4 06/16] net: Remove vlan qdev property

2012-06-08 Thread Zhi Yong Wu
On Fri, Jun 8, 2012 at 9:23 PM, Stefan Hajnoczi wrote: > On Mon, Jun 4, 2012 at 6:29 AM,   wrote: >> From: Stefan Hajnoczi >> >> The vlan feature is implemented using hubs and no longer uses >> special-purpose VLANState structs that are accessible as qdev >> properties. >> >> Signed-off-by: Stefa

  1   2   >