On Fri, Jun 8, 2012 at 11:43 AM, Stefan Weil <s...@weilnetz.de> wrote: > Am 08.06.2012 12:08, schrieb Stefan Hajnoczi: > >> On Fri, Jun 8, 2012 at 10:50 AM, Max Filippov<jcmvb...@gmail.com> wrote: >>> >>> This should fix the following build failure: >>> >>> /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c: In >>> function 'lx_init': >>> /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c:212: >>> warning: implicit declaration of function 'drive_get' >>> /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c:212: >>> warning: nested extern declaration of 'drive_get' >>> /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c:212: >>> error: 'IF_PFLASH' undeclared (first use in this function) >>> /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c:212: >>> error: (Each undeclared identifier is reported only once >>> /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c:212: >>> error: for each function it appears in.) >>> /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c:216: >>> error: dereferencing pointer to incomplete type >>> >>> Signed-off-by: Max Filippov<jcmvb...@gmail.com> >>> --- >>> hw/xtensa_lx60.c | 1 + >>> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> Reviewed-by: Stefan Hajnoczi<stefa...@linux.vnet.ibm.com> >> > > > Strange, I don't see this problem here. > > xtensa_lx60.c includes pc.h which includes fdc.h which includes blockdev.h, > so this patch should not be needed.
Please check the buildbot output for more details on the failure: http://buildbot.b1-systems.de/qemu/builders/block_mingw32/builds/237 I still think this patch is an improvement because relying on pc.h -> fdc.h -> blockdev.h to get drive_get() and IF_PFLASH is very obscure and could break in the future if those headers change. Stefan
