[Qemu-devel] [PATCH v2 19/25] build: convert libhw to nested Makefile.objs

2012-06-06 Thread Paolo Bonzini
After this patch, the libhw* directories will have a hierarchy that mimics the source tree. This is useful because we do have a couple of files there that are in the top source directory. Signed-off-by: Paolo Bonzini --- Makefile.hw |6 +-- Makefile.objs | 143 +--

[Qemu-devel] [PATCH v2 08/25] build: move rules for nesting to Makefile.objs

2012-06-06 Thread Paolo Bonzini
At this point we will start adding nesting behavior to other files than Makefile.target. Because Makefile.objs is included by Makefile.target, it is simpler to move the processing of subdirectories there. To enable this, only add per-target files to obj-y. Use a separate variable for the linker

[Qemu-devel] [PATCH v2 03/25] build: add rules for nesting

2012-06-06 Thread Paolo Bonzini
This adds the 'magic' rules that take care of subdirectories. The subdirectory makefiles in the source tree are not complete; they only define some variables (listed in nested-vars) according to the configuration. The magic rules descend into subdirectory makefiles and gather the evaluated values

[Qemu-devel] [PATCH 1/2] kvm: add missing include files

2012-06-06 Thread Paolo Bonzini
These are included via monitor.h right now, add them explicitly. Signed-off-by: Paolo Bonzini --- kvm-all.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/kvm-all.c b/kvm-all.c index 489ee53..831651d 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -22,6 +22,8 @@ #include "qemu-common.h"

[Qemu-devel] [PATCH 0/6] blkdebug changes extracted from 1.2 streaming patches

2012-06-06 Thread Paolo Bonzini
Hi, these patches are prerequisites for testing streaming error handling. They should be useful on their own, so I am sending them early to keep the queue small. Paolo Bonzini (6): blkdebug: remove sync i/o events blkdebug: tiny cleanup blkdebug: pass getlength to underlying file blkdebug

[Qemu-devel] [PATCH v2 13/25] build: move ui/ objects to nested Makefile.objs

2012-06-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.objs| 21 ++--- ui/Makefile.objs | 18 ++ 2 files changed, 20 insertions(+), 19 deletions(-) create mode 100644 ui/Makefile.objs diff --git a/Makefile.objs b/Makefile.objs index 4acdbaa..a6310e3 100644 --- a/Makef

Re: [Qemu-devel] [PATCH v2 6/6] qapi: convert sendkey

2012-06-06 Thread Amos Kong
On 05/06/12 23:05, Eric Blake wrote: On 06/05/2012 08:55 AM, Amos Kong wrote: +# @sendkey: +# +# Send keys to VM. +# +# @keys: key sequence +# @hold-time: time to delay key up events, milliseconds +# +# Returns: Nothing on success +# If key is unknown or redundant, QERR_INVALID_PARAMET

[Qemu-devel] [PATCH v2 24/25] build: compile oslib-obj-y once

2012-06-06 Thread Paolo Bonzini
There is no difference in oslib-obj-y between user-mode and system targets. There used to be when user-mode could optionally be compiled with PIE. Signed-off-by: Paolo Bonzini --- Makefile.objs |3 ++- Makefile.target |2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v2 22/25] build: libcacard Makefile cleanups

2012-06-06 Thread Paolo Bonzini
Build vscclient from toplevel Makefile, limit usage of vpath. Signed-off-by: Paolo Bonzini --- Makefile |4 Makefile.objs |8 +++- Makefile.target|6 -- configure | 12 +--- libcacard/Makefile | 17 ++--- 5 files change

Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor

2012-06-06 Thread Avi Kivity
On 06/05/2012 03:19 PM, Gerd Hoffmann wrote: > Hi, > >> >> >> Suggestion: add a _guest marker for ordinary state. Fail the build on >> unmarked fields. This ensures that some thought is given to each field, >> instead of having a default that may be correct most of the time, but >> not alway

[Qemu-devel] [PATCH v2 23/25] build: limit usage of vpath

2012-06-06 Thread Paolo Bonzini
All paths are now explicitly given, and the object tree mimics the source tree, so there is no need to apply special vpaths. Signed-off-by: Paolo Bonzini --- Makefile|2 +- Makefile.target |5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefil

[Qemu-devel] [PATCH v2 07/25] build: move other target-*/ objects to nested Makefile.objs

2012-06-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.target |6 +++--- target-alpha/Makefile.objs |3 ++- target-arm/Makefile.objs|3 ++- target-cris/Makefile.objs |4 ++-- target-i386/Makefile.objs |5 +++-- target-lm32/Makefile.objs |3

[Qemu-devel] [PATCH 4/6] blkdebug: store list of active rules

2012-06-06 Thread Paolo Bonzini
This prepares for the next patch, where some active rules may actually not trigger depending on input to readv/writev. Store the active rules in a SIMPLEQ (so that it can be emptied easily with QSIMPLEQ_INIT), and fetch the errno/once/immediately arguments from there. Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH v2 02/25] build: do not sprinkle around GENERATED_HEADERS dependencies

2012-06-06 Thread Paolo Bonzini
Keeping GENERATED_HEADERS dependencies up-to-date everywhere is complex. We can simply make the Makefile depend on them, and they will be built before all other targets. Signed-off-by: Paolo Bonzini --- Makefile| 18 +- Makefile.target | 14 -- tests/Makef

Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor

2012-06-06 Thread Kevin Wolf
Am 05.06.2012 18:21, schrieb Michael Roth: > On Tue, Jun 05, 2012 at 11:25:01AM +0200, Kevin Wolf wrote: >> Am 05.06.2012 03:00, schrieb Michael Roth: >>> This is an import of Anthony's qidl compiler, with some changes squashed >>> in to add support for doing the visitor generation via QEMU's qapi

Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor

2012-06-06 Thread Avi Kivity
On 06/06/2012 12:11 AM, Michael Roth wrote: >> >> Is is possible to let the compiler process the .c file, with the IDL >> delimited by some marker? I like how device models are self contained >> in one file now. > > It's possible, but only if we inject the generated visitor code into the > devic

[Qemu-devel] [PATCH v2 05/25] build: move obj-TARGET-y variables to nested Makefile.objs

2012-06-06 Thread Paolo Bonzini
Also drop duplicate occurrence of device-hotplug.o. Signed-off-by: Paolo Bonzini --- Makefile.target | 186 ++ configure| 48 --- hw/alpha/Makefile.objs |4 + hw/arm/Makefile

[Qemu-devel] [PATCH 1/6] blkdebug: remove sync i/o events

2012-06-06 Thread Paolo Bonzini
These are unused, except (by mistake more or less) in QED. Signed-off-by: Paolo Bonzini --- block.h |2 -- block/blkdebug.c |2 -- block/qed.c |2 +- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/block.h b/block.h index bff5a9b..80c1768 100644 --- a/bloc

[Qemu-devel] [PATCH v2 12/25] build: move fsdev/ objects to nested Makefile.objs

2012-06-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile|2 +- Makefile.objs | 11 +-- fsdev/Makefile.objs |9 + 3 files changed, 15 insertions(+), 7 deletions(-) create mode 100644 fsdev/Makefile.objs diff --git a/Makefile b/Makefile index c0ab97a..0c0540d 100644 -

[Qemu-devel] [PATCH v2 20/25] build: move per-target hw/ objects to nested Makefile.objs

2012-06-06 Thread Paolo Bonzini
This completes the move to nested Makefile.objs for virtio and a few other files that were not part of obj-TARGET-y, but still were compiled separately for each target. Signed-off-by: Paolo Bonzini --- Makefile.hw |5 +++-- Makefile.target | 31 +

[Qemu-devel] [PATCH v2 21/25] build: move device tree to per-target Makefile

2012-06-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.target |7 --- hw/arm/Makefile.objs|1 + hw/microblaze/Makefile.objs |1 + hw/ppc/Makefile.objs|1 + 4 files changed, 3 insertions(+), 7 deletions(-) diff --git a/Makefile.target b/Makefile.target index be0

[Qemu-devel] [PATCH v2 15/25] build: move slirp/ objects to nested Makefile.objs

2012-06-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.objs |5 + slirp/Makefile.objs |3 +++ 2 files changed, 4 insertions(+), 4 deletions(-) create mode 100644 slirp/Makefile.objs diff --git a/Makefile.objs b/Makefile.objs index 7ee2bb6..668c148 100644 --- a/Makefile.objs +++ b/Makefile.

[Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time

2012-06-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 35 ++- rules.mak |1 + 2 files changed, 3 insertions(+), 33 deletions(-) diff --git a/configure b/configure index 301b574..07e3ff1 100755 --- a/configure +++ b/configure @@ -3672,26 +3672,6 @@ if [ "$TARGET_BASE_

Re: [Qemu-devel] [PATCH 11/17] qapi: add qidl-generated qapi schema for rtc

2012-06-06 Thread Kevin Wolf
Am 05.06.2012 18:03, schrieb Michael Roth: > On Tue, Jun 05, 2012 at 11:29:24AM +0200, Kevin Wolf wrote: >> Am 05.06.2012 03:00, schrieb Michael Roth: >>> Signed-off-by: Michael Roth >>> --- >>> qidl-generated/mc146818rtc.json |1 + >>> 1 files changed, 1 insertions(+), 0 deletions(-) >>> cr

[Qemu-devel] [PATCH v2 17/25] build: move qga/ objects to nested Makefile.objs

2012-06-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.objs |7 ++- qga/Makefile.objs |3 +++ 2 files changed, 5 insertions(+), 5 deletions(-) create mode 100644 qga/Makefile.objs diff --git a/Makefile.objs b/Makefile.objs index e7f7a85..fec21a4 100644 --- a/Makefile.objs +++ b/Makefile.objs

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-06 Thread Benjamin Herrenschmidt
On Wed, 2012-06-06 at 10:52 +0800, li zhang wrote: > Hi Anthony, > > > Any comment on this? Allright, this is all quite confusing... He's what I think should happen: When no option is passed -at-all-, we should have vga std and usb ohci + usb mouse + usb ps2. When -nodefault is passed, we sh

[Qemu-devel] [PATCH v2 16/25] build: move qapi/ objects to nested Makefile.objs

2012-06-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.objs |6 ++ qapi/Makefile.objs |3 +++ 2 files changed, 5 insertions(+), 4 deletions(-) create mode 100644 qapi/Makefile.objs diff --git a/Makefile.objs b/Makefile.objs index 668c148..e7f7a85 100644 --- a/Makefile.objs +++ b/Makefile.ob

[Qemu-devel] [PATCH v2 10/25] build: move block/ objects to nested Makefile.objs

2012-06-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.objs | 16 ++-- block/Makefile.objs | 11 +++ 2 files changed, 13 insertions(+), 14 deletions(-) create mode 100644 block/Makefile.objs diff --git a/Makefile.objs b/Makefile.objs index ef49a09..3285949 100644 --- a/Makefile

[Qemu-devel] [PATCH v2 14/25] build: move audio/ objects to nested Makefile.objs

2012-06-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.objs | 18 ++ audio/Makefile.objs | 14 ++ 2 files changed, 16 insertions(+), 16 deletions(-) create mode 100644 audio/Makefile.objs diff --git a/Makefile.objs b/Makefile.objs index a6310e3..7ee2bb6 100644 --- a/Mak

Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor

2012-06-06 Thread Avi Kivity
On 06/06/2012 02:51 AM, Anthony Liguori wrote: >>> +during device construction and never changes. This means we can add an >>> +**_immutable** marker to it: >> >> Even if it does change (suppose we add a monitor command to retarget a >> the serial device's chardev), it need not be migrated since i

Re: [Qemu-devel] [PATCH 16/17] qidl: add qidl-generated vmstate fields for rtc

2012-06-06 Thread Avi Kivity
On 06/06/2012 02:38 AM, Anthony Liguori wrote: > On 06/05/2012 06:26 PM, Avi Kivity wrote: >> On 06/05/2012 04:00 AM, Michael Roth wrote: >>> Initial check-in of the qidl-generated vmstate fields for rtc. >>> >> >> Don't, please. > > As Mike said in another note, we want to keep the device schema

[Qemu-devel] [PATCH v2 06/25] build: move libobj-y variable to nested Makefile.objs

2012-06-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.target | 41 +++ configure |6 -- target-alpha/Makefile.objs |3 ++- target-arm/Makefile.objs|4 target-cris/Makefile.objs |5 - ta

Re: [Qemu-devel] Sporadic AHCI boot failures

2012-06-06 Thread Avi Kivity
On 06/05/2012 10:08 PM, Jan Kiszka wrote: >>> >>> Do things work again after system_reset on the monitor? Maybe the reset >>> function is just broken and we finish some asynchronous stuff after reset? >> >> The problem both occurs after power on as well as reset. Sometimes it >> takes multiple sy

[Qemu-devel] [PATCH 3/6] blkdebug: pass getlength to underlying file

2012-06-06 Thread Paolo Bonzini
This is required when using blkdebug with raw format. Unlike qcow2/QED, raw asks blkdebug for the length of the file, it doesn't get it from a header. Signed-off-by: Paolo Bonzini --- block/blkdebug.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/block/blkdebug.c b/block/blkdebug

[Qemu-devel] [PATCH v2 11/25] build: move net/ objects to nested Makefile.objs

2012-06-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.objs | 17 + net/Makefile.objs | 12 2 files changed, 13 insertions(+), 16 deletions(-) create mode 100644 net/Makefile.objs diff --git a/Makefile.objs b/Makefile.objs index 3285949..f40be38 100644 --- a/Makefile.obj

[Qemu-devel] [PATCH v2 18/25] build: move target-independent hw/ objects to nested Makefiles

2012-06-06 Thread Paolo Bonzini
This patch starts converting the hw/ directory. Some files in hw/ are compiled once, some twice (32-/64-bit), some once per target. Each category is moved in a separate patch. After this patch, the files that are compiled once will show the same hierarchy in the build tree as they do in the sourc

[Qemu-devel] [PATCH v2 01/25] build: remove trace-nested-y

2012-06-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.objs | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index 70c5c79..1daa92c 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -425,16 +425,11 @@ ifneq ($(TRACE_BACKEND),dtrace) trace-obj-y

Re: [Qemu-devel] [PATCH 0/2] Two small fixes to the streaming test case.

2012-06-06 Thread Kevin Wolf
Am 06.06.2012 01:10, schrieb Paolo Bonzini: > Hi Kevin, please take a look at the attached simple patches. > > Paolo > > Paolo Bonzini (2): > qemu-iotests: fill streaming test image with data > qemu-iotests: start vms in qtest mode > > tests/qemu-iotests/030| 15 +-- >

Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor

2012-06-06 Thread Anthony Liguori
On 06/06/2012 03:45 PM, Avi Kivity wrote: On 06/06/2012 02:51 AM, Anthony Liguori wrote: +during device construction and never changes. This means we can add an +**_immutable** marker to it: Even if it does change (suppose we add a monitor command to retarget a the serial device's chardev), i

[Qemu-devel] [Bug 1007269] Re: Can’t install or boot up 32bit win8 guest.

2012-06-06 Thread Yongjie Ren
64bit Win8 client can work fine as a kvm guest, however, 32bit can't work. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1007269 Title: Can’t install or boot up 32bit win8 guest. Status in QEMU:

Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor

2012-06-06 Thread Avi Kivity
On 06/06/2012 11:27 AM, Anthony Liguori wrote: > On 06/06/2012 03:45 PM, Avi Kivity wrote: >> On 06/06/2012 02:51 AM, Anthony Liguori wrote: > +during device construction and never changes. This means we can > add an > +**_immutable** marker to it: Even if it does change (sup

Re: [Qemu-devel] [PATCH v2] kvm: Fix build for non-CAP_IRQ_ROUTING targets

2012-06-06 Thread Avi Kivity
On 06/05/2012 10:03 PM, Jan Kiszka wrote: > A type definition and a KVMState field initialization escaped the > required wrapping with KVM_CAP_IRQ_ROUTING. Also, we need to provide a > dummy kvm_irqchip_release_virq as virtio-pci references (but does not > use) it. > Thanks, applied. -- error

Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor

2012-06-06 Thread Anthony Liguori
On 06/06/2012 04:37 PM, Avi Kivity wrote: On 06/06/2012 11:27 AM, Anthony Liguori wrote: On 06/06/2012 03:45 PM, Avi Kivity wrote: I think you meant to add a const in there, but yeah, I know. Maybe also a _stupid. How can one get a one line example wrong by omitting the important word out of

Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time

2012-06-06 Thread Anthony Liguori
This results in failures to create symlinks in a new build directory. The following patch seems to resolve it though. Regards, Anthony Liguori On 06/06/2012 02:36 PM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- configure | 35 ++- rules.mak |

Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor

2012-06-06 Thread Avi Kivity
On 06/06/2012 11:45 AM, Anthony Liguori wrote: >> Ok. But then the backend pointer is not 'const Backend * const', it's >> 'Backend * const' (if we don't allow retargeting). So we can't say it's >> _immutable (and it isn't). It's _host. > > 'Backend * const' is immutable > > That is, the *poin

[Qemu-devel] [PATCH] configure: fix -enable-debug with newer toolchains

2012-06-06 Thread Avi Kivity
Fedora 17's toolchain wants optimization enabled for _FORTIFY_SOURCE; so disable _FORTIFY_SOURCE when debugging. Signed-off-by: Avi Kivity --- configure |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index 1f338f8..88d9c5b 100755 --- a/configure ++

[Qemu-devel] [PULL] Fix for ppc build breakage

2012-06-06 Thread Avi Kivity
Please pull from: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master Jan Kiszka (1): kvm: Fix build for non-CAP_IRQ_ROUTING targets kvm-all.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions

[Qemu-devel] Singlestepping does not work

2012-06-06 Thread Wacha Gábor
Dear developers, I have created a vmstate change handler, which logs RUN_STATE_DEBUG states, which is (as far as I know) used when one singlesteps the processor. Apparently this handler is not called, not even when I run qemu-system-microblaze with the -singlestep option. What am I missing? Regar

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Yonit Halperin
Hi, I would like to add some more points to Gerd's explanation: On 06/05/2012 04:15 PM, Gerd Hoffmann wrote: Hi, Absolutely not. This is hideously ugly and affects a bunch of code. Spice is *not* getting a hook in migration where it gets to add arbitrary amounts of downtime to the migrati

Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor

2012-06-06 Thread Anthony Liguori
On 06/06/2012 04:59 PM, Avi Kivity wrote: On 06/06/2012 11:45 AM, Anthony Liguori wrote: Ok. But then the backend pointer is not 'const Backend * const', it's 'Backend * const' (if we don't allow retargeting). So we can't say it's _immutable (and it isn't). It's _host. 'Backend * const' is

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Anthony Liguori
On 06/06/2012 05:10 PM, Yonit Halperin wrote: Hi, I would like to add some more points to Gerd's explanation: On 06/05/2012 04:15 PM, Gerd Hoffmann wrote: Hi, Absolutely not. This is hideously ugly and affects a bunch of code. Spice is *not* getting a hook in migration where it gets to add a

Re: [Qemu-devel] [PATCH v2 00/25] per-directory Makefile.objs snippets, limit vpath (ab)use

2012-06-06 Thread Anthony Liguori
On 06/06/2012 02:36 PM, Paolo Bonzini wrote: Here is v2 of the nested Makefile patches. Thanks all for the enthusiasm! The main change is that rules can now be put in the per-directory snippets. This is done for op_helper.o already. Paolo v1->v2: do not call nested files "Makefile" (

Re: [Qemu-devel] [PATCH] configure: fix -enable-debug with newer toolchains

2012-06-06 Thread Peter Maydell
On 6 June 2012 10:03, Avi Kivity wrote: > Fedora 17's toolchain wants optimization enabled for _FORTIFY_SOURCE; > so disable _FORTIFY_SOURCE when debugging. Well, that sucks, but it seems to be a deliberate change in upstream glibc to make it warn now :-( I guess everybody in the world will have

Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor

2012-06-06 Thread Avi Kivity
On 06/06/2012 12:17 PM, Anthony Liguori wrote: >> >> So, is it reasonable to say >> >>uint32_t * _immutable irrp; // Interrupt Request Register >> >> and allocate it on the heap during initialization? > > No, this would be wrong. > > '_immutable' means that the *state* is immutable from the

Re: [Qemu-devel] kernel panic with bridge

2012-06-06 Thread Stefan Hajnoczi
On Wed, Jun 6, 2012 at 4:38 AM, Charles.Tsai-蔡清海-研究發展部 wrote: > We hit a kernel panic when a VM was configured with bridge mode. After the > IpTable was disabled using the following command lines, the kernel panic was > gone. We would like to know if there is any fix in latest kernel for this > is

Re: [Qemu-devel] Any approach to log the file read/write (I/O data flow) like the "-d in_asm" option?

2012-06-06 Thread Stefan Hajnoczi
On Sun, Jun 3, 2012 at 9:50 PM, Yue Chen wrote: > I'm doing something like a simple and lightweight REPLAY program out of > QEMU, only including CPU, MEMORY, and DISK. I'm implementing it with a > shadow CPU (register state), shadow memory(from "pmemsave") and shadow > ".img" file (disk). Why doe

Re: [Qemu-devel] [PATCH v2] kvm: Fix build for non-CAP_IRQ_ROUTING targets

2012-06-06 Thread Jan Kiszka
On 2012-06-06 10:41, Avi Kivity wrote: > On 06/05/2012 10:03 PM, Jan Kiszka wrote: >> A type definition and a KVMState field initialization escaped the >> required wrapping with KVM_CAP_IRQ_ROUTING. Also, we need to provide a >> dummy kvm_irqchip_release_virq as virtio-pci references (but does not

Re: [Qemu-devel] [PATCH block-next 0/3] qemu-img check/qcow2: Allow fixing refcounts

2012-06-06 Thread Stefan Hajnoczi
On Fri, Jun 1, 2012 at 9:26 AM, Zhi Yong Wu wrote: > On Fri, Jun 1, 2012 at 4:06 PM, Stefan Hajnoczi wrote: >> On Fri, Jun 1, 2012 at 6:22 AM, Zhi Yong Wu wrote: >>> On Thu, May 31, 2012 at 5:26 PM, Stefan Hajnoczi wrote: On Wed, May 30, 2012 at 9:31 AM, Zhi Yong Wu wrote: > On Sat, M

Re: [Qemu-devel] [PATCH v2] fdc: fix media change detection for windows

2012-06-06 Thread Kevin Wolf
Am 05.06.2012 18:34, schrieb Pavel Hrdina: > On 06/05/2012 05:56 PM, Kevin Wolf wrote: >> Am 05.06.2012 17:50, schrieb Pavel Hrdina: >>> Sorry, I forget the qtest. I'll create it and send it again. >>> >>> Pavel >>> >>> On 06/05/2012 05:46 PM, Pavel Hrdina wrote: The Windows uses 'READ' comman

Re: [Qemu-devel] [PATCH v2] kvm: Fix build for non-CAP_IRQ_ROUTING targets

2012-06-06 Thread Avi Kivity
On 06/06/2012 01:31 PM, Jan Kiszka wrote: > On 2012-06-06 10:41, Avi Kivity wrote: >> On 06/05/2012 10:03 PM, Jan Kiszka wrote: >>> A type definition and a KVMState field initialization escaped the >>> required wrapping with KVM_CAP_IRQ_ROUTING. Also, we need to provide a >>> dummy kvm_irqchip_rele

[Qemu-devel] [BUG QEMU 1.1] virtio-9p-handle does not compile

2012-06-06 Thread Stefano Stabellini
Hi Anthony, currently QEMU 1.1 doesn't compile virtfs correctly on Ubuntu: qemu/hw/9pfs/virtio-9p-handle.c: In function ‘handle_update_file_cred’: qemu/hw/9pfs/virtio-9p-handle.c:66:58: error: ‘AT_EMPTY_PATH’ undeclared (first use in this function) qemu/hw/9pfs/virtio-9p-handle.c:66:58: note: eac

Re: [Qemu-devel] [PATCH 0/2] scsi: Clean up BlockDriverState use

2012-06-06 Thread Kevin Wolf
Am 05.06.2012 23:32, schrieb Paolo Bonzini: > Il 05/06/2012 16:49, Markus Armbruster ha scritto: >> With this and the related fix for xen applied, block_int.h is finally >> gone from hw/. >> >> Markus Armbruster (2): >> block: New bdrv_get_flags() >> scsi-disk: Don't peek behind the BlockDriver

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Alon Levy
On Wed, Jun 06, 2012 at 05:22:21PM +0800, Anthony Liguori wrote: > On 06/06/2012 05:10 PM, Yonit Halperin wrote: > >Hi, > > > >I would like to add some more points to Gerd's explanation: > >On 06/05/2012 04:15 PM, Gerd Hoffmann wrote: > >>Hi, > >> > >>>Absolutely not. This is hideously ugly and aff

[Qemu-devel] [Bug 1007269] Re: Can’t install or boot up 32bit win8 guest.

2012-06-06 Thread Jan Kiszka
Try varying the CPU type (-cpu ...). Some work for me here, others don't. Likely some subtle bug(s) in the definitions. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1007269 Title: Can’t install or

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Anthony Liguori
On 06/06/2012 06:54 PM, Alon Levy wrote: On Wed, Jun 06, 2012 at 05:22:21PM +0800, Anthony Liguori wrote: On 06/06/2012 05:10 PM, Yonit Halperin wrote: Spice client migration has nothing to do with guest migration. Trying to I don't understand this POV. If it were a VNC connection instead of

Re: [Qemu-devel] [PATCH v2] kvm: Fix build for non-CAP_IRQ_ROUTING targets

2012-06-06 Thread Anthony Liguori
On 06/06/2012 06:44 PM, Avi Kivity wrote: On 06/06/2012 01:31 PM, Jan Kiszka wrote: On 2012-06-06 10:41, Avi Kivity wrote: On 06/05/2012 10:03 PM, Jan Kiszka wrote: A type definition and a KVMState field initialization escaped the required wrapping with KVM_CAP_IRQ_ROUTING. Also, we need to pr

Re: [Qemu-devel] [PATCH 04/16] qapi: introduce OptsVisitor

2012-06-06 Thread Laszlo Ersek
Thank you very much for the review! One question below (and maybe some more later in response to other parts of the review): On 06/05/12 23:12, Paolo Bonzini wrote: > Il 22/05/2012 12:45, Laszlo Ersek ha scritto: >> Optarg values can be of scalar types str / bool / int / size. > > Michael Roth r

Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor

2012-06-06 Thread Anthony Liguori
On 06/06/2012 05:58 PM, Avi Kivity wrote: On 06/06/2012 12:17 PM, Anthony Liguori wrote: So, is it reasonable to say uint32_t * _immutable irrp; // Interrupt Request Register and allocate it on the heap during initialization? No, this would be wrong. '_immutable' means that the *state

Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor

2012-06-06 Thread Avi Kivity
On 06/06/2012 02:12 PM, Anthony Liguori wrote: > On 06/06/2012 05:58 PM, Avi Kivity wrote: >> On 06/06/2012 12:17 PM, Anthony Liguori wrote: So, is it reasonable to say uint32_t * _immutable irrp; // Interrupt Request Register and allocate it on the heap during in

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Alon Levy
On Wed, Jun 06, 2012 at 07:05:44PM +0800, Anthony Liguori wrote: > On 06/06/2012 06:54 PM, Alon Levy wrote: > >On Wed, Jun 06, 2012 at 05:22:21PM +0800, Anthony Liguori wrote: > >>On 06/06/2012 05:10 PM, Yonit Halperin wrote: > >>Spice client migration has nothing to do with guest migration. Tryin

Re: [Qemu-devel] The development tree is now open!

2012-06-06 Thread Avi Kivity
On 06/05/2012 04:19 PM, Jan Kiszka wrote: >> >> Note, I am holding off on the qemu-kvm-1.1 release pending investigation >> of the qcow2/ide bug that Yongjie Ren discovered. But if it's holding >> you off, I can branch 1.1 now and merge this early to master. > > I'm optimistic that the pull I se

Re: [Qemu-devel] [PATCH 2/2] xen: Don't peek behind the BlockDriverState abstraction

2012-06-06 Thread Markus Armbruster
Stefano Stabellini writes: > On Tue, 5 Jun 2012, Markus Armbruster wrote: >> First offender is xen_config_dev_blk()'s use of disk->bdrv->filename. >> Get the filename from disk->opts instead. Same result, except for >> snapshots: there, we now get the filename specified by the user >> instead of

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Anthony Liguori
On 06/06/2012 07:27 PM, Alon Levy wrote: If there is an active VNC client then it is there as a result of a user choosing to use it, so it should be treated as part of the user experience and not as something external. The experience from ignoring this and choosing to treat the remote console as

Re: [Qemu-devel] [PATCH 2/2] xen: Don't peek behind the BlockDriverState abstraction

2012-06-06 Thread Peter Maydell
On 5 June 2012 13:51, Markus Armbruster wrote: > @@ -554,6 +553,7 @@ static int blk_init(struct XenDevice *xendev) >  { >     struct XenBlkDev *blkdev = container_of(xendev, struct XenBlkDev, xendev); >     int index, qflags, info = 0; > +    char fmt_name[128]; Fixed length array with a hardcode

Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time

2012-06-06 Thread Paolo Bonzini
> From e0e6e5b689cbcb782bca8f158fad89b3389e9e11 Mon Sep 17 00:00:00 2001 > From: Anthony Liguori > Date: Wed, 6 Jun 2012 16:57:00 +0800 > Subject: [PATCH] configure: ensure directory exists when creating symlink > > Signed-off-by: Anthony Liguori > --- > configure |3 +-- > 1 files changed,

Re: [Qemu-devel] [PATCH v2 6/6] qapi: convert sendkey

2012-06-06 Thread Eric Blake
On 06/06/2012 01:13 AM, Amos Kong wrote: >>> Ho, I found another bug in my code, key in decimal or hexadecimal >>> format is not supported. I will fix it. >> >> How do you plan to support decimal in QMP? > > In old do_sendkey(), only key-name and hexadecimal were supported, > the description need

Re: [Qemu-devel] [PATCH 04/16] qapi: introduce OptsVisitor

2012-06-06 Thread Paolo Bonzini
Il 06/06/2012 13:12, Laszlo Ersek ha scritto: > The unsigned functions don't check if the int64_t value to be assigned is > negative. What happens in such a case is fully defined, but did Michael > really intend the wraparound to unsigned? I think that's a bug. Please coordinate with Michael and

Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time

2012-06-06 Thread Peter Maydell
On 6 June 2012 12:54, Paolo Bonzini wrote: >> From: Anthony Liguori >> +  mkdir -p `dirname $2` > > Please leave the argument quoted, like > >  dir=`dirname "$2` (missing ", obviously) >  mkdir -p "$dir" Can we use mkdir -p "$(dirname "$2")" or are we still trying to be compatible with some

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Yonit Halperin
On 06/06/2012 12:22 PM, Anthony Liguori wrote: On 06/06/2012 05:10 PM, Yonit Halperin wrote: Hi, I would like to add some more points to Gerd's explanation: On 06/05/2012 04:15 PM, Gerd Hoffmann wrote: Hi, Absolutely not. This is hideously ugly and affects a bunch of code. Spice is *not* ge

[Qemu-devel] [PATCH 3/8] s390: make kvm_stat work on s390

2012-06-06 Thread Jens Freimann
From: Jens Freimann Add s390_exit_reasons so kvm_stat doesn't crash when called on s390. Look for 'vendor_id' in /proc/cpuinfo as well, instead of just for 'flags', so we can determine if we run on S390. Signed-off-by: Jens Freimann --- scripts/kvm/kvm_stat | 26 +- 1

[Qemu-devel] [PATCH 7/8] s390: Add SCLP vt220 console support

2012-06-06 Thread Jens Freimann
From: Heinz Graalfs Adds console support (in vt220 mode). In order to run qemu exploiting the SCLP's console functionality in vt220 mode the user has to specify the following console related parameters: -chardev stdio,id=charconsole0 -device sclpconsole,chardev=charconsole0,id=console0 Signed

[Qemu-devel] [PATCH 2/8] s390: autodetect map private

2012-06-06 Thread Jens Freimann
From: Christian Borntraeger By default qemu will use MAP_PRIVATE for guest pages. This will write protect pages and thus break on s390 systems that dont support this feature. Therefore qemu has a hack to always use MAP_SHARED for s390. But MAP_SHARED has other problems (no dirty pages tracking, a

[Qemu-devel] [PATCH 0/8] s390: SCLP console and misc

2012-06-06 Thread Jens Freimann
From: Jens Freimann Some patches for s390. The biggest chunk is the SCLP (console) implementation. Christian Borntraeger (3): s390: autodetect map private s390: stop target cpu on sigp initial reset s390: Cleanup sclp functions Heinz Graalfs (2): s390: sclp event facility and signal qui

[Qemu-devel] [PATCH 5/8] s390: Cleanup sclp functions

2012-06-06 Thread Jens Freimann
From: Christian Borntraeger The sclp facility on s390 is a hardware that is external to the cpu. Lets cleanup the definitions and move the functionality into a separate file under hw/. Signed-off-by: Christian Borntraeger Signed-off-by: Jens Freimann --- Makefile.target |2 +- hw

[Qemu-devel] [PATCH 4/8] s390: stop target cpu on sigp initial reset

2012-06-06 Thread Jens Freimann
From: Christian Borntraeger We must not run the target cpu after an initial reset. This makes system_reset more reliable for smp guests. Signed-off-by: Christian Borntraeger --- target-s390x/kvm.c |1 + 1 file changed, 1 insertion(+) diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c in

[Qemu-devel] [PATCH 1/8] s390: add new define for KVM_CAP_S390_COW

2012-06-06 Thread Jens Freimann
From: Jens Freimann Add new define for capability KVM_CAP_S390_COW This patch should be replaced by a current kernel kvm.h header file. Signed-off-by: Christian Borntraeger Signed-off-by: Jens Freimann --- linux-headers/linux/kvm.h |1 + 1 file changed, 1 insertion(+) diff --git a/linux-

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Anthony Liguori
On 06/06/2012 08:01 PM, Yonit Halperin wrote: On 06/06/2012 12:22 PM, Anthony Liguori wrote: So send a QMP event and call it a day. Using a QMP event is making spice seamless migration dependent on libvirt version. That is not an acceptable justification. Delaying the status change to "mi

Re: [Qemu-devel] [patch v8 0/5] i.MX31 support

2012-06-06 Thread Andreas Färber
Hello Peter, Am 06.06.2012 05:47, schrieb Peter Chubb: > There are no major changes since last time, just rebased to current > tip now that QEMU 1.2 is open. > > For those who have come into the story late, this is a series of > patches to allow QEMU to emulate a Freescale i.MX31 on a Kyoto > Mi

Re: [Qemu-devel] [PATCH 15/16] convert net_init_bridge() to NetClientOptions

2012-06-06 Thread Laszlo Ersek
On 06/05/12 23:05, Paolo Bonzini wrote: > Il 22/05/2012 12:45, Laszlo Ersek ha scritto: >> Signed-off-by: Laszlo Ersek >> --- >> net/tap.c | 23 --- >> 1 files changed, 12 insertions(+), 11 deletions(-) >> >> diff --git a/net/tap.c b/net/tap.c >> index 7501eba..fdaab2b 10064

Re: [Qemu-devel] [PATCH 0/2] Two small fixes to the streaming test case.

2012-06-06 Thread Paolo Bonzini
> A real patch series is preferable, having the patches as part of your > signature makes quoting them a bit harder with Thunderbird... Oops. Unintended, sorry. >> From 644fda4d6da1a5babfc8884f255d87ebaf847616 Mon Sep 17 00:00:00 2001 >> From: Paolo Bonzini >> Date: Wed, 23 May 2012 13:07:56 +

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Alon Levy
On Wed, Jun 06, 2012 at 08:08:40PM +0800, Anthony Liguori wrote: > On 06/06/2012 08:01 PM, Yonit Halperin wrote: > >On 06/06/2012 12:22 PM, Anthony Liguori wrote: > >> > >>So send a QMP event and call it a day. > >> > >Using a QMP event is making spice seamless migration dependent on libvirt > >ver

Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time

2012-06-06 Thread Paolo Bonzini
Il 06/06/2012 14:03, Peter Maydell ha scritto: > Can we use > mkdir -p "$(dirname "$2")" > > or are we still trying to be compatible with some non-POSIX > shell from the dawn of time? Looks like we can, there are other occurrences of $() in configure. Paolo

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Anthony Liguori
On 06/06/2012 08:15 PM, Alon Levy wrote: On Wed, Jun 06, 2012 at 08:08:40PM +0800, Anthony Liguori wrote: On 06/06/2012 08:01 PM, Yonit Halperin wrote: On 06/06/2012 12:22 PM, Anthony Liguori wrote: So send a QMP event and call it a day. Using a QMP event is making spice seamless migration

Re: [Qemu-devel] [PATCH 2/2] xen: Don't peek behind the BlockDriverState abstraction

2012-06-06 Thread Stefano Stabellini
On Wed, 6 Jun 2012, Markus Armbruster wrote: > Stefano Stabellini writes: > > On Tue, 5 Jun 2012, Markus Armbruster wrote: > >> First offender is xen_config_dev_blk()'s use of disk->bdrv->filename. > >> Get the filename from disk->opts instead. Same result, except for > >> snapshots: there, we no

[Qemu-devel] [PATCH v3 00/16] target-or32: QEMU OpenRISC support

2012-06-06 Thread Jia Liu
This is the OpenCores OpenRISC 1200 support for QEMU. Full implementation of the system-model and linux-user-model support. OpenRISC 1200 is a OpenCores open source CPU, its architecture manual can be find at http://opencores.org/svnget,or1k?file=/trunk/docs/openrisc_arch.pdf --- Thank you all fo

[Qemu-devel] [PATCH v3 02/16] target-or32: Add target machine

2012-06-06 Thread Jia Liu
Add OpenRISC target machine. Signed-off-by: Jia Liu --- target-openrisc/cpu.h | 62 +++-- target-openrisc/machine.c | 22 +++- 2 files changed, 81 insertions(+), 3 deletions(-) diff --git a/target-openrisc/cpu.h b/target-openrisc/cpu.h

[Qemu-devel] [PATCH v3 01/16] target-or32: Add target stubs and cpu QOM

2012-06-06 Thread Jia Liu
Add OpenRISC target stubs and cpu QOM implement. Signed-off-by: Jia Liu --- Makefile.target |8 ++ arch_init.c |2 + arch_init.h |1 + configure| 14 ++- cpu-exec.c |2 + de

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Alon Levy
On Wed, Jun 06, 2012 at 08:17:29PM +0800, Anthony Liguori wrote: > On 06/06/2012 08:15 PM, Alon Levy wrote: > >On Wed, Jun 06, 2012 at 08:08:40PM +0800, Anthony Liguori wrote: > >>On 06/06/2012 08:01 PM, Yonit Halperin wrote: > >>>On 06/06/2012 12:22 PM, Anthony Liguori wrote: > > So send

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Anthony Liguori
On 06/06/2012 08:30 PM, Alon Levy wrote: On Wed, Jun 06, 2012 at 08:17:29PM +0800, Anthony Liguori wrote: On 06/06/2012 08:15 PM, Alon Levy wrote: On Wed, Jun 06, 2012 at 08:08:40PM +0800, Anthony Liguori wrote: On 06/06/2012 08:01 PM, Yonit Halperin wrote: On 06/06/2012 12:22 PM, Anthony Lig

Re: [Qemu-devel] [PATCH 0/2] Two small fixes to the streaming test case.

2012-06-06 Thread Kevin Wolf
Am 06.06.2012 14:15, schrieb Paolo Bonzini: > >> A real patch series is preferable, having the patches as part of your >> signature makes quoting them a bit harder with Thunderbird... > > Oops. Unintended, sorry. > >>> From 644fda4d6da1a5babfc8884f255d87ebaf847616 Mon Sep 17 00:00:00 2001 >>> F

  1   2   3   >