On 06/06/2012 01:13 AM, Amos Kong wrote: >>> Ho, I found another bug in my code, key in decimal or hexadecimal >>> format is not supported. I will fix it. >> >> How do you plan to support decimal in QMP? > > In old do_sendkey(), only key-name and hexadecimal were supported, > the description needs to be fixed. >
> > It seems we can only support key-name for QMP, and support > key-name/hexadecimal > for HMP. Is it acceptable? Yes, that was my argument for bare minimum support - anyone using QMP (like libvirt) will have to be smart enough to use key-name only, while anyone using HMP will be able to use hex because HMP will convert hex to key-name at the appropriate time before calling into QMP. Of course, being able to support hex from QMP would be a nice feature, but I'm not sure how to add it in. -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
