Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-24 Thread Paolo Bonzini
Il 24/04/2012 06:21, ronnie sahlberg ha scritto: > Hi Stefan, > > A little bit off-topic but > > When you design the proper place and API to plug virt-scsi into an > external SCSI parser outside of qemu like the target in the kernel ... > > It would be very nice if one could also plug virt-scsi

[Qemu-devel] [PATCH] docs: fix one issue in qcow2 specs

2012-04-24 Thread zwu . kernel
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- docs/specs/qcow2.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt index b6adcad..ae68a6e 100644 --- a/docs/specs/qcow2.txt +++ b/docs/specs/qcow2.txt @@ -185,7 +185,7 @@ L2

Re: [Qemu-devel] [PATCH v6 2/5] Implement i.MX31 Clock Control Module

2012-04-24 Thread Peter Chubb
> "Paolo" == Paolo Bonzini writes: Paolo> Il 23/04/2012 22:54, Peter Chubb ha scritto: Peter> What is this calculation supposed to do? It doesn't convert a Peter> 10-bit signed twos-complement number into an int32_t, unless Peter> I'm confused... Also, it's a rather opaque way to write "mfn &

[Qemu-devel] Fwd: buildbot failure in qemu on rhel5-default

2012-04-24 Thread Gerd Hoffmann
Original Message Subject: buildbot failure in qemu on rhel5-default Date: Mon, 23 Apr 2012 23:31:44 +0200 From: build...@spunk.home.kraxel.org To: kra...@gmail.com The Buildbot has detected a failed build on builder rhel5-default while building qemu. Full details are available

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Pavel Hrdina
On 04/24/2012 08:55 AM, Paolo Bonzini wrote: Il 23/04/2012 18:06, Pavel Hrdina ha scritto: Hi, this is the patch to fix incorrect handling of IDE floppy drive controller emulation when no media is present. If the guest is booted without a media then the drive was not being emulated at all but t

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Andreas Färber
Am 23.04.2012 18:06, schrieb Pavel Hrdina: > Hi, > this is the patch to fix incorrect handling of IDE floppy drive controller > emulation > when no media is present. If the guest is booted without a media then the > drive > was not being emulated at all but this patch enables the emulation with n

Re: [Qemu-devel] [PATCH v6 0/5] FreeSCALE i.MX31 support

2012-04-24 Thread Andreas Färber
Am 23.04.2012 01:31, schrieb Peter Chubb: > Hi all, >Most of the files are unchanged since last time. Indeed... On v5 I had asked you to shorten the subjects to conform to our commit message scheme and to make patches better readable. There were even suggestions. Also I implicitly suggested to

Re: [Qemu-devel] [PATCH] ISCSI: Add support for thin-provisioning via discard/UNMAP and bigger LUNs

2012-04-24 Thread ronnie sahlberg
On Tue, Apr 24, 2012 at 4:46 PM, Paolo Bonzini wrote: > Il 24/04/2012 08:29, Ronnie Sahlberg ha scritto: >> Update the configure test for libiscsi support to detect version 1.3 or >> later. >> Version 1.3 of libiscsi provides both READCAPACITY16 as well as UNMAP >> commands. >> >> Update the isc

Re: [Qemu-devel] [PATCH] ISCSI: Add support for thin-provisioning via discard/UNMAP and bigger LUNs

2012-04-24 Thread Kevin Wolf
Am 24.04.2012 08:46, schrieb Paolo Bonzini: > Il 24/04/2012 08:29, Ronnie Sahlberg ha scritto: >> Update the configure test for libiscsi support to detect version 1.3 or >> later. >> Version 1.3 of libiscsi provides both READCAPACITY16 as well as UNMAP >> commands. >> >> Update the iscsi block la

Re: [Qemu-devel] [RFC PATCH 0/9] ACPI memory hotplug

2012-04-24 Thread Gleb Natapov
On Mon, Apr 23, 2012 at 02:31:15PM +0200, Vasilis Liaskovitis wrote: > Hi, > > On Sun, Apr 22, 2012 at 05:20:59PM +0300, Gleb Natapov wrote: > > On Sun, Apr 22, 2012 at 05:13:27PM +0300, Avi Kivity wrote: > > > On 04/22/2012 05:09 PM, Gleb Natapov wrote: > > > > On Sun, Apr 22, 2012 at 05:06:43PM

Re: [Qemu-devel] [PATCH] docs: fix one issue in qcow2 specs

2012-04-24 Thread Kevin Wolf
Am 24.04.2012 09:11, schrieb zwu.ker...@gmail.com: > From: Zhi Yong Wu > > Signed-off-by: Zhi Yong Wu > --- > docs/specs/qcow2.txt |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt > index b6adcad..ae68a6e 100644 > --- a/

Re: [Qemu-devel] [PATCH] ISCSI: Add support for thin-provisioning via discard/UNMAP and bigger LUNs

2012-04-24 Thread Paolo Bonzini
Il 24/04/2012 10:02, ronnie sahlberg ha scritto: > So ignore this patch for now. I will redo UNMAP in the patch to > instead use the generic scsi function inside libiscsi. > > That will serve the purpose to verify that the public API in libiscsi > is sufficient for accessing the generic transport

Re: [Qemu-devel] [PATCH] scsi refcounting fix?

2012-04-24 Thread David Gibson
On Tue, Apr 24, 2012 at 08:37:22AM +0200, Paolo Bonzini wrote: > Il 24/04/2012 07:02, David Gibson ha scritto: > > So the patch below fixes my assertion failure, but again, I can't say > > I understand this well enough to be confident - it might be leaking > > scsi reqs instead. But if this isn't

Re: [Qemu-devel] [PATCHv2 0/3] virtio: fix memory access races

2012-04-24 Thread Stefan Hajnoczi
On Mon, Apr 23, 2012 at 2:19 PM, Michael S. Tsirkin wrote: > This is a follow-up to my previous patch: it turns > out that a single mb() isn't sufficient as network > loss could still be triggered under stress. > > Patch 1 is repost of v1. > > The following two patches fix more races found > by co

Re: [Qemu-devel] [RFC PATCH 0/9] ACPI memory hotplug

2012-04-24 Thread Gleb Natapov
On Mon, Apr 23, 2012 at 04:31:04PM +0300, Avi Kivity wrote: > On 04/22/2012 05:20 PM, Gleb Natapov wrote: > > On Sun, Apr 22, 2012 at 05:13:27PM +0300, Avi Kivity wrote: > > > On 04/22/2012 05:09 PM, Gleb Natapov wrote: > > > > On Sun, Apr 22, 2012 at 05:06:43PM +0300, Avi Kivity wrote: > > > > > O

Re: [Qemu-devel] [PATCH] ISCSI: Add support for thin-provisioning via discard/UNMAP and bigger LUNs

2012-04-24 Thread ronnie sahlberg
On Tue, Apr 24, 2012 at 6:05 PM, Paolo Bonzini wrote: > Il 24/04/2012 10:02, ronnie sahlberg ha scritto: >> So ignore this patch for now. I will redo UNMAP in the patch to >> instead use the generic scsi function inside libiscsi. >> >> That will serve the purpose to verify that the public API in l

Re: [Qemu-devel] [PATCH v6 0/5] FreeSCALE i.MX31 support

2012-04-24 Thread Peter Chubb
> "Andreas" == Andreas Färber writes: Andreas> Am 23.04.2012 01:31, schrieb Peter Chubb: >> Hi all, Most of the files are unchanged since last time. Andreas> Indeed... On v5 I had asked you to shorten the subjects to Andreas> conform to our commit message scheme and to make patches Andreas>

Re: [Qemu-devel] [PATCH] block/qcow2: Add missing GCC_FMT_ATTR to function report_unsupported()

2012-04-24 Thread Kevin Wolf
Am 23.04.2012 22:54, schrieb Stefan Weil: > Cc: Kevin Wolf > Signed-off-by: Stefan Weil > --- > block/qcow2.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/block/qcow2.c b/block/qcow2.c > index ad46c03..d03e31c 100644 > --- a/block/qcow2.c > +++ b/block/qcow2.c

Re: [Qemu-devel] [RFC PATCH 0/9] ACPI memory hotplug

2012-04-24 Thread Vasilis Liaskovitis
Hi, On Tue, Apr 24, 2012 at 10:52:24AM +0300, Gleb Natapov wrote: > On Mon, Apr 23, 2012 at 02:31:15PM +0200, Vasilis Liaskovitis wrote: > > The 440fx spec mentions: "The address range from the top of main DRAM to 4 > > Gbytes (top of physical memory space supported by the 440FX PCIset) is > > nor

Re: [Qemu-devel] [RFC PATCH 3/9][SeaBIOS] acpi: generate hotplug memory devices.

2012-04-24 Thread Vasilis Liaskovitis
Hi, On Mon, Apr 23, 2012 at 07:37:51PM -0400, Kevin O'Connor wrote: > On Thu, Apr 19, 2012 at 04:08:41PM +0200, Vasilis Liaskovitis wrote: > > The memory device generation is guided by qemu paravirt info. Seabios > > first uses the info to setup SRAT entries for the hotplug-able memory > > slot

Re: [Qemu-devel] [RFC PATCH 0/9] ACPI memory hotplug

2012-04-24 Thread Gleb Natapov
On Tue, Apr 24, 2012 at 10:24:51AM +0200, Vasilis Liaskovitis wrote: > Hi, > On Tue, Apr 24, 2012 at 10:52:24AM +0300, Gleb Natapov wrote: > > On Mon, Apr 23, 2012 at 02:31:15PM +0200, Vasilis Liaskovitis wrote: > > > The 440fx spec mentions: "The address range from the top of main DRAM to 4 > > >

Re: [Qemu-devel] copy benchmarks onto qemu

2012-04-24 Thread Mulyadi Santosa
On Tue, Apr 24, 2012 at 02:09, Xin Tong wrote: > I am not too sure what you mean by raw image. what i have is an *.img > file that is bootable by QEMU. will kpartx  work ? try to use "qemu-img info" to find what format the file uses... -- regards, Mulyadi Santosa Freelance Linux trainer and c

Re: [Qemu-devel] [PATCH 2/4] block: use Error mechanism instead of -errno for block_job_set_speed()

2012-04-24 Thread Stefan Hajnoczi
On Mon, Apr 23, 2012 at 7:01 PM, Luiz Capitulino wrote: > On Mon, 23 Apr 2012 17:47:09 +0200 > Paolo Bonzini wrote: > >> Il 23/04/2012 17:39, Stefan Hajnoczi ha scritto: >> > There are at least two different errors that can occur in >> > block_job_set_speed(): the job might not support setting sp

Re: [Qemu-devel] [PATCH 00/15] QOM'ify x86 CPU, part 2: properties

2012-04-24 Thread Andreas Färber
Am 19.04.2012 20:27, schrieb Eduardo Habkost: > By the way, do you still plan to make cpudefs register new > classes/types? I remember that you did that on a previous series. Generally I do, yes. However the CPU QOM'ification is not making as much progress as I would've liked, specifically there's

Re: [Qemu-devel] Generating cachegrind output with qemu

2012-04-24 Thread Wacha Gábor
Dear Stefan, Thanks for your quick answer, I'll look into it. Regards, Gabor Wacha 2012.04.24. 6:33, "Stefan Weil" ezt írta: > Am 23.04.2012 18:18, schrieb Wacha Gábor: > >> Dear developers, I am a Hungarian student trying to use qemu for >> profiling bare metal ARM programs for my student rese

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Stefan Hajnoczi
On Mon, Apr 23, 2012 at 5:06 PM, Pavel Hrdina wrote: > Hi, > this is the patch to fix incorrect handling of IDE floppy drive controller > emulation s/IDE// It's unrelated to IDE. > @@ -937,6 +940,9 @@ static int fdctrl_media_changed(FDrive *drv) > >     if (!drv->bs) >         return 0; > +  

Re: [Qemu-devel] [PATCH 2/4] block: use Error mechanism instead of -errno for block_job_set_speed()

2012-04-24 Thread Paolo Bonzini
Il 24/04/2012 10:49, Stefan Hajnoczi ha scritto: > "The error is specific to > block job speeds so we can add a speed argument to block-stream in the > future and clearly identify the invalid parameter." > > I added the new error to avoid having to change the InvalidParameter > 'name' field. It b

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-24 Thread Stefan Hajnoczi
On Tue, Apr 24, 2012 at 8:05 AM, Paolo Bonzini wrote: > Il 24/04/2012 06:21, ronnie sahlberg ha scritto: >> Hi Stefan, >> >> A little bit off-topic but >> >> When you design the proper place and API to plug virt-scsi into an >> external SCSI parser outside of qemu like the target in the kernel ...

[Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Amit Shah
From: Alon Levy guest_connected should be false before guest driver initialization, and true after, both for multiport aware and non multiport aware drivers. Don't set it before the guest_features are available; instead use set_status which is called by io to VIRTIO_PCI_STATUS with VIRTIO_CONFIG

[Qemu-devel] [PATCH v2 09/15] target-i386: Add property getter for CPU model

2012-04-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-i386/cpu.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 9479717..643289f 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -640,6 +640,18 @@ static void x86_cpuid

[Qemu-devel] [PATCH v2 12/15] target-i386: Introduce "level" property for X86CPU

2012-04-24 Thread Andreas Färber
Signed-off-by: Andreas Färber Reviewed-by: Eduardo Habkost --- target-i386/cpu.c | 38 +- 1 files changed, 37 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 490db76..f2df8d0 100644 --- a/target-i386/cpu.c +++ b/target

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Pavel Hrdina
On 04/24/2012 11:06 AM, Stefan Hajnoczi wrote: On Mon, Apr 23, 2012 at 5:06 PM, Pavel Hrdina wrote: Hi, this is the patch to fix incorrect handling of IDE floppy drive controller emulation s/IDE// It's unrelated to IDE. @@ -937,6 +940,9 @@ static int fdctrl_media_changed(FDrive *drv)

[Qemu-devel] [PATCH v2 04/15] target-i386: Add "family" property to X86CPU

2012-04-24 Thread Andreas Färber
Add the property early in the initfn so that it can be used in helpers such as mce_init(). Signed-off-by: Andreas Färber Reviewed-by: Eduardo Habkost [AF: Add an error_free(), spotted by Michael Roth] --- target-i386/cpu.c | 39 ++- 1 files changed, 34 inse

[Qemu-devel] [PATCH v2 14/15] target-i386: Prepare "vendor" property for X86CPU

2012-04-24 Thread Andreas Färber
Using it now would incur converting the three x86_def_t vendor words into a string for object_property_set_str(), then back to three words in the "vendor" setter. The built-in CPU definitions use numeric preprocessor defines to initialize the three words in a charset-safe way, so do not change the

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Kevin Wolf
Am 23.04.2012 18:06, schrieb Pavel Hrdina: > Hi, > this is the patch to fix incorrect handling of IDE floppy drive controller > emulation > when no media is present. If the guest is booted without a media then the > drive > was not being emulated at all but this patch enables the emulation with n

Re: [Qemu-devel] [PATCH] spice: require spice-protocol >= 0.8.1

2012-04-24 Thread Gerd Hoffmann
On 04/23/12 15:52, Peter Maydell wrote: > Ping? This patch doesn't seem to have made it into master yet > and I don't think it was in the last spice pullreq... Somehow overlooked it in my inbox. Added to the spice patch queue now. Thanks for the reminder, Gerd

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Pavel Hrdina
On 04/24/2012 11:32 AM, Kevin Wolf wrote: Am 23.04.2012 18:06, schrieb Pavel Hrdina: Hi, this is the patch to fix incorrect handling of IDE floppy drive controller emulation when no media is present. If the guest is booted without a media then the drive was not being emulated at all but this

[Qemu-devel] [PULL] virtio-serial: fix probing for features before driver init

2012-04-24 Thread Amit Shah
Hi, Please pull for a virtio-serial fix. The following changes since commit 3c30dd5a68e9fee6af67cfd0d14ed7520820f36a: target-arm: Move reset handling to arm_cpu_reset (2012-04-21 18:13:22 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/qemu/amit/virtio-seria

[Qemu-devel] [PATCH v2 15/15] target-i386: Introduce "tsc-frequency" property for X86CPU

2012-04-24 Thread Andreas Färber
Use Hz as unit. Signed-off-by: Andreas Färber Reviewed-by: Eduardo Habkost --- target-i386/cpu.c | 37 - 1 files changed, 36 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 540b3df..64fd903 100644 --- a/target-i386/cp

[Qemu-devel] [PATCH v2 07/15] target-i386: Add "model-id" property to X86CPU

2012-04-24 Thread Andreas Färber
Signed-off-by: Andreas Färber Reviewed-by: Eduardo Habkost --- target-i386/cpu.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 2f843be..1b8053a 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -673,8 +673,11

[Qemu-devel] [PATCH v2 02/15] target-i386: Pass X86CPU to cpu_x86_register()

2012-04-24 Thread Andreas Färber
Avoids an x86_env_get_cpu() call there, to work with QOM properties. Signed-off-by: Andreas Färber Reviewed-by: Eduardo Habkost --- target-i386/cpu.c|3 ++- target-i386/cpu.h|2 +- target-i386/helper.c |2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/tar

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Amit Shah
On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote: > On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah wrote: > > From: Alon Levy > > > > guest_connected should be false before guest driver initialization, and > > true after, both for multiport aware and non multiport aware drivers. > >

[Qemu-devel] [PATCH v2 03/15] target-i386: Add range check for -cpu , family=x

2012-04-24 Thread Andreas Färber
A family field value of 0xf and extended family field value of 0xff is the maximum representable unsigned family number. All other CPUID property values are bounds-checked, so add a check here for symmetry before we adopt it in a property setter. Signed-off-by: Andreas Färber Reviewed-by: Eduardo

[Qemu-devel] [PATCH v2 00/15] QOM'ify x86 CPU, part 2: properties

2012-04-24 Thread Andreas Färber
Hello, This series introduces some QOM properties for X86CPU, so that our built-in init code exercises the same code paths as QMP, as suggested by Eduardo: * "family", * "model", * "stepping" and * "model-id" (rather than "model_id") This QOM'ifies my previously introduced helper functions, adding

[Qemu-devel] [PATCH v2 05/15] target-i386: Add "model" property to X86CPU

2012-04-24 Thread Andreas Färber
Signed-off-by: Andreas Färber Reviewed-by: Eduardo Habkost --- target-i386/cpu.c | 26 +++--- 1 files changed, 23 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index ebe9c7e..3a8141b 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c

[Qemu-devel] [PATCH v2 10/15] target-i386: Add property getter for CPU stepping

2012-04-24 Thread Andreas Färber
Signed-off-by: Andreas Färber Reviewed-by: Eduardo Habkost --- target-i386/cpu.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 643289f..f1d3827 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -675,6 +6

[Qemu-devel] [PATCH v2 06/15] target-i386: Add "stepping" property to X86CPU

2012-04-24 Thread Andreas Färber
Signed-off-by: Andreas Färber Reviewed-by: Eduardo Habkost --- target-i386/cpu.c | 27 --- 1 files changed, 24 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 3a8141b..2f843be 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c

[Qemu-devel] [PATCH v2 11/15] target-i386: Add property getter for CPU model-id

2012-04-24 Thread Andreas Färber
Signed-off-by: Andreas Färber Reviewed-by: Eduardo Habkost --- target-i386/cpu.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index f1d3827..490db76 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -711,6

Re: [Qemu-devel] [PATCH v2 00/15] QOM'ify x86 CPU, part 2: properties

2012-04-24 Thread Andreas Färber
Am 24.04.2012 11:33, schrieb Andreas Färber: > Hello, > > This series introduces some QOM properties for X86CPU, so that our built-in > init code exercises the same code paths as QMP, as suggested by Eduardo: > * "family", > * "model", > * "stepping" and > * "model-id" (rather than "model_id") > T

[Qemu-devel] [PATCH v2 01/15] target-i386: Fix x86_cpuid_set_model_id()

2012-04-24 Thread Andreas Färber
Don't assume zeroed cpuid_model[] fields. This doesn't break anything yet but QOM properties should be able to set the value to something else without setting an intermediate zero string. Signed-off-by: Andreas Färber Reviewed-by: Eduardo Habkost --- target-i386/cpu.c |3 +++ 1 files chang

[Qemu-devel] [PATCH v2 08/15] target-i386: Add property getter for CPU family

2012-04-24 Thread Andreas Färber
Signed-off-by: Andreas Färber Reviewed-by: Eduardo Habkost --- target-i386/cpu.c | 16 +++- 1 files changed, 15 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 1b8053a..9479717 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -599,6

[Qemu-devel] [PATCH v2 13/15] target-i386: Introduce "xlevel" property for X86CPU

2012-04-24 Thread Andreas Färber
Signed-off-by: Andreas Färber Reviewed-by: Eduardo Habkost --- target-i386/cpu.c | 38 +- 1 files changed, 37 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index f2df8d0..89a1855 100644 --- a/target-i386/cpu.c +++ b/target

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Michael S. Tsirkin
On Tue, Apr 24, 2012 at 03:56:44PM +0530, Amit Shah wrote: > On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote: > > On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah wrote: > > > From: Alon Levy > > > > > > guest_connected should be false before guest driver initialization, and > > > tr

Re: [Qemu-devel] [RFC PATCH 0/9] ACPI memory hotplug

2012-04-24 Thread Avi Kivity
On 04/24/2012 10:21 AM, Gleb Natapov wrote: > > > > I was thinking about not having tons of 128MB slots, so we don't have a > > configuration that is far from reality. But maybe this thinking is too > > conservative. > > > I think it is good interface to make memory that is specified with -m to

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Pavel Hrdina
On 04/24/2012 09:48 AM, Andreas Färber wrote: Am 23.04.2012 18:06, schrieb Pavel Hrdina: Hi, this is the patch to fix incorrect handling of IDE floppy drive controller emulation when no media is present. If the guest is booted without a media then the drive was not being emulated at all but thi

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Amit Shah
On (Tue) 24 Apr 2012 [13:49:53], Michael S. Tsirkin wrote: > On Tue, Apr 24, 2012 at 03:56:44PM +0530, Amit Shah wrote: > > On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote: > > > On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah wrote: > > > > From: Alon Levy > > > > > > > > guest_con

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Michael S. Tsirkin
On Tue, Apr 24, 2012 at 04:44:10PM +0530, Amit Shah wrote: > On (Tue) 24 Apr 2012 [13:49:53], Michael S. Tsirkin wrote: > > On Tue, Apr 24, 2012 at 03:56:44PM +0530, Amit Shah wrote: > > > On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote: > > > > On Tue, Apr 24, 2012 at 02:55:26PM +0530, A

[Qemu-devel] [PATCH] xen_disk: remove syncwrite option

2012-04-24 Thread Stefano Stabellini
Use the BDRV_O_CACHE_* flags instead. Signed-off-by: Stefano Stabellini --- hw/xen_disk.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/hw/xen_disk.c b/hw/xen_disk.c index 4a6d89c..3e4a47b 100644 --- a/hw/xen_disk.c +++ b/hw/xen_disk.c @@ -48,7 +48,6 @@ /* --

[Qemu-devel] [PULL] xen patches

2012-04-24 Thread Stefano Stabellini
Hi Anthony, please pull: git://xenbits.xen.org/people/sstabellini/qemu-dm.git for_anthony it contains a couple of xen_disk improvements and Xen HVM reboot support. John V. Baboval (1): xen: Support guest reboots Stefano Stabellini (2): xen_disk: use bdrv_aio_flush instead of bdrv_fl

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Andreas Färber
Am 24.04.2012 12:26, schrieb Amit Shah: > On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote: >> On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah wrote: >>> From: Alon Levy >>> >>> guest_connected should be false before guest driver initialization, and >>> true after, both for multiport

Re: [Qemu-devel] [PATCH v2 01/15] target-i386: Fix x86_cpuid_set_model_id()

2012-04-24 Thread Igor Mammedov
On 04/24/2012 11:33 AM, Andreas Färber wrote: Don't assume zeroed cpuid_model[] fields. This doesn't break anything yet but QOM properties should be able to set the value to something else without setting an intermediate zero string. Signed-off-by: Andreas Färber Reviewed-by: Eduardo Habkost --

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Stefan Hajnoczi
On Tue, Apr 24, 2012 at 10:46 AM, Pavel Hrdina wrote: > > On 04/24/2012 11:06 AM, Stefan Hajnoczi wrote: > > On Mon, Apr 23, 2012 at 5:06 PM, Pavel Hrdina wrote: > > Hi, > this is the patch to fix incorrect handling of IDE floppy drive controller > emulation > > s/IDE// > > It's unrelated to IDE.

Re: [Qemu-devel] [PATCH v2 01/15] target-i386: Fix x86_cpuid_set_model_id()

2012-04-24 Thread Andreas Färber
Am 24.04.2012 13:32, schrieb Igor Mammedov: > On 04/24/2012 11:33 AM, Andreas Färber wrote: >> Don't assume zeroed cpuid_model[] fields. >> >> This doesn't break anything yet but QOM properties should be able to set Should've read "didn't". I sure hope it doesn't. :) >> the value to something els

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Amit Shah
On (Tue) 24 Apr 2012 [14:21:36], Michael S. Tsirkin wrote: > On Tue, Apr 24, 2012 at 04:44:10PM +0530, Amit Shah wrote: > > On (Tue) 24 Apr 2012 [13:49:53], Michael S. Tsirkin wrote: > > > On Tue, Apr 24, 2012 at 03:56:44PM +0530, Amit Shah wrote: > > > > On (Tue) 24 Apr 2012 [13:17:16], Michael S.

Re: [Qemu-devel] [PATCH] xen_disk: remove syncwrite option

2012-04-24 Thread Stefano Stabellini
On Tue, 24 Apr 2012, Kevin Wolf wrote: > Am 24.04.2012 13:22, schrieb Stefano Stabellini: > > Use the BDRV_O_CACHE_* flags instead. > > > > Signed-off-by: Stefano Stabellini > > Doesn't apply to qemu.git because... > > > --- > > hw/xen_disk.c |8 +--- > > 1 files changed, 1 insertions(

Re: [Qemu-devel] [PATCH] xen_disk: remove syncwrite option

2012-04-24 Thread Kevin Wolf
Am 24.04.2012 13:22, schrieb Stefano Stabellini: > Use the BDRV_O_CACHE_* flags instead. > > Signed-off-by: Stefano Stabellini Doesn't apply to qemu.git because... > --- > hw/xen_disk.c |8 +--- > 1 files changed, 1 insertions(+), 7 deletions(-) > > diff --git a/hw/xen_disk.c b/hw/xen

Re: [Qemu-devel] [PATCH v3] spice_info: add mouse_mode

2012-04-24 Thread Gerd Hoffmann
On 03/29/12 23:23, Alon Levy wrote: > Add mouse_mode, either server or mouse, to qmp and hmp commands, based > on spice_server_is_server_mouse added in spice-server 0.10.3. Patch added to spice patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Kevin Wolf
Am 24.04.2012 12:28, schrieb Pavel Hrdina: > On 04/24/2012 12:23 PM, Kevin Wolf wrote: >> Am 24.04.2012 11:55, schrieb Pavel Hrdina: >>> On 04/24/2012 11:32 AM, Kevin Wolf wrote: Am 23.04.2012 18:06, schrieb Pavel Hrdina: > Hi, > this is the patch to fix incorrect handling of IDE flopp

Re: [Qemu-devel] [PATCH] qcow2: Fix refcount block allocation during qcow2_allocate_cluster_at()

2012-04-24 Thread Kevin Wolf
Am 23.04.2012 20:30, schrieb Marcelo Tosatti: > On Mon, Apr 23, 2012 at 02:33:49PM +0200, Kevin Wolf wrote: >> Am 23.04.2012 01:35, schrieb Marcelo Tosatti: >>> On Sun, Apr 22, 2012 at 08:18:49PM -0300, Marcelo Tosatti wrote: On Fri, Apr 20, 2012 at 03:56:01PM +0200, Kevin Wolf wrote: > Re

Re: [Qemu-devel] [PATCH 2/4] block: use Error mechanism instead of -errno for block_job_set_speed()

2012-04-24 Thread Eric Blake
On 04/24/2012 03:01 AM, Paolo Bonzini wrote: > Il 24/04/2012 10:49, Stefan Hajnoczi ha scritto: >> "The error is specific to >> block job speeds so we can add a speed argument to block-stream in the >> future and clearly identify the invalid parameter." >> >> I added the new error to avoid having t

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Pavel Hrdina
On 04/24/2012 12:23 PM, Kevin Wolf wrote: Am 24.04.2012 11:55, schrieb Pavel Hrdina: On 04/24/2012 11:32 AM, Kevin Wolf wrote: Am 23.04.2012 18:06, schrieb Pavel Hrdina: Hi, this is the patch to fix incorrect handling of IDE floppy drive controller emulation when no media is present. If the

[Qemu-devel] [PATCH] usb-uhci: update irq line on reset

2012-04-24 Thread Gerd Hoffmann
uhci_reset() clears irq mask and irq status registers, but doesn't update the irq line. Which may result in suspious IRQs after uhci reset. Fix it. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-uhci.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/usb/hcd-uhci.c b/hw

Re: [Qemu-devel] [PATCH] xen_disk: remove syncwrite option

2012-04-24 Thread Stefano Stabellini
On Tue, 24 Apr 2012, Kevin Wolf wrote: > > That's because it is based on top of the following two patches: > > > > xen_disk: use bdrv_aio_flush instead of bdrv_flush > > http://marc.info/?l=qemu-devel&m=133434258008959&w=2 > > > > xen_disk: implement BLKIF_OP_FLUSH_DISKCACHE, remove BLKIF_OP_WRIT

Re: [Qemu-devel] [PATCH] qxl: don't assert on guest create_guest_primary

2012-04-24 Thread Alon Levy
On Tue, Apr 24, 2012 at 12:17:15PM +0200, Gerd Hoffmann wrote: > On 04/18/12 13:00, Alon Levy wrote: > > initiate the implicit destroy ourselves. > > What is the use case? Don't let guest crash the machine with bad driver. i.e. during testing I did this inadvertently. > > Allowing guests to do

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Alon Levy
On Tue, Apr 24, 2012 at 01:23:53PM +0200, Andreas Färber wrote: > Am 24.04.2012 12:26, schrieb Amit Shah: > > On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote: > >> On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah wrote: > >>> From: Alon Levy > >>> > >>> guest_connected should be false

Re: [Qemu-devel] copy benchmarks onto qemu

2012-04-24 Thread Xin Tong
i got it working with libguestfs. libguestfs is awesome at manipulating guest VM images. Xin On Tue, Apr 24, 2012 at 4:45 AM, Mulyadi Santosa wrote: > On Tue, Apr 24, 2012 at 02:09, Xin Tong wrote: >> I am not too sure what you mean by raw image. what i have is an *.img >> file that is bootabl

[Qemu-devel] Assertion after chaning display resolution

2012-04-24 Thread Peter Lieven
Hi all, I saw the following assert after chaning display resolution. This might be the cause, but i am not sure. Threaded VNC is enabled. Anyone ever seen this? qemu-kvm-1.0: malloc.c:3096: sYSMALLOc: Assertion `(old_top == (((mbinptr) (((char *) &((av)->bins[((1) - 1) * 2])) - __builtin_of

[Qemu-devel] [PATCH v2 0/2] Updated fixes for block job cancellation

2012-04-24 Thread Paolo Bonzini
These patches fix the existing problems with synchronous job cancellation without adding a bdrv_drain_all in the asynchronous block_job_cancel. Paolo Bonzini (2): block: add block_job_sleep_ns block: wait for job callback in block_job_cancel_sync block.c| 47 +++

[Qemu-devel] [PATCH v2 2/2] block: wait for job callback in block_job_cancel_sync

2012-04-24 Thread Paolo Bonzini
The limitation on not having I/O after cancellation cannot really be honored. Even streaming has a very small race window where you could cancel a job and have it report completion. If this window is hit, bdrv_change_backing_file() will yield and possibly cause accesses to dangling pointers etc.

[Qemu-devel] [PATCH v2 1/2] block: add block_job_sleep_ns

2012-04-24 Thread Paolo Bonzini
This function abstracts the pretty complex semantics of the "busy" member of BlockJob. Signed-off-by: Paolo Bonzini --- block.c| 11 +++ block/stream.c | 22 -- block_int.h| 22 +++--- 3 files changed, 34 insertions(+), 21 deletions(-

Re: [Qemu-devel] Assertion after chaning display resolution

2012-04-24 Thread Peter Lieven
On 24.04.2012 15:34, Alon Levy wrote: On Tue, Apr 24, 2012 at 03:24:31PM +0200, Peter Lieven wrote: Hi all, I saw the following assert after chaning display resolution. This might be the cause, but i am not sure. Threaded VNC is enabled. Anyone ever seen this? qemu-kvm-1.0: malloc.c:3096: sY

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Pavel Hrdina
On 04/24/2012 01:38 PM, Stefan Hajnoczi wrote: On Tue, Apr 24, 2012 at 10:46 AM, Pavel Hrdina wrote: On 04/24/2012 11:06 AM, Stefan Hajnoczi wrote: On Mon, Apr 23, 2012 at 5:06 PM, Pavel Hrdina wrote: Hi, this is the patch to fix incorrect handling of IDE floppy drive controller emulation

Re: [Qemu-devel] [RFC] qxl: don't panic on phys2virt

2012-04-24 Thread Gerd Hoffmann
On 03/30/12 21:27, Alon Levy wrote: > On Fri, Mar 30, 2012 at 10:09:42AM +0200, Gerd Hoffmann wrote: >> On 03/29/12 22:56, Alon Levy wrote: >>> Issues a qxl_guest_bug from qxl_phys2virt. Everywhere else will fail. >> >> Nice start (there are more guest-triggerable asserts to be fixed this way). >>

Re: [Qemu-devel] [PATCH] qxl: don't assert on guest create_guest_primary

2012-04-24 Thread Gerd Hoffmann
On 04/18/12 13:00, Alon Levy wrote: > initiate the implicit destroy ourselves. What is the use case? Allowing guests to do that without giving them a way to figure whenever it will work or not doesn't look that useful to me. cheers, Gerd

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Kevin Wolf
Am 24.04.2012 11:55, schrieb Pavel Hrdina: > On 04/24/2012 11:32 AM, Kevin Wolf wrote: >> Am 23.04.2012 18:06, schrieb Pavel Hrdina: >>> Hi, >>> this is the patch to fix incorrect handling of IDE floppy drive controller >>> emulation >>> when no media is present. If the guest is booted without a m

Re: [Qemu-devel] [PATCHv2 1/3] virtio: add missing mb() on notification

2012-04-24 Thread Paolo Bonzini
Il 23/04/2012 15:19, Michael S. Tsirkin ha scritto: > During normal operation, virtio first writes a used index > and then checks whether it should interrupt the guest > by reading guest avail index/flag values. > > Guest does the reverse: writes the index/flag, > then checks the used ring. > > T

Re: [Qemu-devel] [PATCH v6 5/5] FreeSCALE i.MX31 support: KZM-ARM11-01 evaluation board

2012-04-24 Thread Peter Maydell
On 23 April 2012 23:21, Peter Chubb wrote: > Peter> Are these two devices really on the same IRQ? > > Yes.  A single interrupt line comes from the FPGA into the AVIC. > Inside the FPGA the interrupts for the UARTs, SD card and NAND flash > are connected to that single interrupt line. > The non-tou

Re: [Qemu-devel] [PATCHv2 3/3] virtio: order index/descriptor reads

2012-04-24 Thread Paolo Bonzini
Il 23/04/2012 15:19, Michael S. Tsirkin ha scritto: > virtio has the equivalent of: > > if (vq->last_avail_index != vring_avail_idx(vq)) { > read descriptor head at vq->last_avail_index; > } > > In theory, processor can reorder descriptor head > read to happen speculativ

[Qemu-devel] [PATCH v2 0/6] block: add optional 'speed' parameter to block-stream

2012-04-24 Thread Stefan Hajnoczi
Eric Blake raised concerns about the inability to start block jobs with a speed limit. Current the user needs to follow up the block-stream command with block-job-set-speed. There is a window of time while the new block job is running but block-job-set-speed has not been processed yet. This seri

[Qemu-devel] [PATCH v2 4/6] block: add 'speed' optional parameter to block-stream

2012-04-24 Thread Stefan Hajnoczi
Allow streaming operations to be started with an initial speed limit. This eliminates the window of time between starting streaming and issuing block-job-set-speed. Users should use the new optional 'speed' parameter instead so that speed limits are in effect immediately when the job starts. Sign

[Qemu-devel] [PATCH v2 3/6] block: change block-job-set-speed argument from 'value' to 'speed'

2012-04-24 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- block.c |6 +++--- block/stream.c |8 block_int.h |4 ++-- blockdev.c |4 ++-- hmp-commands.hx |4 ++-- qapi-schema.json |4 ++-- qmp-commands.hx |2 +- 7 files changed, 16 insertions(+), 16 deletions(

Re: [Qemu-devel] [PATCH] qxl: don't assert on guest create_guest_primary

2012-04-24 Thread Gerd Hoffmann
>> Allowing guests to do that without giving them a way to figure whenever >> it will work or not doesn't look that useful to me. > > OK - so maybe just have this as a guest_bug instead of an assert? Yes, please. thanks, Gerd

Re: [Qemu-devel] KVM call agenda for April, Tuesday 24

2012-04-24 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please send in any agenda items you are interested in covering. > > Thanks, Juan. As there are no topic, call is cancelled. Happy hacking, Juan.

Re: [Qemu-devel] [PATCHv2 2/3] virtio: add missing mb() on enable notification

2012-04-24 Thread Paolo Bonzini
Il 23/04/2012 15:19, Michael S. Tsirkin ha scritto: > @@ -694,7 +698,7 @@ static bool vring_notify(VirtIODevice *vdev, VirtQueue > *vq) > uint16_t old, new; > bool v; > /* We need to expose used array entries before checking used event. */ > -mb(); > +smp_mb(); This mb() is

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Michael S. Tsirkin
On Tue, Apr 24, 2012 at 05:10:23PM +0530, Amit Shah wrote: > > Sure. So fix it for single port now and for multiport in a > > separate patch. Alon's patch is a single line and it made sense, yours > > differs in that you have added more code to implement a bug. > > Disagree; it was not obvious in

Re: [Qemu-devel] Assertion after chaning display resolution

2012-04-24 Thread Alon Levy
On Tue, Apr 24, 2012 at 03:24:31PM +0200, Peter Lieven wrote: > Hi all, > > I saw the following assert after chaning display resolution. This might be > the cause, but i am not sure. Threaded VNC is enabled. > Anyone ever seen this? > > qemu-kvm-1.0: malloc.c:3096: sYSMALLOc: Assertion `(old_top

Re: [Qemu-devel] [PATCH v2 00/15] QOM'ify x86 CPU, part 2: properties

2012-04-24 Thread Igor Mammedov
Series looks good to me. Reviewed-By: Igor Mammedov On 04/24/2012 11:33 AM, Andreas Färber wrote: Hello, This series introduces some QOM properties for X86CPU, so that our built-in init code exercises the same code paths as QMP, as suggested by Eduardo: * "family", * "model", * "stepping" and

[Qemu-devel] [RFC PATCH 1/1] virtio-serial-bus: Unset guest_connected at reset and driver reset

2012-04-24 Thread Amit Shah
When a guest driver resets the virtio status to not ready, or when qemu is reset, reset the guest_connected bit and let ports know if they have the guest_close() callback registered. Signed-off-by: Amit Shah --- hw/virtio-serial-bus.c | 28 1 files changed, 28 inse

[Qemu-devel] [PATCH] usb-host: add timeout handler

2012-04-24 Thread Gerd Hoffmann
Add a timeout handler. In case bulk transfers take too long to finish the request will be canceled. The timeout is tunable via property, by default it is 5 seconds. Signed-off-by: Gerd Hoffmann --- hw/usb/host-linux.c | 27 +++ trace-events|1 + 2 files ch

Re: [Qemu-devel] [PATCH 00/15] QOM'ify x86 CPU, part 2: properties

2012-04-24 Thread Eduardo Habkost
On Tue, Apr 24, 2012 at 11:00:49AM +0200, Andreas Färber wrote: > Am 19.04.2012 20:27, schrieb Eduardo Habkost: > > By the way, do you still plan to make cpudefs register new > > classes/types? I remember that you did that on a previous series. > > Generally I do, yes. However the CPU QOM'ificatio

  1   2   3   >