On 11 April 2012 02:50, Anthony Liguori wrote:
> On 04/10/2012 04:24 PM, Peter Maydell wrote:
>> This is still changing the version printed in a bunch of user
>> facing usage and help messages. Please drop those.
>
>
> Why? Changing the help messages is not necessary or useful. We just need to
>
First patch introduces two properties: n_in and n_out.
With these properties one can configure gate to group n_in inputs and pass
them to n_out outputs. Gate will make input groups of n_in/n_out size each, so
n_in must be a multiple of n_out.
This device could be used as stand-alone, so, if somebo
Signed-off-by: Evgeny Voevodin
---
hw/exynos4210.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/exynos4210.c b/hw/exynos4210.c
index f904370..088e96e 100644
--- a/hw/exynos4210.c
+++ b/hw/exynos4210.c
@@ -98,6 +98,8 @@ Exynos4210State *exynos4210_init(MemoryReg
With these properties irq gate could be tuned to mux up to
QDEV_MAX_IRQ inputs and ouputs. Gate will group inputs
into groups of size n_out / n_in each.
Signed-off-by: Evgeny Voevodin
---
hw/exynos4210_gic.c | 60 --
1 files changed, 38 insertion
Il 11/04/2012 04:42, Liu Yuan ha scritto:
> 1) if we use bdrv_close(), we rely on the assumption that backend
> storage will do flushing while interpreting this operation. This
> assumption might not always hold, for e.g, current sheepdog doesn't do
> flushing for bdrv_close(). So bdrv_flush() wil
On 11.04.2012 11:18, Evgeny Voevodin wrote:
With these properties irq gate could be tuned to mux up to
QDEV_MAX_IRQ inputs and ouputs. Gate will group inputs
into groups of size n_out / n_in each.
Oops, incorrect comment. Will send new patch.
Signed-off-by: Evgeny Voevodin
---
hw/exynos421
On Tue, Apr 10, 2012 at 04:07:41PM -0600, Alex Williamson wrote:
> > Some points I remember
> > - power on is better called slot enabled
> > - guests dont actually call _PSX like you want them to
> > (PS3 for sure, in my testing PS0 too), and _EJ0 must
> > remove power
> > - populated slots aft
On 11 April 2012 08:18, Evgeny Voevodin wrote:
> First patch introduces two properties: n_in and n_out.
> With these properties one can configure gate to group n_in inputs and pass
> them to n_out outputs. Gate will make input groups of n_in/n_out size each, so
> n_in must be a multiple of n_out.
Am 10.04.2012 20:10, schrieb Liu Yuan:
> From: Liu Yuan
>
> The 'qemu-img convert -h' advertise that the default cache mode is
> 'writeback', while in fact it is 'unsafe'.
>
> This patch 1) changes the cache mode as 'writeback' and 2) explicitly
> calls bdrv_flush() to flush the dirty bits.
>
>
On 11.04.2012 11:41, Peter Maydell wrote:
On 11 April 2012 08:18, Evgeny Voevodin wrote:
First patch introduces two properties: n_in and n_out.
With these properties one can configure gate to group n_in inputs and pass
them to n_out outputs. Gate will make input groups of n_in/n_out size each,
With these properties irq gate could be tuned to mux up to
QDEV_MAX_IRQ inputs and ouputs. Gate will group inputs
into groups of size n_in/n_out each.
Signed-off-by: Evgeny Voevodin
---
hw/exynos4210_gic.c | 60 --
1 files changed, 38 insertions(
On Thu, Apr 05, 2012 at 11:07:01AM -0600, Alex Williamson wrote:
> Incorporating feedback from v1. Re-ordered so first 2 patches are fixes,
> allowing easier backport. Instead of declaring the eject register is
> write-only we define it to be a feature bits register and define the base
> feature
On 04/11/2012 03:32 PM, Paolo Bonzini wrote:
> Il 11/04/2012 04:42, Liu Yuan ha scritto:
>> 1) if we use bdrv_close(), we rely on the assumption that backend
>> storage will do flushing while interpreting this operation. This
>> assumption might not always hold, for e.g, current sheepdog doesn't
On 5 April 2012 16:48, Igor Mitsyanko wrote:
> For the sake of code clarity
>
> Signed-off-by: Igor Mitsyanko
> ---
> hw/sd.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/sd.c b/hw/sd.c
> index e1c998c..7160e8c 100644
> --- a/hw/sd.c
> +++ b/hw/sd.c
> @@ -5
On 04/11/2012 03:49 PM, Kevin Wolf wrote:
> I don't agree with this patch. If the documentation says that qemu-img
> always uses writeback, then the documentation must be fixed.
>
> We really don't care about flushes during an image conversion. It should
> just go as fast as it can. If any error
Michael Roth wrote:
> On Mon, Mar 19, 2012 at 11:57:29PM +0100, Juan Quintela wrote:
>> Some cpu's definitions define CPU_SAVE_VERSION, others not, but they have
>> defined cpu_save/load.
>
> I'm guessing this patch becomes useful later in the series, but as it stands
> I'm not seeing where this h
Michael Roth wrote:
> On Mon, Mar 19, 2012 at 11:57:31PM +0100, Juan Quintela wrote:
>> Signed-off-by: Juan Quintela
>> ---
>> target-unicore32/cpu.h |2 --
>> 1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/target-unicore32/cpu.h b/target-unicore32/cpu.h
>> index a3f858
On 5 April 2012 16:48, Igor Mitsyanko wrote:
> @@ -536,8 +541,8 @@ static void sd_function_switch(SDState *sd, uint32_t arg)
>
> static inline int sd_wp_addr(SDState *sd, uint32_t addr)
> {
> - return sd->wp_groups[addr >>
> - (HWBLOCK_SHIFT + SECTOR_SHIFT + WPGROUP_SHIFT)];
> +
Am 11.04.2012 03:01, schrieb David Gibson:
> On Fri, Apr 06, 2012 at 06:17:10PM +0200, Andreas Färber wrote:
>> Move code from cpu_ppc_init() into an initfn.
>>
>> Signed-off-by: Andreas Färber
>
> This will conflict with my patch which factors out the fiddling with
> the thread numbers into a ho
Peter Maydell wrote:
> On 19 March 2012 22:57, Juan Quintela wrote:
>> + /* Fields needed as intermediate for vmstate */
>> + target_ulong sdr1_vmstate;
>
> Personally I prefer how alpha handles this for fpcr rather than
> clogging up the CPUState with an intermediate field. (possibly
> wit
On 5 April 2012 16:48, Igor Mitsyanko wrote:
> @@ -416,8 +421,9 @@ static void sd_reset(SDState *sd, BlockDriverState *bdrv)
> if (sd->wp_groups)
> g_free(sd->wp_groups);
> sd->wp_switch = bdrv ? bdrv_is_read_only(bdrv) : false;
> + sd->wpgrps_size = BITS_TO_LONGS(sect);
> s
On 5 April 2012 16:48, Igor Mitsyanko wrote:
> A straightforward conversion of SD card implementation to a proper QEMU
> object.
>
> Signed-off-by: Igor Mitsyanko
> ---
> hw/milkymist-memcard.c | 24 ++--
> hw/omap_mmc.c | 28
> hw/p
Am 11.04.2012 12:05, schrieb Liu Yuan:
> On 04/11/2012 03:49 PM, Kevin Wolf wrote:
>
>> I don't agree with this patch. If the documentation says that qemu-img
>> always uses writeback, then the documentation must be fixed.
>>
>> We really don't care about flushes during an image conversion. It sho
If the BlockDriverState is closed/freed without draining the AIO
requests first, the request coroutines may work on invalid data and file
descriptors or have some dangling pointers that cause segfaults.
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/032 | 69 +
If an AIO request is in flight that refers to a BlockDriverState that
has been closed and possibly even freed, more or less anything could
happen. I have seen segfaults, -EBADF return values and qcow2 sometimes
actually catches the situation in bdrv_close() and abort()s.
Signed-off-by: Kevin Wolf
Kevin Wolf (3):
qemu-iotests: Always filter cluster_size out in _make_test_img
qemu-iotests: Test bdrv_close while AIO is in flight
block: Drain requests in bdrv_close
block.c |2 +
tests/qemu-iotests/013.out |2 +-
tests/qemu-iotests/014.out |2 +-
test
Some image formats do have a cluster size, others don't, but there are
tests that work with both sets of images and currently we get failures
because the qemu-img create output doesn't mention the cluster size for
some formats.
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/013.out |2 +-
Commit afe0a595356192d5f79703cf6462fcc112df007c ("rtl8139: support byte
read to TxStatus registers") reused rtl8139_TxStatus_read() for reading
TxAddr registers. It relies on the fact that TxStatus[] and TxAddr[]
are adjacent.
This causes a gcc warning because the compiler can detect that array
a
On Wed, Apr 11, 2012 at 12:07 AM, wrote:
> The Buildbot has detected a new failure on builder default_x86_64_fedora16
> while building qemu.
> Full details are available at:
> http://buildbot.b1-systems.de/qemu/builders/default_x86_64_fedora16/builds/230
I just sent a fix for this rtl8139 issu
On 04/11/2012 02:26 PM, Peter Maydell wrote:
On 5 April 2012 16:48, Igor Mitsyanko wrote:
A straightforward conversion of SD card implementation to a proper QEMU object.
Signed-off-by: Igor Mitsyanko
---
hw/milkymist-memcard.c | 24 ++--
hw/omap_mmc.c | 28
Serge,
This is a KVM base machine which faced the issue not a guest machine.
In kern.log there was no Call Trace found during the time of issue.
Also nothing was found in /var/crash/* too.
Are you aware of any possible reason due to which its not logged in any of
the log files?
-Rahul N.
On Tue,
Also FYI:
OS: Ubuntu 10.04
kernel: 2.6.32-28
-Rahul N.
On Wed, Apr 11, 2012 at 4:49 PM, Rahul Nair
wrote:
> Serge,
>
> This is a KVM base machine which faced the issue not a guest machine.
> In kern.log there was no Call Trace found during the time of issue.
> Also nothing was found in /var/cr
On Wed, Apr 4, 2012 at 5:38 PM, Frediano Ziglio wrote:
> Anybody considered this problem?
In QEMU there are a few different types of memory allocation:
1. Internal data structures allocated at startup. This happens before
the VM is running exiting on out-of-memory is fine here.
2. Transient al
On Tue, Apr 3, 2012 at 5:37 PM, Chris Webb wrote:
> Stefan Hajnoczi writes:
>
>
>> >> Are you sure no other guest has the same MAC address or IP address?
>> >> This weird behavior sounds similar to what happens when you have
>> >> multiple devices on a network using the same address - the results
Am 19.03.2012 23:57, schrieb Juan Quintela:
> Added sdr1_vmstate because storing the value requires calling
> ppc_store_sdr1().
> The position when the function is called also changes (I think it is save).
>
> Signed-off-by: Juan Quintela
> ---
> target-ppc/cpu.h |5 +-
> target-ppc/mac
On 04/11/2012 02:12 PM, Peter Maydell wrote:
On 5 April 2012 16:48, Igor Mitsyanko wrote:
@@ -536,8 +541,8 @@ static void sd_function_switch(SDState *sd, uint32_t arg)
static inline int sd_wp_addr(SDState *sd, uint32_t addr)
{
I've just noticed that it truncates addr to 32 bits... And te
On 11 April 2012 12:57, Igor Mitsyanko wrote:
> On 04/11/2012 02:12 PM, Peter Maydell wrote:
>>
>> On 5 April 2012 16:48, Igor Mitsyanko wrote:
>>>
>>> @@ -536,8 +541,8 @@ static void sd_function_switch(SDState *sd, uint32_t
>>> arg)
>>>
>>> static inline int sd_wp_addr(SDState *sd, uint32_t add
Am 11.04.2012 13:14, schrieb Igor Mitsyanko:
>
>
> On 04/11/2012 02:26 PM, Peter Maydell wrote:
>> On 5 April 2012 16:48, Igor Mitsyanko wrote:
>>> A straightforward conversion of SD card implementation to a proper
>>> QEMU object.
>>>
>>> Signed-off-by: Igor Mitsyanko
>>> ---
>>> hw/milkymist
Am 11.04.2012 12:33, schrieb Kevin Wolf:
> Am 11.04.2012 12:05, schrieb Liu Yuan:
>> On 04/11/2012 03:49 PM, Kevin Wolf wrote:
>>
>>> I don't agree with this patch. If the documentation says that qemu-img
>>> always uses writeback, then the documentation must be fixed.
>>>
>>> We really don't care
On 5 April 2012 16:48, Igor Mitsyanko wrote:
> -#define SD_INIT(sd, bdrv, is_spi) (SD_GET_CLASS(sd)->init(sd, bdrv,
> is_spi))
> +#define SD_INIT(sd, bdrv, is_spi) (SD_GET_CLASS(sd)->init(sd, is_spi))
> diff --git a/hw/ssi-sd.c b/hw/ssi-sd.c
> index beecc0e..38057ba 100644
> --- a/hw/ssi-sd.
On Tue, Apr 3, 2012 at 5:32 PM, Kevin Wolf wrote:
> Some bugs related to rewriting the qcow2 header (as it happens e.g. during
> qemu-img rebase) have been fixed recently. Here is the test case for it.
>
> Kevin Wolf (2):
> qemu-iotests: qcow2.py
> qemu-iotests: Test unknown qcow2 header extensi
On 04/11/2012 04:17 PM, Andreas Färber wrote:
Am 11.04.2012 13:14, schrieb Igor Mitsyanko:
On 04/11/2012 02:26 PM, Peter Maydell wrote:
On 5 April 2012 16:48, Igor Mitsyanko wrote:
A straightforward conversion of SD card implementation to a proper
QEMU object.
Signed-off-by: Igor Mitsyan
Il 11/04/2012 12:40, Kevin Wolf ha scritto:
> Kevin Wolf (3):
> qemu-iotests: Always filter cluster_size out in _make_test_img
> qemu-iotests: Test bdrv_close while AIO is in flight
> block: Drain requests in bdrv_close
>
> block.c |2 +
> tests/qemu-iotests/013.out
Am 10.04.2012 14:10, schrieb Andreas Färber:
> Am 10.04.2012 12:32, schrieb Peter Maydell:
>> On 10 April 2012 11:30, Andreas Färber wrote:
>>> Independent of what frequency of machine versions we offer, I think
>>> defaulting to pc-1.0 is a bad idea. The people fiddling with QEMU
>>> command line
Peter Maydell wrote:
> Remove some useless uses of ARCH_CFLAGS -- this variable was never set
> so will always be empty. The uses were accidental: in commit 0c439cbf8
> Juan Quintela removed ARCH_CFLAGS in favour of CFLAGS (which in turn
> became QEMU_CFLAGS). However in commit be17dc90 a use of i
On Tue, Apr 10, 2012 at 6:47 PM, Stefan Hajnoczi wrote:
>
> On Wed, Apr 4, 2012 at 12:44 PM, Izik Eidus
> wrote:
> > What about this patch?, everything that was asked from Dmitry was
> > accomplished...
> > What prevent us from progressing with merging this patch?
>
> Hang on, I asked what the po
Signed-off-by: Stefano Stabellini
---
hw/xen_backend.c | 17 +
hw/xen_disk.c|4
2 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/hw/xen_backend.c b/hw/xen_backend.c
index d876cab..555da41 100644
--- a/hw/xen_backend.c
+++ b/hw/xen_backend.c
@@ -589,7
> s->pc is updated each time a byte of code is fetched, when an instruction
> is fully decoded s->pc points to the first byte of the next instruction. I see
> that it only makes difference when a branching instruction ends exactly at
> a page boundary. In this case (s->pc - 1) prevents from linking
Quoting Rahul (rahul.n...@finicity.com):
> Serge,
>
> This is a KVM base machine which faced the issue not a guest machine.
Yes, but it's possible that using the same guest OS will make reproducing
the bug possible. Since there isn't enough collected debug info, I'll
need to be able to reproduce
In future I'd prefer if all patches had a description. In this case I'd say
what devices are being added. Hint: it's more than just the I2C controller.
> Signed-off-by: Oskar Andero
Acked-by: Paul Brook
On Tue, Apr 10, 2012 at 04:47:19PM +0100, Stefan Hajnoczi wrote:
> On Wed, Apr 4, 2012 at 12:44 PM, Izik Eidus
> wrote:
> > What about this patch?, everything that was asked from Dmitry was
> > accomplished...
> > What prevent us from progressing with merging this patch?
>
> Hang on, I asked what
On 11 April 2012 14:50, Paul Brook wrote:
>> +++ b/hw/versatile_i2c.c
>> @@ -0,0 +1,102 @@
>> +/*
>> + * Versatile I2C controller
>
> I'd go for "ARM Versatile I2C controller".
Strictly speaking, the ARM devboard manuals don't actually
call this an I2C controller, it's a "custom two-wire serial
b
Am 10.04.2012 20:06, schrieb Eric Blake:
Is there any policy on _ vs - in command names? It seems awkward to
have block_job_cancel but query-block-jobs.
>>>
>>> block_job_cancel is HMP, whereas query-block-jobs is a QMP command. QMP
>>> uses - consistently. Not sure if HMP is consistent,
On Wed, 11 Apr 2012 16:01:26 +0200
Kevin Wolf wrote:
> > Is it too late to rename the QMP command to 'block-job-cancel'?
>
> Streaming hasn't been in any release yet, so in theory I guess we could
> rename the commands.
Yes, we've just discussed this on irc and all involved parties are ok
with
On Wed, Apr 11, 2012 at 3:01 PM, Kevin Wolf wrote:
> Am 10.04.2012 20:06, schrieb Eric Blake:
> Is there any policy on _ vs - in command names? It seems awkward to
> have block_job_cancel but query-block-jobs.
block_job_cancel is HMP, whereas query-block-jobs is a QMP command. Q
> >> static uint32_t addr_to_wpnum(uint64_t addr) {
> >> return addr>> (HWBLOCK_SHIFT + SECTOR_SHIFT + WPGROUP_SHIFT);
> >> }
> >
> > This implicitly limits max address to 0x << (HWBLOCK_SHIFT +
> > SECTOR_SHIFT + WPGROUP_SHIFT), have you done this on purpose?
>
> You could argue for
On 04/11/2012 08:27 PM, Kevin Wolf wrote:
> Am 11.04.2012 12:33, schrieb Kevin Wolf:
>> Am 11.04.2012 12:05, schrieb Liu Yuan:
>>> On 04/11/2012 03:49 PM, Kevin Wolf wrote:
>>>
I don't agree with this patch. If the documentation says that qemu-img
always uses writeback, then the document
On Wed, Apr 11, 2012 at 2:53 PM, Daniel P. Berrange wrote:
> On Tue, Apr 10, 2012 at 04:47:19PM +0100, Stefan Hajnoczi wrote:
>> On Wed, Apr 4, 2012 at 12:44 PM, Izik Eidus
>> wrote:
>> > What about this patch?, everything that was asked from Dmitry was
>> > accomplished...
>> > What prevent us f
On 04/11/2012 02:14 AM, Peter Maydell wrote:
On 11 April 2012 02:50, Anthony Liguori wrote:
On 04/10/2012 04:24 PM, Peter Maydell wrote:
This is still changing the version printed in a bunch of user
facing usage and help messages. Please drop those.
Why? Changing the help messages is not ne
From: Liu Yuan
The 'qemu-img convert -h' advertise that the default cache mode is
'writeback', while in fact it is 'unsafe'.
This patch 1) fix the help manual and 2) let bdrv_close() call bdrv_flush()
3) explicitly calls bdrv_close() to flush the dirty bits.
3) is needed because some backend st
On Wed, Apr 11, 2012 at 2:38 PM, Yan Vugenfirer wrote:
> On Tue, Apr 10, 2012 at 6:47 PM, Stefan Hajnoczi wrote:
>>
>> On Wed, Apr 4, 2012 at 12:44 PM, Izik Eidus
>> wrote:
>> > What about this patch?, everything that was asked from Dmitry was
>> > accomplished...
>> > What prevent us from progr
Il 11/04/2012 11:58, Liu Yuan ha scritto:
>>> >> 2) explicit flushing is more maintainable, we don't need to guess if it
>>> >> does flushing internally if we use other function that flush implicitly.
>> >
>> > I think it is reasonable semantics that closing gets all data to storage.
>> >
>
> Y
2011/11/9 Benoît Canet :
> Signed-off-by: Benoit Canet
> Reviewed-by: Peter Maydell
> ---
> target-arm/cpu.h | 4
> 1 files changed, 4 insertions(+), 0 deletions(-)
I've put this in target-arm.next now that the linux-user
half of the patch has gone into master.
-- PMM
> diff --git a/t
Il 11/04/2012 16:46, Liu Yuan ha scritto:
> From: Liu Yuan
>
> The 'qemu-img convert -h' advertise that the default cache mode is
> 'writeback', while in fact it is 'unsafe'.
>
> This patch 1) fix the help manual and 2) let bdrv_close() call bdrv_flush()
> 3) explicitly calls bdrv_close() to flu
On 11 April 2012 08:48, Evgeny Voevodin wrote:
> With these properties irq gate could be tuned to mux up to
> QDEV_MAX_IRQ inputs and ouputs. Gate will group inputs
> into groups of size n_in/n_out each.
>
> Signed-off-by: Evgeny Voevodin
> ---
> hw/exynos4210_gic.c | 60 ++
On 04/11/2012 11:01 PM, Paolo Bonzini wrote:
> bdrv_delete already does this.
>
> Paolo
Ah yes. Thanks pointing out.
>From 459414f677f6449482f9cfcb7917ff0e242ad490 Mon Sep 17 00:00:00 2001
From: Liu Yuan
Date: Wed, 11 Apr 2012 23:19:54 +0800
Subject: [PATCH v3] qemu-img: let 'qemu-img convert
The block streaming and job commands used '_' instead of '-' for reasons
of compatibility with libvirt, which already included support for the
'_' naming. However, the semantics of block_job_cancel have changed and
libvirt now needs to handle the new semantics.
Since the old semantics were never
On 11 April 2012 08:18, Evgeny Voevodin wrote:
> Signed-off-by: Evgeny Voevodin
> ---
> hw/exynos4210.c | 6 --
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hw/exynos4210.c b/hw/exynos4210.c
> index f904370..088e96e 100644
> --- a/hw/exynos4210.c
> +++ b/hw/exynos42
On 04/11/2012 09:27 AM, Stefan Hajnoczi wrote:
> The block streaming and job commands used '_' instead of '-' for reasons
> of compatibility with libvirt, which already included support for the
> '_' naming. However, the semantics of block_job_cancel have changed and
> libvirt now needs to handle
Jan, Anthony, any opinions on this patch?
If it is OK for you, I am going to include it in the next Xen pull request.
On Thu, 5 Apr 2012, Wei Liu (Intern) wrote:
>
> Signed-off-by: Wei Liu
> ---
> Makefile.target |2 +-
> hw/pc.c |8 +
> hw/xen_apic.c | 90
> ++
On 2012-04-11 18:02, Stefano Stabellini wrote:
> Jan, Anthony, any opinions on this patch?
> If it is OK for you, I am going to include it in the next Xen pull request.
>
Looks good to me.
Jan
>
> On Thu, 5 Apr 2012, Wei Liu (Intern) wrote:
>>
>> Signed-off-by: Wei Liu
>> ---
>> Makefile.tar
On 5 April 2012 10:35, Wei Liu wrote:
>
> --- /dev/null
> +++ b/hw/xen_apic.c
> @@ -0,0 +1,90 @@
> +/*
> + * Xen basic APIC support
> + *
> + * Copyright (c) 2012 Citrix
> + *
> + * Authors:
> + * Wei Liu
> + *
> + * This work is licensed under the terms of the GNU GPL version 2.
> + * See the C
On 2012-04-11 18:07, Peter Maydell wrote:
>> +#include "hw/apic_internal.h"
>> +#include "hw/msi.h"
>> +#include "xen.h"
>> +
>> +static uint64_t xen_apic_mem_read(void *opaque, target_phys_addr_t addr,
>> + unsigned size)
>> +{
>> +return -1U;
>> +}
>
> This s
On Wed, 11 Apr 2012, Peter Maydell wrote:
> On 5 April 2012 10:35, Wei Liu wrote:
> >
> > --- /dev/null
> > +++ b/hw/xen_apic.c
> > @@ -0,0 +1,90 @@
> > +/*
> > + * Xen basic APIC support
> > + *
> > + * Copyright (c) 2012 Citrix
> > + *
> > + * Authors:
> > + * Wei Liu
> > + *
> > + * This work
On Wed, 11 Apr 2012, Stefano Stabellini wrote:
> On Wed, 11 Apr 2012, Peter Maydell wrote:
> > On 5 April 2012 10:35, Wei Liu wrote:
> > >
> > > --- /dev/null
> > > +++ b/hw/xen_apic.c
> > > @@ -0,0 +1,90 @@
> > > +/*
> > > + * Xen basic APIC support
> > > + *
> > > + * Copyright (c) 2012 Citrix
>
On 11 April 2012 17:13, Jan Kiszka wrote:
> On 2012-04-11 18:07, Peter Maydell wrote:
>>> +#include "hw/apic_internal.h"
>>> +#include "hw/msi.h"
>>> +#include "xen.h"
>>> +
>>> +static uint64_t xen_apic_mem_read(void *opaque, target_phys_addr_t addr,
>>> + unsigne
Move XtensaConfig-independent code from cpu_xtensa_init() into a
QOM initfn, as a start.
Signed-off-by: Andreas Färber
---
target-xtensa/cpu.c|9 +
target-xtensa/helper.c |1 -
2 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/target-xtensa/cpu.c b/target-xtensa/
Embed CPUXtensaState as first member of XtensaCPU.
Let CPUClass::reset() call cpu_state_reset() for now.
Signed-off-by: Andreas Färber
---
Makefile.target |1 +
target-xtensa/cpu-qom.h | 80 +++
target-xtensa/cpu.c | 69
Move code from cpu_state_reset() into QOM xtensa_cpu_reset().
To avoid moving reset_mmu() and dependencies, make it non-static.
Signed-off-by: Andreas Färber
---
target-xtensa/cpu.c| 12 +++-
target-xtensa/cpu.h|1 +
target-xtensa/helper.c | 15 ++-
3 files ch
Hello Max,
This series strips down my Xtensa QOM'ification patch from the qom-cpu-others.v1
RFC series, avoiding the XtensaConfig vs. subclass problem and taking care
not to introduce "klass", including in the header file.
I've tested this with the dc232b semihosting test image.
Please review an
Am 11.04.2012 18:24, schrieb Andreas Färber:
> Hello Max,
>
> This series strips down my Xtensa QOM'ification patch from the
> qom-cpu-others.v1
> RFC series, avoiding the XtensaConfig vs. subclass problem and taking care
> not to introduce "klass", including in the header file.
>
> I've tested
On 04/10/2012 10:20 AM, Andreas Färber wrote:
Hello Anthony or Blue,
Please pull the x86 QOM CPU conversion.
Cc: Anthony Liguori
Cc: Blue Swirl
The following changes since commit 4e1957acc854b2f3f3068c75cef2a429f9b97011:
Merge commit 'ff71f2e8cacefae99179993204172bc65e4303df' into staging
On 04/04/2012 02:39 PM, Michael S. Tsirkin wrote:
On Wed, Apr 04, 2012 at 02:44:01PM +0300, Izik Eidus wrote:
Hi,
What about this patch?, everything that was asked from Dmitry was
accomplished...
What prevent us from progressing with merging this patch?
Thanks.
Off the top of my head: issues
When block streaming an image, if a base name is passed in that
is a relative name, but not accessible from the top-level snapshot,
then the relative name is stored incorrectly in the image file.
For instance, given a snapshot case of:
/tmp/a/base.raw
/tmp/a/snap1.qcow2
/tmp/b/snap2.qcow2
if the
On 04/10/2012 10:47 AM, Stefan Hajnoczi wrote:
On Wed, Apr 4, 2012 at 12:44 PM, Izik Eidus
wrote:
What about this patch?, everything that was asked from Dmitry was
accomplished...
What prevent us from progressing with merging this patch?
Hang on, I asked what the point of the VMware paravirt
Add ds1338 rtc attached on i2c.
Signed-off-by: Oskar Andero
---
hw/versatilepb.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/hw/versatilepb.c b/hw/versatilepb.c
index 25afb1e..d011554 100644
--- a/hw/versatilepb.c
+++ b/hw/versatilepb.c
@@ -13,6 +13,7 @@
#inclu
On Sun, 1 Apr 2012 22:50:57 -0300
Luiz Capitulino wrote:
> On Sat, 31 Mar 2012 12:50:21 +0200
> Paolo Bonzini wrote:
>
> > The special target should not be needed anymore, and caused (perhaps
> > due to a Make bug) a failure with "make -j2". In any case, the
> > main makefile is a better place
On Wed, 11 Apr 2012 16:27:10 +0100
Stefan Hajnoczi wrote:
> The block streaming and job commands used '_' instead of '-' for reasons
> of compatibility with libvirt, which already included support for the
> '_' naming. However, the semantics of block_job_cancel have changed and
> libvirt now nee
On 04/11/2012 10:17 AM, Stefano Stabellini wrote:
> On Wed, 11 Apr 2012, Peter Maydell wrote:
>> On 5 April 2012 10:35, Wei Liu wrote:
>>>
>>> --- /dev/null
>>> +++ b/hw/xen_apic.c
>>> @@ -0,0 +1,90 @@
>>> +/*
>>> + * Xen basic APIC support
>>> + *
>>> + * Copyright (c) 2012 Citrix
>>> + *
>>> + *
Hi,
Just some small updates since last version based on the review comments:
- Rephrased commit message on last patch.
- Updated file header on versatile_i2c.c.
-Oskar
Oskar Andero (2):
realview: break out versatile i2c controller code
versatilepb: add ds1338 rtc device
Makefile.target
The versatile i2c controller implementation was separated to
its own file called versatile_i2c.c. This is done as a preparation
for adding i2c support to the versatilepb board.
Signed-off-by: Oskar Andero
---
Makefile.target|1 +
hw/realview.c | 83 +---
Changes from v8:
Implement more effiecent cache_resize method
fix set_cachesize command comments
Changes from v7:
Copy current page before encoding it, this will prevents page content
change during the encoding.
Allow changing the cache size during an active
Implement Unsigned Little Endian Base 128.
Signed-off-by: Orit Wasserman
---
migration.h |4
savevm.c| 28
2 files changed, 32 insertions(+), 0 deletions(-)
diff --git a/migration.h b/migration.h
index 691b367..d798fac 100644
--- a/migration.h
+++ b/m
Add LRU page cache mechanism.
The page are accessed by their address.
Signed-off-by: Orit Wasserman
Signed-off-by: Benoit Hudzia
Signed-off-by: Petter Svard
Signed-off-by: Aidan Shribman
---
arch_init.c | 220 +++
1 files changed, 220 i
Signed-off-by: Orit Wasserman
Signed-off-by: Benoit Hudzia
Signed-off-by: Petter Svard
Signed-off-by: Aidan Shribman
---
hmp-commands.hx | 20
hmp.c|4 +++-
migration.c |9 +
qapi-schema.json |2 +-
qmp-commands.hx |4 +++-
5 fi
On 04/11/2012 06:01 AM, Stefan Hajnoczi wrote:
Commit afe0a595356192d5f79703cf6462fcc112df007c ("rtl8139: support byte
read to TxStatus registers") reused rtl8139_TxStatus_read() for reading
TxAddr registers. It relies on the fact that TxStatus[] and TxAddr[]
are adjacent.
This causes a gcc war
On Wed, Apr 11, 2012 at 6:27 PM, Anthony Liguori wrote:
> On 04/10/2012 10:47 AM, Stefan Hajnoczi wrote:
>>
>> On Wed, Apr 4, 2012 at 12:44 PM, Izik Eidus
>> wrote:
>>>
>>> What about this patch?, everything that was asked from Dmitry was
>>> accomplished...
>>> What prevent us from progressing
Signed-off-by: Isaku Yamahata
---
block-migration.c |8
migration.c | 13 -
migration.h |9 +++--
qemu-common.h |1 +
savevm.c | 11 ---
sysemu.h |3 ++-
vmstate.h |2 +-
7 files changed, 31 inserti
Il 11/04/2012 19:25, Anthony Liguori ha scritto:
>>
>> Off the top of my head: issues with v5:
>> polluting global namespace, must scope names
>> appropriately with vmxnet_ VMXNET_ unless they have file scope.
>> Don't use names with _ followed by an upper case letter
>> or that star with two under
On 04/11/2012 02:08 PM, Paolo Bonzini wrote:
Il 11/04/2012 19:25, Anthony Liguori ha scritto:
Off the top of my head: issues with v5:
polluting global namespace, must scope names
appropriately with vmxnet_ VMXNET_ unless they have file scope.
Don't use names with _ followed by an upper case let
1 - 100 of 198 matches
Mail list logo
