On 04/04/2012 02:39 PM, Michael S. Tsirkin wrote:
On Wed, Apr 04, 2012 at 02:44:01PM +0300, Izik Eidus wrote:
Hi,
What about this patch?, everything that was asked from Dmitry was
accomplished...
What prevent us from progressing with merging this patch?
Thanks.
Off the top of my head: issues with v5:
polluting global namespace, must scope names
appropriately with vmxnet_ VMXNET_ unless they have file scope.
Don't use names with _ followed by an upper case letter
or that star with two underscores. Don't mix underscores and mixed case.
Don't stick any new types in net.c/pci.c - new devices should use -device
not -net. Global stuff like ethernet header size
should move to central place instead of copy paste.
I'd like to see qtest test cases for this too.
Regards,
Anthony Liguori
On 18/03/2012 11:27, Dmitry Fleytman wrote:
Signed-off-by: Dmitry Fleytman<dmi...@daynix.com>
Signed-off-by: Yan Vugenfirer<y...@daynix.com>
---
Makefile.objs | 1 +
default-configs/pci.mak | 1 +
hw/pci.c | 2 +
hw/pci.h | 1 +
hw/vmxnet3.c | 2454 +++++++++++++++++++++++++++++++++++++++++++++++
hw/vmxnet3.h | 757 +++++++++++++++
net.c | 2 +-
7 files changed, 3217 insertions(+), 1 deletions(-)
create mode 100644 hw/vmxnet3.c
create mode 100644 hw/vmxnet3.h
