Re: [Qemu-devel] [PATCH v2 1/2] pl330: initial version

2012-04-05 Thread Andreas Färber
Am 30.03.2012 09:58, schrieb Peter A. G. Crosthwaite: > Device model for Primecell PL330 dma controller. > > Signed-off-by: Peter A. G. Crosthwaite > Signed-off-by: Kirill Batuzov > --- > changed from v1: > GPLv2 license > some code formatting fixes [...] > diff --git a/hw/pl330.c b/hw/pl330.c >

Re: [Qemu-devel] [RFC PATCH v1 1/4] SPI: initial support

2012-04-05 Thread Peter Maydell
On 5 April 2012 01:32, Peter Crosthwaite wrote: > 3: add support for flagging sdi/sdo bits as tristated: > > --- a/hw/ssi.h > +++ b/hw/ssi.h > @@ -28,7 +28,11 @@ typedef struct SSISlaveClass { >     DeviceClass parent_class; > >     int (*init)(SSISlave *dev); > -    uint32_t (*transfer)(SSISlave

Re: [Qemu-devel] [PATCH] configure: Remove useless uses of ARCH_CFLAGS

2012-04-05 Thread Andreas Färber
Am 04.04.2012 18:03, schrieb Peter Maydell: > Remove some useless uses of ARCH_CFLAGS -- this variable was never set > so will always be empty. The uses were accidental: in commit 0c439cbf8 > Juan Quintela removed ARCH_CFLAGS in favour of CFLAGS (which in turn > became QEMU_CFLAGS). However in comm

Re: [Qemu-devel] [Xen-devel] [PATCH v2] qemu/configure: fix CFLAGS handling for i386

2012-04-05 Thread Andreas Färber
Am 04.04.2012 18:09, schrieb Peter Maydell: > On 4 April 2012 16:40, Peter Maydell wrote: >> Having looked at configure I'm pretty sure what we want here is >> QEMU_CFLAGS="-march=i486 $QEMU_CFLAGS" >> >> because we're only doing this for the benefit of a particular bit >> of code in hw/vhost.c a

Re: [Qemu-devel] [PATCH, RESEND] kvm: Fix dirty tracking with large kernel page size

2012-04-05 Thread Jan Kiszka
On 2012-04-04 16:24, David Gibson wrote: > On Wed, Apr 04, 2012 at 12:58:37PM +0200, Jan Kiszka wrote: >> On 2012-04-04 03:12, David Gibson wrote: Also, what's about coalesced MMIO? I see that the ring definition depends on [TARGET_]PAGE_SIZE. What page size does the power kernel use

Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API

2012-04-05 Thread Paolo Bonzini
Il 04/04/2012 19:19, Jan Kiszka ha scritto: >>> Yep, this screams for something like QemuEvent which pleases all users >>> of current qemu_eventfd and EventNotifier - and fit into the existing >>> threading/synchronization abstraction layout. >>> >> >>> >> Kind of, on Unix you cannot

Re: [Qemu-devel] [PATCH 5/6] main-loop: replace WaitForMultipleObjects with g_poll

2012-04-05 Thread Paolo Bonzini
- Messaggio originale - > Da: "Blue Swirl" > A: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, s...@weilnetz.de > Inviato: Mercoledì, 4 aprile 2012 22:44:12 > Oggetto: Re: [Qemu-devel] [PATCH 5/6] main-loop: replace > WaitForMultipleObjects with g_poll > > On Tue, Mar 20, 2012 at 09:49,

Re: [Qemu-devel] [PATCH 2/5] acpi_piix4: Only allow writes to PCI hotplug eject register

2012-04-05 Thread Igor Mammedov
On 04/05/2012 07:51 AM, Alex Williamson wrote: This is never read. We can also derive bus from the write handler, making this more inline with the other callbacks. Note that pciej_write was actually called with (PCIBus *)dev->bus, which is cast as a void* allowing us to pretend it's a BusState*

[Qemu-devel] Despite of traffic control on host netdevice, is it worth to impose a limit control on qemu emulated net device?

2012-04-05 Thread Liu ping fan
Hi, As we know, in order to control the guest OS's TX rate limit, we can apply rate limit on ingress Qdisc of host's tap device. But I think skb will be dropped on host's tap ingress Qdisc, which means that for those protocol lacking of congestion control such as UDP, it will cost a lot of meaning

Re: [Qemu-devel] Switch off use of helper functions

2012-04-05 Thread 陳韋任
On Wed, Apr 04, 2012 at 02:56:37PM +0100, Rajat Goyal wrote: > Is there any way in QEMU to switch off the use of helper functions and make > it translate target code to TCG code using only TCG micro-ops and not calls > to helper functions? Writing TCG micro-ops to do complicated tasks done by he

Re: [Qemu-devel] [PATCH 5/6] main-loop: replace WaitForMultipleObjects with g_poll

2012-04-05 Thread Peter Maydell
On 5 April 2012 09:12, Paolo Bonzini wrote: > (Also, the lowest common denominator for Linux would be 2.12, not 2.0. ...this doesn't seem to be what configure checks for? AFAICT it just wants something providing gthread-2.0. -- PMM

Re: [Qemu-devel] [PATCH 5/6] main-loop: replace WaitForMultipleObjects with g_poll

2012-04-05 Thread Paolo Bonzini
> On 5 April 2012 09:12, Paolo Bonzini wrote: > > (Also, the lowest common denominator for Linux would be 2.12, not > > 2.0. > > ...this doesn't seem to be what configure checks for? AFAICT it > just wants something providing gthread-2.0. Yes, that's correct. Our checks are way too strict. Pao

Re: [Qemu-devel] [PATCH 2/5] acpi_piix4: Only allow writes to PCI hotplug eject register

2012-04-05 Thread Michael S. Tsirkin
On Thu, Apr 05, 2012 at 10:21:18AM +0200, Igor Mammedov wrote: > On 04/05/2012 07:51 AM, Alex Williamson wrote: > >This is never read. We can also derive bus from the write handler, > >making this more inline with the other callbacks. Note that > >pciej_write was actually called with (PCIBus *)de

Re: [Qemu-devel] [PATCH 2/5] acpi_piix4: Only allow writes to PCI hotplug eject register

2012-04-05 Thread Gleb Natapov
On Thu, Apr 05, 2012 at 12:04:44PM +0300, Michael S. Tsirkin wrote: > On Thu, Apr 05, 2012 at 10:21:18AM +0200, Igor Mammedov wrote: > > On 04/05/2012 07:51 AM, Alex Williamson wrote: > > >This is never read. We can also derive bus from the write handler, > > >making this more inline with the othe

[Qemu-devel] [PATCH 0/0] MSI/MSIX injection for Xen HVM guests

2012-04-05 Thread Wei Liu
Implement a simple Xen APIC module and use it to deliver MSI/MSIX for Xen HVM guests.

[Qemu-devel] [PATCH 1/2] Xen: basic HVM MSI injection support.

2012-04-05 Thread Wei Liu
Signed-off-by: Wei Liu --- hw/xen.h |1 + xen-all.c |5 + xen-stub.c |4 3 files changed, 10 insertions(+), 0 deletions(-) diff --git a/hw/xen.h b/hw/xen.h index b46879c..e5926b7 100644 --- a/hw/xen.h +++ b/hw/xen.h @@ -34,6 +34,7 @@ static inline int xen_enabled(void)

[Qemu-devel] [PATCH 2/2] Xen: Add xen-apic support and hook it up.

2012-04-05 Thread Wei Liu
Signed-off-by: Wei Liu --- Makefile.target |2 +- hw/pc.c |8 + hw/xen_apic.c | 90 +++ 3 files changed, 99 insertions(+), 1 deletions(-) create mode 100644 hw/xen_apic.c diff --git a/Makefile.target b/Makefile.target

Re: [Qemu-devel] [PATCH 2/5] acpi_piix4: Only allow writes to PCI hotplug eject register

2012-04-05 Thread Michael S. Tsirkin
On Thu, Apr 05, 2012 at 12:12:37PM +0300, Gleb Natapov wrote: > On Thu, Apr 05, 2012 at 12:04:44PM +0300, Michael S. Tsirkin wrote: > > On Thu, Apr 05, 2012 at 10:21:18AM +0200, Igor Mammedov wrote: > > > On 04/05/2012 07:51 AM, Alex Williamson wrote: > > > >This is never read. We can also derive

Re: [Qemu-devel] [PATCH 2/5] acpi_piix4: Only allow writes to PCI hotplug eject register

2012-04-05 Thread Gleb Natapov
On Thu, Apr 05, 2012 at 12:37:01PM +0300, Michael S. Tsirkin wrote: > On Thu, Apr 05, 2012 at 12:12:37PM +0300, Gleb Natapov wrote: > > On Thu, Apr 05, 2012 at 12:04:44PM +0300, Michael S. Tsirkin wrote: > > > On Thu, Apr 05, 2012 at 10:21:18AM +0200, Igor Mammedov wrote: > > > > On 04/05/2012 07:5

Re: [Qemu-devel] [PATCH V2 2/7] hw/acpi_piix4.c: replace register_ioport*

2012-04-05 Thread Avi Kivity
On 04/04/2012 09:21 PM, Julien Grall wrote: > This patch replaces all register_ioport* with portio_*. It permits to > use the new Memory stuff like listener. > > > > +static const MemoryRegionPortio piix4_portio_list[] = { > +{ 0x00, 64, 1, .read = smb_ioport_readb, }, /* s->smb_io_base */ >

Re: [Qemu-devel] [PATCH 2/5] acpi_piix4: Only allow writes to PCI hotplug eject register

2012-04-05 Thread Michael S. Tsirkin
On Thu, Apr 05, 2012 at 12:40:00PM +0300, Gleb Natapov wrote: > On Thu, Apr 05, 2012 at 12:37:01PM +0300, Michael S. Tsirkin wrote: > > On Thu, Apr 05, 2012 at 12:12:37PM +0300, Gleb Natapov wrote: > > > On Thu, Apr 05, 2012 at 12:04:44PM +0300, Michael S. Tsirkin wrote: > > > > On Thu, Apr 05, 201

Re: [Qemu-devel] [PATCH] Memory: unify ioport registration

2012-04-05 Thread Avi Kivity
On 04/04/2012 06:55 PM, Julien Grall wrote: >> Should we just remove serial_init() and replace it with the serial-isa >> QOM class? >> > After few researchs, it's seems this function is not used in the > source code. Is that right ? > > It's used in mips_mipssim.c. -- error compiling co

Re: [Qemu-devel] [PATCH 0/5] PCI hotplug fixes/cleanup

2012-04-05 Thread Michael S. Tsirkin
On Wed, Apr 04, 2012 at 11:51:00PM -0600, Alex Williamson wrote: > We've been batting this one back and forth. This series includes > several of the cleanups and specification clarifications from my > series awhile back. Patch 5 is my proposed alternative to > Michael's PCI hotplug race fix. Sin

Re: [Qemu-devel] [PATCH 2/5] acpi_piix4: Only allow writes to PCI hotplug eject register

2012-04-05 Thread Gleb Natapov
On Thu, Apr 05, 2012 at 12:53:55PM +0300, Michael S. Tsirkin wrote: > On Thu, Apr 05, 2012 at 12:40:00PM +0300, Gleb Natapov wrote: > > On Thu, Apr 05, 2012 at 12:37:01PM +0300, Michael S. Tsirkin wrote: > > > On Thu, Apr 05, 2012 at 12:12:37PM +0300, Gleb Natapov wrote: > > > > On Thu, Apr 05, 201

Re: [Qemu-devel] [PATCH] memory: check address space when a listener is registered

2012-04-05 Thread Avi Kivity
On 04/04/2012 05:15 PM, Julien Grall wrote: > This patch resolves a bug in memory listener registration. > "range_add" callback was called on each section of the both > address space (IO and memory space) even if it doesn't match > the address space filter. > Thanks, applied. Did you find this b

Re: [Qemu-devel] [PATCH 0/0] MSI/MSIX injection for Xen HVM guests

2012-04-05 Thread Paolo Bonzini
Il 05/04/2012 11:32, Wei Liu ha scritto: > Implement a simple Xen APIC module and use it to deliver MSI/MSIX for > Xen HVM guests. Only skimmed the patch but yeah, this is what I had in mind. Thanks! Paolo

Re: [Qemu-devel] [PATCH 2/5] acpi_piix4: Only allow writes to PCI hotplug eject register

2012-04-05 Thread Michael S. Tsirkin
On Thu, Apr 05, 2012 at 01:08:06PM +0300, Gleb Natapov wrote: > On Thu, Apr 05, 2012 at 12:53:55PM +0300, Michael S. Tsirkin wrote: > > On Thu, Apr 05, 2012 at 12:40:00PM +0300, Gleb Natapov wrote: > > > On Thu, Apr 05, 2012 at 12:37:01PM +0300, Michael S. Tsirkin wrote: > > > > On Thu, Apr 05, 201

Re: [Qemu-devel] [PATCH 0/0] MSI/MSIX injection for Xen HVM guests

2012-04-05 Thread Stefano Stabellini
On Thu, 5 Apr 2012, Paolo Bonzini wrote: > Il 05/04/2012 11:32, Wei Liu ha scritto: > > Implement a simple Xen APIC module and use it to deliver MSI/MSIX for > > Xen HVM guests. > > Only skimmed the patch but yeah, this is what I had in mind. Thanks! It looks good to me too. Paolo, can I add you

Re: [Qemu-devel] [PATCH 2/5] acpi_piix4: Only allow writes to PCI hotplug eject register

2012-04-05 Thread Gleb Natapov
On Thu, Apr 05, 2012 at 01:20:03PM +0300, Michael S. Tsirkin wrote: > On Thu, Apr 05, 2012 at 01:08:06PM +0300, Gleb Natapov wrote: > > On Thu, Apr 05, 2012 at 12:53:55PM +0300, Michael S. Tsirkin wrote: > > > On Thu, Apr 05, 2012 at 12:40:00PM +0300, Gleb Natapov wrote: > > > > On Thu, Apr 05, 201

[Qemu-devel] [PATCH v8 00/10] XBZRLE delta for live migration of large memory app

2012-04-05 Thread Orit Wasserman
Changes from v7: Copy current page before encoding it, this will prevents page content change during the encoding. Allow changing the cache size during an active migration. Fix comments by Avi. Changes from v6: 1) add assert checks to ULEB encoding/decoding 2) no

[Qemu-devel] [PATCH v8 01/10] Add cache handling functions

2012-04-05 Thread Orit Wasserman
Add LRU page cache mechanism. The page are accessed by their address. Signed-off-by: Orit Wasserman --- arch_init.c | 174 +++ 1 files changed, 174 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index 595badf..42d4f1

[Qemu-devel] [PATCH v8 05/10] Add MigrationParams structure

2012-04-05 Thread Orit Wasserman
Signed-off-by: Isaku Yamahata --- block-migration.c |8 migration.c | 13 - migration.h |9 +++-- qemu-common.h |1 + savevm.c | 11 --- sysemu.h |3 ++- vmstate.h |2 +- 7 files changed, 31 inserti

[Qemu-devel] [PATCH v8 03/10] Add save_block_hdr function

2012-04-05 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- arch_init.c | 25 + 1 files changed, 13 insertions(+), 12 deletions(-) diff --git a/arch_init.c b/arch_init.c index 42d4f17..5f60fa9 100644 --- a/arch_init.c +++ b/arch_init.c @@ -301,6 +301,17 @@ static void cache_insert(unsigned long

[Qemu-devel] [PATCH v8 10/10] Add XBZRLE statstics information

2012-04-05 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- arch_init.c | 68 ++ hmp.c| 11 migration.c | 11 migration.h |9 +++ qapi-schema.json | 21 +++- 5 files changed, 118 insertions(+), 2 de

[Qemu-devel] [PATCH v8 04/10] Add host_from_stream_offset_versioned function

2012-04-05 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- arch_init.c | 26 +++--- 1 files changed, 23 insertions(+), 3 deletions(-) diff --git a/arch_init.c b/arch_init.c index 5f60fa9..cef5d6f 100644 --- a/arch_init.c +++ b/arch_init.c @@ -552,6 +552,18 @@ static inline void *host_from_stream_of

Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API

2012-04-05 Thread Paolo Bonzini
Il 05/04/2012 12:55, Jan Kiszka ha scritto: >> BTW you _could_ have a QemuEvent primitive based on Windows manual-reset >> events. It can be used in some cases as a replacement for condvars, >> especially when you have multiple producers and a single consumer (MPSC >> queue is perhaps the easiest l

Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API

2012-04-05 Thread Jan Kiszka
On 2012-04-05 13:07, Paolo Bonzini wrote: > Il 05/04/2012 12:55, Jan Kiszka ha scritto: >>> BTW you _could_ have a QemuEvent primitive based on Windows manual-reset >>> events. It can be used in some cases as a replacement for condvars, >>> especially when you have multiple producers and a single c

Re: [Qemu-devel] [PATCH v3 01/10] Introduce qemu_cond_timedwait for POSIX

2012-04-05 Thread Peter Maydell
On 5 April 2012 11:59, Jan Kiszka wrote: > +/* Returns true if condition was signals, false if timed out. */ > +bool qemu_cond_timedwait(QemuCond *cond, QemuMutex *mutex, > +                         unsigned int timeout_ms) > +{ > +    struct timespec ts; > +    struct timeval tv; > +    int err;

Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API

2012-04-05 Thread Paolo Bonzini
Il 05/04/2012 13:18, Jan Kiszka ha scritto: >> > Note that the thing above would be separate from EventNotifier, which is >> > why I only mentioned as "by the way". >> > >> > EventNotifier and anything using eventfd/pipes would _not_ be a >> > "QEMU-styled thread synchronization mechanism" simply

Re: [Qemu-devel] [PATCH] qom: Refine container_get() to allow using a custom root

2012-04-05 Thread Paolo Bonzini
Il 05/04/2012 13:21, Andreas Färber ha scritto: > Specify the root to search from as argument. This avoids hardcoding > "/machine" in some places and makes it more flexible. > > Signed-off-by: Andreas Färber > Cc: Paolo Bonzini > Cc: Anthony Liguori Looks good, thanks. Paolo > --- > hw/qdev

Re: [Qemu-devel] [PATCH 0/5] PCI hotplug fixes/cleanup

2012-04-05 Thread Gleb Natapov
On Wed, Apr 04, 2012 at 11:51:00PM -0600, Alex Williamson wrote: > We've been batting this one back and forth. This series includes > several of the cleanups and specification clarifications from my > series awhile back. Patch 5 is my proposed alternative to > Michael's PCI hotplug race fix. Sin

[Qemu-devel] [PATCH v3 00/10] Use more central threading and synchronization services

2012-04-05 Thread Jan Kiszka
Patches 1-3 are unmodified from the previous round. Patches 4-10 aim at consolidating our event abstractions over a single QemuEvent object. This is heavily based on Paolo's work, just slightly refactored, plugged into the qemu-thread-* infrastructure and applied on more consumers. CC: Michael S.

Re: [Qemu-devel] [PATCH v3 05/10] Introduce QemuEvent abstraction

2012-04-05 Thread Paolo Bonzini
Il 05/04/2012 12:59, Jan Kiszka ha scritto: > Provide generic services for binary events. Blocking wait would be > feasible but is not included yet as there are no users. > > diff --git a/qemu-event-posix.c b/qemu-event-posix.c > new file mode 100644 > index 000..6138168 > --- /dev/null > +++

Re: [Qemu-devel] [PATCH v3 01/10] Introduce qemu_cond_timedwait for POSIX

2012-04-05 Thread Jan Kiszka
On 2012-04-05 13:19, Peter Maydell wrote: > On 5 April 2012 11:59, Jan Kiszka wrote: >> +/* Returns true if condition was signals, false if timed out. */ >> +bool qemu_cond_timedwait(QemuCond *cond, QemuMutex *mutex, >> + unsigned int timeout_ms) >> +{ >> +struct timesp

Re: [Qemu-devel] [PULL] pci, virtio, net

2012-04-05 Thread Michael S. Tsirkin
On Mon, Mar 19, 2012 at 01:11:16PM -0500, Anthony Liguori wrote: > On 03/15/2012 06:49 PM, Michael S. Tsirkin wrote: > >I'm trying a signed pull request now. You can check the signature > >on for_anthony if you like, and if your git is recent enough > >it will do it for you automatically. > > > >Th

Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API

2012-04-05 Thread Jan Kiszka
On 2012-04-05 13:29, Paolo Bonzini wrote: > Il 05/04/2012 13:18, Jan Kiszka ha scritto: Note that the thing above would be separate from EventNotifier, which is why I only mentioned as "by the way". EventNotifier and anything using eventfd/pipes would _not_ be a "QEMU-style

Re: [Qemu-devel] [PATCH v3 01/10] Introduce qemu_cond_timedwait for POSIX

2012-04-05 Thread Peter Maydell
On 5 April 2012 12:56, Jan Kiszka wrote: > On 2012-04-05 13:19, Peter Maydell wrote: >> Use clock_gettime() and avoid the need to convert a struct timeval >> to a struct timespec ? > > Would save that "* 1000". I just wondered why we do not use it elsewhere > in QEMU and was reluctant to risk some

Re: [Qemu-devel] [PATCH v8 09/10] Add set_cachesize command

2012-04-05 Thread Avi Kivity
On 04/05/2012 01:47 PM, Orit Wasserman wrote: > Change XBZRLE cache size in MB (the size should be a power of 2). In bytes > > +void xbzrle_cache_resize(int64_t new_size) > +{ > +if (page_cache) { > +cache_fini(); > +cache_init(new_size); > +} > +} A little sad to drop

Re: [Qemu-devel] [PATCH v8 09/10] Add set_cachesize command

2012-04-05 Thread Avi Kivity
On 04/05/2012 03:15 PM, Avi Kivity wrote: > We need to either document the default or (better) add a command to get > the current cache size (perhaps with some statistics about hit rate and > average data reduction). > I see there already is a stats command, you can add the cache size to that. --

[Qemu-devel] [RFC PATCH v3 2/9] repagent: Changed repagent socket to be based on set_fd_handler, converted parsing functions to be non-serial

2012-04-05 Thread Ori Mamluk
Use set_fd_handler instead of a listening thread. Change the reading/parsing function to be state-machine based, because they no longer have their own thread. --- Makefile |6 +- Makefile.objs | 10 +- configure |3 +- replicatio

Re: [Qemu-devel] [PATCH 00/13] Convert ARM GIC to sysbus device

2012-04-05 Thread Peter Maydell
On 4 April 2012 16:30, Peter Maydell wrote: >  hw/arm_gic: Move NCPU definition to arm_gic.c >  hw/arm_gic: Move gic_get_current_cpu into arm_gic.c >  hw/arm_gic.c: Expose PPI inputs as gpio inputs >  arm_gic: Make the GIC its own sysbus device >  hw/a15mpcore: switch to using sysbus GIC >  hw/a9m

Re: [Qemu-devel] [PATCH 3/3] pseries: Add DPRINTF macros to spapr pci code

2012-04-05 Thread Andreas Färber
Am 04.04.2012 22:54, schrieb Peter Maydell: > On 4 April 2012 21:34, Blue Swirl wrote: >> On Wed, Apr 4, 2012 at 20:11, Peter Maydell wrote: >>> I'd much rather enable a #define to turn on debugging than faff about >>> with tracing. It's simple and straightforward, you can do it with a >>> single

Re: [Qemu-devel] [PATCH v3 01/10] Introduce qemu_cond_timedwait for POSIX

2012-04-05 Thread malc
On Thu, 5 Apr 2012, Jan Kiszka wrote: > On 2012-04-05 13:19, Peter Maydell wrote: > > On 5 April 2012 11:59, Jan Kiszka wrote: > >> +/* Returns true if condition was signals, false if timed out. */ > >> +bool qemu_cond_timedwait(QemuCond *cond, QemuMutex *mutex, > >> + uns

Re: [Qemu-devel] [PATCH 23/25] qom: add realized property

2012-04-05 Thread Paolo Bonzini
Il 05/04/2012 14:04, Andreas Färber ha scritto: > Am 03.04.2012 15:03, schrieb Paolo Bonzini: >> Il 03/04/2012 14:11, Andreas Färber ha scritto: >>> Since this patch is clearly an extended version of my realize patch >>> http://patchwork.ozlabs.org/patch/148752/, it should carry my SoB, as >>> remi

Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API

2012-04-05 Thread Paolo Bonzini
Il 05/04/2012 14:04, Jan Kiszka ha scritto: >> EventNotifier _is not_ yet another thread synchronization primitive. It >> can be used across processes, across the user/kernel boundary, and the >> main loop can wait on multiple instances. QemuThread synchronization >> primitives are only usable wi

[Qemu-devel] [RFC PATCH v3 4/9] repagent: started writing repagent as a bdrv. Finished driver empty template.

2012-04-05 Thread Ori Mamluk
--- Makefile.objs |2 +- block.c |7 ++- block.h |1 + block/repagent/repagent_drv.c | 197 + blockdev.c|6 ++ vl.c | 15 +++ 6 files

Re: [Qemu-devel] [PATCH v3 01/10] Introduce qemu_cond_timedwait for POSIX

2012-04-05 Thread malc
On Thu, 5 Apr 2012, Paolo Bonzini wrote: > Il 05/04/2012 14:30, malc ha scritto: > >> > Would save that "* 1000". I just wondered why we do not use it elsewhere > >> > in QEMU and was reluctant to risk some BSD breakage. > >> > > > It's probably worth mentioning that using anything other than >

Re: [Qemu-devel] [PATCH v3 01/10] Introduce qemu_cond_timedwait for POSIX

2012-04-05 Thread Paolo Bonzini
Il 05/04/2012 14:53, malc ha scritto: > On Thu, 5 Apr 2012, Paolo Bonzini wrote: > >> Il 05/04/2012 14:30, malc ha scritto: > Would save that "* 1000". I just wondered why we do not use it elsewhere > in QEMU and was reluctant to risk some BSD breakage. > >>> It's probably worth mentio

Re: [Qemu-devel] [PATCH v3 01/10] Introduce qemu_cond_timedwait for POSIX

2012-04-05 Thread Jan Kiszka
On 2012-04-05 14:56, Paolo Bonzini wrote: > Il 05/04/2012 14:53, malc ha scritto: >> On Thu, 5 Apr 2012, Paolo Bonzini wrote: >> >>> Il 05/04/2012 14:30, malc ha scritto: >> Would save that "* 1000". I just wondered why we do not use it elsewhere >> in QEMU and was reluctant to risk some BS

Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: Fix call syntax for qemu-img

2012-04-05 Thread Kevin Wolf
Am 14.03.2012 19:57, schrieb Stefan Weil: > qemu-img requires first options, then file name, then size. > > GNU getopt also allows options at the end, but POSIX getopt > doesn't. Try "export POSIXLY_CORRECT=y" to get the POSIX > behaviour with GNU getopt, too. > > Cc: Kevin Wolf > Signed-off-by:

Re: [Qemu-devel] [PATCH v2] block stream: close unused files and update ->backing_hd

2012-04-05 Thread Kevin Wolf
Am 27.03.2012 09:13, schrieb Stefan Hajnoczi: > On Mon, Mar 26, 2012 at 09:22:10PM -0300, Marcelo Tosatti wrote: >> >> Close the now unused images that were part of the previous backing file >> chain and adjust ->backing_hd, backing_filename and backing_format >> properly. >> >> Fixes https://bugzi

Re: [Qemu-devel] [PATCH 0/5] PCI hotplug fixes/cleanup

2012-04-05 Thread Michael S. Tsirkin
Which commit is this series against? When trying to apply to my tree, I get conflicts.

Re: [Qemu-devel] [PATCH v3 01/10] Introduce qemu_cond_timedwait for POSIX

2012-04-05 Thread malc
On Thu, 5 Apr 2012, Jan Kiszka wrote: > On 2012-04-05 15:00, malc wrote: > > On Thu, 5 Apr 2012, Jan Kiszka wrote: > > > >> On 2012-04-05 14:56, Paolo Bonzini wrote: > >>> Il 05/04/2012 14:53, malc ha scritto: > On Thu, 5 Apr 2012, Paolo Bonzini wrote: > > > Il 05/04/2012 14:30, mal

Re: [Qemu-devel] [PATCH v3 01/10] Introduce qemu_cond_timedwait for POSIX

2012-04-05 Thread Jan Kiszka
On 2012-04-05 15:20, malc wrote: > On Thu, 5 Apr 2012, Jan Kiszka wrote: > >> On 2012-04-05 15:00, malc wrote: >>> On Thu, 5 Apr 2012, Jan Kiszka wrote: >>> On 2012-04-05 14:56, Paolo Bonzini wrote: > Il 05/04/2012 14:53, malc ha scritto: >> On Thu, 5 Apr 2012, Paolo Bonzini wrote: >>

Re: [Qemu-devel] [PATCH 23/25] qom: add realized property

2012-04-05 Thread Andreas Färber
Am 05.04.2012 14:36, schrieb Paolo Bonzini: > Il 05/04/2012 14:04, Andreas Färber ha scritto: >> Am 03.04.2012 15:03, schrieb Paolo Bonzini: >>> Il 03/04/2012 14:11, Andreas Färber ha scritto: Since this patch is clearly an extended version of my realize patch http://patchwork.ozlabs.org/

Re: [Qemu-devel] [PATCH v3 01/10] Introduce qemu_cond_timedwait for POSIX

2012-04-05 Thread malc
On Thu, 5 Apr 2012, Jan Kiszka wrote: > On 2012-04-05 15:20, malc wrote: > > On Thu, 5 Apr 2012, Jan Kiszka wrote: > > > >> On 2012-04-05 15:00, malc wrote: > >>> On Thu, 5 Apr 2012, Jan Kiszka wrote: > >>> > On 2012-04-05 14:56, Paolo Bonzini wrote: > > Il 05/04/2012 14:53, malc ha scri

Re: [Qemu-devel] [PATCH v3 05/10] Introduce QemuEvent abstraction

2012-04-05 Thread Jan Kiszka
On 2012-04-05 13:23, Paolo Bonzini wrote: > Il 05/04/2012 12:59, Jan Kiszka ha scritto: >> Provide generic services for binary events. Blocking wait would be >> feasible but is not included yet as there are no users. >> >> diff --git a/qemu-event-posix.c b/qemu-event-posix.c >> new file mode 100644

Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API

2012-04-05 Thread Jan Kiszka
On 2012-04-05 15:40, Paolo Bonzini wrote: > Il 05/04/2012 15:00, Jan Kiszka ha scritto: But QemuEvent takes away the best name for a useful concept (a cross-platform implementation of Win32 events; you can see that in the >> The concept is not lost, it perfectly fit this incarnation. Just

Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API

2012-04-05 Thread Paolo Bonzini
Il 05/04/2012 16:01, Jan Kiszka ha scritto: > Either you signal via the fd or via a variable. Doing both won't work as > the state can only be in the eventfd/pipe (for external triggers). We > could switch the mode of our QemuEvent on init, but that will become > ugly I'm afraid. Yeah... > RC

Re: [Qemu-devel] [PATCH 23/25] qom: add realized property

2012-04-05 Thread Paolo Bonzini
Il 05/04/2012 15:31, Andreas Färber ha scritto: > Here's how I see it: > > * You add a realize callback to ObjectClass like I did, you add the > Error** parameter that was requested as feedback to mine. > * You add a static object_realize() method that clashes with my > introducing it as a public

[Qemu-devel] [PATCH 1/1] Allow machines to configure the QEMU_VERSION that's exposed via hardware

2012-04-05 Thread Crístian Viana
Based on the following conversation: http://mid.gmane.org/4f69f05b.5010...@codemonkey.ws > Which reminds me - qemu sticks the release version in > guest visible places like CPU version. > This is wrong and causes windows guests to print messages > about driver updates when you switch. > We should

[Qemu-devel] [PATCH v3 07/10] Drop unused qemu_eventfd

2012-04-05 Thread Jan Kiszka
The only user was the main loop which is now relying on QemuEvent. Signed-off-by: Jan Kiszka --- oslib-posix.c | 31 --- qemu-common.h |1 - 2 files changed, 0 insertions(+), 32 deletions(-) diff --git a/oslib-posix.c b/oslib-posix.c index b6a3c7f..7928a0d 1006

Re: [Qemu-devel] [PATCH v3 01/10] Introduce qemu_cond_timedwait for POSIX

2012-04-05 Thread Jan Kiszka
On 2012-04-05 15:00, malc wrote: > On Thu, 5 Apr 2012, Jan Kiszka wrote: > >> On 2012-04-05 14:56, Paolo Bonzini wrote: >>> Il 05/04/2012 14:53, malc ha scritto: On Thu, 5 Apr 2012, Paolo Bonzini wrote: > Il 05/04/2012 14:30, malc ha scritto: Would save that "* 1000". I just

Re: [Qemu-devel] [PATCH 1/1] Allow machines to configure the QEMU_VERSION that's exposed via hardware

2012-04-05 Thread Crístian Viana
On 05-04-2012 11:48, Peter Maydell wrote: > This kind of change is definitely wrong -- where we're reporting > the QEMU version to the *user* we definitely don't want to introduce > the possibility of lying about it. > > (This is distinct from reporting the QEMU version to the *guest* > via device

[Qemu-devel] [PATCH v2] qemu-timer.c: Remove 250us timeouts

2012-04-05 Thread Peter Portante
Basically, the main wait loop calls qemu_run_all_timers() unconditionally. The first thing this routine used to do is to see if a timer had been serviced, and then reset the loop timeout to the next deadline. However, the new deadlines had not been calculated at that point, as qemu_run_timers() ha

Re: [Qemu-devel] [PATCH 23/25] qom: add realized property

2012-04-05 Thread Anthony Liguori
Hi, I'm about to board a plane but I at least want to comment that we should all give each other the benefit of the doubt in a situation like this. Everyone on this thread is a long term contributer to QEMU that has more than earned the right not to be accussed of impropriety. Let's all take a de

Re: [Qemu-devel] [PATCH 0/5] PCI hotplug fixes/cleanup

2012-04-05 Thread Alex Williamson
On Thu, 2012-04-05 at 15:31 +0300, Michael S. Tsirkin wrote: > Which commit is this series against? > When trying to apply to my tree, I get conflicts. Sorry, it's off qemu-kvm, it was too late when I sent this. Let me re-order to send the fix separately so we can continue to discuss the doc/unde

Re: [Qemu-devel] [PATCH V3 0/7] Make QED with live migration safe

2012-04-05 Thread Kevin Wolf
Am 23.03.2012 08:36, schrieb Benoît Canet: > This is the third version of a patchset aiming at making the combined > usage of QED and live migration safe. > > v3: > > -qed: Drop the flags qed structure member and use bs->open_flags to reopen > (stefana) > -qed: When opening honor flags parameter

Re: [Qemu-devel] [PATCH 2/5] acpi_piix4: Only allow writes to PCI hotplug eject register

2012-04-05 Thread Alex Williamson
On Thu, 2012-04-05 at 10:21 +0200, Igor Mammedov wrote: > On 04/05/2012 07:51 AM, Alex Williamson wrote: > > This is never read. We can also derive bus from the write handler, > > making this more inline with the other callbacks. Note that > > pciej_write was actually called with (PCIBus *)dev->b

Re: [Qemu-devel] [PATCH 2/5] acpi_piix4: Only allow writes to PCI hotplug eject register

2012-04-05 Thread Alex Williamson
On Thu, 2012-04-05 at 13:48 +0300, Gleb Natapov wrote: > On Thu, Apr 05, 2012 at 01:20:03PM +0300, Michael S. Tsirkin wrote: > > On Thu, Apr 05, 2012 at 01:08:06PM +0300, Gleb Natapov wrote: > > > On Thu, Apr 05, 2012 at 12:53:55PM +0300, Michael S. Tsirkin wrote: > > > > On Thu, Apr 05, 2012 at 12

Re: [Qemu-devel] [PATCH 2/5] acpi_piix4: Only allow writes to PCI hotplug eject register

2012-04-05 Thread Michael S. Tsirkin
On Thu, Apr 05, 2012 at 09:12:31AM -0600, Alex Williamson wrote: > On Thu, 2012-04-05 at 13:48 +0300, Gleb Natapov wrote: > > On Thu, Apr 05, 2012 at 01:20:03PM +0300, Michael S. Tsirkin wrote: > > > On Thu, Apr 05, 2012 at 01:08:06PM +0300, Gleb Natapov wrote: > > > > On Thu, Apr 05, 2012 at 12:53

Re: [Qemu-devel] [PATCH 0/5] PCI hotplug fixes/cleanup

2012-04-05 Thread Michael S. Tsirkin
On Thu, Apr 05, 2012 at 09:14:34AM -0600, Alex Williamson wrote: > On Thu, 2012-04-05 at 15:31 +0300, Michael S. Tsirkin wrote: > > Which commit is this series against? > > When trying to apply to my tree, I get conflicts. > > Sorry, it's off qemu-kvm, it was too late when I sent this. Let me > r

[Qemu-devel] [PATCH 43/46] qed: add bdrv_invalidate_cache to be called after incoming live migration

2012-04-05 Thread Kevin Wolf
From: Benoît Canet The QED image is reopened to flush metadata and check consistency. Signed-off-by: Benoit Canet Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/qed.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/block/qed.c b/block/qed.

[Qemu-devel] [PATCH 32/46] block: bdrv_append() fixes

2012-04-05 Thread Kevin Wolf
From: Jeff Cody A few fixups for bdrv_append(): The new bs (bs_new) passed into bdrv_append() should be anonymous. Rather than call bdrv_make_anon() to enforce this, use an assert to catch when a caller is passing in a bs_new that is not anonymous. Also, the new top layer should have its backi

[Qemu-devel] [PATCH 21/46] vdi: change goto to loop

2012-04-05 Thread Kevin Wolf
From: Paolo Bonzini Finally reindent all code and change goto statements to a loop. Acked-by: Stefan Weil Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- block/vdi.c | 143 -- 1 files changed, 69 insertions(+), 74 deletions(

Re: [Qemu-devel] KVM call minutes April 3

2012-04-05 Thread Avi Kivity
On 04/04/2012 05:39 PM, Michael Roth wrote: > > Will command line take in account hot-plugged devices? > > No, that's a good point. We'd probably need to generate the options > required to ensure the devices are created on the target, and we'd only > be able to do that just before sending the devic

[Qemu-devel] [PATCH 13/46] qdev: add blocksize property type

2012-04-05 Thread Kevin Wolf
From: Stefan Hajnoczi Storage interfaces like virtio-blk can be configured with block size information so that the guest can take advantage of efficient I/O request sizes. According to the SCSI Block Commands (SBC) standard a device's block size is "almost always greater than one byte and may be

[Qemu-devel] [PATCH 20/46] vdi: do not create useless iovecs

2012-04-05 Thread Kevin Wolf
From: Paolo Bonzini Reads and writes to the underlying file can also occur with the simple non-vectored I/O interfaces. Acked-by: Stefan Weil Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- block/vdi.c | 79 -- 1 files chan

[Qemu-devel] [PATCH 33/46] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-05 Thread Kevin Wolf
From: Liu Yuan Flush operation is supposed to flush the write-back cache of sheepdog cluster. By issuing flush operation, we can assure the Guest of data reaching the sheepdog cluster storage. Cc: Kevin Wolf Cc: MORITA Kazutaka Signed-off-by: Liu Yuan Signed-off-by: Kevin Wolf --- block/sh

[Qemu-devel] [PATCH 11/46] block/vpc: write checksum back to footer after check

2012-04-05 Thread Kevin Wolf
From: Zhang Shengju After validation check, the 'checksum' is not written back to footer, which leave it with zero. This results in errors while loadding it under Microsoft's Hyper-V environment, and also errors from utilities like Citrix's vhd-util. Signed-off-by: Zhang Shengju Signed-off-by:

[Qemu-devel] [PATCH 15/46] vdi: basic conversion to coroutines

2012-04-05 Thread Kevin Wolf
From: Paolo Bonzini Even a basic conversion changing the bdrv_aio_readv/bdrv_aio_writev calls to bdrv_co_readv/bdrv_co_writev, and callbacks to goto statements can eliminate a lot of code. This is because error handling is simplified and indirections through bottom halves can go away. After thi

[Qemu-devel] [PATCH 09/46] ide: Change serial number strncpy() to pstrcpy()

2012-04-05 Thread Kevin Wolf
From: Floris Bos strncpy may not null-terminate the destination string. Cc: kw...@redhat.com Signed-off-by: Floris Bos Signed-off-by: Kevin Wolf --- blockdev.c|5 +++-- hw/ide/core.c |2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev.c inde

Re: [Qemu-devel] [PATCH V2 10/10] hw/sd.c: introduce SD card "image" property and allow SD hot-insert

2012-04-05 Thread Paolo Bonzini
Il 05/04/2012 17:48, Igor Mitsyanko ha scritto: > New SD card "image" property can be used to: > - change image file attached to virtual SD card > - hot-insert new image file into newly initialized BlockDriverState (this was > not > possible before). > > Example usage: > ./qom-set /machine/milkym

[Qemu-devel] [PATCH v2 0/5] PCI hotplug fixes/cleanup

2012-04-05 Thread Alex Williamson
Incorporating feedback from v1. Re-ordered so first 2 patches are fixes, allowing easier backport. Instead of declaring the eject register is write-only we define it to be a feature bits register and define the base feature set in the docs (a feature register seems easier to maintain than a versi

[Qemu-devel] [PATCH v2 2/5] acpi_piix4: Fix PCI hotplug race

2012-04-05 Thread Alex Williamson
As Michael Tsirkin demonstrated, current PCI hotplug is vulnerable to a few races. The first is a race with other hotplug operations because we clear the up & down registers at each event. If a new event comes before the last is processed, up/down is cleared and the event is lost. To fix this fo

[Qemu-devel] [PATCH v2 1/5] acpi_piix4: Disallow write to up/down PCI hotplug registers

2012-04-05 Thread Alex Williamson
The write side of these registers is never used and actually can't be used as defined because any read/modify/write sequence from the guest potentially races with qemu. Drop the write support and define these as read-only registers. Signed-off-by: Alex Williamson --- docs/specs/acpi_pci_hotplu

Re: [Qemu-devel] [patch V5 5/5] FreeSCALE i.MX31 support: KZM-ARM11-01 evaluation board

2012-04-05 Thread Peter Maydell
On 3 April 2012 02:55, Peter Chubb wrote: > Board support for Kyoto Micro's KZM-ARM11-01, an evaluation board built > around the FreeScale i.MX31. > > > Signed-off-by: Philip O'Sullivan > Signed-off-by: Peter Chubb Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [patch V5 3/5] FreeSCALE i.MX31 support: Timers

2012-04-05 Thread Peter Maydell
On 3 April 2012 02:55, Peter Chubb wrote: > +    case 2: /* LR - set ticks */ > +        s->lr = value; > +        /* > +         * Artificially limit tick rate to something > +         * achievable under QEMU.  Otherwise, QEMU spends all > +         * its time generating timer interrupts, and the

Re: [Qemu-devel] [patch V5 2/5] Implement i.MX31 Clock Control Module

2012-04-05 Thread Peter Maydell
On 3 April 2012 02:55, Peter Chubb wrote: > === > --- qemu-working.orig/hw/imx.h  2012-04-03 11:48:48.088706634 +1000 > +++ qemu-working/hw/imx.h       2012-04-03 11:48:48.776708322 +1000 > @@ -13,4 +13,18 @@ > >  void imx_serial_crea

[Qemu-devel] [PATCH V3 5/8] hw/pc.c: replace register_ioport*

2012-04-05 Thread Julien Grall
This patch replaces all register_ioport* with portio_* or isa_register_portio_list. It permits to use the new Memory stuff like listener. Signed-off-by: Julien Grall --- hw/pc.c | 58 +++--- 1 files changed, 43 insertions(+), 15 deletions(-)

  1   2   >