Re: [Qemu-devel] KVM call minutes April 3

2012-04-04 Thread Paolo Bonzini
Il 04/04/2012 03:18, Michael Roth ha scritto: > Attacking the IDL/schema side first is the more rationale approach. From > there we can potentially generate ASN.1 BER/DER visitors for the protocol > side, or potentially even just vmstate bindings as a start. I've recently > started looking into the

Re: [Qemu-devel] [V6 PATCH] virtio-net: send gratuitous packets when needed

2012-04-04 Thread Michael S. Tsirkin
On Wed, Mar 28, 2012 at 01:44:28PM +0800, Jason Wang wrote: > As hypervior does not have the knowledge of guest network configuration, it's > better to ask guest to send gratuitous packets when needed. > > Guest tests VIRTIO_NET_S_ANNOUNCE bit during config change interrupt and when > it > is set

Re: [Qemu-devel] [V6 PATCH] virtio-net: send gratuitous packets when needed

2012-04-04 Thread Michael S. Tsirkin
On Tue, Apr 03, 2012 at 05:49:05PM -0400, David Miller wrote: > From: Jason Wang > Date: Wed, 28 Mar 2012 13:44:28 +0800 > > > As hypervior does not have the knowledge of guest network configuration, > > it's > > better to ask guest to send gratuitous packets when needed. > > > > Guest tests VI

Re: [Qemu-devel] [RFC][PATCH v2 0/4] uq/master: Basic MSI support for in-kernel irqchip mode

2012-04-04 Thread Michael S. Tsirkin
On Tue, Apr 03, 2012 at 07:27:36PM +0200, Jan Kiszka wrote: > On 2012-04-03 15:06, Michael S. Tsirkin wrote: > > On Tue, Apr 03, 2012 at 09:23:12AM +0200, Jan Kiszka wrote: > >> This is v2 of the RFC, fixing a memory leak in > >> kvm_flush_dynamic_msi_routes and adding support for the proposed > >>

Re: [Qemu-devel] [RFC][PATCH v2 0/4] uq/master: Basic MSI support for in-kernel irqchip mode

2012-04-04 Thread Michael S. Tsirkin
On Tue, Apr 03, 2012 at 09:17:30PM +0200, Jan Kiszka wrote: > On 2012-04-03 09:23, Jan Kiszka wrote: > > This is v2 of the RFC, fixing a memory leak in > > kvm_flush_dynamic_msi_routes and adding support for the proposed > > KVM_SIGNAL_MSI IOCTL. > > > > This series depends on "kvm: set gsi_bits a

Re: [Qemu-devel] [PATCH, RESEND] kvm: Fix dirty tracking with large kernel page size

2012-04-04 Thread Avi Kivity
On 04/04/2012 04:15 AM, David Gibson wrote: > If the kernel page size is larger than TARGET_PAGE_SIZE, which > happens for example on ppc64 with kernels compiled for 64K pages, > the dirty tracking doesn't work. > > Cc: Avi Kivity > Cc: Marcelo Tosatti > Thanks, applied to uq/master. -- I have

Re: [Qemu-devel] [PATCH v5] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-04 Thread Kevin Wolf
Am 03.04.2012 22:03, schrieb Liu Yuan: > From: Liu Yuan > > Flush operation is supposed to flush the write-back cache of > sheepdog cluster. > > By issuing flush operation, we can assure the Guest of data > reaching the sheepdog cluster storage. > > Cc: Kevin Wolf > Cc: MORITA Kazutaka > Sign

Re: [Qemu-devel] [PATCH v5] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-04 Thread Liu Yuan
Hi kevin, On 04/04/2012 04:53 PM, Kevin Wolf wrote: > I can update it in my queue, no problem there. > > But I diffed this against v4 and it doesn't seem to have any changes, > except in the context of two hunks. Are you sure that you didn't do the > fixes in a separate commit or send the wrong

Re: [Qemu-devel] [PATCH v5] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-04 Thread Kevin Wolf
Am 04.04.2012 10:58, schrieb Liu Yuan: > Hi kevin, > > On 04/04/2012 04:53 PM, Kevin Wolf wrote: > >> I can update it in my queue, no problem there. >> >> But I diffed this against v4 and it doesn't seem to have any changes, >> except in the context of two hunks. Are you sure that you didn't do t

Re: [Qemu-devel] [PATCH 1/2] ARM: Exynos4210: Drop gic_cpu_write() after initialization.

2012-04-04 Thread Peter Maydell
On 4 April 2012 07:39, Evgeny Voevodin wrote: > Remove gic_cpu_write() call after initialization that was emulating > functionality of earliest SOC bootloader which enables external > GIC CPU1 interface. Instead introduce Exynos4210-specific secondary > CPU bootloader, which enables both Internal

Re: [Qemu-devel] [PATCH 2/2] hw/exynos4210_combiner.c: Drop excessive read/write access check.

2012-04-04 Thread Peter Maydell
On 4 April 2012 07:39, Evgeny Voevodin wrote: > Access to reserved area at offset higher than 0x3c is allowed in > External Combiner. Samsung Galaxy Kernel implements this. So, drop > excessive checks in read/write functions. > > Signed-off-by: Evgeny Voevodin Reviewed-by: Peter Maydell -- PMM

[Qemu-devel] [PATCH] Support system reset in Exynos4210

2012-04-04 Thread Dmitry Zhurikhin
Reset the system when 1 is written to SWRESET register Signed-off-by: Dmitry Zhurikhin --- hw/exynos4210_pmu.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/hw/exynos4210_pmu.c b/hw/exynos4210_pmu.c index c12d750..edf6e34 100644 --- a/hw/exynos4210_pmu.c +++

Re: [Qemu-devel] KVM call minutes April 3

2012-04-04 Thread Michael Roth
On Apr 4, 2012 2:42 AM, "Paolo Bonzini" wrote: > > Il 04/04/2012 03:18, Michael Roth ha scritto: > > Attacking the IDL/schema side first is the more rationale approach. From > > there we can potentially generate ASN.1 BER/DER visitors for the protocol > > side, or potentially even just vmstate bin

Re: [Qemu-devel] KVM call minutes April 3

2012-04-04 Thread Dor Laor
On 04/04/2012 01:37 PM, Michael Roth wrote: On Apr 4, 2012 2:42 AM, "Paolo Bonzini" mailto:pbonz...@redhat.com>> wrote: > > Il 04/04/2012 03:18, Michael Roth ha scritto: > > Attacking the IDL/schema side first is the more rationale approach. From > > there we can potentially generate ASN.1 B

Re: [Qemu-devel] [PATCH, RESEND] kvm: Fix dirty tracking with large kernel page size

2012-04-04 Thread Jan Kiszka
On 2012-04-04 03:12, David Gibson wrote: >> Also, what's about coalesced MMIO? I see that the ring definition >> depends on [TARGET_]PAGE_SIZE. What page size does the power kernel use >> for it, and does it make a relevant difference for space? > > Hr, so the HV variant of Power KVM doesn't do co

Re: [Qemu-devel] KVM call minutes April 3

2012-04-04 Thread Anthony Liguori
On 04/03/2012 03:43 PM, Dor Laor wrote: On 04/03/2012 05:43 PM, Markus Armbruster wrote: I'm afraid my notes are rather rough... * 1.1 soft freeze apr 15th (less than two weeks) hard freeze may 1 three months cycle for 1.2 stable machine types only every few releases? "pc-next" * Maintainers,

Re: [Qemu-devel] KVM call minutes April 3

2012-04-04 Thread Anthony Liguori
On 04/04/2012 05:53 AM, Dor Laor wrote: On 04/04/2012 01:37 PM, Michael Roth wrote: On Apr 4, 2012 2:42 AM, "Paolo Bonzini" mailto:pbonz...@redhat.com>> wrote: > > Il 04/04/2012 03:18, Michael Roth ha scritto: > > Attacking the IDL/schema side first is the more rationale approach. From > > ther

Re: [Qemu-devel] [PATCH] Support system reset in Exynos4210

2012-04-04 Thread Maksim Kozlov
04.04.2012 14:08, Dmitry Zhurikhin пишет: Reset the system when 1 is written to SWRESET register Signed-off-by: Dmitry Zhurikhin --- hw/exynos4210_pmu.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/hw/exynos4210_pmu.c b/hw/exynos4210_pmu.c index c12d750.

Re: [Qemu-devel] KVM call minutes April 3

2012-04-04 Thread Dor Laor
On 04/04/2012 02:52 PM, Anthony Liguori wrote: On 04/04/2012 05:53 AM, Dor Laor wrote: On 04/04/2012 01:37 PM, Michael Roth wrote: On Apr 4, 2012 2:42 AM, "Paolo Bonzini" mailto:pbonz...@redhat.com>> wrote: > > Il 04/04/2012 03:18, Michael Roth ha scritto: > > Attacking the IDL/schema side fir

Re: [Qemu-devel] KVM call minutes April 3

2012-04-04 Thread Michael Roth
On Wed, Apr 04, 2012 at 01:53:34PM +0300, Dor Laor wrote: > On 04/04/2012 01:37 PM, Michael Roth wrote: > > > >On Apr 4, 2012 2:42 AM, "Paolo Bonzini" >> wrote: > > > > > > Il 04/04/2012 03:18, Michael Roth ha scritto: > > > > Attacking the IDL/schema side first is the

[Qemu-devel] [PATCH, repost] qemu-keymaps: Finnish keyboard mapping broken

2012-04-04 Thread Michael Tokarev
As mentioned in http://bugs.debian.org/660154 , finnish keyboard mapping is kind of broken. Fix it as Timo Sirainen suggests in #660154. index 2a4e0f0..4be7586 100644 --- a/pc-bios/keymaps/fi +++ b/pc-bios/keymaps/fi @@ -99,9 +99,7 @@ asterisk 0x2b shift acute 0x2b altgr multiply 0x2b shift al

Re: [Qemu-devel] [PATCH] Support system reset in Exynos4210

2012-04-04 Thread Dmitry Zhurikhin
On 2012-04-04 15:55, Maksim Kozlov wrote: > 04.04.2012 14:08, Dmitry Zhurikhin пишет: >> Reset the system when 1 is written to SWRESET register >> >> Signed-off-by: Dmitry Zhurikhin >> --- >> hw/exynos4210_pmu.c | 11 +++ >> 1 files changed, 11 insertions(+), 0 deletions(-) >> >> diff

Re: [Qemu-devel] [RFC PATCH v1 2/4] m25p80: initial verion

2012-04-04 Thread Andreas Färber
Am 30.03.2012 08:37, schrieb Peter A. G. Crosthwaite: > Added device model for m25p80 SPI flash > > Signed-off-by: Peter A. G. Crosthwaite > --- > Makefile.target |1 + > hw/m25p80.c | 495 > +++ > 2 files changed, 496 insertions(+),

Re: [Qemu-devel] KVM call minutes April 3

2012-04-04 Thread Igor Mammedov
On 04/04/2012 02:14 PM, Michael Roth wrote: On Wed, Apr 04, 2012 at 01:53:34PM +0300, Dor Laor wrote: On 04/04/2012 01:37 PM, Michael Roth wrote: On Apr 4, 2012 2:42 AM, "Paolo Bonzini"mailto:pbonz...@redhat.com>> wrote: Il 04/04/2012 03:18, Michael Roth ha scritto: Attacking the IDL/schem

Re: [Qemu-devel] [PATCH] MSI / MSIX injection for Xen HVM

2012-04-04 Thread Stefano Stabellini
On Tue, 3 Apr 2012, Wei Liu (Intern) wrote: > On Thu, 2012-03-01 at 15:56 +, Paolo Bonzini wrote: > > Il 01/03/2012 15:50, Stefano Stabellini ha scritto: > > >>> > > That is a good point actually: we already have lapic emulation in > > >>> > > Xen, > > >>> > > it makes sense to have apic-msi i

[Qemu-devel] [PATCH] memory: check address space when a listener is registered

2012-04-04 Thread Julien Grall
This patch resolves a bug in memory listener registration. "range_add" callback was called on each section of the both address space (IO and memory space) even if it doesn't match the address space filter. Signed-off-by: Julien Grall --- memory.c |5 + 1 files changed, 5 insertions(+),

[Qemu-devel] Macvtap or tap+bridge

2012-04-04 Thread Chris Webb
When I first started setting up qemu-kvm VMs for customers, I set up their internet-facing network with tap interfaces enslaved to a host bridge along with the physical network card of the host, something like ip tuntap add dev tapN mode tap brctl addif br0 tapN ip link set tapN up qemu-kv

Re: [Qemu-devel] KVM call minutes April 3

2012-04-04 Thread Michael Roth
On Wed, Apr 04, 2012 at 03:21:26PM +0200, Igor Mammedov wrote: > On 04/04/2012 02:14 PM, Michael Roth wrote: > >On Wed, Apr 04, 2012 at 01:53:34PM +0300, Dor Laor wrote: > >>On 04/04/2012 01:37 PM, Michael Roth wrote: > >>> > >>>On Apr 4, 2012 2:42 AM, "Paolo Bonzini" >>>

[Qemu-devel] [PATCH 5/5] Switch compatfd to QEMU thread

2012-04-04 Thread Jan Kiszka
qemu_thread_create already does signal blocking and detaching for us. Signed-off-by: Jan Kiszka --- compatfd.c | 16 +++- 1 files changed, 3 insertions(+), 13 deletions(-) diff --git a/compatfd.c b/compatfd.c index 42f81ca..8d5a63f 100644 --- a/compatfd.c +++ b/compatfd.c @@ -14,1

[Qemu-devel] [PATCH 1/5] Introduce qemu_cond_timedwait for POSIX

2012-04-04 Thread Jan Kiszka
First user will be POSIX compat aio. Windows use cases aren't in sight, so this remains a POSIX-only service for now. Signed-off-by: Jan Kiszka --- qemu-thread-posix.c | 23 +++ qemu-thread-posix.h |5 + 2 files changed, 28 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH 3/5] Use qemu_eventfd for POSIX AIO

2012-04-04 Thread Jan Kiszka
Use qemu_eventfd for signaling POSIX AIO completions. If native eventfd suport is available, this avoids multiple read accesses to drain multiple pending signals. As before we use a pipe if eventfd is not supported. Signed-off-by: Jan Kiszka --- posix-aio-compat.c | 12 1 files ch

[Qemu-devel] [PATCH 2/5] Switch POSIX compat AIO to QEMU abstractions

2012-04-04 Thread Jan Kiszka
Although there is nothing to wrap for non-POSIX here, redirecting thread and synchronization services to our core simplifies managements jobs like scheduling parameter adjustment. It also frees compat AIO from some duplicate code (/wrt qemu-thread). Signed-off-by: Jan Kiszka --- posix-aio-compat

[Qemu-devel] [Xen-devel] [PATCH v2] qemu/configure: fix CFLAGS handling for i386

2012-04-04 Thread Ian Jackson
Olaf Hering writes ("[Xen-devel] [PATCH v2] qemu/configure: fix CFLAGS handling for i386"): > configure will generate incorrect CFLAGS which will lead to compile > errors due to unknown gcc options, iff CFLAGS was already in the > environment during configure invocation. Don't do that then. In g

Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API

2012-04-04 Thread Paolo Bonzini
Il 04/04/2012 17:08, Jan Kiszka ha scritto: > Refreshed versions of some cleanups I already sent last year. See > patches for details. Patches 1, 2 and 5 are fine. I had an alternative implementation using a counting semaphore instead of the condition variable (which would work on Windows too), b

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/3] pseries: Clean up hcall_dprintf() debugging messages

2012-04-04 Thread Andreas Färber
Am 28.03.2012 23:39, schrieb David Gibson: > The pseries machine code has a number of debug messages for debugging PAPR > hypercalls, dependent on DEBUG_SPAPR_HCALLS. This patch cleans these > messages up a bit, by adding __func__ to the hcall_dprintf() macro and > simplifying up a number of the i

Re: [Qemu-devel] [PATCH 00/14] configure: --with-confsuffix option

2012-04-04 Thread Paolo Bonzini
Il 30/03/2012 19:32, Eduardo Habkost ha scritto: > This series is the third version of the --confsuffix/--confdir changes I have > submitted before. Now it does two interface changes: > > - Changes --datadir meaning to match Autoconf convention >(meaning that it should point to /usr/share, no

Re: [Qemu-devel] [Xen-devel] [PATCH v2] qemu/configure: fix CFLAGS handling for i386

2012-04-04 Thread Peter Maydell
On 4 April 2012 16:16, Ian Jackson wrote: > Olaf Hering writes ("[Xen-devel] [PATCH v2] qemu/configure: fix CFLAGS > handling for i386"): >> configure will generate incorrect CFLAGS which will lead to compile >> errors due to unknown gcc options, iff CFLAGS was already in the >> environment durin

Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API

2012-04-04 Thread Jan Kiszka
On 2012-04-04 17:18, Paolo Bonzini wrote: > Il 04/04/2012 17:08, Jan Kiszka ha scritto: >> Refreshed versions of some cleanups I already sent last year. See >> patches for details. > > Patches 1, 2 and 5 are fine. I had an alternative implementation using > a counting semaphore instead of the con

Re: [Qemu-devel] [PATCH] Memory: unify ioport registration

2012-04-04 Thread Julien Grall
On 04/03/2012 08:51 AM, Avi Kivity wrote: On 04/02/2012 05:37 PM, Julien Grall wrote: s = g_malloc0(sizeof(SerialState)); @@ -820,8 +828,9 @@ SerialState *serial_init(int base, qemu_irq irq, int baudbase, vmstate_register(NULL, base,&vmstate_serial, s); -register_ioport_w

[Qemu-devel] [PATCH 09/13] hw/arm11mpcore: Convert to using sysbus GIC device

2012-04-04 Thread Peter Maydell
Convert arm11mpcore to using the standalone sysbus GIC device. Signed-off-by: Peter Maydell --- hw/arm11mpcore.c | 49 ++--- 1 files changed, 30 insertions(+), 19 deletions(-) diff --git a/hw/arm11mpcore.c b/hw/arm11mpcore.c index e876a0e..c528d7a 1

[Qemu-devel] [PATCH 03/13] hw/arm_gic.c: Expose PPI inputs as gpio inputs

2012-04-04 Thread Peter Maydell
Expose the Private Peripheral Interrupt inputs as GPIO inputs. The layout of the GPIO array is thus: [0..N-1] SPIs [N..N+31] PPIs for CPU 0 [N+32..N+63] PPIs for CPU 1 ... Treating PPIs as being another kind of input line is in line with the GIC architecture specification, where they are c

[Qemu-devel] [PATCH 01/13] hw/arm_gic: Move NCPU definition to arm_gic.c

2012-04-04 Thread Peter Maydell
Move the NCPU definition to arm_gic.c: the maximum number of CPU interfaces is defined by the GIC architecture specification to be 8, so we don't need to have this #define in each of the sources files which currently includes arm_gic.c. Signed-off-by: Peter Maydell --- hw/a15mpcore.c |8

[Qemu-devel] [PATCH] configure: Remove useless uses of ARCH_CFLAGS

2012-04-04 Thread Peter Maydell
Remove some useless uses of ARCH_CFLAGS -- this variable was never set so will always be empty. The uses were accidental: in commit 0c439cbf8 Juan Quintela removed ARCH_CFLAGS in favour of CFLAGS (which in turn became QEMU_CFLAGS). However in commit be17dc90 a use of it was reintroduced (apparently

Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API

2012-04-04 Thread Jan Kiszka
On 2012-04-04 17:29, Paolo Bonzini wrote: > Il 04/04/2012 17:24, Jan Kiszka ha scritto: For patches 3 and 4, I'd rather use an EventNotifier... >> ...which still lacks support for non-eventfd systems. Hmm, I guess it's >> time to consolidate both. > > Perhaps you can take the relevant patches

Re: [Qemu-devel] [PATCH 14/14] configure: add --confsuffix option

2012-04-04 Thread Paolo Bonzini
Il 30/03/2012 19:33, Eduardo Habkost ha scritto: > This will allow the user to make Qemu use a different subdirectory name > inside $datadir and $sysconfdir, instead of "/qemu". > > Signed-off-by: Eduardo Habkost > --- > configure |9 ++--- > 1 files changed, 6 insertions(+), 3 deletions

Re: [Qemu-devel] [Xen-devel] [PATCH v2] qemu/configure: fix CFLAGS handling for i386

2012-04-04 Thread Peter Maydell
On 4 April 2012 16:40, Peter Maydell wrote: > Having looked at configure I'm pretty sure what we want here is >  QEMU_CFLAGS="-march=i486 $QEMU_CFLAGS" > > because we're only doing this for the benefit of a particular bit > of code in hw/vhost.c and so QEMU_CFLAGS is sufficient. Also this > brings

Re: [Qemu-devel] [PATCH 14/14] configure: add --confsuffix option

2012-04-04 Thread Eduardo Habkost
On Wed, Apr 04, 2012 at 05:26:10PM +0200, Paolo Bonzini wrote: > Il 30/03/2012 19:33, Eduardo Habkost ha scritto: [...] > > -echo " --sysconfdir=PATHinstall config in PATH/qemu" > > +echo " --sysconfdir=PATHinstall config in PATH$confsuffix" > > +echo " --with-confsuffix=SUFFIX

Re: [Qemu-devel] [PATCH 2/3] pseries: Fix bug with reset of VIO CRQs

2012-04-04 Thread Andreas Färber
Am 28.03.2012 23:39, schrieb David Gibson: > PAPR specifies a Command Response Queue (CRQ) mechanism used for virtual > IO, which we implement. However, we don't correctly clean up registered > CRQs when we reset the system. > > This patch adds a reset handler to fix this bug. While we're at it,

Re: [Qemu-devel] [PATCH V3 0/7] Make QED with live migration safe

2012-04-04 Thread Benoît Canet
> > > > I tested qed live migration as well as confirming that bs->open_flags > BDRV_O_INCOMING works correctly in gdb. > > Reviewed-by: Stefan Hajnoczi > ping. Kevin Wolf: will it be merged in your next for-anthony branch ?

Re: [Qemu-devel] [PATCH] Support system reset in Exynos4210

2012-04-04 Thread Maksim Kozlov
04.04.2012 16:35, Dmitry Zhurikhin пишет: On 2012-04-04 15:55, Maksim Kozlov wrote: 04.04.2012 14:08, Dmitry Zhurikhin пишет: Reset the system when 1 is written to SWRESET register Signed-off-by: Dmitry Zhurikhin --- hw/exynos4210_pmu.c | 11 +++ 1 files changed, 11 insertions(+

Re: [Qemu-devel] [PATCH 13/14] configure: change meaning of --datadir to Autoconf convention

2012-04-04 Thread Eduardo Habkost
On Wed, Apr 04, 2012 at 05:25:14PM +0200, Paolo Bonzini wrote: > Il 30/03/2012 19:33, Eduardo Habkost ha scritto: > > Autoconf uses --datadir for the /usr/share directory, not the > > program-specific subdirectory inside /usr/share. This changes configure > > to match autoconf behavior. > > > > No

[Qemu-devel] automatic exit on memory errors

2012-04-04 Thread Frediano Ziglio
Hi, I just realized that on any out of memory conditions Qemu exit with an error. I found this thread on g_malloc http://comments.gmane.org/gmane.comp.emulators.qemu/128863 but nothing related to the exit conditions. I know that out of memory conditions is quite hard to handle but if some

Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API

2012-04-04 Thread Paolo Bonzini
Il 04/04/2012 18:05, Jan Kiszka ha scritto: >> > Perhaps you can take the relevant patches out of the thread-blocks >> > branch at git://github.com/pbonzini/qemu.git? The iothread eventfd >> > could also use an EventNotifier. > Yep, this screams for something like QemuEvent which pleases all users

Re: [Qemu-devel] [PATCH v2 0/4] QOM'ify S/390 CPU

2012-04-04 Thread Andreas Färber
Am 03.04.2012 14:38, schrieb Christian Borntraeger: > On 02/04/12 19:09, Andreas Färber wrote: >> Hello, >> >> This series breaks down my S/390 QOM'ification patch from the >> qom-cpu-others.v1 >> RFC series into better digestable pieces and reorders it next. >> s390x ignores any user-specified -c

[Qemu-devel] [PATCH 11/13] hw/arm_gic.c: Use NVIC instead of LEGACY_INCLUDED_GIC define

2012-04-04 Thread Peter Maydell
Now all the A profile cores have been switched to use the standalone sysbus GIC, the only remaining code which #includes arm_gic.c is the v7M NVIC. The coupling is much closer here so it's not so easily disentangled. For now, add a comment about how arm_gic.c is compiled, and assume that the NVIC a

[Qemu-devel] [PATCH 12/13] hw/arm_gic.c: gic_set_pending_private() is NVIC only

2012-04-04 Thread Peter Maydell
The function gic_set_pending_private() is now used by the NVIC only (for the GIC we now set PPI interrupts via gpio lines and gic_set_irq()). So make it #ifdef NVIC and remove the 'attribute unused' annotation. Signed-off-by: Peter Maydell --- hw/arm_gic.c |5 +++-- 1 files changed, 3 insert

Re: [Qemu-devel] [RFC PATCH v1 1/4] SPI: initial support

2012-04-04 Thread Paul Brook
> Hi Paul, > > Regarding using ssi, theres a few things that come to mind: > > Theres no sense of it being a multi-slave bus, its just a point to > point link. SPI devices universally have the notion of the CS pin that > tristates the device of the bus. Masters connect to a number of slaves > and

Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API

2012-04-04 Thread Jan Kiszka
On 2012-04-04 18:39, Paolo Bonzini wrote: > Il 04/04/2012 18:05, Jan Kiszka ha scritto: Perhaps you can take the relevant patches out of the thread-blocks branch at git://github.com/pbonzini/qemu.git? The iothread eventfd could also use an EventNotifier. >> Yep, this screams for som

[Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API

2012-04-04 Thread Jan Kiszka
Refreshed versions of some cleanups I already sent last year. See patches for details. The series also helps using different scheduling policies for QEMU threads which includes hardening internal locks. Jan Kiszka (5): Introduce qemu_cond_timedwait for POSIX Switch POSIX compat AIO to QEMU ab

[Qemu-devel] [PATCH 1/4] target-s390x: QOM'ify CPU

2012-04-04 Thread Andreas Färber
Embed CPUS390XState as first member of S390CPU. Since -cpu is being ignored, make TYPE_S390_CPU non-abstract. Signed-off-by: Andreas Färber Tested-by: Christian Borntraeger --- Makefile.target|1 + target-s390x/cpu-qom.h | 71 targe

Re: [Qemu-devel] [PATCH] Support system reset in Exynos4210

2012-04-04 Thread Dmitry Zhurikhin
On 2012-04-04 20:16, Maksim Kozlov wrote: > 04.04.2012 16:35, Dmitry Zhurikhin пишет: >> On 2012-04-04 15:55, Maksim Kozlov wrote: >>> 04.04.2012 14:08, Dmitry Zhurikhin пишет: Reset the system when 1 is written to SWRESET register Signed-off-by: Dmitry Zhurikhin --- hw/

[Qemu-devel] [PATCH 06/13] hw/a9mpcore.c: Switch to using sysbus GIC

2012-04-04 Thread Peter Maydell
Switch the a9mpcore to using the sysbus GIC device rather than having the a9mp private memory region device subclass the GIC. Signed-off-by: Peter Maydell --- hw/a9mpcore.c | 60 +--- 1 files changed, 35 insertions(+), 25 deletions(-) diff -

Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API

2012-04-04 Thread Jan Kiszka
On 2012-04-04 18:55, Jan Kiszka wrote: > On 2012-04-04 18:39, Paolo Bonzini wrote: >> Il 04/04/2012 18:05, Jan Kiszka ha scritto: > Perhaps you can take the relevant patches out of the thread-blocks > branch at git://github.com/pbonzini/qemu.git? The iothread eventfd > could also use a

[Qemu-devel] [PATCH V2 0/7] memory: unify ioport registration

2012-04-04 Thread Julien Grall
This is the second version of patch serie (the previous patch was not split) about ioport registration. For the moment some part of QEMU use register_ioport* functions to register ioport. These functions don't permit the logging of range with Memory Listener. Modifications between V1 and V2 : -

[Qemu-devel] [PATCH V2 2/7] hw/acpi_piix4.c: replace register_ioport*

2012-04-04 Thread Julien Grall
This patch replaces all register_ioport* with portio_*. It permits to use the new Memory stuff like listener. Signed-off-by: Julien Grall --- hw/acpi_piix4.c | 76 +++ 1 files changed, 65 insertions(+), 11 deletions(-) diff --git a/hw/acpi_p

[Qemu-devel] [PATCH 4/4] target-s390x: Update s390x_{tod, cpu}_timer() to use S390CPU

2012-04-04 Thread Andreas Färber
In place of CPUS390XState pass S390CPU as opaque from the new initfn. cpu_interrupt() is anticipated to take a CPUState in the future. Signed-off-by: Andreas Färber Tested-by: Christian Borntraeger --- target-s390x/cpu.c|4 ++-- target-s390x/helper.c |6 -- 2 files changed, 6 in

[Qemu-devel] [PATCH 08/13] hw/exynos4210_gic.c: Convert to using sysbus GIC

2012-04-04 Thread Peter Maydell
Convert the Exynos GIC code to use the standalone sysbus GIC device. Signed-off-by: Peter Maydell --- hw/exynos4210_gic.c | 32 1 files changed, 24 insertions(+), 8 deletions(-) diff --git a/hw/exynos4210_gic.c b/hw/exynos4210_gic.c index a05dab2..e1b215e 1006

Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API

2012-04-04 Thread Jan Kiszka
On 2012-04-04 17:29, Paolo Bonzini wrote: > Il 04/04/2012 17:24, Jan Kiszka ha scritto: For patches 3 and 4, I'd rather use an EventNotifier... >> ...which still lacks support for non-eventfd systems. Hmm, I guess it's >> time to consolidate both. > > Perhaps you can take the relevant patches

[Qemu-devel] Switch off use of helper functions

2012-04-04 Thread Rajat Goyal
Is there any way in QEMU to switch off the use of helper functions and make it translate target code to TCG code using only TCG micro-ops and not calls to helper functions? Rajat.

Re: [Qemu-devel] [PATCH 3/3] pseries: Add DPRINTF macros to spapr pci code

2012-04-04 Thread Blue Swirl
On Mon, Apr 2, 2012 at 04:17, David Gibson wrote: > From: Alexey Kardashevskiy > > This adds DPRINTF() macros with the usual conventions to the spapr_pci > code. Please use tracepoints instead of printf statements. Tracing is more flexible, more efficient and does not suffer from bitrot. > Cc:

Re: [Qemu-devel] [PATCH 7/7 v5] VMXNET3 paravirtualized device implementation Interface type "vmxnet3" added.

2012-04-04 Thread Michael S. Tsirkin
On Wed, Apr 04, 2012 at 02:44:01PM +0300, Izik Eidus wrote: > Hi, > > What about this patch?, everything that was asked from Dmitry was > accomplished... > What prevent us from progressing with merging this patch? > > Thanks. Off the top of my head: issues with v5: polluting global namespace, mu

[Qemu-devel] [PATCH 07/13] hw/realview_gic: switch to sysbus GIC

2012-04-04 Thread Peter Maydell
Switch the realview_gic device to the standalone sysbus GIC. Signed-off-by: Peter Maydell --- hw/realview_gic.c | 38 ++ 1 files changed, 26 insertions(+), 12 deletions(-) diff --git a/hw/realview_gic.c b/hw/realview_gic.c index a3b5a04..5bc37a7 100644 ---

[Qemu-devel] [PATCH 3/4] target-s390x: QOM'ify CPU init

2012-04-04 Thread Andreas Färber
Move code from cpu_s390x_init() into an initfn. Signed-off-by: Andreas Färber Tested-by: Christian Borntraeger --- target-s390x/cpu.c| 25 + target-s390x/cpu.h|3 +++ target-s390x/helper.c | 21 +++-- 3 files changed, 31 insertions(+), 18

Re: [Qemu-devel] Using load_elf

2012-04-04 Thread Blue Swirl
On Mon, Apr 2, 2012 at 22:57, Brian Vandenberg wrote: >  I'm attempting to familiarize myself with the APIs used to add > support for boards in qemu, and I have a few questions. > > * How does using load_elf differ from load_image_targphys? > >  As an example, many of the boards I've looked at hav

[Qemu-devel] [PATCH 13/14] configure: change meaning of --datadir to Autoconf convention

2012-04-04 Thread Eduardo Habkost
Autoconf uses --datadir for the /usr/share directory, not the program-specific subdirectory inside /usr/share. This changes configure to match autoconf behavior. Note that this will break compatibility with existing build scripts. Signed-off-by: Eduardo Habkost --- configure |9 + 1

[Qemu-devel] [PATCH 04/13] arm_gic: Make the GIC its own sysbus device

2012-04-04 Thread Peter Maydell
Compile arm_gic.c as a standalone C file to produce a self contained sysbus GIC device. Support the legacy usage by #include of the .c file by making those users #define LEGACY_INCLUDED_GIC, so we can convert them one by one. Signed-off-by: Peter Maydell --- Makefile.target |1 + hw/a15m

[Qemu-devel] [PATCH 2/4] target-s390x: QOM'ify CPU reset

2012-04-04 Thread Andreas Färber
Move code from cpu_state_reset() to s390_cpu_reset(). Signed-off-by: Andreas Färber Tested-by: Christian Borntraeger --- target-s390x/cpu.c| 13 - target-s390x/helper.c | 12 ++-- 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/target-s390x/cpu.c b/t

[Qemu-devel] [PATCH 07/14] Makefile: use $(qemu_confdir) instead of $(sysconfdir)/qemu

2012-04-04 Thread Eduardo Habkost
Instead of hardcoding the directory suffix, use the qemu-specific directory variable. Signed-off-by: Eduardo Habkost --- Makefile |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 1c9abec..795f9c4 100644 --- a/Makefile +++ b/Makefile @@ -280,8

Re: [Qemu-devel] [PATCH 3/3] pseries: Add DPRINTF macros to spapr pci code

2012-04-04 Thread Peter Maydell
On 4 April 2012 20:18, Blue Swirl wrote: > On Mon, Apr 2, 2012 at 04:17, David Gibson > wrote: >> From: Alexey Kardashevskiy >> This adds DPRINTF() macros with the usual conventions to the spapr_pci >> code. > > Please use tracepoints instead of printf statements. Tracing is more > flexible, mo

[Qemu-devel] [PATCH v4 00/14] configure: --with-confsuffix option

2012-04-04 Thread Eduardo Habkost
I was going to resend only patch 14/14 with a fixed description, but then I noticed the series had to be rebased, with small conflicts on patches 04/14 and 12/14, so I am submitting the whole series again. Changes v3 -> v4: - Rebase against latest qemu.git - Changed patch 14/14 subject to match

Re: [Qemu-devel] [PATCH 3/3] pseries: Add DPRINTF macros to spapr pci code

2012-04-04 Thread Blue Swirl
On Wed, Apr 4, 2012 at 20:11, Peter Maydell wrote: > On 4 April 2012 20:18, Blue Swirl wrote: >> On Mon, Apr 2, 2012 at 04:17, David Gibson >> wrote: >>> From: Alexey Kardashevskiy >>> This adds DPRINTF() macros with the usual conventions to the spapr_pci >>> code. >> >> Please use tracepoints

[Qemu-devel] [PATCH 13/13] hw/arm_gic.c: Remove stray hardcoded tab

2012-04-04 Thread Peter Maydell
Remove the single instance of a hardcoded tab from hw/arm_gic.c. Signed-off-by: Peter Maydell --- hw/arm_gic.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/arm_gic.c b/hw/arm_gic.c index f395e4b..a2aee63 100644 --- a/hw/arm_gic.c +++ b/hw/arm_gic.c @@ -160,7 +160,

Re: [Qemu-devel] [PATCH 1/2][sparc64] Fix vector interrupt handling

2012-04-04 Thread Blue Swirl
Thanks, applied both. On Tue, Apr 3, 2012 at 15:49, Artyom Tarasenko wrote: > Don't produce stray irq 5, don't overwrite ivec_data if still busy with > processing of the previous interrupt. > > Signed-off-by: Artyom Tarasenko > --- >  hw/sun4u.c |   29 - >  1 files ch

Re: [Qemu-devel] [PATCH 5/6] main-loop: replace WaitForMultipleObjects with g_poll

2012-04-04 Thread Blue Swirl
On Tue, Mar 20, 2012 at 09:49, Paolo Bonzini wrote: > On w32, glib implements g_poll using WaitForMultipleObjects > or MsgWaitForMultipleObjects.  This means that we can simplify > our code by switching to g_poll, and at the same time prepare for > adding back glib sources. Unfortunately g_poll d

Re: [Qemu-devel] [PATCH 3/3] pseries: Add DPRINTF macros to spapr pci code

2012-04-04 Thread Peter Maydell
On 4 April 2012 21:34, Blue Swirl wrote: > On Wed, Apr 4, 2012 at 20:11, Peter Maydell wrote: >> I'd much rather enable a #define to turn on debugging than faff about >> with tracing. It's simple and straightforward, you can do it with a >> single obvious change and recompile, and nobody has to l

Re: [Qemu-devel] [PATCH 5/6] main-loop: replace WaitForMultipleObjects with g_poll

2012-04-04 Thread Peter Maydell
On 4 April 2012 21:44, Blue Swirl wrote: > On Tue, Mar 20, 2012 at 09:49, Paolo Bonzini wrote: >> On w32, glib implements g_poll using WaitForMultipleObjects >> or MsgWaitForMultipleObjects.  This means that we can simplify >> our code by switching to g_poll, and at the same time prepare for >> a

[Qemu-devel] [PATCH V2 5/7] hw/pc.c: replace register_ioport*

2012-04-04 Thread Julien Grall
This patch replaces all register_ioport* with portio_* or isa_register_portio_list. It permits to use the new Memory stuff like listener. Signed-off-by: Julien Grall --- hw/pc.c | 37 +++-- 1 files changed, 23 insertions(+), 14 deletions(-) diff --git a/hw/pc.c

[Qemu-devel] [PATCH 04/14] create_config: separate section for qemu_*dir variables (v2)

2012-04-04 Thread Eduardo Habkost
The generic *dir section will eventually go away and be replaced with qemu_* section. By now, both sections will be kept, while the variables get renamed on config-host.mak. With this patch, a XXXdir variable will become a CONFIG_QEMU_XXXDIR define, and a qemu_XXXdir variable will become CONFIG_QE

[Qemu-devel] [PATCH 06/14] config-host.mak: rename confdir to qemu_confdir

2012-04-04 Thread Eduardo Habkost
$confdir is a confusing name, as it's not clear if it's "the system config dir" or "the Qemus-specific directory inside the config dir". $qemu_confdir makes it more clear. The current C code that uses CONFIG_QEMU_CONFDIR should be safe, as now create_config generates the same #define name (CONFIG_

Re: [Qemu-devel] Windows Virtio Issue

2012-04-04 Thread emilien
Vadim Rozenfeld redhat.com> writes: > Hi Paul, > Managed to reproduce this problem, thank you. Going to fix it in the build. > Meanwhile, instead of writeback, could you try cache=off ? > > Best regards, > Vadim. > > Any news? I have the same issue with cache=off, there isn't any fix? Best

Re: [Qemu-devel] [PATCH 13/14] configure: change meaning of --datadir to Autoconf convention

2012-04-04 Thread Paolo Bonzini
Il 30/03/2012 19:33, Eduardo Habkost ha scritto: > Autoconf uses --datadir for the /usr/share directory, not the > program-specific subdirectory inside /usr/share. This changes configure > to match autoconf behavior. > > Note that this will break compatibility with existing build scripts. > > Sig

Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API

2012-04-04 Thread Paolo Bonzini
Il 04/04/2012 17:24, Jan Kiszka ha scritto: >> > For patches 3 and 4, I'd rather use an EventNotifier... > ...which still lacks support for non-eventfd systems. Hmm, I guess it's > time to consolidate both. Perhaps you can take the relevant patches out of the thread-blocks branch at git://github.c

[Qemu-devel] [PATCH V2 1/7] isa: add isa_address_space_io

2012-04-04 Thread Julien Grall
This function permits to retrieve ISA IO address space. It will be usefull when we need to pass IO address space as argument. Signed-off-by: Julien Grall --- hw/isa-bus.c |5 + hw/isa.h |1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/isa-bus.c b/hw/isa-bus

[Qemu-devel] [PATCH v2 2/2] target-sparc: QOM'ify CPU

2012-04-04 Thread Andreas Färber
Embed CPUSPARCState as first member of SPARCCPU. Drop cpu_sparc_close() in favor of object_delete() and a finalizer. Let cpu_state_reset() call cpu_reset(). Make TYPE_SPARC_CPU non-abstract for now. Distinguish between "sparc-cpu" and "sparc64-cpu". Signed-off-by: Andreas Färber --- target-spar

Re: [Qemu-devel] PL353 Device model

2012-04-04 Thread John Williams
On Fri, Mar 30, 2012 at 5:13 PM, Peter Crosthwaite wrote: > We currently have a somewhat hacky PL353 device model in our tree that > we wish to refactor and ultimately push to mainline. Before I go about > reworking it, I wish to discuss the architecture of this device model > because its non-tri

Re: [Qemu-devel] [PATCH v2 0/2] Xilinx Zynq PL330 support

2012-04-04 Thread John Williams
On Fri, Mar 30, 2012 at 5:58 PM, Peter A. G. Crosthwaite wrote: > These patches add support for the Primcell PL330 DMA controller and add it to > the Xilinx Zynq machine model. Patch 1 is the device model. Patch 2 is the > machine model update. > > The Device model was originally contributed by

Re: [Qemu-devel] PL353 Device model

2012-04-04 Thread Andreas Färber
Hello John, Am 05.04.2012 01:35, schrieb John Williams: > On Fri, Mar 30, 2012 at 5:13 PM, Peter Crosthwaite > wrote: > >> We currently have a somewhat hacky PL353 device model in our tree that >> we wish to refactor and ultimately push to mainline. Before I go about >> reworking it, I wish to d

[Qemu-devel] [PATCH 02/13] hw/arm_gic: Move gic_get_current_cpu into arm_gic.c

2012-04-04 Thread Peter Maydell
Move the gic_get_current_cpu() function into arm_gic.c. There are only two implementations: (1) "get the index of the currently executing CPU", used by all multicore GICs, and (2) "always 0", used by all GICs instantiated with a single CPU interface (the Realview board GIC and the v7M NVIC). So we

Re: [Qemu-devel] PL353 Device model

2012-04-04 Thread Peter Crosthwaite
Thanks for you thoughts Andreas, On Thu, Apr 5, 2012 at 9:56 AM, Andreas Färber wrote: > Hello John, > > Am 05.04.2012 01:35, schrieb John Williams: >> On Fri, Mar 30, 2012 at 5:13 PM, Peter Crosthwaite >> wrote: >> >>> We currently have a somewhat hacky PL353 device model in our tree that >>> w

Re: [Qemu-devel] [RFC PATCH v1 1/4] SPI: initial support

2012-04-04 Thread Peter Crosthwaite
>> >> It may be a case though that ssi is a superclass of spi - all SPI >> devices are SSI devices but not all SSI devices are SPI? To that end >> can we make SPI a child object of SSI with the desired extra behaviors >> mentioned in this thread? This kind of stuff is the whole reason for >> QOM. >

  1   2   >