Re: [Qemu-devel] [PATCH, RESEND] kvm: Fix dirty tracking with large kernel page size

2012-04-03 Thread Jan Kiszka
On 2012-04-02 06:04, David Gibson wrote: > From: Ben Herrenschmidt > > If the kernel page size is larger than TARGET_PAGE_SIZE, which > happens for example on ppc64 with kernels compiled for 64K pages, > the dirty tracking doesn't work. > > Cc: Avi Kivity > Cc: Marcelo Tosatti > > Signed-off-

Re: [Qemu-devel] [PATCH] Better support for dma_addr_t variables

2012-04-03 Thread Peter Maydell
On 3 April 2012 01:51, David Gibson wrote: > On Mon, Apr 02, 2012 at 09:49:12AM +0200, Andreas Färber wrote: >> Yes, the issue here is under what license the file is. It's a new file, >> so in lack of a license statement is it under GPLv2 because QEMU as a >> whole currently is?  Thus a header exp

Re: [Qemu-devel] qdev property listing broken

2012-04-03 Thread Paolo Bonzini
Il 03/04/2012 00:27, Peter Maydell ha scritto: > On 2 April 2012 23:03, Paolo Bonzini wrote: >> Il 02/04/2012 22:07, Peter Maydell ha scritto: >>> On 2 April 2012 20:40, Paolo Bonzini wrote: diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c index a310cc7..923519c 100644 --- a/hw/q

[Qemu-devel] [RFC][PATCH v2 0/4] uq/master: Basic MSI support for in-kernel irqchip mode

2012-04-03 Thread Jan Kiszka
This is v2 of the RFC, fixing a memory leak in kvm_flush_dynamic_msi_routes and adding support for the proposed KVM_SIGNAL_MSI IOCTL. This series depends on "kvm: set gsi_bits and max_gsi correctly" (http://thread.gmane.org/gmane.comp.emulators.kvm.devel/88906). Jan Kiszka (4): kvm: Refactor KV

[Qemu-devel] [RFC][PATCH v2 1/4] kvm: Refactor KVMState::max_gsi to gsi_count

2012-04-03 Thread Jan Kiszka
From: Jan Kiszka Instead of the bitmap size, store the maximum of GSIs the kernel support. Move the GSI limit assertion to the API function kvm_irqchip_add_route and make it stricter. Signed-off-by: Jan Kiszka --- kvm-all.c |8 1 files changed, 4 insertions(+), 4 deletions(-) dif

[Qemu-devel] [RFC][PATCH v2 2/4] kvm: Introduce basic MSI support for in-kernel irqchips

2012-04-03 Thread Jan Kiszka
From: Jan Kiszka This patch basically adds kvm_irqchip_send_msi, a service for sending arbitrary MSI messages to KVM's in-kernel irqchip models. As the current KVI API requires us to establish a static route from a pseudo GSI to the target MSI message and inject the MSI via toggling that GSI, we

[Qemu-devel] [RFC][PATCH v2 4/4] kvm: Add support for direct MSI injections

2012-04-03 Thread Jan Kiszka
From: Jan Kiszka If the kernel supports KVM_SIGNAL_MSI, we can avoid the route-based MSI injection mechanism. Signed-off-by: Jan Kiszka --- kvm-all.c | 22 +++--- 1 files changed, 19 insertions(+), 3 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 5256511..6225bab 1006

Re: [Qemu-devel] [PATCH 00/12 v11] introducing a new, dedicated guest memory dump mechanism

2012-04-03 Thread Jan Kiszka
On 2012-04-02 05:19, Wen Congyang wrote: > At 03/28/2012 08:44 PM, Luiz Capitulino Wrote: >> On Wed, 28 Mar 2012 13:17:43 +0800 >> Wen Congyang wrote: >> >>> Hi, Luiz, Anthony, Jan >>> >>> do you have any comments about this patchset? >> >> As far as QMP is concerned: >> >> Acked-by: Luiz Capitul

[Qemu-devel] [RFC][PATCH v2 3/4] KVM: x86: Wire up MSI support for in-kernel irqchip

2012-04-03 Thread Jan Kiszka
From: Jan Kiszka Catch writes to the MSI MMIO region in the KVM APIC and forward them to the kernel. Provide the kernel support GSI routing, this allows to enable MSI support also for in-kernel irqchip mode. Signed-off-by: Jan Kiszka --- hw/apic.c |3 +++ hw/kvm/apic.c | 33 +

Re: [Qemu-devel] [PATCH] Memory: unify ioport registration

2012-04-03 Thread Avi Kivity
On 04/02/2012 05:37 PM, Julien Grall wrote: > Replace register_ioport* by portio_list_*. > All ioports registered by the previous functions don't call memory callback. > > Signed-off-by: Julien Grall > --- > hw/acpi_piix4.c | 22 +++--- > hw/cirrus_vga.c | 31 +

Re: [Qemu-devel] [RFC PATCH v1 2/4] m25p80: initial verion

2012-04-03 Thread Stefan Hajnoczi
On Fri, Mar 30, 2012 at 04:37:11PM +1000, Peter A. G. Crosthwaite wrote: > +static void flash_sync_page(struct flash *s, int page) > +{ > +if (s->bdrv) { > +int bdrv_sector; > +int offset; > + > +bdrv_sector = (page * s->pagesize) / 512; > +offset = bdrv_sector *

Re: [Qemu-devel] [PATCH v2] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-03 Thread Stefan Hajnoczi
On Tue, Apr 03, 2012 at 01:15:40PM +0800, Liu Yuan wrote: > +static int coroutine_fn sd_co_flush_to_disk(BlockDriverState *bs) > +{ > +BDRVSheepdogState *s = bs->opaque; > +SheepdogObjReq hdr = { 0 }; > +SheepdogObjRsp *rsp = (SheepdogObjRsp *)&hdr; > +SheepdogInode *inode = &s->ino

Re: [Qemu-devel] Intermittent e1000 failure on qemu-kvm 1.0

2012-04-03 Thread Stefan Hajnoczi
On Mon, Apr 02, 2012 at 04:37:23PM +0100, Chris Webb wrote: > We initially saw a problem after an upgrade from 0.15.x to 1.0. Perhaps git-bisect(1) can help you track down the change that introduced this between 0.15 and 1.0. > Once I've got a guest with broken networking, the network stays down

Re: [Qemu-devel] Intermittent e1000 failure on qemu-kvm 1.0

2012-04-03 Thread Chris Webb
Stefan Hajnoczi writes: > On Mon, Apr 02, 2012 at 04:37:23PM +0100, Chris Webb wrote: > > We initially saw a problem after an upgrade from 0.15.x to 1.0. > > Perhaps git-bisect(1) can help you track down the change that introduced > this between 0.15 and 1.0. Hi. I attempted this, but the bug i

Re: [Qemu-devel] Intermittent e1000 failure on qemu-kvm 1.0

2012-04-03 Thread Stefan Hajnoczi
On Tue, Apr 3, 2012 at 9:13 AM, Chris Webb wrote: > Stefan Hajnoczi writes: >> On Mon, Apr 02, 2012 at 04:37:23PM +0100, Chris Webb wrote: >> It sounds like this is not the issue, but are you sure the bridge has >> forwarding delay set to 0 or Spanning Tree Protocol disabled?  With STP >> enabled

[Qemu-devel] [PATCH v3] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-03 Thread Liu Yuan
From: Liu Yuan Flush operation is supposed to flush the write-back cache of sheepdog cluster. By issuing flush operation, we can assure the Guest of data reaching the sheepdog cluster storage. Cc: Kevin Wolf Cc: Michael Tokarev Cc: MORITA Kazutaka Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan

Re: [Qemu-devel] [PATCH 6/6] hw/sd.c: convert to QOM object

2012-04-03 Thread Igor Mitsyanko
On 04/03/2012 01:02 AM, Paolo Bonzini wrote: Il 02/04/2012 22:56, Igor Mitsyanko ha scritto: 2) At first I made SD card child of SD host controller, but it most certainly wrong, it should be a link. This is a bit thorny, because BlockDriverState exposes a slot and its medium, not just the medi

Re: [Qemu-devel] [PATCH 1/3] configure: Fix typo 'lib_qga' -> 'libs_qga'

2012-04-03 Thread Stefan Hajnoczi
On Mon, Apr 02, 2012 at 02:49:38PM +0200, Lluís Vilanova wrote: > Signed-off-by: Lluís Vilanova > --- > configure |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/configure b/configure > index bea4a2c..c7be13d 100755 > --- a/configure > +++ b/configure > @@ -526,7 +

Re: [Qemu-devel] [PATCH 2/3] configure: Link QEMU against 'liburcu-bp'

2012-04-03 Thread Stefan Hajnoczi
On Mon, Apr 02, 2012 at 02:49:44PM +0200, Lluís Vilanova wrote: > This library is needed when using 'ust/tracepoint.h'. > > Signed-off-by: Harsh Prateek Bora > Signed-off-by: Lluís Vilanova > --- > configure |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to the t

[Qemu-devel] [PATCH 02/10] coroutine: rename unlock_bh_queue to co_runnable_queue

2012-04-03 Thread Lai Jiangshan
It stands for runnable Coroutines. Signed-off-by: Lai Jiangshan --- qemu-coroutine-lock.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/qemu-coroutine-lock.c b/qemu-coroutine-lock.c index 26ad76b..10e8dbb 100644 --- a/qemu-coroutine-lock.c +++ b/qemu-c

Re: [Qemu-devel] [PATCH] Better support for dma_addr_t variables

2012-04-03 Thread Andreas Färber
Am 03.04.2012 02:51, schrieb David Gibson: > On Mon, Apr 02, 2012 at 09:49:12AM +0200, Andreas Färber wrote: >> Am 31.03.2012 10:50, schrieb David Gibson: >>> On Fri, Mar 30, 2012 at 11:34:25AM +0200, Andreas Färber wrote: Am 30.03.2012 11:32, schrieb Andreas Färber: > Am 27.03.2012 04:43,

Re: [Qemu-devel] [Qemu-trivial] [PATCH trivial] make: fix clean rule by removing build file in qom/

2012-04-03 Thread Stefan Hajnoczi
On Mon, Apr 02, 2012 at 04:10:39PM +0100, Anthony PERARD wrote: > Make clean does not clean the 'qom' directory, leaving *.o and *.d files. This > patch fixes this. > > Signed-off-by: Anthony PERARD > > --- > Makefile |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Thanks, applied

[Qemu-devel] [PATCH] versatilepb: add i2c support

2012-04-03 Thread Oskar Andero
Signed-off-by: Oskar Andero --- hw/versatilepb.c | 80 ++ 1 files changed, 80 insertions(+), 0 deletions(-) diff --git a/hw/versatilepb.c b/hw/versatilepb.c index 25afb1e..014621a 100644 --- a/hw/versatilepb.c +++ b/hw/versatilepb.c @@ -16,9

Re: [Qemu-devel] [PATCH v3] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-03 Thread Kevin Wolf
Am 03.04.2012 10:35, schrieb Liu Yuan: > From: Liu Yuan > > Flush operation is supposed to flush the write-back cache of > sheepdog cluster. > > By issuing flush operation, we can assure the Guest of data > reaching the sheepdog cluster storage. > > Cc: Kevin Wolf > Cc: Michael Tokarev > Cc:

[Qemu-devel] [PATCH 10/10] coroutine: add qemu_coroutine_run() wrapper

2012-04-03 Thread Lai Jiangshan
Wrapper for qemu_coroutine_create()+qemu_coroutine_enter() Signed-off-by: Lai Jiangshan --- block.c | 28 +++- hw/9pfs/virtio-9p.c |4 +--- nbd.c |2 +- qemu-coroutine.h| 12 qemu-io.c |4 +--- 5 files c

Re: [Qemu-devel] [PATCH] versatilepb: add i2c support

2012-04-03 Thread Andreas Färber
Am 02.04.2012 22:17, schrieb Oskar Andero: > Signed-off-by: Oskar Andero > --- > hw/versatilepb.c | 80 > ++ > 1 files changed, 80 insertions(+), 0 deletions(-) > > diff --git a/hw/versatilepb.c b/hw/versatilepb.c > index 25afb1e..014621a 10

[Qemu-devel] [PATCH 04/10] coroutine: init co_runnable_bh during boot

2012-04-03 Thread Lai Jiangshan
use __attribute__((constructor)) to do the initialization. Signed-off-by: Lai Jiangshan --- qemu-coroutine-lock.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/qemu-coroutine-lock.c b/qemu-coroutine-lock.c index 90141cd..7c29bc4 100644 --- a/qemu-coroutine-lock

[Qemu-devel] [PATCH 07/10] coroutine: split qemu-coroutine-lock.c

2012-04-03 Thread Lai Jiangshan
queues are not just internal things for locks, split them. Signed-off-by: Lai Jiangshan --- Makefile.objs |2 +- qemu-coroutine-lock.c | 49 +-- qemu-coroutine-queue.c | 76 trace-events |

Re: [Qemu-devel] [PATCH 3/3] configure: Link qga against UST tracing related libraries

2012-04-03 Thread Stefan Hajnoczi
On Mon, Apr 02, 2012 at 02:49:49PM +0200, Lluís Vilanova wrote: > Signed-off-by: Harsh Prateek Bora > Signed-off-by: Lluís Vilanova > --- > configure |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commit

Re: [Qemu-devel] [PATCH v3] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-03 Thread MORITA Kazutaka
At Tue, 3 Apr 2012 16:35:00 +0800, Liu Yuan wrote: > > +static int coroutine_fn sd_co_flush_to_disk(BlockDriverState *bs) > +{ > +BDRVSheepdogState *s = bs->opaque; > +SheepdogObjReq hdr = { 0 }; > +SheepdogObjRsp *rsp = (SheepdogObjRsp *)&hdr; > +SheepdogInode *inode = &s->inode

Re: [Qemu-devel] [PATCH] Memory: unify ioport registration

2012-04-03 Thread Andreas Färber
Am 02.04.2012 16:37, schrieb Julien Grall: > Replace register_ioport* by portio_list_*. [snip] Are these changes guaranteed to not change the addresses in some way? We've had really subtle bugs with offsets added / not added in the past. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409

Re: [Qemu-devel] [PATCH] Memory: unify ioport registration

2012-04-03 Thread Julien Grall
On 04/03/2012 08:51 AM, Avi Kivity wrote: On 04/02/2012 05:37 PM, Julien Grall wrote: if (!inited) { inited = 1; @@ -2814,19 +2830,8 @@ static void cirrus_init_common(CirrusVGAState * s, int device_id, int is_pci, s->bustype = CIRRUS_BUSTYPE_ISA; } -

[Qemu-devel] [PATCH 08/10] coroutine: process the coroutines woken by child when child yield

2012-04-03 Thread Lai Jiangshan
If the child wake up someone, process them. It would the child complete its works if woken coroutine release the locks that the child needs. It may help for the cache, if the child wake up some someone, they are probably accessing the same data. Signed-off-by: Lai Jiangshan --- qemu-coroutine.

Re: [Qemu-devel] [patch V5 0/5] i.MX31 support

2012-04-03 Thread Andreas Färber
Peter, Am 03.04.2012 03:55, schrieb Peter Chubb: > This is the fifth round of patches for preliminary Freescale i.MX31 > support. If you resend this, it would be nice to shorten the subjects, so that the interesting part is not hidden in the back. First one's fine, then for example: i.MX31: Cloc

[Qemu-devel] [PATCH 09/10] coroutine: schedule timeout coroutine instead process it directly

2012-04-03 Thread Lai Jiangshan
Avoid a timer callback spends too much time. Signed-off-by: Lai Jiangshan --- qemu-coroutine-sleep.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-coroutine-sleep.c b/qemu-coroutine-sleep.c index fd65274..df9254a 100644 --- a/qemu-coroutine-sleep.c +++ b/qemu-cor

[Qemu-devel] [PATCH 01/10] coroutine: use qemu_coroutine_switch() directly

2012-04-03 Thread Lai Jiangshan
When qemu_coroutine_switch() in the qemu_coroutine_yield() returns, It must be someone calls qemu_coroutine_enter() for it, so the @to is active, the tests in coroutine_swap() are unneeded, so we use qemu_coroutine_switch() directly in qemu_coroutine_yield(). Signed-off-by: Lai Jiangshan --- qem

Re: [Qemu-devel] [PATCH 6/6] hw/sd.c: convert to QOM object

2012-04-03 Thread Paolo Bonzini
Il 03/04/2012 10:35, Igor Mitsyanko ha scritto: > I think there's no point in preserving BlockDriverState along with > SDState when we eject image from slot. Just drive_add()-drive_init() it > when user inserts image and drive_put_ref() when user ejects image. Note that the BlockDriverState curren

[Qemu-devel] [PATCH 06/10] coroutine: move runnale coroutine code to qemu-coroutine.c

2012-04-03 Thread Lai Jiangshan
runnable coroutine queue is the core mangement of the coroutine. Signed-off-by: Lai Jiangshan --- qemu-coroutine-lock.c | 27 --- qemu-coroutine.c | 27 +++ qemu-coroutine.h |7 +++ trace-events |2 +- 4 files cha

[Qemu-devel] [PATCH 03/10] coroutine: rename qemu_co_queue_next_bh() to qemu_co_process_runnable()

2012-04-03 Thread Lai Jiangshan
Signed-off-by: Lai Jiangshan --- qemu-coroutine-lock.c |6 +++--- trace-events |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/qemu-coroutine-lock.c b/qemu-coroutine-lock.c index 10e8dbb..90141cd 100644 --- a/qemu-coroutine-lock.c +++ b/qemu-coroutine-lock.c

[Qemu-devel] [PATCH v4] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-03 Thread Liu Yuan
From: Liu Yuan Flush operation is supposed to flush the write-back cache of sheepdog cluster. By issuing flush operation, we can assure the Guest of data reaching the sheepdog cluster storage. Cc: Kevin Wolf Cc: Michael Tokarev Cc: MORITA Kazutaka Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan

[Qemu-devel] [PATCH 05/10] coroutine: add qemu_co_runnable_schedule()

2012-04-03 Thread Lai Jiangshan
split qemu_co_queue_next() as two parts: the first part is dequeuing next from the wait queue. the second part is schedule it to the runnable queue(qemu_co_runnable_schedule()) Signed-off-by: Lai Jiangshan --- qemu-coroutine-lock.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH 14/15] xl-parsing: Parse the new option device_models

2012-04-03 Thread Stefano Stabellini
On Mon, 2 Apr 2012, Ian Jackson wrote: > Julien Grall writes ("[Xen-devel] [XEN][RFC PATCH 14/15] xl-parsing: Parse > the new option device_models"): > > For the support of multiple ioreq server, we add a new option > > "device_models". > > It's an array of device model, for each device model, we

[Qemu-devel] RE. [PATCH] sheepdog: fix send req helpers

2012-04-03 Thread Liu Yuan
From: Liu Yuan Yes, I think so. Here is the patch. Subject: [PATCH] sheepdog: fix send req helpers From: Liu Yuan We should return if reading of the header fails. Cc: Kevin Wolf Cc: MORITA Kazutaka Signed-off-by: Liu Yuan --- block/sheepdog.c |2 ++ 1 files changed, 2 insertions(+), 0

Re: [Qemu-devel] [PATCHv3] piix: fix up/down races

2012-04-03 Thread Michael S. Tsirkin
On Tue, Apr 03, 2012 at 02:40:41AM -0400, Igor Mammedov wrote: > > > + */ > > > +s->pci0_status.down &= ~(1U << slot); > > > > Should we clear "up" here too? > Is it possible to create pci dev for not yet freed pci slot? It's not possible ATM. > If not then we should not care, otherwise

Re: [Qemu-devel] [Qemu-trivial] [PATCH trivial] make: fix clean rule by removing build file in qom/

2012-04-03 Thread Anthony PERARD
On Tue, Apr 3, 2012 at 09:56, Stefan Hajnoczi wrote: > >> tg: (a3b6181..) fix/make-clean (depends on: master) > > What's this?  I'm curious.  First I thought it was a signature joke that > I didn't get but I guess it's for some kind of commit tracking system? No, it is not. To prepare a patch (or

[Qemu-devel] [PATCH v4 UPDATE] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-03 Thread Liu Yuan
From: Liu Yuan Flush operation is supposed to flush the write-back cache of sheepdog cluster. By issuing flush operation, we can assure the Guest of data reaching the sheepdog cluster storage. Cc: Kevin Wolf Cc: Michael Tokarev Cc: MORITA Kazutaka Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan

Re: [Qemu-devel] [PATCH] Memory: unify ioport registration

2012-04-03 Thread Avi Kivity
On 04/03/2012 12:38 PM, Julien Grall wrote: >> Please pass either pci_address_space_io() or isa_io_address_space() >> (you'll have to write the latter) to cirrus_init_common() from its >> callers. We really want to avoid get_system_io(). >> >> > isa_io_address_space doesn't exist. I will

Re: [Qemu-devel] [Qemu-trivial] [PATCH trivial] make: fix clean rule by removing build file in qom/

2012-04-03 Thread Stefan Hajnoczi
On Tue, Apr 03, 2012 at 11:06:45AM +0100, Anthony PERARD wrote: > On Tue, Apr 3, 2012 at 09:56, Stefan Hajnoczi wrote: > > > >> tg: (a3b6181..) fix/make-clean (depends on: master) > > > > What's this?  I'm curious.  First I thought it was a signature joke that > > I didn't get but I guess it's for

Re: [Qemu-devel] [PATCH] Memory: unify ioport registration

2012-04-03 Thread Avi Kivity
On 04/03/2012 12:34 PM, Andreas Färber wrote: > Am 02.04.2012 16:37, schrieb Julien Grall: > > Replace register_ioport* by portio_list_*. > [snip] > > Are these changes guaranteed to not change the addresses in some way? Yes (modulo those subtle bugs). > We've had really subtle bugs with offsets

Re: [Qemu-devel] [PATCH v4 UPDATE] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-03 Thread MORITA Kazutaka
At Tue, 3 Apr 2012 18:08:10 +0800, Liu Yuan wrote: > > From: Liu Yuan > > Flush operation is supposed to flush the write-back cache of > sheepdog cluster. > > By issuing flush operation, we can assure the Guest of data > reaching the sheepdog cluster storage. > > Cc: Kevin Wolf > Cc: Michael

Re: [Qemu-devel] [PATCH v4 UPDATE] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-03 Thread Kevin Wolf
Am 03.04.2012 12:32, schrieb MORITA Kazutaka: > At Tue, 3 Apr 2012 18:08:10 +0800, > Liu Yuan wrote: >> >> From: Liu Yuan >> >> Flush operation is supposed to flush the write-back cache of >> sheepdog cluster. >> >> By issuing flush operation, we can assure the Guest of data >> reaching the sheep

[Qemu-devel] [PATCH 5/8] main-loop: make qemu_event_handle static

2012-04-03 Thread Stefan Hajnoczi
From: Frediano Ziglio Signed-off-by: Frediano Ziglio Signed-off-by: Stefan Hajnoczi --- main-loop.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/main-loop.c b/main-loop.c index db23de0..fc738d1 100644 --- a/main-loop.c +++ b/main-loop.c @@ -164,7 +164,7 @@ static i

[Qemu-devel] [PULL 0/8] Trivial patches for 27 March to 3 April 2012

2012-04-03 Thread Stefan Hajnoczi
I'm will be gone from tomorrow until Monday so it's time to flush the trivial-patches queue. The following changes since commit f05f6b4adb4db3affb0cdd17383b0a7e905e66e1: qdev: put all devices under /machine (2012-04-02 15:04:15 -0500) are available in the git repository at: git://github.com

[Qemu-devel] [PATCH 7/8] configure: Link qga against UST tracing related libraries

2012-04-03 Thread Stefan Hajnoczi
From: Lluís Vilanova Signed-off-by: Harsh Prateek Bora Signed-off-by: Lluís Vilanova Signed-off-by: Stefan Hajnoczi --- configure |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 319355b..520bd93 100755 --- a/configure +++ b/configure @@ -26

Re: [Qemu-devel] RE. [PATCH] sheepdog: fix send req helpers

2012-04-03 Thread MORITA Kazutaka
At Tue, 3 Apr 2012 18:04:21 +0800, Liu Yuan wrote: > > From: Liu Yuan > > Yes, I think so. Here is the patch. > > Subject: [PATCH] sheepdog: fix send req helpers > From: Liu Yuan > > We should return if reading of the header fails. > > Cc: Kevin Wolf > Cc: MORITA Kazutaka > Signed-off-by:

[Qemu-devel] [PATCH 1/8] configure: fix mingw32 libs_qga typo

2012-04-03 Thread Stefan Hajnoczi
It's typical to prepend or append parameters to an argument string so that other places in ./configure can add parameters without clobbering the string. In the mingw32 libs_qga case there is a typo "$lib_qga" instead of "$libs_qga". Signed-off-by: Stefan Hajnoczi Reviewed-by: Andreas Färber ---

[Qemu-devel] [PATCH 6/8] configure: Link QEMU against 'liburcu-bp'

2012-04-03 Thread Stefan Hajnoczi
From: Lluís Vilanova This library is needed when using 'ust/tracepoint.h'. Signed-off-by: Harsh Prateek Bora Signed-off-by: Lluís Vilanova Signed-off-by: Stefan Hajnoczi --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index c0a542

Re: [Qemu-devel] [PATCH 0/6] fix w32 sockets

2012-04-03 Thread Paolo Bonzini
Il 20/03/2012 10:49, Paolo Bonzini ha scritto: > The w32 main loop has been mostly broken by the introduction of the > glib main loop. glib's g_poll does not use sockets on w32, so we > need a separate approach. > > Patch 1 is a simple cleanup that is needed later in the series. > > Patch 2 and

[Qemu-devel] [PATCH 4/8] block/curl: Replace usleep by g_usleep

2012-04-03 Thread Stefan Hajnoczi
From: Stefan Weil The function usleep is not available for all supported platforms: at least some versions of MinGW don't support it. usleep was also declared obsolete by POSIX.1-2001. The function g_usleep is part of glib2.0, so it is available for all supported platforms. Using nanosleep wou

[Qemu-devel] [PATCH 3/8] qtest: Add missing GCC_FMT_ATTR

2012-04-03 Thread Stefan Hajnoczi
From: Stefan Weil gcc reports an error when the code is compiled with -Wmissing-format-attribute. Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- qtest.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/qtest.c b/qtest.c index daeabb7..18afcd9 100644 --

[Qemu-devel] [PATCH 00/25] qdev properties final installment: push, push!

2012-04-03 Thread Paolo Bonzini
This is the final installment of the qdev property cleanup. It includes the following parts: * various bits of state are moved from DeviceState to Object: state (aka realized), reset, static properties, and the simple "type" property * bus properties are replaced with superclass properties

[Qemu-devel] [PATCH 04/25] qom: make Object a type

2012-04-03 Thread Paolo Bonzini
Right now the base Object class has a special NULL type. Change this so that we will be able to add class_init and class_base_init callbacks. To do this, remove some special casing of ObjectClass that is not really necessary. Signed-off-by: Paolo Bonzini --- include/qemu/object.h |2 +- qom

[Qemu-devel] [PATCH 06/25] qdev: fix -device foo,?

2012-04-03 Thread Paolo Bonzini
Since most property types do not have a parse property now, this was broken. Fix it by looking at the setter instead. Signed-off-by: Paolo Bonzini --- hw/qdev-monitor.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c index 4783366

[Qemu-devel] [PATCH 02/25] qom: add object_child_foreach

2012-04-03 Thread Paolo Bonzini
A utility function that will be used to implement hierarchical realization. Signed-off-by: Paolo Bonzini --- include/qemu/object.h | 14 +- qom/object.c | 17 + 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/include/qemu/object.h b/include

[Qemu-devel] [PATCH 19/25] qom: push state up to Object

2012-04-03 Thread Paolo Bonzini
qdev properties use the state member (an embryo of the "realized" property) in order to disable setting them after a device has been initialized. So, in order to push qdev properties up to Object we need to push this bit there too. Signed-off-by: Paolo Bonzini --- hw/qdev-addr.c|3 +

[Qemu-devel] [PATCH 17/25] qdev: remove PropertyInfo range checking

2012-04-03 Thread Paolo Bonzini
Range checking in PropertyInfo is now used only for pci_devfn properties. Move it there, and remove all code that implements it in the various property types. Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c | 102 -- hw/qdev.h|

Re: [Qemu-devel] [PATCH] block: bdrv_append() fixes

2012-04-03 Thread Kevin Wolf
Am 27.03.2012 22:30, schrieb Jeff Cody: > A few fixups for bdrv_append(): > > The new bs (bs_new) passed into bdrv_append() should be anonymous. Rather > than call bdrv_make_anon() to enforce this, use an assert to catch when a > caller > is passing in a bs_new that is not anonymous. > > Also,

[Qemu-devel] [PATCH 14/25] qapi: add Visitor interfaces for uint*_t and int*_t

2012-04-03 Thread Paolo Bonzini
From: Michael Roth This adds visitor interfaces for fixed-width integers types. Implementing these in visitors is optional, otherwise we fall back to visit_type_int() (int64_t) with some additional bounds checking to avoid integer overflows for cases where the value fetched exceeds the bounds of

[Qemu-devel] [PATCH 18/25] qdev: remove qdev_prop_exists

2012-04-03 Thread Paolo Bonzini
Can be replaced everywhere with object_property_find. Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c |5 - hw/qdev.c |2 +- hw/qdev.h |1 - hw/scsi-bus.c |2 +- include/qemu/object.h |9 + qom/object.c |2 +- 6

Re: [Qemu-devel] [PATCH 09/10] coroutine: schedule timeout coroutine instead process it directly

2012-04-03 Thread Paolo Bonzini
Il 03/04/2012 10:38, Lai Jiangshan ha scritto: > Avoid a timer callback spends too much time. > > Signed-off-by: Lai Jiangshan > --- > qemu-coroutine-sleep.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/qemu-coroutine-sleep.c b/qemu-coroutine-sleep.c > index fd

Re: [Qemu-devel] [PATCH 01/10] coroutine: use qemu_coroutine_switch() directly

2012-04-03 Thread Paolo Bonzini
Il 03/04/2012 10:38, Lai Jiangshan ha scritto: > When qemu_coroutine_switch() in the qemu_coroutine_yield() returns, > It must be someone calls qemu_coroutine_enter() for it, so the @to > is active, the tests in coroutine_swap() are unneeded, so we use > qemu_coroutine_switch() directly in qemu_cor

Re: [Qemu-devel] [PATCH 02/10] coroutine: rename unlock_bh_queue to co_runnable_queue

2012-04-03 Thread Paolo Bonzini
Il 03/04/2012 10:38, Lai Jiangshan ha scritto: > It stands for runnable Coroutines. > > Signed-off-by: Lai Jiangshan > --- > qemu-coroutine-lock.c | 18 +- > 1 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/qemu-coroutine-lock.c b/qemu-coroutine-lock.c > index

Re: [Qemu-devel] RE. [PATCH] sheepdog: fix send req helpers

2012-04-03 Thread Kevin Wolf
Am 03.04.2012 13:13, schrieb MORITA Kazutaka: > At Tue, 3 Apr 2012 18:04:21 +0800, > Liu Yuan wrote: >> >> From: Liu Yuan >> >> Yes, I think so. Here is the patch. >> >> Subject: [PATCH] sheepdog: fix send req helpers >> From: Liu Yuan >> >> We should return if reading of the header fails. >> >>

Re: [Qemu-devel] [PATCH 03/10] coroutine: rename qemu_co_queue_next_bh() to qemu_co_process_runnable()

2012-04-03 Thread Paolo Bonzini
Il 03/04/2012 10:38, Lai Jiangshan ha scritto: > Signed-off-by: Lai Jiangshan > --- > qemu-coroutine-lock.c |6 +++--- > trace-events |2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/qemu-coroutine-lock.c b/qemu-coroutine-lock.c > index 10e8dbb..90141cd

Re: [Qemu-devel] [PATCH 05/10] coroutine: add qemu_co_runnable_schedule()

2012-04-03 Thread Paolo Bonzini
Il 03/04/2012 10:38, Lai Jiangshan ha scritto: > split qemu_co_queue_next() as two parts: > the first part is dequeuing next from the wait queue. > the second part is schedule it to the runnable > queue(qemu_co_runnable_schedule()) > > Signed-off-by: Lai Jiangshan > --- > qemu-coroutine-lock.c

Re: [Qemu-devel] [PATCH 04/10] coroutine: init co_runnable_bh during boot

2012-04-03 Thread Paolo Bonzini
Il 03/04/2012 10:38, Lai Jiangshan ha scritto: > use __attribute__((constructor)) to do the initialization. > > Signed-off-by: Lai Jiangshan > --- > qemu-coroutine-lock.c |9 + > 1 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/qemu-coroutine-lock.c b/qemu-coroutine

Re: [Qemu-devel] [PATCH 06/10] coroutine: move runnale coroutine code to qemu-coroutine.c

2012-04-03 Thread Paolo Bonzini
Il 03/04/2012 10:38, Lai Jiangshan ha scritto: > runnable coroutine queue is the core mangement of the coroutine. > > Signed-off-by: Lai Jiangshan > --- > qemu-coroutine-lock.c | 27 --- > qemu-coroutine.c | 27 +++ > qemu-coroutine.h

Re: [Qemu-devel] [PATCH 07/10] coroutine: split qemu-coroutine-lock.c

2012-04-03 Thread Paolo Bonzini
Il 03/04/2012 10:38, Lai Jiangshan ha scritto: > queues are not just internal things for locks, split them. > > Signed-off-by: Lai Jiangshan > --- > Makefile.objs |2 +- > qemu-coroutine-lock.c | 49 +-- > qemu-coroutine-queue.c | 76 > +

Re: [Qemu-devel] [PATCH 10/10] coroutine: add qemu_coroutine_run() wrapper

2012-04-03 Thread Paolo Bonzini
Il 03/04/2012 10:38, Lai Jiangshan ha scritto: > Wrapper for qemu_coroutine_create()+qemu_coroutine_enter() > > Signed-off-by: Lai Jiangshan > --- > block.c | 28 +++- > hw/9pfs/virtio-9p.c |4 +--- > nbd.c |2 +- > qemu-coroutine.h

[Qemu-devel] [PATCH 03/25] qom: add class_base_init

2012-04-03 Thread Paolo Bonzini
The class_base_init TypeInfo callback was present in one of the early QOM versions but removed (on my request...) before committing. We will need it soon, add it. Signed-off-by: Paolo Bonzini --- include/qemu/object.h | 10 -- qom/object.c |9 + 2 files changed, 1

Re: [Qemu-devel] [PATCH 03/10] coroutine: rename qemu_co_queue_next_bh() to qemu_co_process_runnable()

2012-04-03 Thread Kevin Wolf
Am 03.04.2012 10:38, schrieb Lai Jiangshan: > Signed-off-by: Lai Jiangshan > --- > qemu-coroutine-lock.c |6 +++--- > trace-events |2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/qemu-coroutine-lock.c b/qemu-coroutine-lock.c > index 10e8dbb..90141cd 10

Re: [Qemu-devel] [PATCH 07/10] coroutine: split qemu-coroutine-lock.c

2012-04-03 Thread Kevin Wolf
Am 03.04.2012 10:38, schrieb Lai Jiangshan: > queues are not just internal things for locks, split them. > > Signed-off-by: Lai Jiangshan > --- > Makefile.objs |2 +- > qemu-coroutine-lock.c | 49 +-- > qemu-coroutine-queue.c | 76 >

[Qemu-devel] [PATCH 8/8] make: fix clean rule by removing build file in qom/

2012-04-03 Thread Stefan Hajnoczi
From: Anthony PERARD Make clean does not clean the 'qom' directory, leaving *.o and *.d files. This patch fixes this. Signed-off-by: Anthony PERARD Signed-off-by: Stefan Hajnoczi --- Makefile |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index 35

[Qemu-devel] [PATCH] Fix race resulting in loosing event bit in GPE.1.sts

2012-04-03 Thread Igor Mammedov
After receiving hotplug gpe event, guest masks event in GPE.1.en register, executes associated AML handler and then resets event bit in GPE.1.sts. If another pci device was hot-plugged after AML handler has been executed and before event bit is reset in GPE.1.sts, then guest will loose GPE event an

[Qemu-devel] [PATCH 01/25] qom: add object_class_get_parent

2012-04-03 Thread Paolo Bonzini
This simple bit of functionality was missing and we'll need it soon, so add it. Signed-off-by: Paolo Bonzini --- include/qemu/object.h | 14 ++ qom/object.c | 13 + 2 files changed, 27 insertions(+) diff --git a/include/qemu/object.h b/include/qemu/object.h

Re: [Qemu-devel] [PATCH v3] Replace bdrv_* to bdrv_aio_* functions in DMA mode in fdc.c.

2012-04-03 Thread Zhi Hui Li
I think what you say up is right, I will correct them, thank you very much! +bdrv_aio_readv(cur_drv->bs, fd_sector(cur_drv), +&fdctrl->qiov, fdc_sector_num, fdctrl_read_DMA_cb, opaque_cb); +return dma_len; Should be return 0 since we haven't completed I/O yet. Stefan I th

Re: [Qemu-devel] [PATCH] coroutine-gthread.c: Avoid threading APIs deprecated in GLib 2.31

2012-04-03 Thread Peter Maydell
Ping^2 ? On 14 March 2012 14:50, Peter Maydell wrote: > Ping? > > On 3 March 2012 14:52, Peter Maydell wrote: >> The GLib threading APIs were revamped in GLib 2.31 and a number >> of the old interfaces were deprecated, which means they provoke >> compilation warnings (errors if -Werror) now. Add

Re: [Qemu-devel] [PATCH v2] Replace bdrv_* to bdrv_aio_* functions in pio mode in fdc.c.

2012-04-03 Thread Zhi Hui Li
On 2012年04月02日 20:07, Stefan Hajnoczi wrote: On Sat, Mar 31, 2012 at 09:15:10PM +0800, Li Zhi Hui wrote: Replace bdrv_* to bdrv_aio_* functions in pio mode in fdc.c. Signed-off-by: Li Zhi Hui --- hw/fdc.c | 123 +- 1 files changed,

Re: [Qemu-devel] [PATCH] gdbstub: Synchronize CPU state unconditionally in gdb_set_cpu_pc

2012-04-03 Thread Peter Maydell
Ping? -- PMM On 12 March 2012 16:24, Peter Maydell wrote: > Synchronize the CPU state via cpu_sychronize_state() unconditionally > in gdb_set_cpu_pc() rather than only in some of the target ifdef > ladder cases. > > We can divide the CPUs into three categories: >  * non-KVM targets: no change of

[Qemu-devel] [PATCH 12/25] qdev: factor setting of global properties

2012-04-03 Thread Paolo Bonzini
Now that global properties do not depend on buses anymore, set them directly in the device instance_init function. Signed-off-by: Paolo Bonzini --- hw/qdev-monitor.c |1 - hw/qdev.c |2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/qdev-monitor.c b/hw/qdev-m

[Qemu-devel] [PATCH 09/25] qdev: move bus properties to a separate global

2012-04-03 Thread Paolo Bonzini
Simple code movement in order to simplify future refactoring. Signed-off-by: Paolo Bonzini --- hw/i2c.c | 10 ++ hw/ide/qdev.c | 10 ++ hw/intel-hda.c| 10 ++ hw/pci.c | 22 -

[Qemu-devel] [PATCH 05/25] qom: push type up to Object

2012-04-03 Thread Paolo Bonzini
Now that Object is a type, add an instance_init function and push the "type" property from qdev to there. Signed-off-by: Paolo Bonzini --- hw/qdev.c|6 -- qom/object.c | 11 +++ 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 0d3c

[Qemu-devel] [PATCH 20/25] qdev: generalize properties to Objects

2012-04-03 Thread Paolo Bonzini
The property machinery uses DeviceState arguments in a few places. Replace this with Object so that we can push properties up. Signed-off-by: Paolo Bonzini --- hw/qdev-addr.c | 19 +++--- hw/qdev-properties.c | 173 +- hw/qdev.c

Re: [Qemu-devel] [PATCH 23/25] qom: add realized property

2012-04-03 Thread Andreas Färber
Paolo, Am 03.04.2012 13:15, schrieb Paolo Bonzini: > Since we had to move the state field from DeviceState to Object, we cannot > delay the implementation of the "realized" property. The property is > a trigger for two actions that propagate through the composition tree. > "Realize" is called whe

[Qemu-devel] [PATCH 23/25] qom: add realized property

2012-04-03 Thread Paolo Bonzini
Since we had to move the state field from DeviceState to Object, we cannot delay the implementation of the "realized" property. The property is a trigger for two actions that propagate through the composition tree. "Realize" is called when the property becomes true, and propagates in pre-order; re

[Qemu-devel] [PATCH] usb-ehci: Ensure frindex writes leave a valid frindex value

2012-04-03 Thread Hans de Goede
frindex is a 14 bits counter, so bits 31-14 should always be 0, and after the commit titled "usb-ehci: frindex always is a 14 bits counter" we rely on frindex always being a multiple of 8. I've not seen this in practice, but theoretically a guest can write a value >= 0x4000 or a value which is not

[Qemu-devel] [PATCH 25/25] qdev: split part of device_finalize to device_unrealize

2012-04-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/qdev.c | 35 --- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index e674248..45f1133 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -601,27 +601,31 @@ static void device_initfn(Object *obj)

[Qemu-devel] [PATCH 24/25] qdev: implement qdev_init on top of realize

2012-04-03 Thread Paolo Bonzini
Switch the qdev_init function to simply set the "realized" property to true. The old contents of qdev_init become the realize and realize_children methods. Signed-off-by: Paolo Bonzini --- hw/qdev.c | 36 ++-- 1 file changed, 30 insertions(+), 6 deletions(-) d

[Qemu-devel] [PATCH 07/25] qdev: use object_property_print in info qtree

2012-04-03 Thread Paolo Bonzini
Otherwise, non-string properties without a legacy counterpart are missed. Also fix error propagation in object_property_print itself, otherwise pointer properties are printed as "". Signed-off-by: Paolo Bonzini --- hw/qdev-monitor.c |2 +- qom/object.c |2 +- 2 files changed, 2 inse

[Qemu-devel] [PATCH 21/25] qdev: move bulk of qdev-properties.c to qom/object.c

2012-04-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c | 476 - hw/qdev.c | 47 + hw/qdev.h | 87 - include/qemu/object.h | 98 ++ qom/object.c | 459 ++

  1   2   3   >