[Qemu-devel] [PATCH] monitor: fix client_migrate_info error handling

2012-03-18 Thread Yonit Halperin
Report QERR_INVALID_PARAMETER when port is missing. Otherwise QERR_UNDEFINED_ERROR will occur. rhbz #795652 Signed-off-by: Yonit Halperin --- monitor.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index d57e7bf..8f46031 100644 --- a/monitor.

[Qemu-devel] [PATCH] Makefile.target: code stp dependency on trace-events

2012-03-18 Thread Alon Levy
Signed-off-by: Alon Levy --- Makefile.target |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.target b/Makefile.target index eb25941..5c62edb 100644 --- a/Makefile.target +++ b/Makefile.target @@ -58,7 +58,7 @@ else TARGET_TYPE=system endif -$(QEMU_PROG).stp: +$

Re: [Qemu-devel] [PATCH 0/5] VMWare PVSCSI paravirtual device implementation

2012-03-18 Thread Gerhard Wiesinger
Hello Dmitry, Is PVSCSI also ready to boot through BIOS Int 13h? If not, do you plan a SEABIOS patch? Thnx. Ciao, Gerhard On 15.03.2012 10:02, Dmitry Fleytman wrote: Below is the implementation of VMWare PVSCSI device and command line parameters to configure vendor name and product name for S

Re: [Qemu-devel] [PATCH v4 0/9] VMXNET3 paravirtual NIC device implementation

2012-03-18 Thread Gerhard Wiesinger
Hello, I'm still having problems with v4 patch: ping works well, even with large packet sizes but ssh doesn't work at all. Tested with Knoppix 6.7 and Fedora 16. Thnx. Ciao, Gerhard On 15.03.2012 22:08, Dmitry Fleytman wrote: This set of patches implements VMWare VMXNET3 paravirtual NIC dev

Re: [Qemu-devel] [PATCH 5/5] PVSCSI paravirtualized device integration Bus type "pvscsi" added.

2012-03-18 Thread Dmitry Fleytman
Good point. Fixed. Thanks. On Thu, Mar 15, 2012 at 11:46 AM, Paolo Bonzini wrote: > Il 15/03/2012 10:02, Dmitry Fleytman ha scritto: >> Sample command line for pvscsi-based disk is: >>     -drive file=image.raw,if=none,cache=off,id=pvscsi1 \ >>     -device pvscsi,id=pvscsi -device scsi-disk,drive

Re: [Qemu-devel] [PATCH 1/5] Utility function strpadcpy() added

2012-03-18 Thread Dmitry Fleytman
Wow! Someone still remembers Pascal. It was a long time I didn't hear about it. I think I still have some code I wrote for old DOS TurboPascal with TurboVision, maybe I'll publish it somewhere :) Anyway, I believe that difference is rather minor, but let it be... My implementation replaced with yo

Re: [Qemu-devel] [PATCH 3/5] Header with various utility functions shared by VMWARE SCSI and network devices

2012-03-18 Thread Dmitry Fleytman
On Thu, Mar 15, 2012 at 11:56 AM, Paolo Bonzini wrote: > Il 15/03/2012 10:02, Dmitry Fleytman ha scritto: >> Signed-off-by: Dmitry Fleytman >> Signed-off-by: Yan Vugenfirer >> --- >>  hw/vmware_utils.h |  122 >> + >>  1 files changed, 122 inse

Re: [Qemu-devel] [PATCH 2/5] Vendor name and product name parameters for SCSI devices Options "vendor_name" and "product_name" added for SCSI disks.

2012-03-18 Thread Dmitry Fleytman
Unused stuff cleaned out. On Thu, Mar 15, 2012 at 11:55 AM, Paolo Bonzini wrote: > Il 15/03/2012 10:02, Dmitry Fleytman ha scritto: >> Sample command line is: >> >>     -drive file=image.raw,if=none,cache=off,id=scsi1 \ >>     -device lsi,id=scsi -device >> scsi-disk,drive=scsi1,bus=scsi.0,produ

Re: [Qemu-devel] [PATCH v4 9/9] VMXNET3 paravirtualized device integration. Interface type "vmxnet3" added.

2012-03-18 Thread Dmitry Fleytman
Fixed. On Fri, Mar 16, 2012 at 1:35 PM, Paolo Bonzini wrote: > Il 15/03/2012 22:09, Dmitry Fleytman ha scritto: >> Signed-off-by: Dmitry Fleytman >> Signed-off-by: Yan Vugenfirer >> --- >>  Makefile.objs           |    1 + >>  default-configs/pci.mak |    1 + >>  hw/pci.c                |    2

[Qemu-devel] [PATCH 0/5 V2] VMWare PVSCSI paravirtual device implementation

2012-03-18 Thread Dmitry Fleytman
Below is the implementation of VMWare PVSCSI device and command line parameters to configure vendor name and product name for SCSI storage are implemented. Latter is needed to make PVSCSI storage devices look exactly as on VMWare hypervisors. With this and VMWARE3 patches V2V migration problem for

[Qemu-devel] [PATCH 2/4 V2] Vendor name and product name parameters for SCSI devices Options "vendor_name" and "product_name" added for SCSI disks.

2012-03-18 Thread Dmitry Fleytman
Sample command line is: -drive file=image.raw,if=none,cache=off,id=scsi1 \ -device lsi,id=scsi -device scsi-disk,drive=scsi1,bus=scsi.0,product_name="VENDOR SCSI DISK",vendor_name="[VENDOR]" \ Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/scsi-disk.c | 32

[Qemu-devel] [PATCH 3/4 V2] Header with various utility functions shared by VMWARE SCSI and network devices

2012-03-18 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/vmware_utils.h | 126 + 1 files changed, 126 insertions(+), 0 deletions(-) create mode 100644 hw/vmware_utils.h diff --git a/hw/vmware_utils.h b/hw/vmware_utils.h new file m

[Qemu-devel] [PATCH 1/4 V2] Utility function strpadcpy() added

2012-03-18 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- cutils.c |7 +++ qemu-common.h |1 + 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/cutils.c b/cutils.c index af308cd..3ccf45c 100644 --- a/cutils.c +++ b/cutils.c @@ -27,6 +27,13 @@ #include "qe

[Qemu-devel] [PATCH 0/7 v5] VMXNET3 paravirtual NIC device implementation

2012-03-18 Thread Dmitry Fleytman
This set of patches implements VMWare VMXNET3 paravirtual NIC device. The device supports of all the device features including offload capabilties, VLANs and etc. The device is tested on different OSes: Fedora 15 Ubuntu 10.4 Centos 6.2 Windows 2008R2 Windows 2008 64bit Windo

[Qemu-devel] [PATCH 1/7 v5] Adding missing flag VIRTIO_NET_HDR_F_DATA_VALID from Linux kernel source tre Reformatting comments according to checkpatch.pl requirements

2012-03-18 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/virtio-net.h | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/hw/virtio-net.h b/hw/virtio-net.h index 4468741..fa3c17b 100644 --- a/hw/virtio-net.h +++ b/hw/virtio-net.h @@ -78,13 +78,14 @@ st

[Qemu-devel] [PATCH 2/7 v5] Adding utility function net_checksum_add_cont() that allows checksum calculation of scattered data with odd chunk sizes

2012-03-18 Thread Dmitry Fleytman
Adding utility function net_raw_checksum() that calculates checksum of buffer given Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- net/checksum.c | 13 +++-- net/checksum.h | 14 +- 2 files changed, 20 insertions(+), 7 deletions(-) diff --git a/net/che

[Qemu-devel] [PATCH 6/7 v5] Packet abstraction used by VMWARE network devices

2012-03-18 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/vmxnet_pkt.c | 1243 +++ hw/vmxnet_pkt.h | 479 + 2 files changed, 1722 insertions(+), 0 deletions(-) create mode 100644 hw/vmxnet_pkt.c create mode 1006

[Qemu-devel] [PATCH 4/7 v5] Header with various utility functions shared by VMWARE SCSI and network devices

2012-03-18 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/vmware_utils.h | 126 + 1 files changed, 126 insertions(+), 0 deletions(-) create mode 100644 hw/vmware_utils.h diff --git a/hw/vmware_utils.h b/hw/vmware_utils.h new file m

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Avi Kivity
On 03/18/2012 04:01 AM, Mark Cave-Ayland wrote: > Hi Avi/Blue, > > I've just updated to git master and found that SPARC64 is broken > again; a git bisect shows the following commit causes this: > > > commit f3705d53296d78b14f5823472ae2add16a25a0a5 > Author: Avi Kivity > Date: Thu Mar 8 16:16:34

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Blue Swirl
On Sun, Mar 18, 2012 at 09:44, Avi Kivity wrote: > On 03/18/2012 04:01 AM, Mark Cave-Ayland wrote: >> Hi Avi/Blue, >> >> I've just updated to git master and found that SPARC64 is broken >> again; a git bisect shows the following commit causes this: >> >> >> commit f3705d53296d78b14f5823472ae2add16

[Qemu-devel] [PATCH 5/7 v5] Various utility functions used by VMWARE network devices

2012-03-18 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/vmxnet_debug.h | 121 hw/vmxnet_utils.c | 165 +++ hw/vmxnet_utils.h | 320 + 3 files changed, 606 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH 3/7 v5] Adding utility function iov_net_csum_add() for iovec checksum calculation

2012-03-18 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- iov.c | 29 + iov.h |3 +++ 2 files changed, 32 insertions(+), 0 deletions(-) diff --git a/iov.c b/iov.c index 0f96493..5d4f94c 100644 --- a/iov.c +++ b/iov.c @@ -16,6 +16,7 @@ */ #include "i

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Blue Swirl
On Sun, Mar 18, 2012 at 09:44, Avi Kivity wrote: > On 03/18/2012 04:01 AM, Mark Cave-Ayland wrote: >> Hi Avi/Blue, >> >> I've just updated to git master and found that SPARC64 is broken >> again; a git bisect shows the following commit causes this: >> >> >> commit f3705d53296d78b14f5823472ae2add16

Re: [Qemu-devel] [PATCH 3/5] exec: fix code tlb entry misused as iotlb in get_page_addr_code()

2012-03-18 Thread Avi Kivity
On 03/15/2012 09:23 PM, jcmvbkbc wrote: > Hi. > >> get_page_addr_code() reads a code tlb entry, but interprets it as an >> iotlb entry. This works by accident since the low bits of a RAM code >> tlb entry are clear, and match a RAM iotlb entry. This accident is >> about to unhappen, so fix the co

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Mark Cave-Ayland
On 18/03/12 09:44, Avi Kivity wrote: Hi Avi/Blue, I've just updated to git master and found that SPARC64 is broken again; a git bisect shows the following commit causes this: commit f3705d53296d78b14f5823472ae2add16a25a0a5 Author: Avi Kivity Date: Thu Mar 8 16:16:34 2012 +0200 memory:

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Avi Kivity
On 03/18/2012 11:51 AM, Blue Swirl wrote: > On Sun, Mar 18, 2012 at 09:44, Avi Kivity wrote: > > On 03/18/2012 04:01 AM, Mark Cave-Ayland wrote: > >> Hi Avi/Blue, > >> > >> I've just updated to git master and found that SPARC64 is broken > >> again; a git bisect shows the following commit causes t

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Blue Swirl
On Sun, Mar 18, 2012 at 10:31, Avi Kivity wrote: > On 03/18/2012 11:51 AM, Blue Swirl wrote: >> On Sun, Mar 18, 2012 at 09:44, Avi Kivity wrote: >> > On 03/18/2012 04:01 AM, Mark Cave-Ayland wrote: >> >> Hi Avi/Blue, >> >> >> >> I've just updated to git master and found that SPARC64 is broken >>

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Mark Cave-Ayland
On 18/03/12 10:51, Blue Swirl wrote: (except Sparc32, Sparc64 and PPC displays are still not refreshed correctly). Details about this please. Screen is not updated correctly, there are lines from previous screenful. Pressing ctrl-alt-1 refreshes the display. Perhaps dirty tracking is broken?

Re: [Qemu-devel] [PATCH 3/5] exec: fix code tlb entry misused as iotlb in get_page_addr_code()

2012-03-18 Thread Max Filippov
ort with >> the message >> >>  qemu: fatal: Trying to execute code outside RAM or ROM at 0xd88c >> >> This happens immediately after a watchpoint setup for a data >> breakpoint at the same memory page where the currently >> executed code is located

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Blue Swirl
On Sun, Mar 18, 2012 at 11:03, Mark Cave-Ayland wrote: > On 18/03/12 10:51, Blue Swirl wrote: > (except Sparc32, Sparc64 and PPC displays are still not refreshed correctly). >>> >>> >>> Details about this please. >> >> >> Screen is not updated correctly, there are lines from previous >>

[Qemu-devel] [PATCH] sparc: pass page aligned addresses to tlb_set_page

2012-03-18 Thread Blue Swirl
Mask incoming page address early so that resolved addresses are page aligned. Remove further address masking. Signed-off-by: Blue Swirl --- target-sparc/mmu_helper.c | 19 --- 1 files changed, 8 insertions(+), 11 deletions(-) diff --git a/target-sparc/mmu_helper.c b/target-spa

[Qemu-devel] [PATCH 1/2] ioport: use INT64_MAX for IO ranges

2012-03-18 Thread Blue Swirl
Expression UINT64_MAX + 1 will make the range bigger than what can be represented with a 64 bit type. This would trigger an assert in int128_get64() after the next patch. Signed-off-by: Blue Swirl --- ioport.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ioport.c b/i

[Qemu-devel] [PATCH v2 2/2] memory: print aliased IO ranges in info mtree

2012-03-18 Thread Blue Swirl
Print also I/O ports behind bridges and other aliases. Signed-off-by: Blue Swirl --- memory.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/memory.c b/memory.c index 22b0352..a3f5b59 100644 --- a/memory.c +++ b/memory.c @@ -1621,6 +1621,13 @@ void mtree_in

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Avi Kivity
On 03/18/2012 12:51 PM, Blue Swirl wrote: > > > > IMO, my patch is better. tlb_set_page() should not deal with offsets > > within a page. > > It looks like all targets except Sparc32/64 mask the addresses before > passing to tlb_set_page(), so I agree. Ok. Commit my patch then? > > If you prefe

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Blue Swirl
On Sun, Mar 18, 2012 at 12:08, Avi Kivity wrote: > On 03/18/2012 12:51 PM, Blue Swirl wrote: >> > >> > IMO, my patch is better.  tlb_set_page() should not deal with offsets >> > within a page. >> >> It looks like all targets except Sparc32/64 mask the addresses before >> passing to tlb_set_page(),

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Avi Kivity
On 03/18/2012 02:10 PM, Blue Swirl wrote: > On Sun, Mar 18, 2012 at 12:08, Avi Kivity wrote: > > On 03/18/2012 12:51 PM, Blue Swirl wrote: > >> > > >> > IMO, my patch is better. tlb_set_page() should not deal with offsets > >> > within a page. > >> > >> It looks like all targets except Sparc32/64

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Blue Swirl
On Sun, Mar 18, 2012 at 12:13, Avi Kivity wrote: > On 03/18/2012 02:10 PM, Blue Swirl wrote: >> On Sun, Mar 18, 2012 at 12:08, Avi Kivity wrote: >> > On 03/18/2012 12:51 PM, Blue Swirl wrote: >> >> > >> >> > IMO, my patch is better.  tlb_set_page() should not deal with offsets >> >> > within a pa

Re: [Qemu-devel] [PATCH] virtio-spec: split virtio-net device status filed into ro and rw byte

2012-03-18 Thread Michael S. Tsirkin
On Fri, Mar 16, 2012 at 11:20:26PM +0800, Jason Wang wrote: > This patch splits the device status field of virtio-net into ro and rw > byte. This would simplify the implementation of both host and guest > and make the layout more clean. As VIRTIO_NET_S_ANNOUNCE is a rw bit, > it was moved to bit 8

Re: [Qemu-devel] [PATCH] Remove PCI class code from virtio balloon device

2012-03-18 Thread Michael S. Tsirkin
On Fri, Mar 16, 2012 at 12:03:08PM +1100, David Gibson wrote: > Currently the virtio balloon device, when using the virtio-pci interface > advertises itself with PCI class code MEMORY_RAM. This is wrong; the > balloon is vaguely related to memory, but is nothing like a PCI memory > device in the m

[Qemu-devel] [PATCH v4 0/3] qxl trace events

2012-03-18 Thread Alon Levy
Changes from v3: removed three trace-events that were unused (stap complains) added missing #include "trace.h" in spice-display.c tested with stap added reviewed-by from Stefan Hajnoczi (taking the liberty to assume the minor changes from v2 are ok) Changes from v2: spl

[Qemu-devel] [PATCH v4 3/3] qxl/qxl_render.c: add trace events

2012-03-18 Thread Alon Levy
Signed-off-by: Alon Levy Reviewed-by: Stefan Hajnoczi --- hw/qxl-render.c | 13 - trace-events|7 +++ 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/hw/qxl-render.c b/hw/qxl-render.c index 25857f6..28ab182 100644 --- a/hw/qxl-render.c +++ b/hw/qxl-rende

[Qemu-devel] [PATCH v4 1/3] qxl: init_pipe_signaling: exit on failure

2012-03-18 Thread Alon Levy
If pipe creation fails, exit, don't log and continue. Fix indentation at the same time. Signed-off-by: Alon Levy --- hw/qxl.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index e17b0e3..26ca893 100644 --- a/hw/qxl.c +++ b/hw/qx

[Qemu-devel] [PATCH v4 2/3] qxl: switch qxl.c to trace-events

2012-03-18 Thread Alon Levy
dprint is still used for qxl_init_common one time prints. also switched parts of spice-display.c over, mainly all the callbacks to spice server. All qxl device trace events start with the qxl device id. Signed-off-by: Alon Levy Reviewed-by: Stefan Hajnoczi --- hw/qxl.c | 141 ++

Re: [Qemu-devel] [PATCH 0/5] AREG0 patches v6

2012-03-18 Thread Blue Swirl
On Sun, Mar 11, 2012 at 22:23, Blue Swirl wrote: > In this version I rebased the series on REGPARM removal, without > splitting i386 and x86_64. > > I've also made some simple performance tests on i386. It looks like > REGPARM removal accounts for 2.5% performance loss and the full series > 7.5%,

[Qemu-devel] A second bug in the IO throttling code

2012-03-18 Thread Chris Webb
Whilst you have patches in progress for the queue draining issue with the IO throttling code which triggers the assert()s in the ide driver, I thought I should report a second bug I've seen. I'm not sure whether it's related, but none of the patch series posted so far appear to fix or affect it. I

[Qemu-devel] [PATCH] scripts: add gdb support script

2012-03-18 Thread Avi Kivity
Add a script that enhances gdb to be aware of QEMU data structures. This patch adds a single gdb command, 'qemu mtree'. The command is similar to the monitor's 'info mtree', except that it prints MemoryRegion addresses, and except for working from a core dump as well as a live instance. Signed-o

Re: [Qemu-devel] [PATCH v4 0/9] VMXNET3 paravirtual NIC device implementation

2012-03-18 Thread Dmitry Fleytman
Hello, Gerhard I've rechecked SSH connection both incoming and outgoing with patch v5. Everything works fine. If you still see problems, please, provide your exact configuration. Thanking you for your support, Dmitry Fleytman. On Sun, Mar 18, 2012 at 10:29 AM, Gerhard Wiesinger wrote: > Hello,

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Avi Kivity
On 03/18/2012 02:08 PM, Avi Kivity wrote: > > > > Screen is not updated correctly, there are lines from previous > > screenful. Pressing ctrl-alt-1 refreshes the display. Perhaps dirty > > tracking is broken? VGA in x86 works. > > Ok, I see it. Will investigate. > Turns out it's a latent bug in q

Re: [Qemu-devel] [PATCH v4 0/9] VMXNET3 paravirtual NIC device implementation

2012-03-18 Thread Gerhard Wiesinger
Hello, I'm still having problems with v4 patch: ping works well, even with large packet sizes but ssh doesn't work at all. Tested with Knoppix 6.7 and Fedora 16. Thnx. Ciao, Gerhard On 15.03.2012 22:08, Dmitry Fleytman wrote: This set of patches implements VMWare VMXNET3 paravirtual NIC dev

Re: [Qemu-devel] [PATCH 0/5] VMWare PVSCSI paravirtual device implementation

2012-03-18 Thread Gerhard Wiesinger
Hello Dmitry, Is PVSCSI also ready to boot through BIOS Int 13h? If not, do you plan a SEABIOS patch? Thnx. Ciao, Gerhard On 15.03.2012 10:02, Dmitry Fleytman wrote: Below is the implementation of VMWare PVSCSI device and command line parameters to configure vendor name and product name for S

Re: [Qemu-devel] [PATCH 0/5] VMWare PVSCSI paravirtual device implementation

2012-03-18 Thread Evgeny Budilovsky
Hi, Currently there is no support in seabios to boot pvscsi. What we did was a workaround. We've reverted the patch which removes extboot support [2a06024dc1b1e27b1be0266379af397e61b4a9ad] and used -drive ...boot=on --option-rom extboot.bin to boot the pvscsi disk. Best Regards, Evgeny On Sun, Ma

[Qemu-devel] Breakage

2012-03-18 Thread malc
97161e177b4ea2730dff13c4df01475762ab6048 broke booting of a DOS image i've been using for years, the VM stalls at "Booting from hard disk" BIOS message never making any progress. -- mailto:av1...@comtv.ru

Re: [Qemu-devel] Breakage

2012-03-18 Thread Avi Kivity
On 03/18/2012 06:12 PM, malc wrote: > 97161e177b4ea2730dff13c4df01475762ab6048 broke booting of a DOS image > i've been using for years, the VM stalls at "Booting from hard disk" > BIOS message never making any progress. Can you post an image that exhibits the problem? Also, try the attached patc

Re: [Qemu-devel] Breakage

2012-03-18 Thread malc
On Sun, 18 Mar 2012, Avi Kivity wrote: > On 03/18/2012 06:12 PM, malc wrote: > > 97161e177b4ea2730dff13c4df01475762ab6048 broke booting of a DOS image > > i've been using for years, the VM stalls at "Booting from hard disk" > > BIOS message never making any progress. > > Can you post an image tha

Re: [Qemu-devel] [PATCH 3/5] exec: fix code tlb entry misused as iotlb in get_page_addr_code()

2012-03-18 Thread Avi Kivity
M or ROM at 0xd88c > >> > >> This happens immediately after a watchpoint setup for a data > >> breakpoint at the same memory page where the currently > >> executed code is located. Any idea on how to fix it? > > > > Can you provide details on how to r

Re: [Qemu-devel] [PATCH 3/5] exec: fix code tlb entry misused as iotlb in get_page_addr_code()

2012-03-18 Thread Max Filippov
ge >> >> >> >>  qemu: fatal: Trying to execute code outside RAM or ROM at 0xd88c >> >> >> >> This happens immediately after a watchpoint setup for a data >> >> breakpoint at the same memory page where the currently >> >> executed code is located. Any idea on how to fix it? >> > >> > Can you provide details on how to reproduce this? >> >> It may be reproduced by running test_break.tst unit test: >> >> qemu-system-xtensa -M sim -cpu dc232b -nographic -semihosting  -kernel >> ./test_break.tst >> >> Compiled test binary is here: >> http://jcmvbkbc.spb.ru/~dumb/ws/osll/qemu-xtensa/20120318/test_break.tst >> > > Thanks.  Please try out the attached patch. Thanks, with this patch it works. -- Max

[Qemu-devel] [PATCH 0/2] acpi: robust notifications

2012-03-18 Thread Michael S. Tsirkin
acpi currently clears up/down registers on each hotplug request. This loses events if they are done quickly. It's easy to clear down on ej write. To detect that guest was notified of device addition, we track configuration accesses since system reset. Michael S. Tsirkin (2): pci: track function

[Qemu-devel] [PATCH 1/2] pci: track function accesses

2012-03-18 Thread Michael S. Tsirkin
Set a flag when function is first accessed after system reset. Signed-off-by: Michael S. Tsirkin --- hw/pci.c | 26 ++ hw/pci.h |3 +++ hw/pci_host.c |2 ++ 3 files changed, 31 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index b706e

[Qemu-devel] [PATCH 2/2] acpi: don't clear up/down on each host change

2012-03-18 Thread Michael S. Tsirkin
Instead of clearing up slot on each change, we clear: - up: when slot is accessed - down: when device is ejected Signed-off-by: Michael S. Tsirkin --- hw/acpi_piix4.c | 32 +++- 1 files changed, 27 insertions(+), 5 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acp

[Qemu-devel] [PATCH] fix multiboot loading if load_end_addr == 0 (fwd)

2012-03-18 Thread Scott Moser
Re-sending to qemu-devel. I'd originally sent this to kvm mailing list. -- Forwarded message -- Date: Sat, 17 Mar 2012 00:08:06 From: Scott Moser To: k...@vger.kernel.org Subject: [PATCH] fix multiboot loading if load_end_addr == 0 The previous code did not treat the case where

[Qemu-devel] [PATCH v3 0/5] screendump qapi convertion

2012-03-18 Thread Alon Levy
v3 changes: (Requested by Luiz Capitulino) rename helper to qemu_fopen_err don't touch unrelated subsystems move helper to osdep - I couldn't do it that way without dragging a lot of dependencies into libcacard which uses osdep-obj-y, so I split it so that there is now a osdep-no-qerror-obj-y

[Qemu-devel] [PATCH v3 2/5] add qemu_fopen_err

2012-03-18 Thread Alon Levy
This adds a helper to conveniently set the correct error based on the errno after a failed fopen. The added function is placed in it's own c file to allow libcacard to not develop dependencies on everything that qerror will bring in, which includes monitor and half of qemu. I tried to make it as l

[Qemu-devel] [PATCH v3 3/5] vga_hw_screen_dump: add Error** param

2012-03-18 Thread Alon Levy
To later use for qapi implementation of screendump. Signed-off-by: Alon Levy --- console.c |5 +++-- console.h |6 -- hw/blizzard.c |3 ++- hw/g364fb.c |4 +++- hw/omap_lcdc.c |4 +++- hw/qxl.c|6 -- hw/tcx.c| 13 +

[Qemu-devel] [PATCH v3 4/5] qapi: convert screendump

2012-03-18 Thread Alon Levy
The documenting comment contains the long list of possible errors from qemu_fopen_err, this could probably be put somewhere else in the file once more of the api uses those common error classes. Signed-off-by: Alon Levy --- hmp-commands.hx |3 +-- hmp.c|8 hmp.h

[Qemu-devel] [PATCH v3 5/5] vga: ppm_save(): Return error on failure

2012-03-18 Thread Alon Levy
From: Luiz Capitulino This makes all devices using ppm_save() return an error appropriately when the screendump command fails. Based on a code by Anthony Liguori. Signed-off-by: Luiz Capitulino Signed-off-by: Alon Levy --- hw/blizzard.c |2 +- hw/qxl.c|2 +- hw/vga.c

[Qemu-devel] [PATCH v3 1/5] qerror: add error codes for fopen failure

2012-03-18 Thread Alon Levy
Added: QERR_EINTR QERR_EACCES QERR_EEXIST QERR_OPEN_FILE_EMFILE QERR_ENOSPC QERR_EPERM QERR_READ_ONLY QERR_ENOTDIR QERR_EFBIG Signed-off-by: Alon Levy --- qerror.c | 36 qerror.h | 27 +++ 2 files changed, 63 insertions(+) diff -

[Qemu-devel] qemu-ppc during my vacation

2012-03-18 Thread Alexander Graf
Howdy, it's that time of the year again - I'm off for 3 weeks vacation :). In order for things not to go more chaotic than they already are while I'm off, I asked Andreas to jump in for the QEMU PPC tree maintenance and he fortunately accepted! So during the next 3 weeks, Andreas Färber will b

[Qemu-devel] [PATCH 3/3] target-sparc: Add compiler attribute to some functions which don't return

2012-03-18 Thread Stefan Weil
helper_raise_exception does not return, nor does do_unaligned_access. Cc: Blue Swirl Signed-off-by: Stefan Weil --- target-sparc/cpu.h|5 +++-- target-sparc/helper.h |2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/target-sparc/cpu.h b/target-sparc/cpu.h index 1

[Qemu-devel] [PATCH 1/3] Add support for target helper functions which don't return

2012-03-18 Thread Stefan Weil
Most functions which handle exceptions don't return. With a compiler attribute (added by QEMU_NORETURN), gcc can optimize the code. Signed-off-by: Stefan Weil --- def-helper.h |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/def-helper.h b/def-helper.h index 0e70c3

[Qemu-devel] [PATCH 2/3] target-mips: Add compiler attribute to some functions which don't return

2012-03-18 Thread Stefan Weil
helper_raise_exception_err does not return, nor do helper_raise_exception and do_unaligned_access. Cc: Aurelien Jarno Signed-off-by: Stefan Weil --- target-mips/helper.h|4 ++-- target-mips/op_helper.c |3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/target-mip

[Qemu-devel] [Bug 957622] Re: kvm -kernel with grub multiboot kernel dumps core or exits

2012-03-18 Thread Scott Moser
Forwarded to qemu-devel mailing list at http://www.mail-archive.com /qemu-devel@nongnu.org/msg103059.html . -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/957622 Title: kvm -kernel with grub multibo

[Qemu-devel] [Bug 957622] Re: kvm -kernel with grub multiboot kernel dumps core or exits

2012-03-18 Thread Scott Moser
** Patch added: "suggested debdiff" https://bugs.launchpad.net/qemu/+bug/957622/+attachment/2894794/+files/lp957622.debdiff -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/957622 Title: kvm -kern

[Qemu-devel] [PATCH] PNG screendump output alternative

2012-03-18 Thread Rafael
Hi, I had already started to work on supporting PNG dump output on screendump when got to know there was another effort to do the same (see Add PNG screendump thread from Daniel P. Berrange). Anyway, I'd like to share my implementation which is a little bit different. It does not use any reso

Re: [Qemu-devel] Boot failure with MS-Dos 6.22 (due to bad BIOS build?)

2012-03-18 Thread Kevin O'Connor
On Mon, Feb 27, 2012 at 04:25:09PM +0100, Jan Kiszka wrote: > On 2012-02-27 10:51, Daniel P. Berrange wrote: > > I'm seeing current QEMU GIT fail to boot MS-Dos 6.22 with the following > > crash: > > > > # qemu-system-x86_64 -fda ~/MS-DOS\ 6.22.img -m 1 -curses > > iPXE v1.0.0-591-g7aee315 > >

Re: [Qemu-devel] [RFC][PATCH 08/14 v9] target-i386: Add API to write cpu status to core file

2012-03-18 Thread HATAYAMA Daisuke
From: Wen Congyang Subject: Re: [RFC][PATCH 08/14 v9] target-i386: Add API to write cpu status to core file Date: Fri, 16 Mar 2012 14:50:06 +0800 > At 03/16/2012 09:48 AM, HATAYAMA Daisuke Wrote: >> From: Wen Congyang >> Subject: [RFC][PATCH 08/14 v9] target-i386: Add API to write cpu status to

Re: [Qemu-devel] [PATCH] Remove PCI class code from virtio balloon device

2012-03-18 Thread David Gibson
On Sun, Mar 18, 2012 at 02:38:42PM +0200, Michael S. Tsirkin wrote: > On Fri, Mar 16, 2012 at 12:03:08PM +1100, David Gibson wrote: > > Currently the virtio balloon device, when using the virtio-pci interface > > advertises itself with PCI class code MEMORY_RAM. This is wrong; the > > balloon is v

Re: [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory

2012-03-18 Thread Wen Congyang
At 03/15/2012 01:18 AM, Luiz Capitulino Wrote: > On Wed, 14 Mar 2012 10:11:35 +0800 > Wen Congyang wrote: > >> The command's usage: >>dump [-p] file >> file should be start with "file:"(the file's path) or "fd:"(the fd's name). >> >> Note: >> 1. If you want to use gdb to analyse the core, p

Re: [Qemu-devel] [PATCH] virtio-spec: split virtio-net device status filed into ro and rw byte

2012-03-18 Thread Jason Wang
On 03/18/2012 08:22 PM, Michael S. Tsirkin wrote: On Fri, Mar 16, 2012 at 11:20:26PM +0800, Jason Wang wrote: This patch splits the device status field of virtio-net into ro and rw byte. This would simplify the implementation of both host and guest and make the layout more clean. As VIRTIO_NET_S

Re: [Qemu-devel] [V5 PATCH 1/4] net: announce self after vm start

2012-03-18 Thread Jason Wang
On 03/17/2012 12:31 AM, Paolo Bonzini wrote: Il 16/03/2012 16:23, Jason Wang ha scritto: Or just a global need_announce instead of looking at the runstate. Paolo Then I think it's better for us introduce a parameter for vm_start() like what we've done in V4. But that didn't work because you

Re: [Qemu-devel] [RESEND PATCH] ioapic: fix build with DEBUG_IOAPIC

2012-03-18 Thread Jason Wang
On 03/16/2012 06:32 PM, Andreas Färber wrote: Am 16.03.2012 10:10, schrieb Jason Wang: ioapic.c:198: error: format ‘%08x’ expects type ‘unsigned int’, but argument 3 has type ‘uint64_t’ Signed-off-by: Jason Wang PRIx64 is indeed needed here. However, this drops the 08 without mention in the c

[Qemu-devel] [REPOST PATCH] ioapic: fix build with DEBUG_IOAPIC

2012-03-18 Thread Jason Wang
ioapic.c:198: error: format ‘%08x’ expects type ‘unsigned int’, but argument 3 has type ‘uint64_t’ Signed-off-by: Jason Wang --- hw/ioapic.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/ioapic.c b/hw/ioapic.c index 3fee011..e2e4796 100644 --- a/hw/ioapic.c +++ b/

[Qemu-devel] [Bug 957622] Re: kvm -kernel with grub multiboot kernel dumps core or exits

2012-03-18 Thread Ubuntu Foundation's Bug Bot
** Tags added: patch -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/957622 Title: kvm -kernel with grub multiboot kernel dumps core or exits Status in QEMU: Confirmed Status in “qemu-kvm” package

[Qemu-devel] [Bug 957622] Re: kvm -kernel with grub multiboot kernel dumps core or exits

2012-03-18 Thread Serge Hallyn
Thanks, Scott. I"ll wait a day or two to see if there are any upstream comments, then apply. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/957622 Title: kvm -kernel with grub multiboot kernel dump

Re: [Qemu-devel] Breakage

2012-03-18 Thread Roy Tam
2012/3/19 Avi Kivity : > On 03/18/2012 06:12 PM, malc wrote: >> 97161e177b4ea2730dff13c4df01475762ab6048 broke booting of a DOS image >> i've been using for years, the VM stalls at "Booting from hard disk" >> BIOS message never making any progress. > > Can you post an image that exhibits the proble

Re: [Qemu-devel] [PATCH 5/5] memory: get rid of cpu_register_io_memory()

2012-03-18 Thread TeLeMan
On Fri, Mar 9, 2012 at 01:20, Avi Kivity wrote: > The return value of cpu_register_io_memory() is no longer used anywhere, so > we can remove it and all associated data and code. > > Signed-off-by: Avi Kivity > --- >  cpu-all.h       |    8 --- >  exec-all.h      |    1 - >  exec-obsolete.h |

[Qemu-devel] [PATCH] kvm: Fix dirty tracking with large kernel page size

2012-03-18 Thread David Gibson
If the kernel page size is larger than TARGET_PAGE_SIZE, which happens for example on ppc64 with kernels compiled for 64K pages, the dirty tracking doesn't work. Cc: Avi Kivity Cc: Marcelo Tossatti Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson --- kvm-all.c |8 +--

[Qemu-devel] [PATCH] pci: Factor out bounds checking on config space accesses

2012-03-18 Thread David Gibson
There are several paths into the code to emulate PCI config space accesses: one for MMIO to a plain old PCI bridge one for MMIO to a PCIe bridge and one for the pseries machine which provides para-virtualized access to PCI config space. Each of these functions does their own bounds checking agains

[Qemu-devel] [PATCH] Remove PCI class code from virtio balloon device

2012-03-18 Thread David Gibson
Currently the virtio balloon device, when using the virtio-pci interface advertises itself with PCI class code MEMORY_RAM. This is wrong; the balloon is vaguely related to memory, but is nothing like a PCI memory device in the meaning of the class code, and this code is not required or suggested b

[Qemu-devel] [PATCH] .gitignore update

2012-03-18 Thread David Gibson
This adds a few previously missing generated files to .gitignore: the qemu-bridge-helper binary, and more generated versions of the linuxboot, multiboot and kvmvapic roms from pc-bios/optionrom. Signed-off-by: David Gibson --- .gitignore |6 ++ 1 files changed, 6 insertions(+), 0 deletio