Re: [Qemu-devel] [PATCH v2 3/3] block: enforce constraints on block size properties

2012-03-14 Thread Kevin Wolf
Am 14.03.2012 17:04, schrieb Paolo Bonzini: > Il 14/03/2012 16:57, Stefan Hajnoczi ha scritto: >> Nicolae Mogoreanu noticed that I/O requests can lead >> to QEMU crashes when the logical_block_size property is smaller than 512 >> bytes. >> >> Using the new "blocksize" property we can properly enfo

[Qemu-devel] [PATCH 10/12] target-sh4: Make update_itlb_use() take SuperHCPU

2012-03-14 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-sh4/helper.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target-sh4/helper.c b/target-sh4/helper.c index ffe79ec..c5c0593 100644 --- a/target-sh4/helper.c +++ b/target-sh4/helper.c @@ -202,7 +202,7 @@ void do_interrupt

[Qemu-devel] [PATCH 04/12] target-sh4: Make cpu_sh4_invalidate_tlb() take SuperHCPU

2012-03-14 Thread Andreas Färber
Change argument type from CPUSH4State to SuperHCPU. This simplifies the SH7750 SoC as its only caller. Signed-off-by: Andreas Färber --- hw/sh7750.c |2 +- target-sh4/cpu.h|4 +++- target-sh4/helper.c |8 3 files changed, 8 insertions(+), 6 deletions(-) diff --g

[Qemu-devel] [PATCH 03/12] hw/sh7750: Use SuperHCPU

2012-03-14 Thread Andreas Färber
In place of CPUSH4State use SuperHCPU for SH7750State::cpu field. Fix tab indentation on those lines and add braces. Signed-off-by: Andreas Färber --- hw/sh7750.c | 69 ++- 1 files changed, 35 insertions(+), 34 deletions(-) diff --git a

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 10:57:15AM -0500, Anthony Liguori wrote: > On 03/14/2012 10:54 AM, Gleb Natapov wrote: > >On Wed, Mar 14, 2012 at 10:42:50AM -0500, Anthony Liguori wrote: > >> > >>There's still a few places in QEMU that assume that > >>qemu_ram_get_ptr() returns a pointer that's good indefi

[Qemu-devel] [PATCH 05/12] target-sh4: Make increment_urc() take SuperHCPU

2012-03-14 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-sh4/helper.c | 23 --- 1 files changed, 12 insertions(+), 11 deletions(-) diff --git a/target-sh4/helper.c b/target-sh4/helper.c index 655faaa..2d5a4e4 100644 --- a/target-sh4/helper.c +++ b/target-sh4/helper.c @@ -269,17 +269,18 @@

[Qemu-devel] [PATCH 06/12] target-sh4: Make find_*tlb_entry() take SuperHCPU

2012-03-14 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-sh4/helper.c | 29 +++-- 1 files changed, 15 insertions(+), 14 deletions(-) diff --git a/target-sh4/helper.c b/target-sh4/helper.c index 2d5a4e4..d2186ed 100644 --- a/target-sh4/helper.c +++ b/target-sh4/helper.c @@ -243,15 +243,

[Qemu-devel] [PATCH 00/12] QOM'ify SuperH CPU and SH7750 SoC

2012-03-14 Thread Andreas Färber
Hello, Based on qom-cpu v4 and object_class_get_list() v2, this series converts the SuperH CPU to QOM. The SH7750 SoC code invited to do some cleanups, making use of the SuperHCPU, so I've QOM'ified the SoC and added the CPU as a link for now. I'm not so happy about the link construct, so it may

[Qemu-devel] [PATCH 11/12] target-sh4: Make itlb_replacement() use SuperHCPU

2012-03-14 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-sh4/helper.c | 18 +++--- 1 files changed, 11 insertions(+), 7 deletions(-) diff --git a/target-sh4/helper.c b/target-sh4/helper.c index c5c0593..c291eee 100644 --- a/target-sh4/helper.c +++ b/target-sh4/helper.c @@ -227,17 +227,21 @@ static

Re: [Qemu-devel] [PATCH] configure: change endian cross compilation test

2012-03-14 Thread Paul Brook
> From: Stuart Yoder > > Previous check in configure's endian test was to determine if > this is a cross-compile build by testing whether --cross-prefix > was used. This does not work for cross build environments > like Yocto that may set CC instead of --cross-prefix. > > Instead, test whether

[Qemu-devel] [PATCH v3 1/3] Add support for 64bit ARM system registers

2012-03-14 Thread Alexey Starikovskiy
Signed-off-by: Alexey Starikovskiy --- target-arm/cpu.h | 10 -- target-arm/helper.c | 14 +++--- target-arm/machine.c | 16 ++-- 3 files changed, 17 insertions(+), 23 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 0d9b39c..0298a98 1006

[Qemu-devel] [PATCH v3 2/3] Support for MRCC and MCRR instructions

2012-03-14 Thread Alexey Starikovskiy
Signed-off-by: Alexey Starikovskiy --- target-arm/helper.c| 28 target-arm/helper.h|2 ++ target-arm/translate.c | 47 +-- 3 files changed, 59 insertions(+), 18 deletions(-) diff --git a/target-arm/helper.c

[Qemu-devel] [PATCH v3 3/3] Minimal ARM LPAE support.

2012-03-14 Thread Alexey Starikovskiy
Sufficient to boot Linux kernel on vexpress-a15 Missing: * Extends the DBGDRAR and DBGDSAR to 64 bits, to hold PAs of up to 40 bits. * Defines two Memory Attribute Indirection Registers, MAIRn, to replace PRRR and NMRR when using the Long-descriptor translation table format. * Provides two IMPLEM

[Qemu-devel] [PATCH 07/12] target-sh4: Make cpu_sh4_{read, write}_mmaped_{i, u}tlb_addr() take CPU

2012-03-14 Thread Andreas Färber
Change argument type to SuperHCPU and update the SH7750 SoC. Signed-off-by: Andreas Färber --- hw/sh7750.c | 16 ++-- target-sh4/cpu.h| 16 ++-- target-sh4/helper.c | 63 ++- 3 files changed, 48 insertions(+), 47 d

[Qemu-devel] [PATCH] configure: change endian cross compilation test

2012-03-14 Thread Stuart Yoder
From: Stuart Yoder Previous check in configure's endian test was to determine if this is a cross-compile build by testing whether --cross-prefix was used. This does not work for cross build environments like Yocto that may set CC instead of --cross-prefix. Instead, test whether host compiler is

Re: [Qemu-devel] [PATCH v11 0/9] PC system flash support

2012-03-14 Thread Jordan Justen
On Tue, Mar 13, 2012 at 05:34, Paolo Bonzini wrote: > Il 22/02/2012 08:18, Jordan Justen ha scritto: >> Enable flash emulation in a PC system using pflash_cfi01. > > Jordan, can you document this on the wiki > (http://wiki.qemu.org/ChangeLog/1.1#x86)? I found > http://wiki.qemu.org/Features/PC_Sys

Re: [Qemu-devel] [PATCH v2 0/3] block: enforce constraints on block size properties

2012-03-14 Thread Stefan Hajnoczi
On Wed, Mar 14, 2012 at 3:57 PM, Stefan Hajnoczi wrote: > This series ensures we only accept valid block sizes.  Although in theory > block > sizes can vary a lot, the storage protocols (ATA, SCSI) as well as the QEMU > block layer implementation impose constraints.  Valid QEMU block sizes today

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] pseries: Configure PCI bridge using properties

2012-03-14 Thread Alexander Graf
On 13.03.2012, at 04:50, David Gibson wrote: > On Sat, Mar 10, 2012 at 11:40:41PM +0100, Alexander Graf wrote: >> >> On 08.03.2012, at 02:12, David Gibson wrote: >> >>> Currently, the function spapr_create_phb() uses its parameters to >>> initialize the correct memory windows for the new PCI Ho

Re: [Qemu-devel] [PATCH V2 2/5] hw/pxa2xx_dma.c: drop target_phys_addr_t usage in device state

2012-03-14 Thread Michael Roth
On Mon, Mar 05, 2012 at 12:30:42PM +0400, Igor Mitsyanko wrote: > Pxa2xx DMA controller is a 32-bit device and it has no knowledge of system's > physical address size, so it should not use target_phys_addr_t in it's state. > Convert variables descr, src and dest from type target_phys_addr_t to > u

Re: [Qemu-devel] [PATCH v3] w32: Support tests (make check)

2012-03-14 Thread Stefan Weil
Am 14.03.2012 14:39, schrieb Paolo Bonzini: Il 14/03/2012 10:10, Kevin Wolf ha scritto: I have no idea if there's any chance of qemu-iotests successfully on win32, but in order to make it actually run I think you would have to change the file names in tests/qemu-iotests-quick.sh as well. I thi

Re: [Qemu-devel] [PATCH] configure: change endian cross compilation test

2012-03-14 Thread Peter Maydell
2012/3/14 Paul Brook : >> From: Stuart Yoder >> >> Previous check in configure's endian test was to determine if >> this is a cross-compile build by testing whether --cross-prefix >> was used.  This does not work for cross build environments >> like Yocto that may set CC instead of --cross-prefix.

Re: [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory

2012-03-14 Thread Luiz Capitulino
On Wed, 14 Mar 2012 10:11:35 +0800 Wen Congyang wrote: > The command's usage: >dump [-p] file > file should be start with "file:"(the file's path) or "fd:"(the fd's name). > > Note: > 1. If you want to use gdb to analyse the core, please specify -p option. > 2. This command doesn't suppo

Re: [Qemu-devel] [RFC][PATCH 12/14 v9] support to cancel the current dumping

2012-03-14 Thread Luiz Capitulino
On Wed, 14 Mar 2012 10:12:05 +0800 Wen Congyang wrote: > Add API to allow the user to cancel the current dumping. It can only work > after > async dumping is supported. NACK, we shouldn't add it then. > > Signed-off-by: Wen Congyang > --- > dump.c | 12 > hmp-comman

Re: [Qemu-devel] [RFC][PATCH 13/14 v9] support to query dumping status

2012-03-14 Thread Luiz Capitulino
On Wed, 14 Mar 2012 10:13:15 +0800 Wen Congyang wrote: > Add API to allow the user to query dumping status. It can only work after > async dumping is supported. NACK, we shouldn't add it then. > > Signed-off-by: Wen Congyang > --- > dump.c | 32 >

Re: [Qemu-devel] [RFC][PATCH 14/14 v9] allow user to dump a fraction of the memory

2012-03-14 Thread Luiz Capitulino
On Wed, 14 Mar 2012 10:13:50 +0800 Wen Congyang wrote: > This API allows the user to limit how much memory to be dumped, > rather than forcing the user to dump all memory at once. > > Signed-off-by: Wen Congyang > --- > dump.c | 186 > +--

Re: [Qemu-devel] [RFC][PATCH 00/14 v9] introducing a new, dedicated memory dump mechanism

2012-03-14 Thread Luiz Capitulino
On Wed, 14 Mar 2012 10:03:15 +0800 Wen Congyang wrote: > Changes from v8 to v9: > 1. remove async support(it will be reimplemented after QAPI async commands > support >is finished) I gave my review on this one (concentrating on the QMP part only), and one important aspect of this command is

Re: [Qemu-devel] [PATCH 1/2] qapi: Convert screendump

2012-03-14 Thread Luiz Capitulino
On Wed, 14 Mar 2012 17:55:32 +0200 Alon Levy wrote: > From: Luiz Capitulino > > Also, makes it possible for devices to report errors in the > hw_screen_dump() callback. > > Signed-off-by: Luiz Capitulino Please, split this into two patches. The first one just adds the Error parameter to the

Re: [Qemu-devel] [RFC][PATCH 00/14 v9] introducing a new, dedicated memory dump mechanism

2012-03-14 Thread Eric Blake
On 03/14/2012 11:26 AM, Luiz Capitulino wrote: > On Wed, 14 Mar 2012 10:03:15 +0800 > Wen Congyang wrote: > >> Changes from v8 to v9: >> 1. remove async support(it will be reimplemented after QAPI async commands >> support >>is finished) > > I gave my review on this one (concentrating on th

Re: [Qemu-devel] [PATCH 2/2] vga: ppm_save(): Return error on failure

2012-03-14 Thread Luiz Capitulino
On Wed, 14 Mar 2012 17:55:33 +0200 Alon Levy wrote: > From: Luiz Capitulino > > This makes all devices using ppm_save() return an error appropriately > when the screendump command fails. > > Based on a code by Anthony Liguori. > > Signed-off-by: Luiz Capitulino > --- > hw/blizzard.c |

Re: [Qemu-devel] [RFC][PATCH 00/14 v9] introducing a new, dedicated memory dump mechanism

2012-03-14 Thread Anthony Liguori
On 03/14/2012 12:26 PM, Luiz Capitulino wrote: On Wed, 14 Mar 2012 10:03:15 +0800 Wen Congyang wrote: Changes from v8 to v9: 1. remove async support(it will be reimplemented after QAPI async commands support is finished) I gave my review on this one (concentrating on the QMP part only),

[Qemu-devel] [RFC 04/12] target-alpha: QOM'ify CPU

2012-03-14 Thread Andreas Färber
Embed CPUAlphaState in AlphaCPU. Signed-off-by: Andreas Färber --- Makefile.target |1 + target-alpha/cpu-qom.h | 74 +++ target-alpha/cpu.c | 127 ++ target-alpha/cpu.h |1 + target-alpha/trans

[Qemu-devel] [RFC 07/12] target-ppc: Prepare finalizer for PowerPCCPU

2012-03-14 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-ppc/cpu.h|1 + target-ppc/helper.c |1 - target-ppc/kvm.c|1 + target-ppc/translate_init.c |6 ++ 4 files changed, 8 insertions(+), 1 deletions(-) diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h index f

[Qemu-devel] [RFC 10/12] target-microblaze: QOM'ify CPU

2012-03-14 Thread Andreas Färber
There were no CPU models, so make TYPE_MICROBLAZE_CPU non-abstract. Signed-off-by: Andreas Färber --- Makefile.target |1 + target-microblaze/cpu-qom.h | 71 target-microblaze/cpu.c | 120 + target-micr

Re: [Qemu-devel] [RFC 04/12] target-alpha: QOM'ify CPU

2012-03-14 Thread Richard Henderson
On 03/14/12 10:53, Andreas Färber wrote: > Embed CPUAlphaState in AlphaCPU. > > Signed-off-by: Andreas Färber > --- > Makefile.target |1 + > target-alpha/cpu-qom.h | 74 +++ > target-alpha/cpu.c | 127 > +++

[Qemu-devel] [RFC 08/12] target-cris: QOM'ify CPU

2012-03-14 Thread Andreas Färber
Let cris_cpu_list() enumerate CPU classes sorted by version. Signed-off-by: Andreas Färber --- Makefile.target |1 + target-cris/cpu-qom.h | 73 target-cris/cpu.c | 144 +++ target-cris/cpu.h |2

Re: [Qemu-devel] [PATCH 2/2] vga: ppm_save(): Return error on failure

2012-03-14 Thread Alon Levy
On Wed, Mar 14, 2012 at 02:40:42PM -0300, Luiz Capitulino wrote: > On Wed, 14 Mar 2012 17:55:33 +0200 > Alon Levy wrote: > > > From: Luiz Capitulino > > > > This makes all devices using ppm_save() return an error appropriately > > when the screendump command fails. > > > > Based on a code by A

Re: [Qemu-devel] [RFC][PATCH 00/14 v9] introducing a new, dedicated memory dump mechanism

2012-03-14 Thread Luiz Capitulino
On Wed, 14 Mar 2012 12:49:59 -0500 Anthony Liguori wrote: > On 03/14/2012 12:26 PM, Luiz Capitulino wrote: > > On Wed, 14 Mar 2012 10:03:15 +0800 > > Wen Congyang wrote: > > > >> Changes from v8 to v9: > >> 1. remove async support(it will be reimplemented after QAPI async commands > >> support

Re: [Qemu-devel] [PATCH 1/2] qapi: Convert screendump

2012-03-14 Thread Alon Levy
On Wed, Mar 14, 2012 at 02:33:53PM -0300, Luiz Capitulino wrote: > On Wed, 14 Mar 2012 17:55:32 +0200 > Alon Levy wrote: > > > From: Luiz Capitulino > > > > Also, makes it possible for devices to report errors in the > > hw_screen_dump() callback. > > > > Signed-off-by: Luiz Capitulino > > P

[Qemu-devel] [RFC 01/12] target-s390x: QOM'ify CPU

2012-03-14 Thread Andreas Färber
S/390 ignored -cpu, so there's only one S390CPUClass for now. Let cpu_s390x_init() instantiate it. Embed CPUS390XState into S390CPU. Keep s390x_{tod,cpu}_timer() in helper.c but pass the S390CPU to them. Let cpu_state_reset() call cpu_reset(). Signed-off-by: Andreas Färber Cc: Ulrich Hecht ---

Re: [Qemu-devel] [PATCH v2] Man page: Add -global description

2012-03-14 Thread Markus Armbruster
Miroslav Rezanina writes: > There's only TODO information in qemu man page for -global option. This is a > basic description of this option with simple example. > > Signed-off-by: Miroslav Rezanina > > Patch: > -- > diff --git a/qemu-options.hx b/qemu-options.hx > index daefce3..876f929 100644

Re: [Qemu-devel] [PATCH] configure: change endian cross compilation test

2012-03-14 Thread Peter Maydell
[added qemu-devel back again] On 14 March 2012 17:51, Stuart Yoder wrote: > On Wed, Mar 14, 2012 at 12:17 PM, Peter Maydell > wrote: >> Agreed. I think looking at the host CPUs we support the only ones >> that aren't guaranteed either big or little endian are (a) mips >> and (b) ARM. ARM already

Re: [Qemu-devel] Virtio_PCI device driver code

2012-03-14 Thread Brian Jackson
On Wed, 14 Mar 2012 08:38:04 -0500, Abhinav Pundir wrote: Hello all I am very much new to the world of KVM and Qemu. I am trying to make a communication possible between the Guest and the Host. If you just need to communicate, why not just use virtio-serial functionality? I have st

Re: [Qemu-devel] [PATCH v2] Man page: Add -global description

2012-03-14 Thread Peter Maydell
On 14 March 2012 08:53, Miroslav Rezanina wrote: > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -292,9 +292,13 @@ DEF("global", HAS_ARG, QEMU_OPTION_global, >     "                set a global default for a driver property\n", >     QEMU_ARCH_ALL) >  STEXI > -@item -global > +@item -global @

Re: [Qemu-devel] [PATCH 00/12] QOM'ify SuperH CPU and SH7750 SoC

2012-03-14 Thread Andreas Färber
Am 14.03.2012 17:06, schrieb Peter Maydell: > On 14 March 2012 16:01, Andreas Färber wrote: >> Based on qom-cpu v4 and object_class_get_list() v2, this series converts >> the SuperH CPU to QOM. >> >> The SH7750 SoC code invited to do some cleanups, making use of the SuperHCPU, >> so I've QOM'ified

Re: [Qemu-devel] [PATCH 2/3] Disk serial number string copy function: change strncpy() to pstrcpy()

2012-03-14 Thread Markus Armbruster
Floris Bos writes: > Cc: kw...@redhat.com > Signed-off-by: Floris Bos > --- > blockdev.c|5 +++-- > hw/ide/core.c |2 +- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/blockdev.c b/blockdev.c > index d78aa51..e52449e 100644 > --- a/blockdev.c > +++ b/blockdev.c

[Qemu-devel] [PATCH important] spice: fix broken initialization

2012-03-14 Thread Alon Levy
Commit 1b71f7c14fab6f00c2680d4489fbee7baf796e4f moved MODULE_INIT_QOM to way before MODULE_INIT_MACHINE, thereby breaking assumptions made in spice-core.c which registered both a type initializer and a machine intializer. This fix removes the type registration, and replaces it with calling qemu_sp

[Qemu-devel] [RFC 03/12] target-m68k: QOM'ify CPU

2012-03-14 Thread Andreas Färber
Embed CPUM68KState in M68kCPU. Let cpu_state_reset() call cpu_reset(). Let m68k_cpu_list() enumerate CPU classes alphabetically, except for "any". Signed-off-by: Andreas Färber --- Makefile.target |1 + target-m68k/cpu-qom.h | 75 +++ target-m68k/cpu.c | 161

Re: [Qemu-devel] [PATCH RFC v4 14/44] target-arm: Don't overuse CPUState

2012-03-14 Thread Andreas Färber
Am 14.03.2012 15:39, schrieb Peter Maydell: > On 10 March 2012 02:27, Andreas Färber wrote: >> Scripted conversion: >> sed -i "s/CPUState/CPUARMState/g" target-arm/*.[hc] >> sed -i "s/#define CPUARMState/#define CPUState/" target-arm/cpu.h >> >> Signed-off-by: Andreas Färber > > Some of these

[Qemu-devel] [RFC 06/12] target-ppc: QOM'ify CPU

2012-03-14 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-ppc/cpu-qom.h| 84 ++ target-ppc/cpu.h| 25 + target-ppc/helper.c | 72 ++-- target-ppc/kvm.c| 29 +++-- target-ppc/kvm_ppc.h|6 - target-ppc/translate.c |2 +- ta

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Eric Northup
On Wed, Mar 14, 2012 at 6:25 AM, Gleb Natapov wrote: > On Wed, Mar 14, 2012 at 03:16:05PM +0200, Avi Kivity wrote: > > On 03/14/2012 03:14 PM, Gleb Natapov wrote: > > > On Wed, Mar 14, 2012 at 03:07:46PM +0200, Avi Kivity wrote: > > > > On 03/14/2012 01:11 PM, Wen Congyang wrote: > > > > > > > >

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Eric Northup
On Wed, Mar 14, 2012 at 6:25 AM, Gleb Natapov wrote: > On Wed, Mar 14, 2012 at 03:16:05PM +0200, Avi Kivity wrote: >> On 03/14/2012 03:14 PM, Gleb Natapov wrote: >> > On Wed, Mar 14, 2012 at 03:07:46PM +0200, Avi Kivity wrote: >> > > On 03/14/2012 01:11 PM, Wen Congyang wrote: >> > > > > >> > > >

[Qemu-devel] [PATCH 1/2] qemu-iotests: Fix call syntax for qemu-img

2012-03-14 Thread Stefan Weil
qemu-img requires first options, then file name, then size. GNU getopt also allows options at the end, but POSIX getopt doesn't. Try "export POSIXLY_CORRECT=y" to get the POSIX behaviour with GNU getopt, too. Cc: Kevin Wolf Signed-off-by: Stefan Weil --- tests/qemu-iotests/common.rc |9 +++

[Qemu-devel] [PATCH 2/2] qemu-iotests: Fix call syntax for qemu-io

2012-03-14 Thread Stefan Weil
qemu-io requires options first, then fixed parameters. GNU getopt also allows options at the end, but POSIX getopt doesn't. Try "export POSIXLY_CORRECT=y" to get the POSIX behaviour with GNU getopt, too. Cc: Kevin Wolf Signed-off-by: Stefan Weil --- tests/qemu-iotests/009 |4 ++-- tests/qe

Re: [Qemu-devel] [PATCH v2 1/3] Add support for 64bit ARM system registers

2012-03-14 Thread Michael Roth
On Wed, Mar 14, 2012 at 05:00:02PM +0400, Alexey Starikovskiy wrote: > Signed-off-by: Alexey Starikovskiy > --- > target-arm/cpu.h | 10 -- > target-arm/helper.c | 14 +++--- > target-arm/machine.c | 16 ++-- > 3 files changed, 17 insertions(+), 23 deletions(

Re: [Qemu-devel] [PATCH] configure: change endian cross compilation test

2012-03-14 Thread Stefan Weil
Am 14.03.2012 19:09, schrieb Peter Maydell: [added qemu-devel back again] On 14 March 2012 17:51, Stuart Yoder wrote: On Wed, Mar 14, 2012 at 12:17 PM, Peter Maydell wrote: Agreed. I think looking at the host CPUs we support the only ones that aren't guaranteed either big or little endian a

[Qemu-devel] [RFC 12/12] target-xtensa: QOM'ify CPU

2012-03-14 Thread Andreas Färber
Let xtensa_cpu_list() enumerate CPU classes alphabetically. Signed-off-by: Andreas Färber --- Makefile.target |1 + gdbstub.c| 19 +++-- hw/xtensa_pic.c | 51 target-xtensa/core-dc232b.c |5 +- target-xtensa/core-fsf.c |

Re: [Qemu-devel] [PATCH v2 1/3] Add support for 64bit ARM system registers

2012-03-14 Thread Michael Roth
On Wed, Mar 14, 2012 at 01:57:47PM -0500, Michael Roth wrote: > On Wed, Mar 14, 2012 at 05:00:02PM +0400, Alexey Starikovskiy wrote: > > Signed-off-by: Alexey Starikovskiy > > --- > > target-arm/cpu.h | 10 -- > > target-arm/helper.c | 14 +++--- > > target-arm/machine.c |

[Qemu-devel] [RFC 09/12] target-lm32: QOM'ify CPU

2012-03-14 Thread Andreas Färber
Let cpu_lm32_list() enumerate CPU classes sorted alphabetically. Signed-off-by: Andreas Färber --- Makefile.target |1 + target-lm32/cpu-qom.h | 77 target-lm32/cpu.c | 188 + target-lm32/cpu.h |1 + ta

Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: Fix call syntax for qemu-img

2012-03-14 Thread Eric Blake
On 03/14/2012 12:57 PM, Stefan Weil wrote: > qemu-img requires first options, then file name, then size. > > GNU getopt also allows options at the end, but POSIX getopt > doesn't. Try "export POSIXLY_CORRECT=y" to get the POSIX > behaviour with GNU getopt, too. That's a heavy sledgehammer, that h

Re: [Qemu-devel] [PATCH v2 1/3] Add support for 64bit ARM system registers

2012-03-14 Thread Alexey Starikovskiy
Do I need to do anything beside following or not? Thanks, Alex. On Wed, Mar 14, 2012 at 11:06 PM, Michael Roth wrote: >> > -#define CPU_SAVE_VERSION 6 >> > +#define CPU_SAVE_VERSION 7

[Qemu-devel] RF modules and microcontrollers

2012-03-14 Thread Charles Wilson - Wireless RF Systems
Hi, Which microcontrollers and do you work with? Thanks, Charles Wilson Wireless RF Systems 13715 Alton Pkwy. Irvine, CA 92618 Web: http://www.rfdigital.com Email: charles.wil...@wirelessrfsystems.com --- This email i

Re: [Qemu-devel] [PATCH v2] Man page: Add -global description

2012-03-14 Thread Anthony Liguori
On 03/14/2012 01:21 PM, Peter Maydell wrote: On 14 March 2012 08:53, Miroslav Rezanina wrote: --- a/qemu-options.hx +++ b/qemu-options.hx @@ -292,9 +292,13 @@ DEF("global", HAS_ARG, QEMU_OPTION_global, "set a global default for a driver property\n", QEMU_ARCH_ALL) ST

[Qemu-devel] [PATCH] PPC: Fix openpic with relative memregions

2012-03-14 Thread Alexander Graf
After commit 5312bd8b3152 we got memory region relative offsets into our mmio callbacks instead of page boundary based offsets. This broke the OpenPIC emulation which expected offsets to be on page boundary and substracted its region offset manually. This patch gets rid of that manual substractio

Re: [Qemu-devel] [PATCH RFC v4 44/44] qom: Introduce CPU class

2012-03-14 Thread Igor Mitsyanko
On 13.03.2012 3:13 PM, Andreas Färber wrote: In SysBusDeviceClass etc. we use the specific object type, too. Obviously my CPU is the first "new" QOM type, so we can go different ways if we want to. As long as it's a CPU-specific mechanism, using the specific type avoids some casts. It will be

Re: [Qemu-devel] [PATCH v2 1/3] Add support for 64bit ARM system registers

2012-03-14 Thread Michael Roth
On Wed, Mar 14, 2012 at 10:09:09PM +0300, Alexey Starikovskiy wrote: > Do I need to do anything beside following or not? Not sure, ARM folks? My suggestion would be to lose the the catch-all -EINVAL error we throw in machine.c:cpu_load() when version_id != CPU_SAVE_VERSION and only conditionally

[Qemu-devel] [Bug 948675] Re: QEMU is crashing when called with "-vga none"

2012-03-14 Thread Anthony Liguori
** Changed in: qemu Status: New => Incomplete ** Changed in: qemu Status: Incomplete => Confirmed ** Changed in: qemu Importance: Undecided => High -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launch

[Qemu-devel] [Bug 955379] [NEW] cmake hangs with qemu-arm-static

2012-03-14 Thread Tom Mullins
Public bug reported: I'm using git commit 3e7ecd976b06f... configured with --target-list=arm- linux-user --static in a chroot environment to compile some things. I ran into this problem with both pcl and opencv-2.3.1. cmake consistently freezes at some point during its execution, though in a diffe

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-14 Thread Blue Swirl
On Tue, Mar 13, 2012 at 01:01, Andreas Färber wrote: > Am 13.03.2012 01:16, schrieb Anthony Liguori: >> On 03/12/2012 06:32 PM, Andreas Färber wrote: >>> Take Blue's recent target-ppc fix >>> 9d4df9c02866f39d3eef105033091f367cc7c29e for example: After applying >>> patches on day one of FOSDEM he p

Re: [Qemu-devel] [PATCH RFC v4 44/44] qom: Introduce CPU class

2012-03-14 Thread Anthony Liguori
On 03/14/2012 03:37 PM, Igor Mitsyanko wrote: On 13.03.2012 3:13 PM, Andreas Färber wrote: In SysBusDeviceClass etc. we use the specific object type, too. Obviously my CPU is the first "new" QOM type, so we can go different ways if we want to. As long as it's a CPU-specific mechanism, using the

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-14 Thread Blue Swirl
On Tue, Mar 13, 2012 at 13:40, Avi Kivity wrote: > On 03/12/2012 10:27 PM, Anthony Liguori wrote: >>> I agree that more maintainers would be good, but we also need >>> more people with commit rights. >> >> I disagree strongly.  Having multiple pushers makes things difficult >> and encourages peopl

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-03-14 Thread Vasilis Liaskovitis
On Wed, Mar 14, 2012 at 05:23:24PM +0200, Gleb Natapov wrote: > On Wed, Mar 14, 2012 at 02:49:59PM +0100, Vasilis Liaskovitis wrote: > > Hi, > > > > > On a different note, are your going to continue working on your memory hot > plug series? > I am going to look at it now. The memory hotplug pat

[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2012-03-14 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu-kvm - 0.12.3+noroms-0ubuntu9.18 --- qemu-kvm (0.12.3+noroms-0ubuntu9.18) lucid-proposed; urgency=low [ Michael Tokarev ] * QEMUFileBuffered:-indicate-that-were-ready-when-the-underlying-file-is-ready.diff (patch from upstream to speed up

Re: [Qemu-devel] [PATCH RFC v4 44/44] qom: Introduce CPU class

2012-03-14 Thread Andreas Färber
Am 14.03.2012 20:48, schrieb Anthony Liguori: > On 03/14/2012 03:37 PM, Igor Mitsyanko wrote: >> On 13.03.2012 3:13 PM, Andreas Färber wrote: >> >>> In SysBusDeviceClass etc. we use the specific object type, too. >>> Obviously my CPU is the first "new" QOM type, so we can go different >>> ways if w

Re: [Qemu-devel] [Bug 948675] [NEW] QEMU is crashing when called with "-vga none"

2012-03-14 Thread Anthony Liguori
On 03/06/2012 10:22 PM, fidencio wrote: Public bug reported: QEMU is crashing when called with "-vga none". This regression was inserted in e5ad936b0fd7dfd7fd7908be6f9f1ca88f63b96b. QEMU line: /home/fidencio/dev/bin/qemu-system-x86_64 -enable-kvm -m 1024 -kernel /home/fidencio/src/linux-2.6/ar

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-14 Thread Blue Swirl
On Tue, Mar 13, 2012 at 14:41, Anthony Liguori wrote: > On 03/13/2012 09:38 AM, Avi Kivity wrote: >> >> On 03/13/2012 04:00 PM, Anthony Liguori wrote: >>> >>> On 03/13/2012 08:40 AM, Avi Kivity wrote: On 03/12/2012 10:27 PM, Anthony Liguori wrote: >> >> I agree that more maintain

Re: [Qemu-devel] [PATCH RFC v4 44/44] qom: Introduce CPU class

2012-03-14 Thread Anthony Liguori
On 03/14/2012 02:57 PM, Andreas Färber wrote: Am 14.03.2012 20:48, schrieb Anthony Liguori: On 03/14/2012 03:37 PM, Igor Mitsyanko wrote: On 13.03.2012 3:13 PM, Andreas Färber wrote: In SysBusDeviceClass etc. we use the specific object type, too. Obviously my CPU is the first "new" QOM type,

Re: [Qemu-devel] [PATCH 0/7] QOM'ify UniCore32 CPU

2012-03-14 Thread Blue Swirl
On Wed, Mar 14, 2012 at 01:39, Andreas Färber wrote: > Hello, > > Based on qom-cpu v4 and object_class_get_list() v2, this series converts > the UniCore32 CPU to QOM. Code-wise, target-unicore32 is pretty close to > target-arm and faces a similar issue of CPU-dependent init code, so let's > tackle

Re: [Qemu-devel] [PATCH 2/7] target-unicore32: Relicense to GPLv2+

2012-03-14 Thread Blue Swirl
On Wed, Mar 14, 2012 at 01:39, Andreas Färber wrote: > Adopt the license text suggested by Guan Xue-tao for all files except > helper.c, to which Anthony Liguori (IBM) contributed a g_malloc() call. > > Signed-off-by: Andreas Färber > Signed-off-by: Guan Xuetao > Signed-off-by: Stefan Weil > Si

Re: [Qemu-devel] [Bug 948675] [NEW] QEMU is crashing when called with "-vga none"

2012-03-14 Thread Fabiano Fidêncio
Anthony, See http://thread.gmane.org/gmane.comp.emulators.qemu/139580 This patch (from Avi) fix the problem, at least, in my case. On Wed, Mar 14, 2012 at 4:59 PM, Anthony Liguori wrote: > On 03/06/2012 10:22 PM, fidencio wrote: >> >> Public bug reported: >> >> QEMU is crashing when called with

[Qemu-devel] [Bug 918791] Re: qemu-kvm dies when using vmvga driver and unity in the guest

2012-03-14 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu-kvm - 1.0+noroms-0ubuntu7 --- qemu-kvm (1.0+noroms-0ubuntu7) precise; urgency=low [ Dave Walker ] * debian/patches/expose_vmx_qemu64cpu.patch: Expose VMX cpuid feature to the default "qemu64" CPU type, supporting Intel compatible VMX nest

Re: [Qemu-devel] [PATCH] kvmvapic: align start address as well as size

2012-03-14 Thread Anthony Liguori
On 03/06/2012 09:50 AM, Avi Kivity wrote: The kvmvapic code remaps a section of ROM as RAM to allow the guest to maintain state there. It is careful to align the section size to a page boundary, to avoid creating subpages, but neglects to do the same for the start address. These leads to an ass

Re: [Qemu-devel] [PATCH RFC v4 44/44] qom: Introduce CPU class

2012-03-14 Thread Andreas Färber
Am 14.03.2012 21:37, schrieb Igor Mitsyanko: > On 13.03.2012 3:13 PM, Andreas Färber wrote: > >> I never heard anyone wanting to generalize reset so far. I don't think >> it belongs into Object at least. Maybe DeviceState. Anthony? Paolo? >> > > We can have a special object for this, let's call i

Re: [Qemu-devel] [PATCH v2 1/3] Add support for 64bit ARM system registers

2012-03-14 Thread Peter Maydell
On 14 March 2012 19:38, Michael Roth wrote: > On Wed, Mar 14, 2012 at 10:09:09PM +0300, Alexey Starikovskiy wrote: >> Do I need to do anything beside following or not? > > Not sure, ARM folks? > > My suggestion would be to lose the the catch-all -EINVAL error we > throw in machine.c:cpu_load() whe

Re: [Qemu-devel] [PATCH RFC v4 44/44] qom: Introduce CPU class

2012-03-14 Thread Anthony Liguori
On 03/14/2012 03:37 PM, Andreas Färber wrote: Am 14.03.2012 21:37, schrieb Igor Mitsyanko: On 13.03.2012 3:13 PM, Andreas Färber wrote: I never heard anyone wanting to generalize reset so far. I don't think it belongs into Object at least. Maybe DeviceState. Anthony? Paolo? We can have a sp

Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: Fix call syntax for qemu-img

2012-03-14 Thread Stefan Weil
Am 14.03.2012 20:08, schrieb Eric Blake: On 03/14/2012 12:57 PM, Stefan Weil wrote: qemu-img requires first options, then file name, then size. GNU getopt also allows options at the end, but POSIX getopt doesn't. Try "export POSIXLY_CORRECT=y" to get the POSIX behaviour with GNU getopt, too.

Re: [Qemu-devel] [PATCH RFC v4 13/44] target-alpha: Don't overuse CPUState

2012-03-14 Thread Andreas Färber
Am 13.03.2012 19:10, schrieb Anthony Liguori: > On 03/09/2012 08:27 PM, Andreas Färber wrote: >> Scripted conversion: >>sed -i "s/CPUState/CPUAlphaState/g" target-alpha/*.[hc] >>sed -i "s/#define CPUAlphaState/#define CPUState/" target-alpha/cpu.h > > Acked-by: Anthony Liguori > > For 13

Re: [Qemu-devel] [PATCH RFC v4 13/44] target-alpha: Don't overuse CPUState

2012-03-14 Thread Peter Maydell
On 14 March 2012 20:50, Andreas Färber wrote: > Peter's Acked-by was added manually, so if re-running the script due to > conflicts it would need to be re-added. Or you could just drop it, I don't pay that much attention :-) -- PMM

[Qemu-devel] [PATCH][v2] configure: change endianness test

2012-03-14 Thread Stuart Yoder
From: Stuart Yoder Remove the runtime check for endianness, and for platforms that can be bit or little endian do a compile time check. This resolves an issue encountered building QEMU under Yocto which was not setting --cross-prefix. Signed-off-by: Stuart Yoder --- -v2: removed the dynamic r

Re: [Qemu-devel] [PATCH 2/7] target-unicore32: Relicense to GPLv2+

2012-03-14 Thread Stefan Weil
Am 14.03.2012 02:39, schrieb Andreas Färber: Adopt the license text suggested by Guan Xue-tao for all files except helper.c, to which Anthony Liguori (IBM) contributed a g_malloc() call. Signed-off-by: Andreas Färber Signed-off-by: Guan Xuetao Signed-off-by: Stefan Weil Signed-off-by: Blue Sw

Re: [Qemu-devel] [PATCH] kvmvapic: align start address as well as size

2012-03-14 Thread Anthony Liguori
On 03/06/2012 09:50 AM, Avi Kivity wrote: The kvmvapic code remaps a section of ROM as RAM to allow the guest to maintain state there. It is careful to align the section size to a page boundary, to avoid creating subpages, but neglects to do the same for the start address. These leads to an ass

Re: [Qemu-devel] [PATCH V2 0/2] QOM: small object creation fix

2012-03-14 Thread Anthony Liguori
On 02/28/2012 05:57 AM, Igor Mitsyanko wrote: Eliminate impossibility of creating objects of types with @instance_size == 0. Applied all. Thanks. Regards, Anthony Liguori v1->v2: type's instance size now initialized during type initialization. type_class_init() renamed (in additi

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_class_get_list()

2012-03-14 Thread Anthony Liguori
On 02/25/2012 04:07 PM, Andreas Färber wrote: This function allows to obtain a singly-linked list of classes, which can be sorted by the caller. Signed-off-by: Andreas Färber Cc: Anthony Liguori Applied. Thanks. Regards, Anthony Liguori --- v1 -> v2: * Instead of object_class_foreach

Re: [Qemu-devel] [PATCH 2/7] target-unicore32: Relicense to GPLv2+

2012-03-14 Thread Anthony Liguori
On 03/14/2012 04:09 PM, Stefan Weil wrote: Am 14.03.2012 02:39, schrieb Andreas Färber: Adopt the license text suggested by Guan Xue-tao for all files except helper.c, to which Anthony Liguori (IBM) contributed a g_malloc() call. Signed-off-by: Andreas Färber Signed-off-by: Guan Xuetao Signed

Re: [Qemu-devel] [PATCH][v2] configure: change endianness test

2012-03-14 Thread Stefan Weil
Am 14.03.2012 21:37, schrieb Stuart Yoder: From: Stuart Yoder Remove the runtime check for endianness, and for platforms that can be bit or little endian do a compile time check. This resolves an issue encountered building QEMU under Yocto which was not setting --cross-prefix. Signed-off-by:

Re: [Qemu-devel] [PATCH][v2] configure: change endianness test

2012-03-14 Thread Peter Maydell
On 14 March 2012 21:24, Stefan Weil wrote: > Contrary to Paul's argument QEMU does not only support a fixed > set of known host architectures, but also unknown hosts (via TCI). > For those, there remains a small chance that they are big endian > and that they get the wrong endianness now. TCI is s

Re: [Qemu-devel] [PATCH][v2] configure: change endianness test

2012-03-14 Thread Stefan Weil
Am 14.03.2012 22:37, schrieb Peter Maydell: On 14 March 2012 21:24, Stefan Weil wrote: Contrary to Paul's argument QEMU does not only support a fixed set of known host architectures, but also unknown hosts (via TCI). For those, there remains a small chance that they are big endian and that they

[Qemu-devel] [PULL] QOM CPUState v5

2012-03-14 Thread Andreas Färber
Hello Anthony, Please pull the second QOM CPU series, which frees the identifiers cpu_reset and CPUState and introduces TYPE_CPU. Cc: Anthony Liguori The following changes since commit 418ba9e5d6849ef2e8512d8853628ce4bf37937a: qom: Introduce object_class_get_list() (2012-03-14 15:30:39 -0500

[Qemu-devel] [PATCH v5 01/43] PPC: 405: Use proper CPU reset

2012-03-14 Thread Andreas Färber
From: Alexander Graf On ppc405ep there is a register that allows for software to reset the core, but not the whole system. Implement this reset using a reset interrupt. This gets rid of a bunch of #if 0'ed code. Reported-by: Andreas Färber Signed-off-by: Alexander Graf Signed-off-by: Andreas

[Qemu-devel] [PATCH v5 39/43] sh4 hw/: Don't use CPUState

2012-03-14 Thread Andreas Färber
Scripted conversion: for file in hw/sh.h hw/shix.c hw/r2d.c; do sed -i "s/CPUState/CPUSH4State/g" $file done Signed-off-by: Andreas Färber Acked-by: Anthony Liguori --- hw/r2d.c |6 +++--- hw/sh.h |2 +- hw/shix.c |2 +- 3 files changed, 5 insertions(+), 5 deletions(-) d

[Qemu-devel] [PATCH v5 38/43] s390x hw/: Don't use CPUState

2012-03-14 Thread Andreas Färber
Scripted conversion: for file in hw/s390-*.[hc]; do sed -i "s/CPUState/CPUS390XState/g" $file done Signed-off-by: Andreas Färber Acked-by: Anthony Liguori --- hw/s390-virtio-bus.c |6 +++--- hw/s390-virtio.c | 16 2 files changed, 11 insertions(+), 11 deletion

<    1   2   3   4   >