Re: [Qemu-devel] [SeaBIOS] [PATCH v2 1/6] output: add 64bit hex print support

2012-03-05 Thread Kevin O'Connor
On Wed, Feb 29, 2012 at 12:45:05PM +0100, Gerd Hoffmann wrote: > --- > src/output.c | 23 +-- > 1 files changed, 21 insertions(+), 2 deletions(-) Thanks Gerd. I think your patch missed a couple of corner cases. I played with it a bit and came up with the below. -Kevin >

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-03-05 Thread Peter Maydell
On 5 March 2012 15:21, Avi Kivity wrote: > On 03/05/2012 05:20 PM, Peter Maydell wrote: >> On 5 March 2012 15:10, Avi Kivity wrote: >> > I think 32-on-32 is quite rare these days, so it wouldn't be much >> > of a performance issue. >> >> 32-on-32 will be the standard case for KVM on ARM I think..

Re: [Qemu-devel] [PATCH] seabios: acpi: Add _STA for PCI hotplug slots

2012-03-05 Thread Alex Williamson
On Mon, 2012-03-05 at 07:15 +0200, Michael S. Tsirkin wrote: > On Sun, Mar 04, 2012 at 08:30:00PM -0700, Alex Williamson wrote: > > On Sun, 2012-03-04 at 20:53 +0200, Michael S. Tsirkin wrote: > > > On Fri, Feb 24, 2012 at 04:21:17PM -0700, Alex Williamson wrote: > > > > When a Status method is pro

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-03-05 Thread Andreas Färber
Am 05.03.2012 16:10, schrieb Avi Kivity: > On 03/05/2012 04:37 PM, Igor Mitsyanko wrote: >>> Well, can't you make sd.c target dependent? It's not so nice, but it >>> does solve the problem. >>> >> >> OK, but it will turn qemu from it's "long term path to suppress *all* >> target specific code" :)

Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-03-05 Thread Stefan Berger
Resending with people properly cc'ed. On 03/04/2012 05:59 PM, Michael S. Tsirkin wrote: On Fri, Mar 02, 2012 at 07:02:21AM -0500, Stefan Berger wrote: Having instrumented the code with qemu_mutex_trylock() and a counter for failed attempts with subsequent qemu_mutex_lock() practically shows no

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-03-05 Thread Avi Kivity
On 03/05/2012 05:43 PM, Andreas Färber wrote: > Am 05.03.2012 16:10, schrieb Avi Kivity: > > On 03/05/2012 04:37 PM, Igor Mitsyanko wrote: > >>> Well, can't you make sd.c target dependent? It's not so nice, but it > >>> does solve the problem. > >>> > >> > >> OK, but it will turn qemu from it's "l

Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-03-05 Thread Stefan Berger
On 03/04/2012 05:59 PM, Michael S. Tsirkin wrote: On Fri, Mar 02, 2012 at 07:02:21AM -0500, Stefan Berger wrote: Having instrumented the code with qemu_mutex_trylock() and a counter for failed attempts with subsequent qemu_mutex_lock() practically shows no lock contention at all for either polli

Re: [Qemu-devel] PPC: VGA broken in git master

2012-03-05 Thread Avi Kivity
On 03/05/2012 12:29 PM, Mark Cave-Ayland wrote: > On 05/03/12 09:51, Avi Kivity wrote: > >> On 03/04/2012 08:06 PM, Mark Cave-Ayland wrote: >>> Hi all, >>> >>> I've just done a git pull to update my local repository, and it now >>> appears that the VGA device is broken in QEMU - rather than display

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-03-05 Thread Peter Maydell
On 5 March 2012 15:43, Andreas Färber wrote: > Mid-term also depends on how me want to proceed with LPAE softmmu-wise > (bump "arm" to 64-bit target_phys_addr_t, or do LPAE and AArch64 in a > new "arm64"). For LPAE I would have thought we want to make "arm" go to a 64 bit target_phys_addr_t, sinc

[Qemu-devel] [PATCH 0/2] Unbreak aliases of I/O regions (and -vga std)

2012-03-05 Thread Avi Kivity
Aliases to memory regions in the I/O address space are broken; this affects -vga std. These two patches fix the problem. Also available in git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/urgent Avi Kivity (2): ioport: add destructor method to IORange memory: fix I/O port aliases

[Qemu-devel] [PATCH 1/2] ioport: add destructor method to IORange

2012-03-05 Thread Avi Kivity
Previously all callers had a containing object with a destructor that could be used to trigger cleanup of the IORange objects (typically just freeing the containing object), but a forthcoming memory API change doesn't fit this pattern. Rather than setting up a new global table, extend the ioport s

[Qemu-devel] [PATCH 2/2] memory: fix I/O port aliases

2012-03-05 Thread Avi Kivity
Commit e58ac72b6a0 ("ioport: change portio_list not to use memory_region_set_offset()") started using aliases of I/O memory regions. Since the IORange used for the I/O was contained in the target region, the alias information (specifically, the offset into the region) was lost. This broke -vga st

[Qemu-devel] [PATCH v3 0/3] screendump async command

2012-03-05 Thread Alon Levy
v2->v3: pass a closure to hw_screen_dump_async Alon Levy (3): monitor, console: add QEVENT_SCREEN_DUMP_COMPLETE console: add hw_screen_dump_async add qmp screendump-async QMP/qmp-events.txt | 15 +++ console.c| 66 -

[Qemu-devel] [PATCH v3 3/3] add qmp screendump-async

2012-03-05 Thread Alon Levy
Uses a new console.h function, vga_hw_screen_dump_async. vga_hw_screen_dump_async falls back to hw_vga_screen_dump if there is no hw_vga_screen_dump_async callback provided to graphic_console_init. This is the only case right now, but the up side is that the interface is already implemented. The

[Qemu-devel] [PATCH v3 2/3] console: add hw_screen_dump_async

2012-03-05 Thread Alon Levy
adds a handler for the following qmp screendump-async command. graphics_console_init signature change required touching every user, but no implementation of the new vga_hw_screen_dump_async_ptr is provided in this patch. Signed-off-by: Alon Levy --- console.c|4 console.h

Re: [Qemu-devel] virtio-blk performance regression and qemu-kvm

2012-03-05 Thread Martin Mailand
Am 10.02.2012 15:36, schrieb Dongsu Park: Recently I observed performance regression regarding virtio-blk, especially different IO bandwidths between qemu-kvm 0.14.1 and 1.0. So I want to share the benchmark results, and ask you what the reason would be. Hi, I think I found the problem, there

Re: [Qemu-devel] [RFC PATCH] fix select(2) race between main_loop_wait and qemu_aio_wait

2012-03-05 Thread Paolo Bonzini
Il 05/03/2012 16:14, Avi Kivity ha scritto: >> > Hmm, I don't think so. It would need to protect execution of the >> > iohandlers too, and pretty much everything can happen there including a >> > nested loop. Of course recursive mutexes exist, but it sounds like too >> > big an axe. > The I/O han

Re: [Qemu-devel] PPC: VGA broken in git master

2012-03-05 Thread Mark Cave-Ayland
On 05/03/12 15:48, Avi Kivity wrote: Can you provide the command line needed to reproduce the problem? Sure. I can reproduce it here using something as simple as: ./qemu-system-ppc -cdrom /dev/null -boot d -vnc :1 What you'll see is that the framebuffer remains black in your VNC client, as o

[Qemu-devel] [PATCH v3 1/3] monitor, console: add QEVENT_SCREEN_DUMP_COMPLETE

2012-03-05 Thread Alon Levy
Signed-off-by: Alon Levy --- QMP/qmp-events.txt | 15 +++ console.c | 11 +++ console.h |1 + monitor.c |2 ++ monitor.h |1 + 5 files changed, 30 insertions(+), 0 deletions(-) diff --git a/QMP/qmp-events.txt b/QMP/qmp-event

Re: [Qemu-devel] virtio-blk performance regression and qemu-kvm

2012-03-05 Thread Stefan Hajnoczi
On Mon, Mar 5, 2012 at 4:13 PM, Martin Mailand wrote: > Am 10.02.2012 15:36, schrieb Dongsu Park: > >> Recently I observed performance regression regarding virtio-blk, >> especially different IO bandwidths between qemu-kvm 0.14.1 and 1.0. >> So I want to share the benchmark results, and ask you wh

[Qemu-devel] [Bug 938937] Re: Slirp --> Abort when operate dhclient

2012-03-05 Thread ironstorm
I'm getting this too, wondering if its a duplicate of #824650? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/938937 Title: Slirp --> Abort when operate dhclient Status in QEMU: New Bug descript

Re: [Qemu-devel] [PATCH] Spelling fixes in comments (it's -> its)

2012-03-05 Thread Stefan Hajnoczi
On Sun, Feb 26, 2012 at 02:35:43PM +0100, Stefan Weil wrote: > * it's -> its (fixed for all files) > * dont -> don't (only fixed in a line which was touched by the previous fix) > > Signed-off-by: Stefan Weil > --- > configure |2 +- > hw/exynos4210_mct.c |2 +- > hw/us

Re: [Qemu-devel] [PATCH v3] libcacard: Spelling and grammar fixes in documentation

2012-03-05 Thread Stefan Hajnoczi
On Mon, Feb 27, 2012 at 10:57:24PM +0100, Stefan Weil wrote: > * it's -> its > > * it's -> it is (that's no fix, but makes future checks easier) > > * this functions -> this function > > * replacable -> replaceable > > * reader's -> readers > > * logins into -> logs into > > v2: > Also replac

Re: [Qemu-devel] virtio-blk performance regression and qemu-kvm

2012-03-05 Thread Martin Mailand
Am 05.03.2012 17:35, schrieb Stefan Hajnoczi: 1. Test on i7 Laptop with Cpu governor "ondemand". > > v0.14.1 > bw=63492KB/s iops=15873 > bw=63221KB/s iops=15805 > > v1.0 > bw=36696KB/s iops=9173 > bw=37404KB/s iops=9350 > > master > bw=36396KB/s iops=9099 > bw=34182KB/s iops=8545 > > Ch

Re: [Qemu-devel] [PATCH] usb: Fix signature of stub usb_host_device_open

2012-03-05 Thread Stefan Hajnoczi
On Thu, Mar 01, 2012 at 10:43:50AM +0100, Jan Kiszka wrote: > This was a breakage of 3741715cf2. > > Signed-off-by: Jan Kiszka > --- > usb-stub.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Even if a build fix is trivial, I suggest sending it only to qemu-devel@nongnu.org beca

[Qemu-devel] [Bug 947273] [NEW] launchpad homepage url is out of date

2012-03-05 Thread ironstorm
Public bug reported: The launchpad "homepage" link to QEMU's homepage is http://www.nongnu.org/qemu/, this link immediately redirects one to http://qemu.org (then wiki.qemu.org). The link should probably be updated to http://qemu.org ** Affects: qemu Importance: Undecided Status: N

Re: [Qemu-devel] [PATCH v1 1/1] ppc: Correctly define POWERPC_INSNS2_DEFAULT

2012-03-05 Thread Meador Inge
On 02/23/2012 07:44 AM, Meador Inge wrote: > 'POWERPC_INSNS2_DEFAULT' was defined incorrectly which was causing the > opcode table creation code to erroneously register 'eieio' and 'mbar' > for the "default" processor: > >** ERROR: opcode 1a already assigned in opcode table 16 >*** ERROR:

Re: [Qemu-devel] [Qemu-trivial] [PATCH] osdep: Remove local definition of macro offsetof

2012-03-05 Thread Stefan Hajnoczi
On Mon, Mar 05, 2012 at 07:22:31AM +0100, Stefan Weil wrote: > The macro offsetof is defined in stddef.h. It is conforming to > the standards C89, C99 and POSIX.1-2001 (see man page), so it > is a sufficiently old standard. > > Therefore chances are very high that QEMU never needs a local > defini

Re: [Qemu-devel] Live Block Migration using Mirroring

2012-03-05 Thread Marcelo Tosatti
On Wed, Feb 22, 2012 at 05:13:32PM +, Federico Simoncelli wrote: > Hi, > recently I've been working on live block migration combining the live > snapshots and the blkmirror patch sent by Marcelo Tosatti few months ago. > > The design is summarized at this url as "Mirrored-Snapshot": > > htt

[Qemu-devel] [Bug 938937] Re: Slirp --> Abort when operate dhclient

2012-03-05 Thread ironstorm
*** This bug is a duplicate of bug 824650 *** https://bugs.launchpad.net/bugs/824650 Having just rebuilt qemu from GIT and started using the rebuild binary, this problem no longer occurs... definitely related to or duplicate of 824650. ** This bug has been marked a duplicate of bug 824650

Re: [Qemu-devel] [PATCH v3 0/3] screendump async command

2012-03-05 Thread Anthony Liguori
On 03/05/2012 09:56 AM, Alon Levy wrote: v2->v3: pass a closure to hw_screen_dump_async Alon Levy (3): monitor, console: add QEVENT_SCREEN_DUMP_COMPLETE console: add hw_screen_dump_async add qmp screendump-async Reviewed-by: Anthony Liguori Regards, Anthony Liguori QMP/qmp-e

Re: [Qemu-devel] Live Block Migration using Mirroring

2012-03-05 Thread Eric Blake
On 03/05/2012 09:59 AM, Marcelo Tosatti wrote: > On Wed, Feb 22, 2012 at 05:13:32PM +, Federico Simoncelli wrote: >> Hi, >> recently I've been working on live block migration combining the live >> snapshots and the blkmirror patch sent by Marcelo Tosatti few months ago. >> >> The design is sum

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Avi Kivity
On 03/05/2012 04:33 PM, Anthony Liguori wrote: > > > async in QEMU doesn't mean "generate a QMP event when you're done". > It should mean execute this closure when you finish (function pointer > + opaque). > > The QMP event should be dispatched from the closure such that the > screendump code does

[Qemu-devel] [PATCH] spice: set spice uuid and name

2012-03-05 Thread Marc-André Lureau
This allows a Spice client to identify a VM --- ui/spice-core.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index c1091e1..80535b6 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -19,6 +19,7 @@ #include #include +#incl

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Anthony Liguori
On 03/05/2012 11:20 AM, Avi Kivity wrote: On 03/05/2012 04:33 PM, Anthony Liguori wrote: async in QEMU doesn't mean "generate a QMP event when you're done". It should mean execute this closure when you finish (function pointer + opaque). The QMP event should be dispatched from the closure suc

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-03-05 Thread Avi Kivity
On 03/05/2012 05:50 PM, Peter Maydell wrote: > On 5 March 2012 15:43, Andreas Färber wrote: > > Mid-term also depends on how me want to proceed with LPAE softmmu-wise > > (bump "arm" to 64-bit target_phys_addr_t, or do LPAE and AArch64 in a > > new "arm64"). > > For LPAE I would have thought we wa

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Avi Kivity
On 03/05/2012 07:27 PM, Anthony Liguori wrote: > On 03/05/2012 11:20 AM, Avi Kivity wrote: >> On 03/05/2012 04:33 PM, Anthony Liguori wrote: >>> >>> >>> async in QEMU doesn't mean "generate a QMP event when you're done". >>> It should mean execute this closure when you finish (function pointer >>>

Re: [Qemu-devel] [PATCH] osdep: Remove local definition of macro offsetof

2012-03-05 Thread Stefan Weil
Am 05.03.2012 14:49, schrieb Peter Maydell: On 5 March 2012 13:23, Andreas Färber wrote: Am 05.03.2012 07:22, schrieb Stefan Weil: The macro offsetof is defined in stddef.h. It is conforming to the standards C89, C99 and POSIX.1-2001 (see man page), so it is a sufficiently old standard. There

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Luiz Capitulino
On Mon, 05 Mar 2012 11:27:07 -0600 Anthony Liguori wrote: > On 03/05/2012 11:20 AM, Avi Kivity wrote: > > On 03/05/2012 04:33 PM, Anthony Liguori wrote: > >> > >> > >> async in QEMU doesn't mean "generate a QMP event when you're done". > >> It should mean execute this closure when you finish (fun

[Qemu-devel] [PATCH v3 0/8] Mirrored block writes

2012-03-05 Thread Paolo Bonzini
v3 comes with a new QMP command drive-mirror, an improved blockdev-snapshot-sync that just reuses transaction functionality, and a new image creation mode enum. I also tested that the command can be used to migrate without shared storage. Tested with the following scenarios: a) mirror only 1) c

[Qemu-devel] [PATCH v3 7/8] add mirroring to transaction

2012-03-05 Thread Paolo Bonzini
With it comes a new image creation mode, "no-backing-file", that can be used to stream an image so that the destination does not need the original image's backing file(s). Both bdrv_append and blkmirror will set the backing_hd on the target, even if the image is created without one, so that both s

[Qemu-devel] [PATCH v3 4/8] add mode field to blockdev-snapshot-sync transaction item

2012-03-05 Thread Paolo Bonzini
The mode field lets a management application create the snapshot destination outside QEMU. Right now, the only modes are "existing" and "absolute-paths". Mirroring introduces "no-backing-file". In the future "relative-paths" could be implemented too. Signed-off-by: Paolo Bonzini --- blockdev.

[Qemu-devel] [PATCH v3 8/8] add drive-mirror command and HMP equivalent

2012-03-05 Thread Paolo Bonzini
Since QMP transactions are supposed to take (pseudo) QMP commands, add a standalone drive-mirror command. The corresponding HMP command does not provide atomic snapshot+mirror, but it can still be used together with image streaming. Signed-off-by: Paolo Bonzini --- blockdev.c | 24 +

Re: [Qemu-devel] [RFC PATCH] fix select(2) race between main_loop_wait and qemu_aio_wait

2012-03-05 Thread Avi Kivity
On 03/05/2012 06:14 PM, Paolo Bonzini wrote: > Il 05/03/2012 16:14, Avi Kivity ha scritto: > >> > Hmm, I don't think so. It would need to protect execution of the > >> > iohandlers too, and pretty much everything can happen there including a > >> > nested loop. Of course recursive mutexes exist,

Re: [Qemu-devel] [RFC PATCH] fix select(2) race between main_loop_wait and qemu_aio_wait

2012-03-05 Thread Avi Kivity
On 03/05/2012 04:30 PM, Jan Kiszka wrote: > On 2012-03-05 15:24, Avi Kivity wrote: > >> Long-term, I'd like to cut out certain file descriptors from the main > >> loop and process them completely in separate threads (for separate > >> locking, prioritization etc.). Dunno how NBD works, but maybe it

[Qemu-devel] [PATCH 5/7] vdi: leave bounce buffering to block layer

2012-03-05 Thread Paolo Bonzini
vdi.c really works as if it implemented bdrv_read and bdrv_write. However, because only vector I/O is supported by the asynchronous callbacks, it went through extra pain to bounce-buffer the I/O. With the conversion to coroutines bdrv_read and bdrv_write are now asynchronous, so they can be handled

[Qemu-devel] [PATCH v3 3/8] rename blockdev-group-snapshot-sync

2012-03-05 Thread Paolo Bonzini
We will add other kinds of operation. Prepare for this by adjusting the schema. Signed-off-by: Paolo Bonzini --- blockdev.c | 78 - qapi-schema.json | 42 ++-- qmp-commands.hx | 52 +++--

Re: [Qemu-devel] Live Block Migration using Mirroring

2012-03-05 Thread Marcelo Tosatti
On Mon, Mar 05, 2012 at 10:20:36AM -0700, Eric Blake wrote: > On 03/05/2012 09:59 AM, Marcelo Tosatti wrote: > > On Wed, Feb 22, 2012 at 05:13:32PM +, Federico Simoncelli wrote: > >> Hi, > >> recently I've been working on live block migration combining the live > >> snapshots and the blkmirror

[Qemu-devel] [PATCH 3/7] vdi: merge aio_read_cb and aio_write_cb into callers

2012-03-05 Thread Paolo Bonzini
Now inline the former AIO callbacks into vdi_co_readv and vdi_co_writev. While many cleanups are possible, the code now really looks synchronous. Signed-off-by: Paolo Bonzini --- block/vdi.c | 40 1 files changed, 12 insertions(+), 28 deletions(-) diff

Re: [Qemu-devel] [RFC PATCH] fix select(2) race between main_loop_wait and qemu_aio_wait

2012-03-05 Thread Jan Kiszka
On 2012-03-05 18:39, Avi Kivity wrote: > On 03/05/2012 04:30 PM, Jan Kiszka wrote: >> On 2012-03-05 15:24, Avi Kivity wrote: Long-term, I'd like to cut out certain file descriptors from the main loop and process them completely in separate threads (for separate locking, prioritizatio

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Luiz Capitulino
On Mon, 05 Mar 2012 19:29:14 +0200 Avi Kivity wrote: > On 03/05/2012 07:27 PM, Anthony Liguori wrote: > > On 03/05/2012 11:20 AM, Avi Kivity wrote: > >> On 03/05/2012 04:33 PM, Anthony Liguori wrote: > >>> > >>> > >>> async in QEMU doesn't mean "generate a QMP event when you're done". > >>> It sh

Re: [Qemu-devel] [PATCH] spice: set spice uuid and name

2012-03-05 Thread Alon Levy
On Mon, Mar 05, 2012 at 06:22:26PM +0100, Marc-André Lureau wrote: > This allows a Spice client to identify a VM Reviewed-by: Alon Levy > --- > ui/spice-core.c |6 ++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/ui/spice-core.c b/ui/spice-core.c > index c1091e1..

Re: [Qemu-devel] Live Block Migration using Mirroring

2012-03-05 Thread Paolo Bonzini
Il 05/03/2012 18:44, Marcelo Tosatti ha scritto: > OK, can't it be fixed by image streaming on top of a blkmirror device? > This would avoid a duplicate interface (such as no need to snapshot_blkdev > to change to final copy). > > That is, start image streaming to a blkmirror device so that updat

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Alon Levy
On Mon, Mar 05, 2012 at 02:31:42PM -0300, Luiz Capitulino wrote: > On Mon, 05 Mar 2012 11:27:07 -0600 > Anthony Liguori wrote: > > > On 03/05/2012 11:20 AM, Avi Kivity wrote: > > > On 03/05/2012 04:33 PM, Anthony Liguori wrote: > > >> > > >> > > >> async in QEMU doesn't mean "generate a QMP event

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Anthony Liguori
On 03/05/2012 11:29 AM, Avi Kivity wrote: On 03/05/2012 07:27 PM, Anthony Liguori wrote: On 03/05/2012 11:20 AM, Avi Kivity wrote: On 03/05/2012 04:33 PM, Anthony Liguori wrote: async in QEMU doesn't mean "generate a QMP event when you're done". It should mean execute this closure when you f

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Avi Kivity
On 03/05/2012 08:09 PM, Alon Levy wrote: > On Mon, Mar 05, 2012 at 02:31:42PM -0300, Luiz Capitulino wrote: > > On Mon, 05 Mar 2012 11:27:07 -0600 > > Anthony Liguori wrote: > > > > > On 03/05/2012 11:20 AM, Avi Kivity wrote: > > > > On 03/05/2012 04:33 PM, Anthony Liguori wrote: > > > >> > > > >

[Qemu-devel] [PATCH 0/7] block: convert VDI image format to coroutines

2012-03-05 Thread Paolo Bonzini
Conversion to coroutines simplifies the code and removes the need to duplicate common features of the block layer. Each step in the conversion is detailed in the corresponding commit message. Tested with qemu-iotests. Paolo Bonzini (7): vdi: basic conversion to coroutines vdi: move end-of-I/

[Qemu-devel] [PATCH v3 1/8] fix format name for backing file

2012-03-05 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- blockdev.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/blockdev.c b/blockdev.c index d78aa51..96a893b 100644 --- a/blockdev.c +++ b/blockdev.c @@ -800,7 +800,8 @@ void qmp_blockdev_group_snapshot_sync(SnapshotDevList *dev_list,

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Avi Kivity
On 03/05/2012 08:16 PM, Anthony Liguori wrote: > >> >>>We're pretty close to being there. Luiz, about how long do you >>> think before we get there? >> >> It's a pity to add new commands along the way. > > It's more complicated than this unfortunately. > > A client needs to be able to determin

[Qemu-devel] [PATCH v3 2/8] qapi: complete implementation of unions

2012-03-05 Thread Paolo Bonzini
Reviewed-by: Luiz Capitulino Signed-off-by: Paolo Bonzini --- qapi-schema-test.json | 10 ++ scripts/qapi-types.py |5 + scripts/qapi-visit.py | 31 ++- test-qmp-input-visitor.c | 18 ++ test-qmp-output-visitor.c |

[Qemu-devel] [PATCH 6/7] vdi: do not create useless iovecs

2012-03-05 Thread Paolo Bonzini
Reads and writes to the underlying file can also occur with the simple non-vectored I/O interfaces. Signed-off-by: Paolo Bonzini --- block/vdi.c | 79 -- 1 files changed, 33 insertions(+), 46 deletions(-) diff --git a/block/vdi.c b/block

Re: [Qemu-devel] [PATCH] pci: fix bridge IO/BASE

2012-03-05 Thread Blue Swirl
On Sun, Mar 4, 2012 at 22:29, Michael S. Tsirkin wrote: > On Sun, Mar 04, 2012 at 09:54:02PM +, Blue Swirl wrote: >> >> 19.3.1.10 tells that the header type is 0, as you noted too. Still, >> >> the register layout matches bridge spec instead, for example there are >> >> bus number registers in

[Qemu-devel] [PATCH 4/7] vdi: move aiocb fields to locals

2012-03-05 Thread Paolo Bonzini
Most of the AIOCB really holds local variables that need to persist across callback invocation. It can go away now. Signed-off-by: Paolo Bonzini --- block/vdi.c | 162 -- 2 files changed, 65 insertions(+), 101 deletions(-) diff --git a/

[Qemu-devel] [PATCH v3 5/8] qmp: convert blockdev-snapshot-sync to a wrapper around transactions

2012-03-05 Thread Paolo Bonzini
Simplify the blockdev-snapshot-sync code and gain failsafe operation by turning it into a wrapper around the new transaction command. A new option is also added matching "mode". Signed-off-by: Paolo Bonzini --- blockdev.c | 81 - hmp-c

[Qemu-devel] [PATCH v3 6/8] Add blkmirror block driver

2012-03-05 Thread Paolo Bonzini
From: Marcelo Tosatti Mirrored writes are used by live block copy. Signed-off-by: Marcelo Tosatti Signed-off-by: Federico Simoncelli Signed-off-by: Paolo Bonzini --- Makefile.objs |2 +- block/blkmirror.c | 239 + 2 files changed,

Re: [Qemu-devel] [PATCH v3 4/8] add mode field to blockdev-snapshot-sync transaction item

2012-03-05 Thread Eric Blake
On 03/05/2012 10:33 AM, Paolo Bonzini wrote: > The mode field lets a management application create the snapshot > destination outside QEMU. > > Right now, the only modes are "existing" and "absolute-paths". Mirroring > introduces "no-backing-file". In the future "relative-paths" could be > imple

[Qemu-devel] [PATCH] block: handle -EBUSY in bdrv_commit_all()

2012-03-05 Thread Stefan Hajnoczi
Monitor operations that manipulate image files must not execute while a background job (like image streaming) is in progress. This prevents corruptions from happening when two pieces of code are manipulating the image file without knowledge of each other. The monitor "commit" command raises QERR_

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-03-05 Thread Blue Swirl
On Mon, Mar 5, 2012 at 15:17, Avi Kivity wrote: > On 03/05/2012 05:15 PM, Anthony Liguori wrote: >>> The other alternative is to s/target_phys_addr_t/uint64_t/ in the memory >>> API.  I think 32-on-32 is quite rare these days, so it wouldn't be much >>> of a performance issue. >> >> >> I think thi

[Qemu-devel] [PATCH 7/7] vdi: change goto to loop

2012-03-05 Thread Paolo Bonzini
Finally reindent all code and change goto statements to a loop. Signed-off-by: Paolo Bonzini --- block/vdi.c | 141 -- 1 files changed, 68 insertions(+), 73 deletions(-) diff --git a/block/vdi.c b/block/vdi.c index c192c7e..41ec137 100644

Re: [Qemu-devel] [PATCH 0/2] Unbreak aliases of I/O regions (and -vga std)

2012-03-05 Thread Blue Swirl
On Mon, Mar 5, 2012 at 15:51, Avi Kivity wrote: > Aliases to memory regions in the I/O address space are broken; this affects > -vga std.  These two patches fix the problem. > > Also available in > >  git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/urgent Thanks, pulled. > Avi Kivity (

Re: [Qemu-devel] [PULL 0/2] s390 patch queue 2012-03-05

2012-03-05 Thread Blue Swirl
On Mon, Mar 5, 2012 at 18:51, Alexander Graf wrote: > Hi Aurelien / Blue, > > This is my current patch queue for s390. Please pull. Thanks, pulled. > Alex > > > The following changes since commit 2aeabc08179553e1a7eed6cf26286c3efc06ee0b: >  Stefan Weil (1): >        w64: fix type casts when call

Re: [Qemu-devel] [PATCH 5/6] cache-utils: Change data type of parameters for flush_icache_range

2012-03-05 Thread Alexander Graf
On 03/02/2012 11:30 PM, Stefan Weil wrote: The TCG targets i386 and tci needed a change of the function prototype for w64. This change is currently not needed here, but it can be applied to avoid code differences. Cc: Alexander Graf Signed-off-by: Stefan Weil --- cache-utils.h |2 +- 1 f

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Alon Levy
On Mon, Mar 05, 2012 at 08:17:52PM +0200, Avi Kivity wrote: > On 03/05/2012 08:09 PM, Alon Levy wrote: > > On Mon, Mar 05, 2012 at 02:31:42PM -0300, Luiz Capitulino wrote: > > > On Mon, 05 Mar 2012 11:27:07 -0600 > > > Anthony Liguori wrote: > > > > > > > On 03/05/2012 11:20 AM, Avi Kivity wrote:

Re: [Qemu-devel] [PATCH v3 5/8] qmp: convert blockdev-snapshot-sync to a wrapper around transactions

2012-03-05 Thread Eric Blake
On 03/05/2012 10:33 AM, Paolo Bonzini wrote: > Simplify the blockdev-snapshot-sync code and gain failsafe operation > by turning it into a wrapper around the new transaction command. A new > option is also added matching "mode". > > Signed-off-by: Paolo Bonzini > --- > blockdev.c | 81 +

[Qemu-devel] [PATCH 1/7] vdi: basic conversion to coroutines

2012-03-05 Thread Paolo Bonzini
Even a basic conversion changing the bdrv_aio_readv/bdrv_aio_writev calls to bdrv_co_readv/bdrv_co_writev, and callbacks to goto statements can eliminate a lot of code. This is because error handling is simplified and indirections through bottom halves can go away. After this patch, I/O to the un

[Qemu-devel] Fwd: Question on qemu-kvm 1.0

2012-03-05 Thread Al Patel
-- Forwarded message -- From: Al Patel Date: Mon, Mar 5, 2012 at 11:17 AM Subject: Question on qemu-kvm 1.0 To: k...@vger.kernel.org, m...@redhat.com Hi , We have been using qemu/kvm 0.12.5 (unchanged with stock kernel 2.6.32). I just upgraded to qemu/kvm-1.0 and see noticable

[Qemu-devel] Fwd: Question on qemu-kvm 1.0

2012-03-05 Thread Al Patel
-- Forwarded message -- From: Al Patel Date: Mon, Mar 5, 2012 at 11:19 AM Subject: Re: Question on qemu-kvm 1.0 To: k...@vger.kernel.org, m...@redhat.com Side note: I am not using vhost-net yet. I am reading from the blogs that vhost-net gives much better performance. I am puttin

Re: [Qemu-devel] [PATCH v3 7/8] add mirroring to transaction

2012-03-05 Thread Eric Blake
On 03/05/2012 10:34 AM, Paolo Bonzini wrote: > With it comes a new image creation mode, "no-backing-file", that can > be used to stream an image so that the destination does not need the > original image's backing file(s). > > Both bdrv_append and blkmirror will set the backing_hd on the target, >

Re: [Qemu-devel] [PATCH] Userspace ARM BE8 support

2012-03-05 Thread Peter Maydell
On 29 February 2012 15:40, Paul Brook wrote: > Add support for ARM BE8 userspace binaries. > i.e. big-endian data and little-endian code. > In principle LE8 mode is also possible, but AFAIK has never actually > been implemented/used. There seems to have been an LE8 flag in the ARM ELF spec at one

[Qemu-devel] [PATCH 2/7] vdi: move end-of-I/O handling at the end

2012-03-05 Thread Paolo Bonzini
The next step is to take code that only triggers after the first operation, and move it at the end of vdi_aio_read_cb and vdi_aio_write_cb. Signed-off-by: Paolo Bonzini --- block/vdi.c | 123 +++ 1 files changed, 56 insertions(+), 67 delet

[Qemu-devel] [PATCH v3 0/7] add fixed-width visitors and serialization tests

2012-03-05 Thread Michael Roth
These patches apply on top of qemu.git master, and can also be obtained from: git://github.com/mdroth/qemu.git visitor-fixed-width-v3 CHANGES SINCE V2: - Fix qemu-test errors due to now-strict bounds-checking we doing assignment between signed/unsigned types. - uint* property getters/setters

[Qemu-devel] [PATCH v3 3/7] qapi: QMP input visitor, handle floats parsed as ints

2012-03-05 Thread Michael Roth
JSON numbers can be interpreted as either integers or floating point values depending on their representation. As a result, QMP input visitor might visit a QInt when it was expecting a QFloat, so add handling to account for this. Signed-off-by: Michael Roth --- qapi/qmp-input-visitor.c |9 ++

[Qemu-devel] [PATCH v3 6/7] qdev: use int32_t container for devfn property

2012-03-05 Thread Michael Roth
Valid range for devfn is -1 to 255 (-1 for automatic assignment). We do not currently validate this due to devfn being stored as a uint32_t. This can lead to segfaults and other strange behavior. We could technically just cast it to int32_t to implement the checking, but this will not work for vis

[Qemu-devel] [PATCH 2/2] Move helpers.h to helper.h

2012-03-05 Thread Alexander Graf
From: Lluís Vilanova Provides a file naming scheme consistent with other targets. Signed-off-by: Lluís Vilanova Signed-off-by: Alexander Graf --- target-s390x/{helpers.h => helper.h} |0 target-s390x/op_helper.c |2 +- target-s390x/translate.c |4 ++-- 3 fi

[Qemu-devel] [PULL 0/2] s390 patch queue 2012-03-05

2012-03-05 Thread Alexander Graf
Hi Aurelien / Blue, This is my current patch queue for s390. Please pull. Alex The following changes since commit 2aeabc08179553e1a7eed6cf26286c3efc06ee0b: Stefan Weil (1): w64: fix type casts when calling flush_icache_range are available in the git repository at: git://repo.or.cz

[Qemu-devel] [PATCH 1/2] s390: Rework kernel loading: supports elf and newer kernels

2012-03-05 Thread Alexander Graf
From: Christian Borntraeger This reworks the image loading on s390. Newer kernels will not always have a 0dd0 (basr 13,0) at address 0x1. We must not rely on specific code at certain addresses. This check was introduced to warn users that tried to load vmlinux, since ELF loading was not sup

Re: [Qemu-devel] PPC: VGA broken in git master

2012-03-05 Thread Alon Levy
On Mon, Mar 05, 2012 at 04:16:54PM +, Mark Cave-Ayland wrote: > On 05/03/12 15:48, Avi Kivity wrote: > > >>>Can you provide the command line needed to reproduce the problem? > >> > >>Sure. I can reproduce it here using something as simple as: > >> > >>./qemu-system-ppc -cdrom /dev/null -boot d

[Qemu-devel] [PATCH v3 5/7] qapi: String visitor, use %f represenation for floats

2012-03-05 Thread Michael Roth
Currently string-output-visitor formats floats as %g, which is nice in that trailing 0's are automatically truncated, but otherwise this causes some issues: - it 6 uses significant figures instead of 6 decimal places, which means something like 155777.5 (which even has an exact floating point

[Qemu-devel] [PATCH v3 7/7] qdev: switch property accessors to fixed-width visitor interfaces

2012-03-05 Thread Michael Roth
Signed-off-by: Michael Roth --- hw/qdev-addr.c |4 +- hw/qdev-properties.c | 140 ++ 2 files changed, 87 insertions(+), 57 deletions(-) diff --git a/hw/qdev-addr.c b/hw/qdev-addr.c index 0bb16c7..b711b6b 100644 --- a/hw/qdev-addr.c +++

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Anthony Liguori
On 03/05/2012 12:22 PM, Avi Kivity wrote: On 03/05/2012 08:16 PM, Anthony Liguori wrote: We're pretty close to being there. Luiz, about how long do you think before we get there? It's a pity to add new commands along the way. It's more complicated than this unfortunately. A client

[Qemu-devel] [PATCH 1/1] vmware_vga: stop crashing

2012-03-05 Thread Serge Hallyn
if x or y < 0, set them to 0 (and decrement width/height accordingly)> I don't know where the best place to catch this would be, but with vnc and vmware_vga it's possible to get set_bit called on a negative index, crashing qemu. See https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/918791

[Qemu-devel] [PATCH v3 2/7] qapi: unit tests for visitor-based serialization

2012-03-05 Thread Michael Roth
Currently we test our visitors individually, and seperately for input vs. output. This is useful for validating internal representations against the native C types and vice-versa, and other visitor-specific testing, but it doesn't cover the potential use-case of using visitor pairs for serializatio

[Qemu-devel] [PATCH] Add the drive-reopen command

2012-03-05 Thread Federico Simoncelli
Signed-off-by: Federico Simoncelli --- blockdev.c | 40 +++- hmp-commands.hx | 16 hmp.c| 11 +++ hmp.h|1 + qapi-schema.json | 22 ++ 5 files changed, 77 insertions(+), 13

[Qemu-devel] [PATCH v3 1/7] qapi: add Visitor interfaces for uint*_t and int*_t

2012-03-05 Thread Michael Roth
This adds visitor interfaces for fixed-width integers types. Implementing these in visitors is optional, otherwise we fall back to visit_type_int() (int64_t) with some additional bounds checking to avoid integer overflows for cases where the value fetched exceeds the bounds of our target C type. S

Re: [Qemu-devel] [PATCH] [s390] Move helpers.h to helper.h

2012-03-05 Thread Alexander Graf
On 02/13/2012 04:33 PM, Lluís Vilanova wrote: Provides a file naming scheme consistent with other targets. Thanks, applied to s390-next. Alex

Re: [Qemu-devel] [PATCH v3 5/8] qmp: convert blockdev-snapshot-sync to a wrapper around transactions

2012-03-05 Thread Paolo Bonzini
Il 05/03/2012 19:55, Eric Blake ha scritto: > Right now, libvirt has an API virDomainSnapshotCreateXML with a flag > VIR_DOMAIN_SNAPSHOT_CREATE_REUSE_EXT, which should map to this new mode > operand. Am I guaranteed that if I pass a 'mode' argument of 'existing' > to an older qemu that lacked mode

[Qemu-devel] [PATCH v3 4/7] qapi: add String visitor coverage to serialization unit tests

2012-03-05 Thread Michael Roth
Signed-off-by: Michael Roth --- test-visitor-serialization.c | 40 1 files changed, 40 insertions(+), 0 deletions(-) diff --git a/test-visitor-serialization.c b/test-visitor-serialization.c index 6ef57d0..b8ad16f 100644 --- a/test-visitor-serialization

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Luiz Capitulino
On Mon, 5 Mar 2012 20:58:08 +0200 Alon Levy wrote: > On Mon, Mar 05, 2012 at 08:17:52PM +0200, Avi Kivity wrote: > > On 03/05/2012 08:09 PM, Alon Levy wrote: > > > On Mon, Mar 05, 2012 at 02:31:42PM -0300, Luiz Capitulino wrote: > > > > On Mon, 05 Mar 2012 11:27:07 -0600 > > > > Anthony Liguori

Re: [Qemu-devel] [PATCH v1 1/1] ppc: Correctly define POWERPC_INSNS2_DEFAULT

2012-03-05 Thread Andreas Färber
Am 05.03.2012 18:06, schrieb Meador Inge: > On 02/23/2012 07:44 AM, Meador Inge wrote: > >> 'POWERPC_INSNS2_DEFAULT' was defined incorrectly which was causing the >> opcode table creation code to erroneously register 'eieio' and 'mbar' >> for the "default" processor: >> >>** ERROR: opcode 1a a

Re: [Qemu-devel] [PATCH 5/6] cache-utils: Change data type of parameters for flush_icache_range

2012-03-05 Thread Stefan Weil
Am 05.03.2012 19:57, schrieb Alexander Graf: On 03/02/2012 11:30 PM, Stefan Weil wrote: The TCG targets i386 and tci needed a change of the function prototype for w64. This change is currently not needed here, but it can be applied to avoid code differences. Cc: Alexander Graf Signed-off-by: S

<    1   2   3   >