On 03/05/2012 10:34 AM, Paolo Bonzini wrote: > With it comes a new image creation mode, "no-backing-file", that can > be used to stream an image so that the destination does not need the > original image's backing file(s). > > Both bdrv_append and blkmirror will set the backing_hd on the target, > even if the image is created without one, so that both streaming and > copy-on-write work properly (at least with qcow2 or qed, not raw). > > Streaming mode works with the following gotchas: > > - streaming will rewrite every bit of the source image; > > - zero writes are not supported by the blkmirror driver, hence both > the source and the destination image will grow to full size. > > @@ -1159,7 +1175,8 @@ > ## > { 'union': 'BlockdevAction', > 'data': { > - 'blockdev-snapshot-sync': 'BlockdevSnapshot' > + 'blockdev-snapshot-sync': 'BlockdevSnapshot',
Minor nit - should we rebase this trailing comma earlier in the series, to make it obvious that BlockdevAction will grow and for less churn in this patch? -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature