[Qemu-devel] [PATCH v11 8/9] hw/pc_piix: add pc-1.1

2012-02-22 Thread Jordan Justen
Signed-off-by: Jordan Justen --- hw/pc_piix.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 2fc4211..fcf0153 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -371,8 +371,8 @@ static void pc_xen_hvm_init(ram_addr_t ram_size,

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-02-22 Thread Mitsyanko Igor
On 02/21/2012 07:33 PM, Peter Maydell wrote: Short summary: * switch wp groups to bitfield rather than int array * convert sd.c to use memory_region_init_ram() to allocate the wp groups (being careful to use memory_region_set_dirty() when we touch them) * we don't need variable-length field

[Qemu-devel] virtio-win-0.1-22 balloon install fails on 2008R2

2012-02-22 Thread sean darcy
Trying to install the virtio-win-0.1-22.iso balloon driver on Windows 2008R2: E:\Wlh\amd64>x:\microsoft\WinDDK\7600.16385.win7_wdk.100208-1538\tools\devcon\amd64\devcon.exe install BALLOON.inf PCI\VEN_1AF4&DEV_1002&SUBSYS_00051AF4&REV_00 Device node created. Install is complete when drivers ar

[Qemu-devel] [PATCH v11 6/9] hw/pc_sysfw: support system flash memory with pflash

2012-02-22 Thread Jordan Justen
Flash can be enabled by calling pc_system_firmware_init with the system_flash_enabled parameter being non-zero. If system_flash_enabled is zero, then the older qemu rom creation method will be used. If flash is enabled and a pflash image is found, then it is used for the system firmware image. If

Re: [Qemu-devel] [PATCH 0/2] Add "-uboot" option

2012-02-22 Thread Peter Maydell
On 22 February 2012 06:58, Evgeny Voevodin wrote: > These patches add "-uboot" option to ARM boards. > To let user load u-boot, board should initialize > .uboot_start in arm_boot_info struct. > Added utilisation of "-uboot" for exynos4 and integratorcp. Nack. This kind of thing should be done by

[Qemu-devel] [Bug 938431] Re: Reproducible crash in slirp_remque (qemu 1.0.1)

2012-02-22 Thread Craig Ringer
I have now reproduced the same segfault without the controlling script by running qemu on the command line and connecting to it with lftp. To reproduce the fault it appears to be necessary to attempt to connect to the guest before it is fully booted and ready to accept connections; if I let it "set

[Qemu-devel] [PATCH v11 4/9] hw/pc: move rom init to pc_sysfw.c

2012-02-22 Thread Jordan Justen
Signed-off-by: Jordan Justen --- Makefile.target |1 + hw/pc.c | 56 +++-- hw/pc.h |3 ++ hw/pc_sysfw.c | 92 +++ 4 files changed, 101 insertions(+), 51 deletions(-) create mode 100644 h

[Qemu-devel] [PATCH v11 2/9] pflash_cfi01/02: support read-only pflash devices

2012-02-22 Thread Jordan Justen
Signed-off-by: Jordan Justen --- hw/pflash_cfi01.c | 44 +++- hw/pflash_cfi02.c | 83 2 files changed, 75 insertions(+), 52 deletions(-) diff --git a/hw/pflash_cfi01.c b/hw/pflash_cfi01.c index ee0c3ba..b03f623 1006

[Qemu-devel] [PATCH v11 5/9] hw/pc_sysfw: enable pc-sysfw as a qdev

2012-02-22 Thread Jordan Justen
Setup a pc-sysfw device type. It contains a single property of 'rom_only' which is defaulted to enabled. Signed-off-by: Jordan Justen --- hw/pc_sysfw.c | 37 + 1 files changed, 37 insertions(+), 0 deletions(-) diff --git a/hw/pc_sysfw.c b/hw/pc_sysfw.c ind

[Qemu-devel] [PATCH v11 0/9] PC system flash support

2012-02-22 Thread Jordan Justen
Enable flash emulation in a PC system using pflash_cfi01. v11: * Convert pc-sysfw to qdev - Add rom_only property * Remove KVM flash support to remove the need for using bdrv_read during machine initialization. KVM should now continue to use the same 'rom' initialization sequence that it

Re: [Qemu-devel] [PATCH 0/2] Add "-uboot" option

2012-02-22 Thread Evgeny Voevodin
On 22.02.2012 12:12, Peter Maydell wrote: On 22 February 2012 06:58, Evgeny Voevodin wrote: These patches add "-uboot" option to ARM boards. To let user load u-boot, board should initialize .uboot_start in arm_boot_info struct. Added utilisation of "-uboot" for exynos4 and integratorcp. Nack.

Re: [Qemu-devel] [PATCH 0/2] Add "-uboot" option

2012-02-22 Thread Peter Maydell
On 22 February 2012 08:29, Evgeny Voevodin wrote: > On 22.02.2012 12:12, Peter Maydell wrote: >> Nack. This kind of thing should be done by making QEMU >> load an ELF file which has u-boot in it (which at the >> moment you can do with -kernel). Loading Linux kernels >> is a special case in arm_boo

Re: [Qemu-devel] Help me about the FDC

2012-02-22 Thread Stefan Hajnoczi
On Wed, Feb 22, 2012 at 6:16 AM, Zhi Hui Li wrote: > 1: explain the difference between : > >    type_register_static(&isa_fdc_info); >    type_register_static(&sysbus_fdc_info); >    type_register_static(&sun4m_fdc_info); The floppy disk controller is used by several different targets, including

[Qemu-devel] Thank you very much!

2012-02-22 Thread Zhi Hui Li

Re: [Qemu-devel] [PATCH v2] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8

2012-02-22 Thread Andreas Färber
Am 22.02.2012 08:27, schrieb Paolo Bonzini: > On 02/22/2012 03:07 AM, 陳韋任 wrote: >> >> -HELPERS-$(CONFIG_LINUX) = qemu-bridge-helper$(EXESUF) >> +HELPERS-$(CONFIG_LINUX) : config-host.h qemu-bridge-helper$(EXESUF) > > This is not declaring the dependency, it is declaring a target. > > The rule

[Qemu-devel] [PATCH] qxl: fix spice+sdl no cursor regression

2012-02-22 Thread Alon Levy
regression introduced by 075360945860ad9bdd491921954b383bf762b0e5, Reported-by: Fabiano Fidêncio Signed-off-by: Alon Levy --- Thanks for the report, this fixes the problem for me, the problem with reverting the commit you proposed is that it would reintroduce dropping of the global mutex in spi

[Qemu-devel] [RFC] qom: Sorted class enumeration

2012-02-22 Thread Andreas Färber
Hello, For listing registered CPU classes I needed a way to sort classes in a custom (i.e., non-hashtable) order. I found it easiest to sort the classes using the existing foreach infrastructure, on the go via GLib's binary tree. Patch is still missing documentation, but do you think this is the

[Qemu-devel] [PATCH RFC] qom: Introduce object_class_foreach_ordered()

2012-02-22 Thread Andreas Färber
This functions allows to walk the classes in a custom order rather than in hashtable order. Signed-off-by: Andreas Färber Cc: Anthony Liguori Cc: Peter Maydell --- include/qemu/object.h |6 ++ qom/object.c | 43 +++ 2 files changed, 49

[Qemu-devel] [PATCH v2] qxl: fix spice+sdl no cursor regression

2012-02-22 Thread Alon Levy
regression introduced by 075360945860ad9bdd491921954b383bf762b0e5, v2: lock around qemu_spice_cursor_refresh_unlocked Reported-by: Fabiano Fidêncio Signed-off-by: Alon Levy --- hw/qxl.c |4 ui/spice-display.c | 23 ++- ui/spice-display.h |1 + 3 fil

Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io

2012-02-22 Thread Andreas Färber
Am 22.02.2012 02:11, schrieb David Gibson: > On Tue, Feb 21, 2012 at 10:09:01AM +0100, Kevin Wolf wrote: >> Am 21.02.2012 09:35, schrieb Paolo Bonzini: >>> On 02/20/2012 11:50 AM, Alexander Graf wrote: >> DMAAIOCB *dbs = qemu_aio_get(&dma_aio_pool, bs, cb, opaque); >> >> -trace_

Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io

2012-02-22 Thread Hannes Reinecke
On 02/22/2012 10:54 AM, Andreas Färber wrote: > Am 22.02.2012 02:11, schrieb David Gibson: >> On Tue, Feb 21, 2012 at 10:09:01AM +0100, Kevin Wolf wrote: >>> Am 21.02.2012 09:35, schrieb Paolo Bonzini: On 02/20/2012 11:50 AM, Alexander Graf wrote: >>> DMAAIOCB *dbs = qemu_aio_get(&dma_

[Qemu-devel] [PATCH 2/5] hw/pxa2xx_dma.c: drop VMSTATE_UINTTL usage

2012-02-22 Thread Igor Mitsyanko
Convert variables descr, src and dest from type target_phys_addr_t to uint32_t, use VMSTATE_UINT32 instead of VMSTATE_UINTTL for these variables. We can do it safely because: 1) pxa2xx has 32-bit physical address; 2) rest of the code in this file treats these variables as uint32_t; 3) we shouldn't

[Qemu-devel] [PATCH 0/5] VMState cleanups

2012-02-22 Thread Igor Mitsyanko
This patchset cleans up and optimizes vmstate implementation. Patch 1 is a trivial bug fixing. Patches 2 and 3 replaces target_phys_addr_t in pxa implementation to uint32_t. Patch 4 moves VMSTATE_UINTTL from hw.h to vmstate.h. Explicit dependency on NEED_CPU_H is droped, I failed to understand why

[Qemu-devel] [PATCH 3/5] hw/pxa2xx_lcd.c: drop VMSTATE_UINTTL usage

2012-02-22 Thread Igor Mitsyanko
Convert three variables in DMAChannel state from type target_phys_addr_t to uint32_t, use VMSTATE_UINT32 instead of VMSTATE_UINTTL for these variables. We can do it safely because: 1) pxa2xx has 32-bit physical address; 2) rest of the code in this file treats these variables as uint32_t; 3) we sho

[Qemu-devel] [PATCH 5/5] vmstate: introduce get_bufsize entry in VMStateField

2012-02-22 Thread Igor Mitsyanko
New get_bufsize field in VMStateField is supposed to help us easily add save/restore support of dynamically allocated buffers in device's states. There are some cases when information about size of dynamically allocated buffer is already presented in specific device's state structure, but in such

[Qemu-devel] [PATCH 4/5] vmstate: refactor and move VMSTATE_UINTTL* macro

2012-02-22 Thread Igor Mitsyanko
Instead of defining VMSTATE_UINTTL* based on TARGET_LONG_BITS value, we can use qemu_put_betls/qemu_get_betls functions. These two functions depend on TARGET_LONG_BITS as well, and this new approach for VMSTATE_UINTTL* will result in the same thing as before (will call qemu_get_be32s/qemu_put_be32s

[Qemu-devel] [PATCH 1/5] target-alpha/machine.c: use VMSTATE_UINT64* instead of VMSTATE_UINTTL*

2012-02-22 Thread Igor Mitsyanko
Do not use VMSTATE_UINTTL* macro for variables that are actually defined as uint64_t in CPUAlphaState. Signed-off-by: Igor Mitsyanko --- target-alpha/machine.c | 34 +- 1 files changed, 17 insertions(+), 17 deletions(-) diff --git a/target-alpha/machine.c b/ta

[Qemu-devel] [Bug 938552] [NEW] ENH: Inherit ptys, useful output from -serial pty

2012-02-22 Thread Craig Ringer
Public bug reported: When controlling a qemu instance from another program, it'd be very useful to be able to have qemu inherit pseudo-tty file descriptors so they could just be specified on the command line. It's possible to allocate a pty pair in the master program before forking and exec'ing q

Re: [Qemu-devel] [PATCH 2/5] hw/pxa2xx_dma.c: drop VMSTATE_UINTTL usage

2012-02-22 Thread Peter Maydell
On 22 February 2012 10:15, Igor Mitsyanko wrote: > Convert variables descr, src and dest from type target_phys_addr_t to > uint32_t, > use VMSTATE_UINT32 instead of VMSTATE_UINTTL for these variables. > We can do it safely because: > 1) pxa2xx has 32-bit physical address; > 2) rest of the code in

Re: [Qemu-devel] [PATCH 3/5] hw/pxa2xx_lcd.c: drop VMSTATE_UINTTL usage

2012-02-22 Thread Peter Maydell
On 22 February 2012 10:15, Igor Mitsyanko wrote: > Convert three variables in DMAChannel state from type target_phys_addr_t to > uint32_t, > use VMSTATE_UINT32 instead of VMSTATE_UINTTL for these variables. > We can do it safely because: > 1) pxa2xx has 32-bit physical address; > 2) rest of the c

Re: [Qemu-devel] [RFC v4 4/9] qxl: screen_dump in vga: do a single ppm_save

2012-02-22 Thread Gerd Hoffmann
On 02/21/12 22:39, Alon Levy wrote: > Using vga->screen_dump results in a number of calls to ppm_save, > instead of a single one. Can you investigate why? > Lacking time to test all the possible users of > vga->screen_dump, avoid the redundant calls by doing the vga_hw_update+ > ppm_save in qxl_h

Re: [Qemu-devel] [RFC v4 5/9] qxl: require spice >= 0.8.2

2012-02-22 Thread Gerd Hoffmann
On 02/21/12 22:39, Alon Levy wrote: > drop all ifdefs on SPICE_INTERFACE_QXL_MINOR >= 1 as a result, > 0.8.2 has SPICE_INTERFACE_QXL_MINOR == 1. Nice. I think there are a few more SPICE_SERVER_VERSION #ifdefs which can be dropped too. Also SPICE_INTERFACE_CORE_MINOR ... cheers, Gerd

Re: [Qemu-devel] [RFC v4 6/9] qxl: remove flipped

2012-02-22 Thread Gerd Hoffmann
Hi, It's not obvious to me how the non-flipped case (qxl_stride > 0) is handled now. Have you tested this with both windows+linux guests? cheers, Gerd

Re: [Qemu-devel] [PATCH v2 0/4] RTC: New logic to emulate RTC

2012-02-22 Thread Paolo Bonzini
On 02/21/2012 01:00 AM, Zhang, Yang Z wrote: >> > Thanks, this looks much better! I'll run it through some tests. >> > >> > We also should try to keep migration working from older versions using the >> > load_old callback. > Sure, I missed it. Will add it to the version 3. > Any other comments?

Re: [Qemu-devel] [PATCH 1/5] target-alpha/machine.c: use VMSTATE_UINT64* instead of VMSTATE_UINTTL*

2012-02-22 Thread Peter Maydell
Looks plausible but cc'ing the Alpha maintainer... -- PMM On 22 February 2012 10:15, Igor Mitsyanko wrote: > Do not use VMSTATE_UINTTL* macro for variables that are actually defined as > uint64_t > in CPUAlphaState. > > Signed-off-by: Igor Mitsyanko > --- >  target-alpha/machine.c |   34 +

Re: [Qemu-devel] [RFC v4 7/9] qxl: introduce QXLCookie

2012-02-22 Thread Gerd Hoffmann
On 02/21/12 22:39, Alon Levy wrote: > Will be used in the next patch. Looks good, and is more readable without all the #ifdefs. > static void qxl_spice_flush_surfaces_async(PCIQXLDevice *qxl) > { > -spice_qxl_flush_surfaces_async(&qxl->ssd.qxl, 0); > + spice_qxl_flush_surfaces_async(&qxl->s

Re: [Qemu-devel] [PATCH 0/5] VMState cleanups

2012-02-22 Thread Peter Maydell
On 22 February 2012 10:15, Igor Mitsyanko wrote: > This patchset cleans up and optimizes vmstate implementation. > > Patch 1 is a trivial bug fixing. > Patches 2 and 3 replaces target_phys_addr_t in pxa implementation > to uint32_t. > Patch 4 moves VMSTATE_UINTTL from hw.h to vmstate.h. Explicit d

Re: [Qemu-devel] [PATCH 3/5] hw/pxa2xx_lcd.c: drop VMSTATE_UINTTL usage

2012-02-22 Thread andrzej zaborowski
On 22 February 2012 11:15, Igor Mitsyanko wrote: > Convert three variables in DMAChannel state from type target_phys_addr_t to > uint32_t, > use VMSTATE_UINT32 instead of VMSTATE_UINTTL for these variables. > We can do it safely because: > 1) pxa2xx has 32-bit physical address; > 2) rest of the c

Re: [Qemu-devel] [RFC v4 8/9] qxl: make qxl_render_update async

2012-02-22 Thread Gerd Hoffmann
Hi, > +qxl->render_update_redraw_area.left = 0; > +qxl->render_update_redraw_area.right = > +qxl->guest_primary.surface.width; > +qxl->render_update_redraw_area.top= 0; > +qxl->render_update_redraw_area.bottom = > +qxl->guest_primary.surface.height; Are th

Re: [Qemu-devel] [RFC v4 9/9] qxl-render: call ppm_save on bh

2012-02-22 Thread Gerd Hoffmann
On 02/21/12 22:39, Alon Levy wrote: > This changes the behavior of the monitor command. After the previous > patch, there is no longer an option of deadlock with virt-manager, but > ppm_save is called too early, before the update has completed. With this > patch it is called at the correct moment,

Re: [Qemu-devel] [PATCH 3/5] hw/pxa2xx_lcd.c: drop VMSTATE_UINTTL usage

2012-02-22 Thread Peter Maydell
On 22 February 2012 11:36, andrzej zaborowski wrote: > On 22 February 2012 11:15, Igor Mitsyanko wrote: >> Convert three variables in DMAChannel state from type target_phys_addr_t to >> uint32_t, >> use VMSTATE_UINT32 instead of VMSTATE_UINTTL for these variables. >> We can do it safely because:

Re: [Qemu-devel] [PATCH 0/5] VMState cleanups

2012-02-22 Thread Mitsyanko Igor
On 02/22/2012 03:26 PM, Peter Maydell wrote: On 22 February 2012 10:15, Igor Mitsyanko wrote: This patchset cleans up and optimizes vmstate implementation. Patch 1 is a trivial bug fixing. Patches 2 and 3 replaces target_phys_addr_t in pxa implementation to uint32_t. Patch 4 moves VMSTATE_UINT

Re: [Qemu-devel] [PATCH 0/5] VMState cleanups

2012-02-22 Thread Peter Maydell
On 22 February 2012 10:15, Igor Mitsyanko wrote: > Patch 4 moves VMSTATE_UINTTL from hw.h to vmstate.h. Explicit dependency > on NEED_CPU_H is droped, I failed to understand why it was presented at all. You need #ifdef NEED_CPU_H because in generic source files (where NEED_CPU_H is not defined) t

Re: [Qemu-devel] [PATCH v5 12/12] suspend: add qmp events

2012-02-22 Thread Gerd Hoffmann
Hi, > Isn't this something where it is easier to omit first and add later > once we have a use case, than to add up front only to find that no > one cares? Yes. I'll drop it. cheers, Gerd

Re: [Qemu-devel] [PATCH 3/5] hw/pxa2xx_lcd.c: drop VMSTATE_UINTTL usage

2012-02-22 Thread andrzej zaborowski
On 22 February 2012 13:00, Peter Maydell wrote: > On 22 February 2012 11:36, andrzej zaborowski wrote: >> On 22 February 2012 11:15, Igor Mitsyanko wrote: >>> Convert three variables in DMAChannel state from type target_phys_addr_t to >>> uint32_t, >>> use VMSTATE_UINT32 instead of VMSTATE_UINT

Re: [Qemu-devel] [RFC v4 4/9] qxl: screen_dump in vga: do a single ppm_save

2012-02-22 Thread Alon Levy
On Wed, Feb 22, 2012 at 12:10:08PM +0100, Gerd Hoffmann wrote: > On 02/21/12 22:39, Alon Levy wrote: > > Using vga->screen_dump results in a number of calls to ppm_save, > > instead of a single one. > > Can you investigate why? oh, I know why. vga_screen_dump implementation: screen_dump_file

Re: [Qemu-devel] [PATCH 3/5] hw/pxa2xx_lcd.c: drop VMSTATE_UINTTL usage

2012-02-22 Thread Mitsyanko Igor
On 02/22/2012 03:36 PM, andrzej zaborowski wrote: On 22 February 2012 11:15, Igor Mitsyanko wrote: Convert three variables in DMAChannel state from type target_phys_addr_t to uint32_t, use VMSTATE_UINT32 instead of VMSTATE_UINTTL for these variables. We can do it safely because: 1) pxa2xx has

Re: [Qemu-devel] [RFC v4 6/9] qxl: remove flipped

2012-02-22 Thread Alon Levy
On Wed, Feb 22, 2012 at 12:18:50PM +0100, Gerd Hoffmann wrote: > Hi, > > It's not obvious to me how the non-flipped case (qxl_stride > 0) is > handled now. Have you tested this with both windows+linux guests? It isn't handled. The simplest way is just to if on the stride and do a single memcpy

Re: [Qemu-devel] [RFC v4 8/9] qxl: make qxl_render_update async

2012-02-22 Thread Alon Levy
On Wed, Feb 22, 2012 at 12:41:01PM +0100, Gerd Hoffmann wrote: > Hi, > > > +qxl->render_update_redraw_area.left = 0; > > +qxl->render_update_redraw_area.right = > > +qxl->guest_primary.surface.width; > > +qxl->render_update_redraw_area.top= 0; > > +qxl->render_upda

Re: [Qemu-devel] [RFC v4 9/9] qxl-render: call ppm_save on bh

2012-02-22 Thread Alon Levy
On Wed, Feb 22, 2012 at 12:46:28PM +0100, Gerd Hoffmann wrote: > On 02/21/12 22:39, Alon Levy wrote: > > This changes the behavior of the monitor command. After the previous > > patch, there is no longer an option of deadlock with virt-manager, but > > ppm_save is called too early, before the updat

Re: [Qemu-devel] [RFC v4 9/9] qxl-render: call ppm_save on bh

2012-02-22 Thread Alon Levy
On Wed, Feb 22, 2012 at 12:46:28PM +0100, Gerd Hoffmann wrote: > On 02/21/12 22:39, Alon Levy wrote: > > This changes the behavior of the monitor command. After the previous > > patch, there is no longer an option of deadlock with virt-manager, but > > ppm_save is called too early, before the updat

Re: [Qemu-devel] [PATCH 3/5] hw/pxa2xx_lcd.c: drop VMSTATE_UINTTL usage

2012-02-22 Thread Peter Maydell
On 22 February 2012 12:13, andrzej zaborowski wrote: > On 22 February 2012 13:00, Peter Maydell wrote: >> On 22 February 2012 11:36, andrzej zaborowski wrote: >>> On 22 February 2012 11:15, Igor Mitsyanko wrote: Convert three variables in DMAChannel state from type target_phys_addr_t

Re: [Qemu-devel] [PATCH 3/5] hw/pxa2xx_lcd.c: drop VMSTATE_UINTTL usage

2012-02-22 Thread andrzej zaborowski
On 22 February 2012 13:26, Mitsyanko Igor wrote: > On 02/22/2012 03:36 PM, andrzej zaborowski wrote: >> Why's uint32_t more correct though?  The purpose of using a named type >> across qemu is to mark fields as memory addresses (similar to size_t >> being used for sizes, etc.), uint32_t conveys le

Re: [Qemu-devel] [PATCH 0/5] VMState cleanups

2012-02-22 Thread Andreas Färber
Am 22.02.2012 12:26, schrieb Peter Maydell: > So if we apply patches 1-3 (which all look plausible) then the only > remaining user of VMSTATE_UINTTL is target-i386/machine.c as far as > I can see. > > This leaves me wondering if we shouldn't just put it actually in > target-i386/machine.c as a con

Re: [Qemu-devel] [PATCH 0/5] VMState cleanups

2012-02-22 Thread Peter Maydell
On 22 February 2012 12:49, Andreas Färber wrote: > Am 22.02.2012 12:26, schrieb Peter Maydell: >> So if we apply patches 1-3 (which all look plausible) then the only >> remaining user of VMSTATE_UINTTL is target-i386/machine.c as far as >> I can see. >> >> This leaves me wondering if we shouldn't

Re: [Qemu-devel] [PATCH 3/5] hw/pxa2xx_lcd.c: drop VMSTATE_UINTTL usage

2012-02-22 Thread andrzej zaborowski
On 22 February 2012 13:48, Peter Maydell wrote: > On 22 February 2012 12:13, andrzej zaborowski wrote: >> On 22 February 2012 13:00, Peter Maydell wrote: >>> On 22 February 2012 11:36, andrzej zaborowski wrote: On 22 February 2012 11:15, Igor Mitsyanko wrote: > Convert three variables

Re: [Qemu-devel] [PATCH v3 0/5]: QMP: add DEVICE_TRAY_MOVED event

2012-02-22 Thread Luiz Capitulino
On Mon, 20 Feb 2012 09:28:15 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > The event name changed, which caused the subject to change too, hope this > > won't cause confusion. > > > > v3 > > > > o Rename the event to DEVICE_TRAY_MOVED > > o Rename the 'ejected' event data to 't

Re: [Qemu-devel] [PATCH 6/6] qmp: add balloon-get-memory-stats & event

2012-02-22 Thread Luiz Capitulino
On Fri, 17 Feb 2012 15:51:33 -0600 Michael Roth wrote: > On Fri, Feb 17, 2012 at 03:16:22PM -0200, Luiz Capitulino wrote: > > On Fri, 17 Feb 2012 10:55:41 -0600 > > Anthony Liguori wrote: > > > > > On 02/08/2012 02:30 PM, Luiz Capitulino wrote: > > > > This commit adds a QMP API for the guest p

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-22 Thread Peter Zijlstra
On Sat, 2012-02-04 at 11:08 +0900, Takuya Yoshikawa wrote: > The latter needs a fundamental change: I heard (from Avi) that we can > change mmu_lock to mutex_lock if mmu_notifier becomes preemptible. > > So I was planning to restart this work when Peter's > "mm: Preemptibility" >

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-22 Thread Luiz Capitulino
On Tue, 21 Feb 2012 19:40:16 +0200 Alon Levy wrote: > On Tue, Feb 21, 2012 at 09:15:45AM -0700, Eric Blake wrote: > > On 02/21/2012 01:19 AM, Alon Levy wrote: > > > > >>> (2) Async monitor command. Keeps interface and works nicely. A bunch > > >>> of QAPI bits tickled into master meanwhi

Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event

2012-02-22 Thread Kevin Wolf
Am 17.02.2012 20:21, schrieb Luiz Capitulino: > It's emitted whenever the tray is moved by the guest or by HMP/QMP > commands. > > Signed-off-by: Luiz Capitulino > --- > QMP/qmp-events.txt | 18 ++ > block.c| 24 > monitor.c |

Re: [Qemu-devel] [PATCH v3 0/5]: QMP: add DEVICE_TRAY_MOVED event

2012-02-22 Thread Kevin Wolf
Am 22.02.2012 13:53, schrieb Luiz Capitulino: > On Mon, 20 Feb 2012 09:28:15 +0100 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >>> The event name changed, which caused the subject to change too, hope this >>> won't cause confusion. >>> >>> v3 >>> >>> o Rename the event to DEVICE_T

Re: [Qemu-devel] [PATCH v5 12/12] suspend: add qmp events

2012-02-22 Thread Luiz Capitulino
On Wed, 22 Feb 2012 13:08:16 +0100 Gerd Hoffmann wrote: > Hi, > > > Isn't this something where it is easier to omit first and add later > > once we have a use case, than to add up front only to find that no > > one cares? > > Yes. I'll drop it. Yes, I think it's better to drop it for now and

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-22 Thread Alon Levy
On Wed, Feb 22, 2012 at 11:17:17AM -0200, Luiz Capitulino wrote: > On Tue, 21 Feb 2012 19:40:16 +0200 > Alon Levy wrote: > > > On Tue, Feb 21, 2012 at 09:15:45AM -0700, Eric Blake wrote: > > > On 02/21/2012 01:19 AM, Alon Levy wrote: > > > > > > >>> (2) Async monitor command. Keeps interface a

Re: [Qemu-devel] [RFC] qom: Sorted class enumeration

2012-02-22 Thread Anthony Liguori
On 02/22/2012 03:44 AM, Andreas Färber wrote: Hello, For listing registered CPU classes I needed a way to sort classes in a custom (i.e., non-hashtable) order. I found it easiest to sort the classes using the existing foreach infrastructure, on the go via GLib's binary tree. Patch is still miss

Re: [Qemu-devel] [PATCH 3/5] hw/pxa2xx_lcd.c: drop VMSTATE_UINTTL usage

2012-02-22 Thread Mitsyanko Igor
On 02/22/2012 04:48 PM, andrzej zaborowski wrote: On 22 February 2012 13:26, Mitsyanko Igor wrote: On 02/22/2012 03:36 PM, andrzej zaborowski wrote: Why's uint32_t more correct though? The purpose of using a named type across qemu is to mark fields as memory addresses (similar to size_t being

Re: [Qemu-devel] [PATCH 3/5] hw/pxa2xx_lcd.c: drop VMSTATE_UINTTL usage

2012-02-22 Thread Mitsyanko Igor
On 02/22/2012 04:56 PM, andrzej zaborowski wrote: On 22 February 2012 13:48, Peter Maydell wrote: On 22 February 2012 12:13, andrzej zaborowski wrote: On 22 February 2012 13:00, Peter Maydell wrote: On 22 February 2012 11:36, andrzej zaborowski wrote: On 22 February 2012 11:15, Igor Mit

Re: [Qemu-devel] [PATCH 2/5] hw/pxa2xx_dma.c: drop VMSTATE_UINTTL usage

2012-02-22 Thread Juan Quintela
Igor Mitsyanko wrote: > Convert variables descr, src and dest from type target_phys_addr_t to > uint32_t, > use VMSTATE_UINT32 instead of VMSTATE_UINTTL for these variables. > We can do it safely because: > 1) pxa2xx has 32-bit physical address; > 2) rest of the code in this file treats these var

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-22 Thread Luiz Capitulino
On Wed, 22 Feb 2012 14:22:50 +0100 Alon Levy wrote: > On Wed, Feb 22, 2012 at 11:17:17AM -0200, Luiz Capitulino wrote: > > On Tue, 21 Feb 2012 19:40:16 +0200 > > Alon Levy wrote: > > > > > On Tue, Feb 21, 2012 at 09:15:45AM -0700, Eric Blake wrote: > > > > On 02/21/2012 01:19 AM, Alon Levy wrot

Re: [Qemu-devel] [PATCH 1/5] target-alpha/machine.c: use VMSTATE_UINT64* instead of VMSTATE_UINTTL*

2012-02-22 Thread Juan Quintela
Igor Mitsyanko wrote: > Do not use VMSTATE_UINTTL* macro for variables that are actually defined as > uint64_t > in CPUAlphaState. Old code is wrong (TM). I think that your changes are ok.

Re: [Qemu-devel] [PATCH 2/5] hw/pxa2xx_dma.c: drop VMSTATE_UINTTL usage

2012-02-22 Thread Peter Maydell
On 22 February 2012 13:47, Juan Quintela wrote: > Igor Mitsyanko wrote: >> Convert variables descr, src and dest from type target_phys_addr_t to >> uint32_t, >> use VMSTATE_UINT32 instead of VMSTATE_UINTTL for these variables. >> We can do it safely because: >> 1) pxa2xx has 32-bit physical addr

Re: [Qemu-devel] [PATCH 3/5] hw/pxa2xx_lcd.c: drop VMSTATE_UINTTL usage

2012-02-22 Thread Juan Quintela
andrzej zaborowski wrote: > On 22 February 2012 13:00, Peter Maydell wrote: >> On 22 February 2012 11:36, andrzej zaborowski wrote: >>> On 22 February 2012 11:15, Igor Mitsyanko wrote: Convert three variables in DMAChannel state from type target_phys_addr_t to uint32_t, use VMSTA

Re: [Qemu-devel] [RFC v4 4/9] qxl: screen_dump in vga: do a single ppm_save

2012-02-22 Thread Gerd Hoffmann
> And the only user of screen_dump_filename is: > > static void vga_save_dpy_update(DisplayState *ds, > int x, int y, int w, int h) > { > if (screen_dump_filename) { > ppm_save(screen_dump_filename, ds->surface); upstream/master this here: sc

Re: [Qemu-devel] [PATCH 4/5] vmstate: refactor and move VMSTATE_UINTTL* macro

2012-02-22 Thread Juan Quintela
Igor Mitsyanko wrote: > Instead of defining VMSTATE_UINTTL* based on TARGET_LONG_BITS value, we can > use qemu_put_betls/qemu_get_betls functions. These two functions depend on > TARGET_LONG_BITS as well, and this new approach for VMSTATE_UINTTL* will > result > in the same thing as before (will

Re: [Qemu-devel] [PATCH 0/5] VMState cleanups

2012-02-22 Thread Juan Quintela
Peter Maydell wrote: > On 22 February 2012 10:15, Igor Mitsyanko wrote: >> This patchset cleans up and optimizes vmstate implementation. >> >> Patch 1 is a trivial bug fixing. >> Patches 2 and 3 replaces target_phys_addr_t in pxa implementation >> to uint32_t. >> Patch 4 moves VMSTATE_UINTTL from

Re: [Qemu-devel] [PATCH 2/5] hw/pxa2xx_dma.c: drop VMSTATE_UINTTL usage

2012-02-22 Thread Juan Quintela
Peter Maydell wrote: > On 22 February 2012 13:47, Juan Quintela wrote: >> Igor Mitsyanko wrote: >>> Convert variables descr, src and dest from type target_phys_addr_t >>> to uint32_t, >>> use VMSTATE_UINT32 instead of VMSTATE_UINTTL for these variables. >>> We can do it safely because: >>> 1) px

Re: [Qemu-devel] [RFC v4 6/9] qxl: remove flipped

2012-02-22 Thread Gerd Hoffmann
On 02/22/12 13:28, Alon Levy wrote: > On Wed, Feb 22, 2012 at 12:18:50PM +0100, Gerd Hoffmann wrote: >> Hi, >> >> It's not obvious to me how the non-flipped case (qxl_stride > 0) is >> handled now. Have you tested this with both windows+linux guests? > > It isn't handled. The simplest way is ju

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-22 Thread Gerd Hoffmann
Hi, > Honestly, for this particular case, I'm not 100% sure that having an id is > _required_, as I don't expect a client to submit multiple screendump calls > in parallel and we don't "officially" support multiple QMP clients either. > Also, having the screendump filename in the event will serv

Re: [Qemu-devel] [RFC v4 6/9] qxl: remove flipped

2012-02-22 Thread Alon Levy
On Wed, Feb 22, 2012 at 03:09:09PM +0100, Gerd Hoffmann wrote: > On 02/22/12 13:28, Alon Levy wrote: > > On Wed, Feb 22, 2012 at 12:18:50PM +0100, Gerd Hoffmann wrote: > >> Hi, > >> > >> It's not obvious to me how the non-flipped case (qxl_stride > 0) is > >> handled now. Have you tested this wi

Re: [Qemu-devel] [Spice-devel] [RFC v4 4/9] qxl: screen_dump in vga: do a single ppm_save

2012-02-22 Thread Alon Levy
On Wed, Feb 22, 2012 at 02:58:10PM +0100, Gerd Hoffmann wrote: > > And the only user of screen_dump_filename is: > > > > static void vga_save_dpy_update(DisplayState *ds, > > int x, int y, int w, int h) > > { > > if (screen_dump_filename) { > > ppm_save(

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-22 Thread Alon Levy
On Wed, Feb 22, 2012 at 11:49:27AM -0200, Luiz Capitulino wrote: > On Wed, 22 Feb 2012 14:22:50 +0100 > Alon Levy wrote: > > > On Wed, Feb 22, 2012 at 11:17:17AM -0200, Luiz Capitulino wrote: > > > On Tue, 21 Feb 2012 19:40:16 +0200 > > > Alon Levy wrote: > > > > > > > On Tue, Feb 21, 2012 at 0

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-22 Thread Alon Levy
On Wed, Feb 22, 2012 at 03:22:11PM +0100, Gerd Hoffmann wrote: > Hi, > > > Honestly, for this particular case, I'm not 100% sure that having an id is > > _required_, as I don't expect a client to submit multiple screendump calls > > in parallel and we don't "officially" support multiple QMP clie

[Qemu-devel] [PATCH v4 02/18] dma-helpers: add dma_buf_read and dma_buf_write

2012-02-22 Thread Paolo Bonzini
These helpers do a full transfer from an in-memory buffer to target memory, with support for scatter/gather lists. It will be used to store the reply of an emulated command into a QEMUSGList provided by the adapter. Signed-off-by: Paolo Bonzini --- dma-helpers.c | 31 +

Re: [Qemu-devel] Merging qemu-iotests into qemu.git?

2012-02-22 Thread Anthony Liguori
On 02/20/2012 10:42 AM, Kevin Wolf wrote: Am 16.02.2012 21:53, schrieb Christoph Hellwig: On Thu, Feb 16, 2012 at 04:01:58PM +0100, Kevin Wolf wrote: Hi Christoph, I just talked to Stefan about our testing, both regarding the block layer and qemu in general, and we came to the conclusion that

[Qemu-devel] [PATCH v4 05/18] scsi: pass residual amount to command_complete

2012-02-22 Thread Paolo Bonzini
With the upcoming sglist support, HBAs will not see any transfer_data call and will not have a way to detect short transfers. So pass the residual amount of data upon command completion. Signed-off-by: Paolo Bonzini --- hw/esp.c |3 ++- hw/lsi53c895a.c |2 +- hw/scsi-bus.c|

[Qemu-devel] [PATCH v4 07/18] scsi-disk: enable scatter/gather functionality

2012-02-22 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/scsi-bus.c |1 + hw/scsi-disk.c | 63 --- 2 files changed, 51 insertions(+), 13 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index 0c471e0..dce6208 100644 --- a/hw/scsi-bus.c +++ b/hw/scsi-b

[Qemu-devel] [PATCH v4 11/18] virtio-scsi: Add virtio-scsi stub device

2012-02-22 Thread Paolo Bonzini
From: Stefan Hajnoczi Add a useless virtio SCSI HBA device: qemu -device virtio-scsi-pci Signed-off-by: Stefan Hajnoczi Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- Makefile.target |1 + default-configs/pci.mak |1 + default-configs/s39

[Qemu-devel] [PATCH v4 15/18] virtio-scsi: add migration support

2012-02-22 Thread Paolo Bonzini
Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- hw/virtio-scsi.c | 50 +- 1 files changed, 49 insertions(+), 1 deletions(-) diff --git a/hw/virtio-scsi.c b/hw/virtio-scsi.c index 380073a..7f850d1 100644 --- a/hw/virtio-scsi.c +++ b

Re: [Qemu-devel] [Spice-devel] [RFC v4 4/9] qxl: screen_dump in vga: do a single ppm_save

2012-02-22 Thread Gerd Hoffmann
On 02/22/12 15:25, Alon Levy wrote: > On Wed, Feb 22, 2012 at 02:58:10PM +0100, Gerd Hoffmann wrote: >>> And the only user of screen_dump_filename is: >>> >>> static void vga_save_dpy_update(DisplayState *ds, >>> int x, int y, int w, int h) >>> { >>> if (screen_d

Re: [Qemu-devel] [PULL v2 0/9] qdev deconstruction, command-line episode

2012-02-22 Thread Anthony Liguori
On 02/21/2012 11:13 AM, Paolo Bonzini wrote: Anthony, I'm sending a pull request since you informally said on IRC that you're okay with the patches. The following changes since commit 99c7f87826337fa81f2f0f9baa9ca0a44faf90e9: input: send kbd+mouse events only to running guests. (2012-02-17

Re: [Qemu-devel] [PULL] spice patch queue

2012-02-22 Thread Anthony Liguori
On 02/21/2012 04:59 AM, Gerd Hoffmann wrote: Hi, Here is the spice patch queue with a collection of little improvements and bugfixes. No major stuff. See individual patches for details. Pulled. Thanks. Regards, Anthony Liguori please pull, Gerd The following changes since commit

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-22 Thread Gerd Hoffmann
Hi, > I was thinking to add a new command since I'll want to add the id, and > if I'm already adding a new command I'll put in a display number too. Big question is what the display number is supposed to be ... cheers, Gerd

[Qemu-devel] [PATCH v4 10/18] scsi-disk: add migration support

2012-02-22 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 59 --- 1 files changed, 55 insertions(+), 4 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 2a24840..ec8e7cb 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -111,12 +111,1

Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs

2012-02-22 Thread Anthony Liguori
On 02/20/2012 11:31 AM, Jeff Cody wrote: The QAPI scripts allow for generating commands that receive parameter input consisting of a list of custom structs, but the QMP input paramter checking did not support receiving a qlist as opposed to a qdict for input. What are you trying to send on the

Re: [Qemu-devel] [Xen-devel] [PATCH V7 00/11] Xen PCI Passthrough

2012-02-22 Thread Anthony PERARD
On Mon, 20 Feb 2012, Anthony PERARD wrote: > On Mon, Feb 20, 2012 at 19:58, Tobias Geiger wrote: > > [00:06.0] pt_pci_read_config: address=0x0030 val=0x len=4 > > [00:06.0] pt_pci_write_config: address=0x0030 val=0x len=4 > > [00:06.0] pt_iomem_map: BAR 6, e_phys=0xfff

[Qemu-devel] [PATCH v4 06/18] scsi: add scatter/gather functionality

2012-02-22 Thread Paolo Bonzini
Scatter/gather functionality uses the newly added DMA helpers. The device can choose between doing DMA itself, or calling scsi_req_data as usual, which will use the newly added DMA helpers to copy piecewise to/from the destination area(s). Signed-off-by: Paolo Bonzini --- hw/scsi-bus.c | 28 +

Re: [Qemu-devel] Help me about the FDC

2012-02-22 Thread 陳韋任
> 3: or give me some introduce of FDC. http://en.wikipedia.org/wiki/Floppy_disk_controller HTH, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-2788-3799 #1667 Homepage: http://people.cs.nctu.edu.tw/~chenwj

Re: [Qemu-devel] Help me about the FDC

2012-02-22 Thread 陳韋任
> 2: explain the struct of FDCtrl; In order to know what those fields in FDCtrl mean, you might need to read ftp://download.intel.com/design/archives/periphrl/docs/29047504.pdf first. As the comment in hw/fdc.c says, it's Intel 82078 floppy disk controller emulation. Regards, chenwj -- Wei

[Qemu-devel] [PATCH] split SCSI and LSI, add myself as SCSI maintainer

2012-02-22 Thread Paolo Bonzini
This has been the de facto situation for a while now. Add a tree, too. Signed-off-by: Paolo Bonzini --- MAINTAINERS |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 647c413..0b3b3d8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -420

Re: [Qemu-devel] [PATCH 6/6] qmp: add balloon-get-memory-stats & event

2012-02-22 Thread Michael Roth
On Wed, Feb 22, 2012 at 10:48:13AM -0200, Luiz Capitulino wrote: > On Fri, 17 Feb 2012 15:51:33 -0600 > Michael Roth wrote: > > > On Fri, Feb 17, 2012 at 03:16:22PM -0200, Luiz Capitulino wrote: > > > On Fri, 17 Feb 2012 10:55:41 -0600 > > > Anthony Liguori wrote: > > > > > > > On 02/08/2012 02

  1   2   3   >