On 22 February 2012 12:49, Andreas Färber <afaer...@suse.de> wrote: > Am 22.02.2012 12:26, schrieb Peter Maydell: >> So if we apply patches 1-3 (which all look plausible) then the only >> remaining user of VMSTATE_UINTTL is target-i386/machine.c as far as >> I can see. >> >> This leaves me wondering if we shouldn't just put it actually in >> target-i386/machine.c as a convenience macro for that specific CPU >> to avoid having to have more #ifdef TARGET_X86_64s. > > Nack. I don't see the connection between target_ulong and TARGET_X86_64. > Just because that becomes the only user does not mean target_ulong is an > x86-specific concept.
Yeah, I guess. I would like the macro to be protected so you can only get at it if you're target-*/ though... -- PMM
