Re: [Qemu-devel] [PATCH v4 07/11] trace: [tracetool] Rewrite event argument parsing

2012-02-13 Thread Harsh Bora
On 02/10/2012 05:25 PM, Lluís Vilanova wrote: Signed-off-by: Lluís Vilanova --- scripts/tracetool.py | 190 -- 1 files changed, 91 insertions(+), 99 deletions(-) diff --git a/scripts/tracetool.py b/scripts/tracetool.py index f2bcb65..cd1c29d 10

Re: [Qemu-devel] [PATCH v2 1/8] kvm: Set cpu_single_env only once

2012-02-13 Thread Paolo Bonzini
On 02/11/2012 03:12 PM, Andreas Färber wrote: Yes and no. They can have any target-specific pointer they want, just as before. But no global first_cpu / cpu_single_env pointer - that's replaced by CPU pointers, through which members of derived classes can be accessed (which did not work for CPUSt

[Qemu-devel] [PATCHv2-RFC 0/2] RFC: standard pci bridge device

2012-02-13 Thread Michael S. Tsirkin
Here's a new version of the patch. It works for me. Deep nesting of bridges is supported. You need a small BIOS patch to support the OSHP method if you want hotplug to work. I will post this separately. We'd need a full ACPI driver to make hotplug work for guests without an SHPC driver (e.g. window

[Qemu-devel] [PATCHv2-RFC 2/2] pci: add standard bridge device

2012-02-13 Thread Michael S. Tsirkin
This adds support for a standard pci to pci bridge, enabling support for more than 32 PCI devices in the system. Device hotplug is supported by means of SHPC controller. For guests with an SHPC driver, this allows robust hotplug and even hotplug of nested bridges, up to 31 devices per bridge. TODO

[Qemu-devel] [PATCHv2-RFC 1/2] shpc: standard hot plug controller

2012-02-13 Thread Michael S. Tsirkin
This adds support for SHPC interface, as defined by PCI Standard Hot-Plug Controller and Subsystem Specification, Rev 1.0 http://www.pcisig.com/specifications/conventional/pci_hot_plug/SHPC_10 Only SHPC intergrated with a PCI-to-PCI bridge is supported, SHPC integrated with a host bridge would nee

Re: [Qemu-devel] [PATCH] oslib: make error handling more reasonable

2012-02-13 Thread Daniel P. Berrange
On Fri, Feb 10, 2012 at 11:35:11AM -0700, Eric Blake wrote: > On 02/10/2012 07:41 AM, Daniel P. Berrange wrote: > > >> @@ -80,7 +80,7 @@ void *qemu_oom_check(void *ptr) > >> { > >> if (ptr == NULL) { > >> fprintf(stderr, "Failed to allocate memory: %s\n", > >> strerror(errno)); > >

Re: [Qemu-devel] [PATCH v4 05/11] suspend: add infrastructure

2012-02-13 Thread Gleb Natapov
On Thu, Feb 09, 2012 at 06:05:37PM +0100, Gerd Hoffmann wrote: > This patch adds some infrastructure to handle suspend and resume to > qemu. First there are two functions to switch state and second there > is a suspend notifier: > > * qemu_system_suspend_request is supposed to be called when the

Re: [Qemu-devel] qemu-kvm-1.0 crashes with threaded vnc server?

2012-02-13 Thread Peter Lieven
Am 11.02.2012 um 09:55 schrieb Corentin Chary: > On Thu, Feb 9, 2012 at 7:08 PM, Peter Lieven wrote: >> Hi, >> >> is anyone aware if there are still problems when enabling the threaded vnc >> server? >> I saw some VMs crashing when using a qemu-kvm build with >> --enable-vnc-thread. >> >> qemu

[Qemu-devel] [PATCH RFC] seabios: add OSHP method stub

2012-02-13 Thread Michael S. Tsirkin
To allow guests to load the native SHPC driver for a bridge, we must declare an OSHP method for the appropriate device which lets the OS take control of the SHPC. As we don't access SHPC at the moment, we don't need to do anything - just report success. Signed-off-by: Michael S. Tsirkin --- dif

Re: [Qemu-devel] [PATCHv2-RFC 0/2] RFC: standard pci bridge device

2012-02-13 Thread Wen Congyang
At 02/13/2012 05:15 PM, Michael S. Tsirkin Wrote: > Here's a new version of the patch. It works for me. > Deep nesting of bridges is supported. > You need a small BIOS patch to support the OSHP method > if you want hotplug to work. I will post this separately. > We'd need a full ACPI driver to make

Re: [Qemu-devel] [PATCHv2-RFC 0/2] RFC: standard pci bridge device

2012-02-13 Thread Michael S. Tsirkin
On Mon, Feb 13, 2012 at 05:38:26PM +0800, Wen Congyang wrote: > At 02/13/2012 05:15 PM, Michael S. Tsirkin Wrote: > > Here's a new version of the patch. It works for me. > > Deep nesting of bridges is supported. > > You need a small BIOS patch to support the OSHP method > > if you want hotplug to w

Re: [Qemu-devel] [PATCHv2-RFC 1/2] shpc: standard hot plug controller

2012-02-13 Thread Isaku Yamahata
Oh nice work. On Mon, Feb 13, 2012 at 11:15:55AM +0200, Michael S. Tsirkin wrote: > This adds support for SHPC interface, as defined by PCI Standard > Hot-Plug Controller and Subsystem Specification, Rev 1.0 > http://www.pcisig.com/specifications/conventional/pci_hot_plug/SHPC_10 > > Only SHPC in

Re: [Qemu-devel] [PATCH v2 5/8] kvmvapic: Introduce TPR access optimization for Windows guests

2012-02-13 Thread Jan Kiszka
On 2012-02-11 16:25, Blue Swirl wrote: > On Fri, Feb 10, 2012 at 18:31, Jan Kiszka wrote: >> This enables acceleration for MMIO-based TPR registers accesses of >> 32-bit Windows guest systems. It is mostly useful with KVM enabled, >> either on older Intel CPUs (without flexpriority feature, can al

Re: [Qemu-devel] weird qdev error

2012-02-13 Thread Paolo Bonzini
On 02/13/2012 05:58 AM, Michael S. Tsirkin wrote: Doesn't solve this issue, but shouldn't we use _SAFE in object_property_del_child? Like this: ---> qemu: use safe list macro As we might remove an element from list, use the safe macro to walk it. Signed-off-by: Michael S. Tsirkin --- diff -

Re: [Qemu-devel] How to follow a child process created in the guest OS?

2012-02-13 Thread Stefan Hajnoczi
On Sun, Feb 12, 2012 at 3:00 AM, Wei Yang wrote: > 2012/2/11 malc : >> On Sat, 11 Feb 2012, Andreas F?rber wrote: >> >>> Am 10.02.2012 11:26, schrieb ???: >>> > On Fri, Feb 10, 2012 at 08:14:41AM +, Stefan Hajnoczi wrote: >>> >> On Thu, Feb 09, 2012 at 06:33:16PM +0800, ??? wrote: >>> >>> I am

[Qemu-devel] [PATCH] Running vgabios during resume from S3 on QEMU by default

2012-02-13 Thread Gleb Natapov
Run vgabios during resume from S3 by default on QEMU. QEMU still able to modify SeaBIOS behavior if it wishes so by providing etc/s3-resume-vga-init file. With QEMU emulated vga cards this behaviour is desirable otherwise console becomes unusable with Linux guests after resume. Since we control vga

Re: [Qemu-devel] [PATCH] oslib: make error handling more reasonable

2012-02-13 Thread Stefan Hajnoczi
On Mon, Feb 13, 2012 at 6:29 AM, Stefan Weil wrote: > Am 13.02.2012 03:37, schrieb Zhi Yong Wu: > >> On Fri, Feb 10, 2012 at 11:53 PM, Stefan Weil wrote: >>> >>> Am 10.02.2012 16:13, schrieb Zhi Yong Wu: >>> On Fri, Feb 10, 2012 at 10:41 PM, Daniel P. Berrange wrote: > > >

Re: [Qemu-devel] how could I analysis the trace log?

2012-02-13 Thread Stefan Hajnoczi
On Sun, Feb 12, 2012 at 4:32 AM, Wei Yang wrote: > After some run time, I run the script like: > ./scripts/simpletrace.py qemu_trace_events_parse qemu_trace.log > > The qemu_trace_events_parse is : > g_realloc(addr) > g_malloc(addr) > > The output looks like: > g_malloc 1.831 addr=0xb945d1f0 > g_m

Re: [Qemu-devel] virtio-blk throughput

2012-02-13 Thread Stefan Hajnoczi
On Sat, Feb 11, 2012 at 9:57 AM, Prateek Sharma wrote: > $QEMU  -cpu core2duo,+vmx  -drive file=$VM_PATH,if=virtio,aio=native > -drive file=viotest.img,if=virtio,index=2 -drive cache=none is typically used for good performance when the image is on a local disk. Try that and I think you'll see an

Re: [Qemu-devel] Missing patch in QEMU which is in QEMU-KVM

2012-02-13 Thread Jan Kiszka
On 2012-02-13 07:21, Gerhard Wiesinger wrote: > Hello, > > I miss the following patch in QEMU which is in QEMU-KVM: > http://article.gmane.org/gmane.comp.emulators.kvm.devel/13557 > > commit a7fe0297840908a4fd65a1cf742481ccd45960eb > Author: Andreas Winkelbauer > Date: Sun Feb 24 10:33:27 2008

Re: [Qemu-devel] [PATCH] i8259: Do not clear level-triggered lines in IRR on init

2012-02-13 Thread Jan Kiszka
On 2012-01-24 16:29, Jan Kiszka wrote: > When an input line is handled as level-triggered, it will immediately > raise an IRQ on the output of a PIC again that goes through an init > reset. So only clear the edge-triggered inputs from IRR in that > scenario. > > Signed-off-by: Jan Kiszka > --- >

Re: [Qemu-devel] virtio-blk throughput

2012-02-13 Thread Prateek Sharma
On Mon, Feb 13, 2012 at 4:53 PM, Stefan Hajnoczi wrote: > On Sat, Feb 11, 2012 at 9:57 AM, Prateek Sharma wrote: >> $QEMU  -cpu core2duo,+vmx  -drive file=$VM_PATH,if=virtio,aio=native >> -drive file=viotest.img,if=virtio,index=2 > > -drive cache=none is typically used for good performance when t

Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h

2012-02-13 Thread Stefano Stabellini
On Fri, 10 Feb 2012, Paul Brook wrote: > > +#ifdef CONFIG_SLIRP > > +static inline void slirp_update_timeout(uint32_t *timeout) > > +{ > > +*timeout = MIN(1000, *timeout); > > +} > > +#else > > +static inline void slirp_update_timeout(uint32_t *timeout) { } > > +#endif > > Shouldn't we be test

Re: [Qemu-devel] [PATCHv2-RFC 1/2] shpc: standard hot plug controller

2012-02-13 Thread Michael S. Tsirkin
On Mon, Feb 13, 2012 at 07:03:52PM +0900, Isaku Yamahata wrote: > Oh nice work. > > On Mon, Feb 13, 2012 at 11:15:55AM +0200, Michael S. Tsirkin wrote: > > This adds support for SHPC interface, as defined by PCI Standard > > Hot-Plug Controller and Subsystem Specification, Rev 1.0 > > http://www.p

Re: [Qemu-devel] virtio-blk performance regression and qemu-kvm

2012-02-13 Thread Stefan Hajnoczi
On Fri, Feb 10, 2012 at 2:36 PM, Dongsu Park wrote: >  Now I'm running benchmarks with both qemu-kvm 0.14.1 and 1.0. > >  - Sequential read (Running inside guest) >   # fio -name iops -rw=read -size=1G -iodepth 1 \ >    -filename /dev/vdb -ioengine libaio -direct=1 -bs=4096 > >  - Sequential write

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-02-13 Thread Stefano Stabellini
On Tue, 31 Jan 2012, Stefano Stabellini wrote: > On Wed, 25 Jan 2012, Stefano Stabellini wrote: > > Hi all, > > this is the fourth version of the Xen save/restore patch series. > > We have been discussing this issue for quite a while on #qemu and > > qemu-devel: > > > > > > http://marc.info/?l=qe

Re: [Qemu-devel] [PATCH V6 11/11] pci: Do not check if a bus exist in pci_parse_devaddr.

2012-02-13 Thread Michael S. Tsirkin
On Mon, Feb 13, 2012 at 12:20:13PM +, Anthony PERARD wrote: > Actually, pci_parse_devaddr checks if the dom/bus of the PCI address exist. > But > this should be the jobs of a caller. In fact, the two callers of this function > will try to retrieve the PCIBus related to the devaddr and return a

Re: [Qemu-devel] [RFC Patch 5/7]Qemu: raw-posix image file reopen

2012-02-13 Thread Supriya Kannery
On 02/02/2012 05:45 AM, Michael Roth wrote: On 01/31/2012 09:07 PM, Supriya Kannery wrote: raw-posix driver changes for bdrv_reopen_xx functions to safely reopen image files. Reopening of image files while changing hostcache dynamically is handled here. + + /* Flags that can be set using fcn

Re: [Qemu-devel] [RFC Patch 2/7]Qemu: Error classes for file reopen and data sync failure

2012-02-13 Thread Supriya Kannery
On 02/07/2012 01:26 PM, Stefan Hajnoczi wrote: On Wed, Feb 01, 2012 at 08:36:28AM +0530, Supriya Kannery wrote: Index: qemu/qerror.c === --- qemu.orig/qerror.c +++ qemu/qerror.c @@ -108,6 +108,14 @@ static const QErrorStringTable qe

Re: [Qemu-devel] [RFC Patch 1/7]Qemu: Enhance "info block" to display host cache setting

2012-02-13 Thread Supriya Kannery
On 02/08/2012 05:30 PM, Luiz Capitulino wrote: On Wed, 01 Feb 2012 08:36:14 +0530 Supriya Kannery wrote: Enhance "info block" to display hostcache setting for each block device. Example: (qemu) info block ide0-hd0: removable=0 file=../rhel6-32.raw ro=0 drv=raw encrypted=0 Enhanced to display

Re: [Qemu-devel] [RFC Patch 3/7]Qemu: Cmd "block_set_hostcache" for dynamic cache change

2012-02-13 Thread Supriya Kannery
On 02/08/2012 05:37 PM, Luiz Capitulino wrote: On Wed, 01 Feb 2012 08:36:41 +0530 Supriya Kannery wrote: +ret = bdrv_open(bs, bs->filename, bdrv_flags, drv); +if (ret< 0) { +/* Reopen failed. Try to open with original flags */ +qerror_report(QERR_REOPEN_FILE_FAILED,

[Qemu-devel] QEMU desired libiscsi.so clashes with libiscsi.so from iscsi-initiator-utils

2012-02-13 Thread Daniel P. Berrange
I was investigating how to build latest QEMU with the iSCSI block driver enabled. I saw that configure wanted a libiscsi.so, so I installed that library from Fedora RPMs via the iscsi-initiator-utils package, but it still wouldn't build. After further investigation, I find that QEMU in fact wants

Re: [Qemu-devel] [RFC Patch 5/7]Qemu: raw-posix image file reopen

2012-02-13 Thread Supriya Kannery
On 02/08/2012 08:24 PM, Kevin Wolf wrote: Am 01.02.2012 04:07, schrieb Supriya Kannery: raw-posix driver changes for bdrv_reopen_xx functions to safely reopen image files. Reopening of image files while changing hostcache dynamically is handled here. +typedef struct BDRVRawReopenState { +

Re: [Qemu-devel] [RFC Patch 6/7]Qemu: raw-win32 image file reopen

2012-02-13 Thread Supriya Kannery
On 02/08/2012 08:32 PM, Kevin Wolf wrote: Am 01.02.2012 04:07, schrieb Supriya Kannery: win32 driver changes for bdrv_reopen_xx functions to safely reopen image files. Reopening of image files while changing hostcache dynamically is handled here. + +if (osvi.dwMajorVersion>= WINDOWS_VISTA)

[Qemu-devel] [PATCH v3] Add SPICE support to add_client monitor command

2012-02-13 Thread Daniel P. Berrange
From: "Daniel P. Berrange" With the acceptance of some new APIs to libspice-server.so it is possible to add support for SPICE to the 'add_client' monitor command, bringing parity with VNC. Since SPICE can use TLS or plain connections, the command also gains a new 'tls' parameter to specify whethe

Re: [Qemu-devel] virtio-blk throughput

2012-02-13 Thread Anthony Liguori
On 02/13/2012 05:23 AM, Stefan Hajnoczi wrote: On Sat, Feb 11, 2012 at 9:57 AM, Prateek Sharma wrote: $QEMU -cpu core2duo,+vmx -drive file=$VM_PATH,if=virtio,aio=native -drive file=viotest.img,if=virtio,index=2 -drive cache=none is typically used for good performance when the image is on a

Re: [Qemu-devel] [RFC Patch 4/7]Qemu: Framework for reopening image files safely

2012-02-13 Thread Supriya Kannery
On 02/08/2012 08:37 PM, Kevin Wolf wrote: Am 01.02.2012 04:06, schrieb Supriya Kannery: Struct BDRVReopenState along with three reopen related functions introduced for handling reopening of images safely. This can be extended by each of the block drivers to reopen respective image files. +

Re: [Qemu-devel] [PATCH] oslib: make error handling more reasonable

2012-02-13 Thread Markus Armbruster
Stefan Weil writes: > Am 10.02.2012 16:13, schrieb Zhi Yong Wu: >> On Fri, Feb 10, 2012 at 10:41 PM, Daniel P. Berrange >> wrote: >>> On Fri, Feb 10, 2012 at 10:34:13PM +0800, Zhi Yong Wu wrote: From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- oslib-posix.c |4 ++-

Re: [Qemu-devel] virtio-blk throughput

2012-02-13 Thread Stefan Hajnoczi
On Mon, Feb 13, 2012 at 11:39 AM, Prateek Sharma wrote: > On Mon, Feb 13, 2012 at 4:53 PM, Stefan Hajnoczi wrote: >> On Sat, Feb 11, 2012 at 9:57 AM, Prateek Sharma >> wrote: >>> $QEMU  -cpu core2duo,+vmx  -drive file=$VM_PATH,if=virtio,aio=native >>> -drive file=viotest.img,if=virtio,index=2 >

Re: [Qemu-devel] [PATCH] oslib: make error handling more reasonable

2012-02-13 Thread Peter Maydell
On 13 February 2012 14:04, Markus Armbruster wrote: > I consider abort() on OOM somewhat eccentric.  abort() is for > programming errors.  Resource shortage is an environmental error that is > sometimes (but not always) caused by a programming error. > > I'd rather inconvenience programmers (by ma

Re: [Qemu-devel] [PATCHv2-RFC 1/2] shpc: standard hot plug controller

2012-02-13 Thread Isaku Yamahata
On Mon, Feb 13, 2012 at 01:49:32PM +0200, Michael S. Tsirkin wrote: > On Mon, Feb 13, 2012 at 07:03:52PM +0900, Isaku Yamahata wrote: > > Oh nice work. > > > > On Mon, Feb 13, 2012 at 11:15:55AM +0200, Michael S. Tsirkin wrote: > > > This adds support for SHPC interface, as defined by PCI Standard

[Qemu-devel] [PATCH 0/3] New sigaltstack method for coroutine

2012-02-13 Thread Alex Barcelo
This series of patches implements coroutines method with sigaltstack. The flow of creation and management of the coroutines is quite similar to the coroutine-ucontext.c. The way to use sigaltstack to achieve the needed stack manipulation is done in a way quite similar to the GNU Portable Threads (

[Qemu-devel] [PATCH 1/3] coroutine: adding sigaltstack method (.c source)

2012-02-13 Thread Alex Barcelo
This file is based in both coroutine-ucontext.c and pth_mctx.c (from the GNU Portable Threads library). The mechanism used to change stacks is the sigaltstack function (variant 2 of the pth library). Signed-off-by: Alex Barcelo --- coroutine-sigaltstack.c | 337

[Qemu-devel] [PATCH 2/3] coroutine: adding control flags (enable/disable) for ucontext compilation

2012-02-13 Thread Alex Barcelo
Configure tries, as a default, ucontext functions for the coroutines. But now the user can force its use or disable it at all (enable and disable flags) Signed-off-by: Alex Barcelo --- configure | 26 ++ 1 files changed, 22 insertions(+), 4 deletions(-) diff --git a/co

[Qemu-devel] [PATCH 3/3] coroutine: adding enable/disable options for sigaltstack method

2012-02-13 Thread Alex Barcelo
It's possible to enable/disable sigaltstack, but it always has less priority than ucontext method (to force sigaltstack, ucontext has to be disabled). Signed-off-by: Alex Barcelo --- Makefile.objs |4 configure | 39 +++ 2 files changed, 43 inse

Re: [Qemu-devel] [PATCHv2-RFC 1/2] shpc: standard hot plug controller

2012-02-13 Thread Michael S. Tsirkin
On Mon, Feb 13, 2012 at 11:30:23PM +0900, Isaku Yamahata wrote: > On Mon, Feb 13, 2012 at 01:49:32PM +0200, Michael S. Tsirkin wrote: > > On Mon, Feb 13, 2012 at 07:03:52PM +0900, Isaku Yamahata wrote: > > > Oh nice work. > > > > > > On Mon, Feb 13, 2012 at 11:15:55AM +0200, Michael S. Tsirkin wro

Re: [Qemu-devel] [PATCH 3/3] coroutine: adding enable/disable options for sigaltstack method

2012-02-13 Thread Daniel P. Berrange
On Mon, Feb 13, 2012 at 03:42:30PM +0100, Alex Barcelo wrote: > It's possible to enable/disable sigaltstack, but it always has > less priority than ucontext method (to force sigaltstack, > ucontext has to be disabled). > > Signed-off-by: Alex Barcelo > --- > Makefile.objs |4 > configur

Re: [Qemu-devel] [PATCH 0/3] New sigaltstack method for coroutine

2012-02-13 Thread Peter Maydell
On 13 February 2012 14:42, Alex Barcelo wrote: > This series of patches implements coroutines method with > sigaltstack. > > The flow of creation and management of the coroutines is > quite similar to the coroutine-ucontext.c. The way to use > sigaltstack to achieve the needed stack manipulation i

Re: [Qemu-devel] [PATCH 1/3] coroutine: adding sigaltstack method (.c source)

2012-02-13 Thread Paolo Bonzini
On 02/13/2012 03:42 PM, Alex Barcelo wrote: This file is based in both coroutine-ucontext.c and pth_mctx.c (from the GNU Portable Threads library). The mechanism used to change stacks is the sigaltstack function (variant 2 of the pth library). Signed-off-by: Alex Barcelo --- coroutine-sigalts

Re: [Qemu-devel] [PATCH 0/3] New sigaltstack method for coroutine

2012-02-13 Thread Alex Barcelo
On Mon, Feb 13, 2012 at 15:51, Peter Maydell wrote: > On 13 February 2012 14:42, Alex Barcelo wrote: >> This series of patches implements coroutines method with >> sigaltstack. >> >> The flow of creation and management of the coroutines is >> quite similar to the coroutine-ucontext.c. The way to

Re: [Qemu-devel] how could I analysis the trace log?

2012-02-13 Thread Andreas Färber
Hi, Am 12.02.2012 05:32, schrieb Wei Yang: > I enable the trace function with --enable-trace-backend=simple and I > create the event file like this > g_realloc > g_malloc > > Then I start the qemu with following command. > ./i386-softmmu/qemu-system-i386 -enable-kvm -drive > file=../../kvm/ubuntu

Re: [Qemu-devel] [PATCH 3/3] coroutine: adding enable/disable options for sigaltstack method

2012-02-13 Thread Alex Barcelo
On Mon, Feb 13, 2012 at 15:49, Daniel P. Berrange wrote: > Since the 3 different coroutine impls are mutually exclusive > choices, perhaps it'd be preferable to just have a single > configure argument like > >   --with-couroutines=[ucontext|sigaltstack|gthread] > > Thus avoiding the non-sensical s

Re: [Qemu-devel] [PATCH v4 07/11] trace: [tracetool] Rewrite event argument parsing

2012-02-13 Thread Lluís Vilanova
Harsh Bora writes: > BTW, I am manually applying your changes on top of my patches as there were > significant changes in my patches also. I will include your patches in my next > series. Excellent. Lluis -- "And it's much the same thing with knowledge, for whenever you learn something new,

Re: [Qemu-devel] slirp-related crash

2012-02-13 Thread Zhi Yong Wu
On Mon, Feb 13, 2012 at 4:24 AM, Jan Kiszka wrote: > On 2012-02-12 19:34, Michael S. Tsirkin wrote: >> It seems somewhat easy to crash qemu with slirp if we queue multiple packets. >> I didn't investigate further yet so I don't know if this >> is a regression. Anyone knowledgeable about slirp want

Re: [Qemu-devel] [PATCH 2/3] coroutine: adding control flags (enable/disable) for ucontext compilation

2012-02-13 Thread Kevin Wolf
Am 13.02.2012 15:42, schrieb Alex Barcelo: > Configure tries, as a default, ucontext functions for the > coroutines. But now the user can force its use or disable > it at all (enable and disable flags) > > Signed-off-by: Alex Barcelo I think a better approach would be to have a --coroutines=[uco

[Qemu-devel] [PATCH] [m68k] Move helpers.h to helper.h

2012-02-13 Thread Lluís Vilanova
Provides a file naming scheme consistent with other targets. Signed-off-by: Lluís Vilanova --- target-m68k/helper.c|2 +- target-m68k/helper.h| 54 +++ target-m68k/helpers.h | 54 --- target

[Qemu-devel] [PATCH] [s390] Move helpers.h to helper.h

2012-02-13 Thread Lluís Vilanova
Provides a file naming scheme consistent with other targets. Signed-off-by: Lluís Vilanova --- target-s390x/helper.h| 152 ++ target-s390x/helpers.h | 152 -- target-s390x/op_helper.c |2 - target

[Qemu-devel] [PATCH] [xtensa] Move helpers.h to helper.h

2012-02-13 Thread Lluís Vilanova
Provides a file naming scheme consistent with other targets. Signed-off-by: Lluís Vilanova --- target-xtensa/helper.h| 32 target-xtensa/helpers.h | 32 target-xtensa/op_helper.c |2 +- target-xtensa/translate.c |

Re: [Qemu-devel] [PATCH 1/3] coroutine: adding sigaltstack method (.c source)

2012-02-13 Thread Andreas Färber
Am 13.02.2012 15:42, schrieb Alex Barcelo: > This file is based in both coroutine-ucontext.c and > pth_mctx.c (from the GNU Portable Threads library). > > The mechanism used to change stacks is the sigaltstack > function (variant 2 of the pth library). > > Signed-off-by: Alex Barcelo > --- > co

Re: [Qemu-devel] [PATCH 1/3] coroutine: adding sigaltstack method (.c source)

2012-02-13 Thread Alex Barcelo
On Mon, Feb 13, 2012 at 16:57, Andreas Färber wrote: > You should (need to?) use version 2.1 or later above then, too. You can > then simply move this snippet up and drop the "Same license ..." line. I wanted to ask this, but it slipped my mind. So it's ok to change the header to a newer GNU vers

[Qemu-devel] [PATCH V6 00/11] Xen PCI Passthrough

2012-02-13 Thread Anthony PERARD
Hi all, This patch series introduces the PCI passthrough for Xen. First, we have HostPCIDevice that help to access one PCI device of the host. Then, there is an additions in the QEMU code, pci_check_bar_overlap. There are also several change in pci_ids and pci_regs. Last part, but not least, t

[Qemu-devel] [PATCH V6 04/11] configure: Introduce --enable-xen-pci-passthrough.

2012-02-13 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- configure | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 763db24..0787992 100755 --- a/configure +++ b/configure @@ -132,6 +132,7 @@ vnc_png="" vnc_thread="no" xen="" xen_ctrl_versi

[Qemu-devel] [PATCH V6 02/11] pci_regs: Fix value of PCI_EXP_TYPE_RC_EC.

2012-02-13 Thread Anthony PERARD
Value check in PCI Express Base Specification rev 1.1 Signed-off-by: Anthony PERARD --- hw/pci_regs.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pci_regs.h b/hw/pci_regs.h index e8357c3..6b42515 100644 --- a/hw/pci_regs.h +++ b/hw/pci_regs.h @@ -393,7 +393,7 @@

[Qemu-devel] [PATCH V6 01/11] pci_ids: Add INTEL_82599_VF id.

2012-02-13 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- hw/pci_ids.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/pci_ids.h b/hw/pci_ids.h index e8235a7..943106a 100644 --- a/hw/pci_ids.h +++ b/hw/pci_ids.h @@ -118,6 +118,7 @@ #define PCI_DEVICE_ID_INTEL_82801I_UHCI6 0x2939 #define PCI

[Qemu-devel] [PATCH V6 06/11] pci.c: Add pci_check_bar_overlap

2012-02-13 Thread Anthony PERARD
From: Yuji Shimada This function helps Xen PCI Passthrough device to check for overlap. Signed-off-by: Yuji Shimada Signed-off-by: Anthony PERARD --- hw/pci.c | 47 +++ hw/pci.h |3 +++ 2 files changed, 50 insertions(+), 0 deletions(-) diff -

[Qemu-devel] [PATCH V6 08/11] Introduce Xen PCI Passthrough, PCI config space helpers (2/3)

2012-02-13 Thread Anthony PERARD
From: Allen Kay A more complete history can be found here: git://xenbits.xensource.com/qemu-xen-unstable.git Signed-off-by: Allen Kay Signed-off-by: Guy Zana Signed-off-by: Anthony PERARD --- hw/xen_pci_passthrough.c | 10 + hw/xen_pci_passthrough.h |2 + hw/xen

[Qemu-devel] [PATCH V6 07/11] Introduce Xen PCI Passthrough, qdevice (1/3)

2012-02-13 Thread Anthony PERARD
From: Allen Kay A more complete history can be found here: git://xenbits.xensource.com/qemu-xen-unstable.git Signed-off-by: Allen Kay Signed-off-by: Guy Zana Signed-off-by: Anthony PERARD --- Makefile.target |2 + hw/xen_common.h |3 + hw/xen

[Qemu-devel] [PATCH V6 11/11] pci: Do not check if a bus exist in pci_parse_devaddr.

2012-02-13 Thread Anthony PERARD
Actually, pci_parse_devaddr checks if the dom/bus of the PCI address exist. But this should be the jobs of a caller. In fact, the two callers of this function will try to retrieve the PCIBus related to the devaddr and return an error if they cannot. Signed-off-by: Anthony PERARD --- hw/pci.c |

[Qemu-devel] [PATCH V6 10/11] Introduce Xen PCI Passthrough, MSI (3/3)

2012-02-13 Thread Anthony PERARD
From: Jiang Yunhong A more complete history can be found here: git://xenbits.xensource.com/qemu-xen-unstable.git Signed-off-by: Jiang Yunhong Signed-off-by: Shan Haitao Signed-off-by: Anthony PERARD --- Makefile.target |1 + hw/apic-msidef.h |

[Qemu-devel] [PATCH V6 03/11] pci_regs: Add PCI_EXP_TYPE_PCIE_BRIDGE

2012-02-13 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- hw/pci_regs.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/pci_regs.h b/hw/pci_regs.h index 6b42515..56a404b 100644 --- a/hw/pci_regs.h +++ b/hw/pci_regs.h @@ -392,6 +392,7 @@ #define PCI_EXP_TYPE_UPSTREAM 0x5 /* Upstream Port

Re: [Qemu-devel] [PATCH 1/3] coroutine: adding sigaltstack method (.c source)

2012-02-13 Thread Andreas Färber
Am 13.02.2012 17:11, schrieb Alex Barcelo: > On Mon, Feb 13, 2012 at 16:57, Andreas Färber wrote: >> You should (need to?) use version 2.1 or later above then, too. You can >> then simply move this snippet up and drop the "Same license ..." line. > > I wanted to ask this, but it slipped my mind.

Re: [Qemu-devel] how could I analysis the trace log?

2012-02-13 Thread Stefan Hajnoczi
On Mon, Feb 13, 2012 at 3:12 PM, Andreas Färber wrote: > Hi, > > Am 12.02.2012 05:32, schrieb Wei Yang: >> I enable the trace function with --enable-trace-backend=simple and I >> create the event file like this >> g_realloc >> g_malloc >> >> Then I start the qemu with following command. >> ./i386-

[Qemu-devel] [PATCH V6 09/11] Introduce apic-msidef.h

2012-02-13 Thread Anthony PERARD
This patch move the msi definition from apic.c to apic-msidef.h. So it can be used also by other .c files. Signed-off-by: Anthony PERARD --- hw/apic-msidef.h | 28 hw/apic.c| 11 +-- 2 files changed, 29 insertions(+), 10 deletions(-) create mode

Re: [Qemu-devel] [PATCHv3 0/3] unicore32: add unicore32-linux-user support for qemu 0.14

2012-02-13 Thread Guan Xuetao
On Sat, 2012-02-11 at 14:11 +0100, Andreas Färber wrote: > Hello, > > Last year you added a unicore32 target to QEMU. The new files you added > in target-unicore32/ carry the following license notice: > > * This program is free software; you can redistribute it and/or modify > * it under the t

Re: [Qemu-devel] [PATCH] [m68k] Move helpers.h to helper.h

2012-02-13 Thread Andreas Färber
Am 13.02.2012 16:33, schrieb Lluís Vilanova: > Provides a file naming scheme consistent with other targets. > > Signed-off-by: Lluís Vilanova > --- > target-m68k/helper.c|2 +- > target-m68k/helper.h| 54 > +++ > target-m68k/helpers.h

Re: [Qemu-devel] [PATCH V6 11/11] pci: Do not check if a bus exist in pci_parse_devaddr.

2012-02-13 Thread Anthony PERARD
On Mon, 13 Feb 2012, Michael S. Tsirkin wrote: > On Mon, Feb 13, 2012 at 12:20:13PM +, Anthony PERARD wrote: > > Actually, pci_parse_devaddr checks if the dom/bus of the PCI address exist. > > But > > this should be the jobs of a caller. In fact, the two callers of this > > function > > will

[Qemu-devel] [PATCH V6 05/11] Introduce HostPCIDevice to access a pci device on the host.

2012-02-13 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- Makefile.target |3 + hw/host-pci-device.c | 278 ++ hw/host-pci-device.h | 75 ++ 3 files changed, 356 insertions(+), 0 deletions(-) create mode 100644 hw/host-pci-device.c create mode 100

Re: [Qemu-devel] [PATCH] [m68k] Move helpers.h to helper.h

2012-02-13 Thread Lluís Vilanova
Andreas Färber writes: > Am 13.02.2012 16:33, schrieb Lluís Vilanova: >> Provides a file naming scheme consistent with other targets. >> >> Signed-off-by: Lluís Vilanova >> --- >> target-m68k/helper.c|2 +- >> target-m68k/helper.h| 54 >>

[Qemu-devel] [PATCH v3 01/15] dma-helpers: make QEMUSGList target independent

2012-02-13 Thread Paolo Bonzini
scsi-disk will manage scatter/gather list, but it does not create single entries so it remains target-independent. Make QEMUSGList available to it. Signed-off-by: Paolo Bonzini --- dma.h | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/dma.h b/dma.h index a1

[Qemu-devel] [PATCH v3 00/15] SCSI s/g + SCSI migration + virtio-scsi

2012-02-13 Thread Paolo Bonzini
Here is v3 of the virtio-scsi driver. Changes are: - the virtio id is now 8, to fix a conflict in the virtio spec; - rebased for QOM; - changed the resid type to size_t following Stefan's advice; - fixed sense length (patch from Christian Hoff). The spec has been committed by Rusty (version 0

[Qemu-devel] [PATCH v3 05/15] scsi: pass residual amount to command_complete

2012-02-13 Thread Paolo Bonzini
With the upcoming sglist support, HBAs will not see any transfer_data call and will not have a way to detect short transfers. So pass the residual amount of data upon command completion. Signed-off-by: Paolo Bonzini --- v2->v3: fixed resid type (Stefan) hw/esp.c |3 ++- hw/

[Qemu-devel] [PATCH v3 10/15] scsi-disk: add migration support

2012-02-13 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 59 --- 1 files changed, 55 insertions(+), 4 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 0e4d6ad..4d7b4eb 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -111,12 +111,1

[Qemu-devel] [PATCH v3 13/15] virtio-scsi: add basic SCSI bus operation

2012-02-13 Thread Paolo Bonzini
Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- v2->v3: fixed sense length (Christian Hoff) hw/virtio-scsi.c | 110 +++-- 1 files changed, 97 insertions(+), 13 deletions(-) diff --git a/hw/virtio-scsi.c b/hw/virtio-scsi.c i

[Qemu-devel] [PATCH v3 04/15] ahci: use new DMA helpers

2012-02-13 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/ide/ahci.c | 82 + 1 files changed, 13 insertions(+), 69 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index c87a6ca..25ed844 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -426,55 +426,6 @

[Qemu-devel] [PATCH v3 12/15] virtio-scsi: Add basic request processing infrastructure

2012-02-13 Thread Paolo Bonzini
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- hw/virtio-scsi.c | 142 +- 1 files changed, 140 insertions(+), 2 deletions(-) diff --git a/hw/virtio-scsi.c b/hw/virtio-scsi

[Qemu-devel] [PATCH v3 14/15] virtio-scsi: process control queue requests

2012-02-13 Thread Paolo Bonzini
Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- hw/virtio-scsi.c | 125 ++--- 1 files changed, 117 insertions(+), 8 deletions(-) diff --git a/hw/virtio-scsi.c b/hw/virtio-scsi.c index 21264a1..7ad60ec 100644 --- a/hw/virtio-scsi.c +

Re: [Qemu-devel] [PATCH] [m68k] Move helpers.h to helper.h

2012-02-13 Thread Andreas Färber
Am 13.02.2012 18:01, schrieb Lluís Vilanova: > Andreas Färber writes: > >> Am 13.02.2012 16:33, schrieb Lluís Vilanova: >>> Provides a file naming scheme consistent with other targets. >>> >>> Signed-off-by: Lluís Vilanova >>> --- >>> target-m68k/helper.c|2 +- >>> target-m68k/helper.h

[Qemu-devel] [PATCH v3 03/15] dma-helpers: add accounting wrappers

2012-02-13 Thread Paolo Bonzini
The length of the transfer is already in the sglist, the wrapper simply fetches it. Signed-off-by: Paolo Bonzini --- dma-helpers.c |6 ++ dma.h |3 +++ 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/dma-helpers.c b/dma-helpers.c index f53a51f..a773489 100644 -

[Qemu-devel] [PATCH v3 02/15] dma-helpers: add dma_buf_read and dma_buf_write

2012-02-13 Thread Paolo Bonzini
These helpers do a full transfer from an in-memory buffer to target memory, with support for scatter/gather lists. It will be used to store the reply of an emulated command into a QEMUSGList provided by the adapter. Signed-off-by: Paolo Bonzini --- dma-helpers.c | 30 +

[Qemu-devel] [PATCH v3 08/15] scsi: add SCSIDevice vmstate definitions

2012-02-13 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/scsi-bus.c | 107 +++-- hw/scsi.h | 16 2 files changed, 120 insertions(+), 3 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index 817aa49..15841d0 100644 --- a/hw/scsi-bus.c +++ b/hw

[Qemu-devel] [PATCH v3 06/15] scsi: add scatter/gather functionality

2012-02-13 Thread Paolo Bonzini
Scatter/gather functionality uses the newly added DMA helpers. The device can choose between doing DMA itself, or calling scsi_req_data as usual, which will use the newly added DMA helpers to copy piecewise to/from the destination area(s). Signed-off-by: Paolo Bonzini --- hw/scsi-bus.c | 28 +

[Qemu-devel] [PATCH v3 07/15] scsi-disk: enable scatter/gather functionality

2012-02-13 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/scsi-bus.c |1 + hw/scsi-disk.c | 63 --- 2 files changed, 51 insertions(+), 13 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index 69cb3fc..817aa49 100644 --- a/hw/scsi-bus.c +++ b/hw/scsi-b

[Qemu-devel] [PATCH v3 09/15] scsi-generic: add migration support

2012-02-13 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/scsi-generic.c | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c index 4859212..cd62922 100644 --- a/hw/scsi-generic.c +++ b/hw/scsi-generic.c @@ -59,6 +59,28 @@ typedef struc

[Qemu-devel] [PATCH v3 11/15] virtio-scsi: Add virtio-scsi stub device

2012-02-13 Thread Paolo Bonzini
From: Stefan Hajnoczi Add a useless virtio SCSI HBA device: qemu -device virtio-scsi-pci Signed-off-by: Stefan Hajnoczi Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- v2->v3: changed virtio id Makefile.target |1 + default-configs/pci.mak

[Qemu-devel] [PATCH v3 15/15] virtio-scsi: add migration support

2012-02-13 Thread Paolo Bonzini
Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- hw/virtio-scsi.c | 50 +- 1 files changed, 49 insertions(+), 1 deletions(-) diff --git a/hw/virtio-scsi.c b/hw/virtio-scsi.c index 7ad60ec..f5cecfc 100644 --- a/hw/virtio-scsi.c +++ b

Re: [Qemu-devel] [PATCH v2 5/8] kvmvapic: Introduce TPR access optimization for Windows guests

2012-02-13 Thread Blue Swirl
On Mon, Feb 13, 2012 at 10:16, Jan Kiszka wrote: > On 2012-02-11 16:25, Blue Swirl wrote: >> On Fri, Feb 10, 2012 at 18:31, Jan Kiszka wrote: >>> This enables acceleration for MMIO-based TPR registers accesses of >>> 32-bit Windows guest systems. It is mostly useful with KVM enabled, >>> either o

Re: [Qemu-devel] [PATCH v2 5/8] kvmvapic: Introduce TPR access optimization for Windows guests

2012-02-13 Thread Gleb Natapov
On Mon, Feb 13, 2012 at 06:50:08PM +, Blue Swirl wrote: > On Mon, Feb 13, 2012 at 10:16, Jan Kiszka wrote: > > On 2012-02-11 16:25, Blue Swirl wrote: > >> On Fri, Feb 10, 2012 at 18:31, Jan Kiszka wrote: > >>> This enables acceleration for MMIO-based TPR registers accesses of > >>> 32-bit Win

Re: [Qemu-devel] [PATCH v2 5/8] kvmvapic: Introduce TPR access optimization for Windows guests

2012-02-13 Thread Jan Kiszka
On 2012-02-13 19:50, Blue Swirl wrote: > On Mon, Feb 13, 2012 at 10:16, Jan Kiszka wrote: >> On 2012-02-11 16:25, Blue Swirl wrote: >>> On Fri, Feb 10, 2012 at 18:31, Jan Kiszka wrote: This enables acceleration for MMIO-based TPR registers accesses of 32-bit Windows guest systems. It is

[Qemu-devel] [PATCH] trace: fix documentation ./configure line

2012-02-13 Thread Stefan Hajnoczi
The quickstart documentation still shows the old ./configure --trace-backend= syntax. This was changed in commit 74242e0f7f4bf3d85fe28b939a3d66827fe653e5 to be more like autoconf using --enable-trace-backend=. Signed-off-by: Stefan Hajnoczi --- docs/tracing.txt |2 +- 1 files changed, 1 ins

Re: [Qemu-devel] slirp-related crash

2012-02-13 Thread Jan Kiszka
On 2012-02-13 16:27, Zhi Yong Wu wrote: > On Mon, Feb 13, 2012 at 4:24 AM, Jan Kiszka wrote: >> On 2012-02-12 19:34, Michael S. Tsirkin wrote: >>> It seems somewhat easy to crash qemu with slirp if we queue multiple >>> packets. >>> I didn't investigate further yet so I don't know if this >>> is

  1   2   >