Re: [Qemu-devel] [PATCH] fixup e432cef9 (aio help text): end sentences with periods

2012-01-25 Thread Markus Armbruster
Patch looks good, cc'ing qemu-trivial. Laszlo Ersek writes: > (Please keep me CC'd on any followup; I'm not subscribed. Thanks.) Best to put such notes below the --- line, so they don't get immortalized in the commit log. > Signed-off-by: Laszlo Ersek > --- > qemu-io.c |4 ++-- > 1 files

Re: [Qemu-devel] [PATCH 27/28] sysbus: apic: ioapic: convert to QEMU Object Model

2012-01-25 Thread Andreas Färber
Am 25.01.2012 00:03, schrieb Anthony Liguori: > On 01/24/2012 04:06 PM, Jan Kiszka wrote: >> On 2012-01-24 22:53, Anthony Liguori wrote: >>> But I don't like this. The problem is that the declarative syntax we >>> have doesn't distinguish between "not-specified" and >>> "zero-initialized". >> >> T

Re: [Qemu-devel] [PATCH 27/28] sysbus: apic: ioapic: convert to QEMU Object Model

2012-01-25 Thread Jan Kiszka
On 2012-01-25 00:03, Anthony Liguori wrote: > They're exactly the same size (16 lines). If you embed TypeInfo into > DeviceTypeInfo, and introduce a Device specific type registration > function, then you could do: > > static DeviceTypeInfo my_device_type_info = { > .type.name = TYPE_MY_DEVICE

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-25 Thread Kevin Wolf
Am 24.01.2012 21:03, schrieb Eric Blake: > On 01/24/2012 11:16 AM, Luiz Capitulino wrote: >> Libvirt wants to be notified when the guest ejects a medium, so that >> it can update its view of the guest. >> >> This code has been originally written by Daniel Berrange. It adds >> the event to IDE and S

Re: [Qemu-devel] [PATCH] usb-redir: Add the posibility to filter out certain devices from redirecion

2012-01-25 Thread Hans de Goede
Hi, On 01/23/2012 03:51 PM, Gerd Hoffmann wrote: On 01/13/12 08:43, Gerd Hoffmann wrote: On 01/12/12 17:31, Hans de Goede wrote: This patch adds the posibility to filter out certain devices from redirecion. To use this pass the filter property to -device usb-redir. The filter property takes a

[Qemu-devel] [PATCH] usb-redir: Add the posibility to filter out certain devices from redirecion

2012-01-25 Thread Hans de Goede
This patch adds the posibility to filter out certain devices from redirecion. To use this pass the filter property to -device usb-redir. The filter property takes a string consisting of filter rules, the format for a rule is: -1 can be used to allow any value for a field. Muliple rules can

Re: [Qemu-devel] [PATCH 27/28] sysbus: apic: ioapic: convert to QEMU Object Model

2012-01-25 Thread Paolo Bonzini
On 01/25/2012 09:37 AM, Jan Kiszka wrote: > They're exactly the same size (16 lines). If you embed TypeInfo into > DeviceTypeInfo, and introduce a Device specific type registration > function, then you could do: > > static DeviceTypeInfo my_device_type_info = { > .type.name = TYPE_MY_D

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-25 Thread Markus Armbruster
Luiz Capitulino writes: > Libvirt wants to be notified when the guest ejects a medium, so that > it can update its view of the guest. > > This code has been originally written by Daniel Berrange. It adds > the event to IDE and SCSI emulation. > > Please, note that this only covers guest initiated

[Qemu-devel] [Bug 921208] Re: win7/x64 installer hangs on startup with 0x0000005d.

2012-01-25 Thread Paolo Bonzini
Please try "-cpu kvm64" (yes, even if you are using TCG). -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/921208 Title: win7/x64 installer hangs on startup with 0x005d. Status in QEMU: New Bu

Re: [Qemu-devel] [PATCH 27/28] sysbus: apic: ioapic: convert to QEMU Object Model

2012-01-25 Thread Jan Kiszka
On 2012-01-25 11:15, Paolo Bonzini wrote: > On 01/25/2012 09:37 AM, Jan Kiszka wrote: >>> > They're exactly the same size (16 lines). If you embed TypeInfo into >>> > DeviceTypeInfo, and introduce a Device specific type registration >>> > function, then you could do: >>> > >>> > static DeviceT

[Qemu-devel] [PATCH v4 0/4] Improve SD controllers emulation

2012-01-25 Thread Mitsyanko Igor
Changelog v3->v4 - PATCH 1/3 rebased to current master; - Fixed .start field use during vmstate save/load; - added get_bufsize() NULL pointer check; - patches 2-4 merged into patches 2-3 v2->v3: - PATCH 2/3 splitted into smaller patches 2-4/5. - SDState structure rearrengment dropped. v1->

[Qemu-devel] [PATCH v4 1/4] vmstate: introduce get_bufsize entry in VMStateField

2012-01-25 Thread Mitsyanko Igor
New get_bufsize field in VMStateField is supposed to help us easily add save/restore support of dynamically allocated buffers in device's states. There are some cases when information about size of dynamically allocated buffer is already presented in specific device's state structure, but in such

Re: [Qemu-devel] [PATCH 27/28] sysbus: apic: ioapic: convert to QEMU Object Model

2012-01-25 Thread Paolo Bonzini
On 01/25/2012 11:27 AM, Jan Kiszka wrote: > I agree with Anthony, this would get really ugly where you are calling > the functions and doing the class initialization. I think we need to try it first. There is a lot of repetition, and that gets boring at beat and ugly at worst when doing it fo

[Qemu-devel] [PATCH v4 3/4] hw/sd.c: convert SD state binary variables to bool

2012-01-25 Thread Mitsyanko Igor
SDstate members wp_switch, wp_groups, spi, expecting_acmd and enable are in fact binary variables s converting them to type "bool" makes code a little bit more clear. API modified to reflect new variables types. Signed-off-by: Mitsyanko Igor --- hw/sd.c | 42 +--

[Qemu-devel] [PATCH v4 2/4] hw/sd.c: add SD card save/load support

2012-01-25 Thread Mitsyanko Igor
This patch updates SD card emulation to support save/load of card's state. Signed-off-by: Mitsyanko Igor --- hw/sd.c | 102 +-- 1 files changed, 73 insertions(+), 29 deletions(-) diff --git a/hw/sd.c b/hw/sd.c index 07eb263..bfe7f58 1

[Qemu-devel] commit 67feec6ed854b3618b37ccf050b90192cbb96e0f breaks compilation of hw/pci.c

2012-01-25 Thread erik . rull
Hi all, from the qemu-kvm master I did some bisectioning because I cannot compile it. My error is: In file included from /home/erik/qemu-kvm/hw/pci.c:36: /qmp-commands.h:3: error: expected identifier or '(' before '{' token /qmp-commands.h:10: error: expected identifier or '(' before ',' token /

Re: [Qemu-devel] commit 67feec6ed854b3618b37ccf050b90192cbb96e0f breaks compilation of hw/pci.c

2012-01-25 Thread Gleb Natapov
On Wed, Jan 25, 2012 at 12:22:51PM +0100, erik.r...@rdsoftware.de wrote: > Hi all, > > from the qemu-kvm master I did some bisectioning because I cannot compile it. > I got the same error because of some stale .h file. Removing it resolved the problem, but I do not remember what was the file exac

Re: [Qemu-devel] qemu-kvm upstreaming: Do we want -kvm-shadow-memory semantics?

2012-01-25 Thread Avi Kivity
On 01/19/2012 07:39 PM, Jan Kiszka wrote: > On 2012-01-19 18:28, Marcelo Tosatti wrote: > > On Thu, Jan 19, 2012 at 01:46:39PM +0100, Jan Kiszka wrote: > >> Hi again, > >> > >> do we need some KVM knob comparable to qemu-kvm's -kvm-shadow-memory in > >> upstream? > >> > >> If yes: The underlying IO

Re: [Qemu-devel] [Xen-devel] [PATCH v3 5/6] xen: record physmap changes to xenstore

2012-01-25 Thread Avi Kivity
On 01/19/2012 04:16 PM, Stefano Stabellini wrote: > > > > If you are migrating to a newer qemu then the could in > > principal change, I think. > > Not unless the implementation of qemu_ram_alloc_from_ptr or > find_ram_offset change, but these are core qemu functions. Both of these functions wil

Re: [Qemu-devel] git bisect results

2012-01-25 Thread erik . rull
Hi Jan, This little change fixes my problem with the usb-tablet update rate. Can you please verify if this has some side effects? If not, can you post a real patch? I don't know how to handle the whole patching and committing stuff exactly. Thanks. Erik -- diff --git a/ui/sdl.c b/ui/sdl.c i

Re: [Qemu-devel] [PATCH v6 02/11] Add uleb encoding/decoding functions

2012-01-25 Thread Avi Kivity
On 01/25/2012 01:26 PM, Orit Wasserman wrote: > Implement Unsigned Little Endian Base 128. > > > +/* ULEB128 */ > +int uleb128_encode_small(uint8_t *out, uint32_t n); > +int uleb128_decode_small(const uint8 *in, uint32_t *n); > + > #endif > diff --git a/savevm.c b/savevm.c > index 80be1ff..304db

Re: [Qemu-devel] [PATCH v6 00/11] XBRLE delta for live migration of large memory app

2012-01-25 Thread Avi Kivity
On 01/25/2012 01:26 PM, Orit Wasserman wrote: > The run length is encoded using ULEB128 (http://en.wikipedia.org/wiki/LEB128) > > page = zrun >| zrun nzrun >| zrun nzrun page > > zrun = length > > nzrun = length byte... > > length = uleb128 encoded integer > We can improve this by

Re: [Qemu-devel] [Xen-devel] [PATCH v3 5/6] xen: record physmap changes to xenstore

2012-01-25 Thread Stefano Stabellini
On Wed, 25 Jan 2012, Avi Kivity wrote: > On 01/19/2012 04:16 PM, Stefano Stabellini wrote: > > > > > > If you are migrating to a newer qemu then the could in > > > principal change, I think. > > > > Not unless the implementation of qemu_ram_alloc_from_ptr or > > find_ram_offset change, but these

Re: [Qemu-devel] qemu-kvm upstreaming: Do we want -kvm-shadow-memory semantics?

2012-01-25 Thread Jan Kiszka
On 2012-01-25 12:38, Avi Kivity wrote: > On 01/19/2012 07:39 PM, Jan Kiszka wrote: >> On 2012-01-19 18:28, Marcelo Tosatti wrote: >>> On Thu, Jan 19, 2012 at 01:46:39PM +0100, Jan Kiszka wrote: Hi again, do we need some KVM knob comparable to qemu-kvm's -kvm-shadow-memory in ups

Re: [Qemu-devel] [Xen-devel] [PATCH v3 5/6] xen: record physmap changes to xenstore

2012-01-25 Thread Avi Kivity
On 01/25/2012 01:55 PM, Stefano Stabellini wrote: > > > > Match on just the MemoryRegion (and match on the object itself, not the > > name; see xen_register_framebuffer()). > > I agree that would be ideal, but how can that work across save/restore? > Unless we introduce some other kind of identifi

Re: [Qemu-devel] qemu-kvm upstreaming: Do we want -kvm-shadow-memory semantics?

2012-01-25 Thread Avi Kivity
On 01/25/2012 01:57 PM, Jan Kiszka wrote: > > > > -kvm-shadow-memory is becoming less meaningful for ordinary workloads > > since everything uses TDP these days. It's still meaningful for testing > > (forcing aggressive cache replacement), or perhaps nested virtualization. > > So, is it used for

Re: [Qemu-devel] [PATCH 27/28] sysbus: apic: ioapic: convert to QEMU Object Model

2012-01-25 Thread Avi Kivity
On 01/25/2012 10:33 AM, Andreas Färber wrote: > > > > There is a declarative solution for this that I know of, a C++ class > > definition ;-) > > So what's the reason not to go with one of the object-oriented, > C-compatible languages GCC supports, like C++ or Objective-C/C++? > (Objective-C has n

Re: [Qemu-devel] qemu-kvm upstreaming: Do we want -kvm-shadow-memory semantics?

2012-01-25 Thread Jan Kiszka
On 2012-01-25 13:04, Avi Kivity wrote: > On 01/25/2012 01:57 PM, Jan Kiszka wrote: >>> >>> -kvm-shadow-memory is becoming less meaningful for ordinary workloads >>> since everything uses TDP these days. It's still meaningful for testing >>> (forcing aggressive cache replacement), or perhaps nested

Re: [Qemu-devel] qemu-kvm upstreaming: Do we want -kvm-shadow-memory semantics?

2012-01-25 Thread Avi Kivity
On 01/25/2012 02:10 PM, Jan Kiszka wrote: > > > >> Would a machine option > >> "kvm_shadow_memory=n" be desirable? > > > > Not sure, this is a host option, not a guest option. Machine options > > should be guest-visible. > > machine options are not guest visible. Basically, this options falls >

Re: [Qemu-devel] qemu-kvm upstreaming: Do we want -kvm-shadow-memory semantics?

2012-01-25 Thread Jan Kiszka
On 2012-01-25 13:15, Avi Kivity wrote: > On 01/25/2012 02:10 PM, Jan Kiszka wrote: >>> Would a machine option "kvm_shadow_memory=n" be desirable? >>> >>> Not sure, this is a host option, not a guest option. Machine options >>> should be guest-visible. >> >> machine options are not guest

Re: [Qemu-devel] [PATCH v2 2/9] Add Cortex-A15 CPU definition

2012-01-25 Thread Andreas Färber
Am 24.01.2012 13:39, schrieb Peter Maydell: > Add a definition of a Cortex-A15 CPU. Note that for the moment we do > not implement any of: > * Large Physical Address Extensions (LPAE) > * Virtualization Extensions > * Generic Timer > * TrustZone (this is also true of our existing Cortex-A9 mode

Re: [Qemu-devel] qemu-kvm upstreaming: Do we want -kvm-shadow-memory semantics?

2012-01-25 Thread Avi Kivity
On 01/25/2012 02:26 PM, Jan Kiszka wrote: > On 2012-01-25 13:15, Avi Kivity wrote: > > On 01/25/2012 02:10 PM, Jan Kiszka wrote: > >>> > Would a machine option > "kvm_shadow_memory=n" be desirable? > >>> > >>> Not sure, this is a host option, not a guest option. Machine options > >>> sho

Re: [Qemu-devel] [PATCH 26/28] pci: convert to QEMU Object Model

2012-01-25 Thread Michael S. Tsirkin
On Tue, Jan 24, 2012 at 01:33:18PM -0600, Anthony Liguori wrote: > diff --git a/hw/ac97.c b/hw/ac97.c > index 03be99b..33b85f5 100644 > --- a/hw/ac97.c > +++ b/hw/ac97.c > @@ -1344,21 +1344,30 @@ int ac97_init (PCIBus *bus) > return 0; > } > > -static PCIDeviceInfo ac97_info = { > -.qde

Re: [Qemu-devel] [PATCH 03/28] pci: call reset unconditionally

2012-01-25 Thread Michael S. Tsirkin
On Tue, Jan 24, 2012 at 01:32:55PM -0600, Anthony Liguori wrote: > Because now all PCI devices are converted to qdev. > > Signed-off-by: Anthony Liguori Finally! > --- > hw/pci.c |7 ++- > 1 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/hw/pci.c b/hw/pci.c > index 54

Re: [Qemu-devel] [PATCH v2 1/9] Add dummy implementation of generic timer cp15 registers

2012-01-25 Thread Andreas Färber
Am 24.01.2012 13:39, schrieb Peter Maydell: > Add a dummy implementation of the cp15 registers for the generic > timer (found in the Cortex-A15), just sufficient for Linux to > decide that it can't use it. This requires at least CNTP_CTL and > CNTFRQ to be implemented as RAZ/WI; we RAZ/WI all of c1

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-25 Thread Luiz Capitulino
On Wed, 25 Jan 2012 09:41:20 +0100 Kevin Wolf wrote: > Am 24.01.2012 21:03, schrieb Eric Blake: > > On 01/24/2012 11:16 AM, Luiz Capitulino wrote: > >> Libvirt wants to be notified when the guest ejects a medium, so that > >> it can update its view of the guest. > >> > >> This code has been origi

Re: [Qemu-devel] [RFC/PATCH] Fix guest OS panic when 64bit BAR is present

2012-01-25 Thread Michael S. Tsirkin
On Wed, Jan 25, 2012 at 06:46:03PM +1300, Alexey Korolev wrote: > Hi, > In this post > http://lists.gnu.org/archive/html/qemu-devel/2011-12/msg03171.html I've > mentioned about the issues when 64Bit PCI BAR is present and 32bit > address range is selected for it. > The issue affects all recent qem

Re: [Qemu-devel] [PATCH v2 1/9] Add dummy implementation of generic timer cp15 registers

2012-01-25 Thread Peter Maydell
On 25 January 2012 12:37, Andreas Färber wrote: > Am 24.01.2012 13:39, schrieb Peter Maydell: >> +    ARM_FEATURE_GENERICTIMER, > > Personally I would've preferred GENERIC_TIMER (we have ARM_DIV, > THUMB_DIV as counterexamples), but no strong objection here. I think I agree. -- PMM

[Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-25 Thread Stefano Stabellini
Hi all, this is the fourth version of the Xen save/restore patch series. We have been discussing this issue for quite a while on #qemu and qemu-devel: http://marc.info/?l=qemu-devel&m=132346828427314&w=2 http://marc.info/?l=qemu-devel&m=132377734605464&w=2 The principal changes in the this vers

[Qemu-devel] [PATCH v4 1/6] cirrus_vga: do not reset videoram

2012-01-25 Thread Stefano Stabellini
There is no need to set the videoram to 0xff in cirrus_reset, because it is the BIOS' job. Signed-off-by: Stefano Stabellini --- hw/cirrus_vga.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index f7b1d3d..5564478 100644 --- a/hw/ci

[Qemu-devel] [PATCH v4 5/6] Set runstate to INMIGRATE earlier

2012-01-25 Thread Stefano Stabellini
Set runstate to RUN_STATE_INMIGRATE as soon as we can on resume. Signed-off-by: Stefano Stabellini --- vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index c3a155f..9b9a4fb 100644 --- a/vl.c +++ b/vl.c @@ -2972,6 +2972,7 @@ int main(int argc, char **ar

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-25 Thread Kevin Wolf
Am 25.01.2012 13:42, schrieb Luiz Capitulino: > On Wed, 25 Jan 2012 09:41:20 +0100 > Kevin Wolf wrote: > >> Am 24.01.2012 21:03, schrieb Eric Blake: >>> On 01/24/2012 11:16 AM, Luiz Capitulino wrote: Libvirt wants to be notified when the guest ejects a medium, so that it can update its

[Qemu-devel] [PATCH v4 4/6] xen mapcache: check if memory region has moved.

2012-01-25 Thread Stefano Stabellini
From: Anthony PERARD This patch changes the xen_map_cache behavior. Before trying to map a guest addr, mapcache will look into the list of range of address that have been moved (physmap/set_memory). There is currently one memory space like this, the vram, "moved" from were it's allocated to were

[Qemu-devel] [PATCH v4 2/6] Introduce "save_devices"

2012-01-25 Thread Stefano Stabellini
- add an "is_ram" flag to SaveStateEntry; - add an "is_ram" parameter to register_savevm_live; - introduce a "save_devices" monitor command that can be used to save the state of non-ram devices. Signed-off-by: Stefano Stabellini --- block-migration.c |2 +- hmp-commands.hx | 14 +++

Re: [Qemu-devel] [PATCH 03/28] pci: call reset unconditionally

2012-01-25 Thread Anthony Liguori
On 01/25/2012 06:42 AM, Michael S. Tsirkin wrote: On Tue, Jan 24, 2012 at 01:32:55PM -0600, Anthony Liguori wrote: Because now all PCI devices are converted to qdev. Signed-off-by: Anthony Liguori Finally! Yeah, I hope there's more cleanup that can come out of this. Regards, Anthony Liguo

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-25 Thread Luiz Capitulino
On Wed, 25 Jan 2012 11:19:59 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > Libvirt wants to be notified when the guest ejects a medium, so that > > it can update its view of the guest. > > > > This code has been originally written by Daniel Berrange. It adds > > the event to ID

[Qemu-devel] [PATCH v4 6/6] xen: do not allocate RAM during INMIGRATE runstate

2012-01-25 Thread Stefano Stabellini
From: Anthony PERARD Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- xen-all.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/xen-all.c b/xen-all.c index bb66c82..5b10d0c 100644 --- a/xen-all.c +++ b/xen-all.c @@ -190,6 +190,14 @@ void xen_r

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-25 Thread Paolo Bonzini
On 01/25/2012 02:23 PM, Kevin Wolf wrote: > > > Please, note that this only covers guest initiated ejects, that's, > > > the QMP/HMP commands 'eject' and 'change' are not covered. > > > > What's the reason for this behaviour? It feels inconsistent. > > I don't think it's inconsistent because

[Qemu-devel] [PATCH 0/2] Cortex-A15 support: target-arm patches

2012-01-25 Thread Peter Maydell
Just a retransmit of the target-arm parts of the Cortex-A15 series, with the tiny change of s/ARM_FEATURE_GENERICTIMER/ARM_FEATURE_GENERIC_TIMER/ and no other changes from the versions in v2 of the vexpress-a15 patchset. Peter Maydell (2): Add dummy implementation of generic timer cp15 register

Re: [Qemu-devel] [PATCH 26/28] pci: convert to QEMU Object Model

2012-01-25 Thread Anthony Liguori
On 01/25/2012 06:41 AM, Michael S. Tsirkin wrote: On Tue, Jan 24, 2012 at 01:33:18PM -0600, Anthony Liguori wrote: diff --git a/hw/ac97.c b/hw/ac97.c index 03be99b..33b85f5 100644 --- a/hw/ac97.c +++ b/hw/ac97.c @@ -1344,21 +1344,30 @@ int ac97_init (PCIBus *bus) return 0; } -static PCI

[Qemu-devel] [PATCH v4 3/6] xen: record physmap changes to xenstore

2012-01-25 Thread Stefano Stabellini
Write to xenstore any physmap changes so that the hypervisor can be aware of them. Read physmap changes from xenstore on boot. Signed-off-by: Stefano Stabellini --- xen-all.c | 78 - 1 files changed, 77 insertions(+), 1 deletions(-)

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-25 Thread Kevin Wolf
Am 25.01.2012 14:32, schrieb Paolo Bonzini: > On 01/25/2012 02:23 PM, Kevin Wolf wrote: > Please, note that this only covers guest initiated ejects, that's, > the QMP/HMP commands 'eject' and 'change' are not covered. What's the reason for this behaviour? It feels inconsistent.

[Qemu-devel] [PATCH 2/2] Add Cortex-A15 CPU definition

2012-01-25 Thread Peter Maydell
Add a definition of a Cortex-A15 CPU. Note that for the moment we do not implement any of: * Large Physical Address Extensions (LPAE) * Virtualization Extensions * Generic Timer * TrustZone (this is also true of our existing Cortex-A9 model, etc) This CPU model is sufficient to boot a Linux ke

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-25 Thread Luiz Capitulino
On Wed, 25 Jan 2012 14:23:55 +0100 Kevin Wolf wrote: > >> Also, I seem to remember that once we had discussed some kind of a "tray > >> status (open/closed) changed" event, which would be more generic. > > > > Yes, but my old series got complex and way beyond the original event. If we > > decide

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-25 Thread Markus Armbruster
Paolo Bonzini writes: > On 01/25/2012 02:23 PM, Kevin Wolf wrote: >> > > > Please, note that this only covers guest initiated ejects, that's, >> > > > the QMP/HMP commands 'eject' and 'change' are not covered. >> > > >> > > What's the reason for this behaviour? It feels inconsistent. >> > >> >

[Qemu-devel] [PATCH 1/2] Add dummy implementation of generic timer cp15 registers

2012-01-25 Thread Peter Maydell
Add a dummy implementation of the cp15 registers for the generic timer (found in the Cortex-A15), just sufficient for Linux to decide that it can't use it. This requires at least CNTP_CTL and CNTFRQ to be implemented as RAZ/WI; we RAZ/WI all of c14. Signed-off-by: Peter Maydell --- target-arm/cp

Re: [Qemu-devel] [PATCH 27/28] sysbus: apic: ioapic: convert to QEMU Object Model

2012-01-25 Thread Anthony Liguori
On 01/25/2012 02:37 AM, Jan Kiszka wrote: On 2012-01-25 00:03, Anthony Liguori wrote: They're exactly the same size (16 lines). If you embed TypeInfo into DeviceTypeInfo, and introduce a Device specific type registration function, then you could do: static DeviceTypeInfo my_device_type_info =

Re: [Qemu-devel] [PATCH 1/2] Add dummy implementation of generic timer cp15 registers

2012-01-25 Thread Andreas Färber
Am 25.01.2012 14:32, schrieb Peter Maydell: > Add a dummy implementation of the cp15 registers for the generic > timer (found in the Cortex-A15), just sufficient for Linux to > decide that it can't use it. This requires at least CNTP_CTL and > CNTFRQ to be implemented as RAZ/WI; we RAZ/WI all of c1

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-25 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 25 Jan 2012 11:19:59 +0100 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > Libvirt wants to be notified when the guest ejects a medium, so that >> > it can update its view of the guest. >> > >> > This code has been originally written by Daniel

[Qemu-devel] Block-Migration eats my memory

2012-01-25 Thread David Weber
Hi, we are trying to upgrade our systems from kvm 0.14 (Ubuntu 11.04) to 1.0 (Ubuntu 12.04). Everything works fine except block-migration. When startet, the kvm process allocates the size of the image as memory, which of course leads to an oom an large machines. I tried to debug with valgrind

Re: [Qemu-devel] git bisect results

2012-01-25 Thread Jan Kiszka
On 2012-01-25 12:48, erik.r...@rdsoftware.de wrote: > Hi Jan, You should CC me then... :) > > This little change fixes my problem with the usb-tablet update rate. > > Can you please verify if this has some side effects? Surely as it disables in general valid code, namely the auto-grabbing feat

Re: [Qemu-devel] [PATCH 1/2] Add dummy implementation of generic timer cp15 registers

2012-01-25 Thread Peter Maydell
On 25 January 2012 14:01, Andreas Färber wrote: > Am 25.01.2012 14:32, schrieb Peter Maydell: >> Add a dummy implementation of the cp15 registers for the generic >> timer (found in the Cortex-A15), just sufficient for Linux to >> decide that it can't use it. This requires at least CNTP_CTL and >>

Re: [Qemu-devel] [PATCH 27/28] sysbus: apic: ioapic: convert to QEMU Object Model

2012-01-25 Thread Jan Kiszka
On 2012-01-25 15:00, Anthony Liguori wrote: > On 01/25/2012 02:37 AM, Jan Kiszka wrote: >> On 2012-01-25 00:03, Anthony Liguori wrote: >>> They're exactly the same size (16 lines). If you embed TypeInfo into >>> DeviceTypeInfo, and introduce a Device specific type registration >>> function, then y

[Qemu-devel] TCG register allocator

2012-01-25 Thread Xin Tong
I am wondering how tcg reg alloc works. Specifically, how do i reserve a register only for one specific purpose. R14 on tcg i386 is reserved to point to the cpustate strcuture. it is assigned in the prologue, but what code makes sure that it is not clobbered in the middle of a TB ? Thanks Xin

Re: [Qemu-devel] [PATCH 27/28] sysbus: apic: ioapic: convert to QEMU Object Model

2012-01-25 Thread Anthony Liguori
On 01/25/2012 02:33 AM, Andreas Färber wrote: Am 25.01.2012 00:03, schrieb Anthony Liguori: On 01/24/2012 04:06 PM, Jan Kiszka wrote: On 2012-01-24 22:53, Anthony Liguori wrote: But I don't like this. The problem is that the declarative syntax we have doesn't distinguish between "not-specifie

Re: [Qemu-devel] [PATCH 27/28] sysbus: apic: ioapic: convert to QEMU Object Model

2012-01-25 Thread Anthony Liguori
On 01/25/2012 08:23 AM, Jan Kiszka wrote: On 2012-01-25 15:00, Anthony Liguori wrote: On 01/25/2012 02:37 AM, Jan Kiszka wrote: On 2012-01-25 00:03, Anthony Liguori wrote: They're exactly the same size (16 lines). If you embed TypeInfo into DeviceTypeInfo, and introduce a Device specific type

Re: [Qemu-devel] [Android-virt] [PATCH 02/12] arm: make the number of GIC interrupts configurable

2012-01-25 Thread Peter Maydell
On 24 January 2012 08:42, Rusty Russell wrote: > On Fri, 13 Jan 2012 20:52:39 +, Peter Maydell > wrote: >> From: Mark Langsdorf >> >> Increase the maximum number of GIC interrupts for a9mp and a11mp to 1020, >> and create a configurable property for each defaulting to 96 and 64 >> (respecti

Re: [Qemu-devel] TCG register allocator

2012-01-25 Thread Peter Maydell
On 25 January 2012 14:24, Xin Tong wrote: > I am wondering how tcg reg alloc works. Specifically, how do i reserve > a register only for one specific purpose. R14 on tcg i386 is reserved > to point to the cpustate strcuture.  it is assigned in the prologue, > but what code makes sure that it is no

Re: [Qemu-devel] [PATCH 27/28] sysbus: apic: ioapic: convert to QEMU Object Model

2012-01-25 Thread Andreas Färber
Am 25.01.2012 15:40, schrieb Anthony Liguori: > On 01/25/2012 08:23 AM, Jan Kiszka wrote: >> On 2012-01-25 15:00, Anthony Liguori wrote: >>> On 01/25/2012 02:37 AM, Jan Kiszka wrote: On 2012-01-25 00:03, Anthony Liguori wrote: > They're exactly the same size (16 lines). If you embed TypeI

[Qemu-devel] [PULL 0/6] qemu-ga queue and qemu-tool fixes

2012-01-25 Thread Michael Roth
This pull adds 2 RPCs (guest-suspend and guest-set-support-level) to qemu-ga and some includes fixes/workarounds for building tools on Windows. The following changes since commit 5b4448d27d7c6ff6e18a1edc8245cb1db783e37c: Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2012-01-2

[Qemu-devel] [PATCH 1/6] main-loop: Fix SetEvent() on uninitialized handle on win32

2012-01-25 Thread Michael Roth
The __attribute__((constructor)) init_main_loop() automatically get called if qemu-tool.o is linked in. On win32, this leads to a qemu_notify_event() call which attempts to SetEvent() on a HANDLE that won't be initialized until qemu_init_main_loop() is manually called, breaking qemu-tools.o program

[Qemu-devel] [PATCH 5/6] qemu-ga: set O_NONBLOCK for serial channels

2012-01-25 Thread Michael Roth
From: Luiz Capitulino This fixes a bug when using -m isa-serial where qemu-ga will hang on a read()'s when communicating to the host via isa-serial. Original fix by Michael Roth. Signed-off-by: Luiz Capitulino Signed-off-by: Michael Roth --- qemu-ga.c |2 +- 1 files changed, 1 insertions

[Qemu-devel] [PATCH 6/6] qemu-ga: Add the guest-suspend command

2012-01-25 Thread Michael Roth
From: Luiz Capitulino The guest-suspend command supports three modes: o hibernate (suspend to disk) o sleep (suspend to ram) o hybrid(save RAM contents to disk, but suspend instead of powering off) Before trying to suspend, the command queries the guest in order to know

[Qemu-devel] [PATCH 1/5] target-arm: Fix implementation of TLB invalidate operations

2012-01-25 Thread Peter Maydell
Fix some bugs in the implementation of the TLB invalidate operations on ARM: * the 'invalidate all' op was not passing flush_global=1 to tlb_flush(); this doesn't have a practical effect since tlb_flush() currently ignores that argument, but is semantically incorrect * 'invalidate by add

[Qemu-devel] [PATCH 2/5] target-arm/helper.c: Don't assume softfloat int32 is 32 bits only

2012-01-25 Thread Peter Maydell
In the helper routines for VCVT float-to-int conversions, add an explicit cast rather than relying on the softfloat int32 type being exactly 32 bits wide (which it is not guaranteed to be). Without this, if the softfloat type was 64 bits wide we would get zero-extension of the 32 bit value from the

Re: [Qemu-devel] [PATCH 27/28] sysbus: apic: ioapic: convert to QEMU Object Model

2012-01-25 Thread Eric Blake
On 01/25/2012 07:40 AM, Anthony Liguori wrote: >>> >>> (void *) isn't compatible with integers or function pointers (at least >>> not in a portable way). > > I don't see how they can be compatible since on some platforms > sizeof(void (*)(void)) != sizeof(void *). C99 says they are not required t

Re: [Qemu-devel] [RFC/PATCH] Fix guest OS panic when 64bit BAR is present

2012-01-25 Thread Michael S. Tsirkin
On Wed, Jan 25, 2012 at 06:46:03PM +1300, Alexey Korolev wrote: > Hi, > In this post > http://lists.gnu.org/archive/html/qemu-devel/2011-12/msg03171.html I've > mentioned about the issues when 64Bit PCI BAR is present and 32bit > address range is selected for it. > The issue affects all recent qem

Re: [Qemu-devel] TCG register allocator

2012-01-25 Thread Xin Tong
I tried to reserve a register in target-i386 with this code target-i386/translate.ctb_env = tcg_global_reg_new_ptr(TCG_AREG1, "env"); i386/tcg-target.h #define TCG_AREG1 TCG_REG_R13 i386/tcg-target.c tcg_out_movi(s, TCG_TYPE_PTR, TCG_AREG1, args[0]); But when i looked into t

Re: [Qemu-devel] TCG register allocator

2012-01-25 Thread Peter Maydell
On 25 January 2012 15:42, Xin Tong wrote: > I tried to reserve a register in target-i386 with this code > > target-i386/translate.c    tb_env = tcg_global_reg_new_ptr(TCG_AREG1, "env"); Why do you want to define a second global which holds the environment variable? Just use TCG_AREG0 for that. >

[Qemu-devel] [PATCH 3/6] qemu-ga: Add schema documentation for types

2012-01-25 Thread Michael Roth
Document guest agent schema types in similar fashion as qmp schema types. Signed-off-by: Michael Roth --- qapi-schema-guest.json | 118 +++- 1 files changed, 97 insertions(+), 21 deletions(-) diff --git a/qapi-schema-guest.json b/qapi-schema-guest.js

Re: [Qemu-devel] TCG register allocator

2012-01-25 Thread Xin Tong
I have a bug, it segfaults when executing a translation blocks. when i disable block chaining, the bug disappears. However, with block chaining, i do not know which translation block jumps to the code which caused the segfault. I want to reserve a register and use it to record the last translation

Re: [Qemu-devel] TCG register allocator

2012-01-25 Thread Xin Tong
The segfault is caused by jumping to the middle of an instruction. so i want to know which TB jumps here. Thanks Xin On Wed, Jan 25, 2012 at 10:54 AM, Xin Tong wrote: > I have a bug, it segfaults when executing a translation blocks. when i > disable block chaining, the bug disappears.  However

[Qemu-devel] [PATCH 3/5] arm: store the config_base_register during cpu_reset

2012-01-25 Thread Peter Maydell
From: Mark Langsdorf Long term, the config_base_register will be a QDM parameter. In the meantime, models that use it need to be able to preserve it across cpu_reset() calls. Signed-off-by: Mark Langsdorf Signed-off-by: Peter Maydell --- target-arm/helper.c |3 +++ 1 files changed, 3 inse

[Qemu-devel] [PATCH 5/5] Add Cortex-A15 CPU definition

2012-01-25 Thread Peter Maydell
Add a definition of a Cortex-A15 CPU. Note that for the moment we do not implement any of: * Large Physical Address Extensions (LPAE) * Virtualization Extensions * Generic Timer * TrustZone (this is also true of our existing Cortex-A9 model, etc) This CPU model is sufficient to boot a Linux ke

[Qemu-devel] [PATCH 4/5] Add dummy implementation of generic timer cp15 registers

2012-01-25 Thread Peter Maydell
Add a dummy implementation of the cp15 registers for the generic timer (found in the Cortex-A15), just sufficient for Linux to decide that it can't use it. This requires at least CNTP_CTL and CNTFRQ to be implemented as RAZ/WI; we RAZ/WI all of c14. Reviewed-by: Andreas Färber Signed-off-by: Pete

[Qemu-devel] [PULL 0/5] target-arm queue

2012-01-25 Thread Peter Maydell
Here's the latest target-arm pullreq. It includes Mark's fix for config_base_register, which is in turn a dependency of the arm-devs pullreq I'm about to send out, and which I'd like to get in before Anthony's QOM patchset lands and invalidates it :-) Please pull. -- PMM The following changes s

Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI

2012-01-25 Thread Eric Blake
On 01/24/2012 11:47 PM, ronnie sahlberg wrote: > Read from an arbitrary filedescriptor inherited from the parent process : > 9 vnc=127.0.0.1:0 -drive file=iscsi://127.0.0.1/iqn.ronnie.test/1 > -readconfig /proc/self/fd/9 That requires the existence of procfs, which is not portable (although it doe

Re: [Qemu-devel] TCG register allocator

2012-01-25 Thread Max Filippov
> I have a bug, it segfaults when executing a translation blocks. when i > disable block chaining, the bug disappears.  However, with block > chaining, i do not know which translation block jumps to the code > which caused the segfault. I want to reserve a register and use it to > record the last t

[Qemu-devel] [PATCH 4/6] qemu-ga: add guest-set-support-level command

2012-01-25 Thread Michael Roth
Recently commands where introduced on the mailing that involved adding commands to the guest agent that could potentially break older versions of QEMU. While it's okay to expect that qemu-ga can be updated to support newer host features, it's unrealistic to require a host to be updated to support q

[Qemu-devel] [PATCH 2/6] main-loop: For tools, initialize timers as part of qemu_init_main_loop()

2012-01-25 Thread Michael Roth
In some cases initializing the alarm timers can lead to non-negligable overhead from programs that link against qemu-tool.o. At least, setting a max-resolution WinMM alarm timer via mm_start_timer() (the current default for Windows) can increase the "tick rate" on Windows OSs and affect frequency s

Re: [Qemu-devel] [PATCH v2 3/9] hw/a15mpcore.c: Add Cortex-A15 private peripheral model

2012-01-25 Thread Andreas Färber
Am 24.01.2012 13:39, schrieb Peter Maydell: > Add a model of the Cortex-A15 memory mapped private peripheral > space. This is fairly simple because the only memory mapped > bit of the A15 is the GIC. > > Note that we don't currently model a VGIC and therefore don't > map the VGIC related bits of t

Re: [Qemu-devel] TCG register allocator

2012-01-25 Thread Peter Maydell
On 25 January 2012 15:55, Xin Tong wrote: > The segfault is caused by jumping to the middle of an instruction. so > i want to know which TB jumps here. (a) Assuming it doesn't take too long to get there, you should be able to get this information by turning on the debug log via -d whatever. If it

Re: [Qemu-devel] [PATCH v9 7/9] hw/lan9118: Add basic 16-bit mode support.

2012-01-25 Thread Peter Maydell
On 20 January 2012 10:53, Evgeny Voevodin wrote: > @@ -294,6 +304,14 @@ static const VMStateDescription vmstate_lan9118 = { >         VMSTATE_INT32(rxp_offset, lan9118_state), >         VMSTATE_INT32(rxp_size, lan9118_state), >         VMSTATE_INT32(rxp_pad, lan9118_state), > +        VMSTATE_UINT

Re: [Qemu-devel] [PATCH v2 4/9] hw/vexpress.c: Make motherboard peripheral memory map table-driven

2012-01-25 Thread Andreas Färber
Am 24.01.2012 13:39, schrieb Peter Maydell: > Pull the addresses used for mapping motherboard peripherals into > memory out into a table. This will allow us to simply provide a > second table to implement the "Cortex-A Series" memory map used by > the A15 variant of Versatile Express, as well as th

Re: [Qemu-devel] [PATCH v2 11/33] scsi-disk: support DVD profile in GET CONFIGURATION

2012-01-25 Thread Paolo Bonzini
On 01/25/2012 05:34 PM, Artyom Tarasenko wrote: This patch produces the following error when booting Solaris/SPARC: WARNING: /iommu@0,1000/sbus@0,10001000/espdma@5,840/esp@5,880 (esp0): data transfer overrun: current esp state: esp:State=DATA Last State=DATA_DONE

Re: [Qemu-devel] [PATCH v9 7/9] hw/lan9118: Add basic 16-bit mode support.

2012-01-25 Thread Andreas Färber
Am 25.01.2012 17:35, schrieb Peter Maydell: > On 20 January 2012 10:53, Evgeny Voevodin wrote: >> @@ -294,6 +304,14 @@ static const VMStateDescription vmstate_lan9118 = { >> VMSTATE_INT32(rxp_offset, lan9118_state), >> VMSTATE_INT32(rxp_size, lan9118_state), >> VMSTATE_INT3

[Qemu-devel] [PATCH uq/master] kvm: Allow to set shadow MMU size

2012-01-25 Thread Jan Kiszka
Introduce the KVM-specific machine option kvm_shadow_mem. It allows to set a custom shadow MMU size for the virtual machine. This is useful for stress testing e.g. Only x86 supports this for now, but it is in principle a generic concept for all targets with shadow MMUs. Signed-off-by: Jan Kiszka

Re: [Qemu-devel] [PATCH v9 7/9] hw/lan9118: Add basic 16-bit mode support.

2012-01-25 Thread Peter Maydell
On 25 January 2012 17:04, Andreas Färber wrote: > Am 25.01.2012 17:35, schrieb Peter Maydell: >> >> You need to bump .version_id and make your new fields >>    VMSTATE_UINT32(write_word_prev_offset, lan9118_state, 2), > >    VMSTATE_UINT32_V(write_word_prev_offset, lan9118_state, 2), Doh, yes. -

[Qemu-devel] [PATCH 10/10] PPC: booke206: move avail check to tlbwe

2012-01-25 Thread Alexander Graf
We can have TLBs that only support a single page size. This is defined by the absence of the AVAIL flag in TLBnCFG. If this is the case, we currently write invalid size info into the TLB, but override it on internal fault. Let's move the check over to tlbwe, so we don't have the AVAIL check in the

[Qemu-devel] [PATCH 08/10] PPC: booke206: Implement tlbilx

2012-01-25 Thread Alexander Graf
The PowerPC 2.06 BookE ISA defines an opcode called "tlbilx" which is used to flush TLB entries. It's the recommended way of flushing in virtualized environments. So far we got away without implementing it, but Linux for e500mc uses this instruction, so we better add it :). Signed-off-by: Alexand

  1   2   >