Re: [Qemu-devel] [PATCH 06/16] Avoid range comparisons on io index types

2012-01-03 Thread Avi Kivity
On 01/02/2012 11:58 PM, Richard Henderson wrote: > On 01/03/2012 03:33 AM, Avi Kivity wrote: > > -if ((pd & ~TARGET_PAGE_MASK) > IO_MEM_ROM && !(pd & IO_MEM_ROMD)) { > > +if (!is_ram_rom(pd) && !(pd & IO_MEM_ROMD)) { > > /* IO memory case (romd handled later) */ > > Perhaps (!is_ra

Re: [Qemu-devel] [PATCH 08/16] Convert IO_MEM_{RAM, ROM, UNASSIGNED, NOTDIRTY} to MemoryRegions

2012-01-03 Thread Avi Kivity
On 01/03/2012 12:16 AM, Richard Henderson wrote: > On 01/03/2012 03:33 AM, Avi Kivity wrote: > > -if (is_ram_rom_romd(pd)) { > > +if (!is_ram_rom_romd(pd)) { > > Should be merged with a previous patch. > Fixed. -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] KVM call agenda for Tuesday 3

2012-01-03 Thread Paolo Bonzini
On 01/03/2012 02:12 AM, Anthony Liguori wrote: 2/4 is on the list. It's adding the type infrastructure such that when you do -device e1000, as far as QOM is concerned you're creating an E1000 object which inherits from a PCIDevice, etc. Yes, sorry, that was quite obvious. I was not sure about

Re: [Qemu-devel] [PATCH 01/27] qom: add the base Object class

2012-01-03 Thread Paolo Bonzini
On 01/03/2012 02:18 AM, Anthony Liguori wrote: 2) Why do you need a list for the interface objects at all? You can make obj->interfaces point to a single blob, and initialize the objects in place. You only need to store the number of interfaces into the TypeImpl or in the object header, or add a

Re: [Qemu-devel] coroutine bug?, was Re: [PATCH] sheepdog: use coroutines

2012-01-03 Thread Stefan Hajnoczi
On Mon, Jan 02, 2012 at 04:39:59PM +0100, Christoph Hellwig wrote: > I've tried to understand how the recursive calling happens, but unfortunately > the whole coroutine code lacks any sort of documentation how it should > behave or what it asserts about the callers. There is documentation on the p

Re: [Qemu-devel] [ANNOUNCE] qemu-test: a set of tests scripts for QEMU

2012-01-03 Thread Stefan Hajnoczi
On Mon, Jan 02, 2012 at 03:07:08PM +0100, Paolo Bonzini wrote: > On 12/29/2011 07:33 PM, Anthony Liguori wrote: > > > >FWIW, I expect virtio-scsi to be the first guinea pig here... I believe > >Stefan has already started looking at writing some qtest based tests for > >virtio-scsi. > > I'm curiou

Re: [Qemu-devel] coroutine bug?, was Re: [PATCH] sheepdog: use coroutines

2012-01-03 Thread Stefan Hajnoczi
On Mon, Jan 02, 2012 at 10:38:11PM +, Stefan Hajnoczi wrote: > On Mon, Jan 2, 2012 at 3:39 PM, Christoph Hellwig wrote: > > On Fri, Dec 30, 2011 at 10:35:01AM +, Stefan Hajnoczi wrote: > >> If you can reproduce this bug and suspect coroutines are involved then I > > > > It's entirely repro

Re: [Qemu-devel] KVM call agenda for Tuesday 3

2012-01-03 Thread Stefan Hajnoczi
On Mon, Jan 02, 2012 at 01:09:40PM +0100, Juan Quintela wrote: > Please send in any agenda items you are interested in covering. Status of virtio drivers for Windows: * Unsupported in community today * Bugs languish on bug tracker/mailing list * Risking a reputation of not supporting Windows gu

Re: [Qemu-devel] [PATCH 07/30] qom: add the base Object class (v2)

2012-01-03 Thread Paolo Bonzini
On 01/03/2012 01:51 AM, Anthony Liguori wrote: This class provides the main building block for QEMU Object Model and is extensively documented in the header file. It is largely inspired by GObject. Signed-off-by: Anthony Liguori Very nice. I still have some minor remarks, but nothing that ca

Re: [Qemu-devel] [PATCH 10/30] qdev: don't access name through info

2012-01-03 Thread Paolo Bonzini
On 01/03/2012 01:51 AM, Anthony Liguori wrote: d->nic = qemu_new_nic(&net_e1000_info,&d->conf, - qdev_get_info(&d->dev.qdev)->name, d->dev.qdev.id, d); + object_get_typename(OBJECT(d)), d->dev.qdev.id, d); It's a pity that this loses type

Re: [Qemu-devel] [ANNOUNCE] qemu-test: a set of tests scripts for QEMU

2012-01-03 Thread Paolo Bonzini
On 01/03/2012 09:19 AM, Stefan Hajnoczi wrote: I haven't started yet but I am planning to write qtest virtio PCI tests and will definitely be taking a look at virtio-scsi. We don't necessarily need mock devices, just really simply temporary raw files or similar. On the other hand mock devices c

Re: [Qemu-devel] [PATCH 0/2] virtio-mmio: fix 2 bugs

2012-01-03 Thread Stefan Hajnoczi
On Tue, Jan 3, 2012 at 7:05 AM, Ying-Shiuan Pan wrote: > I'm not sure if it is appropriate to put patches here because > virtio-mmio is actually not in official repository yet. It's worth CCing Peter Maydell and Pawel on this because they are working on virtio-mmio. Stefan

Re: [Qemu-devel] [PATCH] Fix wrong region_offset when overlaying a page with another

2012-01-03 Thread Avi Kivity
On 01/02/2012 07:49 PM, Andreas Färber wrote: > Am 01.01.2012 18:23, schrieb Avi Kivity: > > cpu_register_physical_memory_log() does not update region_offset > > if a page was previously registered for the same address. This > > could cause mmio accesses going to the wrong place, by using the > >

Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI

2012-01-03 Thread Daniel P. Berrange
On Fri, Dec 23, 2011 at 10:08:11AM +0100, Paolo Bonzini wrote: > On 12/22/2011 09:51 PM, ronnie sahlberg wrote: > >The difference between qcow2 and iscsi and the problem is that .open() > >is called for all devices before the monitor is started, so .open() is > >called before we would have a chance

Re: [Qemu-devel] KVM call agenda for Tuesday 3

2012-01-03 Thread Peter Maydell
On 3 January 2012 01:14, Anthony Liguori wrote: > Let's separate out what a user *should* do from what a user *can* do. > > A user *should* have a command line syntax that reflects something that > makes sense to them. For instance, qemu-system-arm --machine beaglebone > > I don't really care wha

[Qemu-devel] [Bug 502107] Re: qemu-kvm 0.12.1.2 crashes booting Ubuntu 9.10 with "-vga std"

2012-01-03 Thread Claudio Matsuoka
Some notes of interest: - the unaligned pointer error also seems to happen in real systems with certain ATI cards. - rebuilding grub with mm-debug makes Ubuntu boot without unaligned/out of range pointer messages with -vga std. - adding debug messages (with grub_printf()) to grub memalign/free f

Re: [Qemu-devel] [PATCH 0/2] virtio-mmio: fix 2 bugs

2012-01-03 Thread Peter Maydell
On 3 January 2012 07:05, Ying-Shiuan Pan wrote: > I'm not sure if it is appropriate to put patches here because > virtio-mmio is actually not in official repository yet. > In case that someone else wants to test virtio-mmio as I did, I decide > to send them out. > > Currently, I've successfully te

Re: [Qemu-devel] [PATCH] configure: CONFIG_QEMU_INTERP_PREFIX only for user mode

2012-01-03 Thread Stefan Hajnoczi
On Thu, Dec 22, 2011 at 11:26:10AM +0100, Stefan Weil wrote: > Signed-off-by: Stefan Weil > --- > configure |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) In the future, please include an explanation in the commit message. For example, this change seems to be purely a clean up.

[Qemu-devel] [Bug 498035] Re: qemu hangs on shutdown or reboot (XP guest)

2012-01-03 Thread Claudio Matsuoka
Did a clean XP install and could not reproduce with current git qemu- kvm. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/498035 Title: qemu hangs on shutdown or reboot (XP guest) Status in QEMU:

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Fix test for supported host CPU type

2012-01-03 Thread Stefan Hajnoczi
On Sat, Dec 24, 2011 at 01:07:25PM +, Peter Maydell wrote: > The test for whether the host CPU is supported had several problems: > * the attempt to fall back to TCI was done as a duplicate >test, very late (so "--cpu foo" would fail early but "--cpu unicore32" >would fail late, differ

Re: [Qemu-devel] [Qemu-trivial] [PATCH] gdbstub: Fix fd leak in gdbserver_open() error path

2012-01-03 Thread Stefan Hajnoczi
On Sat, Dec 24, 2011 at 11:37:24PM +, Peter Maydell wrote: > Fix a leak of a file descriptor in error exit paths in > gdbserver_open(). > > Signed-off-by: Peter Maydell > --- > Of no great consequence, but it was in the pile of coverity complaints > and it's a trivial fix. > > gdbstub.c |

Re: [Qemu-devel] [Qemu-trivial] [PATCH] net/socket.c: Fix fd leak in net_socket_listen_init() error paths

2012-01-03 Thread Stefan Hajnoczi
On Sat, Dec 24, 2011 at 11:47:11PM +, Peter Maydell wrote: > Fix a leak of a file descriptor due to missing closesocket() calls > in error paths in net_socket_listen_init(). > > Signed-off-by: Peter Maydell > --- > Coverity again... > > net/socket.c |2 ++ > 1 files changed, 2 insertion

Re: [Qemu-devel] [Qemu-trivial] [PATCH V2] Make python mandatory

2012-01-03 Thread Stefan Hajnoczi
On Sat, Dec 31, 2011 at 12:20:47PM +0100, Stefan Weil wrote: > Am 31.12.2011 12:14, schrieb Sebastian Herbszt: > >Make python mandatory. > > > >Signed-off-by: Sebastian Herbszt > >--- > >configure | 10 +++--- > >1 files changed, 3 insertions(+), 7 deletions(-) > > > >diff --git a/configure b/c

Re: [Qemu-devel] [PATCH 1/8] notifier: switch to QLIST

2012-01-03 Thread Stefan Hajnoczi
On Mon, Jan 02, 2012 at 07:00:30PM +0100, Paolo Bonzini wrote: > void notifier_list_add(NotifierList *list, Notifier *notifier) > { > -QTAILQ_INSERT_HEAD(&list->notifiers, notifier, node); > +QLIST_INSERT_HEAD(&list->notifiers, notifier, node); > } > > -void notifier_list_remove(Notifi

Re: [Qemu-devel] [PATCH 1/8] notifier: switch to QLIST

2012-01-03 Thread Paolo Bonzini
On 01/03/2012 12:54 PM, Stefan Hajnoczi wrote: On Mon, Jan 02, 2012 at 07:00:30PM +0100, Paolo Bonzini wrote: void notifier_list_add(NotifierList *list, Notifier *notifier) { -QTAILQ_INSERT_HEAD(&list->notifiers, notifier, node); +QLIST_INSERT_HEAD(&list->notifiers, notifier, node);

Re: [Qemu-devel] [Qemu-trivial] [PATCH 5/8] qemu-queue: really simplify QSIMPLEQ

2012-01-03 Thread Stefan Hajnoczi
On Mon, Jan 02, 2012 at 07:00:34PM +0100, Paolo Bonzini wrote: > QSIMPLEQ is still relatively heavyweight when used as a free list, > compared to a simple singly-linked list. One disadvantage is that > it requires an initializer macro, unlike for example QLIST. QSIMPLEQ is no longer a queue if yo

Re: [Qemu-devel] KVM call agenda for Tuesday 3

2012-01-03 Thread Alex Bradbury
On 3 January 2012 10:26, Peter Maydell wrote: > I don't think we even have syntax for 2 at the moment except for the > weird special case of "-cpu foo". It currently is quite common to e.g. use a versatilepb machine model but switch the CPU for arm1176, cortex-a8 etc with -cpu. Will this still be

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/8] qemu-queue cleanups

2012-01-03 Thread Stefan Hajnoczi
On Mon, Jan 02, 2012 at 07:00:29PM +0100, Paolo Bonzini wrote: > These patches simplify the jungle of lists provided by qemu-queue from > 4 to 3. QCIRCLEQ is dropped, since it provides no real advantage over > QTAILQ. QSIMPLEQ is simplified to no longer permit insertion at the > tail, with the ad

Re: [Qemu-devel] [PATCH 1/8] notifier: switch to QLIST

2012-01-03 Thread Stefan Hajnoczi
On Tue, Jan 3, 2012 at 11:59 AM, Paolo Bonzini wrote: > On 01/03/2012 12:54 PM, Stefan Hajnoczi wrote: >> >> On Mon, Jan 02, 2012 at 07:00:30PM +0100, Paolo Bonzini wrote: >>> >>>  void notifier_list_add(NotifierList *list, Notifier *notifier) >>>  { >>> -    QTAILQ_INSERT_HEAD(&list->notifiers, n

Re: [Qemu-devel] KVM call agenda for Tuesday 3

2012-01-03 Thread Dor Laor
On 01/03/2012 10:33 AM, Stefan Hajnoczi wrote: On Mon, Jan 02, 2012 at 01:09:40PM +0100, Juan Quintela wrote: Please send in any agenda items you are interested in covering. Status of virtio drivers for Windows: * Unsupported in community today Why? * Bugs languish on bug tracker/maili

Re: [Qemu-devel] KVM call agenda for Tuesday 3

2012-01-03 Thread Stefan Hajnoczi
On Tue, Jan 3, 2012 at 12:15 PM, Dor Laor wrote: > On 01/03/2012 10:33 AM, Stefan Hajnoczi wrote: >> >> On Mon, Jan 02, 2012 at 01:09:40PM +0100, Juan Quintela wrote: >>> >>> Please send in any agenda items you are interested in covering. >> >> >> Status of virtio drivers for Windows: >>  * Unsupp

[Qemu-devel] [PATCH] vga: optimize ppm_save() divisions

2012-01-03 Thread Avi Kivity
ppm_save() spends upwards of 50% of its time doing divisions. Replace them with shifts. Signed-off-by: Avi Kivity --- hw/vga.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/vga.c b/hw/vga.c index ca79aa1..a228cde 100644 --- a/hw/vga.c +++ b/hw/vga.c @@ -237

Re: [Qemu-devel] KVM call agenda for Tuesday 3

2012-01-03 Thread Anthony Liguori
On 01/03/2012 04:26 AM, Peter Maydell wrote: On 3 January 2012 01:14, Anthony Liguori wrote: Let's separate out what a user *should* do from what a user *can* do. A user *should* have a command line syntax that reflects something that makes sense to them. For instance, qemu-system-arm --machi

Re: [Qemu-devel] [PATCH 10/30] qdev: don't access name through info

2012-01-03 Thread Anthony Liguori
On 01/03/2012 03:06 AM, Paolo Bonzini wrote: On 01/03/2012 01:51 AM, Anthony Liguori wrote: d->nic = qemu_new_nic(&net_e1000_info,&d->conf, - qdev_get_info(&d->dev.qdev)->name, d->dev.qdev.id, d); + object_get_typename(OBJECT(d)), d->dev.qdev.id, d); It's a pity that this loses type-safety.

Re: [Qemu-devel] [PATCH 10/30] qdev: don't access name through info

2012-01-03 Thread Paolo Bonzini
On 01/03/2012 02:39 PM, Anthony Liguori wrote: It's a pity that this loses type-safety. You mean at run time or because OBJECT() cast is so lose? We can fix the later.. At compile-time, i.e. the latter. But no problem, I really think it should be fixed in the compiler. Paolo

Re: [Qemu-devel] [ANNOUNCE] qemu-test: a set of tests scripts for QEMU

2012-01-03 Thread Anthony Liguori
On 12/30/2011 09:43 AM, Andreas Färber wrote: Am 29.12.2011 23:30, schrieb Anthony Liguori: On 12/29/2011 04:10 PM, Peter Maydell wrote: How does your framework deal with non-x86 targets? http://git.qemu.org/qemu-jeos.git I've already got ppc32 support working. Adding a new arch is just a m

Re: [Qemu-devel] [patch 2/5] block: implement bdrv_find_backing_image in qcow2

2012-01-03 Thread Stefan Hajnoczi
On Fri, Dec 30, 2011 at 10:03 AM, Marcelo Tosatti wrote: > Signed-off-by: Marcelo Tosatti > > Index: stefanha/block/qcow2.c > === > --- stefanha.orig/block/qcow2.c > +++ stefanha/block/qcow2.c > @@ -767,6 +767,20 @@ static int qcow2_

Re: [Qemu-devel] [ANNOUNCE] qemu-test: a set of tests scripts for QEMU

2012-01-03 Thread Anthony Liguori
On 12/29/2011 07:20 PM, Lucas Meneghel Rodrigues wrote: On 12/29/2011 10:33 PM, Anthony Liguori wrote: So I decided to do some snooping. Here are some stats: anthony@titi:~/git/autotest/client/tests/kvm/tests$ wc -l *.py 150 balloon_check.py 68 boot_savevm.py 190 cdrom.py 1875 cgroup.py 111 cpu

Re: [Qemu-devel] KVM call agenda for Tuesday 3

2012-01-03 Thread Andreas Färber
Anthony, Am 03.01.2012 02:04, schrieb Anthony Liguori: > On 01/02/2012 07:46 AM, Andreas Färber wrote: >> Am 02.01.2012 13:09, schrieb Juan Quintela: >>> First of all, Happy New Year to everybody (even for the people whose >>> calendar is different O:-) >> >> +1 >> >>> Please send in any agenda it

Re: [Qemu-devel] KVM call agenda for Tuesday 3

2012-01-03 Thread Peter Maydell
On 3 January 2012 13:37, Anthony Liguori wrote: > For what you're getting at, you actually want to model the CPUs in QOM such > that you would have an ARM926 is-a ARMCPU is-a CPUCommon. > > Then you could have the beagle machine have a link.  If it always > has a single CPU, you make it a child an

Re: [Qemu-devel] KVM call agenda for Tuesday 3

2012-01-03 Thread Anthony Liguori
On 01/03/2012 07:52 AM, Andreas Färber wrote: Anthony, Am 03.01.2012 02:04, schrieb Anthony Liguori: On 01/02/2012 07:46 AM, Andreas Färber wrote: Am 02.01.2012 13:09, schrieb Juan Quintela: First of all, Happy New Year to everybody (even for the people whose calendar is different O:-) +1

Re: [Qemu-devel] KVM call agenda for Tuesday 3

2012-01-03 Thread Anthony Liguori
On 01/03/2012 07:57 AM, Peter Maydell wrote: On 3 January 2012 13:37, Anthony Liguori wrote: For what you're getting at, you actually want to model the CPUs in QOM such that you would have an ARM926 is-a ARMCPU is-a CPUCommon. Then you could have the beagle machine have a link. If it always h

Re: [Qemu-devel] KVM call agenda for Tuesday 3

2012-01-03 Thread Andreas Färber
Am 03.01.2012 14:12, schrieb Stefan Hajnoczi: > On Tue, Jan 3, 2012 at 12:15 PM, Dor Laor wrote: >> There is a legal issue w/ WHQL drivers but self sign is not a probably and I >> believe that's what we have today. > > For a user anything other than first-class native drivers is a red > flag that

Re: [Qemu-devel] KVM call agenda for Tuesday 3

2012-01-03 Thread Peter Maydell
On 3 January 2012 14:02, Anthony Liguori wrote: > On 01/03/2012 07:57 AM, Peter Maydell wrote: >> The CPU should always be a child of the board, surely, even if the user >> might want to use a different one? That's just basic composition. >> The links should be for "the CPU has two input IRQ lines

Re: [Qemu-devel] [PATCH 0/2][RFC] postcopy migration: Linux char device for postcopy

2012-01-03 Thread Andrea Arcangeli
On Mon, Jan 02, 2012 at 06:55:18PM +0100, Paolo Bonzini wrote: > On 01/02/2012 06:05 PM, Andrea Arcangeli wrote: > > On Thu, Dec 29, 2011 at 06:01:45PM +0200, Avi Kivity wrote: > >> On 12/29/2011 06:00 PM, Avi Kivity wrote: > >>> The NFS client has exactly the same issue, if you mount it with the i

Re: [Qemu-devel] linux-user: improved fake /proc/self/stat

2012-01-03 Thread Alexander Graf
Subject should have [PATCH] in the beginning. Why don't you just create the patch using git-format-patch? It makes sure the format is correct. You can also check out http://wiki.qemu.org/Contribute/SubmitAPatch for some hints. And thanks a lot for fixing this! On 03.01.2012, at 08:25, Fabio Erc

Re: [Qemu-devel] KVM call agenda for Tuesday 3

2012-01-03 Thread Vadim Rozenfeld
On Tue, 2012-01-03 at 13:12 +, Stefan Hajnoczi wrote: > On Tue, Jan 3, 2012 at 12:15 PM, Dor Laor wrote: > > On 01/03/2012 10:33 AM, Stefan Hajnoczi wrote: > >> > >> On Mon, Jan 02, 2012 at 01:09:40PM +0100, Juan Quintela wrote: > >>> > >>> Please send in any agenda items you are interested in

Re: [Qemu-devel] [ANNOUNCE] qemu-test: a set of tests scripts for QEMU

2012-01-03 Thread Andreas Färber
Am 03.01.2012 14:42, schrieb Anthony Liguori: > On 12/30/2011 09:43 AM, Andreas Färber wrote: >> Am 29.12.2011 23:30, schrieb Anthony Liguori: >>> 1) build binutils for desired target >>> >>> 2) build GCC using (1) as a cross compiler. This is a limited form of >>> GCC (no thread support) targeted

[Qemu-devel] [PULL 00/10] ppc patch queue 2012-01-03

2012-01-03 Thread Alexander Graf
Hi Anthony / Aurelien / Blue, This is my current patch queue for ppc. Please pull. It includes a screendump segfault fix patch that is not PPC specific, but has been on the ML forever now, so I assume it's safe to pull as well. Alex The following changes since commit 8d3bc5178fbc06cdd89c064ae8

Re: [Qemu-devel] [PATCH 04/30] ppc_prep: convert host bridge to qdev

2012-01-03 Thread Andreas Färber
Am 03.01.2012 01:51, schrieb Anthony Liguori: > Untested beyond compile. But it's a very simple conversion. > > Signed-off-by: Anthony Liguori Seems like we've crossed paths now. I have a more complete patch using different naming, but it's not yet working. I'll have to bisect. Andreas > ---

Re: [Qemu-devel] [PATCH 2/3] Add a new PCI region type to supports 64 bit ranges

2012-01-03 Thread Gerd Hoffmann
On 12/29/11 03:56, Kevin O'Connor wrote: > On Wed, Dec 28, 2011 at 06:26:05PM +1300, Alexey Korolev wrote: >> This patch adds PCI_REGION_TYPE_PREFMEM_64 region type and modifies types of >> variables to make it possible to work with 64 bit addresses. >> >> Why I've added just one region type PCI_RE

Re: [Qemu-devel] [PATCH 1/5] vfio: Introduce documentation for VFIO driver

2012-01-03 Thread Alex Williamson
On Wed, 2011-12-28 at 19:16 +0200, Ronen Hod wrote: > On 12/21/2011 11:42 PM, Alex Williamson wrote: > > +The final aspect of VFIO is the notion of merging groups. In both the > > +assignment of devices to virtual machines and the pure userspace > > +driver model, it's expect that a single user in

[Qemu-devel] [PATCH 05/10] pseries: FDT NUMA extensions to support multi-node guests

2012-01-03 Thread Alexander Graf
From: Bharata B Rao Add NUMA specific properties to guest's device tree to boot a multi-node guests. This patch adds the following properties: ibm,associativity ibm,architecture-vec-5 ibm,associativity-reference-points With this, it becomes possible to use -numa option on pseries targets. Sign

Re: [Qemu-devel] Mixed USB 1.1 and USB 2.0 on the same port

2012-01-03 Thread Gerd Hoffmann
On 12/31/11 13:11, Erik Rull wrote: > Hi all, > > how can I use a USB 1.1 device on the USB 2.0 bus? Currently the EHCI > implementation complains that the device is mismatches the USB version. -readconfig docs/ich9-ehci-uhci.cfg cheers, Gerd

[Qemu-devel] [PATCH 02/10] console: Fix segfault on screendump without VGA adapter

2012-01-03 Thread Alexander Graf
When trying to create a screen dump without having any VGA adapter inside the guest, QEMU segfaults. This is because it's trying to switch back to the "previous" screen it was on before dumping the VGA screen. Unfortunately, in my case there simply is no previous screen so it accesses a NULL point

Re: [Qemu-devel] linux-user: improved fake /proc/self/stat

2012-01-03 Thread Fabio Erculiani
On Tue, Jan 3, 2012 at 3:26 PM, Alexander Graf wrote: > Subject should have [PATCH] in the beginning. Why don't you just create the > patch using git-format-patch? It makes sure the format is correct. You can > also check out http://wiki.qemu.org/Contribute/SubmitAPatch for some hints. > > And t

[Qemu-devel] [PATCH 06/10] pseries: Emit device tree nodes in reg order

2012-01-03 Thread Alexander Graf
From: David Gibson Although in theory the device tree has no inherent ordering, in practice the order of nodes in the device tree does effect the order that devices are detected by software. Currently the ordering is determined by the order the devices appear on the QEMU command line. Although t

[Qemu-devel] [PATCH v5 1/9] Add cache handling functions

2012-01-03 Thread Orit Wasserman
Add page caching mechanism. The pages are stored in the cache ordered by their address. Signed-off-by: Orit Wasserman --- arch_init.c | 183 +++ 1 files changed, 183 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c ind

[Qemu-devel] [PATCH v5 4/9] Add host_from_stream_offset_versioned function

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- arch_init.c | 35 +-- 1 files changed, 21 insertions(+), 14 deletions(-) diff --git a/arch_init.c b/arch_init.c index e87dfbc..05b8053 100644 --- a/arch_init.c +++ b/arch_init.c @@ -613,6 +613,23 @@ static inline void *host_fro

[Qemu-devel] [PATCH v5 3/9] Add save_block_hdr function

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- arch_init.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/arch_init.c b/arch_init.c index 426b34d..e87dfbc 100644 --- a/arch_init.c +++ b/arch_init.c @@ -335,6 +335,17 @@ static void xor_encode(uint8_t *d

[Qemu-devel] [PATCH v5 8/9] QMP commands changes

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- hmp-commands.hx | 34 ++ qmp-commands.hx | 44 +--- 2 files changed, 63 insertions(+), 15 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 14838b7..952d5cd 100644 --- a

[Qemu-devel] [PATCH 10/10] PPC: Add description for the Freescale e500mc core.

2012-01-03 Thread Alexander Graf
From: Varun Sethi This core is found on chips such as p4080, p3041, p2040, and p5020. More needs to be done to make this viable for TCG (such as missing SPRs and instructions), but this suffices to get KVM running with appropriate kernel support. Signed-off-by: Varun Sethi [scottw...@freescale

[Qemu-devel] [PATCH v5 0/9] XBZRLE delta for live migration of large memory apps

2012-01-03 Thread Orit Wasserman
Changes from v4: 1) Rebase 2) divide patch into 9 patches 3) move memory allocation into cache_insert By using XBZRLE (Xor Binary Zero Run-Length-Encoding) we can reduce VM downtime and total live-migration time of VMs running memory write intensive workloads typical of large enterprise applicatio

[Qemu-devel] [PATCH] linux-user: improve fake /proc/self/stat making `ps` not segfault.

2012-01-03 Thread Fabio Erculiani
With the current fake /proc/self/stat implementation `ps` is segfaulting because it expects to read PID and argv[0] as first and second field respectively, with the latter being enclosed between backets. Reproducing is as easy as running: `ps` inside qemu-user chroot with /proc mounted. Signed-of

Re: [Qemu-devel] [PATCH v5 8/9] QMP commands changes

2012-01-03 Thread Stefan Hajnoczi
On Tue, Jan 3, 2012 at 3:34 PM, Orit Wasserman wrote: > +        .args_type  = "detach:-d,blk:-b,inc:-i,xbrle:-x,uri:s", > +        .params     = "[-d] [-b] [-i] [-x] uri", > +        .help       = "migrate to URI" > +                      "\n\t -d to not wait for completion" > +                  

[Qemu-devel] [PULL] virtio-serial: Fix console failure on unconnected pty

2012-01-03 Thread Amit Shah
Hi, This patch fixes a frozen guest on virtio-console output before a pty is connected. Please pull. The following changes since commit 8d3bc5178fbc06cdd89c064ae8f44e77c503e91e: Fix qapi code generation wrt parallel build (2011-12-27 09:28:58 -0600) are available in the git repository at:

Re: [Qemu-devel] Better qemu/kvm defaults (was Re: [RFC PATCH 0/4] Gang scheduling in CFS)

2012-01-03 Thread Anthony Liguori
On 01/01/2012 04:16 AM, Dor Laor wrote: On 12/29/2011 06:16 PM, Anthony Liguori wrote: On 12/29/2011 10:07 AM, Dor Laor wrote: On 12/26/2011 11:05 AM, Avi Kivity wrote: On 12/26/2011 05:14 AM, Nikunj A Dadhania wrote: btw you can get an additional speedup by enabling x2apic, for default_send

Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty

2012-01-03 Thread Amit Shah
On (Mon) 02 Jan 2012 [17:55:06], Alexander Graf wrote: > > On 02.01.2012, at 16:41, Christian Borntraeger wrote: > > > On 02/01/12 16:34, Alexander Graf wrote: > if (ret == -EAGAIN || (ret >= 0 && ret < buf_size)) { > virtio_serial_throttle_port(port, true); > >>

[Qemu-devel] [PATCH v5 5/9] Add XBRLE to ram_save_block and ram_save_live

2012-01-03 Thread Orit Wasserman
Add migration state to store XBRLE params (enablement and cache size). In the outgoing check to see if the page is cached and send compressed page by using save_xbrle_page function. In the incoming migration check to see if RAM_SAVE_FLAG_XBRLE is set decompress the page (by using load_xbrle functi

Re: [Qemu-devel] [PULL] virtio-serial: Fix console failure on unconnected pty

2012-01-03 Thread Amit Shah
On (Tue) 03 Jan 2012 [21:18:20], Amit Shah wrote: > Hi, > > This patch fixes a frozen guest on virtio-console output before a pty > is connected. Please pull. > > The following changes since commit 8d3bc5178fbc06cdd89c064ae8f44e77c503e91e: > > Fix qapi code generation wrt parallel build (2011

Re: [Qemu-devel] [PATCH v2] prepare for future GPLv2+ relicensing

2012-01-03 Thread Anthony Liguori
On 12/23/2011 09:19 AM, Paolo Bonzini wrote: All files under GPLv2 will get GPLv2+ changes starting next Christmas. Files that were only ever touched by Red Hat employees can be relicensed now. Signed-off-by: Paolo Bonzini Please speak now if you object to this. Regards, Anthony Liguori

[Qemu-devel] [PATCH 07/10] pseries: Add a routine to find a stable "default" vty and use it

2012-01-03 Thread Alexander Graf
From: David Gibson In vty_lookup() we have a special case for supporting early debug in the kernel. This accepts reg == 0 as a special case to mean "any vty". We implement this by searching the vtys on the bus and returning the first we find. This means that the vty we chose depends on the order

[Qemu-devel] [PATCH 09/10] pseries: Check for duplicate addresses on the spapr-vio bus

2012-01-03 Thread Alexander Graf
From: Michael Ellerman Check that devices on the spapr vio bus aren't given duplicate addresses. Currently we will not run with duplicate devices, the fdt code will spot it, but the error reporting is not great. With this patch we can report the error nicely in terms of the device names given by

[Qemu-devel] [PATCH 03/10] kvm-ppc: halt secondary cpus when guest reset

2012-01-03 Thread Alexander Graf
From: Liu Yu-B13201 When guest reset, we need to halt secondary cpus until guest kick them. This already works for tcg. The patch add the support for kvm. Signed-off-by: Liu Yu Signed-off-by: Alexander Graf [agraf: remove in-kernel irqchip code] --- hw/ppce500_spin.c |1 + target-ppc/kvm.

Re: [Qemu-devel] [PATCH v5 8/9] QMP commands changes

2012-01-03 Thread Orit Wasserman
On 01/03/2012 05:47 PM, Stefan Hajnoczi wrote: > On Tue, Jan 3, 2012 at 3:34 PM, Orit Wasserman wrote: >> +.args_type = "detach:-d,blk:-b,inc:-i,xbrle:-x,uri:s", >> +.params = "[-d] [-b] [-i] [-x] uri", >> +.help = "migrate to URI" >> + "\n\t

[Qemu-devel] [PATCH 01/10] PPC: monitor: add ability to dump SLB entries

2012-01-03 Thread Alexander Graf
From: Nishanth Aravamudan When run with a PPC Book3S (server) CPU Currently 'info tlb' in the qemu monitor reports "dump_mmu: unimplemented". However, during bringup work, it can be quite handy to have the SLB entries, which are available in the CPUPPCState. This patch adds an implementation of

[Qemu-devel] [PATCH 04/10] pseries: Remove hcalls callback

2012-01-03 Thread Alexander Graf
From: David Gibson For forgotten historical reasons, PAPR hypercalls for specific virtual IO devices (oh which there are quite a number) are registered via a callback in the VIOsPAPRDeviceInfo structure. This is kind of ugly, so this patch instead registers hypercalls from device_init() function

Re: [Qemu-devel] [PATCH] linux-user: improve fake /proc/self/stat making `ps` not segfault.

2012-01-03 Thread Fabio Erculiani
ts->bprm->argv seems NULL here. Isn't it supposed to be set? -- Fabio Erculiani

[Qemu-devel] [PATCH] linux-user: use uint64_t for getpid()

2012-01-03 Thread Fabio Erculiani
This fixes -Wformat warning introduced by 983da8bec44fd1ab5e9730f01e719b3849aa0a35 Signed-off-by: Fabio Erculiani --- linux-user/syscall.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index f2af5d5..e563c00 100644 --- a/li

[Qemu-devel] [PATCH v5 6/9] Add xbrle parameters to MigrationState

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- block-migration.c |4 +++- hw/hw.h |4 +++- migration.c | 15 +-- migration.h |3 +++ savevm.c | 11 +++ sysemu.h |4 +++- 6 files changed, 32 insertions(+), 9 deletions(-) diff --g

[Qemu-devel] [PATCH v5 7/9] Add set_cachesize to change XBRLE cache size

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- migration.c | 25 - migration.h |7 +++ 2 files changed, 31 insertions(+), 1 deletions(-) diff --git a/migration.c b/migration.c index ed47958..3d88cdd 100644 --- a/migration.c +++ b/migration.c @@ -380,7 +380,30 @@ void migrat

[Qemu-devel] [PATCH v5 2/9] Add rle_encode and rle_decode functions Implement Run Length Encoding compression

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- arch_init.c | 58 ++ 1 files changed, 58 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index fdda277..426b34d 100644 --- a/arch_init.c +++ b/arch_init.c @@ -139,6 +139,9 @@ typedef

[Qemu-devel] [PATCH v5 9/9] Add XBRLE statistics information

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- arch_init.c | 67 +++ migration.c | 11 + migration.h |9 3 files changed, 87 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index 6b839a1..037d8ba 100644 ---

[Qemu-devel] [PATCH 08/10] pseries: Populate "/chosen/linux, stdout-path" in the FDT

2012-01-03 Thread Alexander Graf
From: David Gibson There is a device tree property "/chosen/linux,stdout-path" which indicates which device should be used as stdout - ie. "the console". Currently we don't specify anything, which means both firmware and Linux choose something arbitrarily. Use the routine we added in the last pa

Re: [Qemu-devel] [PATCH v5 8/9] QMP commands changes

2012-01-03 Thread Stefan Hajnoczi
On Tue, Jan 3, 2012 at 3:57 PM, Orit Wasserman wrote: > On 01/03/2012 05:47 PM, Stefan Hajnoczi wrote: >> On Tue, Jan 3, 2012 at 3:34 PM, Orit Wasserman wrote: >>> +        .args_type  = "detach:-d,blk:-b,inc:-i,xbrle:-x,uri:s", >>> +        .params     = "[-d] [-b] [-i] [-x] uri", >>> +        .

Re: [Qemu-devel] [PATCH v5 0/9] XBZRLE delta for live migration of large memory apps

2012-01-03 Thread Anthony Liguori
On 01/03/2012 09:34 AM, Orit Wasserman wrote: Changes from v4: 1) Rebase 2) divide patch into 9 patches 3) move memory allocation into cache_insert By using XBZRLE (Xor Binary Zero Run-Length-Encoding) we can reduce VM downtime and total live-migration time of VMs running memory write intensive

Re: [Qemu-devel] [PATCH v5 0/9] XBZRLE delta for live migration of large memory apps

2012-01-03 Thread Orit Wasserman
On 01/03/2012 06:32 PM, Anthony Liguori wrote: > On 01/03/2012 09:34 AM, Orit Wasserman wrote: >> Changes from v4: >> 1) Rebase >> 2) divide patch into 9 patches >> 3) move memory allocation into cache_insert >> >> By using XBZRLE (Xor Binary Zero Run-Length-Encoding) we can reduce VM >> downtime

Re: [Qemu-devel] [PULL][v2] Remove cpu_get_physical_page_desc

2012-01-03 Thread Anthony Liguori
On 12/27/2011 09:38 AM, Avi Kivity wrote: Changes since first posting: fold a fixup patch into its parent patch, style fixes. I didn't get much review or testing for vhost or Xen, due to various issues around births separated by a large amount of time if not distance, but I don't want to get thi

Re: [Qemu-devel] [PULL][v2] Remove cpu_get_physical_page_desc

2012-01-03 Thread Avi Kivity
On 01/03/2012 07:06 PM, Anthony Liguori wrote: > On 12/27/2011 09:38 AM, Avi Kivity wrote: >> Changes since first posting: fold a fixup patch into its parent patch, >> style fixes. >> >> I didn't get much review or testing for vhost or Xen, due to various >> issues around births separated by a larg

Re: [Qemu-devel] [PULL][v2] Remove cpu_get_physical_page_desc

2012-01-03 Thread Avi Kivity
On 01/03/2012 07:09 PM, Avi Kivity wrote: > (strange, I was 100% sure I tested Xen). > Ah, we have different CONFIG_XEN_CTRL_INTERFACE_VERSIONs. -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PULL][v2] Remove cpu_get_physical_page_desc

2012-01-03 Thread Avi Kivity
On 01/03/2012 07:16 PM, Avi Kivity wrote: > On 01/03/2012 07:09 PM, Avi Kivity wrote: > > (strange, I was 100% sure I tested Xen). > > > > Ah, we have different CONFIG_XEN_CTRL_INTERFACE_VERSIONs. > Updated branch pushed - changed the signature of an empty-bodied function, should be safe. git:/

Re: [Qemu-devel] [PATCH] linux-user: improve fake /proc/self/stat making `ps` not segfault.

2012-01-03 Thread Alexander Graf
On 03.01.2012, at 17:07, Fabio Erculiani wrote: > ts->bprm->argv seems NULL here. > Isn't it supposed to be set? Good question. Maybe we need some other way to fetch argv0 then? Alex

Re: [Qemu-devel] [PATCH] linux-user: use uint64_t for getpid()

2012-01-03 Thread Alexander Graf
On 03.01.2012, at 17:08, Fabio Erculiani wrote: > This fixes -Wformat warning introduced by > 983da8bec44fd1ab5e9730f01e719b3849aa0a35 > > Signed-off-by: Fabio Erculiani As long as your original patch isn't applied yet, please just respin it and submit v2 or v3 of your original patch :). Al

[Qemu-devel] Stalls on Live Migration of VMs with a lot of memory

2012-01-03 Thread Peter Lieven
Hi all, is there any known issue when migrating VMs with a lot of (e.g. 32GB) of memory. It seems that there is some portion in the migration code which takes too much time when the number of memory pages is large. Symptoms are: Irresponsive VNC connection, VM stalls and also irresponsive QE

Re: [Qemu-devel] [PATCH] linux-user: improve fake /proc/self/stat making `ps` not segfault.

2012-01-03 Thread Fabio Erculiani
On Tue, Jan 3, 2012 at 6:41 PM, Alexander Graf wrote: > > On 03.01.2012, at 17:07, Fabio Erculiani wrote: > >> ts->bprm->argv seems NULL here. >> Isn't it supposed to be set? > > Good question. Maybe we need some other way to fetch argv0 then? or we could leave just an empty string for now -> "()

Re: [Qemu-devel] [PATCH] linux-user: improve fake /proc/self/stat making `ps` not segfault.

2012-01-03 Thread Fabio Erculiani
Or just using linux_binprm->filename with basename() -- Fabio Erculiani

[Qemu-devel] [PATCH] PPC: Get -M bamboo work with TCG

2012-01-03 Thread Alexander Graf
The -M bamboo target got introduced by Hollis back in the day as a way to run KVM code on ppc440. Unfortunately, since then it's been bitrot quite a bit. One of the reasons for this is that nobody without a ppc440 board can actually run the code, so even if there were volunteers to improve the cod

[Qemu-devel] [PATCH] PPC: Bamboo: Register CPU reset

2012-01-03 Thread Alexander Graf
To be able to support CPU reset, we need to put all register initialization and initial state into a CPU reset hook instead of a function that is only called once on bootup. This is a preparation step for the initial TLB setting code and brings bamboo more in line with what e500 and virtex already

Re: [Qemu-devel] [PATCH] linux-user: improve fake /proc/self/stat making `ps` not segfault.

2012-01-03 Thread Alexander Graf
On 03.01.2012, at 19:08, Fabio Erculiani wrote: > Or just using linux_binprm->filename with basename() No, that'd be wrong since argv[0] can be different from the actual file name. Also it can be the full path or not depending on what the initiator defined. Alex

Re: [Qemu-devel] [PATCH] linux-user: improve fake /proc/self/stat making `ps` not segfault.

2012-01-03 Thread Alexander Graf
On 03.01.2012, at 19:04, Fabio Erculiani wrote: > On Tue, Jan 3, 2012 at 6:41 PM, Alexander Graf wrote: >> >> On 03.01.2012, at 17:07, Fabio Erculiani wrote: >> >>> ts->bprm->argv seems NULL here. >>> Isn't it supposed to be set? >> >> Good question. Maybe we need some other way to fetch argv

  1   2   >