[Qemu-devel] [PATCH 4/4] scripts/analyse-9p-simpletrace.py: Add symbolic names for 9p operations.

2011-12-21 Thread Aneesh Kumar K.V
From: Harsh Prateek Bora Currently, we just print the numerical value of 9p operation identifier in case of RERROR which is less meaningful for readability. Mapping 9p operation ids to symbolic names provides a better tracelog: RERROR (tag = 1 , id = TWALK , err = " No such file or direc

[Qemu-devel] [PATCH 3/4] hw/9pfs: iattr_valid flags are kernel internal flags map them to 9p values.

2011-12-21 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" Kernel internal values can change, add protocol values for these constant and use them. Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p.c | 47 --- 1 files changed, 24 insertions(+), 23 deletions(-) diff --git a/hw/9

[Qemu-devel] [PATCH 1/4] hw/9pfs: replace iovec manipulation with QEMUIOVector

2011-12-21 Thread Aneesh Kumar K.V
From: Stefan Hajnoczi The v9fs_read() and v9fs_write() functions rely on iovec[] manipulation code should be replaced with QEMUIOVector to avoid duplicating code. In the future it may be possible to make the code even more concise by using QEMUIOVector consistently across virtio and 9pfs. The "v

Re: [Qemu-devel] [PATCH [0/9] various ARM fixes

2011-12-21 Thread Markus Armbruster
Please thread together your patches so that the parts appear as replies to the cover letter. git-send-email should do that by default. Why? Disconnected parts can easily get separated in the list. When that happens, your reviewers need to hunt for parts. They may choose to review something els

[Qemu-devel] the principle of the vm snapshot based on qemu-dm

2011-12-21 Thread ¤終於aware
Hi everyone, I'm not clear about the principle of the vm snapshot based on qemu-dm, so the following below maybe a joke. Sorry for that... register_savevm() included in ioemu-qemu-xen/hw/*.c covers various kinds of hardware in order to save the state of current running vm. In this

Re: [Qemu-devel] [Bug 907063] [NEW] Error reading VMDK4 with footer instead of header

2011-12-21 Thread Stefan Hajnoczi
On Tue, Dec 20, 2011 at 8:53 PM, bbgordonn <907...@bugs.launchpad.net> wrote: > Public bug reported: > > VMDK4 files can have a footer in the last block, which is the same > datastructure as the header but must be used instead if present. In this > case, the gd_offset in the usual header at the b

Re: [Qemu-devel] [RFC] Migration convergence - a suggestion

2011-12-21 Thread Ronen Hod
On 12/20/2011 03:39 PM, Anthony Liguori wrote: On 12/20/2011 01:06 AM, Ronen Hod wrote: Well the issue is not new, anyhow, following a conversation with Orit ... Since we want the migration to finish, I believe that the "migration speed" parameter alone cannot do the job. I suggest using two

[Qemu-devel] [PATCH] scsi virtio-blk usb-msd: Clean up device init error messages

2011-12-21 Thread Markus Armbruster
Replace error_report("DEVICE-NAME: MESSAGE"); by just error_report("MESSAGE"); in block device init functions. DEVICE-NAME is bogus in some cases: it's "scsi-disk" for device scsi-hd and scsi-cd, "virtio-blk-pci" for virtio-blk-s390, and "usb-msd" for usb-storage. There is no real nee

Re: [Qemu-devel] [PATCH] qemu-options.hx: fix tls-channel help text

2011-12-21 Thread Stefan Hajnoczi
On Tue, Dec 20, 2011 at 01:05:18PM +0200, Alon Levy wrote: > Remove the default compiled out tunnel channel, add the always available > cursor channel. Optimally the man page would depend on compiled in > options, but that's harder to do. > > RHBZ: 688586 > > Signed-off-by: Alon Levy > --- > qe

Re: [Qemu-devel] [PATCH] qemu-options.hx: fix tls-channel help text

2011-12-21 Thread Stefan Hajnoczi
On Tue, Dec 20, 2011 at 01:05:18PM +0200, Alon Levy wrote: > Remove the default compiled out tunnel channel, add the always available > cursor channel. Optimally the man page would depend on compiled in > options, but that's harder to do. > > RHBZ: 688586 > > Signed-off-by: Alon Levy > --- > qe

[Qemu-devel] Regression: cold plug with device_add fails assertion

2011-12-21 Thread Markus Armbruster
Test case: $ echo -e 'device_add usb-mouse\nq' | qemu-system-x86_64 -vnc :0 -monitor stdio -usb Works in v1.0, doesn't work in master's commit ab0115e1: qemu-system-x86_64: /work/armbru/qemu/hw/qdev.c:97: qdev_create_from_info: Assertion `bus->allow_hotplug' failed. Same for virtio-blk-pci, s

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Strip trailing '\n' from error_report()'s first argument (again)

2011-12-21 Thread Stefan Hajnoczi
On Tue, Dec 20, 2011 at 06:13:08PM +0100, Markus Armbruster wrote: > Commit 6daf194d got rid of them, but Hans and Gerd added some more > lately. Tracked down with this Coccinelle semantic patch: > > @r@ > expression fmt; > position p; > @@ > error_report(fmt, ...)@p > @script:python@

Re: [Qemu-devel] [PATCH] scsi virtio-blk usb-msd: Clean up device init error messages

2011-12-21 Thread Stefan Hajnoczi
On Wed, Dec 21, 2011 at 11:37:57AM +0100, Markus Armbruster wrote: > Replace > > error_report("DEVICE-NAME: MESSAGE"); > > by just > > error_report("MESSAGE"); > > in block device init functions. > > DEVICE-NAME is bogus in some cases: it's "scsi-disk" for device > scsi-hd and scsi-cd,

Re: [Qemu-devel] [PATCH 5/6] hw/omap1.c: Separate clkm from omap_mpu_state

2011-12-21 Thread Peter Maydell
On 21 December 2011 01:38, andrzej zaborowski wrote: > Since this sub device uses parts of the rest of mpu state, it's > (apparently) not a separate device, can we thus skip this change?  I > don't see much value in it and it doesn't simplify code. If you like; I don't have a very strong feeling

Re: [Qemu-devel] [PATCH 00/10] hw/sd.c: Fix various status related bugs

2011-12-21 Thread Peter Maydell
On 21 December 2011 03:54, andrzej zaborowski wrote: > On 18 December 2011 21:37, Peter Maydell wrote: >> This patchset fixes a number of bugs in our SD card emulation > Thanks, I pushed the series.  Some good catches here.  Also thanks to > bug reporter. > > I replaced "card" with "command" in

[Qemu-devel] [Bug 597641] Re: SD card state change from ident to stby

2011-12-21 Thread Peter Maydell
These two issues should now be fixed in qemu git master by commits 25881d3..3799ce4. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/597641 Tit

Re: [Qemu-devel] [PATCH] scsi virtio-blk usb-msd: Clean up device init error messages

2011-12-21 Thread Amit Shah
On (Wed) 21 Dec 2011 [11:37:57], Markus Armbruster wrote: > Replace > > error_report("DEVICE-NAME: MESSAGE"); > > by just > > error_report("MESSAGE"); > > in block device init functions. > > DEVICE-NAME is bogus in some cases: it's "scsi-disk" for device > scsi-hd and scsi-cd, "virtio-

[Qemu-devel] memory: Why subpage is introduced?

2011-12-21 Thread Zhi Yong Wu
HI, For memory management, i have several questions as below: 1.) Why is subpage introduced? what is its goal? 2.) How to render MemoryRegion into one disjoint flatrange list? That rendering function is a bit difficult to understand. Can anyone simply explain it? 3.) What are separately the mea

Re: [Qemu-devel] [PATCH v2 01/10] qapi: add Visitor interfaces for uint*_t and int*_t

2011-12-21 Thread Paolo Bonzini
On 12/20/2011 09:22 PM, Michael Roth wrote: The main goal is to abstract away data serialization schemes (QObject->JSON, C->QEMUFile, etc). Right. And the simplest way to abstract the scheme is to provide a backend-independent representation of device state. As a convention, I'll call: - "

Re: [Qemu-devel] [PATCH v2 01/10] qapi: add Visitor interfaces for uint*_t and int*_t

2011-12-21 Thread Paolo Bonzini
On 12/20/2011 09:56 PM, Anthony Liguori wrote: As always, you can implement that in many ways. However, I think the point of using Visitors is not to remove QEMUFile. Yes, it is. The point of using Visitors is to provide a standard representation of device state. QEMUFile is but one consume

Re: [Qemu-devel] memory: Why subpage is introduced?

2011-12-21 Thread Avi Kivity
On 12/21/2011 02:09 PM, Zhi Yong Wu wrote: > HI, > > For memory management, i have several questions as below: > > 1.) Why is subpage introduced? what is its goal? A TLB entry spans one page; a subpage is a way of dispatching accesses through that tlb entry to various memory regions. > 2.) How to

[Qemu-devel] [PATCH 4/8] Remove support for version 3 ram_load

2011-12-21 Thread Avi Kivity
Version 3 ram_load depends on ram_addrs, which are not stable. Version 4 was introduced in 0.13 (and RHEL 6), so this means live migration from 0.12 and earlier to 1.1 or later will not work. Signed-off-by: Avi Kivity --- arch_init.c | 18 -- 1 files changed, 4 insertions(+),

[Qemu-devel] [PATCH 5/8] Convert ram_load() to the memory API

2011-12-21 Thread Avi Kivity
Signed-off-by: Avi Kivity --- arch_init.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch_init.c b/arch_init.c index 9b8a1f3..381c055 100644 --- a/arch_init.c +++ b/arch_init.c @@ -344,7 +344,7 @@ int ram_save_live(Monitor *mon, QEMUFile *f, int stage, void *opaq

Re: [Qemu-devel] [PATCH v4 04/11] ARM: exynos4210: IRQ subsystem support.

2011-12-21 Thread Peter Maydell
On 19 December 2011 11:53, Evgeny Voevodin wrote: > +static uint64_t exynos4210_gic_cpu_read(void *opaque, target_phys_addr_t > offset, > +        unsigned size) > +{ > +    Exynos4210GicState *s = (Exynos4210GicState *) opaque; > +    DPRINTF_EXYNOS4210_GIC("CPU%d: read offset 0x%x\n", > +    

[Qemu-devel] [PATCH 0/8] Convert live migration to memory API

2011-12-21 Thread Avi Kivity
These patches, on top of "vmstate, memory: decouple vmstate from memory API", convert live migration to use the memory API. Patch 4 is an ABI change, please review carefully. Avi Kivity (8): Store MemoryRegion in RAMBlock Switch ram_save to the memory API Sort RAMBlocks by ID for migration,

Re: [Qemu-devel] [PATCH 3/8] Sort RAMBlocks by ID for migration, not by ram_addr

2011-12-21 Thread Anthony Liguori
On 12/21/2011 07:34 AM, Avi Kivity wrote: ram_addr is (a) unstable (b) going away. Sort by idstr instead. Signed-off-by: Avi Kivity I don't see this as a problem, per say, but this is a significant behavioral change. ram_addr does correspond roughly to the location in memory and historical

Re: [Qemu-devel] [PATCH 4/8] Remove support for version 3 ram_load

2011-12-21 Thread Anthony Liguori
On 12/21/2011 07:34 AM, Avi Kivity wrote: Version 3 ram_load depends on ram_addrs, which are not stable. Version 4 was introduced in 0.13 (and RHEL 6), so this means live migration from 0.12 and earlier to 1.1 or later will not work. Can you please make a note on http://wiki.qemu.org/ChangeLog

Re: [Qemu-devel] [PATCH 0/8] Convert live migration to memory API

2011-12-21 Thread Anthony Liguori
On 12/21/2011 07:34 AM, Avi Kivity wrote: These patches, on top of "vmstate, memory: decouple vmstate from memory API", convert live migration to use the memory API. Patch 4 is an ABI change, please review carefully. Using ram_addr_t for migration was badly, badly broken. I think it's been lo

[Qemu-devel] [PATCH 6/8] memory: obsolete cpu_physical_memory_[gs]et_dirty_tracking()

2011-12-21 Thread Avi Kivity
The getter is no longer used, so it is completely removed. Signed-off-by: Avi Kivity --- arch_init.c |7 +++ cpu-all.h |4 exec-obsolete.h |2 ++ exec.c | 10 -- memory.c|2 ++ 5 files changed, 7 insertions(+), 18 deletions(-) diff -

[Qemu-devel] [PATCH 3/8] Sort RAMBlocks by ID for migration, not by ram_addr

2011-12-21 Thread Avi Kivity
ram_addr is (a) unstable (b) going away. Sort by idstr instead. Signed-off-by: Avi Kivity --- arch_init.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/arch_init.c b/arch_init.c index 2743bfd..8a3f052 100644 --- a/arch_init.c +++ b/arch_init.c @@ -217,12 +217,8

Re: [Qemu-devel] Regression: cold plug with device_add fails assertion

2011-12-21 Thread Anthony Liguori
On 12/21/2011 05:01 AM, Markus Armbruster wrote: Test case: $ echo -e 'device_add usb-mouse\nq' | qemu-system-x86_64 -vnc :0 -monitor stdio -usb Works in v1.0, doesn't work in master's commit ab0115e1: qemu-system-x86_64: /work/armbru/qemu/hw/qdev.c:97: qdev_create_from_info: Assertion `bus-

Re: [Qemu-devel] [RFC] Migration convergence - a suggestion

2011-12-21 Thread Anthony Liguori
On 12/21/2011 03:47 AM, Ronen Hod wrote: On 12/20/2011 03:39 PM, Anthony Liguori wrote: On 12/20/2011 01:06 AM, Ronen Hod wrote: Well the issue is not new, anyhow, following a conversation with Orit ... Since we want the migration to finish, I believe that the "migration speed" parameter alone

Re: [Qemu-devel] [PATCH 01/27] qom: add the base Object class

2011-12-21 Thread Paolo Bonzini
On 12/20/2011 05:51 PM, Anthony Liguori wrote: This class provides the main building block for QEMU Object Model and is extensively documented in the header file. It is largely inspired by GObject. Signed-off-by: Anthony Liguori --- Makefile.objs |2 + hw/object.c | 469 ++

[Qemu-devel] [PATCH 2/8] Switch ram_save to the memory API

2011-12-21 Thread Avi Kivity
Avoid using ram_addr_t, instead use (MemoryRegion *, offset) pairs. Signed-off-by: Avi Kivity --- arch_init.c | 34 ++ 1 files changed, 14 insertions(+), 20 deletions(-) diff --git a/arch_init.c b/arch_init.c index ceef26e..2743bfd 100644 --- a/arch_init.c +++

[Qemu-devel] [PATCH 1/8] Store MemoryRegion in RAMBlock

2011-12-21 Thread Avi Kivity
As a step in moving live migration from RAMBlocks to MemoryRegions, store the MemoryRegion in a RAMBlock. Signed-off-by: Avi Kivity --- cpu-all.h |1 + exec.c|1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/cpu-all.h b/cpu-all.h index 734833a..4acaa8b 100644 --- a

[Qemu-devel] [PATCH 7/8] xen: convert framebuffer dirty tracking to memory API

2011-12-21 Thread Avi Kivity
Signed-off-by: Avi Kivity --- xen-all.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/xen-all.c b/xen-all.c index df70592..8f9db95 100644 --- a/xen-all.c +++ b/xen-all.c @@ -408,7 +408,6 @@ static int xen_sync_dirty_bitmap(XenIOState *state,

[Qemu-devel] [PATCH 8/8] memory: obsolete more dirty memory related functions

2011-12-21 Thread Avi Kivity
No longer used outside memory.c and exec.c. Signed-off-by: Avi Kivity --- cpu-all.h | 49 - exec-obsolete.h | 49 + 2 files changed, 49 insertions(+), 49 deletions(-) diff --git a/cpu-all.h

Re: [Qemu-devel] [PATCH 01/27] qom: add the base Object class

2011-12-21 Thread Anthony Liguori
On 12/21/2011 07:35 AM, Paolo Bonzini wrote: On 12/20/2011 05:51 PM, Anthony Liguori wrote: This class provides the main building block for QEMU Object Model and is extensively documented in the header file. It is largely inspired by GObject. Signed-off-by: Anthony Liguori --- Makefile.objs | 2

Re: [Qemu-devel] [PATCH v2 01/10] qapi: add Visitor interfaces for uint*_t and int*_t

2011-12-21 Thread Anthony Liguori
On 12/21/2011 06:35 AM, Paolo Bonzini wrote: On 12/20/2011 09:56 PM, Anthony Liguori wrote: As always, you can implement that in many ways. However, I think the point of using Visitors is not to remove QEMUFile. Yes, it is. The point of using Visitors is to provide a standard representation

Re: [Qemu-devel] [PATCH v4 04/11] ARM: exynos4210: IRQ subsystem support.

2011-12-21 Thread Evgeny Voevodin
On 12/21/2011 05:50 PM, Peter Maydell wrote: On 19 December 2011 11:53, Evgeny Voevodin wrote: +static uint64_t exynos4210_gic_cpu_read(void *opaque, target_phys_addr_t offset, +unsigned size) +{ +Exynos4210GicState *s = (Exynos4210GicState *) opaque; +DPRINTF_EXYNOS4210_GIC("

Re: [Qemu-devel] [PATCH 3/8] Sort RAMBlocks by ID for migration, not by ram_addr

2011-12-21 Thread Avi Kivity
On 12/21/2011 03:55 PM, Anthony Liguori wrote: > On 12/21/2011 07:34 AM, Avi Kivity wrote: >> ram_addr is (a) unstable (b) going away. Sort by idstr instead. >> >> Signed-off-by: Avi Kivity > > I don't see this as a problem, per say, but this is a significant > behavioral change. ram_addr does co

Re: [Qemu-devel] [PATCH 4/8] Remove support for version 3 ram_load

2011-12-21 Thread Avi Kivity
On 12/21/2011 03:57 PM, Anthony Liguori wrote: > On 12/21/2011 07:34 AM, Avi Kivity wrote: >> Version 3 ram_load depends on ram_addrs, which are not stable. >> Version 4 >> was introduced in 0.13 (and RHEL 6), so this means live migration >> from 0.12 >> and earlier to 1.1 or later will not work.

Re: [Qemu-devel] [PATCH 01/27] qom: add the base Object class

2011-12-21 Thread Paolo Bonzini
On 12/21/2011 03:35 PM, Anthony Liguori wrote: +Type type_register_static(const TypeInfo *info) +{ + Type type = num_types++; + TypeImpl *ti; + + ti =&type_table[type]; + + assert(info->name != NULL); + + printf("Added type %s -> %s\n", info->name, info->parent); + + ti->name = info->name; Why

[Qemu-devel] [PATCH] qemu-io: add option to enable tracing

2011-12-21 Thread Stefan Hajnoczi
It can be useful to enable QEMU tracing when trying out block layer interfaces via qemu-io. Tracing can be enabled using the new -t FILE option where the given file contains a list of trace events to enable (just like the qemu --trace events=FILE option). $ echo qemu_vfree >my-events $ ./qemu

Re: [Qemu-devel] [PATCH v2 01/10] qapi: add Visitor interfaces for uint*_t and int*_t

2011-12-21 Thread Paolo Bonzini
On 12/21/2011 03:45 PM, Anthony Liguori wrote: On 12/21/2011 06:35 AM, Paolo Bonzini wrote: On 12/20/2011 09:56 PM, Anthony Liguori wrote: As always, you can implement that in many ways. However, I think the point of using Visitors is not to remove QEMUFile. Yes, it is. The point of using V

[Qemu-devel] [PATCH v3 0/6] block: zero writes

2011-12-21 Thread Stefan Hajnoczi
This series adds an interface for efficient writes when data contains all zeros. It also takes advantage of this new interface by extending the copy-on-read feature to perform zero-detection. The details of efficient zero representations depend on the image format. This series includes a patch f

[Qemu-devel] [PATCH v3 1/6] cutils: extract buffer_is_zero() from qemu-img.c

2011-12-21 Thread Stefan Hajnoczi
The qemu-img.c:is_not_zero() function checks if a buffer contains all zeroes. This function will come in handy for zero-detection in the block layer, so clean it up and move it to cutils.c. Note that the function now returns true if the buffer is all zeroes. This avoids the double-negatives (i.e.

[Qemu-devel] [PATCH v3 3/6] block: perform zero-detection during copy-on-read

2011-12-21 Thread Stefan Hajnoczi
Copy-on-Read populates the image file with data read from a backing image. In order to avoid bloating the image file when all zeroes are read we should scan the buffer and perform an optimized zero write operation. Signed-off-by: Stefan Hajnoczi --- block.c | 14 +++--- 1 files change

[Qemu-devel] [PATCH v3 4/6] qed: replace is_write with flags field

2011-12-21 Thread Stefan Hajnoczi
Per-request attributes like read/write are currently implemented as bool fields in the QEDAIOCB struct. This becomes unwiedly as the number of attributes grows. For example, the qed_aio_setup() function would have to take multiple bool arguments and at call sites it would be hard to distinguish t

[Qemu-devel] [PATCH v3 2/6] block: add .bdrv_co_write_zeroes() interface

2011-12-21 Thread Stefan Hajnoczi
The ability to zero regions of an image file is a useful primitive for higher-level features such as image streaming or zero write detection. Image formats may support an optimized metadata representation instead of writing zeroes into the image file. This allows zero writes to be potentially fas

[Qemu-devel] [PATCH v3 5/6] qed: add .bdrv_co_write_zeroes() support

2011-12-21 Thread Stefan Hajnoczi
Zero writes are a dedicated interface for writing regions of zeroes into the image file. If clusters are not yet allocated it is possible to use an efficient metadata representation which keeps the image file compact and does not store individual zero bytes. Implementing this for the QED image fo

[Qemu-devel] [PATCH v3 6/6] qemu-io: add write -z option for bdrv_co_write_zeroes

2011-12-21 Thread Stefan Hajnoczi
Extend the qemu-io write command with the -z option to call bdrv_co_write_zeroes(). Exposing the zero write interface from qemu-io allows us to write tests that exercise this new block layer interface. Signed-off-by: Stefan Hajnoczi --- qemu-io.c | 77 +

Re: [Qemu-devel] [PATCH v3 0/6] block: zero writes

2011-12-21 Thread Stefan Hajnoczi
On Wed, Dec 21, 2011 at 4:00 PM, Stefan Hajnoczi wrote: > This series adds an interface for efficient writes when data contains all > zeros.  It also takes advantage of this new interface by extending the > copy-on-read feature to perform zero-detection. > > The details of efficient zero represent

Re: [Qemu-devel] [PATCH v2 01/10] qapi: add Visitor interfaces for uint*_t and int*_t

2011-12-21 Thread Anthony Liguori
On 12/21/2011 09:39 AM, Paolo Bonzini wrote: On 12/21/2011 03:45 PM, Anthony Liguori wrote: On 12/21/2011 06:35 AM, Paolo Bonzini wrote: On 12/20/2011 09:56 PM, Anthony Liguori wrote: As always, you can implement that in many ways. However, I think the point of using Visitors is not to remove

Re: [Qemu-devel] [PATCH 3/9] arm: add missing v7 cp15 registers

2011-12-21 Thread Mark Langsdorf
On 12/20/2011 01:48 PM, Peter Maydell wrote: > On 20 December 2011 19:10, Mark Langsdorf wrote: >> diff --git a/target-arm/helper.c b/target-arm/helper.c >> index 816c4c4..37110bc 100644 >> --- a/target-arm/helper.c >> +++ b/target-arm/helper.c >> @@ -2197,6 +2197,13 @@ uint32_t HELPER(get_cp15)(C

Re: [Qemu-devel] [PATCH v3 1/6] cutils: extract buffer_is_zero() from qemu-img.c

2011-12-21 Thread Eric Blake
On 12/21/2011 09:00 AM, Stefan Hajnoczi wrote: > The qemu-img.c:is_not_zero() function checks if a buffer contains all > zeroes. This function will come in handy for zero-detection in the > block layer, so clean it up and move it to cutils.c. > > Note that the function now returns true if the buf

Re: [Qemu-devel] [PATCH v3 2/6] block: add .bdrv_co_write_zeroes() interface

2011-12-21 Thread Christoph Hellwig
On Wed, Dec 21, 2011 at 04:00:36PM +, Stefan Hajnoczi wrote: > The ability to zero regions of an image file is a useful primitive for > higher-level features such as image streaming or zero write detection. > > Image formats may support an optimized metadata representation instead > of writing

Re: [Qemu-devel] [PATCH v2 01/10] qapi: add Visitor interfaces for uint*_t and int*_t

2011-12-21 Thread Paolo Bonzini
On 12/21/2011 05:24 PM, Anthony Liguori wrote: Ok, I get what you're suggesting. You would like to continue to keep VMStateDescription describing both the QEMUFile format and the fields. I don't "like" to do that, but yes, that's what I'm suggesting. :) You envision having the front-end (stat

Re: [Qemu-devel] [PATCH 00/17] Support mismatched host and guest logical block sizes

2011-12-21 Thread Christoph Hellwig
On Wed, Dec 14, 2011 at 01:40:22PM +0100, Paolo Bonzini wrote: > If the partitions are aligned, the OS will always issue aligned requests, > because file system blocks are already 4k. It won't nessecarily. For example XFS will do a fair amount of sub-blocksize I/O for metadata and the log. Note

Re: [Qemu-devel] [PATCH 00/17] Support mismatched host and guest logical block sizes

2011-12-21 Thread Paolo Bonzini
On 12/21/2011 05:55 PM, Christoph Hellwig wrote: On Wed, Dec 14, 2011 at 01:40:22PM +0100, Paolo Bonzini wrote: If the partitions are aligned, the OS will always issue aligned requests, because file system blocks are already 4k. It won't nessecarily. For example XFS will do a fair amount of s

Re: [Qemu-devel] [RFC] Device isolation infrastructure v2

2011-12-21 Thread Joerg Roedel
On Wed, Dec 21, 2011 at 02:32:35PM +1100, David Gibson wrote: > On Mon, Dec 19, 2011 at 04:41:56PM +0100, Joerg Roedel wrote: > > For 1) I think the current solution with the iommu_group file is fine. > > It is somewhat expensive for user-space to figure out the per-group > > device-sets, but that

[Qemu-devel] [Bug 883136] Re: qemu on ARM hosts aborts on startup because makecontext() always fails

2011-12-21 Thread Dr. David Alan Gilbert
Attached is a 1st cut of a makecontext/setcontext/getcontext/swapcontext set for ARM - not ready to go into libc yet; currently it builds standalone and links (and passes) with a test of mine. Next stop libc and a lot of cleanup. ** Changed in: qemu-linaro Assignee: (unassigned) => Dr. Da

Re: [Qemu-devel] [PATCH 00/25] nbd asynchronous operation

2011-12-21 Thread Paolo Bonzini
On 12/15/2011 12:09 PM, Kevin Wolf wrote: > This needs rebasing due to commit 3a93113 (fix typo: delete redundant > semicolon, 2011-11-29). To avoid further spamming, I placed the whole > thing at git://github.com/bonzini/qemu.git in branch nbd-server. I won't get to this (and virtio-scsi) b

Re: [Qemu-devel] [PATCH 00/25] nbd asynchronous operation

2011-12-21 Thread Anthony Liguori
On 12/21/2011 12:11 PM, Paolo Bonzini wrote: On 12/15/2011 12:09 PM, Kevin Wolf wrote: > This needs rebasing due to commit 3a93113 (fix typo: delete redundant > semicolon, 2011-11-29). To avoid further spamming, I placed the whole > thing at git://github.com/bonzini/qemu.git in branch nbd-server

Re: [Qemu-devel] [PATCH v4 04/11] ARM: exynos4210: IRQ subsystem support.

2011-12-21 Thread Peter Maydell
On 21 December 2011 15:08, Evgeny Voevodin wrote: > On 12/21/2011 05:50 PM, Peter Maydell wrote: >> arm_gic.c exposes the CPU and distributor interfaces as their own >> memory regions now -- you shouldn't need any of this intermediate >> layer of functions. > These functions are not actually for

Re: [Qemu-devel] [PATCH 3/9] arm: add missing v7 cp15 registers

2011-12-21 Thread Peter Maydell
On 21 December 2011 16:37, Mark Langsdorf wrote: > On 12/20/2011 01:48 PM, Peter Maydell wrote: >> This commit leaves the register with a reset value of 0, which >> isn't right (we only implement A9MP, not A9UP, so the reset value >> should be settable by the board at init time somehow depending >

[Qemu-devel] [PATCH 0/5] VFIO core framework

2011-12-21 Thread Alex Williamson
n and the VFIO PCI bus driver, for exposing PCI devices through VFIO, can be found here: git://github.com/awilliam/linux-vfio.git vfio-next-20111221 A development version of qemu which includes a full working vfio-pci driver, indepdendent of KVM support, can be found here: git://github.com/awi

[Qemu-devel] [PATCH 4/5] vfio: VFIO core IOMMU mapping support

2011-12-21 Thread Alex Williamson
Backing for operations on the IOMMU object, including DMA mapping and unmapping. Signed-off-by: Alex Williamson --- drivers/vfio/vfio_iommu.c | 593 + 1 files changed, 593 insertions(+), 0 deletions(-) create mode 100644 drivers/vfio/vfio_iommu.c d

[Qemu-devel] [PATCH 3/5] vfio: VFIO core group interface

2011-12-21 Thread Alex Williamson
This provides the base group management with conduits to the IOMMU driver and VFIO bus drivers. Signed-off-by: Alex Williamson --- drivers/vfio/vfio_main.c| 1201 +++ drivers/vfio/vfio_private.h | 36 + 2 files changed, 1237 insertions(+), 0 deletio

[Qemu-devel] [PATCH 5/5] vfio: VFIO core Kconfig and Makefile

2011-12-21 Thread Alex Williamson
Enable the base code. Signed-off-by: Alex Williamson --- MAINTAINERS |8 drivers/Kconfig |2 ++ drivers/Makefile |1 + drivers/vfio/Kconfig |8 drivers/vfio/Makefile |3 +++ 5 files changed, 22 insertions(+), 0 deletions(-) create mod

[Qemu-devel] [PATCH 1/5] vfio: Introduce documentation for VFIO driver

2011-12-21 Thread Alex Williamson
Including rationale for design, example usage and API description. Signed-off-by: Alex Williamson --- Documentation/vfio.txt | 352 1 files changed, 352 insertions(+), 0 deletions(-) create mode 100644 Documentation/vfio.txt diff --git a/Docum

Re: [Qemu-devel] [PATCH 1/3] virtio-console: Check if chardev backends available before calling into them

2011-12-21 Thread Anthony Liguori
On 12/21/2011 12:58 AM, Amit Shah wrote: For the callback functions invoked by the virtio-serial-bus code, check if we have chardev backends registered before we call into the chardev functions. Signed-off-by: Amit Shah Applied all. Thanks. Regards, Anthony Liguori --- hw/virtio-console

[Qemu-devel] [PATCH 2/5] vfio: VFIO core header

2011-12-21 Thread Alex Williamson
This defines both the user and bus driver APIs. Signed-off-by: Alex Williamson --- Documentation/ioctl/ioctl-number.txt |1 include/linux/vfio.h | 353 ++ 2 files changed, 354 insertions(+), 0 deletions(-) create mode 100644 include/linux/v

Re: [Qemu-devel] [PATCH 8/9] Add xgmac ethernet model

2011-12-21 Thread Mark Langsdorf
On 12/20/2011 02:24 PM, Peter Maydell wrote: > On 20 December 2011 19:15, Mark Langsdorf wrote: >> This adds very basic support for xgmac block. Missing things include: >> >> - statistics counters >> - WoL support >> - rx checksum offload >> - chained descriptors (only linear descriptor ring) >> -

[Qemu-devel] VMDK: footer must take precedence over header when present

2011-12-21 Thread B Gordon
VMDK: footer must take precedence over header when present In e.g. streamOptimized VMDKs from VSphere 4 with this flag set the header l1_table is bogus and only the footer l1_table can be used to correctly read extents. Also reverts recent change to VMDK4Header so order of rgd_ and gd_offset matc

Re: [Qemu-devel] [PATCH] w32: QEMU applications with SDL are always GUI applications

2011-12-21 Thread TeLeMan
-- SUN OF A BEACH On Mon, Dec 19, 2011 at 16:15, Stefan Weil wrote: > Am 19.12.2011 03:12, schrieb TeLeMan: > >> On Sat, Dec 17, 2011 at 07:12, Stefan Weil wrote: >>> >>> Am 16.12.2011 04:24, schrieb TeLeMan: >>> On Sun, Dec 4, 2011 at 05:32, Stefan Weil wrote: > > > Since co

[Qemu-devel] Seem thread Competition

2011-12-21 Thread ZhouPeng
Hi, I meet the err: # virsh dumpxml 63 error: internal error cannot parse json {"timestamp": {"seconds": 1323332828, "microseco{"timest35p":39}, "econds":PICE_D 1CO3233TE828, Dmicrosec "ds"data"52}, : {"ser: "SPrCE_DIS"ONNEC{ED", "port": {"serve ": {6299": "62, "famiamily": "ipv:", "hist": pv4"1

Re: [Qemu-devel] OEM Windows in Qemu

2011-12-21 Thread inbox
Michael, Thanks for the response. Since you wrote the patch I'm using I'd say you are the most qualified to answer questions about it. :) >Note that for winXP, the only thing needed from the bios is to _mention_ - >anywhere in its memory - name of your manufacturer. That is, you can >add any ta

Re: [Qemu-devel] OEM Windows in Qemu

2011-12-21 Thread Michael Tokarev
On 22.12.2011 08:44, in...@expertcomputerrepair.com wrote: [] >> WinXP requires "SLIC version 1.0", which is reduced to just having a string >> with the name of your OEM in the bios (one possible place is the SLIC table). >> More recent version of SLIC (2.1 I think) is needed to activate windows7.

Re: [Qemu-devel] [PATCH] w32: QEMU applications with SDL are always GUI applications

2011-12-21 Thread Stefan Weil
Am 22.12.2011 02:50, schrieb TeLeMan: SDL-1.3 removed the stdio-redirect feature, so we should ignore it. Blue Swirl, can you revert this commit? I'd prefer to keep it. There are good reason why SDL applications are linked as Windows applications by default, so we should use this default. Yes

Re: [Qemu-devel] [PATCH v4 04/11] ARM: exynos4210: IRQ subsystem support.

2011-12-21 Thread Evgeny Voevodin
On 12/22/2011 12:31 AM, Peter Maydell wrote: On 21 December 2011 15:08, Evgeny Voevodin wrote: On 12/21/2011 05:50 PM, Peter Maydell wrote: arm_gic.c exposes the CPU and distributor interfaces as their own memory regions now -- you shouldn't need any of this intermediate layer of functions. T

Re: [Qemu-devel] [PATCH] w32: QEMU applications with SDL are always GUI applications

2011-12-21 Thread TeLeMan
On Thu, Dec 22, 2011 at 14:45, Stefan Weil wrote: > Am 22.12.2011 02:50, schrieb TeLeMan: > >> SDL-1.3 removed the stdio-redirect feature, so we should ignore it. >> >> Blue Swirl, can you revert this commit? > > > I'd prefer to keep it. There are good reason why SDL applications > are linked as W