On 12/21/2011 03:55 PM, Anthony Liguori wrote: > On 12/21/2011 07:34 AM, Avi Kivity wrote: >> ram_addr is (a) unstable (b) going away. Sort by idstr instead. >> >> Signed-off-by: Avi Kivity<a...@redhat.com> > > I don't see this as a problem, per say, but this is a significant > behavioral change. ram_addr does correspond roughly to the location > in memory and historically we would send memory starting from 0 upward > whereas now, the order that we send RAMBlocks will be random for all > intents and purposes. > > Again, I don't think it's a problem, but we should note this in the > commit message in case it creates a problem down the road. >
I (and the new commit message) note that the sort order used to be random a while ago (before b2e0a138e), so this isn't entirely new. -- error compiling committee.c: too many arguments to function
