[Qemu-devel] Contacts DEFISCALISATION et PLACEMENTS FINANCIERS. Jusqu'à 35 contacts offerts en Décembre. Profitez-en!

2011-12-05 Thread Mes-Contacts
Cher(s)  CLIENTS,   cgp(s) indépendant(s), cabinet(s) de commercilisation, promoteur(s)... Rendez-vous sur www.mes-contacts.com (recommandé par les promoteurs) pour obtenir maintenant les meilleurs Contacts entrants en Défiscalisation et Placements financiers (Ass.vie, SCPI,mutuelle,retraite..)

Re: [Qemu-devel] [RFC v2 6/6] Add C version of rtc-test

2011-12-05 Thread Kevin Wolf
Am 02.12.2011 19:43, schrieb Anthony Liguori: > On 12/02/2011 11:45 AM, Kevin Wolf wrote: >> Am 02.12.2011 18:26, schrieb Anthony Liguori: >>> On 12/02/2011 11:25 AM, Kevin Wolf wrote: >>> So that's how you read/write memory. Likewise, for IRQs, you can poll the >>> status of a given IRQ. I thoug

[Qemu-devel] buildbot failure in qemu on monitor_x86_64_debian_6_0

2011-12-05 Thread qemu
The Buildbot has detected a new failure on builder monitor_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/monitor_x86_64_debian_6_0/builds/112 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki

[Qemu-devel] Emulating GPIO input

2011-12-05 Thread Gauresh Rane
Hi, I want to emulate GPIO input(Like a digital square wave from outside to processor) using qemu. What's the good way to do it? Thanks, Regards, Gauresh Rane Grad Student CS Department UCLA

[Qemu-devel] [PULL] VirtFS update

2011-12-05 Thread Aneesh Kumar K.V
Hi, I guess all these patches can be applied to 1.0 stable series. The following changes since commit 1c8a881daaca6fe0646a425b0970fb3ad25f6732: Update version for 1.0 release (2011-12-01 14:04:21 -0600) are available in the git repository at: git://repo.or.cz/qemu/v9fs.git 1.0-fixes Aneesh

[Qemu-devel] [PATCH 3/5] hw/9pfs: Reset server state during TVERSION

2011-12-05 Thread Aneesh Kumar K.V
From: Deepak C Shetty As per the 9p rfc, during TVERSION its necessary to clean all the active fids, so that we start the session from a clean state. Its also needed in scenarios where the guest is booting off 9p, and boot fails, and client restarts, without any knowledge of the past, it will iss

Re: [Qemu-devel] [PATCH for v1.0 1/3] msix: track function masked in pci device state

2011-12-05 Thread Michael S. Tsirkin
On Sun, Dec 04, 2011 at 04:47:17PM -0700, Cam Macdonell wrote: > On Sun, Dec 4, 2011 at 3:20 AM, Michael S. Tsirkin wrote: > > On Fri, Dec 02, 2011 at 04:34:21PM -0700, Cam Macdonell wrote: > >> Based on a git bisect, this patch breaks msi-x interrupt delivery in > >> the ivshmem device. > > > > I

Re: [Qemu-devel] [PATCH 01/18] qom: add new dynamic property infrastructure based on Visitors

2011-12-05 Thread Kevin Wolf
Am 02.12.2011 19:47, schrieb Anthony Liguori: > On 12/01/2011 09:52 AM, Kevin Wolf wrote: >> Am 30.11.2011 22:03, schrieb Anthony Liguori: >>> + >>> +void qdev_property_add(DeviceState *dev, const char *name, const char >>> *type, >>> + DevicePropertyEtter *get, DevicePropert

[Qemu-devel] [PATCH 4/5] hw/9pfs: Add qdev.reset callback for virtio-9p-pci device

2011-12-05 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" Add the device reset callback Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p-device.c |3 ++- hw/virtio-pci.c|2 +- hw/virtio-pci.h|1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/9pfs/virtio-9p-device.c

[Qemu-devel] [PATCH 2/5] hw/9pfs: use migration blockers to prevent live migration when virtfs export path is mounted

2011-12-05 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" Now when you try to migrate with VirtFS export path mounted, you get a proper QMP error: (qemu) migrate tcp:localhost: Migration is disabled when VirtFS export path '/tmp/' is mounted in the guest using mount_tag 'v_tmp' (qemu) Signed-off-by: Aneesh Kumar K.V ---

Re: [Qemu-devel] sub-page-sized mmio regions and address passed to read/write fns

2011-12-05 Thread Avi Kivity
On 12/04/2011 11:15 PM, Peter Maydell wrote: > On 4 December 2011 12:17, Avi Kivity wrote: > > On 12/02/2011 04:49 PM, Peter Maydell wrote: > >> However what I found is that the addresses passed to the read/write > >> functions aren't what I would expect. For instance if the board > >> maps the co

[Qemu-devel] [PATCH 1/5] hw/9pfs: Improve portability to older systems

2011-12-05 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" handle fs driver require a set of newly added syscalls. Don't Compile handle FS driver if those syscalls are not available. Instead of adding #ifdef for all those syscalls we check for open by handle syscall. If that is available then rest of the syscalls used by the driv

[Qemu-devel] [PATCH 5/5] hw/9pfs: Use the correct file descriptor in Fsdriver Callback

2011-12-05 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" Fsdriver callback that operate on file descriptor need to differentiate between directory fd and file fd. Based on the original patch from Sassan Panahinejad Signed-off-by: Aneesh Kumar K.V --- fsdev/file-op-9p.h |4 ++-- hw/9pfs/cofile.c |4

Re: [Qemu-devel] [Bug 899140] Re: Problem with Linux Kernel Traffic Control

2011-12-05 Thread Stefan Hajnoczi
On Sun, Dec 04, 2011 at 03:54:12PM -, Vincent Autefage wrote: > The result without TC is about 120 Mbit/s. > I check the bandwidth with lot of programs (not only with Iperf) and the > result is also the same > > However, if I use the same raw image and the same TC configuration with > th

Re: [Qemu-devel] [PATCH 2/2] ppc_prep: convert ioport to memory API

2011-12-05 Thread Benoît Canet
> I'll test later. Did you in some way? > After testing it occurs this patch is plain wrong.It make qemu segfault. I'll try to fix it. Regards Benoit

Re: [Qemu-devel] [PATCH v2 00/18] qom: dynamic properties and composition tree (v2)

2011-12-05 Thread Paolo Bonzini
On 12/04/2011 10:01 PM, Anthony Liguori wrote: I've begun the work of introducing proper inheritance. There's a lot going on but the basic idea is: 1) introduce QOM base type (Object), make qdev inherit from it 2) create a dynamic typeinfo based DeviceInfo, make device class point to device

Re: [Qemu-devel] [RFC][PATCH 14/16] kvm: x86: Add user space part for in-kernel i8259

2011-12-05 Thread Avi Kivity
On 12/04/2011 11:38 PM, Jan Kiszka wrote: > > > > It should be also possible to migrate from non-KVM device to KVM > > version, different names would prevent that for ever. > > It is (theoretically) possible with these patches as the vmstate names > are the same. KVM to TCG migration does not work

Re: [Qemu-devel] [PATCH v2 3/6] memory: introduce memory_region_set_alias_offset()

2011-12-05 Thread Avi Kivity
On 12/04/2011 11:34 PM, Blue Swirl wrote: > On Sun, Dec 4, 2011 at 18:09, Avi Kivity wrote: > > Add an API to update an alias offset of an active alias. This can be > > used to simplify implementation of dynamic memory banks. > > > > */ > > -void memory_region_set_address(MemoryRegion *mr, targe

Re: [Qemu-devel] [RFC][PATCH 02/16] kvm: Move kvmclock into hw/kvm folder

2011-12-05 Thread Andreas Färber
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 03.12.2011 23:33, schrieb Jan Kiszka: > On 2011-12-03 20:00, Andreas Färber wrote: >> Am 03.12.2011 12:17, schrieb Jan Kiszka: >>> diff --git a/hw/kvmclock.c b/hw/kvm/clock.c similarity index >>> 96% rename from hw/kvmclock.c rename to hw/kvm/clock.

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.0 release

2011-12-05 Thread Daniel P. Berrange
On Thu, Dec 01, 2011 at 03:23:37PM -0600, Anthony Liguori wrote: > Hi, > > On behalf of the QEMU Team, I'd like to announce the availability of > QEMU 1.0! Great to see the release out now. Could you clarify the intention for release numbering from this point onwards. Is it correct to say that s

Re: [Qemu-devel] [Bug 899140] Re: Problem with Linux Kernel Traffic Control

2011-12-05 Thread Vincent Autefage
Hi, So we have another problem... The thing is that the 0.14.0 (and all 0.14.0 rc) built from GIT has the same problem. However, the package 0.14.0 from Ubuntu does not has this bug... Le 05/12/2011 09:26, Stefan Hajnoczi a écrit : > On Sun, Dec 04, 2011 at 03:54:12PM -, Vincent Autefage wr

[Qemu-devel] [PATCH] exec.c: Allow memory region start_addr and region_offset to vary in low bits

2011-12-05 Thread Peter Maydell
Fix a long-standing deficiency of cpu_register_physical_memory_log() where the start address and region offset had to have the same low bits (otherwise the IO functions would be passed an incorrect address offset). This was most likely to bite when registering memory regions which started at a non-

Re: [Qemu-devel] [Bug 899140] Re: Problem with Linux Kernel Traffic Control

2011-12-05 Thread Stefan Hajnoczi
On Mon, Dec 5, 2011 at 10:45 AM, Vincent Autefage <899...@bugs.launchpad.net> wrote: > So we have another problem... > The thing is that the 0.14.0 (and all 0.14.0 rc) built from GIT has the > same problem. > However, the package 0.14.0 from Ubuntu does not has this bug... Okay, that's actually a

Re: [Qemu-devel] [PATCH v4 7/8] block: core copy-on-read logic

2011-12-05 Thread Stefan Hajnoczi
On Fri, Dec 2, 2011 at 5:13 PM, Marcelo Tosatti wrote: > On Wed, Nov 23, 2011 at 11:47:57AM +, Stefan Hajnoczi wrote: >> Signed-off-by: Stefan Hajnoczi >> --- >>  block.c      |   72 >> ++ >>  trace-events |    1 + >>  2 files changed,

Re: [Qemu-devel] [RFC][PATCH 14/16] kvm: x86: Add user space part for in-kernel i8259

2011-12-05 Thread Jan Kiszka
On 2011-12-05 11:01, Avi Kivity wrote: > On 12/04/2011 11:38 PM, Jan Kiszka wrote: >>> >>> It should be also possible to migrate from non-KVM device to KVM >>> version, different names would prevent that for ever. >> >> It is (theoretically) possible with these patches as the vmstate names >> are t

Re: [Qemu-devel] [PATCH v4 3/8] block: add request tracking

2011-12-05 Thread Marcelo Tosatti
On Wed, Nov 23, 2011 at 11:47:53AM +, Stefan Hajnoczi wrote: > The block layer does not know about pending requests. This information > is necessary for copy-on-read since overlapping requests must be > serialized to prevent races that corrupt the image. > > The BlockDriverState gets a new tr

Re: [Qemu-devel] [PATCH v4 3/8] block: add request tracking

2011-12-05 Thread Paolo Bonzini
On 12/05/2011 01:17 PM, Marcelo Tosatti wrote: There is no need to worry about synchronous read/write requests bypassing this interface, correct? Synchronous read/write requests do not exist anymore (in the sense that they also go through coroutines). Paolo

Re: [Qemu-devel] [Bug 899140] Re: Problem with Linux Kernel Traffic Control

2011-12-05 Thread Vincent Autefage
Yes this is the package that seems to not include the bug. I'm going to check sources of this package. Vincent Autefage Le 05/12/2011 12:11, Stefan Hajnoczi a écrit : > On Mon, Dec 5, 2011 at 10:45 AM, Vincent Autefage > <899...@bugs.launchpad.net> wrote: >> So we have another problem... >> Th

Re: [Qemu-devel] [RFC][PATCH 14/16] kvm: x86: Add user space part for in-kernel i8259

2011-12-05 Thread Avi Kivity
On 12/05/2011 01:37 PM, Jan Kiszka wrote: > On 2011-12-05 11:01, Avi Kivity wrote: > > On 12/04/2011 11:38 PM, Jan Kiszka wrote: > >>> > >>> It should be also possible to migrate from non-KVM device to KVM > >>> version, different names would prevent that for ever. > >> > >> It is (theoretically) p

Re: [Qemu-devel] [PATCH v2 0/8] [RFC] vmstate: Add copyrights for all cpus

2011-12-05 Thread Juan Quintela
Andreas Färber wrote: > Am 27.11.2011 14:30, schrieb Juan Quintela: >> Andreas Färber wrote: >>> Hi Juan, >>> >>> Am 23.11.2011 16:44, schrieb Juan Quintela: [ Resnd this time also ading fabrice address, sorry ] v2: - split patches by file, make easier to add "acked-by" notice

Re: [Qemu-devel] [RFC][PATCH 14/16] kvm: x86: Add user space part for in-kernel i8259

2011-12-05 Thread Jan Kiszka
On 2011-12-05 13:36, Avi Kivity wrote: > On 12/05/2011 01:37 PM, Jan Kiszka wrote: >> On 2011-12-05 11:01, Avi Kivity wrote: >>> On 12/04/2011 11:38 PM, Jan Kiszka wrote: > > It should be also possible to migrate from non-KVM device to KVM > version, different names would prevent that f

Re: [Qemu-devel] [ICON] Quinn the Qemu emu gazes ahead thoughtfully, considering what the future holds

2011-12-05 Thread Luiz Capitulino
On Fri, 2 Dec 2011 12:43:44 +0700 Mulyadi Santosa wrote: > On Wed, Nov 30, 2011 at 21:41, Alex Bradbury wrote: > > I lack drawing skills, so took a vectorised version of the public > > domain emu drawing [1] from openclipart (currently down...). A lot of > > talk has been about a new Qemu "icon"

Re: [Qemu-devel] [PATCH V3] Guest stop notification

2011-12-05 Thread Eric B Munson
On Sat, 03 Dec 2011, Jan Kiszka wrote: > On 2011-12-02 22:27, Eric B Munson wrote: > > On Fri, 02 Dec 2011, Jan Kiszka wrote: > > > >> On 2011-12-02 20:19, Eric B Munson wrote: > >>> Often when a guest is stopped from the qemu console, it will report > >>> spurious > >>> soft lockup warnings on

Re: [Qemu-devel] [PATCH v2 0/8] [RFC] vmstate: Add copyrights for all cpus

2011-12-05 Thread Andreas Färber
Am 05.12.2011 13:45, schrieb Juan Quintela: > Andreas Färber wrote: >> Am 27.11.2011 14:30, schrieb Juan Quintela: >>> Andreas Färber wrote: I did have another comment regarding the "Based on" part that you haven't responded to yet. >>> >>> Sorry, forgot about that one. What text do yo

Re: [Qemu-devel] [RFC][PATCH 14/16] kvm: x86: Add user space part for in-kernel i8259

2011-12-05 Thread Avi Kivity
On 12/05/2011 02:47 PM, Jan Kiszka wrote: > > > > (the memory API added unstable names, hopefully the QOM can take over > > the stable ones and we'll have a good way to denote the unstable ones). > > > > OK, maybe - or likely - we should make those device models have the same > names in QOM once

Re: [Qemu-devel] [PATCH v4 2/3] Extract code to nbd_setup function to be used for many purposes

2011-12-05 Thread Stefan Hajnoczi
On Mon, Dec 5, 2011 at 5:46 AM, Chunyan Liu wrote: > 2011/12/3 Paolo Bonzini >> >> On 12/02/2011 04:27 PM, Chunyan Liu wrote: >>> >>> @@ -42,6 +42,18 @@ static int verbose; >>>  static char *device; >>>  static char *srcpath; >>>  static char *sockpath; >>> +static int is_sockpath_option; >>> +st

Re: [Qemu-devel] [RFC][PATCH 14/16] kvm: x86: Add user space part for in-kernel i8259

2011-12-05 Thread Jan Kiszka
On 2011-12-05 14:14, Avi Kivity wrote: > On 12/05/2011 02:47 PM, Jan Kiszka wrote: >>> >>> (the memory API added unstable names, hopefully the QOM can take over >>> the stable ones and we'll have a good way to denote the unstable ones). >>> >> >> OK, maybe - or likely - we should make those device

Re: [Qemu-devel] [PATCH V3] Guest stop notification

2011-12-05 Thread Marcelo Tosatti
On Sat, Dec 03, 2011 at 12:45:51PM +0100, Jan Kiszka wrote: > >> I was referring to the relation between the IOCTL and kvmclock, but > >> IOCTL vs. kvm_run. > >> > >> Jan > > > > Ah, OK. Yes, we better characterize it as KVMCLOCK specific (a generic > > "guest is paused" command is not the scope o

Re: [Qemu-devel] [RFC][PATCH 14/16] kvm: x86: Add user space part for in-kernel i8259

2011-12-05 Thread Avi Kivity
On 12/05/2011 03:29 PM, Jan Kiszka wrote: > On 2011-12-05 14:14, Avi Kivity wrote: > > On 12/05/2011 02:47 PM, Jan Kiszka wrote: > >>> > >>> (the memory API added unstable names, hopefully the QOM can take over > >>> the stable ones and we'll have a good way to denote the unstable ones). > >>> > >>

Re: [Qemu-devel] [PATCH] exec.c: Allow memory region start_addr and region_offset to vary in low bits

2011-12-05 Thread Avi Kivity
On 12/05/2011 01:01 PM, Peter Maydell wrote: > Fix a long-standing deficiency of cpu_register_physical_memory_log() > where the start address and region offset had to have the same low > bits (otherwise the IO functions would be passed an incorrect address > offset). This was most likely to bite wh

Re: [Qemu-devel] [PATCH V3] Guest stop notification

2011-12-05 Thread Jan Kiszka
On 2011-12-05 14:35, Marcelo Tosatti wrote: > On Sat, Dec 03, 2011 at 12:45:51PM +0100, Jan Kiszka wrote: I was referring to the relation between the IOCTL and kvmclock, but IOCTL vs. kvm_run. Jan >>> >>> Ah, OK. Yes, we better characterize it as KVMCLOCK specific (a generic >>>

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.0 release

2011-12-05 Thread Anthony Liguori
On 12/05/2011 04:51 AM, Daniel P. Berrange wrote: On Thu, Dec 01, 2011 at 03:23:37PM -0600, Anthony Liguori wrote: Hi, On behalf of the QEMU Team, I'd like to announce the availability of QEMU 1.0! Great to see the release out now. Could you clarify the intention for release numbering from t

Re: [Qemu-devel] [PATCH 0/3] block: fix and detect qemu_aio_wait() issues

2011-12-05 Thread Kevin Wolf
Am 30.11.2011 13:23, schrieb Stefan Hajnoczi: > This series fixes an issue where qemu_aio_flush() would return to IDE hardware > emulation with requests still pending. Kevin Wolf found it > in the block tree before qemu.git/master merge, so qemu.git/master is not > affected and these patches are

Re: [Qemu-devel] [RFC][PATCH 14/16] kvm: x86: Add user space part for in-kernel i8259

2011-12-05 Thread Jan Kiszka
On 2011-12-05 14:36, Avi Kivity wrote: > On 12/05/2011 03:29 PM, Jan Kiszka wrote: >> On 2011-12-05 14:14, Avi Kivity wrote: >>> On 12/05/2011 02:47 PM, Jan Kiszka wrote: > > (the memory API added unstable names, hopefully the QOM can take over > the stable ones and we'll have a good wa

Re: [Qemu-devel] [PATCH] exec.c: Allow memory region start_addr and region_offset to vary in low bits

2011-12-05 Thread Peter Maydell
On 5 December 2011 13:40, Avi Kivity wrote: > On 12/05/2011 01:01 PM, Peter Maydell wrote: >> @@ -2677,7 +2674,11 @@ void >> cpu_register_physical_memory_log(target_phys_addr_t start_addr, >>      if (phys_offset == IO_MEM_UNASSIGNED) { >>          region_offset = start_addr; >>      } >> -    re

Re: [Qemu-devel] [PATCH] exec.c: Allow memory region start_addr and region_offset to vary in low bits

2011-12-05 Thread Avi Kivity
On 12/05/2011 04:01 PM, Peter Maydell wrote: > On 5 December 2011 13:40, Avi Kivity wrote: > > On 12/05/2011 01:01 PM, Peter Maydell wrote: > >> @@ -2677,7 +2674,11 @@ void > >> cpu_register_physical_memory_log(target_phys_addr_t start_addr, > >> if (phys_offset == IO_MEM_UNASSIGNED) { > >>

[Qemu-devel] KVM call agenda for 12/6 (Tuesday) @ 10am US/Eastern

2011-12-05 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Proposal (from Anthony): > 1. A short introduction to each of the guest agents, what guests they > support, and what verbs they support. > 2. A short description of key requirements from each party (oVirt, > libvirt, QEMU) for

[Qemu-devel] [PULL 00/41] Block patches

2011-12-05 Thread Kevin Wolf
The following changes since commit 1c8a881daaca6fe0646a425b0970fb3ad25f6732: Update version for 1.0 release (2011-12-01 14:04:21 -0600) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Dong Xu Wang (1): block: Add coroutine_fn marker to coroutine func

[Qemu-devel] [PATCH 01/41] qcow2: Unlock during COW

2011-12-05 Thread Kevin Wolf
Unlocking during COW allows for more parallelism. One change it requires is that buffers are dynamically allocated instead of just using a per-image buffer. While touching the code, drop the synchronous qcow2_read() function and replace it by a bdrv_read() call. Signed-off-by: Kevin Wolf --- bl

[Qemu-devel] [PATCH 24/41] vvfat: convert to .bdrv_co_is_allocated()

2011-12-05 Thread Kevin Wolf
From: Stefan Hajnoczi It is trivial to switch from the synchronous .bdrv_is_allocated() interface to .bdrv_co_is_allocated() since vvfat_is_allocated() does not block. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/vvfat.c |4 ++-- 1 files changed, 2 insertions(+), 2 d

[Qemu-devel] [PATCH 19/41] qcow2: Fix error path in qcow2_snapshot_load_tmp

2011-12-05 Thread Kevin Wolf
If the bdrv_read() of the snapshot's L1 table fails, return the right error code and make sure that the old L1 table is still loaded and we don't break the BlockDriverState completely. Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi --- block/qcow2-snapshot.c | 34 +

[Qemu-devel] [PATCH 18/41] qcow2: Fix order in qcow2_snapshot_delete

2011-12-05 Thread Kevin Wolf
First the snapshot must be deleted and only then the refcounts can be decreased. Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi --- block/qcow2-snapshot.c | 48 +--- 1 files changed, 33 insertions(+), 15 deletions(-) diff --git a/block/qcow

[Qemu-devel] [PATCH 17/41] qcow2: Fix order of refcount updates in qcow2_snapshot_goto

2011-12-05 Thread Kevin Wolf
The refcount updates must be moved so that in the worst case we can get cluster leaks, but refcounts may never be too low. Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi --- block/qcow2-refcount.c |7 - block/qcow2-snapshot.c | 61 ++

[Qemu-devel] [PATCH 23/41] block: convert qcow2, qcow2, and vmdk to .bdrv_co_is_allocated()

2011-12-05 Thread Kevin Wolf
From: Stefan Hajnoczi The qcow2, qcow, and vmdk block drivers are based on coroutines. They have a coroutine mutex which protects internal state. We can convert the .bdrv_is_allocated() function to .bdrv_co_is_allocated() by holding the mutex around the cluster lookup operation. Signed-off-by:

[Qemu-devel] [PATCH 29/41] qemu-common: add QEMU_ALIGN_DOWN() and QEMU_ALIGN_UP() macros

2011-12-05 Thread Kevin Wolf
From: Stefan Hajnoczi Add macros for aligning a number to a multiple, for example: QEMU_ALIGN_DOWN(500, 2000) = 0 QEMU_ALIGN_UP(500, 2000) = 2000 Since ALIGN_UP() is a common macro name use the QEMU_* namespace prefix. Hopefully this will protect us from included headers that leak something wit

[Qemu-devel] [PATCH 30/41] coroutine: add qemu_co_queue_restart_all()

2011-12-05 Thread Kevin Wolf
From: Stefan Hajnoczi It's common to wake up all waiting coroutines. Introduce the qemu_co_queue_restart_all() function to do this instead of looping over qemu_co_queue_next() in every caller. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/qcow2.c |2 +- qemu-

[Qemu-devel] [PATCH 27/41] block: drop .bdrv_is_allocated() interface

2011-12-05 Thread Kevin Wolf
From: Stefan Hajnoczi Now that all block drivers have been converted to .bdrv_co_is_allocated() we can drop .bdrv_is_allocated(). Note that the public bdrv_is_allocated() interface is still available but is in fact a synchronous wrapper around .bdrv_co_is_allocated(). Signed-off-by: Stefan Hajn

Re: [Qemu-devel] [PATCH] Rename get_tls to tls_var

2011-12-05 Thread Paolo Bonzini
On 12/05/2011 03:18 PM, Jan Kiszka wrote: get_tls() can serve as a lvalue as well, so 'get' might be confusing. Signed-off-by: Jan Kiszka --- cpu-all.h |2 +- qemu-tls.h |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cpu-all.h b/cpu-all.h index 5f47ab8..

Re: [Qemu-devel] [RFC v2 1/6] qtest: add test framework

2011-12-05 Thread Luiz Capitulino
On Thu, 1 Dec 2011 12:43:27 -0600 Anthony Liguori wrote: > The idea behind qtest is pretty simple. Instead of executing a CPU via TCG or > KVM, rely on an external process to send events to the device model that the > CPU > would normally generate. > > qtest presents itself as an accelerator.

Re: [Qemu-devel] [RFC v2 5/6] Add RTC test case

2011-12-05 Thread Luiz Capitulino
On Thu, 1 Dec 2011 12:43:31 -0600 Anthony Liguori wrote: I think it's a good idea to use python's unittest module and write tests as unit-tests (eg. using asserts instead of writing results as strings). > --- > rtc-test.py | 105 > +++ >

[Qemu-devel] [PATCH 26/41] cow: convert to .bdrv_co_is_allocated()

2011-12-05 Thread Kevin Wolf
From: Stefan Hajnoczi The cow block driver does not keep internal state for cluster lookups. This means it is safe to perform cluster lookups in coroutine context without risk of race conditions that corrupt internal state. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/co

Re: [Qemu-devel] [PATCH v2 00/18] qom: dynamic properties and composition tree (v2)

2011-12-05 Thread Anthony Liguori
On 12/05/2011 03:52 AM, Paolo Bonzini wrote: On 12/04/2011 10:01 PM, Anthony Liguori wrote: I've begun the work of introducing proper inheritance. There's a lot going on but the basic idea is: 1) introduce QOM base type (Object), make qdev inherit from it 2) create a dynamic typeinfo based

[Qemu-devel] [PATCH 37/41] cow: use bdrv_co_is_allocated()

2011-12-05 Thread Kevin Wolf
From: Stefan Hajnoczi Now that bdrv_co_is_allocated() is available we can use it instead of the synchronous bdrv_is_allocated() interface. This is a follow-up that Kevin Wolf pointed out after applying the series that introduces bdrv_co_is_allocated(). It is safe to make cow_read() a coroutine

[Qemu-devel] [PATCH 06/41] block: add the blockio limits command line support

2011-12-05 Thread Kevin Wolf
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block.c | 39 +++ block.h |4 block_int.h | 29 + blockdev.c | 44 +

[Qemu-devel] [PATCH v2 0/4]: Improve QMP visitor unit-tests

2011-12-05 Thread Luiz Capitulino
This series introduces two new test programs: test-qmp-output-visitor and test-qmp-input-visitor. As their names suggest, they contain unit-tests to check QMP's Visitor implementation. They supersede the test-visitor program (which is dropped by this series). Besides adding new unit-tests, I've _

[Qemu-devel] [PATCH 4/4] Drop test-visitor

2011-12-05 Thread Luiz Capitulino
It has been superseded by the two previous commits, which introduced the test-qmp-output-visitor and test-qmp-input-visitor tests. Signed-off-by: Luiz Capitulino --- Makefile |5 +- test-visitor.c | 338 2 files changed, 1 inser

[Qemu-devel] [PATCH 1/4] configure: Don't mix glib and libcheck tests

2011-12-05 Thread Luiz Capitulino
test-coroutine is listed as a libcheck test in the 'checks' variable. This is not right because 'make check' won't run test-coroutine if libcheck tests are not enabled (either because libcheck isn't detected or because --disable-check-utests is passed). Tests using the glib test framework are inde

Re: [Qemu-devel] [PATCH v2 00/18] qom: dynamic properties and composition tree (v2)

2011-12-05 Thread Peter Maydell
On 5 December 2011 14:36, Anthony Liguori wrote: > On 12/05/2011 03:52 AM, Paolo Bonzini wrote: > struct SCSIBus { >   Interface parent; >   void (*command_complete)(SCSIBus *bus, SCSIRequest *req); > }; > > TypeInfo scsi_bus_info = { >   .name = TYPE_SCSI_BUS, >   .parent = TYPE_INTERFACE, > }; >

[Qemu-devel] [PATCH 13/41] qcow2: Update snapshot table information at once

2011-12-05 Thread Kevin Wolf
Failing in the middle wouldn't help with the integrity of the image, so doing everything in a single request seems better. Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi --- block/qcow2-snapshot.c | 22 ++ 1 files changed, 10 insertions(+), 12 deletions(-) diff --

[Qemu-devel] [PATCH 02/41] qcow2: avoid reentrant bdrv_read() in copy_sectors()

2011-12-05 Thread Kevin Wolf
From: Stefan Hajnoczi A BlockDriverState should not issue requests on itself through the public block layer interface. Nested, or reentrant, requests are problematic because they do I/O throttling and request tracking twice. Features like block layer copy-on-read use request tracking to avoid r

Re: [Qemu-devel] Boot from disk problem

2011-12-05 Thread Ignacio Geli
El 02/12/11 18:47, Artyom Tarasenko escribió: On Fri, Dec 2, 2011 at 1:48 PM, Ignacio Geli wrote: El 01/12/11 07:29, Artyom Tarasenko escribió: On Sat, Nov 26, 2011 at 9:01 AM, Blue Swirl wrote: On Fri, Nov 25, 2011 at 18:24, Ignacio Geli wrote: El 25/11

[Qemu-devel] [PATCH 35/41] block: core copy-on-read logic

2011-12-05 Thread Kevin Wolf
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block.c | 72 ++ trace-events |1 + 2 files changed, 73 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index ca0e8ec..dd5d5ca 100

[Qemu-devel] [PATCH 36/41] block: add -drive copy-on-read=on|off

2011-12-05 Thread Kevin Wolf
From: Stefan Hajnoczi This patch adds the -drive copy-on-read=on|off command-line option: copy-on-read=on|off copy-on-read is "on" or "off" and enables whether to copy read backing file sectors into the image file. Copy-on-read avoids accessing the same backing file sectors repeatedly a

[Qemu-devel] [PATCH 20/41] block: use public bdrv_is_allocated() interface

2011-12-05 Thread Kevin Wolf
From: Stefan Hajnoczi There is no need for bdrv_commit() to use the BlockDriver .bdrv_is_allocated() interface directly. Converting to the public interface gives us the freedom to drop .bdrv_is_allocated() entirely in favor of a new .bdrv_co_is_allocated() in the future. Signed-off-by: Stefan H

Re: [Qemu-devel] [PATCH v2 00/18] qom: dynamic properties and composition tree (v2)

2011-12-05 Thread Anthony Liguori
On 12/05/2011 08:50 AM, Peter Maydell wrote: On 5 December 2011 14:36, Anthony Liguori wrote: struct LSIDevice { PCIDevice parent; }; static void lsi_command_complete(SCSIBus *bus, SCSIRequest *req) { LSIDevice *dev = LSI_DEVICE(bus); ... } What is the LSI_DEVICE macro actually doi

[Qemu-devel] [PATCH 07/41] CoQueue: introduce qemu_co_queue_wait_insert_head

2011-12-05 Thread Kevin Wolf
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- qemu-coroutine-lock.c |8 qemu-coroutine.h |6 ++ 2 files changed, 14 insertions(+), 0 deletions(-) diff --git a/qemu-coroutine-lock.c b/qemu-coroutine-lock.c i

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.0 release

2011-12-05 Thread Alex Jia
Hi Anthony, It seems the following link is unavailable now: http://wiki.qemu.org/download/qemu-1.0.tar.gz Regards, Alex - Original Message - From: "Anthony Liguori" To: "qemu-devel" Sent: Friday, December 2, 2011 5:23:37 AM Subject: [Qemu-devel] [ANNOUNCE] QEMU 1.0 release Hi, On beh

[Qemu-devel] [PATCH 14/41] qcow2: Cleanups and memleak fix in qcow2_snapshot_create

2011-12-05 Thread Kevin Wolf
sn->id_str could be leaked before this. The rest of this patch changes comments, fixes coding style or removes checks that are unnecessary with g_malloc. Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi --- block/qcow2-snapshot.c | 26 +++--- 1 files changed, 11 inse

[Qemu-devel] [PATCH] Rename get_tls to tls_var

2011-12-05 Thread Jan Kiszka
get_tls() can serve as a lvalue as well, so 'get' might be confusing. Signed-off-by: Jan Kiszka --- cpu-all.h |2 +- qemu-tls.h |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cpu-all.h b/cpu-all.h index 5f47ab8..016 100644 --- a/cpu-all.h +++ b/cpu-all.h @@

[Qemu-devel] [PATCH 08/41] block: add I/O throttling algorithm

2011-12-05 Thread Kevin Wolf
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block.c | 234 +++ block.h |1 + block_int.h |1 + 3 files changed, 236 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH 21/41] block: add .bdrv_co_is_allocated()

2011-12-05 Thread Kevin Wolf
From: Stefan Hajnoczi This patch adds the .bdrv_co_is_allocated() interface which is identical to .bdrv_is_allocated() but runs in coroutine context. Running in coroutine context implies that other coroutines might be performing I/O at the same time. Therefore it must be safe to run while the

[Qemu-devel] [PATCH 3/4] Introduce test-qmp-input-visitor

2011-12-05 Thread Luiz Capitulino
Contains unit-tests for the QMP input visitor implementation. Signed-off-by: Luiz Capitulino --- Makefile |5 +- configure|2 +- test-qmp-input-visitor.c | 270 ++ 3 files changed, 275 insertions(+), 2 deletions

[Qemu-devel] [PATCH 31/41] block: add request tracking

2011-12-05 Thread Kevin Wolf
From: Stefan Hajnoczi The block layer does not know about pending requests. This information is necessary for copy-on-read since overlapping requests must be serialized to prevent races that corrupt the image. The BlockDriverState gets a new tracked_request list field which contains all pending

[Qemu-devel] [PATCH 34/41] block: request overlap detection

2011-12-05 Thread Kevin Wolf
From: Stefan Hajnoczi Detect overlapping requests and remember to align to cluster boundaries if the image format uses them. This assumes that allocating I/O is performed in cluster granularity - which is true for qcow2, qed, etc. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf ---

[Qemu-devel] [PATCH 40/41] block: wait_for_overlapping_requests() deadlock detection

2011-12-05 Thread Kevin Wolf
From: Stefan Hajnoczi Debugging a reentrant request deadlock was fun but in the future we need a quick and obvious way of detecting such bugs. Add an assert that checks we are not about to deadlock when waiting for another request. Suggested-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi Signe

[Qemu-devel] [PATCH 12/41] qcow2: Return real error code in qcow2_write_snapshots

2011-12-05 Thread Kevin Wolf
Doesn't immediately fix anything as the callers don't use the return value, but they will be fixed next. Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi --- block/qcow2-snapshot.c | 48 ++-- 1 files changed, 38 insertions(+), 10 deletions(-)

[Qemu-devel] [PATCH 03/41] qed: adjust the way to get nb_sectors

2011-12-05 Thread Kevin Wolf
From: Zhi Yong Wu This patch is only to refactor some lines of codes to get better and more robust codes. As you have seen, in qed_read_table_cb() it's nice to use qiov->size because that function doesn't obviously use a single struct iovec. In other two functions, if qiov use more than one st

[Qemu-devel] [PATCH 05/41] block: Use bdrv functions to replace file operation in cow.c

2011-12-05 Thread Kevin Wolf
From: Li Zhi Hui Since common file operation functions lack of error detection, so change them to bdrv series functions. Signed-off-by: Li Zhi Hui Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/cow.c | 34 -- 1 files changed, 16 insertions(

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.0 release

2011-12-05 Thread Anthony Liguori
On 12/05/2011 09:06 AM, Alex Jia wrote: Hi Anthony, It seems the following link is unavailable now: http://wiki.qemu.org/download/qemu-1.0.tar.gz The VM is crashing pretty often. We're working on a migration plan that will resolve this problem. I'll post dates once I can confirm them. The

Re: [Qemu-devel] [RFC v2 0/6] qtest unit test framework

2011-12-05 Thread Anthony Liguori
On 12/04/2011 04:03 AM, Dor Laor wrote: On 12/01/2011 08:43 PM, Anthony Liguori wrote: This series is still pretty rough but I wanted to get an idea of what people thought about it before polishing it. The general idea is outlined in the first test. The main advantage of this type of test frame

[Qemu-devel] [PATCH 41/41] block: convert qemu_aio_flush() calls to bdrv_drain_all()

2011-12-05 Thread Kevin Wolf
From: Stefan Hajnoczi Many places in QEMU call qemu_aio_flush() to complete all pending asynchronous I/O. Most of these places actually want to drain all block requests but there is no block layer API to do so. This patch introduces the bdrv_drain_all() API to wait for requests across all Block

Re: [Qemu-devel] [PULL][1.1] Memory API conversions

2011-12-05 Thread Anthony Liguori
On 11/29/2011 05:47 AM, Avi Kivity wrote: Please pull from git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/batch to receive the final batch of mmio conversions to the memory API (note that ioports still use the old API). While there may be a few regressions in there, it will be a

[Qemu-devel] [PATCH 09/41] hmp/qmp: add block_set_io_throttle

2011-12-05 Thread Kevin Wolf
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block.c | 15 + blockdev.c | 59 ++ blockdev.h |2 + hmp-commands.hx | 15 + hm

Re: [Qemu-devel] [PULL 00/15] Trivial patches for 24 November to 2 December 2011

2011-12-05 Thread Anthony Liguori
On 12/02/2011 07:50 AM, Stefan Hajnoczi wrote: First post-1.0 trivial-patches pull request. We should get through the backlog within 2 weeks. The following changes since commit 1c8a881daaca6fe0646a425b0970fb3ad25f6732: Update version for 1.0 release (2011-12-01 14:04:21 -0600) are availabl

Re: [Qemu-devel] [PATCH v2 00/18] qom: dynamic properties and composition tree (v2)

2011-12-05 Thread Peter Maydell
On 5 December 2011 15:04, Anthony Liguori wrote: > On 12/05/2011 08:50 AM, Peter Maydell wrote: >> >> On 5 December 2011 14:36, Anthony Liguori  wrote: >>> >>> struct LSIDevice { >>> >>>    PCIDevice parent; >>> }; >>> >>> static void lsi_command_complete(SCSIBus *bus, SCSIRequest *req) >>> { >>>

[Qemu-devel] [PATCH 11/41] qcow2: Return real error code in qcow2_read_snapshots

2011-12-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi --- block/qcow2-snapshot.c | 25 - block/qcow2.c |5 +++-- 2 files changed, 23 insertions(+), 7 deletions(-) diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c index bdc33ba..4134bbc 100644 -

[Qemu-devel] [PATCH 33/41] block: wait for overlapping requests

2011-12-05 Thread Kevin Wolf
From: Stefan Hajnoczi When copy-on-read is enabled it is necessary to wait for overlapping requests before issuing new requests. This prevents races between the copy-on-read and a write request. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block.c | 35 +

[Qemu-devel] [PATCH 22/41] qed: convert to .bdrv_co_is_allocated()

2011-12-05 Thread Kevin Wolf
From: Stefan Hajnoczi The bdrv_qed_is_allocated() function is a synchronous wrapper around qed_find_cluster(), which performs the cluster lookup. In order to convert the synchronous function to a coroutine function we yield instead of using qemu_aio_wait(). Note that QED's cache is already safe

[Qemu-devel] [PATCH 25/41] vdi: convert to .bdrv_co_is_allocated()

2011-12-05 Thread Kevin Wolf
From: Stefan Hajnoczi It is trivial to switch from the synchronous .bdrv_is_allocated() interface to .bdrv_co_is_allocated() since vdi_is_allocated() does not block. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/vdi.c |6 +++--- 1 files changed, 3 insertions(+), 3 del

[Qemu-devel] [PATCH 38/41] dma-helpers: Add trace events

2011-12-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi --- dma-helpers.c | 10 ++ trace-events |7 +++ 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/dma-helpers.c b/dma-helpers.c index bdcd38c..9d6b6fa 100644 --- a/dma-helpers.c +++ b/dma-helpers.c @@ -9,6 +9

  1   2   3   >