Re: [Qemu-devel] qemu-img vmdk converted from iso not accepted by vSphere

On Thu, Oct 20, 2011 at 9:35 PM, Rich Wellum wrote: > > On Oct 20, 2011, at 2:17 PM, Stefan Hajnoczi wrote: > >> On Thu, Oct 20, 2011 at 10:54 AM, Rich Wellum wrote: >>> Hi Stefan, qemu-img >>> qemu-img version 0.15.50, Copyright (c) 2004-2008 Fabrice Bellard >>> I haven't got this to work o

[Qemu-devel] [Bug 855633] Re: guest boots up too slowly

I found this bug in memory/queue branch of qemu.git on September 21st. As some codes in memory branch were merged into master branch, the master tree of qemu.git also has this issue now. ** Description changed: - qemu.git commit: 6cc7686696f73ae87cadef4450776a488b0e0c8b + qemu.git (memory/queue b

[Qemu-devel] [Bug 855664] Re: 64-bit windows guest cannot boot up

I found this bug in memory/queue branch of qemu.git on September 21st. As some codes in memory branch were merged into master branch, the master tree of qemu.git also has this issue now. ** Description changed: - qemu.git commit: 6cc7686696f73ae87cadef4450776a488b0e0c8b + qemu.git (memory/queue b

Re: [Qemu-devel] [Bug 824650] [NEW] Latest GIT assert error in arp_table.c

Hi, 2011/9/15 Jan Kiszka : > On 2011-09-15 15:20, Roy Tam wrote: >> 2011/9/15 Jan Kiszka : >>> On 2011-09-15 14:05, Roy Tam wrote: Here you go. sb16: warning: command 0xf,1 is not truly understood yet sb16: warning: command 0xe,2 is not truly understood yet [Switching to T

Re: [Qemu-devel] KVM call agenda for October 25

Am 25.10.2011 16:06, schrieb Anthony Liguori: > On 10/25/2011 08:56 AM, Kevin Wolf wrote: >> Am 25.10.2011 15:05, schrieb Anthony Liguori: >>> I'd be much more open to changing the default mode to cache=none FWIW since >>> the >>> risk of data loss there is much, much lower. >> >> I think people s

[Qemu-devel] [Bug 739088] Re: I/O errors after "Save/Restore"

** Description changed: qemu-kvm commit: b73357ecd2b14c057134cb71d29447b5b988c516 ( Author: Marcelo Tosatti Date: Wed Mar 16 17:04:16 2011 -0300) kvm commit: a72e315c509376bbd1e121219c3ad9f23973923f After restoring from saved img, some I/O errors appear in dmesg and file system

Re: [Qemu-devel] KVM call agenda for October 25

Kevin Wolf writes: > Am 25.10.2011 16:06, schrieb Anthony Liguori: >> On 10/25/2011 08:56 AM, Kevin Wolf wrote: >>> Am 25.10.2011 15:05, schrieb Anthony Liguori: I'd be much more open to changing the default mode to cache=none FWIW since the risk of data loss there is much, much l

[Qemu-devel] [virtio-spec: RFC PATCH] virtio-spec: introduce VIRTIO_NET_F_GUEST_ANNOUNCE

Network connections in guest need to be kept after migration. This is done by sending gratuitous packet and let switch learn new port of the mac address. As hypervisor does not have the knowledge of guest network configurations such as tagged vlan or ipv6, it may require guest to send gratuitous pa

[Qemu-devel] buildbot failure in qemu on default_s390

The Buildbot has detected a new failure on builder default_s390 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_s390/builds/49 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: qemu-s390.opensuse.org Build Reaso

Re: [Qemu-devel] [Bug 824650] [NEW] Latest GIT assert error in arp_table.c

On 2011-10-26 10:03, Roy Tam wrote: > Hi, > > 2011/9/15 Jan Kiszka : >> On 2011-09-15 15:20, Roy Tam wrote: >>> 2011/9/15 Jan Kiszka : On 2011-09-15 14:05, Roy Tam wrote: > Here you go. > > sb16: warning: command 0xf,1 is not truly understood yet > sb16: warning: command 0xe,2

Re: [Qemu-devel] KVM call agenda for October 25

On 10/26/2011 10:48 AM, Markus Armbruster wrote: Sector size is a device property. If the user asks for a 4K sector disk, and the backend can't support that, we need to reject the configuration. Just like we reject read-only backends for read/write disks. Isn't it the other way round, i.e. th

Re: [Qemu-devel] KVM call agenda for October 25

On Wed, Oct 26, 2011 at 10:48:12AM +0200, Markus Armbruster wrote: > Kevin Wolf writes: > > > Am 25.10.2011 16:06, schrieb Anthony Liguori: > >> On 10/25/2011 08:56 AM, Kevin Wolf wrote: > >>> Am 25.10.2011 15:05, schrieb Anthony Liguori: > I'd be much more open to changing the default mode

Re: [Qemu-devel] [PATCH v3] add add-cow file format

Please find version 4 in the attachment. 2011/10/23 shu ming : > On 2011-10-13 0:23, Dong Xu Wang wrote: >> >> Add add-cow file format >> >> Signed-off-by: Dong Xu Wang >> --- >>  Makefile.objs          |    1 + >>  block.c                |    2 +- >>  block.h                |    1 + >>  block/add

[Qemu-devel] [PATCH] kvm_init didn't set return value after create vm failed

kvm_init didn't set return value after create vm failed. And kvm_ioctl(s, KVM_CREATE_VM, 0)'s return value can be < -1, so change the check of vmfd at label 'err'. Signed-off-by: Xu He Jie --- kvm-all.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/kvm-all.c b/kvm-

Re: [Qemu-devel] Executing from a rom device - Re: [PATCH 2/4] pc: Support system flash memory with pflash

On 10/25/2011 11:06 PM, Jordan Justen wrote: > Avi, all, > > Would it be acceptable to implement the pflash support for qemu only > at this time? If kvm is enabled, I could install ram (in read-only > mode) as is done today for the firmware to execute from. Certainly. > Later, when the additiona

[Qemu-devel] [PATCH] migration: flush migration data to disk.

This patch increases robustness when migrating to a file with two little changes: (1) Before closing the migration file handle checks if it happens to be a regular file and if so it issues a fsync. This way the data is flushed to disk before qemu sends the migration completed event. (

Re: [Qemu-devel] [PATCH] kvm_init didn't set return value after create vm failed

On 2011-10-26 12:19, Xu He Jie wrote: > kvm_init didn't set return value after create vm failed. > > And kvm_ioctl(s, KVM_CREATE_VM, 0)'s return value can be < -1, > so change the check of vmfd at label 'err'. > > Signed-off-by: Xu He Jie > --- > kvm-all.c |3 ++- > 1 files changed, 2 inse

[Qemu-devel] [PATCH] ahci: fix DPRINTF format strings

Signed-off-by: Max Filippov --- hw/ide/ahci.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 1c7e3a0..0af201d 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -327,7 +327,7 @@ static void ahci_mem_write(void *opaque, t

[Qemu-devel] [PATCH] kvm: x86: Drop redundant apic base and tpr update from kvm_get_sregs

The latter was already commented out, the former is redundant as well. We always get the latest changes after return from the guest via kvm_arch_post_run. Signed-off-by: Jan Kiszka --- target-i386/kvm.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/target-i386/kvm.

Re: [Qemu-devel] KVM call agenda for October 25

Paolo Bonzini writes: > On 10/26/2011 10:48 AM, Markus Armbruster wrote: >> Sector size is a device property. >> >> If the user asks for a 4K sector disk, and the backend can't support >> that, we need to reject the configuration. Just like we reject >> read-only backends for read/write disks. >

Re: [Qemu-devel] KVM call agenda for October 25

Am 26.10.2011 11:57, schrieb Daniel P. Berrange: > On Wed, Oct 26, 2011 at 10:48:12AM +0200, Markus Armbruster wrote: >> Kevin Wolf writes: >> >>> Am 25.10.2011 16:06, schrieb Anthony Liguori: On 10/25/2011 08:56 AM, Kevin Wolf wrote: > Am 25.10.2011 15:05, schrieb Anthony Liguori: >>

Re: [Qemu-devel] qemu-img vmdk converted from iso not accepted by vSphere

cheers,||RichOn Oct 26, 2011, at 3:43 AM, Stefan Hajnoczi wrote:On Thu, Oct 20, 2011 at 9:35 PM, Rich Wellum wrote:On Oct 20, 2011, at 2:17 PM, Stefan Hajnoczi wrote:On Thu, Oct 20, 2011 at 10:54 AM, Rich Wellum wrote:Hi Stefan,qemu-imgqemu-img version

Re: [Qemu-devel] KVM call agenda for October 25

On Wed, Oct 26, 2011 at 01:23:05PM +0200, Kevin Wolf wrote: > Am 26.10.2011 11:57, schrieb Daniel P. Berrange: > > On Wed, Oct 26, 2011 at 10:48:12AM +0200, Markus Armbruster wrote: > >> Kevin Wolf writes: > >> > >>> Am 25.10.2011 16:06, schrieb Anthony Liguori: > On 10/25/2011 08:56 AM, Kevi

Re: [Qemu-devel] [PATCH 1/5] monitor: screen_dump async

On Tue, Oct 25, 2011 at 04:41:18PM -0200, Luiz Capitulino wrote: > On Tue, 25 Oct 2011 15:21:11 +0200 > Alon Levy wrote: > > > On Tue, Oct 25, 2011 at 10:51:30AM -0200, Luiz Capitulino wrote: > > > On Tue, 25 Oct 2011 12:13:09 +0200 > > > Alon Levy wrote: > > > > > > > On Mon, Oct 24, 2011 at 1

Re: [Qemu-devel] KVM call agenda for October 25

Am 26.10.2011 13:39, schrieb Daniel P. Berrange: > On Wed, Oct 26, 2011 at 01:23:05PM +0200, Kevin Wolf wrote: >> Am 26.10.2011 11:57, schrieb Daniel P. Berrange: >>> On Wed, Oct 26, 2011 at 10:48:12AM +0200, Markus Armbruster wrote: Kevin Wolf writes: > Am 25.10.2011 16:06, schrieb

[Qemu-devel] [RFC] Implement qword CPU access to device MMIO regions

From: Max Filippov For newly developed device verification we need to be able to distinguish qword and dword access to its MMIO regions from CPU. This goal is achieved with the following steps: - io_mem_read[3] and io_mem_write[3] are used for the ldq/stq callbacks; - softmmu io_read and io_writ

[Qemu-devel] [PATCH 1/7] block: Remove dead code

Signed-off-by: Kevin Wolf --- block.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index 0b7bc06..86d450c 100644 --- a/block.c +++ b/block.c @@ -2039,11 +2039,7 @@ const char *bdrv_get_encrypted_filename(BlockDriverState *bs) void bdrv_get_back

[Qemu-devel] [PATCH 0/7] block: Collection of unrelated simple fixes

This fixes some misc block layer bugs that Coverity pointed at. Kevin Wolf (7): block: Remove dead code block: Fix bdrv_open use after free qcow: Fix bdrv_write_compressed error handling ide: Fix off-by-one error in array index check vmdk: Fix use of uninitialised value vmdk: Improve e

[Qemu-devel] [PATCH 2/7] block: Fix bdrv_open use after free

tmp_filename was used outside the block it was defined in, i.e. after it went out of scope. Move its declaration to the top level. Signed-off-by: Kevin Wolf --- block.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block.c b/block.c index 86d450c..9dbb572 100644 --- a

[Qemu-devel] [PATCH 7/7] vmdk: Fix possible segfaults

Data we read from the disk isn't necessarily null terminated and may not contain the string we're looking for. The code needs to be a bit more careful here. Signed-off-by: Kevin Wolf --- block/vmdk.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/block/vmdk.c b/bl

[Qemu-devel] [PATCH 3/7] qcow: Fix bdrv_write_compressed error handling

Signed-off-by: Kevin Wolf --- block/qcow.c | 30 +++--- 1 files changed, 19 insertions(+), 11 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index ab36b29..35e21eb 100644 --- a/block/qcow.c +++ b/block/qcow.c @@ -736,8 +736,6 @@ static int qcow_write_compressed(B

[Qemu-devel] [PATCH 4/7] ide: Fix off-by-one error in array index check

Signed-off-by: Kevin Wolf --- hw/ide/core.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 280a117..29305d3 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -2039,7 +2039,7 @@ static int ide_drive_pio_post_load(void *opaque, int ver

Re: [Qemu-devel] [Qemu-trivial] [PATCH] exec.c: Remove useless comment

On Fri, Oct 21, 2011 at 05:57:09PM +0800, 陳韋任 wrote: > As phys_ram_size had been removed since QEMU 0.12. Remove the useless > comment. > > Signed-off-by: Chen Wen-Ren > --- > exec.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) Thanks, applied to the trivial patches tree: http

[Qemu-devel] [PATCH 6/7] vmdk: Improve error handling

Return the right error values in some more places. Signed-off-by: Kevin Wolf --- block/vmdk.c | 21 +++-- 1 files changed, 15 insertions(+), 6 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 6cdbfb7..fa0e8bd 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -212,8 +2

[Qemu-devel] [PATCH 0/0] Add mention of iSCSI devices to manpage

List Following patch adds a new section to the manpage to describe the special URL syntax used for various block backends. It adds a subsection with examples on the newly added iSCSI backend. Perhaps all other backeds can be added with examples to this section as well? In which case I add patch

[Qemu-devel] [PATCH] Documentation: add new section for device URL syntax for special files and describe the iSCSI URL with examples

Signed-off-by: Ronnie Sahlberg --- qemu-options.hx | 42 ++ 1 files changed, 42 insertions(+), 0 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 5d2a776..7c434f8 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -148,6 +148,9 @@ De

Re: [Qemu-devel] [Qemu-trivial] [PATCH] tools: reorganize Makefile variables

On Mon, Oct 24, 2011 at 01:33:01PM +0200, Paolo Bonzini wrote: > - Add all dependencies of the block layer to block-obj-y, and all > dependencies of QObject to qobject-obj-y > > - Remove the block layer from tools-obj-y, add it to qemu-img, qemu-nbd, > qemu-io > > - Add qobject-obj-y and tool

Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value)

On Mon, Oct 24, 2011 at 10:18:43PM +0200, Stefan Weil wrote: > For compilations with -DNDEBUG, the default case did not return > a value which caused a compiler warning. > > Signed-off-by: Stefan Weil > --- > hw/ppce500_spin.c | 11 --- > 1 files changed, 8 insertions(+), 3 deletions(-

[Qemu-devel] [PATCH 5/7] vmdk: Fix use of uninitialised value

In error cases, cid is never set. Signed-off-by: Kevin Wolf --- block/vmdk.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 6be592f..6cdbfb7 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -208,7 +208,7 @@ static void vmdk_free_last_ex

Re: [Qemu-devel] [PATCH] migration: flush migration data to disk.

Gerd Hoffmann wrote: > This patch increases robustness when migrating to a file with > two little changes: > > (1) Before closing the migration file handle checks if it happens to be > a regular file and if so it issues a fsync. This way the data is > flushed to disk before qemu sends

Re: [Qemu-devel] [PATCH 01/12] Fix typo: buf -> bus

On Mon, Oct 24, 2011 at 09:52:38PM +0200, Hervé Poussineau wrote: > > Signed-off-by: Hervé Poussineau > --- > hw/audiodev.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to the trivial patches tree: http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivia

Re: [Qemu-devel] [PATCH 5/7] vmdk: Fix use of uninitialised value

On Wed, Oct 26, 2011 at 4:31 PM, Kevin Wolf wrote: > In error cases, cid is never set. > > Signed-off-by: Kevin Wolf This fix is already in the qemu-trivial queue: http://repo.or.cz/w/qemu/stefanha.git/commit/8379e46d1fd681b8aa4714382e2cdab05e5d0575 -- Pavel > --- >  block/vmdk.c |    2 +- >

Re: [Qemu-devel] [Qemu-trivial] [PATCH] ahci: fix DPRINTF format strings

On Wed, Oct 26, 2011 at 03:06:14PM +0400, Max Filippov wrote: > Signed-off-by: Max Filippov > --- > hw/ide/ahci.c | 16 ++-- > 1 files changed, 10 insertions(+), 6 deletions(-) Thanks, applied to the trivial patches tree: http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/tr

Re: [Qemu-devel] [PATCH] Documentation: fix typo

On Tue, Oct 25, 2011 at 10:22:18AM +0200, Bernhard Reutner-Fischer wrote: > Signed-off-by: Bernhard Reutner-Fischer > --- > qemu-doc.texi |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to the trivial patches tree: http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs

Re: [Qemu-devel] [PATCH 01/12] Fix typo: buf -> bus

On Mon, Oct 24, 2011 at 09:52:38PM +0200, Hervé Poussineau wrote: > > Signed-off-by: Hervé Poussineau > --- > hw/audiodev.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to the trivial patches tree: http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivia

Re: [Qemu-devel] [PATCH] kvm_init didn't set return value after create vm failed

于 2011年10月26日 19:03, Jan Kiszka 写道: On 2011-10-26 12:19, Xu He Jie wrote: kvm_init didn't set return value after create vm failed. And kvm_ioctl(s, KVM_CREATE_VM, 0)'s return value can be< -1, so change the check of vmfd at label 'err'. Signed-off-by: Xu He Jie --- kvm-all.c |3 ++- 1

Re: [Qemu-devel] [PATCH 5/7] vmdk: Fix use of uninitialised value

Am 26.10.2011 15:21, schrieb Pavel Borzenkov: > On Wed, Oct 26, 2011 at 4:31 PM, Kevin Wolf wrote: >> In error cases, cid is never set. >> >> Signed-off-by: Kevin Wolf > > This fix is already in the qemu-trivial queue: > http://repo.or.cz/w/qemu/stefanha.git/commit/8379e46d1fd681b8aa4714382e2cda

Re: [Qemu-devel] [PATCH] Make cpu_single_env thread local (Linux only for now)

On 5 October 2011 10:21, Paolo Bonzini wrote: [tls patches] > If interested people can test the patches more and submit them more > formally, I'd be very glad.  I wrote it for RCU, but of course that one is > not really going to be 1.0 material (even for 9p). For the record (since I think we only

[Qemu-devel] [PATCH 03/10] vmdk: vmdk_read_cid returns garbage if p_name is NULL

From: Pavel Borzenkov Spotted by Clang Analyzer Signed-off-by: Pavel Borzenkov Signed-off-by: Stefan Hajnoczi --- block/vmdk.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 3969131..a75dcc2 100644 --- a/block/vmdk.c +++ b/block/vmd

[Qemu-devel] [PATCH 10/10] ahci: fix DPRINTF format strings

From: Max Filippov Signed-off-by: Max Filippov Signed-off-by: Stefan Hajnoczi --- hw/ide/ahci.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 1c7e3a0..0af201d 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -327,7

[Qemu-devel] [PATCH 05/10] qed: remove unneeded variable assignment

From: Pavel Borzenkov 'ret' is unconditionally overwitten by qed_read_l1_table_sync() Spotted by Clang Analyzer Signed-off-by: Pavel Borzenkov Signed-off-by: Stefan Hajnoczi --- block/qed.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/block/qed.c b/block/qed.c ind

[Qemu-devel] [PATCH 09/10] Documentation: fix typo

From: Bernhard Reutner-Fischer Signed-off-by: Bernhard Reutner-Fischer Signed-off-by: Stefan Hajnoczi --- qemu-doc.texi |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-doc.texi b/qemu-doc.texi index ad19b73..149e9bd 100644 --- a/qemu-doc.texi +++ b/qemu-doc.texi

Re: [Qemu-devel] [PATCH] Make cpu_single_env thread local (Linux only for now)

On 10/26/2011 04:03 PM, Peter Maydell wrote: For the record (since I think we only talked about this on IRC): * the POSIX TLS fallback code doesn't work on Linux hosts for linux-user emulation (the constructor is never called to set up the TLS for the main thread, probably something to

[Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

Hi folks: We've captured a regression with floppy disk on recent qemu (and qemu-kvm, after a code merge). We bisected it to be caused by: commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8 Author: Richard Henderson Date: Mon Aug 15 15:08:45 2011 -0700 fdc: Convert to isa_register_portio_l

[Qemu-devel] [PATCH 07/10] tools: reorganize Makefile variables

From: Paolo Bonzini - Add all dependencies of the block layer to block-obj-y, and all dependencies of QObject to qobject-obj-y - Remove the block layer from tools-obj-y, add it to qemu-img, qemu-nbd, qemu-io - Add qobject-obj-y and tools-obj-y wherever useful, remove duplicates Signed-off-

[Qemu-devel] New Memory API Question

Sorry for coming late to the party on this... I only read qemu-devel through a filter so I missed all the discussions on the new memory API. I have a question as to how it works and how it's supposed to work in certain scenarios. It's a question of flow. I'm following the code path through the

Re: [Qemu-devel] [PATCH] Make cpu_single_env thread local (Linux only for now)

On 26 October 2011 15:39, Paolo Bonzini wrote: > On 10/26/2011 04:03 PM, Peter Maydell wrote: >> >> For the record (since I think we only talked about this on IRC): >>  * the POSIX TLS fallback code doesn't work on Linux hosts for >>    linux-user emulation (the constructor is never called to set

[Qemu-devel] [PULL 00/10] Trivial patches for October 15 to 26 2011

The following changes since commit d300854b1ccd036e0d7c58d789f4ab8d372263e6: target-sparc: Fix use of g_new0 / g_free (2011-10-25 19:30:33 +) are available in the git repository at: ssh://repo.or.cz/srv/git/qemu/stefanha.git trivial-patches Bernhard Reutner-Fischer (1): Documentati

[Qemu-devel] [PATCH 00/10] pxa2xx: memory API conversions

Convert most of pxa2xx periferal to memory API. pxa2xx_dmai.c was intact appart because it use cpu_physical_memory_read/write internal and seems special. Benoît Canet (10): pxa2xx_gpio: convert to memory API pxa2xx_pcmcia.c: convert common memory space to memory API pxa2xx_pcmcia.c: convert

[Qemu-devel] [PATCH 01/10] pxa2xx_gpio: convert to memory API

Signed-off-by: Benoit Canet --- hw/pxa2xx_gpio.c | 29 +++-- 1 files changed, 11 insertions(+), 18 deletions(-) diff --git a/hw/pxa2xx_gpio.c b/hw/pxa2xx_gpio.c index 200b0cf..f7464fe 100644 --- a/hw/pxa2xx_gpio.c +++ b/hw/pxa2xx_gpio.c @@ -16,6 +16,7 @@ typedef struct

[Qemu-devel] [PATCH 03/10] pxa2xx_pcmcia.c: convert attribute memory space to memory API

Signed-off-by: Benoit Canet --- hw/pxa2xx_pcmcia.c | 31 ++- 1 files changed, 14 insertions(+), 17 deletions(-) diff --git a/hw/pxa2xx_pcmcia.c b/hw/pxa2xx_pcmcia.c index 51ed72a..94811fc 100644 --- a/hw/pxa2xx_pcmcia.c +++ b/hw/pxa2xx_pcmcia.c @@ -12,10 +12,12 @@

[Qemu-devel] [PATCH 02/10] pxa2xx_pcmcia.c: convert common memory space to memory API

Signed-off-by: Benoit Canet --- hw/pxa2xx_pcmcia.c | 31 ++- 1 files changed, 14 insertions(+), 17 deletions(-) diff --git a/hw/pxa2xx_pcmcia.c b/hw/pxa2xx_pcmcia.c index 74c6817..51ed72a 100644 --- a/hw/pxa2xx_pcmcia.c +++ b/hw/pxa2xx_pcmcia.c @@ -10,17 +10,19 @@

[Qemu-devel] [PATCH 05/10] pxa2xx_pcmcia.c: merge calls to get_system_memory()

Signed-off-by: Benoit Canet --- hw/pxa2xx_pcmcia.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/pxa2xx_pcmcia.c b/hw/pxa2xx_pcmcia.c index f428bd1..8538cca 100644 --- a/hw/pxa2xx_pcmcia.c +++ b/hw/pxa2xx_pcmcia.c @@ -120,6 +120,7 @@ static void pxa2xx_pcmcia_s

[Qemu-devel] [PATCH 04/10] pxa2xx_pcmcia.c: convert io memory space to memory API

Signed-off-by: Benoit Canet --- hw/pxa2xx_pcmcia.c | 31 +-- 1 files changed, 13 insertions(+), 18 deletions(-) diff --git a/hw/pxa2xx_pcmcia.c b/hw/pxa2xx_pcmcia.c index 94811fc..f428bd1 100644 --- a/hw/pxa2xx_pcmcia.c +++ b/hw/pxa2xx_pcmcia.c @@ -18,6 +18,7 @@ str

[Qemu-devel] [PATCH 07/10] pxa2xx_timer: convert to memory API

Signed-off-by: Benoit Canet --- hw/pxa2xx_timer.c | 28 1 files changed, 12 insertions(+), 16 deletions(-) diff --git a/hw/pxa2xx_timer.c b/hw/pxa2xx_timer.c index 4235e42..38dd8e0 100644 --- a/hw/pxa2xx_timer.c +++ b/hw/pxa2xx_timer.c @@ -12,6 +12,7 @@ #include "

[Qemu-devel] [PATCH 10/10] pxa2xx_lcd: convert to memory API

Signed-off-by: Benoit Canet --- hw/pxa2xx_lcd.c | 30 +- 1 files changed, 13 insertions(+), 17 deletions(-) diff --git a/hw/pxa2xx_lcd.c b/hw/pxa2xx_lcd.c index b73290c..2ab3c3b 100644 --- a/hw/pxa2xx_lcd.c +++ b/hw/pxa2xx_lcd.c @@ -14,6 +14,7 @@ /* FIXME: For grap

Re: [Qemu-devel] [PATCH] Make cpu_single_env thread local (Linux only for now)

On 10/26/2011 04:54 PM, Peter Maydell wrote: On 26 October 2011 15:39, Paolo Bonzini wrote: On 10/26/2011 04:03 PM, Peter Maydell wrote: For the record (since I think we only talked about this on IRC): * the POSIX TLS fallback code doesn't work on Linux hosts for linux-user emulation (t

Re: [Qemu-devel] [PATCH] Make cpu_single_env thread local (Linux only for now)

On 2011-10-26 16:54, Peter Maydell wrote: > On 26 October 2011 15:39, Paolo Bonzini wrote: >> On 10/26/2011 04:03 PM, Peter Maydell wrote: >>> >>> For the record (since I think we only talked about this on IRC): >>> * the POSIX TLS fallback code doesn't work on Linux hosts for >>>linux-user e

Re: [Qemu-devel] [PATCH] Make cpu_single_env thread local (Linux only for now)

On 26 October 2011 16:02, Jan Kiszka wrote: > On 2011-10-26 16:54, Peter Maydell wrote: >> On 26 October 2011 15:39, Paolo Bonzini wrote: >>> On 10/26/2011 04:03 PM, Peter Maydell wrote: For the record (since I think we only talked about this on IRC):  * the POSIX TLS fallback code

[Qemu-devel] [PATCH 08/10] pxa2xx_pic: convert to memory API

The ARM documentation say transfers between the cpu and the coprocessor are 32 bits wide. Use 4 as size for coprocessor read and writes. Signed-off-by: Benoit Canet --- hw/pxa2xx_pic.c | 31 +-- 1 files changed, 13 insertions(+), 18 deletions(-) diff --git a/hw/pxa

Re: [Qemu-devel] [PATCH] Make cpu_single_env thread local (Linux only for now)

On 2011-10-26 17:09, Peter Maydell wrote: > On 26 October 2011 16:02, Jan Kiszka wrote: >> On 2011-10-26 16:54, Peter Maydell wrote: >>> On 26 October 2011 15:39, Paolo Bonzini wrote: On 10/26/2011 04:03 PM, Peter Maydell wrote: > > For the record (since I think we only talked about

Re: [Qemu-devel] [PATCH] Make cpu_single_env thread local (Linux only for now)

On 26 October 2011 16:13, Jan Kiszka wrote: > My point is that it is fine to use for per-vcpu variables because: >  - they are single-threaded in TCG mode >  - they are multi-threaded in KVM mode, but that's only affecting Linux >   hosts for which this TLS wrapper is already usable Oh, I see. Fe

[Qemu-devel] [PATCH 04/10] qed: don't pass NULL to memcpy

From: Pavel Borzenkov Spotted by Clang Analyzer [Note this memcpy call has always been safe because the length will be 0 when the pointer is NULL] Signed-off-by: Pavel Borzenkov Signed-off-by: Stefan Hajnoczi --- block/qed.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) di

[Qemu-devel] [PATCH 01/10] device_tree: Fix potential memory leak

From: Stefan Weil cppcheck error report: device_tree.c:156: error: Memory leak: dupname Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- device_tree.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/device_tree.c b/device_tree.c index dc69232..86a694c 10

[Qemu-devel] [PATCH 09/10] pxa2xx_mmci: convert to memory API.

Convert mechanicaly; the access size of the old_mmio fields seems odd. Signed-off-by: Benoit Canet --- hw/pxa2xx_mmci.c | 28 ++-- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/hw/pxa2xx_mmci.c b/hw/pxa2xx_mmci.c index 1de4979..58e6e29 100644 --- a/hw

[Qemu-devel] [PATCH 06/10] exec.c: Remove useless comment

From: 陳韋任 As phys_ram_size had been removed since QEMU 0.12. Remove the useless comment. Signed-off-by: Chen Wen-Ren Signed-off-by: Stefan Hajnoczi --- exec.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/exec.c b/exec.c index 9dc4edb..2f3c6a0 100644 --- a/exec.c

[Qemu-devel] [PATCH 08/10] Fix typo: buf -> bus

From: Hervé Poussineau Signed-off-by: Hervé Poussineau Signed-off-by: Stefan Hajnoczi --- hw/audiodev.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/audiodev.h b/hw/audiodev.h index 8e930b2..d60c349 100644 --- a/hw/audiodev.h +++ b/hw/audiodev.h @@ -11,7 +11,7 @

[Qemu-devel] [PATCH 06/10] pxa2xx_keypad: convert to memory API

Signed-off-by: Benoit Canet --- hw/pxa2xx_keypad.c | 30 +- 1 files changed, 13 insertions(+), 17 deletions(-) diff --git a/hw/pxa2xx_keypad.c b/hw/pxa2xx_keypad.c index e33959d..de0a6c7 100644 --- a/hw/pxa2xx_keypad.c +++ b/hw/pxa2xx_keypad.c @@ -11,6 +11,7 @@ #in

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues: > Hi folks: > > We've captured a regression with floppy disk on recent qemu (and > qemu-kvm, after a code merge). We bisected it to be caused by: > > commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8 > Author: Richard Henderson > Date: Mon

[Qemu-devel] [PATCH 02/10] vmdk: remove unneeded variable assignment

From: Pavel Borzenkov Spotted by Clang Analyzer Signed-off-by: Pavel Borzenkov Signed-off-by: Stefan Hajnoczi --- block/vmdk.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 5d16ec4..3969131 100644 --- a/block/vmdk.c +++ b/block/vmdk

Re: [Qemu-devel] [PATCH] Make cpu_single_env thread local (Linux only for now)

On 2011-10-26 17:18, Peter Maydell wrote: > On 26 October 2011 16:13, Jan Kiszka wrote: >> My point is that it is fine to use for per-vcpu variables because: >> - they are single-threaded in TCG mode >> - they are multi-threaded in KVM mode, but that's only affecting Linux >> hosts for which t

[Qemu-devel] [PATCH 2/2] Make cpu_single_env thread-local

From: Paolo Bonzini Make cpu_single_env thread-local. This fixes a regression in handling of multi-threaded programs in linux-user mode (bug 823902). Signed-off-by: Paolo Bonzini --- cpu-all.h |4 +++- darwin-user/main.c |2 -- exec.c |2 +- 3 files changed, 4

[Qemu-devel] [PATCH 1/2] qemu-tls.h: Add abstraction layer for TLS variables

Add an abstraction layer for defining and using thread-local variables. For the moment this is implemented only for Linux, which means they can only be used in restricted circumstances. The abstraction layer allows us to add POSIX and Win32 support later. Signed-off-by: Peter Maydell --- qemu-tl

Re: [Qemu-devel] [PATCH 2/2] Make cpu_single_env thread-local

Am 26.10.2011 18:07, schrieb Peter Maydell: > From: Paolo Bonzini > > Make cpu_single_env thread-local. This fixes a regression > in handling of multi-threaded programs in linux-user mode > (bug 823902). > > Signed-off-by: Paolo Bonzini > --- > cpu-all.h |4 +++- > darwin-user/mai

[Qemu-devel] Correct syntax for named snapshots

According to the latest doc file you create a named snapshot like this: qemu-img snapshot [-l | -a snapshot | -c snapshot | -d snapshot] base-image.img Is this other following syntax still supported or deprecated: "qemu-img create -f qcow2 -b base-image.img snapshot.img" ? The latter is on the

Re: [Qemu-devel] [PATCH] Make cpu_single_env thread local (Linux only for now)

Am 26.10.2011 18:02, schrieb Jan Kiszka: > On 2011-10-26 17:18, Peter Maydell wrote: >> On 26 October 2011 16:13, Jan Kiszka wrote: >>> My point is that it is fine to use for per-vcpu variables because: >>> - they are single-threaded in TCG mode >>> - they are multi-threaded in KVM mode, but tha

Re: [Qemu-devel] [PATCH] Make cpu_single_env thread local (Linux only for now)

On 2011-10-26 18:27, Andreas Färber wrote: > Am 26.10.2011 18:02, schrieb Jan Kiszka: >> On 2011-10-26 17:18, Peter Maydell wrote: >>> On 26 October 2011 16:13, Jan Kiszka wrote: My point is that it is fine to use for per-vcpu variables because: - they are single-threaded in TCG mode >>

[Qemu-devel] [PATCH 0/2] TLS abstraction layer for thread-local cpu_single_env on Linux

These patches add enough of the TLS abstraction layer to allow us to make cpu_single_env thread-local on Linux systems. This fixes the regression described in bug 823902 for the 1.0 release; we can add the Win32 and POSIX implementations later. I haven't included Paolo's "Prepare Windows

Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value), introduce qemu_abort?

Am 26.10.2011 14:54, schrieb Stefan Hajnoczi: On Mon, Oct 24, 2011 at 10:18:43PM +0200, Stefan Weil wrote: For compilations with -DNDEBUG, the default case did not return a value which caused a compiler warning. Signed-off-by: Stefan Weil --- hw/ppce500_spin.c | 11 --- 1 files changed,

Re: [Qemu-devel] [PATCH 2/2] Make cpu_single_env thread-local

On 26 October 2011 17:20, Andreas Färber wrote: >> +DECLARE_TLS(CPUState *,tls_cpu_single_env); > > So this effectively becomes tls__tls_cpu_single_env iiuc. > For compile-checking for missed conversions, > > DECLARE_TLS(CPUState *,cpu_single_env); > > should do, no? Yes. (That does impose the si

[Qemu-devel] [PATCH 0/2] Fix ppc64-linux-user

At the moment, no ppc64-linux-user tests work at all. With these two patches, I can at least run the linux-user-test-0.3 binary and a statically linked empty program (int main() { return 0; }). Given that linux-user-test-0.3 is in fact busybox, this is rather more comprehensive testing than it wo

[Qemu-devel] [PATCH 1/2] ppc64-linux-user: Properly interpret the entry function descriptor.

Don't confuse the load address with the load bias. They're equal for ET_DYN objects (i.e. ld.so) but different for ET_EXEC objects (i.e. statically linked). Signed-off-by: Richard Henderson --- linux-user/elfload.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/

[Qemu-devel] [PATCH 2/2] ppc64-linux-user: Fix syscall return type.

Use target_ulong instead of hard-coded uint32_t. Remove the disabled printf's that are redundant with -strace. Signed-off-by: Richard Henderson --- linux-user/main.c | 13 +++-- 1 files changed, 3 insertions(+), 10 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index

Re: [Qemu-devel] [PATCH 1/2] qemu-tls.h: Add abstraction layer for TLS variables

On 10/26/2011 06:07 PM, Peter Maydell wrote: + * Authors: + * Paolo Bonzini Wrong email address, + * Peter Maydell otherwise looks fine. Paolo

Re: [Qemu-devel] [PATCH 4/5] integratorcp: convert integratorcm to VMState

On 25 October 2011 12:09, Benoît Canet wrote: > +static const VMStateDescription vmstate_integratorcm = { > +    .name = "integratorcm", > +    .version_id = 1, > +    .minimum_version_id = 1, > +    .minimum_version_id_old = 1, > +    .fields = (VMStateField[]) { > +        VMSTATE_UINT32(memsz,

Re: [Qemu-devel] [PATCH 2/9] Sparc: avoid AREG0 for softint op helpers and Leon cache control

On Tue, Oct 25, 2011 at 21:40, Richard Henderson wrote: > On 10/25/2011 02:14 PM, Blue Swirl wrote: >> Make softint op helpers and Leon cache irq manager take a parameter >> for CPUState instead of relying on global env. Move the functions >> to int{32,64}_helper.c. >> >> Signed-off-by: Blue Swirl

[Qemu-devel] [RFC] Add a .mailmap to map pre-git-conversion authors to friendly names

Add a .mailmap file so 'git shortlog' can map the unfriendly pre-git-conversion author entries to real names. Signed-off-by: Peter Maydell --- I've had this kicking around in my working tree for a while, but it seems like it's more generally useful. Opinions? .mailmap | 20 +++

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

On 10/26/2011 01:47 PM, Kevin Wolf wrote: Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues: Hi folks: We've captured a regression with floppy disk on recent qemu (and qemu-kvm, after a code merge). We bisected it to be caused by: commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8 Author: Ric

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

On 10/26/2011 12:47 PM, Kevin Wolf wrote: Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues: Hi folks: We've captured a regression with floppy disk on recent qemu (and qemu-kvm, after a code merge). We bisected it to be caused by: commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8 Author: Ric

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

On 10/26/2011 12:47 PM, Kevin Wolf wrote: Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues: Hi folks: We've captured a regression with floppy disk on recent qemu (and qemu-kvm, after a code merge). We bisected it to be caused by: commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8 Author: Ric

  1   2   >