On 10/04/2011 07:26 PM, Jan Kiszka wrote:
Looks like a start. But I would avoid macros and go for (static inline)
functions where possible. And initialization should be explicit (so that
you can start using TLS already inside constructors).
Here is the patch I wrote to do more or less the same
v2->v3:
fix comments from sheepdog maintainer
v1->v2:
moved coroutine send/recv functions to osdep.c, added support
for multiple in-flight requests, added support for co_discard
and aio_discard.
Paolo Bonzini (14):
sheepdog: add coroutine_fn markers
add socket_
This makes the following patch easier to review.
Cc: MORITA Kazutaka
Signed-off-by: Paolo Bonzini
---
block/sheepdog.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index c1f6e07..af696a5 100644
--- a/block/sheepdog.c
+
bdrv_read and bdrv_write return negative errno values, not -1.
Signed-off-by: Paolo Bonzini
---
nbd.c | 21 -
1 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/nbd.c b/nbd.c
index fb5e424..5df9745 100644
--- a/nbd.c
+++ b/nbd.c
@@ -580,6 +580,7 @@ int nbd_trip
The server can use it to issue a flush automatically after a
write. The client can also use it to mimic a write-through
cache.
Signed-off-by: Paolo Bonzini
---
block/nbd.c |8
nbd.c | 13 +++--
2 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/block/nb
Map it to bdrv_discard. The server can also expose NBD_FLAG_SEND_TRIM.
Signed-off-by: Paolo Bonzini
---
block/nbd.c | 31 +++
nbd.c | 13 -
2 files changed, 43 insertions(+), 1 deletions(-)
diff --git a/block/nbd.c b/block/nbd.c
index 23f83d4..
On Mon, Oct 03, 2011 at 10:00:48AM -0500, Anthony Liguori wrote:
> >Yes, it's easy to quantify. I think the following gives us
> >the offset before and after, so the difference is the size
> >we seek, right?
OK, Orit (Cc'd) did some research - this is a booting
while still in grub, size probably d
Signed-off-by: Paolo Bonzini
---
block/vvfat.c |7 ++-
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index a682eae..fb3d62e 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -930,11 +930,8 @@ static int init_directories(BDRVVVFATState* s,
Note for the brace police: the style in this commit and the following
is consistent with the rest of the file. It is then fixed together with
the introduction of coroutines.
Signed-off-by: Paolo Bonzini
---
block/nbd.c | 31 +++
nbd.c | 15 ++-
The sector count is stored in the partition and hence must not include the
sectors before its start. At the same time, remove the useless special
casing for 1.44 MB floppies. This fixes fsck on VVFAT hard disks,
which otherwise tries to seek past the end of the disk.
Signed-off-by: Paolo Bonzini
On 2011-10-05 09:08, Paolo Bonzini wrote:
> On 10/04/2011 07:26 PM, Jan Kiszka wrote:
>> Looks like a start. But I would avoid macros and go for (static inline)
>> functions where possible. And initialization should be explicit (so that
>> you can start using TLS already inside constructors).
>
>
On 04/10/2011 10:43, Yann Quelen wrote:
> Hello,
>
> 2011/10/3 Fabien Chouteau :
>> Simple implementation of an stdio char device on Windows.
>>
>> Signed-off-by: Fabien Chouteau
>> ---
>> qemu-char.c | 227
>> ++-
>> 1 files changed, 225
This is duplicated twice for read/write operations. Unify it, and
move it close to the code that adds bdrv_flush.
Signed-off-by: Paolo Bonzini
---
block.c | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/block.c b/block.c
index ce35dce..394ecaf 100644
---
It occurred to me that, if there's one thing vvfat ought to be good
at, it is creating disk images with qemu-img convert (a driver disk
in my case).
It turns out the use case is really broken. qemu-img doesn't
complete at all, the resulting images often do not pass fsck,
and it's impossible to cr
From: Stefan Hajnoczi
Block drivers typically have two copies of the flush operation: a
synchronous .bdrv_flush() and an asynchronous .bdrv_aio_flush(). This
patch applies the same emulation that we already do for
.bdrv_read()/.bdrv_write() to .bdrv_flush(). Now block drivers only
need to provi
Allow sending up to 16 requests, and drive the replies to the coroutine
that did the request. The code is written to be exactly the same as
before this patch when MAX_NBD_REQUESTS == 1 (modulo the extra mutex
and state).
Signed-off-by: Paolo Bonzini
---
block/nbd.c | 69 ++
First determine FAT12/16/32, then compute geometry from that for both
FDD and HDD. For floppies, change to 1 sector/cluster since the limit
for that is ~2 MB for FAT12 (which we use for 1.44 MB floppies only)
and well over 2.88 MB for FAT16.
This matches the actual format used by 1.44 MB floppies
On Sun, Oct 02, 2011 at 06:35:48PM +0200, Andreas Färber wrote:
> The command line option is called -kernel, not -kenrel.
>
> Cc: Paul Brook
> Signed-off-by: Andreas Färber
> ---
> target-arm/helper.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Thanks, applied to the trivial
Signed-off-by: Paolo Bonzini
---
block.c | 45 +++--
block_int.h |1 +
2 files changed, 36 insertions(+), 10 deletions(-)
diff --git a/block.c b/block.c
index 394ecaf..f4b9089 100644
--- a/block.c
+++ b/block.c
@@ -66,6 +66,8 @@ static BlockDrive
On Sun, Oct 02, 2011 at 06:53:09PM +0200, Stefan Weil wrote:
> This error was reported by cppcheck.
>
> Signed-off-by: Stefan Weil
> ---
> console.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Thanks, applied to the trivial patches tree:
http://repo.or.cz/w/qemu/stefanha.git/s
This is consistent with what "real" floppies have, so file(1)
now actually recognizes the VVFAT image as a 1.44 MB floppy.
Signed-off-by: Paolo Bonzini
---
block/vvfat.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index bc2dd4c..eb916
On Mon, Oct 03, 2011 at 10:43:19PM +0200, Stefan Weil wrote:
> The code is unused since 8 years, so remove it.
>
> Signed-off-by: Stefan Weil
> ---
> linux-user/signal.c |5 +
> 1 files changed, 1 insertions(+), 4 deletions(-)
Thanks, applied to the trivial patches tree:
http://repo.or.
Outside coroutines, avoid busy waiting on EAGAIN by temporarily
making the socket blocking.
The API of qemu_recvv/qemu_sendv is slightly different from
do_readv/do_writev because they do not handle coroutines. It
returns the number of bytes written before encountering an
EAGAIN. The specificity
If the number of "faked sectors" + the number of sectors that are
part of a cluster does not sum up to the total number of sectors,
qemu-img convert fails. Read these spare sectors as all zeros.
Signed-off-by: Paolo Bonzini
---
block/vvfat.c |4 ++--
1 files changed, 2 insertions(+), 2 dele
Signed-off-by: Paolo Bonzini
---
block/nbd.c | 218 +++
nbd.c |8 ++
2 files changed, 152 insertions(+), 74 deletions(-)
diff --git a/block/nbd.c b/block/nbd.c
index 35c15c8..90c4f2f 100644
--- a/block/nbd.c
+++ b/block/nbd.c
@@
When reading the address of the first free entry, you cannot
use array_get without first marking all entries as occupied.
This is visible if you change the sectors per cluster on a
floppy from 2 to 1.
Signed-off-by: Paolo Bonzini
---
block/vvfat.c |1 +
1 files changed, 1 insertions(+), 0 d
Signed-off-by: Paolo Bonzini
---
osdep.c | 67 +
qemu-common.h |4 +++
2 files changed, 71 insertions(+), 0 deletions(-)
diff --git a/osdep.c b/osdep.c
index 56e6963..718a25d 100644
--- a/osdep.c
+++ b/osdep.c
@@ -166,3 +166,70
Cc: MORITA Kazutaka
Signed-off-by: Paolo Bonzini
---
oslib-posix.c |7 +++
oslib-win32.c |6 ++
qemu_socket.h |1 +
3 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/oslib-posix.c b/oslib-posix.c
index a304fb0..dbc8ee8 100644
--- a/oslib-posix.c
+++ b/oslib-posi
qemu-nbd has a limit of slightly less than 1M per request. Work
around this in the nbd block driver.
Signed-off-by: Paolo Bonzini
---
block/nbd.c | 52 ++--
1 files changed, 46 insertions(+), 6 deletions(-)
diff --git a/block/nbd.c b/block/nbd.
Signed-off-by: Paolo Bonzini
---
block.c | 140 -
block.h |3 +
block_int.h |9 +++-
trace-events |1 +
4 files changed, 148 insertions(+), 5 deletions(-)
diff --git a/block.c b/block.c
index f4b9089..7853982 100644
The following changes since commit d11cf8cc80d946dfc9a23597cd9a0bb1c487cfa7:
etrax-dma: Remove bogus if statement (2011-10-03 10:20:13 +0200)
are available in the git repository at:
ssh://repo.or.cz/srv/git/qemu/stefanha.git trivial-patches
Andreas Färber (1):
target-arm: Fix typo
Ant
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Signed-off-by: Stefan Hajnoczi
---
Makefile |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/Makefile b/Makefile
index 6ed3194..5723108 100644
--- a/Makefile
+++ b/Makefile
@@ -145,11 +145,12 @@ endif
qemu-img.o:
From: Antony Pavlov
The commit fc2bf44972349b078d8310466c3866615500e67f
changed the type of val argument of the function gt64120_writel()
from uint32_t to uint64_t, so we need to change the corresponding
length modifier from "%x" to "%" PRIx64.
Signed-off-by: Antony Pavlov
Signed-off-by: Stefan
From: Andreas Färber
The command line option is called -kernel, not -kenrel.
Cc: Paul Brook
Reviewed-by: Peter Maydell
Signed-off-by: Andreas Färber
Signed-off-by: Stefan Hajnoczi
---
target-arm/helper.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-arm/he
From: Stefan Weil
This error was reported by cppcheck.
Signed-off-by: Stefan Weil
Signed-off-by: Stefan Hajnoczi
---
console.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/console.c b/console.c
index 6dfcc47..e43de92 100644
--- a/console.c
+++ b/console.c
@@ -1538
From: Antony Pavlov
The commit fc2bf44972349b078d8310466c3866615500e67f
removed ISD_handle field from struct GT64120State,
so remove the field from DPRINTF too.
Signed-off-by: Antony Pavlov
Signed-off-by: Stefan Hajnoczi
---
hw/gt64xxx.c |5 +++--
1 files changed, 3 insertions(+), 2 delet
From: Jan Kiszka
Signed-off-by: Jan Kiszka
Signed-off-by: Stefan Hajnoczi
---
hw/lsi53c895a.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c
index 75a03a7..e077ec0 100644
--- a/hw/lsi53c895a.c
+++ b/hw/lsi53c895a.c
@@ -697,7 +697,7 @
From: Stefan Weil
The code is unused since 8 years, so remove it.
Signed-off-by: Stefan Weil
Signed-off-by: Stefan Hajnoczi
---
linux-user/signal.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/linux-user/signal.c b/linux-user/signal.c
index 89276eb..40c5eb18 10
On 10/05/2011 09:52 AM, Jan Kiszka wrote:
Yeah, it probably makes sense to build the abstractions around __thread
so that - one day - we can drop the legacy wrappers.
Just do not prepend "tls__" in the gcc model
Actually I did that on purpose so that people would not forget get_tls. :)
(ther
On Tue, Oct 4, 2011 at 8:58 PM, Anthony Liguori wrote:
> On 10/04/2011 06:13 AM, pingf...@linux.vnet.com wrote:
>
>> From: Liu Ping Fan
>> >
>>
>> Separate apic from qbus to icc bus which supports hotplug feature.
>> And make the creation of apic as part of cpu initialization, so
>> apic's state h
On Wed, Oct 5, 2011 at 12:43 AM, Jan Kiszka wrote:
> On 2011-10-04 13:13, pingf...@linux.vnet.com wrote:
> > From: Liu Ping Fan
> >
> > Separate apic from qbus to icc bus which supports hotplug feature.
>
> Modeling the ICC bus looks like a step in the right direction. The
> IOAPIC could be atta
On 2011-10-05 12:26, liu ping fan wrote:
>> > And make the creation of apic as part of cpu initialization, so
>>> apic's state has been ready, before setting kvm_apic.
>>
>> There is no kvm-apic upstream yet, so it's hard to judge why we need
>> this here. If we do, this has to be a separate patch
On Tue, 4 Oct 2011, Anthony PERARD wrote:
> Signed-off-by: Anthony PERARD
any reason why we shouldn't merge this patch with patch #1?
> ---
> hw/host-pci-device.c | 31 +++
> hw/host-pci-device.h |2 ++
> 2 files changed, 33 insertions(+), 0 deletions(-)
>
>
On Tue, 4 Oct 2011, Anthony PERARD wrote:
> Signed-off-by: Anthony PERARD
You should set the original author correctly and add his signed-off-by.
Remeber to run the patch through checkpatch.pl.
> ---
> hw/xen_pci_passthrough.c | 763
> ++
> hw/xen_p
On Tue, 4 Oct 2011, Anthony PERARD wrote:
> Signed-off-by: Anthony PERARD
You should set the original author of this patch correctly and add his
signed-off-by.
Remember to run the patch through checkpatch.pl.
> ---
> hw/xen_pci_passthrough_msi.c | 674
> +++
On Tue, 4 Oct 2011, Anthony PERARD wrote:
> Signed-off-by: Anthony PERARD
> ---
> Makefile.target |7 +++
> configure | 21 +
> 2 files changed, 28 insertions(+), 0 deletions(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index f708453..b5fbc18 100644
Hello,
I am not getting any reply on this query. I do not know how should I use this
combination and really stuck because of this. Can somebody from QEMU devel
quickly provide me help in this regard? I do not know what is taking time to
answer this query. Let me know if anything is needed from
Anthony Liguori wrote:
> On 09/23/2011 07:57 AM, Juan Quintela wrote:
>> This will allows us to hide the status values.
>>
>> --- a/ui/spice-core.c
>> +++ b/ui/spice-core.c
>> @@ -447,9 +447,7 @@ void do_info_spice(Monitor *mon, QObject **ret_data)
>>
>> static void migration_state_notifier(Noti
On 10/05/2011 06:28 AM, Michael S. Tsirkin wrote:
On Mon, Oct 03, 2011 at 10:00:48AM -0500, Anthony Liguori wrote:
Yes, it's easy to quantify. I think the following gives us
the offset before and after, so the difference is the size
we seek, right?
OK, Orit (Cc'd) did some research - this is a
On 10/04/2011 09:05 PM, Stefan Berger wrote:
On 10/03/2011 09:43 AM, Anthony Liguori wrote:
On 10/03/2011 08:24 AM, Michael S. Tsirkin wrote:
On Mon, Oct 03, 2011 at 07:51:00AM -0500, Anthony Liguori wrote:
Here are some suggestions:
- Let's make the protocol be BER directly.
As a first step,
From: Anthony Liguori
Reported-by: Luiz Capitulino
Signed-off-by: Anthony Liguori
Signed-off-by: Luiz Capitulino
---
error.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/error.c b/error.c
index b802752..68c0039 100644
--- a/error.c
+++ b/error.c
@@ -97,6 +97,10
From: Anthony Liguori
This provides a bridge between Error (new error mechanism) and QError (old error
mechanism). Errors can be propagated whereas QError cannot.
The minor evilness avoids layering violations. Since QError should go away RSN,
it seems like a reasonable hack.
Signed-off-by: An
The stop reason is returned in the RunState argument. This is a
preparation for a future commit which will convert the query-status
command to the QAPI.
Signed-off-by: Luiz Capitulino
---
vl.c | 16 ++--
1 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/vl.c b/vl.c
in
On 4 October 2011 06:07, TusharK wrote:
> I tried executing QEMU (realview-smp ARM11MPCore) with Linux kernel 2.6.39.3,
> but it failed. Kernel itself is not getting decompressed.
> I am executing below command.
>
> qemu-system-arm -M realview-eb-mpcore -cpu arm11mpcore -kernel
> arch/arm/boot/z
Next commit will convert the query-status command to use the
RunState type as generated by the QAPI.
In order to "transparently" replace the current enum by the QAPI
one, we have to make some changes to some enum values.
As the changes are simple renames, I'll do them in one shot. The
changes are
The QAPI framework won't generate it, so we need to get rid of it.
In order to do that, this commit makes RSTATE_PRE_LAUNCH the initial
state and change qemu_vmstop_requested() to use RSTATE_MAX.
Signed-off-by: Luiz Capitulino
---
sysemu.h |1 -
vl.c | 19 +++
2 files
Signed-off-by: Anthony Liguori
Signed-off-by: Luiz Capitulino
---
hmp-commands.hx |3 +--
hmp.c|5 +
hmp.h|1 +
monitor.c| 10 --
qapi-schema.json |9 +
qmp-commands.hx |5 +
qmp.c|4
7 files cha
From: Anthony Liguori
To get the ball rolling merging QAPI, this patch introduces a "middle mode" to
the code generator. In middle mode, the code generator generates marshalling
functions that are compatible with the current QMP server. We absolutely need
to replace the current QMP server in or
From: Michael Roth
Reviewed-by: Anthony Liguori
Signed-off-by: Michael Roth
Signed-off-by: Luiz Capitulino
---
scripts/qapi-types.py |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py
index fc0f7af..4797a70 100644
--- a/scri
Please, note that the RunState type as defined in sysemu.h and its
runstate_as_string() function are being dropped in favor of the
RunState type generated by the QAPI.
Signed-off-by: Anthony Liguori
Signed-off-by: Luiz Capitulino
---
hmp.c| 19 +++
hmp.h|
Signed-off-by: Anthony Liguori
Signed-off-by: Luiz Capitulino
---
hmp-commands.hx |3 +--
hmp.c|5 +
hmp.h|1 +
monitor.c|9 -
qapi-schema.json | 12
qmp-commands.hx |5 +
qmp.c|5 +
7 files
From: Michael Roth
Previously our logic for keeping track of when we're visiting the head
of a list was done via a global bool. This can be overwritten if dealing
with nested lists, so use stack entries to track this instead.
Reviewed-by: Anthony Liguori
Signed-off-by: Michael Roth
Signed-off-
It's the last value in the enum and is very useful for the C
implementation.
Signed-off-by: Luiz Capitulino
---
scripts/qapi-types.py |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py
index 3bacc0c..f64d84c 100644
--- a/scr
On 2 October 2011 19:44, Blue Swirl wrote:
> Bah, bug in bccd9ec5f098668576342c83d90d6d6833d61d33,
> target-arm/op_helper.c missed this change unlike all other targets:
> diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c
> index ab9c923..1892b35 100644
> --- a/target-arm/op_helper.c
> +
From: Michael Roth
Signed-off-by: Michael Roth
Signed-off-by: Luiz Capitulino
---
test-qmp-commands.c | 29 +
1 files changed, 29 insertions(+), 0 deletions(-)
diff --git a/test-qmp-commands.c b/test-qmp-commands.c
index f142cc6..fa5a7bd 100644
--- a/test-qmp-com
From: Anthony Liguori
Signed-off-by: Anthony Liguori
Signed-off-by: Luiz Capitulino
---
scripts/qapi-commands.py | 23 +++
1 files changed, 15 insertions(+), 8 deletions(-)
diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py
index 2776804..c947ba4 100644
---
From: Michael Roth
Modify logic such that we never assign values to the list head argument
to progress through the list on subsequent iterations, instead rely only
on having our return value passed back in as an argument on the next
call. Also update QMP I/O visitors and test cases accordingly, a
Reviewed-by: Michael Roth
Tested-by: Michael Roth
Signed-off-by: Anthony Liguori
Signed-off-by: Luiz Capitulino
---
hmp.c| 13 +
hmp.h|1 +
monitor.c| 11 +--
qapi-schema.json | 26 ++
qemu-char.c | 35
On Tue, 4 Oct 2011 14:04:45 +0200
Paolo Bonzini wrote:
> Trying to migrate a paused machine fails. The reason is that
> the RSTATE_PRE_MIGRATE is reached with vm_stop, and this
> transition is eaten when the vm is already paused. This patch
> fixes the problem by always going through runstate_
Otherwise if we have something like 'foo-bar' in the schema,
it will be generated as 'foo_bar' in the string lookup table.
c_var() is good for C variables, but not for enum strings.
Signed-off-by: Luiz Capitulino
---
scripts/qapi-types.py |2 +-
1 files changed, 1 insertions(+), 1 deletions
From: Anthony Liguori
A simple example conversion 'info name'. This also adds the new files for
QMP and HMP.
Signed-off-by: Anthony Liguori
Signed-off-by: Luiz Capitulino
---
Makefile.objs|1 +
hmp.c| 26 ++
hmp.h| 22 ++
Signed-off-by: Anthony Liguori
Signed-off-by: Luiz Capitulino
---
hmp-commands.hx |3 +--
hmp.c|5 +
hmp.h|1 +
qapi-schema.json | 14 ++
qmp.c|5 +
5 files changed, 26 insertions(+), 2 deletions(-)
diff --git a/hmp-comm
Signed-off-by: Anthony Liguori
Signed-off-by: Luiz Capitulino
---
hmp.c|8
hmp.h|1 +
monitor.c| 28 +---
qapi-schema.json | 24
qmp-commands.hx |6 ++
qmp.c| 15 +
Signed-off-by: Anthony Liguori
Signed-off-by: Luiz Capitulino
---
hmp.c| 16
hmp.h|1 +
monitor.c| 36 +---
qapi-schema.json | 25 +
qmp-commands.hx |6 ++
qmp.c
From: Anthony Liguori
Use the new middle mode within the existing QMP server.
Signed-off-by: Anthony Liguori
Signed-off-by: Luiz Capitulino
---
Makefile | 12
Makefile.objs|2 ++
Makefile.target |6 +++---
monitor.c|9 -
qapi-schema.json
Signed-off-by: Luiz Capitulino
---
monitor.c| 40 +++-
qapi-schema.json | 23 +++
qmp-commands.hx |6 ++
3 files changed, 44 insertions(+), 25 deletions(-)
diff --git a/monitor.c b/monitor.c
index 86a0dad..0c90506 10064
Signed-off-by: Anthony Liguori
Signed-off-by: Luiz Capitulino
---
hmp-commands.hx |2 +-
hmp.c|6 ++
hmp.h|1 +
monitor.c| 12
qapi-schema.json | 11 +++
qmp-commands.hx |5 +
qmp.c|6 ++
7 fil
From: Michael Roth
Currently we do 3 things wrong:
1) The list iterator, in practice, is used in a manner where the pointer
we pass in is the same as the pointer we assign the output to from
visit_next_list(). This causes an infinite loop where we keep freeing
the same structures.
2) We attempt
Signed-off-by: Anthony Liguori
Signed-off-by: Luiz Capitulino
---
hmp.c| 13 +
hmp.h|1 +
monitor.c| 46 +++---
qapi-schema.json | 37 +
qmp-commands.hx |6 +
Anthony,
This pull request contains only the first round of QAPI conversions series.
I had to rebase it but the changes are rather simple.
The changes (since d11cf8cc80d946dfc9a23597cd9a0bb1c487cfa7) are available
in the following repository:
git://repo.or.cz/qemu/qmp-unstable.git queue/qmp
On 10/05/2011 07:24 AM, Juan Quintela wrote:
Anthony Liguori wrote:
On 09/23/2011 07:57 AM, Juan Quintela wrote:
This will allows us to hide the status values.
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -447,9 +447,7 @@ void do_info_spice(Monitor *mon, QObject **ret_data)
static void
On Wed, Oct 05, 2011 at 07:54:21AM -0500, Anthony Liguori wrote:
> On 10/04/2011 09:05 PM, Stefan Berger wrote:
> >On 10/03/2011 09:43 AM, Anthony Liguori wrote:
> >>On 10/03/2011 08:24 AM, Michael S. Tsirkin wrote:
> >>>On Mon, Oct 03, 2011 at 07:51:00AM -0500, Anthony Liguori wrote:
> >Here a
On 10/05/2011 04:37 PM, Luiz Capitulino wrote:
Now, we have three options to fix this but I don't know which one to choose:
1. We could just add the transition RSTATE_PAUSED -> RSTATE_POST_MIGRATE
as valid. Not sure this is a good thing to do though, as it seems a silly
workaround f
On 10/05/2011 05:43 PM, Avi Kivity wrote:
On 10/05/2011 04:37 PM, Luiz Capitulino wrote:
Now, we have three options to fix this but I don't know which one to
choose:
1. We could just add the transition RSTATE_PAUSED ->
RSTATE_POST_MIGRATE
as valid. Not sure this is a good thing to do
More sync, aio, and coroutine unification. Make bdrv_aio_readv() go
through coroutine request processing.
Signed-off-by: Stefan Hajnoczi
---
block.c | 48 +++-
1 files changed, 35 insertions(+), 13 deletions(-)
diff --git a/block.c b/block.c
index
The public interface for I/O in coroutine context is bdrv_co_readv() and
bdrv_co_writev(). Split out the request processing code into
bdrv_co_do_readv() and bdrv_co_writev() so that it can be called
internally when we refactor all request processing to use coroutines.
Signed-off-by: Stefan Hajnoc
We will unify block layer request processing across sync, aio, and
coroutines and this means a .bdrv_co_*() emulation function should not
call back into the public interface. There's no need here, just call
.bdrv_aio_*() directly.
The gory details: bdrv_co_io_em() cannot call back into the public
The aio write operation marks blocks dirty when the write operation
completes. The coroutine write operation marks blocks dirty before
issuing the write operation.
It seems safest to mark the block dirty when the operation completes so
that anything tracking dirty blocks will not act before the c
The bdrv_read()/bdrv_write() functions call .bdrv_read()/.bdrv_write().
They should go through bdrv_co_do_readv() and bdrv_co_do_writev()
instead in order to unify request processing code across sync, aio, and
coroutine interfaces. This is also an important step towards removing
BlockDriverState .
More sync, aio, and coroutine unification. Make bdrv_aio_writev() go
through coroutine request processing.
Remove the dirty block callback mechanism which was needed only for aio
processing and can be done more naturally in coroutine context.
Signed-off-by: Stefan Hajnoczi
---
block.c | 66 +
Block layer features like dirty block tracing, I/O throttling, and live block
copy are forced to duplicate code due to the three different interfaces:
synchronous, asynchronous, and coroutines.
Since there are bdrv_read(), bdrv_aio_readv(), and bdrv_co_readv() interfaces
for read (and similar for
On 09/30/2011 05:39 AM, Stefan Hajnoczi wrote:
QED's metadata caching strategy allows two parallel requests to race for
metadata lookup. The first one to complete will populate the metadata
cache and the second one will drop the data it just read in favor of the
cached data.
There is a use-afte
On 2011-10-05 17:43, Avi Kivity wrote:
> On 10/05/2011 04:37 PM, Luiz Capitulino wrote:
>> Now, we have three options to fix this but I don't know which one to
>> choose:
>>
>> 1. We could just add the transition RSTATE_PAUSED ->
>> RSTATE_POST_MIGRATE
>> as valid. Not sure this is a good t
On 10/05/2011 06:31 PM, Jan Kiszka wrote:
>>
>
> vm_start() should be symmetric with vm_stop(). That is, if a piece of
> code wants to execute with vcpus stopped, it should just run inside a
> stop/start pair.
>
> The only confusion can come from the user, if he sees multiple stop
> events
On 2011-10-05 18:37, Avi Kivity wrote:
> On 10/05/2011 06:31 PM, Jan Kiszka wrote:
>> >>
>> >
>> > vm_start() should be symmetric with vm_stop(). That is, if a piece of
>> > code wants to execute with vcpus stopped, it should just run inside a
>> > stop/start pair.
>> >
>> > The only confusion
On Wed, 05 Oct 2011 18:37:51 +0200
Avi Kivity wrote:
> On 10/05/2011 06:31 PM, Jan Kiszka wrote:
> > >>
> > >
> > > vm_start() should be symmetric with vm_stop(). That is, if a piece of
> > > code wants to execute with vcpus stopped, it should just run inside a
> > > stop/start pair.
> > >
>
On 10/05/2011 06:49 PM, Jan Kiszka wrote:
On 2011-10-05 18:37, Avi Kivity wrote:
> On 10/05/2011 06:31 PM, Jan Kiszka wrote:
>> >>
>> >
>> > vm_start() should be symmetric with vm_stop(). That is, if a piece of
>> > code wants to execute with vcpus stopped, it should just run inside a
>
Marcelo Tosatti wrote:
> On Sun, Sep 25, 2011 at 10:47:46PM +0800, Liu, Jinsong wrote:
>> Marcelo Tosatti wrote:
>>> On Fri, Sep 23, 2011 at 04:25:51PM +0800, Liu, Jinsong wrote:
Marcelo Tosatti wrote:
> On Thu, Sep 22, 2011 at 04:55:52PM +0800, Liu, Jinsong wrote:
>>> From 4d5b83aba40
On 10/05/2011 07:02 PM, Luiz Capitulino wrote:
On Wed, 05 Oct 2011 18:37:51 +0200
Avi Kivity wrote:
> On 10/05/2011 06:31 PM, Jan Kiszka wrote:
> > >>
> > >
> > > vm_start() should be symmetric with vm_stop(). That is, if a piece of
> > > code wants to execute with vcpus stopped,
On Wed, 05 Oct 2011 19:23:21 +0200
Avi Kivity wrote:
> On 10/05/2011 07:02 PM, Luiz Capitulino wrote:
> > On Wed, 05 Oct 2011 18:37:51 +0200
> > Avi Kivity wrote:
> >
> > > On 10/05/2011 06:31 PM, Jan Kiszka wrote:
> > > > >>
> > > > >
> > > > > vm_start() should be symmetric with vm_st
1 - 100 of 120 matches
Mail list logo
