It occurred to me that, if there's one thing vvfat ought to be good at, it is creating disk images with qemu-img convert (a driver disk in my case).
It turns out the use case is really broken. qemu-img doesn't complete at all, the resulting images often do not pass fsck, and it's impossible to create a 1.44 MB disk image. This series fixes all of the small problems I found. Coding standard in this file is such a pain that I hardly bothered about it. Paolo Bonzini (6): vvfat: fix out of bounds array_get usage vvfat: do not fail if the disk has spare sectors vvfat: need to use first_sectors_number to distinguish fdd/hdd vvfat: unify and correct computation of sector count vvfat: do not hardcode sector counts in error message vvfat: reorganize computation of disk geometry block/vvfat.c | 50 ++++++++++++++++++++++++-------------------------- 3 files changed, 26 insertions(+), 28 deletions(-) -- 1.7.6
