Re: [Qemu-devel] [PATCH 01/58] spapr: proper qdevification

2011-09-15 Thread Paolo Bonzini
On 09/15/2011 05:14 AM, David Gibson wrote: Under PAPR, there is generally only supposed to be one SCSI target (disk / cd / whatever) per virtual scsi bus. But the generic qdev code will, by default, keep assigning devices to the existing bus until it's full. Any thoughts on how to sanely chang

Re: [Qemu-devel] [PATCH][RFC][0/2] REF+/REF- optimization

2011-09-15 Thread Frediano Ziglio
2011/9/14 Kevin Wolf : ... > > But let's measure the effects first, I suspect that for cluster > allocation it doesn't help much because every REF- comes with a REF+. > That's 50% of effort if REF- clusters are far from REF+ :) >>> >>> I would expect that the next REF+ allocat

Re: [Qemu-devel] [PATCH] Fix subtle integer overflow bug in memory API

2011-09-15 Thread Avi Kivity
On 09/15/2011 05:58 AM, David Gibson wrote: > Well.. I'm pretty sure that particular case can no longer be > triggered. But there may be other integer overflow bugs in this code, > though I didn't spot them at a glance. Actually, there definitely are. addrrange_end() should probably be rede

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-15 Thread Avi Kivity
On 09/14/2011 11:25 PM, Blue Swirl wrote: On Wed, Sep 14, 2011 at 8:15 PM, Avi Kivity wrote: > On 09/14/2011 11:06 PM, Blue Swirl wrote: >> >> On Wed, Sep 14, 2011 at 8:35 AM, Avi Kivitywrote: >> >On 09/14/2011 11:27 AM, Alexander Graf wrote: >> >> >> >>On 14.09.2011, at 10:24,

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-15 Thread Avi Kivity
On 09/15/2011 04:24 AM, Benjamin Herrenschmidt wrote: On Wed, 2011-09-14 at 23:41 +0200, Alexander Graf wrote: > On 14.09.2011, at 22:42, Richard Henderson wrote: > > > On 09/14/2011 01:35 PM, Alexander Graf wrote: > > > >>> Can you explain what the memory map looks like from the hardware >

Re: [Qemu-devel] [PATCH 1/2] hw/usb-ohci: Honour endpoint maximum packet size

2011-09-15 Thread Gerd Hoffmann
On 09/14/11 19:48, Peter Maydell wrote: Honour the maximum packet size for endpoints; this applies when sending non-isochronous data and means we transfer only as much as the endpoint allows, leaving the transfer descriptor on the list for another go next time around. This allows usb-net to work

Re: [Qemu-devel] [PATCH 2/2] hw/usb-ohci: Fix OHCI_TD_T1 bit position definition

2011-09-15 Thread Gerd Hoffmann
On 09/14/11 19:49, Peter Maydell wrote: The OHCI Transfer Descriptor T (DataToggle) bits are 24 and 25; fix an error which accidentally overlaid them both on the same bit. Signed-off-by: Peter Maydell Patch added to usb patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-15 Thread Alexander Graf
On 15.09.2011, at 03:24, Benjamin Herrenschmidt wrote: > On Wed, 2011-09-14 at 23:41 +0200, Alexander Graf wrote: >> On 14.09.2011, at 22:42, Richard Henderson wrote: >> >>> On 09/14/2011 01:35 PM, Alexander Graf wrote: >>> > Can you explain what the memory map looks like from the hardware

Re: [Qemu-devel] [Qemu-ppc] [PATCH 28/58] device tree: give dt more size

2011-09-15 Thread Alexander Graf
On 15.09.2011, at 05:19, David Gibson wrote: > On Wed, Sep 14, 2011 at 10:42:52AM +0200, Alexander Graf wrote: >> We currently load a device tree blob and then just take its size x2 to >> account for modifications we do inside. While this is nice and great, >> it fails when we have a small device

Re: [Qemu-devel] [PATCH] Fix subtle integer overflow bug in memory API

2011-09-15 Thread Paolo Bonzini
On 09/15/2011 04:34 AM, David Gibson wrote: explicit "if (a + b)< a" tests in some places. Please wrap these in a macro, since the addition has to be done in an unsigned type. Otherwise overflow is undefined. Paolo

Re: [Qemu-devel] [Bug 824650] [NEW] Latest GIT assert error in arp_table.c

2011-09-15 Thread Roy Tam
2011/9/15 Jan Kiszka : > On 2011-09-15 06:11, Roy Tam wrote: >> 2011/8/12 Nigel Horne <824...@bugs.launchpad.net>: >>> Public bug reported: >>> >>> The latest git version of qemu (commit >>> 8cc7c3952d4d0a681d8d4c3ac89a206a5bfd7f00) crashes after a few minutes. >>> All was fine up to a few days ago

Re: [Qemu-devel] [PATCH] Fix subtle integer overflow bug in memory API

2011-09-15 Thread Avi Kivity
On 09/15/2011 10:38 AM, Paolo Bonzini wrote: On 09/15/2011 04:34 AM, David Gibson wrote: explicit "if (a + b)< a" tests in some places. Please wrap these in a macro, since the addition has to be done in an unsigned type. Otherwise overflow is undefined. It doesn't help if the overflow is

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-15 Thread Daniel P. Berrange
On Thu, Sep 15, 2011 at 08:51:00AM +1000, ronnie sahlberg wrote: > On Thu, Sep 15, 2011 at 12:36 AM, Christoph Hellwig wrote: > ... > >> > +/* > >> > + * We support iscsi url's on the form > >> > + * iscsi://[%@][:]// > >> > + */ > > > > Is having username + password on the command line really a t

Re: [Qemu-devel] Memory API code review

2011-09-15 Thread Juan Quintela
Avi Kivity wrote: > I would like to carry out an online code review of the memory API so > that more people are familiar with the internals, and perhaps even to > catch some bugs or deficiency. I'd like to use the next kvm > conference call slot for this (Tuesday 1400 UTC) since many people > alr

Re: [Qemu-devel] [PATCH 1/2] KVM: emulate lapic tsc deadline timer for guest

2011-09-15 Thread Liu, Jinsong
Marcelo Tosatti wrote: >> +} else if (apic_lvtt_tscdeadline(apic)) { >> +/* lapic timer in tsc deadline mode */ >> +u64 guest_tsc, guest_tsc_delta, ns = 0; >> +struct kvm_vcpu *vcpu = apic->vcpu; >> +unsigned long this_tsc_khz = vcpu_tsc_khz(vcpu)

[Qemu-devel] PATCH: s390: fix reset hypercall to reset the status

2011-09-15 Thread Christian Borntraeger
This patch fixes the reset hypercall which is supposed to also reset the device status in device memory. This fixes the following bug: [root@localhost driver]# echo virtio0 > unbind [ 35.056966] [ cut here ] [ 35.057054] kernel BUG at drivers/virtio/virtio.c:157! [ 35

Re: [Qemu-devel] [PATCH] A small patch to introduce stop conditions to the live migration.

2011-09-15 Thread Thomas Treutner
Am 14.09.2011 17:45, schrieb Anthony Liguori: On 09/14/2011 08:18 AM, Thomas Treutner wrote: Currently, it is possible that a live migration never finishes, when the dirty page rate is high compared to the scan/transfer rate. The exact values for MAX_MEMORY_ITERATIONS and MAX_TOTAL_MEMORY_TRANSF

Re: [Qemu-devel] [PATCH 1/2] hw/usb-ohci: Honour endpoint maximum packet size

2011-09-15 Thread Peter Maydell
On 15 September 2011 08:33, Gerd Hoffmann wrote: > On 09/14/11 19:48, Peter Maydell wrote: >> >> Honour the maximum packet size for endpoints; this applies when >> sending non-isochronous data and means we transfer only as >> much as the endpoint allows, leaving the transfer descriptor >> on the l

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-15 Thread Dor Laor
On 09/15/2011 09:04 AM, Paolo Bonzini wrote: On 09/15/2011 01:08 AM, ronnie sahlberg wrote: I think it is reasonable to just not support iscsi at all for blocksize that is not multiple of 512 bytes since a read-modify-write cycle across a network would probably be prohibitively expensive. Agre

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-15 Thread Kevin Wolf
Am 15.09.2011 00:51, schrieb ronnie sahlberg: > On Thu, Sep 15, 2011 at 12:36 AM, Christoph Hellwig wrote: > ... +/* + * We support iscsi url's on the form + * iscsi://[%@][:]// + */ >> >> Is having username + password on the command line really a that good idea? >> Also what a

Re: [Qemu-devel] Why qemu write/rw speed is so low?

2011-09-15 Thread Zhi Yong Wu
On Wed, Sep 14, 2011 at 10:17 PM, Stefan Hajnoczi wrote: > On Wed, Sep 14, 2011 at 3:42 AM, Zhi Yong Wu wrote: >> Log for bps=((10 * 1024 * 1024)). > > Okay, I think this data shows that I/O limits is too aggressive. > There seems to be some "overhead" amount so the guest is never able to > reach

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-15 Thread Kevin Wolf
Am 15.09.2011 08:04, schrieb Paolo Bonzini: > On 09/15/2011 01:08 AM, ronnie sahlberg wrote: >> I think it is reasonable to just not support iscsi at all for >> blocksize that is not multiple of 512 bytes >> since a read-modify-write cycle across a network would probably be >> prohibitively expensi

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-15 Thread Paolo Bonzini
On 09/15/2011 10:48 AM, Dor Laor wrote: We need the same patch for NBD, so I wouldn't bother with the synchronous flush. It seems to me that using a qemu external initiator/target pairs like Orit's original design in http://wiki.qemu.org/Features/LiveBlockMigration#ISCSI_for_non_shared_storage

Re: [Qemu-devel] [PATCH 1/2] hw/usb-ohci: Honour endpoint maximum packet size

2011-09-15 Thread Gerd Hoffmann
On 09/15/11 10:36, Peter Maydell wrote: On 15 September 2011 08:33, Gerd Hoffmann wrote: On 09/14/11 19:48, Peter Maydell wrote: Honour the maximum packet size for endpoints; this applies when sending non-isochronous data and means we transfer only as much as the endpoint allows, leaving the

[Qemu-devel] windows XP fail to enter standby mode

2011-09-15 Thread hkran
Hi, If I select to let my guest XP enter standby mode by clicking the button manually. qemu will exit with the following message left: ioport_write: PANIC d->guest_slots[val].active failed the following is my command to start qemu: /home/huikai/qemu15/bin/qemu --enable-kvm -m 768 -drive file

[Qemu-devel] [PATCH] vga: Respect isa_mem_base when registering chain4 alias

2011-09-15 Thread Jan Kiszka
This does not yet unbreak PPC (which has its own problems) but potentially other non-x86 systems where isa_mem_base is != 0. Signed-off-by: Jan Kiszka --- hw/vga.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/vga.c b/hw/vga.c index 125fb29..0a0c5a6 100644 --- a/hw/

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-15 Thread Jan Kiszka
On 2011-09-14 21:24, Avi Kivity wrote: > On 09/14/2011 09:10 PM, Jan Kiszka wrote: >> OK, let's try again: Do we have to model hierarchy in PIO address space >> at all? I don't think so. > > > We do. A device listens to addresses 0x100-0x110. Another BAR (at > 0x106) clips this to 0x100-0x106.

Re: [Qemu-devel] [PATCH] A small patch to introduce stop conditions to the live migration.

2011-09-15 Thread Paolo Bonzini
On 09/15/2011 10:27 AM, Thomas Treutner wrote: can always stop a guest to force convergence. What do you mean by stop exactly? Pausing the guest? Is it then automatically unpaused by qemu again at the destination host? Whether the guest restarts on the destination depends on the -S command

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-15 Thread Paolo Bonzini
On 09/15/2011 11:10 AM, Kevin Wolf wrote: > We need the same patch for NBD, so I wouldn't bother with the > synchronous flush. Doesn't Stefan's patch conflict with your bdrv_co_flush patch? Yes. I'll include it myself in my NBD v2. Paolo

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-15 Thread Daniel P. Berrange
On Thu, Sep 15, 2011 at 11:48:35AM +0300, Dor Laor wrote: > On 09/15/2011 09:04 AM, Paolo Bonzini wrote: > >On 09/15/2011 01:08 AM, ronnie sahlberg wrote: > >>I think it is reasonable to just not support iscsi at all for > >>blocksize that is not multiple of 512 bytes > >>since a read-modify-write

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-15 Thread Avi Kivity
On 09/15/2011 12:30 PM, Jan Kiszka wrote: On 2011-09-14 21:24, Avi Kivity wrote: > On 09/14/2011 09:10 PM, Jan Kiszka wrote: >> OK, let's try again: Do we have to model hierarchy in PIO address space >> at all? I don't think so. > > > We do. A device listens to addresses 0x100-0x110. Anothe

Re: [Qemu-devel] [PATCH] Add iSCSI support for QEMU

2011-09-15 Thread Orit Wasserman
On Thu, 2011-09-15 at 08:06 +0200, Paolo Bonzini wrote: > On 09/14/2011 06:36 PM, Orit Wasserman wrote: > > > I think NBD would be fine, especially with a flush command. > > I think NBD would be fine, especially with a flush command. > > If I remember correctly , there is a problem with NBD with

Re: [Qemu-devel] [PATCH] Add iSCSI support for QEMU

2011-09-15 Thread Paolo Bonzini
On 09/15/2011 11:52 AM, Orit Wasserman wrote: > The NBD protocol supports multiple named exports, just not QEMU's > implementation. I guess we can fix that. Yes, or just use Unix sockets and rely on libvirt to tunnel/multiplex the NBD streams. Paolo

Re: [Qemu-devel] [PATCH] scsi-generic: do not disable FUA

2011-09-15 Thread Kevin Wolf
Am 14.09.2011 16:40, schrieb Christoph Hellwig: > On Wed, Sep 14, 2011 at 03:25:56PM +0200, Paolo Bonzini wrote: >> I found no rationale for this in the logs, and it is quite bad because >> it will make scsi-generic unsafe WRT power failures. > > Looks good, > > Reviewed-by: Christoph Hellwig T

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-15 Thread Benjamin Herrenschmidt
> Sure :). So the problem is that when emulating the G3 Beige machine in > QEMU (default ppc32 target) we also add a PCI VGA adapter. Apparently, > on x86 that PCI VGA adapter can map the special VGA regions to > somewhere, namely 0xa. With the memory api overhaul, this also > slipped into the

Re: [Qemu-devel] [PATCH] Add iSCSI support for QEMU

2011-09-15 Thread Kevin Wolf
Am 15.09.2011 11:55, schrieb Paolo Bonzini: > On 09/15/2011 11:52 AM, Orit Wasserman wrote: >>> The NBD protocol supports multiple named exports, just not QEMU's >>> implementation. >> I guess we can fix that. > > Yes, or just use Unix sockets and rely on libvirt to tunnel/multiplex > the NBD s

Re: [Qemu-devel] [PATCH 1/2] hw/usb-ohci: Honour endpoint maximum packet size

2011-09-15 Thread Peter Maydell
On 15 September 2011 10:13, Gerd Hoffmann wrote: > On 09/15/11 10:36, Peter Maydell wrote: >> >> On 15 September 2011 08:33, Gerd Hoffmann  wrote: >>> >>> On 09/14/11 19:48, Peter Maydell wrote: Honour the maximum packet size for endpoints; this applies when sending non-isochronous

Re: [Qemu-devel] Using the qemu tracepoints with SystemTap

2011-09-15 Thread Stefan Hajnoczi
On Wed, Sep 14, 2011 at 5:02 PM, William Cohen wrote: > On 09/14/2011 10:51 AM, Stefan Hajnoczi wrote: >> On Tue, Sep 13, 2011 at 8:38 PM, William Cohen wrote: >>> On 09/13/2011 12:10 PM, William Cohen wrote: >>> Should the qemu.kvm.cpu_in and qemu.kvm.cpu_out match up?  There are a lot >>>

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-15 Thread Jan Kiszka
On 2011-09-15 11:53, Avi Kivity wrote: >>> The host pci bridge remaps this as >>> 0x100105-0x100106 in the memory address space space. But >>> someone configured a cpu-local region at this address, so the cpu can't >>> reach it at all. >> >> Mapping PIO into MMIO space is special as i

Re: [Qemu-devel] Design of the blobstore

2011-09-15 Thread Stefan Berger
On 09/15/2011 01:47 AM, Gleb Natapov wrote: On Wed, Sep 14, 2011 at 01:05:44PM -0400, Stefan Berger wrote: One property of the blobstore is that it has a certain required size for accommodating all blobs of device that want to store their blobs onto. The assumption is that the size of these b

Re: [Qemu-devel] Design of the blobstore

2011-09-15 Thread Gleb Natapov
On Thu, Sep 15, 2011 at 06:18:35AM -0400, Stefan Berger wrote: > On 09/15/2011 01:47 AM, Gleb Natapov wrote: > >On Wed, Sep 14, 2011 at 01:05:44PM -0400, Stefan Berger wrote: > >> One property of the blobstore is that it has a certain required > >>size for accommodating all blobs of device that w

Re: [Qemu-devel] Design of the blobstore

2011-09-15 Thread Stefan Berger
On 09/15/2011 02:57 AM, Michael S. Tsirkin wrote: On Wed, Sep 14, 2011 at 05:12:48PM -0400, Stefan Berger wrote: On 09/14/2011 01:56 PM, Michael S. Tsirkin wrote: On Wed, Sep 14, 2011 at 01:49:50PM -0400, Stefan Berger wrote: On 09/14/2011 01:40 PM, Michael S. Tsirkin wrote: On Wed, Sep 14, 2

Re: [Qemu-devel] windows XP fail to enter standby mode

2011-09-15 Thread Alon Levy
On Thu, Sep 15, 2011 at 05:23:01PM +0800, hkran wrote: > Hi, > > If I select to let my guest XP enter standby mode by clicking the button > manually. qemu will exit with the following message left: > > ioport_write: PANIC d->guest_slots[val].active failed > > the following is my command to start

Re: [Qemu-devel] [Bug 824650] [NEW] Latest GIT assert error in arp_table.c

2011-09-15 Thread Jan Kiszka
On 2011-09-15 09:38, Roy Tam wrote: > 2011/9/15 Jan Kiszka : >> On 2011-09-15 06:11, Roy Tam wrote: >>> 2011/8/12 Nigel Horne <824...@bugs.launchpad.net>: Public bug reported: The latest git version of qemu (commit 8cc7c3952d4d0a681d8d4c3ac89a206a5bfd7f00) crashes after a few mi

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Stefan Hajnoczi
On Thu, Sep 15, 2011 at 7:31 AM, Gleb Natapov wrote: > On Wed, Sep 14, 2011 at 01:04:00PM -0500, Anthony Liguori wrote: >> All device relationships are identified as named properties.  A QOM >> path name >> consists of a named device, followed by a series of properties which >> may or may >> not r

Re: [Qemu-devel] [PATCH 1/2] hw/usb-ohci: Honour endpoint maximum packet size

2011-09-15 Thread Gerd Hoffmann
Hi, No. What I think is that USBPacket shouldn't be required to be an actual USB packet, but a transfer, i.e. do the splitting of larger transfers into smaller packets in the usb driver emulation (if needed), not the host adapter emulation. The OHCI spec still requires us to only process on

Re: [Qemu-devel] Design of the blobstore

2011-09-15 Thread Michael S. Tsirkin
On Thu, Sep 15, 2011 at 06:22:15AM -0400, Stefan Berger wrote: > On 09/15/2011 02:57 AM, Michael S. Tsirkin wrote: > >On Wed, Sep 14, 2011 at 05:12:48PM -0400, Stefan Berger wrote: > >>On 09/14/2011 01:56 PM, Michael S. Tsirkin wrote: > >>>On Wed, Sep 14, 2011 at 01:49:50PM -0400, Stefan Berger wro

Re: [Qemu-devel] [Bug 824650] [NEW] Latest GIT assert error in arp_table.c

2011-09-15 Thread Roy Tam
2011/9/15 Jan Kiszka : > On 2011-09-15 09:38, Roy Tam wrote: >> 2011/9/15 Jan Kiszka : >>> On 2011-09-15 06:11, Roy Tam wrote: 2011/8/12 Nigel Horne <824...@bugs.launchpad.net>: > Public bug reported: > > The latest git version of qemu (commit > 8cc7c3952d4d0a681d8d4c3ac89a206a

Re: [Qemu-devel] Design of the blobstore

2011-09-15 Thread Stefan Berger
On 09/15/2011 06:51 AM, Michael S. Tsirkin wrote: On Thu, Sep 15, 2011 at 06:22:15AM -0400, Stefan Berger wrote: On 09/15/2011 02:57 AM, Michael S. Tsirkin wrote: On Wed, Sep 14, 2011 at 05:12:48PM -0400, Stefan Berger wrote: On 09/14/2011 01:56 PM, Michael S. Tsirkin wrote: On Wed, Sep 14, 2

Re: [Qemu-devel] [Qemu-ppc] [PATCH 28/58] device tree: give dt more size

2011-09-15 Thread David Gibson
On Thu, Sep 15, 2011 at 09:37:48AM +0200, Alexander Graf wrote: > > On 15.09.2011, at 05:19, David Gibson wrote: > > > On Wed, Sep 14, 2011 at 10:42:52AM +0200, Alexander Graf wrote: > >> We currently load a device tree blob and then just take its size x2 to > >> account for modifications we do i

[Qemu-devel] [PATCH] configure: Make missing pkg-config an error rather than a warning

2011-09-15 Thread Peter Maydell
If pkg-config doesn't exist then make configure fail immediately with a useful error message. Now that glib is a required dependency, proceeding despite the missing pkg-config will just cause us to fail later with a misleading message about glib not being present. Signed-off-by: Peter Maydell ---

Re: [Qemu-devel] Design of the blobstore

2011-09-15 Thread Stefan Hajnoczi
On Wed, Sep 14, 2011 at 6:05 PM, Stefan Berger wrote: >  One property of the blobstore is that it has a certain required size for > accommodating all blobs of device that want to store their blobs onto. The > assumption is that the size of these blobs is know a-priori to the writer of > the device

[Qemu-devel] [PATCH 0/6] usb patch queue

2011-09-15 Thread Gerd Hoffmann
Hi, Here comes the USB patch queue with a few bugfixes. please pull, Gerd The following changes since commit 44520db10b1b92f272348ab7028e7afc68ac3edf: Gdbstub: Fix back-trace on SPARC32 (2011-09-10 18:12:35 +) are available in the git repository at: git://git.kraxel.org/qemu usb.27

[Qemu-devel] [PATCH 1/6] usb-storage: fix NULL pointer dereference.

2011-09-15 Thread Gerd Hoffmann
When a usb packet is canceled we need to check whenever we actually have a scsi request in flight before we try to cancel it. Signed-off-by: Gerd Hoffmann --- hw/usb-msd.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/hw/usb-msd.c b/hw/usb-msd.c index e92434c..08d2

[Qemu-devel] [PATCH 2/6] usb-hub: need to check dev->attached

2011-09-15 Thread Gerd Hoffmann
commit 891fb2cd4592b6fe76106a69e0ca40efbf82726a did that for all host controllers, the usb hub was left out by accident. Signed-off-by: Gerd Hoffmann --- hw/usb-hub.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb-hub.c b/hw/usb-hub.c index 286e3ad..39382c7 10

[Qemu-devel] [PATCH 5/6] usb-host: handle USBDEVFS_SETCONFIGURATION returning EBUSY

2011-09-15 Thread Gerd Hoffmann
In case the host uses the usb device usbfs will refuse to set the configuration due to the device being busy. Handle this case by disconnection the interfaces, then trying again. Signed-off-by: Gerd Hoffmann --- usb-linux.c | 36 +++- 1 files changed, 35 insert

[Qemu-devel] [PATCH 3/6] usb: fix port reset

2011-09-15 Thread Gerd Hoffmann
commit 891fb2cd4592b6fe76106a69e0ca40efbf82726a removed the implicit detach before (re-)attaching in usb_attach(). Some usb host controllers used that behavior though to do a port reset by a detach+attach sequence. This patch establishes old behavior by adding a new usb_reset() function for port

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-15 Thread Avi Kivity
On 09/15/2011 01:18 PM, Jan Kiszka wrote: On 2011-09-15 11:53, Avi Kivity wrote: >>>The host pci bridge remaps this as >>> 0x100105-0x100106 in the memory address space space. But >>> someone configured a cpu-local region at this address, so the cpu can't >>> reach it at all. >

[Qemu-devel] [PATCH 6/6] hw/usb-ohci: Fix OHCI_TD_T1 bit position definition

2011-09-15 Thread Gerd Hoffmann
From: Peter Maydell The OHCI Transfer Descriptor T (DataToggle) bits are 24 and 25; fix an error which accidentally overlaid them both on the same bit. Signed-off-by: Peter Maydell Signed-off-by: Gerd Hoffmann --- hw/usb-ohci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

Re: [Qemu-devel] [PATCH 1/2] hw/usb-ohci: Honour endpoint maximum packet size

2011-09-15 Thread Peter Maydell
On 15 September 2011 11:49, Gerd Hoffmann wrote: >Peter Maydell wrote: >> It seems to me that at least some of that is likely to be >> guest-visible, especially in the case where an endpoint returns an >> error partway through. So it's not clear to me that you could >> validly batch up everything

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-15 Thread ronnie sahlberg
On Thu, Sep 15, 2011 at 7:11 PM, Paolo Bonzini wrote: ... > Perhaps Ronnie has rough performance numbers comparing in-kernel iSCSI with > libiscsi? I did some tests some time ago just doing things like 'dd if=/dev/sda of=/dev/null' on the root disk from within a RHEL guest itself and performace w

[Qemu-devel] [PATCH 4/6] usb-host: factor out code

2011-09-15 Thread Gerd Hoffmann
Move code to claim usb ports and to disconnect usb interfaces into usb_host_claim_port and usb_host_disconnect_ifaces functions. No functional change. Signed-off-by: Gerd Hoffmann --- usb-linux.c | 140 -- 1 files changed, 77 insertions(+

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-15 Thread Avi Kivity
On 09/15/2011 01:01 PM, Benjamin Herrenschmidt wrote: > Sure :). So the problem is that when emulating the G3 Beige machine in > QEMU (default ppc32 target) we also add a PCI VGA adapter. Apparently, > on x86 that PCI VGA adapter can map the special VGA regions to > somewhere, namely 0xa.

Re: [Qemu-devel] PATCH: s390: fix reset hypercall to reset the status

2011-09-15 Thread Alexander Graf
On 09/15/2011 10:22 AM, Christian Borntraeger wrote: This patch fixes the reset hypercall which is supposed to also reset the device status in device memory. This fixes the following bug: [root@localhost driver]# echo virtio0> unbind [ 35.056966] [ cut here ] [ 35.05

Re: [Qemu-devel] Design of the blobstore

2011-09-15 Thread Daniel P. Berrange
On Thu, Sep 15, 2011 at 12:17:54PM +0100, Stefan Hajnoczi wrote: > On Wed, Sep 14, 2011 at 6:05 PM, Stefan Berger > wrote: > >  One property of the blobstore is that it has a certain required size for > > accommodating all blobs of device that want to store their blobs onto. The > > assumption is

Re: [Qemu-devel] [PATCH V4] booke timers

2011-09-15 Thread Alexander Graf
On 09/13/2011 04:00 PM, Fabien Chouteau wrote: While working on the emulation of the freescale p2010 (e500v2) I realized that there's no implementation of booke's timers features. Currently mpc8544 uses ppc_emb (ppc_emb_timers_init) which is close but not exactly like booke (for example booke use

Re: [Qemu-devel] Design of the blobstore

2011-09-15 Thread Kevin Wolf
Am 15.09.2011 13:17, schrieb Stefan Hajnoczi: > On Wed, Sep 14, 2011 at 6:05 PM, Stefan Berger > wrote: >> One property of the blobstore is that it has a certain required size for >> accommodating all blobs of device that want to store their blobs onto. The >> assumption is that the size of these

Re: [Qemu-devel] qemu virtIO blocking operation - question

2011-09-15 Thread Stefan Hajnoczi
On Tue, Sep 13, 2011 at 6:35 PM, Sinha, Ani wrote: > Makes sense? I'm still not sure what the point of multiplexing host IPMI into guests is. The guest should not be able to power off the host. It shouldn't be able to mess with the watchdog timer. It may wish to read sensors but do they even m

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-15 Thread Dor Laor
On 09/15/2011 12:11 PM, Paolo Bonzini wrote: On 09/15/2011 10:48 AM, Dor Laor wrote: We need the same patch for NBD, so I wouldn't bother with the synchronous flush. It seems to me that using a qemu external initiator/target pairs like Orit's original design in http://wiki.qemu.org/Features/Li

Re: [Qemu-devel] [PATCH 1/2] hw/usb-ohci: Honour endpoint maximum packet size

2011-09-15 Thread Gerd Hoffmann
On 09/15/11 13:24, Peter Maydell wrote: On 15 September 2011 11:49, Gerd Hoffmann wrote: Peter Maydell wrote: It seems to me that at least some of that is likely to be guest-visible, especially in the case where an endpoint returns an error partway through. So it's not clear to me that you cou

Re: [Qemu-devel] [PATCH 1/2] KVM: emulate lapic tsc deadline timer for guest

2011-09-15 Thread Marcelo Tosatti
On Thu, Sep 15, 2011 at 04:17:20PM +0800, Liu, Jinsong wrote: > Marcelo Tosatti wrote: > >> + } else if (apic_lvtt_tscdeadline(apic)) { > >> + /* lapic timer in tsc deadline mode */ > >> + u64 guest_tsc, guest_tsc_delta, ns = 0; > >> + struct kvm_vcpu *vcpu = apic->vcpu;

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-15 Thread Christoph Hellwig
On Thu, Sep 15, 2011 at 02:42:42PM +0300, Dor Laor wrote: > My main motivation for external iScsi is to provide qemu operations w/ non > shared storage. iSCSI with multiple initiator is shared storage.

Re: [Qemu-devel] [Bug 824650] [NEW] Latest GIT assert error in arp_table.c

2011-09-15 Thread Jan Kiszka
On 2011-09-15 12:53, Roy Tam wrote: > 2011/9/15 Jan Kiszka : >> On 2011-09-15 09:38, Roy Tam wrote: >>> 2011/9/15 Jan Kiszka : On 2011-09-15 06:11, Roy Tam wrote: > 2011/8/12 Nigel Horne <824...@bugs.launchpad.net>: >> Public bug reported: >> >> The latest git version of qemu (

Re: [Qemu-devel] Design of the blobstore

2011-09-15 Thread Stefan Hajnoczi
On Thu, Sep 15, 2011 at 12:40 PM, Kevin Wolf wrote: > Am 15.09.2011 13:17, schrieb Stefan Hajnoczi: >> On Wed, Sep 14, 2011 at 6:05 PM, Stefan Berger >> wrote: >>>  One property of the blobstore is that it has a certain required size for >>> accommodating all blobs of device that want to store th

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-15 Thread Paolo Bonzini
On 09/15/2011 01:42 PM, Dor Laor wrote: However, iSCSI is a complex protocol and a complex suite of tools. With a simpler set of tools such as qemu-nbd/nbd, you can for example tunnel data over the libvirt connection. Possibly with encryption. Also, with iSCSI you're tied to raw, while qemu-nbd

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-15 Thread Dor Laor
On 09/15/2011 02:46 PM, Christoph Hellwig wrote: On Thu, Sep 15, 2011 at 02:42:42PM +0300, Dor Laor wrote: My main motivation for external iScsi is to provide qemu operations w/ non shared storage. iSCSI with multiple initiator is shared storage. Exactly :) that's the magic.

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-15 Thread Paolo Bonzini
On 09/15/2011 02:01 PM, Dor Laor wrote: My main motivation for external iScsi is to provide qemu operations w/ non shared storage. iSCSI with multiple initiator is shared storage. Exactly :) that's the magic. I think we're on the same page, it's just a difference in terms. iSCSI or NBD wo

Re: [Qemu-devel] [Bug 824650] [NEW] Latest GIT assert error in arp_table.c

2011-09-15 Thread Roy Tam
2011/9/15 Jan Kiszka : > On 2011-09-15 12:53, Roy Tam wrote: >> 2011/9/15 Jan Kiszka : >>> On 2011-09-15 09:38, Roy Tam wrote: 2011/9/15 Jan Kiszka : > On 2011-09-15 06:11, Roy Tam wrote: >> 2011/8/12 Nigel Horne <824...@bugs.launchpad.net>: >>> Public bug reported: >>> >>>

Re: [Qemu-devel] [PATCH] configure: Make missing pkg-config an error rather than a warning

2011-09-15 Thread Paolo Bonzini
On 09/15/2011 01:15 PM, Peter Maydell wrote: If pkg-config doesn't exist then make configure fail immediately with a useful error message. Now that glib is a required dependency, proceeding despite the missing pkg-config will just cause us to fail later with a misleading message about glib not be

Re: [Qemu-devel] [PATCH] fix compilation with stderr trace backend

2011-09-15 Thread Stefan Hajnoczi
On Tue, Sep 13, 2011 at 05:47:52PM +0200, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > trace-events |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to the trivial patches tree: http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches

Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-i386: Remove data type CCTable

2011-09-15 Thread Stefan Hajnoczi
On Wed, Sep 14, 2011 at 06:27:54PM +0200, Stefan Weil wrote: > Remove also two assert statements which were the last remaining users. > > Signed-off-by: Stefan Weil > --- > target-i386/cpu.h |5 - > target-i386/translate.c |5 - > 2 files changed, 0 insertions(+), 10 deleti

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Make missing pkg-config an error rather than a warning

2011-09-15 Thread Stefan Hajnoczi
On Thu, Sep 15, 2011 at 12:15:56PM +0100, Peter Maydell wrote: > If pkg-config doesn't exist then make configure fail immediately > with a useful error message. Now that glib is a required dependency, > proceeding despite the missing pkg-config will just cause us to > fail later with a misleading m

[Qemu-devel] blobstore disk format (was Re: Design of the blobstore)

2011-09-15 Thread Michael S. Tsirkin
So the below is a proposal for a directory scheme for storing (optionally multiple) nvram images, along with any metadata. Data is encoded using BER: http://en.wikipedia.org/wiki/Basic_Encoding_Rules Specifically, we mostly use the subsets. We use a directory as a SET in a CER format. This allows

Re: [Qemu-devel] Design of the blobstore

2011-09-15 Thread Michael S. Tsirkin
> We'll need to invent our > own key-value store when there are plenty of existing ones. Let's not invent our own. So a proposal I sent uses an existing one (BER encoding) for such a store. I actually think we can switch to BER more widely such as for migration format. -- MST

Re: [Qemu-devel] Design of the blobstore [API of the NVRAM]

2011-09-15 Thread Stefan Berger
On 09/15/2011 07:17 AM, Stefan Hajnoczi wrote: On Wed, Sep 14, 2011 at 6:05 PM, Stefan Berger wrote: One property of the blobstore is that it has a certain required size for accommodating all blobs of device that want to store their blobs onto. The assumption is that the size of these blobs

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-15 Thread Orit Wasserman
On Thu, 2011-09-15 at 13:58 +0200, Paolo Bonzini wrote: > On 09/15/2011 01:42 PM, Dor Laor wrote: > >> > >> However, iSCSI is a complex protocol and a complex suite of tools. With > >> a simpler set of tools such as qemu-nbd/nbd, you can for example tunnel > >> data over the libvirt connection. Pos

[Qemu-devel] Help needed -- vvfat.c

2011-09-15 Thread Pintu Kumar
Hi, This is regarding qemu block/vvfat.c. Currently vvfat scans all directories and sub-directories in the beginning during init_directories(). I want to modify vvfat such that it should scan only the TOP directory content and not the sub-directory content before mounting. And after mounting vvf

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-15 Thread Paolo Bonzini
On 09/15/2011 02:34 PM, Orit Wasserman wrote: > Then you need an iSCSI*target* that understands qcow2, like qemu-nbd > but for iSCSI... that's exactly the thing you were worried about > implementing. Not really , this is just part of the target configuration. For each file in the chain we c

Re: [Qemu-devel] [PATCH 1/2] KVM: emulate lapic tsc deadline timer for guest

2011-09-15 Thread Marcelo Tosatti
On Thu, Sep 15, 2011 at 02:22:58PM +0800, Liu, Jinsong wrote: > Marcelo Tosatti wrote: > >> diff --git a/arch/x86/include/asm/apicdef.h > >> b/arch/x86/include/asm/apicdef.h > >> index 34595d5..3925d80 100644 > >> --- a/arch/x86/include/asm/apicdef.h > >> +++ b/arch/x86/include/asm/apicdef.h > >>

Re: [Qemu-devel] Design of the blobstore

2011-09-15 Thread Daniel P. Berrange
On Wed, Sep 14, 2011 at 01:05:44PM -0400, Stefan Berger wrote: > Hello! > > Over the last few days primarily Michael Tsirkin and I have > discussed the design of the 'blobstore' via IRC (#virtualization). > The intention of the blobstore is to provide storage to persist > blobs that devices crea

Re: [Qemu-devel] [Bug 824650] [NEW] Latest GIT assert error in arp_table.c

2011-09-15 Thread Jan Kiszka
On 2011-09-15 14:05, Roy Tam wrote: > Here you go. > > sb16: warning: command 0xf,1 is not truly understood yet > sb16: warning: command 0xe,2 is not truly understood yet > [Switching to Thread 13840.0x3140] > > Breakpoint 1, arp_table_search (slirp=0x19f7380, ip_addr=4294967295, > out_ethadd

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Anthony Liguori
On 09/15/2011 05:49 AM, Stefan Hajnoczi wrote: On Thu, Sep 15, 2011 at 7:31 AM, Gleb Natapov wrote: On Wed, Sep 14, 2011 at 01:04:00PM -0500, Anthony Liguori wrote: For isa machines: /isa/ide@0170/drive@0/disk@0 /isa/fdc@03f1/floppy@1 /isa/fdc@03f1/floppy@0 /isa/ide@0170/drive@0/disk@1 Yes, i

Re: [Qemu-devel] Design of the blobstore

2011-09-15 Thread Stefan Berger
On 09/15/2011 09:05 AM, Daniel P. Berrange wrote: On Wed, Sep 14, 2011 at 01:05:44PM -0400, Stefan Berger wrote: Hello! Over the last few days primarily Michael Tsirkin and I have discussed the design of the 'blobstore' via IRC (#virtualization). The intention of the blobstore is to provide

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Anthony Liguori
On 09/15/2011 01:31 AM, Gleb Natapov wrote: On Wed, Sep 14, 2011 at 01:04:00PM -0500, Anthony Liguori wrote: All device relationships are identified as named properties. A QOM path name consists of a named device, followed by a series of properties which may or may not refer to other devices.

Re: [Qemu-devel] [Bug 824650] [NEW] Latest GIT assert error in arp_table.c

2011-09-15 Thread Roy Tam
2011/9/15 Jan Kiszka : > On 2011-09-15 14:05, Roy Tam wrote: >> Here you go. >> >> sb16: warning: command 0xf,1 is not truly understood yet >> sb16: warning: command 0xe,2 is not truly understood yet >> [Switching to Thread 13840.0x3140] >> >> Breakpoint 1, arp_table_search (slirp=0x19f7380, ip_add

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Anthony Liguori
On 09/15/2011 01:47 AM, Paolo Bonzini wrote: On 09/14/2011 08:04 PM, Anthony Liguori wrote: The concept of busses are implemented as an interface that a device implements. I noticed that you haven't written in the document how to make devices reside on a particular bus (PCI, ISA, I2C, ...). T

Re: [Qemu-devel] Design of the blobstore

2011-09-15 Thread Daniel P. Berrange
On Thu, Sep 15, 2011 at 09:13:25AM -0400, Stefan Berger wrote: > On 09/15/2011 09:05 AM, Daniel P. Berrange wrote: > >On Wed, Sep 14, 2011 at 01:05:44PM -0400, Stefan Berger wrote: > >>Hello! > >> > >> Over the last few days primarily Michael Tsirkin and I have > >>discussed the design of the 'bl

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Paolo Bonzini
On 09/15/2011 03:26 PM, Anthony Liguori wrote: class PciConnector : public PciDevice { // provides interfaces to register closures which implement // PCI abstract functions }; or actually even class PciConnector : Plug { PciBus *bus; uint8_t config_space[4096]; ... } The properti

Re: [Qemu-devel] [PATCH] hid: vmstat fix

2011-09-15 Thread Gerd Hoffmann
On 09/14/11 09:59, Paolo Bonzini wrote: On 09/14/2011 09:40 AM, TeLeMan wrote: >> >> The commit "usb/hid: add hid_pointer_activate, use it" used >> HIDMouseState.mouse_grabbed in hid_pointer_activate(), so >> mouse_grabbed should be added into vmstat. > > Does this fix a bug? qemu_activate_mous

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Jan Kiszka
On 2011-09-15 00:11, Anthony Liguori wrote: > On 09/14/2011 04:15 PM, Jan Kiszka wrote: >> On 2011-09-14 21:42, Anthony Liguori wrote: Such names can get fairly long I'm afraid... >>> >>> A user should never even see these names. A user probably will always >>> interact with devices via paths

  1   2   >