[Qemu-devel] [RFC PATCH V1 09/14] xilinx_intc: Added fdt generic platform support

2011-08-25 Thread Peter A. G. Crosthwaite
Signed-off-by: Peter A. G. Crosthwaite --- hw/xilinx_intc.c | 35 ++- 1 files changed, 34 insertions(+), 1 deletions(-) diff --git a/hw/xilinx_intc.c b/hw/xilinx_intc.c index cb72d5a..aa7783a 100644 --- a/hw/xilinx_intc.c +++ b/hw/xilinx_intc.c @@ -158,9 +158,11

[Qemu-devel] [RFC PATCH V1 10/14] xilinx_ethlite: Added fdt generic platform support

2011-08-25 Thread Peter A. G. Crosthwaite
Signed-off-by: Peter A. G. Crosthwaite --- hw/xilinx_ethlite.c | 39 ++- 1 files changed, 38 insertions(+), 1 deletions(-) diff --git a/hw/xilinx_ethlite.c b/hw/xilinx_ethlite.c index f35ba84..c06b015 100644 --- a/hw/xilinx_ethlite.c +++ b/hw/xilinx_ethlite.

[Qemu-devel] [RFC PATCH V1 08/14] xilinx_timer: Added fdt_generic platform support

2011-08-25 Thread Peter A. G. Crosthwaite
Signed-off-by: Peter A. G. Crosthwaite --- hw/xilinx_timer.c | 39 ++- 1 files changed, 38 insertions(+), 1 deletions(-) diff --git a/hw/xilinx_timer.c b/hw/xilinx_timer.c index f1c7abc..8fe32f6 100644 --- a/hw/xilinx_timer.c +++ b/hw/xilinx_timer.c @@ -215,

[Qemu-devel] [RFC PATCH V1 11/14] vl.c: Added hw_dtb/kern_dtb command line opts

2011-08-25 Thread Peter A. G. Crosthwaite
Added command line options to specify device-tree-blobs for fdt generic platforms. Different dtbs can be used for software and harware by using both options concurrently Signed-off-by: Peter A. G. Crosthwaite --- qemu-options.hx | 47 +++ sysemu.h

[Qemu-devel] [PATCH] disasm: update comment

2011-08-25 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- disas.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/disas.c b/disas.c index 1334b8e..611b30b 100644 --- a/disas.c +++ b/disas.c @@ -137,7 +137,7 @@ print_insn_thumb1(bfd_vma pc, disassemble_info *info) /* Disassemble this for me

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-08-25 Thread Avi Kivity
On 08/22/2011 08:12 PM, Jan Kiszka wrote: Most VGA memory access modes require MMIO handling as they demand weird logic to get a byte from or into the video RAM. However, there is one exception: chain 4 mode with all memory planes enabled for writing. This mode actually allows lineary mapping, wh

[Qemu-devel] [PATCH] qcow2: use always stderr for debugging

2011-08-25 Thread Frediano Ziglio
let all DEBUG_ALLOC2 printf goes to stderr Signed-off-by: Frediano Ziglio --- block/qcow2-cluster.c |2 +- block/qcow2-refcount.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 9269dda..9034840 100644 --- a/blo

[Qemu-devel] [PATCH] qcow2: remove unused qcow2_create_refcount_update function

2011-08-25 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow2-refcount.c | 18 -- block/qcow2.h |2 -- 2 files changed, 0 insertions(+), 20 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 2a915be..62946bb 100644 --- a/block/qcow2-refcount.c +++ b/

Re: [Qemu-devel] Guest kernel device compatability auto-detection

2011-08-25 Thread Richard W.M. Jones
On Thu, Aug 25, 2011 at 08:33:04AM +0300, Avi Kivity wrote: > On 08/25/2011 08:21 AM, Sasha Levin wrote: > >Hi, > > > >Currently when we run the guest we treat it as a black box, we're not > >quite sure what it's going to start and whether it supports the same > >features we expect it to support wh

Re: [Qemu-devel] Guest kernel device compatability auto-detection

2011-08-25 Thread Sasha Levin
On Thu, 2011-08-25 at 08:32 +0100, Richard W.M. Jones wrote: > On Thu, Aug 25, 2011 at 08:33:04AM +0300, Avi Kivity wrote: > > On 08/25/2011 08:21 AM, Sasha Levin wrote: > > >Hi, > > > > > >Currently when we run the guest we treat it as a black box, we're not > > >quite sure what it's going to star

Re: [Qemu-devel] Guest kernel device compatability auto-detection

2011-08-25 Thread Richard W.M. Jones
On Thu, Aug 25, 2011 at 10:40:34AM +0300, Sasha Levin wrote: > From what I gathered libguestfs only provides access to the guests' > image. Correct. > Which part is doing the IKCONFIG or System.map probing? Or is it done in > a different way? You'll have to see what Matt's doing in the virt-v2v

[Qemu-devel] [PULL] Fix for ppc/escc crash

2011-08-25 Thread Avi Kivity
Anthony/Blue, please pull from: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/urgent to receive a fix for a crash caused by the memory API conversion: Avi Kivity (1): ppc_oldworld, ppc_newworld: fix escc BAR related crash hw/ppc_newworld.c |5 - hw/ppc_oldworld.c |

[Qemu-devel] [PULL] Memory API conversions, batch 5

2011-08-25 Thread Avi Kivity
Please pull from git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/batch to receive the fifth memory API conversions batch. There is really nothing notable, except perhaps the first use of the transaction API. While the patches have been on the list for just a short time, they have

Re: [Qemu-devel] [PATCH] qemu-coroutine: Add simple work queue support

2011-08-25 Thread Stefan Hajnoczi
On Thu, Aug 25, 2011 at 04:46:59PM +1000, Peter Crosthwaite wrote: > Hi Stefan, > > I have ccd you on a RFC containing the work that this patch uses. I have > also changed the name of the function to co_queue_enter_next() as i think > yield was not the appropriate name. The idea is the top level t

[Qemu-devel] [PATCH 00/19] Memory API conversions: batch 6

2011-08-25 Thread Avi Kivity
More fairly straightforward conversions. If you have limited time, please review my patches, as Richard's have already been reviewed. Avi Kivity (9): mips_fulong2e: convert to memory API mips_jazz: convert to memory API mips_malta: convert to memory API mips_mipssim: convert to memory API

[Qemu-devel] [PATCH 14/19] i8254: Convert to MemoryRegion

2011-08-25 Thread Avi Kivity
From: Richard Henderson Signed-off-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/i8254.c | 16 +--- 1 files changed, 13 insertions(+), 3 deletions(-) diff --git a/hw/i8254.c b/hw/i8254.c index a9ca9f6..12571ef 100644 --- a/hw/i8254.c +++ b/hw/i8254.c @@ -55,6 +55,7 @@ t

[Qemu-devel] [PATCH 15/19] i8259: Convert to MemoryRegion

2011-08-25 Thread Avi Kivity
From: Richard Henderson The only non-obvious part is pic_poll_read which used "addr1 >> 7" to detect whether one referred to either the master or slave PIC. Instead, test this directly. Signed-off-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/i8259.c | 65 +

[Qemu-devel] [PATCH 10/19] isa: Pass i/o address space to isa_bus_new

2011-08-25 Thread Avi Kivity
From: Richard Henderson Not used yet, but at least we're provided with the correct region. Signed-off-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/isa-bus.c |4 +++- hw/isa.h |2 +- hw/mips_jazz.c | 17 ++--- hw/mips_r4k.c |2 +- hw/pc_piix.c |

[Qemu-devel] [PATCH 08/19] omap1: convert to memory API (part II)

2011-08-25 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/omap.h |7 ++- hw/omap1.c | 195 2 files changed, 111 insertions(+), 91 deletions(-) diff --git a/hw/omap.h b/hw/omap.h index bae6bed..bb25754 100644 --- a/hw/omap.h +++ b/hw/omap.h @@ -677,7 +677

[Qemu-devel] [PATCH 02/19] mips_jazz: convert to memory API

2011-08-25 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/mips_jazz.c | 81 +++ 1 files changed, 40 insertions(+), 41 deletions(-) diff --git a/hw/mips_jazz.c b/hw/mips_jazz.c index a741086..91e15b9 100644 --- a/hw/mips_jazz.c +++ b/hw/mips_jazz.c @@ -52,44 +52,42 @@

[Qemu-devel] [PATCH] build: sort objects to remove duplicates for link

2011-08-25 Thread Stefan Hajnoczi
Avoid duplicate object files during the link. There are legitimate cases where a link command-line would include duplicate object files because two independent subsystems both depend on common infrastructure. Use GNU make's $(sort) function to remove duplicate object files from the link command-l

Re: [Qemu-devel] [PATCH] disasm: update comment

2011-08-25 Thread Stefan Hajnoczi
On Thu, Aug 25, 2011 at 09:14:38AM +0200, Frediano Ziglio wrote: > > Signed-off-by: Frediano Ziglio > --- > disas.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to the trivial patches tree: http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patche

[Qemu-devel] [PATCH 07/19] omap1: convert to memory API (part I)

2011-08-25 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/omap.h | 11 ++- hw/omap1.c| 338 +++- hw/omap_sx1.c |4 +- hw/palm.c |4 +- 4 files changed, 203 insertions(+), 154 deletions(-) diff --git a/hw/omap.h b/hw/omap.h index db101c6..bae6bed

[Qemu-devel] [PATCH 18/19] fdc: Convert isabus_fdc_init1 to MemoryRegion

2011-08-25 Thread Avi Kivity
From: Richard Henderson This requires some amount of hoop-jumping, so that we don't inadvertently claim port 0x3f6, which is used by ISA IDE. The sysbus initialization path is as yet unconverted. Signed-off-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/fdc.c | 53 +

[Qemu-devel] [PATCH 11/19] isa: add isa_register_ioport()

2011-08-25 Thread Avi Kivity
From: Richard Henderson To replace isa_init_ioport and isa_init_ioport_range as the ISA devices are converted to the memory api. [avi: use memory_region_size()] Signed-off-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/isa-bus.c | 10 ++ hw/isa.h |5 - 2 files c

[Qemu-devel] [PATCH 05/19] mips_r4k: convert to memory API

2011-08-25 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/mips_r4k.c | 38 ++ 1 files changed, 14 insertions(+), 24 deletions(-) diff --git a/hw/mips_r4k.c b/hw/mips_r4k.c index 51dc868..efa4b05 100644 --- a/hw/mips_r4k.c +++ b/hw/mips_r4k.c @@ -42,8 +42,8 @@ static struct _loaderpa

[Qemu-devel] [PATCH 09/19] pci: add pci_address_space_io()

2011-08-25 Thread Avi Kivity
From: Richard Henderson Returns the I/O address space. Useful for implementing PCI-ISA bridge devices. Signed-off-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/pci.c |5 + hw/pci.h |1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c i

[Qemu-devel] [PATCH 1/2] Fix up some style nits of last uq/master merge

2011-08-25 Thread Stefan Hajnoczi
From: Jan Kiszka Signed-off-by: Jan Kiszka Signed-off-by: Stefan Hajnoczi --- cutils.c |2 +- target-i386/kvm.c |5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/cutils.c b/cutils.c index f2bcf20..c91f887 100644 --- a/cutils.c +++ b/cutils.c @@ -408,7 +4

[Qemu-devel] [PATCH 2/2] disasm: update comment

2011-08-25 Thread Stefan Hajnoczi
From: Frediano Ziglio Signed-off-by: Frediano Ziglio Signed-off-by: Stefan Hajnoczi --- disas.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/disas.c b/disas.c index 1334b8e..611b30b 100644 --- a/disas.c +++ b/disas.c @@ -137,7 +137,7 @@ print_insn_thumb1(bfd_vma pc

[Qemu-devel] [PULL 0/2] Trivial patches for August 13 to 25 2011

2011-08-25 Thread Stefan Hajnoczi
The following changes since commit 89da90b1b4acf24a9a3f2fd197b1bdf69ab24e72: gt64xxx: fix crash in gt64120_pci_mapping() (2011-08-24 21:11:21 +0200) are available in the git repository at: ssh://repo.or.cz/srv/git/qemu/stefanha.git trivial-patches Frediano Ziglio (1): disasm: update co

[Qemu-devel] [PATCH 16/19] pckbd: Convert to MemoryRegion

2011-08-25 Thread Avi Kivity
From: Richard Henderson Slightly non-obvious with mips_jazz passing in the region structure to populate. Signed-off-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/mips_jazz.c |4 ++- hw/pc.h|2 +- hw/pckbd.c | 59 ++

[Qemu-devel] [PATCH 06/19] musicpal: convert to memory API

2011-08-25 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/musicpal.c | 243 +++-- 1 files changed, 99 insertions(+), 144 deletions(-) diff --git a/hw/musicpal.c b/hw/musicpal.c index 5e74ee7..ffde117 100644 --- a/hw/musicpal.c +++ b/hw/musicpal.c @@ -19,6 +19,7 @@ #i

[Qemu-devel] [PATCH 03/19] mips_malta: convert to memory API

2011-08-25 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/mips_malta.c | 53 +++-- 1 files changed, 27 insertions(+), 26 deletions(-) diff --git a/hw/mips_malta.c b/hw/mips_malta.c index b5c9bcf..a093b65 100644 --- a/hw/mips_malta.c +++ b/hw/mips_malta.c @@ -57,6 +57,9 @

[Qemu-devel] [PATCH 17/19] serial: Convert serial_isa_initfn to MemoryRegion

2011-08-25 Thread Avi Kivity
From: Richard Henderson The serial_mm_init path is as yet unconverted. Signed-off-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/serial.c | 15 --- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/hw/serial.c b/hw/serial.c index ed7fd0a..2e6d212 100644 ---

Re: [Qemu-devel] [PATCH] hw/smc91c111: Convert to MemoryRegion

2011-08-25 Thread Avi Kivity
On 08/24/2011 08:28 PM, Peter Maydell wrote: Signed-off-by: Peter Maydell --- This is against master and doesn't depend on or conflict with anything that's in Avi's branch. (I needed this because I've just rebased qemu-linaro on master and one of the omap3 boards connects an smc91c111 up to the o

[Qemu-devel] [PATCH 12/19] pc: Re-order pc_init1 to initialize the ISA bus before ISA devices

2011-08-25 Thread Avi Kivity
From: Richard Henderson In particular, the i8259 was being initialized before the ISA bus, leading to a crash. Signed-off-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/pc_piix.c | 22 -- 1 files changed, 12 insertions(+), 10 deletions(-) diff --git a/hw/pc_piix

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-08-25 Thread Jan Kiszka
On 2011-08-25 09:19, Avi Kivity wrote: > On 08/22/2011 08:12 PM, Jan Kiszka wrote: >> Most VGA memory access modes require MMIO handling as they demand weird >> logic to get a byte from or into the video RAM. However, there is one >> exception: chain 4 mode with all memory planes enabled for writin

Re: [Qemu-devel] [PATCH 10/14] qapi: add change-vnc-password

2011-08-25 Thread Gerd Hoffmann
On 08/24/11 20:43, Anthony Liguori wrote: This is a new QMP only command that only changes the VNC password. What is wrong with "set_password vnc $secret" ? cheers, Gerd

[Qemu-devel] [PATCH] vga: Silence bogus gcc warning about uninitialized variables

2011-08-25 Thread Jan Kiszka
Some gcc versions do not properly detect that all possible cases are covered and base and size are always initialized. Please gcc by defining a pseudo default case. Signed-off-by: Jan Kiszka --- hw/vga.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/vga.c b/hw/vga.c

[Qemu-devel] [PATCH 04/19] mips_mipssim: convert to memory API

2011-08-25 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/mips_mipssim.c | 16 +--- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/hw/mips_mipssim.c b/hw/mips_mipssim.c index 0d46cc4..d013494 100644 --- a/hw/mips_mipssim.c +++ b/hw/mips_mipssim.c @@ -35,6 +35,7 @@ #include "mips-bios.h" #i

[Qemu-devel] [PATCH 01/19] mips_fulong2e: convert to memory API

2011-08-25 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/mips_fulong2e.c | 17 ++--- 1 files changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/mips_fulong2e.c b/hw/mips_fulong2e.c index ec8c88e..abe3056 100644 --- a/hw/mips_fulong2e.c +++ b/hw/mips_fulong2e.c @@ -38,6 +38,7 @@ #include "vt82c686.

[Qemu-devel] [PATCH 13/19] cs4231a: Convert to MemoryRegion

2011-08-25 Thread Avi Kivity
From: Richard Henderson Signed-off-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/cs4231a.c | 38 +++--- 1 files changed, 19 insertions(+), 19 deletions(-) diff --git a/hw/cs4231a.c b/hw/cs4231a.c index 598f032..e16665e 100644 --- a/hw/cs4231a.c +++ b

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-08-25 Thread Avi Kivity
On 08/25/2011 12:07 PM, Jan Kiszka wrote: >> > > On which version of grub does this work? This isn't having any effect > on my Fedora grub. It's both grub1 (0.97) in graphical mode as used by OpenSUSE 11.4 and grub2 (1.99-rc1) of Ubuntu 11.04. Is Fedora's grub still slow or was it already fa

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-08-25 Thread Jan Kiszka
On 2011-08-25 11:16, Avi Kivity wrote: > On 08/25/2011 12:07 PM, Jan Kiszka wrote: >>> >>> On which version of grub does this work? This isn't having any effect >>> on my Fedora grub. >> >> It's both grub1 (0.97) in graphical mode as used by OpenSUSE 11.4 and >> grub2 (1.99-rc1) of Ubuntu 1

[Qemu-devel] [PATCH 19/19] pci: simplify memory region registration

2011-08-25 Thread Avi Kivity
The two code paths (for ADDRESS_SPACE_IO and ADDRESS_SPACE_MEM) are almost identical. Unify them. Signed-off-by: Avi Kivity --- hw/pci.c | 15 --- 1 files changed, 4 insertions(+), 11 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 1a5d2b6..e9e37ef 100644 --- a/hw/pci.c +++ b

Re: [Qemu-devel] [PATCH] qed: make qed_alloc_clusters round up offset to nearest cluster

2011-08-25 Thread Stefan Hajnoczi
On Tue, Aug 23, 2011 at 02:38:00PM +0200, Kevin Wolf wrote: > Am 16.08.2011 01:16, schrieb Devin Nakamura: > > Signed-off-by: Devin Nakamura > > --- > > block/qed.c |2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/block/qed.c b/block/qed.c > > index 333f067..9

Re: [Qemu-devel] [RFC PATCH V1 12/14] microblaze: Make the MSR PVR bit non writable

2011-08-25 Thread Peter Maydell
On 25 August 2011 07:41, Peter A. G. Crosthwaite wrote: > From: Edgar E. Iglesias > > Instead of hardcoding it to 1. This and patch 13/14 seem to be generic target-microblaze fixes -- did you mean to include them in this devicetree series rather than sending them separately? -- PMM

Re: [Qemu-devel] [PATCH 2/2] disasm: update comment

2011-08-25 Thread Peter Maydell
On 25 August 2011 09:44, Stefan Hajnoczi wrote: >  /* Disassemble this for me please... (debugging). 'flags' has the following >    values: > -    i386 - nonzero means 16 bit code > +    i386 - 1 means 16 bit code, 2 means 64 bit code ...presumably 0 means 32 bit code, by elimination ? -- PMM

Re: [Qemu-devel] [PATCH 2/2] disasm: update comment

2011-08-25 Thread Frediano Ziglio
2011/8/25 Peter Maydell : > On 25 August 2011 09:44, Stefan Hajnoczi wrote: >>  /* Disassemble this for me please... (debugging). 'flags' has the following >>    values: >> -    i386 - nonzero means 16 bit code >> +    i386 - 1 means 16 bit code, 2 means 64 bit code > > ...presumably 0 means 32 bi

Re: [Qemu-devel] X86 CPU topology broken in qemu ?

2011-08-25 Thread Avi Kivity
> Hi, > > I see that x86 CPU topology inside VM is not showing up as specified. > With some debugging, I found out that the root cause for this: qemu is > not enumerating the apic ids correctly for vcpus. I made the below > hackish change to get it working. Has anybody else seen this problem > ? T

Re: [Qemu-devel] Guest kernel device compatability auto-detection

2011-08-25 Thread Richard W.M. Jones
On Thu, Aug 25, 2011 at 08:48:25AM +0100, Richard W.M. Jones wrote: > On Thu, Aug 25, 2011 at 10:40:34AM +0300, Sasha Levin wrote: > > From what I gathered libguestfs only provides access to the guests' > > image. > > Correct. > > > Which part is doing the IKCONFIG or System.map probing? Or is it

[Qemu-devel] [PATCH] vhost-net: cleanup host notifiers at last step

2011-08-25 Thread Michael S. Tsirkin
When the vhost notifier is disabled, the userspace handler runs immediately: virtio_pci_set_host_notifier_internal might call virtio_queue_notify_vq. Since the VQ state and the tap backend state aren't recovered yet, this causes "Guest moved used index from XXX to YYY" assertions. The solution is

Re: [Qemu-devel] [RFC PATCH V1 12/14] microblaze: Make the MSR PVR bit non writable

2011-08-25 Thread Peter Crosthwaite
Hi Peter , I included them as they are prerequisite for patch 14. Edgar, can we get a review / push of these two separate of this series so I can take them out next revision ? On Aug 25, 2011 7:34 PM, "Peter Maydell" wrote: On 25 August 2011 07:41, Peter A. G. Crosthwaite wrote: > From: Edgar

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-08-25 Thread Avi Kivity
On 08/25/2011 12:21 PM, Jan Kiszka wrote: > > Still slow. I tried an old F11 image I had lying around, and -snapshot > /dev/sda, but this laptop was installed many years ago. I'll download > some more images and try. You may also want to instrument vga_update_memory_access if some requireme

Re: [Qemu-devel] X86 CPU topology broken in qemu ?

2011-08-25 Thread Jan Kiszka
On 2011-08-17 07:25, Bharata B Rao wrote: > Hi, > > I see that x86 CPU topology inside VM is not showing up as specified. > With some debugging, I found out that the root cause for this: qemu is > not enumerating the apic ids correctly for vcpus. I made the below > hackish change to get it working

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-08-25 Thread Jan Kiszka
On 2011-08-25 12:45, Avi Kivity wrote: > On 08/25/2011 12:21 PM, Jan Kiszka wrote: >>> >>> Still slow. I tried an old F11 image I had lying around, and -snapshot >>> /dev/sda, but this laptop was installed many years ago. I'll download >>> some more images and try. >> >> You may also want to i

Re: [Qemu-devel] [PATCH 1/3] Avoid the use of deprecated gnutls gnutls_*_set_priority functions.

2011-08-25 Thread Stefan Hajnoczi
On Mon, Jul 4, 2011 at 11:00 PM, Raghavendra D Prabhu wrote: > The gnutls_*_set_priority family of functions has been marked deprecated > in 2.12.x. These functions have been superceded by > gnutls_priority_set_direct(). > > Signed-off-by: Raghavendra D Prabhu > --- >  ui/vnc-tls.c |   20 +--

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-25 Thread Roedel, Joerg
On Wed, Aug 24, 2011 at 10:56:13AM -0400, Alex Williamson wrote: > On Wed, 2011-08-24 at 10:43 +0200, Joerg Roedel wrote: > > A side-note: Might it be better to expose assigned devices in a guest on > > a seperate bus? This will make it easier to emulate an IOMMU for the > > guest inside qemu. > >

Re: [Qemu-devel] [PATCH 1/3] Avoid the use of deprecated gnutls gnutls_*_set_priority functions.

2011-08-25 Thread Daniel P. Berrange
On Thu, Aug 25, 2011 at 11:54:41AM +0100, Stefan Hajnoczi wrote: > On Mon, Jul 4, 2011 at 11:00 PM, Raghavendra D Prabhu > wrote: > > The gnutls_*_set_priority family of functions has been marked deprecated > > in 2.12.x. These functions have been superceded by > > gnutls_priority_set_direct(). >

Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields

2011-08-25 Thread Jan Kiszka
On 2011-08-25 03:14, TeLeMan wrote: > On Wed, Aug 24, 2011 at 17:11, Jan Kiszka wrote: >> On 2011-08-23 12:49, TeLeMan wrote: >>> On Sun, Aug 21, 2011 at 04:00, Stefan Weil wrote: Am 15.08.2011 08:39, schrieb Jan Kiszka: > > The following changes since commit > 3b6ffe50300f13240e

[Qemu-devel] [Bug 833658] [NEW] Qemu ppc does not boot Debian 3.1r8

2011-08-25 Thread Schulz
Public bug reported: I tried booting the official image debian-31r8-powerpc-binary-1.iso with the following commandline: qemu-system-ppc -boot d -cdrom ../debian-31r8-powerpc-binary-1.iso -hda hd.img. The booting process stops with CPU at 100%. I can choose to boot "install-2.4" or "install" wh

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-08-25 Thread Avi Kivity
On 08/25/2011 01:51 PM, Jan Kiszka wrote: > > Plain F15 is slow. SR2 = SR4 = 0. So it's not using chain4 mode. Can you check what mode the adapter is actually in and how VRAM is accessed? Likely, there is nothing we can do about it. /me just wonders what makes F15 grub behave differently from

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-25 Thread Roedel, Joerg
Hi Alex, On Wed, Aug 24, 2011 at 05:13:49PM -0400, Alex Williamson wrote: > Is this roughly what you're thinking of for the iommu_group component? > Adding a dev_to_group iommu ops callback let's us consolidate the sysfs > support in the iommu base. Would AMD-Vi do something similar (or > exactly

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-08-25 Thread Jan Kiszka
On 2011-08-25 13:19, Avi Kivity wrote: > On 08/25/2011 01:51 PM, Jan Kiszka wrote: >>> >>> Plain F15 is slow. SR2 = SR4 = 0. >> >> So it's not using chain4 mode. Can you check what mode the adapter is >> actually in and how VRAM is accessed? Likely, there is nothing we can do >> about it. /me jus

Re: [Qemu-devel] [PATCH v2 14/22] pflash_cfi01/pflash_cfi02: convert to memory API

2011-08-25 Thread Jan Kiszka
On 2011-08-24 15:40, Avi Kivity wrote: > cfi02 is annoying in that is ignores some address bits; we probably > want explicit support in the memory API for that. ... > diff --git a/hw/musicpal.c b/hw/musicpal.c > index 63dd391..5e74ee7 100644 > --- a/hw/musicpal.c > +++ b/hw/musicpal.c > @@ -1502,

Re: [Qemu-devel] [PATCH v2 14/22] pflash_cfi01/pflash_cfi02: convert to memory API

2011-08-25 Thread Avi Kivity
On 08/25/2011 02:37 PM, Jan Kiszka wrote: On 2011-08-24 15:40, Avi Kivity wrote: > cfi02 is annoying in that is ignores some address bits; we probably > want explicit support in the memory API for that. ... > diff --git a/hw/musicpal.c b/hw/musicpal.c > index 63dd391..5e74ee7 100644 > ---

[Qemu-devel] [PATCH] memory: fix memory_region_init_rom_device() not initializing ->ops

2011-08-25 Thread Avi Kivity
Signed-off-by: Avi Kivity --- memory.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/memory.c b/memory.c index 8e9ac46..b91c5da 100644 --- a/memory.c +++ b/memory.c @@ -967,6 +967,7 @@ void memory_region_init_rom_device(MemoryRegion *mr,

Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields

2011-08-25 Thread TeLeMan
On Thu, Aug 25, 2011 at 19:04, Jan Kiszka wrote: > On 2011-08-25 03:14, TeLeMan wrote: >> On Wed, Aug 24, 2011 at 17:11, Jan Kiszka wrote: >>> On 2011-08-23 12:49, TeLeMan wrote: On Sun, Aug 21, 2011 at 04:00, Stefan Weil wrote: > Am 15.08.2011 08:39, schrieb Jan Kiszka: >> >> T

[Qemu-devel] [PATCH] ui: avoid use of deprecated gnutls_*_set_priority functions

2011-08-25 Thread Stefan Hajnoczi
From: Raghavendra D Prabhu The gnutls_*_set_priority family of functions has been marked deprecated in 2.12.x. These functions have been superceded by gnutls_priority_set_direct(). Signed-off-by: Raghavendra D Prabhu Signed-off-by: Daniel P. Berrange Signed-off-by: Stefan Hajnoczi --- Re-send

Re: [Qemu-devel] [PATCH 08/14] qapi: convert eject (qmp and hmp) to QAPI

2011-08-25 Thread Kevin Wolf
Am 24.08.2011 20:43, schrieb Anthony Liguori: > Signed-off-by: Anthony Liguori > --- > blockdev.c | 22 +++--- > blockdev.h |1 - > hmp-commands.hx |3 +-- > hmp.c| 14 ++ > hmp.h|1 + > qapi-schema.json | 25 +

Re: [Qemu-devel] [PATCH 09/14] qapi: convert block_passwd and add set-blockdev-password

2011-08-25 Thread Kevin Wolf
Am 24.08.2011 20:43, schrieb Anthony Liguori: > block_passwd is unfortunately named so while converting block_passwd to QAPI, > introduce a more properly named alias. > > Signed-off-by: Anthony Liguori I'm not sure if I like the set-blockdev-password alias, for two reasons. The first one is tha

Re: [Qemu-devel] [PATCH] ui: avoid use of deprecated gnutls_*_set_priority functions

2011-08-25 Thread Peter Maydell
On 25 August 2011 13:11, Stefan Hajnoczi wrote: > From: Raghavendra D Prabhu > > The gnutls_*_set_priority family of functions has been marked deprecated > in 2.12.x. These functions have been superceded by > gnutls_priority_set_direct(). Does this constitute a change in the required version of

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-25 Thread Roedel, Joerg
On Wed, Aug 24, 2011 at 11:07:46AM -0400, Alex Williamson wrote: > On Wed, 2011-08-24 at 10:52 +0200, Roedel, Joerg wrote: > > On Tue, Aug 23, 2011 at 01:08:29PM -0400, Alex Williamson wrote: > > > On Tue, 2011-08-23 at 15:14 +0200, Roedel, Joerg wrote: > > > > > > Handling it through fds is a goo

Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields

2011-08-25 Thread Jan Kiszka
On 2011-08-25 14:02, TeLeMan wrote: > On Thu, Aug 25, 2011 at 19:04, Jan Kiszka wrote: >> On 2011-08-25 03:14, TeLeMan wrote: >>> On Wed, Aug 24, 2011 at 17:11, Jan Kiszka wrote: On 2011-08-23 12:49, TeLeMan wrote: > On Sun, Aug 21, 2011 at 04:00, Stefan Weil wrote: >> Am 15.08.2011

Re: [Qemu-devel] [PATCH 12/14] qapi: introduce change-blockdev

2011-08-25 Thread Kevin Wolf
Am 24.08.2011 20:43, schrieb Anthony Liguori: > A new QMP only command to change the blockdev associated with a block device. > The semantics of change right now are just plain scary. This command > introduces > sane semantics. For more details, see the documentation in the schema file. Changes

Re: [Qemu-devel] [PATCH 12/14] qapi: introduce change-blockdev

2011-08-25 Thread Anthony Liguori
On 08/25/2011 07:46 AM, Kevin Wolf wrote: Am 24.08.2011 20:43, schrieb Anthony Liguori: A new QMP only command to change the blockdev associated with a block device. The semantics of change right now are just plain scary. This command introduces sane semantics. For more details, see the docume

Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields

2011-08-25 Thread Avi Kivity
On 08/25/2011 03:38 PM, Jan Kiszka wrote: >> >> What a mess. Do we really have to go through all 257 packed data structs >> in QEMU and add these MS compat bits to all potentially affected ones? > I prefer to detect -mms-bitfields and remove it in configure. Can use -mno-ms-bitfields later t

Re: [Qemu-devel] [PULL] VirtFS coroutine changes patchset 2

2011-08-25 Thread Anthony Liguori
On 08/24/2011 10:32 AM, Aneesh Kumar K.V wrote: The following changes since commit f1a7104a5f435a1bf2a1158e6f737dbd89e8c153: Merge remote-tracking branch 'pmaydell/armhw-for-upstream' into staging (2011-08-21 18:34:33 -0500) are available in the git repository at: git://repo.or.cz/qemu

Re: [Qemu-devel] [PULL] Fix for ppc/escc crash

2011-08-25 Thread Anthony Liguori
On 08/25/2011 02:55 AM, Avi Kivity wrote: Anthony/Blue, please pull from: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/urgent to receive a fix for a crash caused by the memory API conversion: Pulled. Thanks. Regards, Anthony Liguori Avi Kivity (1): ppc_oldworld, ppc_newworl

Re: [Qemu-devel] [PULL] Memory API conversions, batch 5

2011-08-25 Thread Anthony Liguori
On 08/25/2011 03:01 AM, Avi Kivity wrote: Please pull from git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/batch to receive the fifth memory API conversions batch. There is really nothing notable, except perhaps the first use of the transaction API. While the patches have been on the

Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields

2011-08-25 Thread Anthony Liguori
On 08/25/2011 07:38 AM, Jan Kiszka wrote: On 2011-08-25 14:02, TeLeMan wrote: On Thu, Aug 25, 2011 at 19:04, Jan Kiszka wrote: What a mess. Do we really have to go through all 257 packed data structs in QEMU and add these MS compat bits to all potentially affected ones? I prefer to detect -mm

Re: [Qemu-devel] [PULL 0/2] Trivial patches for August 13 to 25 2011

2011-08-25 Thread Anthony Liguori
On 08/25/2011 03:44 AM, Stefan Hajnoczi wrote: The following changes since commit 89da90b1b4acf24a9a3f2fd197b1bdf69ab24e72: gt64xxx: fix crash in gt64120_pci_mapping() (2011-08-24 21:11:21 +0200) Pulled. Thanks. Regards, Anthony Liguori are available in the git repository at: ssh:/

Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields

2011-08-25 Thread Anthony Liguori
On 08/25/2011 08:02 AM, Avi Kivity wrote: On 08/25/2011 03:38 PM, Jan Kiszka wrote: >> >> What a mess. Do we really have to go through all 257 packed data structs >> in QEMU and add these MS compat bits to all potentially affected ones? > I prefer to detect -mms-bitfields and remove it in config

Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields

2011-08-25 Thread Jan Kiszka
On 2011-08-25 15:07, Anthony Liguori wrote: > On 08/25/2011 08:02 AM, Avi Kivity wrote: >> On 08/25/2011 03:38 PM, Jan Kiszka wrote: >>> >> >>> >> What a mess. Do we really have to go through all 257 packed data >>> structs >>> >> in QEMU and add these MS compat bits to all potentially affected >>>

Re: [Qemu-devel] [PATCH 10/14] qapi: add change-vnc-password

2011-08-25 Thread Anthony Liguori
On 08/25/2011 04:07 AM, Gerd Hoffmann wrote: On 08/24/11 20:43, Anthony Liguori wrote: This is a new QMP only command that only changes the VNC password. What is wrong with "set_password vnc $secret" ? Overloading a single function to do multiple things makes the function hard to use. Con

Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields

2011-08-25 Thread Jan Kiszka
On 2011-08-25 15:06, Anthony Liguori wrote: > On 08/25/2011 07:38 AM, Jan Kiszka wrote: >> On 2011-08-25 14:02, TeLeMan wrote: >>> On Thu, Aug 25, 2011 at 19:04, Jan Kiszka wrote: What a mess. Do we really have to go through all 257 packed data structs in QEMU and add these MS compa

Re: [Qemu-devel] [PATCH] ui: avoid use of deprecated gnutls_*_set_priority functions

2011-08-25 Thread Daniel P. Berrange
On Thu, Aug 25, 2011 at 01:27:00PM +0100, Peter Maydell wrote: > On 25 August 2011 13:11, Stefan Hajnoczi wrote: > > From: Raghavendra D Prabhu > > > > The gnutls_*_set_priority family of functions has been marked deprecated > > in 2.12.x. These functions have been superceded by > > gnutls_priori

Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields

2011-08-25 Thread Avi Kivity
On 08/25/2011 04:07 PM, Anthony Liguori wrote: On 08/25/2011 08:02 AM, Avi Kivity wrote: On 08/25/2011 03:38 PM, Jan Kiszka wrote: >> >> What a mess. Do we really have to go through all 257 packed data structs >> in QEMU and add these MS compat bits to all potentially affected ones? > I prefe

Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields

2011-08-25 Thread Avi Kivity
On 08/25/2011 04:09 PM, Jan Kiszka wrote: >> >> We should simply avoid bitfields on externally-defined formats; >> meanwhile we can use __attribute__((gcc_struct)) and keep using those we >> have already. > > +1 We aren't discussing bitfields anymore but essential unaligned (and therefore pa

Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields

2011-08-25 Thread Jan Kiszka
On 2011-08-25 15:15, Avi Kivity wrote: > On 08/25/2011 04:07 PM, Anthony Liguori wrote: >> On 08/25/2011 08:02 AM, Avi Kivity wrote: >>> On 08/25/2011 03:38 PM, Jan Kiszka wrote: >> >> What a mess. Do we really have to go through all 257 packed data structs >> in QEMU and add th

Re: [Qemu-devel] [PATCH] qcow2: use always stderr for debugging

2011-08-25 Thread Kevin Wolf
Am 25.08.2011 09:23, schrieb Frediano Ziglio: > let all DEBUG_ALLOC2 printf goes to stderr > > Signed-off-by: Frediano Ziglio Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields

2011-08-25 Thread Avi Kivity
On 08/25/2011 04:19 PM, Jan Kiszka wrote: > > However, I don't like it either, and prefer the > __attribute__(((gcc_fields)) as well. Could someone with a Windows environment test if that (or (packed, gcc_fields)?) makes struct { unsigned char a; unsigned int b; }; tr

Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields

2011-08-25 Thread Avi Kivity
On 08/25/2011 04:13 PM, Jan Kiszka wrote: > > So why can't we just #pragma guard all of the slirp bits? Why are we > doing it on a per data structure basis? Packing all structs is not really a good idea, more a last resort. btw, how are the non-x86s handling this? by trapping and fixuping

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-25 Thread Alexander Graf
On 25.08.2011, at 07:31, Roedel, Joerg wrote: > On Wed, Aug 24, 2011 at 11:07:46AM -0400, Alex Williamson wrote: >> On Wed, 2011-08-24 at 10:52 +0200, Roedel, Joerg wrote: > [...] >> We need to try the polite method of attempting to hot unplug the device >> from qemu first, which the current v

Re: [Qemu-devel] [RFC PATCH V1 00/14] Dynamic machine model creation from device trees

2011-08-25 Thread Anthony Liguori
On 08/25/2011 01:41 AM, Peter A. G. Crosthwaite wrote: Hello This is a general RFC for a framework developed at Petalogix for creating QEMU models based on a passed device tree. Machine models are dynamically constructed from parsing a Device Tree Specification (DTS) - no more hard-coded machi

Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields

2011-08-25 Thread Anthony Liguori
On 08/25/2011 08:13 AM, Jan Kiszka wrote: On 2011-08-25 15:06, Anthony Liguori wrote: On 08/25/2011 07:38 AM, Jan Kiszka wrote: On 2011-08-25 14:02, TeLeMan wrote: On Thu, Aug 25, 2011 at 19:04, Jan Kiszka wrote: What a mess. Do we really have to go through all 257 packed data structs in QE

[Qemu-devel] Questions regarding ivshmem spec

2011-08-25 Thread Sasha Levin
Hello, I am looking to implement an ivshmem device for KVM tools, the purpose is to provide same functionality as QEMU and interoperability with QEMU. Going through the spec (I found here: https://gitorious.org/nahanni/guest-code/blobs/master/device_spec.txt ) and the code in QEMU I have gathered

Re: [Qemu-devel] [PATCH 11/14] qapi: add change-vnc-listen

2011-08-25 Thread Luiz Capitulino
On Wed, 24 Aug 2011 13:43:06 -0500 Anthony Liguori wrote: > New QMP only command to change the VNC server's listening address. > > Signed-off-by: Anthony Liguori > --- > qapi-schema.json | 14 ++ > qmp-commands.hx |8 > qmp.c|7 +++ > 3 files cha

Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields

2011-08-25 Thread Jan Kiszka
On 2011-08-25 15:28, Anthony Liguori wrote: > On 08/25/2011 08:13 AM, Jan Kiszka wrote: >> On 2011-08-25 15:06, Anthony Liguori wrote: >>> On 08/25/2011 07:38 AM, Jan Kiszka wrote: On 2011-08-25 14:02, TeLeMan wrote: > On Thu, Aug 25, 2011 at 19:04, Jan Kiszka wrote: >> What a mess.

Re: [Qemu-devel] [PATCH 10/14] qapi: add change-vnc-password

2011-08-25 Thread Luiz Capitulino
On Wed, 24 Aug 2011 13:43:05 -0500 Anthony Liguori wrote: > This is a new QMP only command that only changes the VNC password. Isn't this useful in HMP too? > > Signed-off-by: Anthony Liguori > --- > qapi-schema.json | 13 + > qmp-commands.hx |8 > qmp.c

  1   2   3   >