Am 24.08.2011 20:43, schrieb Anthony Liguori: > block_passwd is unfortunately named so while converting block_passwd to QAPI, > introduce a more properly named alias. > > Signed-off-by: Anthony Liguori <aligu...@us.ibm.com>
I'm not sure if I like the set-blockdev-password alias, for two reasons. The first one is that blockdev_* is supposed to be the new, clean interface, so I wouldn't add similarly named commands without having a look at the big picture. For example, what again was the reason for having the password separate from other block device options? The second one is that names like set-foo, get-foo and frob-foo make it very hard to see what I can do with a foo. If they are called as today (drive_add, drive_del) and ideally use a consistent prefix (unlike drive_*, block_*, snapshot_blkdev today), you'll find all of them in the same place in the documentation and in HMP typing blockdev_<TAB> will show you everything you can do with a block device. Kevin
