Re: [Qemu-devel] [PATCH 06/11] Goldfish: Added a nand controller.

2011-08-23 Thread Paolo Bonzini
On 08/22/2011 10:41 PM, Stefan Hajnoczi wrote: On Mon, Aug 22, 2011 at 3:16 PM, Paolo Bonzini wrote: On 08/22/2011 02:04 PM, Stefan Hajnoczi wrote: Please use the block layer instead of reinventing portable file I/O. Also, please check which of the utility functions already exist in QEMU. I

Re: [Qemu-devel] Compilation error of coroutine-win32.c with gcc version 3.4.5 (mingw-vista special r3)

2011-08-23 Thread Roy Tam
2011/8/20 Stefan Weil : > Am 16.08.2011 20:50, schrieb Paolo Bonzini: >> >> On 08/16/2011 05:45 AM, Stefan Hajnoczi wrote: >>> >>> Roy, >>> This stack trace does not reveal much. >>> >>> Is there any MinGW gcc user that has successfully built and run >>> qemu.git? >> >> I would be surprised if Stef

Re: [Qemu-devel] [PATCH 2/2] [RFC] time: refactor QEMU timer to use GHRTimer

2011-08-23 Thread Paolo Bonzini
On 08/22/2011 09:21 PM, Anthony Liguori wrote: -ticks = cpu_get_real_ticks(); -if (timers_state.cpu_ticks_prev > ticks) { -/* Note: non increasing ticks may happen if the host uses - software suspend */ -timers_state.cpu_ticks_offset += timers

Re: [Qemu-devel] [PATCH v2] rbd: allow client id to be specified in config string

2011-08-23 Thread Stefan Hajnoczi
On Mon, Aug 22, 2011 at 02:45:48PM -0700, Sage Weil wrote: > diff --git a/block/rbd.c b/block/rbd.c > index d5659cd..b0cd750 100644 > --- a/block/rbd.c > +++ b/block/rbd.c > @@ -169,6 +169,34 @@ done: > return ret; > } > > +static char *qemu_rbd_parse_clientname(const char *conf, char *clie

Re: [Qemu-devel] Block layer roadmap on wiki

2011-08-23 Thread Stefan Hajnoczi
On Mon, Aug 22, 2011 at 04:01:08PM -0500, Anthony Liguori wrote: > On 08/22/2011 03:48 PM, Ryan Harper wrote: > >* Stefan Hajnoczi [2011-08-22 15:32]: > >>We wouldn't rm -rf block/* because we still need qemu-nbd. It > >>probably makes sense to keep what we have today. I'm talking more > >>about

Re: [Qemu-devel] [PATCH 2/2] [RFC] time: refactor QEMU timer to use GHRTimer

2011-08-23 Thread Paolo Bonzini
On 08/22/2011 10:28 PM, Jan Kiszka wrote: - QEMU_CLOCK_VIRTUAL: Without -icount, same as above, but stops when the guest is stopped. The offset to compensate for stopped times is based on TSC, not sure why. With -icount, things get more complicated, Paolo had some nice explanations

Re: [Qemu-devel] [PATCH 2/2] [RFC] time: refactor QEMU timer to use GHRTimer

2011-08-23 Thread Edgar E. Iglesias
On Tue, Aug 23, 2011 at 10:12:05AM +0200, Paolo Bonzini wrote: > On 08/22/2011 10:28 PM, Jan Kiszka wrote: > > - QEMU_CLOCK_VIRTUAL: Without -icount, same as above, but stops when > > the guest is stopped. The offset to compensate for stopped > > times is based on TSC, not sure why. With

Re: [Qemu-devel] [RFC PATCH v4 2/5] ramlist mutex

2011-08-23 Thread Marcelo Tosatti
On Tue, Aug 23, 2011 at 06:15:33AM -0300, Marcelo Tosatti wrote: > On Tue, Aug 16, 2011 at 11:56:37PM -0400, Umesh Deshpande wrote: > > ramlist mutex is implemented to protect the RAMBlock list traversal in the > > migration thread from their addition/removal from the iothread. > > > > Signed-off-

Re: [Qemu-devel] [RFC PATCH v4 2/5] ramlist mutex

2011-08-23 Thread Marcelo Tosatti
On Tue, Aug 16, 2011 at 11:56:37PM -0400, Umesh Deshpande wrote: > ramlist mutex is implemented to protect the RAMBlock list traversal in the > migration thread from their addition/removal from the iothread. > > Signed-off-by: Umesh Deshpande > --- > cpu-all.h |2 ++ > exec.c|

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

2011-08-23 Thread Marcelo Tosatti
On Mon, Aug 22, 2011 at 12:18:49PM +0300, Avi Kivity wrote: > On 08/17/2011 07:19 AM, Liu, Jinsong wrote: > > From a9670ddff84080c56183e2d678189e100f891174 Mon Sep 17 00:00:00 2001 > >From: Liu, Jinsong > >Date: Wed, 17 Aug 2011 11:36:28 +0800 > >Subject: [PATCH] KVM: emulate lapic tsc deadline tim

Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields

2011-08-23 Thread TeLeMan
On Sun, Aug 21, 2011 at 04:00, Stefan Weil wrote: > Am 15.08.2011 08:39, schrieb Jan Kiszka: >> >> The following changes since commit >> 3b6ffe50300f13240e1b46420ad05da1116df410: >> >> hw/scsi-bus.c: Fix use of uninitialised variable (2011-08-14 19:34:25 >> +) >> >> are available in the git re

Re: [Qemu-devel] [PATCH v2] posix-aio-compat: fix latency issues

2011-08-23 Thread Stefan Hajnoczi
On Mon, Aug 22, 2011 at 6:29 PM, Jan Kiszka wrote: > On 2011-08-14 06:04, Avi Kivity wrote: >> In certain circumstances, posix-aio-compat can incur a lot of latency: >>  - threads are created by vcpu threads, so if vcpu affinity is set, >>    aio threads inherit vcpu affinity.  This can cause many

[Qemu-devel] Execute QEMU "the same"

2011-08-23 Thread Lyu Mitnick
Hello all, I am wondering to know whether QEMU could run "the same" twice. ie. the same of execution trace. I read the user manual and find options like: "-clock dynticks -rtc base=2006-06-17T16:01:21,clock=vm -icount 1". Would QEMU run "the same" with these options?? PS. I also found the functi

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Joerg Roedel
On Mon, Aug 22, 2011 at 08:52:18PM -0400, aafabbri wrote: > You have to enforce group/iommu domain assignment whether you have the > existing uiommu API, or if you change it to your proposed > ioctl(inherit_iommu) API. > > The only change needed to VFIO here should be to make uiommu fd assignment

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Joerg Roedel
On Tue, Aug 23, 2011 at 02:54:43AM -0400, Benjamin Herrenschmidt wrote: > Possibly, the question that interest me the most is what interface will > KVM end up using. I'm also not terribly fan with the (perceived) > discrepancy between using uiommu to create groups but using the group fd > to actual

Re: [Qemu-devel] Block layer roadmap on wiki

2011-08-23 Thread Kevin Wolf
Am 22.08.2011 23:01, schrieb Anthony Liguori: > On 08/22/2011 03:48 PM, Ryan Harper wrote: >> * Stefan Hajnoczi [2011-08-22 15:32]: >>> We wouldn't rm -rf block/* because we still need qemu-nbd. It >>> probably makes sense to keep what we have today. I'm talking more >>> about a shift from writi

Re: [Qemu-devel] [RFC PATCH v4 2/5] ramlist mutex

2011-08-23 Thread Paolo Bonzini
On 08/23/2011 11:17 AM, Marcelo Tosatti wrote: > >typedef struct RAMList { > > +QemuMutex mutex; > >uint8_t *phys_dirty; > >QLIST_HEAD(ram, RAMBlock) blocks; > >QLIST_HEAD(, RAMBlock) blocks_mru; > > A comment on what the mutex protects would be good. Ind

Re: [Qemu-devel] Block layer roadmap on wiki

2011-08-23 Thread Stefan Hajnoczi
On Tue, Aug 23, 2011 at 12:25 PM, Kevin Wolf wrote: > Am 22.08.2011 23:01, schrieb Anthony Liguori: >> On 08/22/2011 03:48 PM, Ryan Harper wrote: >>> * Stefan Hajnoczi  [2011-08-22 15:32]: We wouldn't rm -rf block/* because we still need qemu-nbd.  It probably makes sense to keep what we

Re: [Qemu-devel] [PATCH] sheepdog: use coroutines

2011-08-23 Thread Kevin Wolf
Am 12.08.2011 14:33, schrieb MORITA Kazutaka: > This makes the sheepdog block driver support bdrv_co_readv/writev > instead of bdrv_aio_readv/writev. > > With this patch, Sheepdog network I/O becomes fully asynchronous. The > block driver yields back when send/recv returns EAGAIN, and is resumed

Re: [Qemu-devel] [RFC][PATCH 000/111] QEMU m68k core additions

2011-08-23 Thread Rob Landley
On 08/21/2011 09:15 PM, Natalia Portillo wrote: > Definitively you don't know how a Mac works, you don't want to know > and you don't need to. I do not care about the half of MacOS that Apple burns into ROM which Linux does not use, true. On 08/20/2011 07:23 PM, Natalia Portillo wrote: > >

Re: [Qemu-devel] [PATCH 2/2] [RFC] time: refactor QEMU timer to use GHRTimer

2011-08-23 Thread Anthony Liguori
On 08/23/2011 02:43 AM, Paolo Bonzini wrote: On 08/22/2011 09:21 PM, Anthony Liguori wrote: - ticks = cpu_get_real_ticks(); - if (timers_state.cpu_ticks_prev > ticks) { - /* Note: non increasing ticks may happen if the host uses - software suspend */ - timers_state.cpu_ticks_offset += timers_sta

Re: [Qemu-devel] [PATCH] qed: make qed_alloc_clusters round up offset to nearest cluster

2011-08-23 Thread Kevin Wolf
Am 16.08.2011 01:16, schrieb Devin Nakamura: > Signed-off-by: Devin Nakamura > --- > block/qed.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/block/qed.c b/block/qed.c > index 333f067..9a1e49c 100644 > --- a/block/qed.c > +++ b/block/qed.c > @@ -263,6 +263,8 @@

Re: [Qemu-devel] [RFC PATCH v4 2/5] ramlist mutex

2011-08-23 Thread Marcelo Tosatti
On Tue, Aug 23, 2011 at 01:41:48PM +0200, Paolo Bonzini wrote: > On 08/23/2011 11:17 AM, Marcelo Tosatti wrote: > >typedef struct RAMList { > > +QemuMutex mutex; > >uint8_t *phys_dirty; > >QLIST_HEAD(ram, RAMBlock) blocks; > >QLIST_HEAD

Re: [Qemu-devel] [PATCH v2] posix-aio-compat: fix latency issues

2011-08-23 Thread Anthony Liguori
On 08/23/2011 06:01 AM, Stefan Hajnoczi wrote: On Mon, Aug 22, 2011 at 6:29 PM, Jan Kiszka wrote: On 2011-08-14 06:04, Avi Kivity wrote: In certain circumstances, posix-aio-compat can incur a lot of latency: - threads are created by vcpu threads, so if vcpu affinity is set, aio threads i

Re: [Qemu-devel] [PATCH 2/2] [RFC] time: refactor QEMU timer to use GHRTimer

2011-08-23 Thread Paolo Bonzini
On 08/23/2011 02:33 PM, Anthony Liguori wrote: cpu_get_ticks is used also to emulate the guest TSC, are you sure you want to change that uniformly to a 1 GHz rate? Where possible, CLOCK_MONOTONIC_RAW should be implemented in terms or rdtscp. It will provide the highest accuracy time source tha

[Qemu-devel] [PATCH 4/4] qmp: add query-block-jobs

2011-08-23 Thread Stefan Hajnoczi
This patch introduces the query-block-jobs HMP/QMP command. It is currently unimplemented and returns an empty dict. query-block-jobs Show progress of ongoing block device operations. Return a json-array of all block device operations. If no operation is active then return an

[Qemu-devel] [PATCH 3/4] qmp: add block_job_cancel command

2011-08-23 Thread Stefan Hajnoczi
This patch introduces the block_job_cancel HMP/QMP command. It is currently unimplemented and returns the 'DeviceNotActive' error. block_job_cancel Stop an active block streaming operation. This command returns once the active block streaming operation has been stopped. It is

[Qemu-devel] [PATCH 0/4] Image Streaming API

2011-08-23 Thread Stefan Hajnoczi
These patches put in place the image streaming QMP/HMP commands and documentation. Image streaming itself is not implemented by this patch series but the HMP/QMP commands that libvirt uses are implemented to return NotSupported. The Image Streaming API can be used to copy the contents of a backin

[Qemu-devel] [PATCH 2/4] qmp: add block_job_set_speed command

2011-08-23 Thread Stefan Hajnoczi
This patch introduces the block_job_set_speed HMP/QMP command. It is currently unimplemented and returns the 'NotSupported' error. block_job_set_speed --- Set maximum speed for a background block operation. This command can only be issued when there is an active block job. Thro

[Qemu-devel] [PATCH 1/4] qmp: add block_stream command

2011-08-23 Thread Stefan Hajnoczi
This patch introduces the block_stream HMP/QMP command. It is currently unimplemented and returns the 'NotSupported' error. block_stream Copy data from a backing file into a block device. The block streaming operation is performed in the background until the entire backing file has

Re: [Qemu-devel] [PATCH v2] posix-aio-compat: fix latency issues

2011-08-23 Thread Jan Kiszka
On 2011-08-23 14:40, Anthony Liguori wrote: > On 08/23/2011 06:01 AM, Stefan Hajnoczi wrote: >> On Mon, Aug 22, 2011 at 6:29 PM, Jan Kiszka wrote: >>> On 2011-08-14 06:04, Avi Kivity wrote: In certain circumstances, posix-aio-compat can incur a lot of latency: - threads are created by

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Roedel, Joerg
On Mon, Aug 22, 2011 at 05:03:53PM -0400, Benjamin Herrenschmidt wrote: > > > I am in favour of /dev/vfio/$GROUP. If multiple devices should be > > assigned to a guest, there can also be an ioctl to bind a group to an > > address-space of another group (certainly needs some care to not allow > > t

[Qemu-devel] [PATCH v3 00/15] qcow/qcow2 cleanups

2011-08-23 Thread Frediano Ziglio
These patches mostly cleanup some AIO code using coroutines. Mostly they use stack instead of allocated AIO structure. Feel free to collapse it too short. Frediano Ziglio (15): qcow: allocate QCowAIOCB structure using stack qcow: QCowAIOCB field cleanup qcow: move some blocks of code to avoi

[Qemu-devel] [PATCH v3 01/15] qcow: allocate QCowAIOCB structure using stack

2011-08-23 Thread Frediano Ziglio
instead of calling qemi_aio_get use stack Signed-off-by: Frediano Ziglio --- block/qcow.c | 52 block/qcow2.c | 38 +++--- 2 files changed, 27 insertions(+), 63 deletions(-) diff --git a/block/qcow.c b/blo

[Qemu-devel] [PATCH v3 02/15] qcow: QCowAIOCB field cleanup

2011-08-23 Thread Frediano Ziglio
remove unused field from this structure and put some of them in qcow_aio_read_cb and qcow_aio_write_cb Signed-off-by: Frediano Ziglio --- block/qcow.c | 137 +++-- 1 files changed, 65 insertions(+), 72 deletions(-) diff --git a/block/qcow.c

[Qemu-devel] [PATCH v3 03/15] qcow: move some blocks of code to avoid useless variable initialization

2011-08-23 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow.c | 53 ++--- 1 files changed, 26 insertions(+), 27 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index 9754ca9..4ede7f3 100644 --- a/block/qcow.c +++ b/block/qcow.c @@ -520,35 +520,18 @@ sta

[Qemu-devel] [PATCH v3 05/15] qcow: remove old #undefined code

2011-08-23 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow.c | 63 -- 1 files changed, 0 insertions(+), 63 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index f28c821..8cbabdd 100644 --- a/block/qcow.c +++ b/block/qcow.c @@ -190,24 +190,6 @@

[Qemu-devel] [PATCH v3 12/15] qcow2: removed QCowAIOCB entirely

2011-08-23 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow2.c | 207 ++--- 1 files changed, 80 insertions(+), 127 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 287dd99..d34bd72 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -372,83 +372

[Qemu-devel] [PATCH v3 13/15] qcow2: remove memory leak

2011-08-23 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow2.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index d34bd72..07529b1 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -492,6 +492,7 @@ fail: qemu_co_mutex_unlock(&s->lock); qem

[Qemu-devel] [PATCH v3 14/15] qcow2: small math optimization

2011-08-23 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow2-refcount.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 2a915be..0f9a64a 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refcount.c @@ -140,10 +140,7 @@ stat

[Qemu-devel] [PATCH v3 15/15] qcow2: small optimization

2011-08-23 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow2-refcount.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 0f9a64a..243c24b 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refcount.c @@ -681,14 +681,13

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Roedel, Joerg
On Mon, Aug 22, 2011 at 03:17:00PM -0400, Alex Williamson wrote: > On Mon, 2011-08-22 at 19:25 +0200, Joerg Roedel wrote: > > I am in favour of /dev/vfio/$GROUP. If multiple devices should be > > assigned to a guest, there can also be an ioctl to bind a group to an > > address-space of another gro

[Qemu-devel] [PATCH v3 04/15] qcow: embed qcow_aio_read_cb into qcow_co_readv and qcow_aio_write_cb into qcow_co_writev

2011-08-23 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow.c | 291 - 1 files changed, 123 insertions(+), 168 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index 4ede7f3..f28c821 100644 --- a/block/qcow.c +++ b/block/qcow.c @@ -486,223 +486,17

[Qemu-devel] [PATCH v3 09/15] qcow2: remove cluster_offset from QCowAIOCB

2011-08-23 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow2.c | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 4b9ec29..7e13283 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -378,7 +378,6 @@ typedef struct QCowAIOCB {

[Qemu-devel] [PATCH v3 10/15] qcow2: remove common from QCowAIOCB

2011-08-23 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow2.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 7e13283..519fc8b 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -373,7 +373,7 @@ int qcow2_backing_read1(BlockDriverState *bs, Q

Re: [Qemu-devel] [PATCH v2 00/15] qcow/qcow2 cleanups

2011-08-23 Thread Frediano Ziglio
2011/8/22 Kevin Wolf : > Am 09.08.2011 09:46, schrieb Frediano Ziglio: >> These patches mostly cleanup some AIO code using coroutines. >> Mostly they use stack instead of allocated AIO structure. >> Feel free to collapse it too short. >> >> Frediano Ziglio (15): >>   qcow: allocate QCowAIOCB struct

Re: [Qemu-devel] [PATCH v2] posix-aio-compat: fix latency issues

2011-08-23 Thread Anthony Liguori
On 08/23/2011 08:02 AM, Jan Kiszka wrote: On 2011-08-23 14:40, Anthony Liguori wrote: You should be able to just use an eventfd or pipe. Better yet, we should look at using GThreadPool to replace posix-aio-compat. When interacting with the thread pool is part of some time-critical path (easil

[Qemu-devel] [PATCH v3 06/15] qcow2: removed unused fields

2011-08-23 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow2.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index bb6c75e..4171b47 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -381,11 +381,8 @@ typedef struct QCowAIOCB { uint64_t byt

[Qemu-devel] [PATCH v3 07/15] qcow2: removed cur_nr_sectors field in QCowAIOCB

2011-08-23 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow2.c | 98 + 1 files changed, 43 insertions(+), 55 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 4171b47..f920dbe 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -377,7 +377,6

[Qemu-devel] [PATCH v3 11/15] qcow2: reindent and use while before the big jump

2011-08-23 Thread Frediano Ziglio
prepare to remove read/write callbacks Signed-off-by: Frediano Ziglio --- block/qcow2.c | 272 - 1 files changed, 135 insertions(+), 137 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 519fc8b..287dd99 100644 --- a/block/qco

[Qemu-devel] [PATCH v3 08/15] qcow2: remove l2meta from QCowAIOCB

2011-08-23 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow2.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index f920dbe..4b9ec29 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -381,7 +381,6 @@ typedef struct QCowAIOCB { uint64_t

Re: [Qemu-devel] [PATCH v2] posix-aio-compat: fix latency issues

2011-08-23 Thread Jan Kiszka
On 2011-08-23 16:02, Anthony Liguori wrote: > On 08/23/2011 08:02 AM, Jan Kiszka wrote: >> On 2011-08-23 14:40, Anthony Liguori wrote: >>> You should be able to just use an eventfd or pipe. >>> >>> Better yet, we should look at using GThreadPool to replace posix-aio-compat. >> >> When interacting w

Re: [Qemu-devel] [libvirt] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Corey Bryant
On 08/22/2011 03:25 PM, Anthony Liguori wrote: On 08/22/2011 01:22 PM, Daniel P. Berrange wrote: On Mon, Aug 22, 2011 at 12:25:25PM -0500, Anthony Liguori wrote: On 08/22/2011 11:50 AM, Daniel P. Berrange wrote: On Mon, Aug 22, 2011 at 11:29:12AM -0500, Anthony Liguori wrote: I don't think it

Re: [Qemu-devel] [libvirt] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Anthony Liguori
On 08/23/2011 09:26 AM, Corey Bryant wrote: On 08/22/2011 03:25 PM, Anthony Liguori wrote: On 08/22/2011 01:22 PM, Daniel P. Berrange wrote: On Mon, Aug 22, 2011 at 12:25:25PM -0500, Anthony Liguori wrote: On 08/22/2011 11:50 AM, Daniel P. Berrange wrote: On Mon, Aug 22, 2011 at 11:29:12AM -0

Re: [Qemu-devel] Grand Unified Tracing

2011-08-23 Thread Blue Swirl
On Tue, Aug 23, 2011 at 5:35 AM, Stefan Hajnoczi wrote: > On Mon, Aug 22, 2011 at 9:59 PM, Blue Swirl wrote: >> On Mon, Aug 22, 2011 at 8:23 PM, Stefan Hajnoczi wrote: >>> On Mon, Aug 22, 2011 at 7:14 PM, Blue Swirl wrote: OpenBIOS uses traditional DPRINTFs for debugging. I was considering

Re: [Qemu-devel] Grand Unified Tracing

2011-08-23 Thread Stefan Hajnoczi
On Tue, Aug 23, 2011 at 3:34 PM, Blue Swirl wrote: > On Tue, Aug 23, 2011 at 5:35 AM, Stefan Hajnoczi wrote: >> On Mon, Aug 22, 2011 at 9:59 PM, Blue Swirl wrote: >>> On Mon, Aug 22, 2011 at 8:23 PM, Stefan Hajnoczi wrote: On Mon, Aug 22, 2011 at 7:14 PM, Blue Swirl wrote: > OpenBIOS

[Qemu-devel] MPC5200 + BestComm support in QEMU

2011-08-23 Thread steve . belanger
Hi, I'm Steve, an embedded software developper for Bombardier Transportation Canada. We use the MPC5200 for most of our onboard computers inside train control systems. To enhance our SW engineering process, we would like the emulate the MPC5200 processor using QEMU, an open source software CPU

Re: [Qemu-devel] Grand Unified Tracing

2011-08-23 Thread Blue Swirl
On Tue, Aug 23, 2011 at 2:45 PM, Stefan Hajnoczi wrote: > On Tue, Aug 23, 2011 at 3:34 PM, Blue Swirl wrote: >> On Tue, Aug 23, 2011 at 5:35 AM, Stefan Hajnoczi wrote: >>> On Mon, Aug 22, 2011 at 9:59 PM, Blue Swirl wrote: On Mon, Aug 22, 2011 at 8:23 PM, Stefan Hajnoczi wrote:

Re: [Qemu-devel] RFCv2: virDomainSnapshotCreateXML enhancements

2011-08-23 Thread Stefan Hajnoczi
On Tue, Aug 23, 2011 at 2:40 PM, Eric Blake wrote: > On 08/23/2011 03:52 AM, Stefan Hajnoczi wrote: >> >> On Wed, Aug 10, 2011 at 11:08 PM, Eric Blake  wrote: >>> >>> disk snapshot: the state of a virtual disk used at a given time; once a >>> snapshot exists, then it is possible to track a delta o

Re: [Qemu-devel] [libvirt] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Corey Bryant
On 08/22/2011 02:39 PM, Blue Swirl wrote: On Mon, Aug 22, 2011 at 5:42 PM, Corey Bryant wrote: > > > On 08/22/2011 01:25 PM, Anthony Liguori wrote: >> >> On 08/22/2011 11:50 AM, Daniel P. Berrange wrote: >>> >>> On Mon, Aug 22, 2011 at 11:29:12AM -0500, Anthony Liguori wrote:

Re: [Qemu-devel] [libvirt] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Daniel P. Berrange
On Tue, Aug 23, 2011 at 11:13:34AM -0400, Corey Bryant wrote: > > > On 08/22/2011 02:39 PM, Blue Swirl wrote: > >On Mon, Aug 22, 2011 at 5:42 PM, Corey Bryant > >wrote: > >>> > >>> > >>> On 08/22/2011 01:25 PM, Anthony Liguori wrote: > > > > On 08/22/2011 11:50 AM, Daniel P. Berrange

Re: [Qemu-devel] [PATCH v3 14/15] qcow2: small math optimization

2011-08-23 Thread Kevin Wolf
Am 23.08.2011 15:21, schrieb Frediano Ziglio: > Signed-off-by: Frediano Ziglio > --- > block/qcow2-refcount.c |5 + > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c > index 2a915be..0f9a64a 100644 > --- a/block/qcow2-refc

Re: [Qemu-devel] [PATCH v3 15/15] qcow2: small optimization

2011-08-23 Thread Kevin Wolf
Am 23.08.2011 15:21, schrieb Frediano Ziglio: > Signed-off-by: Frediano Ziglio > --- > block/qcow2-refcount.c | 11 +-- > 1 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c > index 0f9a64a..243c24b 100644 > --- a/block/qcow

Re: [Qemu-devel] [PATCH v3 00/15] qcow/qcow2 cleanups

2011-08-23 Thread Kevin Wolf
Am 23.08.2011 15:21, schrieb Frediano Ziglio: > These patches mostly cleanup some AIO code using coroutines. > Mostly they use stack instead of allocated AIO structure. > Feel free to collapse it too short. > > Frediano Ziglio (15): > qcow: allocate QCowAIOCB structure using stack > qcow: QCow

Re: [Qemu-devel] [libvirt] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Kevin Wolf
Am 23.08.2011 17:26, schrieb Daniel P. Berrange: > On Tue, Aug 23, 2011 at 11:13:34AM -0400, Corey Bryant wrote: >> >> >> On 08/22/2011 02:39 PM, Blue Swirl wrote: >>> On Mon, Aug 22, 2011 at 5:42 PM, Corey Bryant >>> wrote: > > > On 08/22/2011 01:25 PM, Anthony Liguori wrote: >>

Re: [Qemu-devel] [PATCH 2/2] [FYI] coverage test for Linux installs

2011-08-23 Thread Ryan Harper
* Anthony Liguori [2011-08-08 14:33]: > This is a simple tool that I've been using for the past couple months to help > with day-to-day testing of changes. It may seem like it's similar to > kvm-autotest but it's actually quite different. Most noticably: > > - It's a coverage test instead of a

Re: [Qemu-devel] [libvirt] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Daniel P. Berrange
On Tue, Aug 23, 2011 at 05:50:03PM +0200, Kevin Wolf wrote: > Am 23.08.2011 17:26, schrieb Daniel P. Berrange: > > On Tue, Aug 23, 2011 at 11:13:34AM -0400, Corey Bryant wrote: > >> > >> > >> On 08/22/2011 02:39 PM, Blue Swirl wrote: > >>> On Mon, Aug 22, 2011 at 5:42 PM, Corey Bryant > >>> wrote

Re: [Qemu-devel] [libvirt] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Daniel P. Berrange
On Tue, Aug 23, 2011 at 04:51:31PM +0100, Daniel P. Berrange wrote: > On Tue, Aug 23, 2011 at 05:50:03PM +0200, Kevin Wolf wrote: > > Am 23.08.2011 17:26, schrieb Daniel P. Berrange: > > > On Tue, Aug 23, 2011 at 11:13:34AM -0400, Corey Bryant wrote: > > >> > > >> > > >> On 08/22/2011 02:39 PM, Blu

Re: [Qemu-devel] [PATCH 2/2] Added target to build libvdisk

2011-08-23 Thread Daniel P. Berrange
On Mon, Aug 22, 2011 at 02:29:00PM -0500, Anthony Liguori wrote: > On 08/22/2011 12:06 PM, Saggi Mizrahi wrote: > >libvdisk is a library that packages qemu's handling of disk images. This > >allows for other programs to link to it and get access to qemu image > >file abstractions. > > > >To use ins

Re: [Qemu-devel] [PATCH 2/2] Added target to build libvdisk

2011-08-23 Thread Anthony Liguori
On 08/23/2011 11:12 AM, Daniel P. Berrange wrote: On Mon, Aug 22, 2011 at 02:29:00PM -0500, Anthony Liguori wrote: On 08/22/2011 12:06 PM, Saggi Mizrahi wrote: libvdisk is a library that packages qemu's handling of disk images. This allows for other programs to link to it and get access to qemu

Re: [Qemu-devel] [libvirt] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Corey Bryant
On 08/23/2011 11:50 AM, Kevin Wolf wrote: Am 23.08.2011 17:26, schrieb Daniel P. Berrange: > On Tue, Aug 23, 2011 at 11:13:34AM -0400, Corey Bryant wrote: >> >> >> On 08/22/2011 02:39 PM, Blue Swirl wrote: >>> On Mon, Aug 22, 2011 at 5:42 PM, Corey Bryant wrote: > > >On

Re: [Qemu-devel] [PATCH 2/2] Added target to build libvdisk

2011-08-23 Thread Daniel P. Berrange
On Tue, Aug 23, 2011 at 11:14:20AM -0500, Anthony Liguori wrote: > On 08/23/2011 11:12 AM, Daniel P. Berrange wrote: > >$(block-obj-y) pulls in 'aio.o' which is built from aio.c which > >is licensed "GPLv2 only". So even those many files are BSD > >licenses, the combined work will be GPLv2-only.

Re: [Qemu-devel] [PATCH 2/2] Added target to build libvdisk

2011-08-23 Thread Anthony Liguori
On 08/23/2011 11:18 AM, Daniel P. Berrange wrote: On Tue, Aug 23, 2011 at 11:14:20AM -0500, Anthony Liguori wrote: On 08/23/2011 11:12 AM, Daniel P. Berrange wrote: $(block-obj-y) pulls in 'aio.o' which is built from aio.c which is licensed "GPLv2 only". So even those many files are BSD licen

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Alex Williamson
On Tue, 2011-08-23 at 12:38 +1000, David Gibson wrote: > On Mon, Aug 22, 2011 at 09:45:48AM -0600, Alex Williamson wrote: > > On Mon, 2011-08-22 at 15:55 +1000, David Gibson wrote: > > > On Sat, Aug 20, 2011 at 09:51:39AM -0700, Alex Williamson wrote: > > > > We had an extremely productive VFIO BoF

Re: [Qemu-devel] [PATCH 4/4] qmp: add query-block-jobs

2011-08-23 Thread Adam Litke
On Tue, 2011-08-23 at 13:58 +0100, Stefan Hajnoczi wrote: > diff --git a/blockdev.c b/blockdev.c > index 036b7eb..e9098f6 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -835,3 +835,13 @@ int do_block_job_cancel(Monitor *mon, const QDict > *params, QObject **ret_data) > qerror_report(QERR_D

[Qemu-devel] [PATCH 2/3] rbd: allow client id to be specified in config string

2011-08-23 Thread Sage Weil
Allow the client id to be specified in the config string via 'id=' so that users can control who they authenticate as. Currently they are stuck with the default ('admin'). This is necessary for anyone using authentication in their environment. Signed-off-by: Sage Weil --- block/rbd.c | 52 ++

[Qemu-devel] [PATCH 3/3] rbd: clean up, fix style

2011-08-23 Thread Sage Weil
No assignment in condition. Remove duplicate ret > 0 check. Signed-off-by: Sage Weil --- block/rbd.c | 17 - 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index e239e04..5423a2d 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -391,15 +3

[Qemu-devel] [PATCH 1/3] rbd: fix leak in failure path

2011-08-23 Thread Sage Weil
Fix leak of s->snap when rados_create fails. Reported-by: Stefan Hajnoczi Signed-off-by: Sage Weil --- block/rbd.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index d5659cd..52b79fa 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -393

Re: [Qemu-devel] [PATCH 1/4] qmp: add block_stream command

2011-08-23 Thread Adam Litke
Under libvirt, I get the following error when trying to start a block stream: qerror: bad call in function 'do_block_stream': qerror: -> error format '{ 'class': 'NotSupported', 'data': {} }' not found qerror: call at blockdev.c:808 2011-08-23 11:30:09.974: shutting down Is this patch missing a p

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-23 Thread aafabbri
On 8/23/11 4:04 AM, "Joerg Roedel" wrote: > On Mon, Aug 22, 2011 at 08:52:18PM -0400, aafabbri wrote: >> You have to enforce group/iommu domain assignment whether you have the >> existing uiommu API, or if you change it to your proposed >> ioctl(inherit_iommu) API. >> >> The only change neede

Re: [Qemu-devel] [PATCH 0/3] PPC: E500: Support SPE guest

2011-08-23 Thread Jason Wessel
On 08/22/2011 11:55 PM, Alexander Graf wrote: > When I bumped into Jason on Linuxcon, we tried out to run the e500 target > on his Windriver build that used SPE and immediately ran into emulation > issues. Fortunately there weren't too many, so here are the patches to get > a guest using SPE instru

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Alex Williamson
On Tue, 2011-08-23 at 16:54 +1000, Benjamin Herrenschmidt wrote: > On Mon, 2011-08-22 at 17:52 -0700, aafabbri wrote: > > > I'm not following you. > > > > You have to enforce group/iommu domain assignment whether you have the > > existing uiommu API, or if you change it to your proposed > > ioctl

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Alex Williamson
On Tue, 2011-08-23 at 15:14 +0200, Roedel, Joerg wrote: > On Mon, Aug 22, 2011 at 03:17:00PM -0400, Alex Williamson wrote: > > On Mon, 2011-08-22 at 19:25 +0200, Joerg Roedel wrote: > > > > I am in favour of /dev/vfio/$GROUP. If multiple devices should be > > > assigned to a guest, there can also

Re: [Qemu-devel] [PATCH 2/6] tcg: Always define all of the TCGOpcode enum members.

2011-08-23 Thread Peter Maydell
On 17 August 2011 22:11, Richard Henderson wrote: > By always defining these symbols, we can eliminate a lot of ifdefs. > > To allow this to be checked reliably, the semantics of the > TCG_TARGET_HAS_* macros must be changed from def/undef to true/false. > This allows even more ifdefs to be remove

Re: [Qemu-devel] [PATCH] sheepdog: use coroutines

2011-08-23 Thread MORITA Kazutaka
At Tue, 23 Aug 2011 14:29:50 +0200, Kevin Wolf wrote: > > Am 12.08.2011 14:33, schrieb MORITA Kazutaka: > > This makes the sheepdog block driver support bdrv_co_readv/writev > > instead of bdrv_aio_readv/writev. > > > > With this patch, Sheepdog network I/O becomes fully asynchronous. The > > bl

Re: [Qemu-devel] [PATCH 2/6] tcg: Always define all of the TCGOpcode enum members.

2011-08-23 Thread Richard Henderson
On 08/23/2011 10:11 AM, Peter Maydell wrote: > A compile-time check that the tcg target has #defined all the > TCG_TARGET_HAS_foo to 0/1 and not left any undefined might be > useful? That compile-time check is the uses in tcg-op.h. If they're not defined you'll get undefined symbol errors in that

[Qemu-devel] Nous sommes là pour

2011-08-23 Thread Prod6
  Nous sommes là pour vous faire bénéficier d’une étude GRATUITE et sans engagement de votre part pour l’installation de :   • Climatisation réversible, • Chauffe-eau solaire • Energie solaire pour chauffer votre piscine • Isolation thermique des combles • Adoucisseur d’eau • L’é

[Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-23 Thread Jan Kiszka
From: Alex Williamson Nothing good can happen when we overlap capabilities [ Jan: rebased over qemu, minor formatting ] Signed-off-by: Jan Kiszka --- hw/pci.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 6124790..ff20631 1006

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Aaron Fabbri
On 8/23/11 10:01 AM, "Alex Williamson" wrote: > On Tue, 2011-08-23 at 16:54 +1000, Benjamin Herrenschmidt wrote: >> On Mon, 2011-08-22 at 17:52 -0700, aafabbri wrote: >> >>> I'm not following you. >>> >>> You have to enforce group/iommu domain assignment whether you have the >>> existing uio

[Qemu-devel] [PATCH] tcg: Update --enable-debug for TCG_OPF_NOT_PRESENT.

2011-08-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tcg.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 06ce214..411f971 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -1128,18 +1128,19 @@ void tcg_add_target_add_op_defs(const TCGTargetOpDef *

[Qemu-devel] PPC* and Sparc32 crash

2011-08-23 Thread Blue Swirl
qemu-system-ppc: /src/qemu/memory.c:1183: memory_region_add_subregion_common: Assertion `!subregion->parent' failed. Aborted qemu-system-ppc64: /src/qemu/memory.c:1183: memory_region_add_subregion_common: Assertion `!subregion->parent' failed. Aborted qemu-system-sparc: /src/qemu/hw/sysbus.c:156: s

Re: [Qemu-devel] PPC* and Sparc32 crash

2011-08-23 Thread Peter Maydell
On 23 August 2011 18:55, Blue Swirl wrote: > qemu-system-ppc: /src/qemu/memory.c:1183: > memory_region_add_subregion_common: Assertion `!subregion->parent' > failed. > Aborted > qemu-system-ppc64: /src/qemu/memory.c:1183: > memory_region_add_subregion_common: Assertion `!subregion->parent' > faile

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Alex Williamson
On Tue, 2011-08-23 at 10:33 -0700, Aaron Fabbri wrote: > > > On 8/23/11 10:01 AM, "Alex Williamson" wrote: > > > On Tue, 2011-08-23 at 16:54 +1000, Benjamin Herrenschmidt wrote: > >> On Mon, 2011-08-22 at 17:52 -0700, aafabbri wrote: > >> > >>> I'm not following you. > >>> > >>> You have to e

[Qemu-devel] [Bug 821078] Re: virtio-serial-bus: Unexpected port id

2011-08-23 Thread Rick Vernam
Using qemu-kvm-0.15.0 for a few weeks now, I'd like to report that maybe 1/10 times it works as expected: ie, there is no virtio-serial-bus error, vdagent in the windows guest starts, etc. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEM

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-23 Thread Michael S. Tsirkin
On Tue, Aug 23, 2011 at 07:28:08PM +0200, Jan Kiszka wrote: > From: Alex Williamson > > Nothing good can happen when we overlap capabilities > > [ Jan: rebased over qemu, minor formatting ] > > Signed-off-by: Jan Kiszka I'll stick an assert there instead. Normal devices don't generate overlap

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-23 Thread Alex Williamson
On Tue, 2011-08-23 at 21:17 +0300, Michael S. Tsirkin wrote: > On Tue, Aug 23, 2011 at 07:28:08PM +0200, Jan Kiszka wrote: > > From: Alex Williamson > > > > Nothing good can happen when we overlap capabilities > > > > [ Jan: rebased over qemu, minor formatting ] > > > > Signed-off-by: Jan Kiszk

[Qemu-devel] [PATCH] hw/omap_gpmc: Don't try to map CS0 twice on reset

2011-08-23 Thread Peter Maydell
Remove a spurious second map of the OMAP GPMC CS0 region on reset. This fixes an assertion failure when we try to add the region to its container when it was already added. (The old code did not complain about mismatched map/unmap calls, but the new MemoryRegion implementation does.) Signed-off-by

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-23 Thread Michael S. Tsirkin
On Tue, Aug 23, 2011 at 12:21:47PM -0600, Alex Williamson wrote: > On Tue, 2011-08-23 at 21:17 +0300, Michael S. Tsirkin wrote: > > On Tue, Aug 23, 2011 at 07:28:08PM +0200, Jan Kiszka wrote: > > > From: Alex Williamson > > > > > > Nothing good can happen when we overlap capabilities > > > > > >

Re: [Qemu-devel] [PATCH] tcg: Update --enable-debug for TCG_OPF_NOT_PRESENT.

2011-08-23 Thread Peter Maydell
On 23 August 2011 18:43, Richard Henderson wrote: > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Confirmed that this fixes the assertion on x86-64 host. -- PMM

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-23 Thread Alex Williamson
On Tue, 2011-08-23 at 21:26 +0300, Michael S. Tsirkin wrote: > On Tue, Aug 23, 2011 at 12:21:47PM -0600, Alex Williamson wrote: > > On Tue, 2011-08-23 at 21:17 +0300, Michael S. Tsirkin wrote: > > > On Tue, Aug 23, 2011 at 07:28:08PM +0200, Jan Kiszka wrote: > > > > From: Alex Williamson > > > >

  1   2   >