On 17 August 2011 22:11, Richard Henderson <r...@twiddle.net> wrote: > By always defining these symbols, we can eliminate a lot of ifdefs. > > To allow this to be checked reliably, the semantics of the > TCG_TARGET_HAS_* macros must be changed from def/undef to true/false. > This allows even more ifdefs to be removed, converting them into > C if statements.
This breaks x86-64 hosts if built with --enable-debug: petmay01@LinaroE102767:~/git/qemu$ ./arm-softmmu/qemu-system-arm Missing op definition for div_i32 Missing op definition for divu_i32 Missing op definition for rem_i32 Missing op definition for remu_i32 Missing op definition for deposit_i32 Missing op definition for add2_i32 Missing op definition for sub2_i32 Missing op definition for brcond2_i32 Missing op definition for mulu2_i32 Missing op definition for setcond2_i32 Missing op definition for andc_i32 Missing op definition for orc_i32 Missing op definition for eqv_i32 Missing op definition for nand_i32 Missing op definition for nor_i32 Missing op definition for div_i64 Missing op definition for divu_i64 Missing op definition for rem_i64 Missing op definition for remu_i64 Missing op definition for deposit_i64 Missing op definition for andc_i64 Missing op definition for orc_i64 Missing op definition for eqv_i64 Missing op definition for nand_i64 Missing op definition for nor_i64 /home/petmay01/git/qemu/tcg/tcg.c:1148: tcg fatal error Aborted A compile-time check that the tcg target has #defined all the TCG_TARGET_HAS_foo to 0/1 and not left any undefined might be useful? [thanks to mmu_man on irc for the report.] -- PMM
