Re: [Qemu-devel] [RFC] Introduce vm_stop_permanent()

2011-07-28 Thread Avi Kivity
On 07/28/2011 12:44 AM, Blue Swirl wrote: On Wed, Jul 27, 2011 at 9:42 PM, Luiz Capitulino wrote: > This function should be used when the VM is not supposed to resume > execution (eg. by issuing 'cont' monitor command). > > Today, we allow the user to resume execution even when: > >o the

Re: [Qemu-devel] [PATCH v2] pci: Common overflow prevention

2011-07-28 Thread Isaku Yamahata
This might be a bit late comment... On Fri, Jul 22, 2011 at 11:05:01AM +0200, Jan Kiszka wrote: > diff --git a/hw/pci_host.c b/hw/pci_host.c > index 728e2d4..bfdc321 100644 > --- a/hw/pci_host.c > +++ b/hw/pci_host.c > @@ -47,17 +47,33 @@ static inline PCIDevice *pci_dev_find_by_addr(PCIBus > *bu

Re: [Qemu-devel] [PATCH v2 3/5] balloon: Ignore negative balloon values

2011-07-28 Thread Markus Armbruster
Amit Shah writes: > Negative balloon values don't make sense, ignore them. Actually, they aren't ignored, they're rejected.

Re: [Qemu-devel] [PATCH v2 4/5] virtio-balloon: Add exit handler, fix memleaks

2011-07-28 Thread Markus Armbruster
Amit Shah writes: > Add an exit handler that will free up RAM and unregister the savevm > section after a virtio-balloon device is unplugged. > > Signed-off-by: Amit Shah > --- > hw/virtio-balloon.c |5 + > hw/virtio-pci.c | 11 ++- > hw/virtio.h |1 + > 3 file

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-28 Thread Paolo Bonzini
On 07/27/2011 10:01 PM, Anthony Liguori wrote: That's milkymist, not GoldFish. Oh, Goldfish is fake. It's not real hardware. The enumerator device is not a real device. It's weird because it's imaginary and was designed specifically within QEMU. It's not a good example for discussing mode

Re: [Qemu-devel] [PATCH v2 4/5] virtio-balloon: Add exit handler, fix memleaks

2011-07-28 Thread Markus Armbruster
Amit Shah writes: > On (Thu) 28 Jul 2011 [11:47:15], Amit Shah wrote: >> Add an exit handler that will free up RAM and unregister the savevm >> section after a virtio-balloon device is unplugged. > > This commit message should be changed; I'll do that in the pull > request I send out. You mean d

[Qemu-devel] [PATCH 0/8] qcow2 cleanup for coroutine-block branch

2011-07-28 Thread Frediano Ziglio
This is a collection of patches that remove QCowAIOCB, useless with coroutines. It apply to Kevin coroutine-block branch. I leave all step I did to remove the structure, feel free to collapse some of them. I tested with iotests and got no changes (026 fails like coroutine-block branch). Frediano Z

[Qemu-devel] [PATCH 1/8] qcow2: removed unused fields

2011-07-28 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow2.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index edc068e..5c454bb 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -381,11 +381,8 @@ typedef struct QCowAIOCB { uint64_t byt

[Qemu-devel] [PATCH 2/8] qcow2: removed cur_nr_sectors field in QCowAIOCB

2011-07-28 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow2.c | 98 + 1 files changed, 43 insertions(+), 55 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 5c454bb..0cf4465 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -377,7 +377,6

[Qemu-devel] [PATCH 3/8] qcow2: remove l2meta from QCowAIOCB

2011-07-28 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow2.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 0cf4465..adf31ce 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -381,7 +381,6 @@ typedef struct QCowAIOCB { uint64_t

[Qemu-devel] [PATCH 8/8] qcow2: remove memory leak

2011-07-28 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow2.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 6073568..aed8da7 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -492,6 +492,7 @@ fail: qemu_co_mutex_unlock(&s->lock); qem

Re: [Qemu-devel] [PATCH 1/2] linux aio: support flush operation

2011-07-28 Thread Kevin Wolf
Am 27.07.2011 21:57, schrieb Christoph Hellwig: > On Wed, Jul 27, 2011 at 09:52:51PM +0200, Frediano Ziglio wrote: >> Also I notice that combining XFS, Linux AIO, O_DIRECT and O_DSYNC give >> impressive performance but currently there is no way to specify all that >> flags together cause nocache

Re: [Qemu-devel] [PATCH v2 5/5] virtio-balloon: Unregister savevm section on device unplug

2011-07-28 Thread Markus Armbruster
Amit Shah writes: > Migrating after unplugging a virtio-balloon device resulted in an error > message on the destination: > > Unknown savevm section or instance ':00:04.0/virtio-balloon' 0 > load of migration failed > > Fix this by unregistering the section on device unplug. > > Signed-off-by

Re: [Qemu-devel] [PATCH v2 0/5] balloon: fix memleaks, invalid arguments, unplug

2011-07-28 Thread Markus Armbruster
Amit Shah writes: > Hello, > > This series is on top of the other balloon series for which I sent a > pull request on Tuesday. > > This series fixes memleak on exit, unregisters the savevm section on > unplug, disallows negative values as ballooning targets and doesn't > allow multiple balloon de

[Qemu-devel] [PATCH 7/8] qcow2: removed QCowAIOCB entirely

2011-07-28 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow2.c | 207 ++--- 1 files changed, 80 insertions(+), 127 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index dfb969e..6073568 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -372,83 +372

[Qemu-devel] [PATCH 4/8] qcow2: remove cluster_offset from QCowAIOCB

2011-07-28 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow2.c | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index adf31ce..446946e 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -378,7 +378,6 @@ typedef struct QCowAIOCB {

Re: [Qemu-devel] RFC: moving fsfreeze support from the userland guest agent to the guest kernel

2011-07-28 Thread Andrea Arcangeli
On Thu, Jul 28, 2011 at 11:53:50AM +0900, Fernando Luis Vázquez Cao wrote: > On Wed, 2011-07-27 at 17:24 +0200, Andrea Arcangeli wrote: > > making > > sure no lib is calling any I/O function to be able to defreeze the > > filesystems later, making sure the oom killer or a wrong kill -9 > > $RANDOM

[Qemu-devel] Volume key in qcow3?

2011-07-28 Thread Frediano Ziglio
Hi, I noted that AES encryption using qcow2 just use the password given as as key (and also truncating it to 16 bytes == 128 bits). This is prone to brute force attacks and is not also easy to change password (you have to decrypt and encrypt again the entire image). LUKS and EncFS use another way

Re: [Qemu-devel] [PATCH 00/55] Block layer cleanup & fixes

2011-07-28 Thread Kevin Wolf
Am 20.07.2011 18:23, schrieb Markus Armbruster: > This patch series looks bigger than it is. All the patches are small > and hopefully easy to review. > > Objectives: > > * Push BlockDriverState members locked, tray_open, media_changed into > device models, where they belong. > > * BlockDrive

[Qemu-devel] [PATCH 5/8] qcow2: remove common from QCowAIOCB

2011-07-28 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow2.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 446946e..c7445cc 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -373,7 +373,7 @@ int qcow2_backing_read1(BlockDriverState *bs, Q

Re: [Qemu-devel] [PATCH v5] Add support for Zipit Z2 machine

2011-07-28 Thread Vasily Khoruzhick
On Monday 11 July 2011 18:26:37 Vasily Khoruzhick wrote: > On Wednesday 06 July 2011 16:52:49 Vasily Khoruzhick wrote: > > Zipit Z2 is small PXA270 based handheld. > > Ping? One more ping.

Re: [Qemu-devel] [PATCH v2 1/1] The codes V2 for QEMU disk I/O limits.

2011-07-28 Thread Stefan Hajnoczi
On Thu, Jul 28, 2011 at 6:43 AM, Zhi Yong Wu wrote: > On Wed, Jul 27, 2011 at 8:58 PM, Stefan Hajnoczi wrote: >> On Wed, Jul 27, 2011 at 11:17 AM, Zhi Yong Wu wrote: >>> On Wed, Jul 27, 2011 at 3:26 AM, Marcelo Tosatti >>> wrote: On Tue, Jul 26, 2011 at 04:59:06PM +0800, Zhi Yong Wu wrote

[Qemu-devel] [PATCH 6/8] qcow2: reindent and use while before the big jump

2011-07-28 Thread Frediano Ziglio
prepare to remove read/write callbacks Signed-off-by: Frediano Ziglio --- block/qcow2.c | 272 - 1 files changed, 135 insertions(+), 137 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index c7445cc..dfb969e 100644 --- a/block/qco

Re: [Qemu-devel] [PATCH v2 1/1] The codes V2 for QEMU disk I/O limits.

2011-07-28 Thread Stefan Hajnoczi
On Thu, Jul 28, 2011 at 9:20 AM, Stefan Hajnoczi wrote: > On Thu, Jul 28, 2011 at 6:43 AM, Zhi Yong Wu wrote: >> On Wed, Jul 27, 2011 at 8:58 PM, Stefan Hajnoczi wrote: >>> On Wed, Jul 27, 2011 at 11:17 AM, Zhi Yong Wu wrote: On Wed, Jul 27, 2011 at 3:26 AM, Marcelo Tosatti wrote: >

Re: [Qemu-devel] [PATCH v2] pci: Common overflow prevention

2011-07-28 Thread Michael S. Tsirkin
On Thu, Jul 28, 2011 at 04:23:24PM +0900, Isaku Yamahata wrote: > This might be a bit late comment... > > On Fri, Jul 22, 2011 at 11:05:01AM +0200, Jan Kiszka wrote: > > diff --git a/hw/pci_host.c b/hw/pci_host.c > > index 728e2d4..bfdc321 100644 > > --- a/hw/pci_host.c > > +++ b/hw/pci_host.c > >

Re: [Qemu-devel] [PATCH] add QEMU_LD_PREFIX environment variable

2011-07-28 Thread Riku Voipio
On Sat, Jul 23, 2011 at 07:47:49AM +0200, josch wrote: > This could be avoided by setting the proposed environment variable > QEMU_LD_PREFIX to the just > created debian rootfs. As mentioned earlier, the usage of the -L option > is not possible in this scenario because qemu-user is only implicitly

Re: [Qemu-devel] [PATCH v2 0/5] balloon: fix memleaks, invalid arguments, unplug

2011-07-28 Thread Michael S. Tsirkin
On Thu, Jul 28, 2011 at 11:47:11AM +0530, Amit Shah wrote: > Hello, > > This series is on top of the other balloon series for which I sent a > pull request on Tuesday. > > This series fixes memleak on exit, unregisters the savevm section on > unplug, disallows negative values as ballooning target

Re: [Qemu-devel] [PATCH v2 1/1] The codes V2 for QEMU disk I/O limits.

2011-07-28 Thread Zhi Yong Wu
On Thu, Jul 28, 2011 at 4:25 PM, Stefan Hajnoczi wrote: > On Thu, Jul 28, 2011 at 9:20 AM, Stefan Hajnoczi wrote: >> On Thu, Jul 28, 2011 at 6:43 AM, Zhi Yong Wu wrote: >>> On Wed, Jul 27, 2011 at 8:58 PM, Stefan Hajnoczi wrote: On Wed, Jul 27, 2011 at 11:17 AM, Zhi Yong Wu wrote: > O

Re: [Qemu-devel] RFC: moving fsfreeze support from the userland guest agent to the guest kernel

2011-07-28 Thread Jes Sorensen
On 07/27/11 18:40, Andrea Arcangeli wrote: >> Another thing to note is that snapshotting is not necessarily something >> > that should be completely transparent to the guest. One of the planned >> > future features for the guest agent (mentioned in the snapshot wiki, and >> > a common use case t

Re: [Qemu-devel] RFC: moving fsfreeze support from the userland guest agent to the guest kernel

2011-07-28 Thread Jes Sorensen
On 07/27/11 20:36, Christoph Hellwig wrote: > Initiating the freeze from kernelspace doesn't make much sense. With > virtio we could add in-band freeze request to the protocol, and although > that would be a major change in that way virtio-blk works right now it's > at least doable. But all other

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for dynamic block params change

2011-07-28 Thread Stefan Hajnoczi
On Wed, Jul 27, 2011 at 5:02 PM, Anthony Liguori wrote: > On 07/27/2011 09:31 AM, Stefan Hajnoczi wrote: >> >> On Wed, Jul 27, 2011 at 1:58 PM, Anthony Liguori >>  wrote: Index: qemu/hmp-commands.hx === --- qemu.or

Re: [Qemu-devel] [PATCH 00/55] Block layer cleanup & fixes

2011-07-28 Thread Amit Shah
On (Wed) 20 Jul 2011 [18:23:34], Markus Armbruster wrote: > This patch series looks bigger than it is. All the patches are small > and hopefully easy to review. Nice series! ACK the entire series (barring the non-qdev users connecting to bdrv and scsi patches, which I didn't quite follow).

Re: [Qemu-devel] [PATCH v2 3/5] balloon: Ignore negative balloon values

2011-07-28 Thread Amit Shah
On (Thu) 28 Jul 2011 [09:31:53], Markus Armbruster wrote: > Amit Shah writes: > > > Negative balloon values don't make sense, ignore them. > > Actually, they aren't ignored, they're rejected. Will update commit log. Amit

Re: [Qemu-devel] [PATCH v2 4/5] virtio-balloon: Add exit handler, fix memleaks

2011-07-28 Thread Amit Shah
On (Thu) 28 Jul 2011 [09:39:40], Markus Armbruster wrote: > Amit Shah writes: > > > On (Thu) 28 Jul 2011 [11:47:15], Amit Shah wrote: > >> Add an exit handler that will free up RAM and unregister the savevm > >> section after a virtio-balloon device is unplugged. > > > > This commit message shoul

Re: [Qemu-devel] [PATCH v2 5/5] virtio-balloon: Unregister savevm section on device unplug

2011-07-28 Thread Amit Shah
On (Thu) 28 Jul 2011 [09:45:44], Markus Armbruster wrote: > Amit Shah writes: > > > Migrating after unplugging a virtio-balloon device resulted in an error > > message on the destination: > > > > Unknown savevm section or instance ':00:04.0/virtio-balloon' 0 > > load of migration failed > > >

[Qemu-devel] [PULL v2][ALSO STABLE] balloon: multiple fixes and cleanups

2011-07-28 Thread Amit Shah
Hello, This new pull request carries the first 7 patches from the earlier pull request that cleaned up balloon code and fixed a use-after-free segfault on issuing 'balloon 0'. This series adds 5 more patches that fix: - a memleak on unplug, - migration after unplug, - negative balloon values

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for dynamic block params change

2011-07-28 Thread Supriya Kannery
On 07/27/2011 09:32 PM, Anthony Liguori wrote: On 07/27/2011 09:31 AM, Stefan Hajnoczi wrote: On Wed, Jul 27, 2011 at 1:58 PM, Anthony Liguori wrote: Index: qemu/hmp-commands.hx === --- qemu.orig/hmp-commands.hx +++ qemu/hmp-comman

Re: [Qemu-devel] Block layer roadmap

2011-07-28 Thread Kevin Wolf
Am 27.07.2011 14:37, schrieb Stefan Hajnoczi: > Hi, > Here is a list of block layer and storage changes that have been discussed. > It > is useful to have a roadmap of changes in order to avoid duplication, allow > more developers to contribute, and to communicate the direction of storage in > QE

[Qemu-devel] [PATCH 0.16 v3 0/3] make endian-independent unaligned memory access functions available to libhw

2011-07-28 Thread Paolo Bonzini
Functions like ldl_be_p and ldl_le_p are currently used only as building blocks for {ld,st}XX_p. As such, they are in cpu-all.h even though they have absolutely no dependency on the target. In order to make them globally available, this series moves them to bswap.h instead. An interesting part o

[Qemu-devel] [PATCH 0.16 v3 1/3] move WORDS_ALIGNED to qemu-common.h

2011-07-28 Thread Paolo Bonzini
This is not a CPU interface, and a configure test would not be too precise. So just add it to qemu-common.h. Signed-off-by: Paolo Bonzini --- cpu-common.h |4 qemu-common.h |4 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cpu-common.h b/cpu-common.h index 44

[Qemu-devel] [PATCH 0.16 v3 2/3] softfloat: change default nan definitions to variables

2011-07-28 Thread Paolo Bonzini
Most definitions in softfloat.h are really target-independent, but the file is not because it includes definitions of the default NaN values. Change those to variables to allow including softfloat.h from files that are not compiled per-target. By making them const, the compiler is allowed to optim

[Qemu-devel] [PATCH 0.16 v3 3/3] move unaligned memory access functions to bswap.h

2011-07-28 Thread Paolo Bonzini
This is just code movement, and moving the fpu/ include path from target-dependent to target-independent Make variables. Signed-off-by: Paolo Bonzini --- Makefile.hw |2 +- bswap.h | 474 +++ configure |3 +- cpu-all.h | 4

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for dynamic block params change

2011-07-28 Thread Kevin Wolf
Am 27.07.2011 16:51, schrieb Stefan Hajnoczi: > 2011/7/27 Michael Tokarev : >> 27.07.2011 15:30, Supriya Kannery wrote: >>> New command "block_set" added for dynamically changing any of the block >>> device parameters. For now, dynamic setting of hostcache params using this >>> command is implement

Re: [Qemu-devel] [V5 Patch 1/4]Qemu: Enhance "info block" to display host cache setting

2011-07-28 Thread Supriya Kannery
On 07/27/2011 07:49 PM, Stefan Hajnoczi wrote: On Wed, Jul 27, 2011 at 12:30 PM, Supriya Kannery wrote: Enhance "info block" to display hostcache setting for each block device. Example: (qemu) info block ide0-hd0: type=hd removable=0 file=../rhel6-32.qcow2 ro=0 drv=qcow2 encrypted=0 Enhanced

Re: [Qemu-devel] [PATCH] fix disabling interrupts in sun4u

2011-07-28 Thread tsnsaito
Hi, At Mon, 25 Jul 2011 19:22:38 +0200, Artyom Tarasenko wrote: > clear interrupt request if the interrupt priority < CPU pil > clear hardware interrupt request if interrupts are disabled Not directly related to the fix, but I'd like to note a problem of hw/sun4u.c interrupt code: The interrupt

Re: [Qemu-devel] Block layer roadmap

2011-07-28 Thread Stefan Hajnoczi
On Wed, Jul 27, 2011 at 1:37 PM, Stefan Hajnoczi wrote: > =Changes where I am not aware of firm plans= qcow2 online resize * Handle snapshots * Support shrinking qed online resize * Support shrinking

[Qemu-devel] [PATCH v3 1/2] The command line support for QEMU disk I/O limits

2011-07-28 Thread Zhi Yong Wu
Signed-off-by: Zhi Yong Wu --- Makefile.objs |2 +- blockdev.c | 22 ++ qemu-config.c | 24 qemu-option.c | 17 + qemu-option.h |1 + qemu-options.hx |1 + 6 files changed, 66 insertions(+), 1 deletions(-)

[Qemu-devel] [PATCH v3 2/2] The implement of block queue, block timer, and I/O throttling algorithm

2011-07-28 Thread Zhi Yong Wu
Note: 1.) When bps/iops limits are specified to a small value such as 511 bytes/s, this VM will hang up. We are considering how to handle this senario. 2.) When "dd" command is issued in guest, if its option bs is set to a large value such as "bs=1024K", the result speed will slightly bigge

[Qemu-devel] [PATCH v3 0/2] The intro for QEMU disk I/O limits

2011-07-28 Thread Zhi Yong Wu
The main goal of the patch is to effectively cap the disk I/O speed or counts of one single VM.It is only one draft, so it unavoidably has some drawbacks, if you catch them, please let me know. The patch will mainly introduce one block I/O throttling algorithm, one timer and one block queue for

Re: [Qemu-devel] [PATCH v2 5/5] virtio-balloon: Unregister savevm section on device unplug

2011-07-28 Thread Michael S. Tsirkin
On Thu, Jul 28, 2011 at 09:45:44AM +0200, Markus Armbruster wrote: > I hate the virtio pointer thicket. The problem is that each device is both a virtio pci device and a virtio net device. -- MST

Re: [Qemu-devel] [PATCH] add QEMU_LD_PREFIX environment variable

2011-07-28 Thread Johannes Schauer
Hi, On Thu, Jul 28, 2011 at 11:41:09AM +0300, Riku Voipio wrote: > On Sat, Jul 23, 2011 at 07:47:49AM +0200, josch wrote: > > This could be avoided by setting the proposed environment variable > > QEMU_LD_PREFIX to the just > > created debian rootfs. As mentioned earlier, the usage of the -L opti

Re: [Qemu-devel] [PATCH] fix disabling interrupts in sun4u

2011-07-28 Thread Artyom Tarasenko
Hi, On Thu, Jul 28, 2011 at 12:31 PM, wrote: > Hi, > > At Mon, 25 Jul 2011 19:22:38 +0200, > Artyom Tarasenko wrote: > >> clear interrupt request if the interrupt priority < CPU pil >> clear hardware interrupt request if interrupts are disabled > > Not directly related to the fix, but I'd like to

[Qemu-devel] [PATCH] libcacard: use INSTALL_DATA for data

2011-07-28 Thread Alon Levy
Signed-off-by: Alon Levy --- libcacard/Makefile |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/libcacard/Makefile b/libcacard/Makefile index 15205b5..33c1302 100644 --- a/libcacard/Makefile +++ b/libcacard/Makefile @@ -56,9 +56,8 @@ install-libcacard: libcacard.pc li

Re: [Qemu-devel] [PATCH] fix disabling interrupts in sun4u

2011-07-28 Thread tsnsaito
At Thu, 28 Jul 2011 13:51:08 +0200, Artyom Tarasenko wrote: > On Thu, Jul 28, 2011 at 12:31 PM, wrote: > > Hi, > > > > At Mon, 25 Jul 2011 19:22:38 +0200, > > Artyom Tarasenko wrote: > > > >> clear interrupt request if the interrupt priority < CPU pil > >> clear hardware interrupt request if inte

Re: [Qemu-devel] Block layer roadmap

2011-07-28 Thread Christoph Hellwig
On Thu, Jul 28, 2011 at 12:05:43PM +0200, Kevin Wolf wrote: > Another item that just came up on IRC again: Allow guests to toggle WCE, > so that we finally can get rid of the cache=writethrough default. We > should definitely get this done before 1.0. Guest toggling is nice and cool, but the real

Re: [Qemu-devel] Block layer roadmap

2011-07-28 Thread Christoph Hellwig
On Wed, Jul 27, 2011 at 01:37:31PM +0100, Stefan Hajnoczi wrote: > Coroutines in the block layer [Kevin] > * Programming model to simplify block drivers without blocking QEMU threads Can anyone explain what the whole point of this is? It really just is a bit of syntactic sugar for the current as

Re: [Qemu-devel] [PATCH] fix disabling interrupts in sun4u

2011-07-28 Thread Tsuneo Saito
2011/7/28 : > > At Thu, 28 Jul 2011 13:51:08 +0200, > Artyom Tarasenko wrote: > > On Thu, Jul 28, 2011 at 12:31 PM,   wrote: > > > Hi, > > > > > > At Mon, 25 Jul 2011 19:22:38 +0200, > > > Artyom Tarasenko wrote: > > > > > >> clear interrupt request if the interrupt priority < CPU pil > > >> clear

Re: [Qemu-devel] Block layer roadmap

2011-07-28 Thread Frediano Ziglio
2011/7/28 Christoph Hellwig : > On Wed, Jul 27, 2011 at 01:37:31PM +0100, Stefan Hajnoczi wrote: >> Coroutines in the block layer [Kevin] >>  * Programming model to simplify block drivers without blocking QEMU threads > > Can anyone explain what the whole point of this is?  It really just is > a bi

Re: [Qemu-devel] [PATCH 1/2] linux aio: support flush operation

2011-07-28 Thread Christoph Hellwig
On Thu, Jul 28, 2011 at 09:47:05AM +0200, Kevin Wolf wrote: > > Indeed. This has come up a few times, and actually is a mostly trivial > > task. Maybe we should give up waiting for -blockdev and separate cache > > mode settings and allow a nocache-writethrough or similar mode now? It's > > going

Re: [Qemu-devel] Block layer roadmap

2011-07-28 Thread Christoph Hellwig
On Thu, Jul 28, 2011 at 02:15:38PM +0200, Frediano Ziglio wrote: > > This has nothing (or few) to do with threads. Instead of splitting > functions in callbacks at every synchronous function it allow to write > more readable code. Thanks for repeating my statement that it doesn't fix the real thi

Re: [Qemu-devel] [PATCH v2 5/5] virtio-balloon: Unregister savevm section on device unplug

2011-07-28 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Thu, Jul 28, 2011 at 09:45:44AM +0200, Markus Armbruster wrote: >> I hate the virtio pointer thicket. > > The problem is that each device is both a virtio pci > device and a virtio net device. In my possibly naive opinion, virtio-FOO-pci is a PCI device, and has

Re: [Qemu-devel] Block layer roadmap

2011-07-28 Thread Kevin Wolf
Am 28.07.2011 14:08, schrieb Christoph Hellwig: > On Thu, Jul 28, 2011 at 12:05:43PM +0200, Kevin Wolf wrote: >> Another item that just came up on IRC again: Allow guests to toggle WCE, >> so that we finally can get rid of the cache=writethrough default. We >> should definitely get this done before

Re: [Qemu-devel] [PATCH v2 5/5] virtio-balloon: Unregister savevm section on device unplug

2011-07-28 Thread Michael S. Tsirkin
On Thu, Jul 28, 2011 at 02:21:32PM +0200, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Jul 28, 2011 at 09:45:44AM +0200, Markus Armbruster wrote: > >> I hate the virtio pointer thicket. > > > > The problem is that each device is both a virtio pci > > device and a virtio n

Re: [Qemu-devel] Block layer roadmap

2011-07-28 Thread Kevin Wolf
Am 28.07.2011 14:09, schrieb Christoph Hellwig: > On Wed, Jul 27, 2011 at 01:37:31PM +0100, Stefan Hajnoczi wrote: >> Coroutines in the block layer [Kevin] >> * Programming model to simplify block drivers without blocking QEMU threads > > Can anyone explain what the whole point of this is? It re

Re: [Qemu-devel] [PATCH 1/2] linux aio: support flush operation

2011-07-28 Thread Kevin Wolf
Am 28.07.2011 14:15, schrieb Christoph Hellwig: >> Christoph, on another note: Can we rely on Linux AIO never returning >> short writes except on EOF? Currently we return -EINVAL in this case, so "short reads" I meant, of course. >> I hope it's true or we wouldn't return the correct error code. >

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-28 Thread Anthony Liguori
On 07/28/2011 02:36 AM, Paolo Bonzini wrote: On 07/27/2011 10:01 PM, Anthony Liguori wrote: That's milkymist, not GoldFish. Oh, Goldfish is fake. It's not real hardware. The enumerator device is not a real device. It's weird because it's imaginary and was designed specifically within QEMU.

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for dynamic block params change

2011-07-28 Thread Anthony Liguori
On 07/28/2011 05:13 AM, Supriya Kannery wrote: On 07/27/2011 09:32 PM, Anthony Liguori wrote: On 07/27/2011 09:31 AM, Stefan Hajnoczi wrote: On Wed, Jul 27, 2011 at 1:58 PM, Anthony Liguori wrote: Index: qemu/hmp-commands.hx === -

Re: [Qemu-devel] [PATCH v2] pci: Common overflow prevention

2011-07-28 Thread Isaku Yamahata
On Thu, Jul 28, 2011 at 11:40:21AM +0300, Michael S. Tsirkin wrote: > On Thu, Jul 28, 2011 at 04:23:24PM +0900, Isaku Yamahata wrote: > > This might be a bit late comment... > > > > On Fri, Jul 22, 2011 at 11:05:01AM +0200, Jan Kiszka wrote: > > > diff --git a/hw/pci_host.c b/hw/pci_host.c > > > i

Re: [Qemu-devel] [PATCH] fix disabling interrupts in sun4u

2011-07-28 Thread Artyom Tarasenko
On Thu, Jul 28, 2011 at 2:03 PM, wrote: > At Thu, 28 Jul 2011 13:51:08 +0200, > Artyom Tarasenko wrote: >> On Thu, Jul 28, 2011 at 12:31 PM,   wrote: >> > Hi, >> > >> > At Mon, 25 Jul 2011 19:22:38 +0200, >> > Artyom Tarasenko wrote: >> > >> >> clear interrupt request if the interrupt priority <

Re: [Qemu-devel] Block layer roadmap

2011-07-28 Thread Anthony Liguori
On 07/28/2011 07:09 AM, Christoph Hellwig wrote: On Wed, Jul 27, 2011 at 01:37:31PM +0100, Stefan Hajnoczi wrote: Coroutines in the block layer [Kevin] * Programming model to simplify block drivers without blocking QEMU threads Can anyone explain what the whole point of this is? It really j

Re: [Qemu-devel] Block layer roadmap

2011-07-28 Thread Stefan Hajnoczi
On Thu, Jul 28, 2011 at 1:35 PM, Kevin Wolf wrote: > Am 28.07.2011 14:09, schrieb Christoph Hellwig: >> On Wed, Jul 27, 2011 at 01:37:31PM +0100, Stefan Hajnoczi wrote: >>> Coroutines in the block layer [Kevin] >>>  * Programming model to simplify block drivers without blocking QEMU threads >> >>

Re: [Qemu-devel] [PATCH] fix disabling interrupts in sun4u

2011-07-28 Thread Artyom Tarasenko
On Thu, Jul 28, 2011 at 2:10 PM, Tsuneo Saito wrote: > 2011/7/28 : >> >> At Thu, 28 Jul 2011 13:51:08 +0200, >> Artyom Tarasenko wrote: >> > On Thu, Jul 28, 2011 at 12:31 PM,   wrote: >> > > Hi, >> > > >> > > At Mon, 25 Jul 2011 19:22:38 +0200, >> > > Artyom Tarasenko wrote: >> > > >> > >> clear i

Re: [Qemu-devel] Block layer roadmap

2011-07-28 Thread Kevin Wolf
Am 28.07.2011 14:54, schrieb Stefan Hajnoczi: > On Thu, Jul 28, 2011 at 1:35 PM, Kevin Wolf wrote: >> Am 28.07.2011 14:09, schrieb Christoph Hellwig: >>> On Wed, Jul 27, 2011 at 01:37:31PM +0100, Stefan Hajnoczi wrote: Coroutines in the block layer [Kevin] * Programming model to simplif

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for dynamic block params change

2011-07-28 Thread Stefan Hajnoczi
On Thu, Jul 28, 2011 at 11:23 AM, Kevin Wolf wrote: > Am 27.07.2011 16:51, schrieb Stefan Hajnoczi: >> 2011/7/27 Michael Tokarev : >>> 27.07.2011 15:30, Supriya Kannery wrote: New command "block_set" added for dynamically changing any of the block device parameters. For now, dynamic sett

Re: [Qemu-devel] Block layer roadmap

2011-07-28 Thread Stefan Hajnoczi
On Thu, Jul 28, 2011 at 2:10 PM, Kevin Wolf wrote: > Am 28.07.2011 14:54, schrieb Stefan Hajnoczi: >> On Thu, Jul 28, 2011 at 1:35 PM, Kevin Wolf wrote: >>> Am 28.07.2011 14:09, schrieb Christoph Hellwig: On Wed, Jul 27, 2011 at 01:37:31PM +0100, Stefan Hajnoczi wrote: > Coroutines in th

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for dynamic block params change

2011-07-28 Thread Kevin Wolf
Am 28.07.2011 15:10, schrieb Stefan Hajnoczi: > On Thu, Jul 28, 2011 at 11:23 AM, Kevin Wolf wrote: >> Am 27.07.2011 16:51, schrieb Stefan Hajnoczi: >>> I'll think about this some more, there are a couple of solutions like >>> keeping only the file descriptor around, introducing a flush command >>

[Qemu-devel] [PATCH RESEND 2/3] Move the xenfb pointer handler to the connected method

2011-07-28 Thread stefano.stabellini
From: John Haxby Ensure that we read "request-abs-pointer" after the frontend has written it. This means that we will correctly set up an ansolute or relative pointer handler correctly. Signed-off-by: John Haxby Acked-by: Stefano Stabellini --- hw/xenfb.c | 19 ++- 1 files

[Qemu-devel] [PATCH RESEND 1/3] Introduce a new 'connected' xendev op called when Connected.

2011-07-28 Thread stefano.stabellini
From: John Haxby Rename the existing xendev 'connect' op to 'initialised' and introduce a new 'connected' op. This new op, if defined, is called when the backend is connected. Note that since there is no state transition this may be called more than once. Signed-off-by: John Haxby Acked-by: S

[Qemu-devel] [PATCH RESEND 3/3] xen: use uint64_t instead of target_ulong in cpu_ioreq_move

2011-07-28 Thread stefano.stabellini
From: Stefano Stabellini cpu_ioreq_move might move 8 bytes at a time so we must make sure that the temporary variable can hold 8 bytes. Signed-off-by: Stefano Stabellini --- xen-all.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/xen-all.c b/xen-all.c index 9eaeac1.

Re: [Qemu-devel] [RFC] Introduce vm_stop_permanent()

2011-07-28 Thread Luiz Capitulino
On Thu, 28 Jul 2011 10:23:22 +0300 Avi Kivity wrote: > On 07/28/2011 12:44 AM, Blue Swirl wrote: > > On Wed, Jul 27, 2011 at 9:42 PM, Luiz Capitulino > > wrote: > > > This function should be used when the VM is not supposed to resume > > > execution (eg. by issuing 'cont' monitor command). >

Re: [Qemu-devel] [RFC] Introduce vm_stop_permanent()

2011-07-28 Thread Avi Kivity
On 07/28/2011 04:31 PM, Luiz Capitulino wrote: On Thu, 28 Jul 2011 10:23:22 +0300 Avi Kivity wrote: > On 07/28/2011 12:44 AM, Blue Swirl wrote: > > On Wed, Jul 27, 2011 at 9:42 PM, Luiz Capitulino wrote: > > > This function should be used when the VM is not supposed to resume > > >

[Qemu-devel] [PATCH 0/4] Set of patches for chrooted environment

2011-07-28 Thread Laurent Vivier
This set of patches helps to use qemu-linux-user in a chrooted environment. It mostly allows to define the default cpu model as we can't use '-cpu' argument. The last one defines enviromnent variables to be able to use log file and gdb server ('-d' and '-g' arguments). NOTE: I saw some comment

[Qemu-devel] [PATCH 2/4] linux-user: specify the cpu model during configure

2011-07-28 Thread Laurent Vivier
This patch allows to set the default cpu model for a given architecture, for instance: configure --target-list=m68k-linux-user --m68k-default-cpu=m68040 Signed-off-by: Laurent Vivier --- configure |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/configure b/conf

[Qemu-devel] [PATCH 3/4] linux-user,m68k: display default cpu

2011-07-28 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- target-m68k/helper.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/target-m68k/helper.c b/target-m68k/helper.c index a936fe7..f5d33cd 100644 --- a/target-m68k/helper.c +++ b/target-m68k/helper.c @@ -57,6 +57,11 @@ void m68k_cpu_list

[Qemu-devel] [PATCH 4/4] linux-user: define new environment variables

2011-07-28 Thread Laurent Vivier
QEMU_GDB=port allows to define gdb server port to wait on. QEMU_DEBUG=options allows to activate log file (like -d options) Signed-off-by: Laurent Vivier --- linux-user/main.c | 11 --- qemu-doc.texi |4 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/linux

[Qemu-devel] [PATCH 1/4] linux-user: define default cpu model in configure instead of linux-user/main.c

2011-07-28 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- configure | 15 +++ linux-user/main.c | 34 +- 2 files changed, 16 insertions(+), 33 deletions(-) diff --git a/configure b/configure index fb8819b..c74a5f9 100755 --- a/configure +++ b/configure @@ -3075,6

Re: [Qemu-devel] [PATCH] fix disabling interrupts in sun4u

2011-07-28 Thread tsnsaito
At Thu, 28 Jul 2011 14:50:57 +0200, Artyom Tarasenko wrote: > On Thu, Jul 28, 2011 at 2:03 PM, wrote: > > At Thu, 28 Jul 2011 13:51:08 +0200, > > Artyom Tarasenko wrote: > >> On Thu, Jul 28, 2011 at 12:31 PM,   wrote: > >> > Hi, > >> > > >> > At Mon, 25 Jul 2011 19:22:38 +0200, > >> > Artyom Tara

[Qemu-devel] [PATCH] [RFC] qcow2: group refcount updates during cow

2011-07-28 Thread Frediano Ziglio
Well, I think this is the first real improve patch. Is more a RFC than a patch. Yes, some lines are terrible! It collapses refcount decrement during cow. >From a first check time executing 015 test passed from about 600 seconds to 70. This at least prove that refcount updates counts! Some doubt: 1-

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-28 Thread Paolo Bonzini
On 07/28/2011 02:46 PM, Anthony Liguori wrote: There are plenty of PV interfaces implemented by QEMU. Would you say the same of virtio? Virtio was designed to look like real hardware. I would say that trying to fit XenStore into QOM would not be a good exercise. No doubt about that. :) I'd

Re: [Qemu-devel] [PATCH 00/12] bugfix and qdevify NAND and ONENAND devices

2011-07-28 Thread Peter Maydell
Ping on this one too, since I'm nearly ready with the next chunk of patches (18 patches fixing bugs and adding NAND support to omap_gpmc) and they obviously depend on this set. -- PMM On 15 July 2011 15:58, Peter Maydell wrote: > This patchseries is more goodies from the Meego tree. Specifically

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-28 Thread Anthony Liguori
On 07/28/2011 08:50 AM, Paolo Bonzini wrote: On 07/28/2011 02:46 PM, Anthony Liguori wrote: There are plenty of PV interfaces implemented by QEMU. Would you say the same of virtio? Virtio was designed to look like real hardware. I would say that trying to fit XenStore into QOM would not be a

[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2011-07-28 Thread Jeff Snider
Michael: Yes, that is the correct patch. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/524447 Title: virsh save is very slow Status in libvirt virtualization API: Unknown Status in QEMU: Fix R

Re: [Qemu-devel] [PATCH] [RFC] qcow2: group refcount updates during cow

2011-07-28 Thread Kevin Wolf
Am 28.07.2011 15:50, schrieb Frediano Ziglio: > Well, I think this is the first real improve patch. > Is more a RFC than a patch. Yes, some lines are terrible! > It collapses refcount decrement during cow. > From a first check time executing 015 test passed from about 600 seconds > to 70. > This at

Re: [Qemu-devel] Volume key in qcow3?

2011-07-28 Thread Kevin Wolf
Am 28.07.2011 10:05, schrieb Frediano Ziglio: > Hi, > I noted that AES encryption using qcow2 just use the password given > as as key (and also truncating it to 16 bytes == 128 bits). > This is prone to brute force attacks and is not also easy to change > password (you have to decrypt and encrypt

Re: [Qemu-devel] [RFC] Introduce vm_stop_permanent()

2011-07-28 Thread Jan Kiszka
On 2011-07-28 15:37, Avi Kivity wrote: > On 07/28/2011 04:31 PM, Luiz Capitulino wrote: >> On Thu, 28 Jul 2011 10:23:22 +0300 >> Avi Kivity wrote: >> >> > On 07/28/2011 12:44 AM, Blue Swirl wrote: >> > > On Wed, Jul 27, 2011 at 9:42 PM, Luiz >> Capitulino wrote: >> > > > This function sho

[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2011-07-28 Thread Michael Tokarev
I just wanted to point out that we've this patch in Debian since ages, and it's been included in upstream for a long time too. Added a debbug reference for this as well. ** Bug watch added: Debian Bug tracker #597517 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=597517 ** Also affects: qem

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-28 Thread Paolo Bonzini
On 07/28/2011 04:03 PM, Anthony Liguori wrote: No doubt about that. :) I'd put a lot more hope into Goldfish though. What's unclear to me about the Goldfish enumerator is whether it should be filled out through interaction with hardware devices or via some other mechanism. In many ways, it's s

Re: [Qemu-devel] [PATCH] fix disabling interrupts in sun4u

2011-07-28 Thread Artyom Tarasenko
On Thu, Jul 28, 2011 at 3:40 PM, wrote: > At Thu, 28 Jul 2011 14:50:57 +0200, > Artyom Tarasenko wrote: >> On Thu, Jul 28, 2011 at 2:03 PM,   wrote: >> > At Thu, 28 Jul 2011 13:51:08 +0200, >> > Artyom Tarasenko wrote: >> >> On Thu, Jul 28, 2011 at 12:31 PM,   wrote: >> >> > Hi, >> >> > >> >> > A

[Qemu-devel] [PATCH] lm832x: Take DeviceState pointer in lm832x_key_event()

2011-07-28 Thread Peter Maydell
Since lm832x has been qdev'ified, its users will generally have a DeviceState pointer rather than an i2c_slave pointer, so adjust lm832x_key_event's prototype to suit. This allows the n810 (its only user) to actually pass a correct pointer to it rather than NULL. The effect is that we no longer se

Re: [Qemu-devel] [PATCH v2 1/1] The codes V2 for QEMU disk I/O limits.

2011-07-28 Thread Marcelo Tosatti
On Thu, Jul 28, 2011 at 12:24:48PM +0800, Zhi Yong Wu wrote: > On Wed, Jul 27, 2011 at 11:49 PM, Marcelo Tosatti wrote: > > On Wed, Jul 27, 2011 at 06:17:15PM +0800, Zhi Yong Wu wrote: > >> >> +        wait_time = 1; > >> >> +    } > >> >> + > >> >> +    wait_time = wait_time + (slice_time - elaps

  1   2   >