Re: [Qemu-devel] [PATCH] posix-aio-compat: Fix idle_threads counter

2011-05-04 Thread Stefan Hajnoczi
On Tue, May 3, 2011 at 5:53 PM, Kevin Wolf wrote: > Am 03.05.2011 17:56, schrieb Stefan Hajnoczi: >> On Tue, May 3, 2011 at 2:26 PM, Kevin Wolf wrote: >>> A thread should only be counted as idle when it really is waiting for new >>> requests. Without this patch, sometimes too few threads are star

Re: [Qemu-devel] [PATCH] ide: cleanup warnings

2011-05-04 Thread Kevin Wolf
Am 03.05.2011 22:03, schrieb Andrea Arcangeli: > Hello, > > This is just a minor cleanup adding \n. Thanks, applied to the block branch. > On a side note, it was good idea to keep it under DEBUG_IDE because if > iscsi server reboots or goes down, this would generate a flood of > errors if it's e

Re: [Qemu-devel] [PATCH v3 5/5] hpet 'driftfix': add code in hpet_timer() to compensate delayed callbacks and coalesced interrupts

2011-05-04 Thread Ulrich Obergfell
Hi Marcelo, > Whats prev_period for, since in practice the period will not change > between interrupts (OS programs comparator once, or perhaps twice > during bootup) ? 'prev_period' is needed if a guest o/s changes the comparator period 'on the fly' (without stopping and restarting the timer).

[Qemu-devel] [PATCH] s390x: Fix debugging for unknown sigp order codes

2011-05-04 Thread Christian Borntraeger
On unknown sigp order codes we print a debug message. This patch fixes the output, since we want to see the order_code and not the register numbers. Patch applies on agraf tree. Signed-off-by: Christian Borntraeger --- target-s390x/kvm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH 05/17] kvm: add kvm stub for arch specific stuff

2011-05-04 Thread Jan Kiszka
On 2011-05-04 07:19, Alexander Graf wrote: > > On 03.05.2011, at 16:57, Jan Kiszka wrote: > >> On 2011-05-03 16:17, Alexander Graf wrote: >>> >>> On 18.04.2011, at 20:34, Aurelien Jarno wrote: >>> On Fri, Apr 15, 2011 at 05:32:46PM +0200, Alexander Graf wrote: > We have a generic stub ar

Re: [Qemu-devel] [PATCH] s390x: Fix debugging for unknown sigp order codes

2011-05-04 Thread Alexander Graf
On 04.05.2011, at 10:30, Christian Borntraeger wrote: > On unknown sigp order codes we print a debug message. This patch > fixes the output, since we want to see the order_code and not > the register numbers. > Patch applies on agraf tree. > > Signed-off-by: Christian Borntraeger Thanks, appli

[Qemu-devel] IPv6 support for TCP migrations

2011-05-04 Thread nick
Hi, Currently migration-tcp.c uses the IPv4-only socket functions, making migrations over IPv6 impossible. Following is a tentative patch that switches it to use inet_connect() and inet_listen(). However, the patch loses the non-blocking connect() behaviour seen with the previous code. I'm not s

[Qemu-devel] [PATCH] migration-tcp: Allow incoming and outgoing migrations over IPv6

2011-05-04 Thread nick
From: Nick Thomas Signed-off-by: Nick Thomas --- migration-tcp.c | 85 --- 1 files changed, 12 insertions(+), 73 deletions(-) diff --git a/migration-tcp.c b/migration-tcp.c index d3d80c9..8ae778e 100644 --- a/migration-tcp.c +++ b/migration

Re: [Qemu-devel] [PATCH 05/17] kvm: add kvm stub for arch specific stuff

2011-05-04 Thread Alexander Graf
On 04.05.2011, at 10:31, Jan Kiszka wrote: > On 2011-05-04 07:19, Alexander Graf wrote: >> >> On 03.05.2011, at 16:57, Jan Kiszka wrote: >> >>> On 2011-05-03 16:17, Alexander Graf wrote: On 18.04.2011, at 20:34, Aurelien Jarno wrote: > On Fri, Apr 15, 2011 at 05:32:46PM +02

Re: [Qemu-devel] [PATCH 05/17] kvm: add kvm stub for arch specific stuff

2011-05-04 Thread Jan Kiszka
On 2011-05-04 10:40, Alexander Graf wrote: > > On 04.05.2011, at 10:31, Jan Kiszka wrote: > >> On 2011-05-04 07:19, Alexander Graf wrote: >>> >>> On 03.05.2011, at 16:57, Jan Kiszka wrote: >>> On 2011-05-03 16:17, Alexander Graf wrote: > > On 18.04.2011, at 20:34, Aurelien Jarno wrot

Re: [Qemu-devel] [PATCH 05/17] kvm: add kvm stub for arch specific stuff

2011-05-04 Thread Alexander Graf
On 04.05.2011, at 10:43, Jan Kiszka wrote: > On 2011-05-04 10:40, Alexander Graf wrote: >> >> On 04.05.2011, at 10:31, Jan Kiszka wrote: >> >>> On 2011-05-04 07:19, Alexander Graf wrote: On 03.05.2011, at 16:57, Jan Kiszka wrote: > On 2011-05-03 16:17, Alexander Graf wrote:

Re: [Qemu-devel] [PATCH v2] Import Linux headers for KVM and vhost

2011-05-04 Thread Jan Kiszka
On 2011-05-03 23:37, Michael S. Tsirkin wrote: > On Tue, May 03, 2011 at 12:59:06PM -0500, Anthony Liguori wrote: >> On 05/03/2011 12:55 PM, Jan Kiszka wrote: >>> On 2011-05-03 19:45, Anthony Liguori wrote: On 05/03/2011 12:30 PM, Peter Maydell wrote: > On 3 May 2011 17:48, Jan Kiszka wr

[Qemu-devel] [Bug 723871] Re: qemu-kvm-0.14.0 Aborts with -vga qxl

2011-05-04 Thread Boris Derzhavets
git clone git://git.freedesktop.org/git/spice/qemu cd qemu/ git checkout -b spice.v35 origin/spice.35 Allows to build qemu-kvm-spice_0.14.0+noroms-0ubuntu4qxl3_amd64.deb with patches larger_default_ram_size.patch # Detect-and-use-GCC-atomic-builtins-for-locking.patch # 0001-qxl-spice-display-move

[Qemu-devel] [Bug 723871] Re: qemu-kvm-0.14.0 Aborts with -vga qxl

2011-05-04 Thread Boris Derzhavets
** Attachment added: "qemu-kvm-spice based spice.v35" https://bugs.launchpad.net/qemu/+bug/723871/+attachment/2111482/+files/qemu-kvm-spice_0.14.0%2Bnoroms-0ubuntu4qxl3_amd64.deb -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. ht

Re: [Qemu-devel] [PATCH 07/18] Fix typo in comment (consistant -> consistent)

2011-05-04 Thread Alon Levy
On Thu, Apr 28, 2011 at 05:20:31PM +0200, Stefan Weil wrote: > Signed-off-by: Stefan Weil > --- ACK. I assumed since you emailed qemu-trivial that these don't actually require any acks. > libcacard/vcard_emul_nss.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/

Re: [Qemu-devel] IPv6 support for TCP migrations

2011-05-04 Thread Daniel P. Berrange
On Wed, May 04, 2011 at 09:39:02AM +0100, n...@bytemark.co.uk wrote: > Hi, > > Currently migration-tcp.c uses the IPv4-only socket functions, making > migrations over IPv6 impossible. Following is a tentative patch that switches > it to use inet_connect() and inet_listen(). > > However, the patc

Re: [Qemu-devel] [PATCH v2] Import Linux headers for KVM and vhost

2011-05-04 Thread Jan Kiszka
On 2011-05-03 22:22, Peter Maydell wrote: > On 3 May 2011 17:48, Jan Kiszka wrote: >> +++ b/scripts/update-linux-headers.sh >> @@ -0,0 +1,47 @@ >> +#!/bin/sh > > No -e ? > >> +rm -rf $output/include/linux/* > > Given that updating the kernel headers will blow away large > subsets of include/ li

[Qemu-devel] s390x kvm and smp

2011-05-04 Thread Christian Borntraeger
Alex, I have trouble getting kvm smp support running. Turns out that qemu does a kvm run even on secondary CPUs which dont have a sane state (initial psw == 0) triggering some program faults. Architecturally these cpus are in the stopped state, so we should not do KVM_RUN. (these CPUs will be star

Re: [Qemu-devel] IPv6 support for TCP migrations

2011-05-04 Thread Nicholas Thomas
On Wed, 2011-05-04 at 11:13 +0100, Daniel P. Berrange wrote: > On Wed, May 04, 2011 at 09:39:02AM +0100, n...@bytemark.co.uk wrote: > > Hi, > > > > Currently migration-tcp.c uses the IPv4-only socket functions, making > > migrations over IPv6 impossible. Following is a tentative patch that > > sw

Re: [Qemu-devel] s390x kvm and smp

2011-05-04 Thread Jan Kiszka
On 2011-05-04 12:43, Christian Borntraeger wrote: > Alex, > > I have trouble getting kvm smp support running. Turns out that qemu does a kvm > run even on secondary CPUs which dont have a sane state (initial psw == 0) > triggering some program faults. Architecturally these cpus are in the stopped

Re: [Qemu-devel] ­ How to cross compile QEMU

2011-05-04 Thread 李柏舉
Hi, all I using cross-compiler: arm-2008q3 , no error occur . Regards, Poki 2011/5/3 Jan-Simon Möller > Am Dienstag, 3. Mai 2011, 11:13:35 schrieb 李柏舉: > > arm-2007q3 > > Try a newer cross-compiler please and then report back. > > Best, > Jan-Simon >

Re: [Qemu-devel] [PATCH 3/3] ide: add TRIM support

2011-05-04 Thread Kevin Wolf
Am 03.05.2011 14:06, schrieb Christoph Hellwig: > Add support for TRIM sub function of the data set management command, > and wire it up to the qemu discard infrastructure. > > Signed-off-by: Christoph Hellwig Don't failed trim requests turn into writes now? Also, there are some braces missing.

Re: [Qemu-devel] [PATCH v3 5/5] hpet 'driftfix': add code in hpet_timer() to compensate delayed callbacks and coalesced interrupts

2011-05-04 Thread Marcelo Tosatti
On Wed, May 04, 2011 at 04:06:59AM -0400, Ulrich Obergfell wrote: > > Hi Marcelo, > > > Whats prev_period for, since in practice the period will not change > > between interrupts (OS programs comparator once, or perhaps twice > > during bootup) ? > > 'prev_period' is needed if a guest o/s chang

[Qemu-devel] [PATCH 03/13] s390x: make kvm exported functions conditional on kvm

2011-05-04 Thread Alexander Graf
We have some helper functions we use to directly invoke KVM functionality from device emulation code. This patch replaces those exported functions with static inline stubs when not building with KVM enabled. Signed-off-by: Alexander Graf --- target-s390x/cpu.h | 17 + 1 files

[Qemu-devel] [PATCH 05/13] s390x: Shift variables in CPUState for memset(0)

2011-05-04 Thread Alexander Graf
The default reset handler does a memset(0) until right in between CPU_COMMON. I incorrectly changed that behavior on the s390x port, so let's move the fields in CPUState around to reflect the correct split up to which point memset(0) zeros out everything. Signed-off-by: Alexander Graf --- target

[Qemu-devel] [PATCH 01/13] tcg: extend max tcg opcodes when using 64-on-32bit

2011-05-04 Thread Alexander Graf
When running a 64 bit guest on a 32 bit host, we tend to use more TCG ops than on a 64 bit host. Reflect that in the reserved opcode amount constant. Signed-off-by: Alexander Graf --- v4 -> v5: - only increase MAX_OP_PER_INSTR when running 64-on-32 --- exec-all.h |4 1 files change

[Qemu-devel] [PATCH 08/13] s390x: Adjust internal kvm code

2011-05-04 Thread Alexander Graf
We're now finally emulating an s390x CPU, so we can move quite some logic from the kvm code out into generic CPU code. This patch does this and adjusts the interfaces according to what the code around now expects to be able to call. Signed-off-by: Alexander Graf --- target-s390x/kvm.c | 44 ++

[Qemu-devel] [PATCH 00/13] s390x emulation support v5

2011-05-04 Thread Alexander Graf
We've had support for running s390x guests with KVM for a while now. This patch set also enables support for running s390x guests in system as well as linux-user mode in emulation! Within this scope, I again want to stress that this is _not_ supposed to replace Hercules - the s390 emulator - in an

[Qemu-devel] [PATCH 06/13] s390x: helper functions for system emulation

2011-05-04 Thread Alexander Graf
When running system emulation, we need to transverse through the MMU and deliver interrupts according to the specification. This patch implements those two pieces and in addition adjusts the CPU initialization code to account for the new fields in CPUState. Signed-off-by: Alexander Graf --- v1

[Qemu-devel] [PATCH 10/13] s390x: Adjust GDB stub

2011-05-04 Thread Alexander Graf
We have successfully lazilized cc computation, so we need to manually trigger its calculation when gdb wants to fetch it. We also changed the variable name, so writing it writes into a different field now. Signed-off-by: Alexander Graf --- gdbstub.c |8 ++-- 1 files changed, 6 insertions

[Qemu-devel] [PATCH 11/13] s390x: remove compatibility cc field

2011-05-04 Thread Alexander Graf
Remove the now unused cc field that was only required to not break bisectability. Signed-off-by: Alexander Graf --- target-s390x/cpu.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h index 125b939..4e5c391 100644 --- a/target-s390x

[Qemu-devel] [PATCH 02/13] s390x: s390x-linux-user support

2011-05-04 Thread Alexander Graf
From: Ulrich Hecht This patch adds support for running s390x binaries in the linux-user emulation code. Signed-off-by: Ulrich Hecht Signed-off-by: Alexander Graf --- v1 -> v2: - always set 64bit flag for s390x binaries in elf loader - remove redundant EXECUTE_SVC - advance psw.addr in

[Qemu-devel] [PATCH 04/13] s390x: keep hint on virtio managing size

2011-05-04 Thread Alexander Graf
The s390x virtio bus keeps management information on virtio after the top of the guest's RAM. We need to be able to tell the guest the size of its RAM (without virtio stuff), but also be able to trap when the guest accesses RAM outside of its scope (including virtio stuff). So we need a variable t

[Qemu-devel] [PATCH 12/13] s390x: build s390x by default

2011-05-04 Thread Alexander Graf
This patch enables building of s390x-softmmu and s390x-linux-user targets by default. Signed-off-by: Alexander Graf --- configure|2 ++ default-configs/s390x-linux-user.mak |1 + 2 files changed, 3 insertions(+), 0 deletions(-) create mode 100644 default-conf

[Qemu-devel] [PATCH 13/13] s390x: Fix debugging for unknown sigp order codes

2011-05-04 Thread Alexander Graf
From: Christian Borntraeger On unknown sigp order codes we print a debug message. This patch fixes the output, since we want to see the order_code and not the register numbers. Patch applies on agraf tree. Signed-off-by: Christian Borntraeger Signed-off-by: Alexander Graf --- target-s390x/kvm

[Qemu-devel] [PATCH 2/2] Two new monitor commands: 'info keyboard', 'keyboard_set'

2011-05-04 Thread Dmitry Zhurikhin
From: Shahar Havivi Adding 2 new monitor commands to handle keyboard list: 'info keyboard' - show all keyboard devices and mark the current one 'keyboard_set' - set active keyboard by index as displayed by 'info keyboard' Signed-off-by: Shahar Havivi --- console.h |4 ++ hmp-commands

[Qemu-devel] [PATCH 0/2 v6] Qemu support for multiple keyboard devices

2011-05-04 Thread Dmitry Zhurikhin
v6 (Dmitry Zhurikhin ): - merge with commit 57aa265d462a64a06268be26d49020729cff56c1 - moved changes from usb-hid.c and qemu_activate_keyboard_event_handler function to the first patch as more appropriate - changed some keyboard names to be more consistent - added 'info keyboard' to the 'info sub

[Qemu-devel] [PATCH 1/2] Support for multiple keyboard devices

2011-05-04 Thread Dmitry Zhurikhin
From: Shahar Havivi Adding keyboard is done to the queue instead of "last added keyboard wins", when removing keyboard via device_del - previous keyboard is selected. Signed-off-by: Shahar Havivi --- console.h| 16 +++- hw/adb.c |2 +- hw/escc.c

Re: [Qemu-devel] [PATCH v3 5/5] hpet 'driftfix': add code in hpet_timer() to compensate delayed callbacks and coalesced interrupts

2011-05-04 Thread Glauber Costa
On Wed, 2011-05-04 at 06:09 -0300, Marcelo Tosatti wrote: > On Wed, May 04, 2011 at 04:06:59AM -0400, Ulrich Obergfell wrote: > > > > Hi Marcelo, > > > > > Whats prev_period for, since in practice the period will not change > > > between interrupts (OS programs comparator once, or perhaps twice

Re: [Qemu-devel] [PATCH] ide: cleanup warnings

2011-05-04 Thread Andrea Arcangeli
On Wed, May 04, 2011 at 10:08:12AM +0200, Kevin Wolf wrote: > Isn't it a bug that qemu_aio_flush() doesn't clear aiocb/status? Should > we move the ide_set_inactive() call from ide_dma_error to ide_dma_cb? How would that make a difference, it's still running in aio context, running it a bit earlie

Re: [Qemu-devel] [PATCH v3 5/5] hpet 'driftfix': add code in hpet_timer() to compensate delayed callbacks and coalesced interrupts

2011-05-04 Thread Gleb Natapov
On Wed, May 04, 2011 at 10:36:12AM -0300, Glauber Costa wrote: > On Wed, 2011-05-04 at 06:09 -0300, Marcelo Tosatti wrote: > > On Wed, May 04, 2011 at 04:06:59AM -0400, Ulrich Obergfell wrote: > > > > > > Hi Marcelo, > > > > > > > Whats prev_period for, since in practice the period will not chan

Re: [Qemu-devel] [PATCH v3 5/5] hpet 'driftfix': add code in hpet_timer() to compensate delayed callbacks and coalesced interrupts

2011-05-04 Thread Glauber Costa
On Wed, 2011-05-04 at 16:46 +0300, Gleb Natapov wrote: > On Wed, May 04, 2011 at 10:36:12AM -0300, Glauber Costa wrote: > > On Wed, 2011-05-04 at 06:09 -0300, Marcelo Tosatti wrote: > > > On Wed, May 04, 2011 at 04:06:59AM -0400, Ulrich Obergfell wrote: > > > > > > > > Hi Marcelo, > > > > > > >

Re: [Qemu-devel] [PATCH] ide: cleanup warnings

2011-05-04 Thread Kevin Wolf
Am 04.05.2011 15:41, schrieb Andrea Arcangeli: > On Wed, May 04, 2011 at 10:08:12AM +0200, Kevin Wolf wrote: >> Isn't it a bug that qemu_aio_flush() doesn't clear aiocb/status? Should >> we move the ide_set_inactive() call from ide_dma_error to ide_dma_cb? > > How would that make a difference, it'

Re: [Qemu-devel] [PATCH v3 5/5] hpet 'driftfix': add code in hpet_timer() to compensate delayed callbacks and coalesced interrupts

2011-05-04 Thread Gleb Natapov
On Wed, May 04, 2011 at 10:47:40AM -0300, Glauber Costa wrote: > On Wed, 2011-05-04 at 16:46 +0300, Gleb Natapov wrote: > > On Wed, May 04, 2011 at 10:36:12AM -0300, Glauber Costa wrote: > > > On Wed, 2011-05-04 at 06:09 -0300, Marcelo Tosatti wrote: > > > > On Wed, May 04, 2011 at 04:06:59AM -0400

Re: [Qemu-devel] [PATCH] ide: cleanup warnings

2011-05-04 Thread Andrea Arcangeli
On Wed, May 04, 2011 at 03:57:28PM +0200, Kevin Wolf wrote: > I can't see how you could leave ide_dma_cb without either scheduling > another AIO request or setting aiocb = NULL in ide_set_inactive. I guess > I need to reproduce this and do some debugging... That would be nice to be sure. This has

Re: [Qemu-devel] [PATCH] ide: cleanup warnings

2011-05-04 Thread Kevin Wolf
Am 04.05.2011 16:04, schrieb Andrea Arcangeli: > On Wed, May 04, 2011 at 03:57:28PM +0200, Kevin Wolf wrote: >> I can't see how you could leave ide_dma_cb without either scheduling >> another AIO request or setting aiocb = NULL in ide_set_inactive. I guess >> I need to reproduce this and do some de

[Qemu-devel] [PATCH v4 09/10] trace-state: [stderr] add support for dynamically enabling/disabling events

2011-05-04 Thread Lluís
Re-send patch with added minor fix. Uses the generic interface provided in "trace/control.h" in order to provide a programmatic interface as well as command line and monitor controls. Signed-off-by: Fabien Chouteau Signed-off-by: Lluís Vilanova --- configure |3 +++ docs/tracing.tx

[Qemu-devel] [Bug 723871] Re: qemu-kvm-0.14.0 Aborts with -vga qxl

2011-05-04 Thread Serge Hallyn
@Boris Thanks for this work. Would you be interested in pursuing the process to push these packages (celt051, the spice packages, and qemu-kvm-spice based on your new package) into the Ubuntu archive? The process is described at https://wiki.ubuntu.com/UbuntuDevelopment/NewPackages. -- You rec

Re: [Qemu-devel] [Qemu-trivial] [PATCH 01/18] Fix typos in comments (dependancy -> dependency)

2011-05-04 Thread Stefan Hajnoczi
On Tue, May 3, 2011 at 9:25 PM, Stefan Weil wrote: > Am 28.04.2011 17:20, schrieb Stefan Weil: >> >> Signed-off-by: Stefan Weil >> --- >> Changelog | 2 +- >> Makefile.objs | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> > > There were no replies to the patch series up to now. Sorry

[Qemu-devel] A Question

2011-05-04 Thread Zhenkai Zhang
Hi, guys, I want to emulate some code for ARM7TDMI. Does Qemu support this ARM type? Thank you Zhenkai

Re: [Qemu-devel] [RFC 03/28] target-xtensa: implement disas_xtensa_insn

2011-05-04 Thread Richard Henderson
On 05/03/2011 05:59 PM, Max Filippov wrote: > +static void gen_jump(DisasContext *dc, TCGv dest) > +{ > +tcg_gen_mov_i32(cpu_pc, dest); > +if (dc->singlestep_enabled) { > +gen_exception(EXCP_DEBUG); > +} > +tcg_gen_exit_tb(0); > +dc->is_jmp = DISAS_UPDATE; You're genera

[Qemu-devel] [PATCH 01/14] usb-linux: introduce a usb_linux_alt_setting function

2011-05-04 Thread Gerd Hoffmann
From: Hans de Goede The next patch in this series introduces multiple ways to get the alt setting dependent upon usb_fs_type, it is cleaner to put this into its own function. Note that this patch also changes the assumed alt setting in case of an error getting the alt setting to be 0 (a sane def

[Qemu-devel] [PULL] usb patch queue

2011-05-04 Thread Gerd Hoffmann
Hi, The USB patch queue is back! I'm still busy catching up with the backlog, I know I didn't pick up everything from the list yet. If in doubt it doesn't hurt to resend usb related patches, with me being Cc'ed. This pull brings old stuff, most of the patches are several months old already.

[Qemu-devel] [PATCH 02/14] usb-linux: Get the alt. setting from sysfs rather then asking the dev

2011-05-04 Thread Gerd Hoffmann
From: Hans de Goede At least one device I have lies when receiving a USB_REQ_GET_INTERFACE, always returning 0 even if the alternate setting is different. This is likely caused because in practice this control message is never used as the operating system's usb stack knows which alternate setting

[Qemu-devel] [PATCH 03/14] usb-linux: Add support for buffering iso usb packets

2011-05-04 Thread Gerd Hoffmann
From: Hans de Goede Currently we are submitting iso packets to the host one at a time, as we receive them from the emulated host controller. This has 2 problems: 1) If we were fast enough to submit every packet in time for the next host host controller usb frame, we would be generating 1000 hardw

[Qemu-devel] [PATCH 07/14] usb-linux: Add support for buffering iso out usb packets

2011-05-04 Thread Gerd Hoffmann
From: Hans de Goede Extend the iso buffering code to also buffer iso out packets, this fixes for example using usb speakers with usb redirection. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- usb-linux.c | 152 +++ 1 fil

[Qemu-devel] [PATCH 04/14] usb-linux: Refuse packets for endpoints which are not in the usb descriptor

2011-05-04 Thread Gerd Hoffmann
From: Hans de Goede If an endpoint is not in the usb descriptor we've no idea what kind of endpoint it is and thus how to handle it, refuse packages in this case. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- usb-linux.c | 13 + 1 files changed, 13 insertions(+),

[Qemu-devel] [PATCH 11/14] ohci: get ohci state via container_of()

2011-05-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb-ohci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb-ohci.c b/hw/usb-ohci.c index 0ad4f55..7678cdb 100644 --- a/hw/usb-ohci.c +++ b/hw/usb-ohci.c @@ -577,7 +577,7 @@ static void ohci_process_lists(OHCIState *ohci, int com

[Qemu-devel] [PATCH 05/14] usb-linux: Refuse iso packets when max packet size is 0 (alt setting 0)

2011-05-04 Thread Gerd Hoffmann
From: Hans de Goede Refuse iso usb packets when then max packet size for the endpoint is 0, this avoids an abort in usb_host_alloc_iso() caused by trying to qemu_malloc a 0 bytes large buffer. Signed-off-by: Gerd Hoffmann --- usb-linux.c |6 +- 1 files changed, 5 insertions(+), 1 delet

[Qemu-devel] [PATCH 10/14] uhci: keep uhci state pointer in async packet struct.

2011-05-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb-uhci.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index 2de0cf2..2b63b3f 100644 --- a/hw/usb-uhci.c +++ b/hw/usb-uhci.c @@ -106,6 +106,8 @@ static void dump_data(const uint8_t *data, int

[Qemu-devel] [PATCH 06/14] usb-linux: We only need to keep track of 15 endpoints

2011-05-04 Thread Gerd Hoffmann
From: Hans de Goede Currently we reserve room for endpoint data for 16 endpoints, but given that we only use endpoint data for endpoints 1-15, and always index the array with the endpoint-number - 1, 15 is enough. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- usb-linux.c |

[Qemu-devel] [PATCH 09/14] uhci: switch to QTAILQ

2011-05-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb-uhci.c | 63 +--- 1 files changed, 15 insertions(+), 48 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index 346db3e..2de0cf2 100644 --- a/hw/usb-uhci.c +++ b/hw/usb-uhci.c @@ -113,7 +113,7 @@

[Qemu-devel] [PATCH 12/14] musb: get musb state via container_of()

2011-05-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb-musb.c | 54 ++ 1 files changed, 34 insertions(+), 20 deletions(-) diff --git a/hw/usb-musb.c b/hw/usb-musb.c index 15bc549..30148e7 100644 --- a/hw/usb-musb.c +++ b/hw/usb-musb.c @@ -267,7 +267,16 @@

[Qemu-devel] [PATCH 08/14] usb: control buffer fixes

2011-05-04 Thread Gerd Hoffmann
From: Hans de Goede Windows allows control transfers to pass up to 4k of data, so raise our control buffer size to 4k. For control out transfers the usb core code copies the control request data to a buffer before calling the device's handle_control callback. Add a check for overflowing the buffe

Re: [Qemu-devel] [RFC 08/28] target-xtensa: implement conditional jumps

2011-05-04 Thread Richard Henderson
On 05/03/2011 05:59 PM, Max Filippov wrote: > +int label = gen_new_label(); > +int inv = BRI12_M & 1; > + > +switch (BRI12_M & 2) { > +case 0: /*BEQZ*/ > +tcg_gen_brcondi_i32(inv ? TCG_COND_EQ : TCG_COND_NE, > +

[Qemu-devel] [PATCH 14/14] usb: mass storage fix

2011-05-04 Thread Gerd Hoffmann
Initialize scsi_len with zero when starting a new request, so any stuff leftover from the previous request is cleared out. This may happen in case the data returned by the scsi command doesn't fit into the buffer provided by the guest. Signed-off-by: Gerd Hoffmann --- hw/usb-msd.c |1 + 1 f

[Qemu-devel] [PATCH 13/14] usb: move complete callback to port ops

2011-05-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb-hub.c | 14 ++ hw/usb-msd.c |4 ++-- hw/usb-musb.c | 27 +-- hw/usb-ohci.c |7 ++- hw/usb-uhci.c |7 +++ hw/usb.h |7 +++ usb-linux.c |2 +- 7 files changed, 34 insertions(+),

Re: [Qemu-devel] A Question

2011-05-04 Thread Peter Maydell
On 4 May 2011 16:26, Zhenkai Zhang wrote: > I want to emulate some code for ARM7TDMI. Does Qemu support this ARM type? No, we don't emulate an ARM7TDMI. However depending on what your code does it's possible that you might be able to get away with using the ARM926 model. If you want to emulate a

Re: [Qemu-devel] [RFC 11/28] target-xtensa: implement RST3 group

2011-05-04 Thread Richard Henderson
On 05/03/2011 05:59 PM, Max Filippov wrote: > +case 2: /*SEXTu*/ > +HAS_OPTION(XTENSA_OPTION_MISC_OP); > +{ > +TCGv_i32 tmp = tcg_temp_new_i32(); > +tcg_gen_shli_i32(tmp, cpu_R[RRR_S], 24 - RRR_T); > +

Re: [Qemu-devel] s390x kvm and smp

2011-05-04 Thread Christian Borntraeger
On 04/05/11 12:59, Jan Kiszka wrote: > s390 just need to return a meaningful value from > kvm_arch_process_async_events, e.g. env->halted, see other archs. Yes indeed. This patch fixes smp for kvm on s390x. Signed-off-by: Christian Borntraeger --- a/target-s390x/kvm.c +++ b/target-s390x/kvm.c @

Re: [Qemu-devel] [RFC 12/28] target-xtensa: implement shifts (ST1 and RST1 groups)

2011-05-04 Thread Richard Henderson
On 05/03/2011 05:59 PM, Max Filippov wrote: > +HAS_OPTION(XTENSA_OPTION_MISC_OP); > +{ > +#define gen_bit_bisect(w) do { \ > +int label = gen_new_label(); \ > +tcg_gen_brcondi_i32(TCG_COND_LTU, tmp, 1 << (w), label); \ > +tcg_gen_shri_

Re: [Qemu-devel] [RFC 18/28] target-xtensa: implement exceptions

2011-05-04 Thread Richard Henderson
On 05/03/2011 05:59 PM, Max Filippov wrote: > +static void gen_check_privilege(DisasContext *dc) > +{ > +if (option_enabled(dc, XTENSA_OPTION_MMU)) { > +TCGv_i32 tmp = tcg_temp_new_i32(); > +int label = gen_new_label(); > + > +tcg_gen_andi_i32(tmp, cpu_SR[PS], PS_EXCM);

Re: [Qemu-devel] [RFC 12/28] target-xtensa: implement shifts (ST1 and RST1 groups)

2011-05-04 Thread Max Filippov
>> +                    HAS_OPTION(XTENSA_OPTION_MISC_OP); >> +                    { >> +#define gen_bit_bisect(w) do { \ >> +        int label = gen_new_label(); \ >> +        tcg_gen_brcondi_i32(TCG_COND_LTU, tmp, 1 << (w), label); \ >> +        tcg_gen_shri_i32(tmp, tmp, (w)); \ >> +        tcg_

Re: [Qemu-devel] [RFC 18/28] target-xtensa: implement exceptions

2011-05-04 Thread Richard Henderson
On 05/04/2011 09:33 AM, Richard Henderson wrote: > This is a case where you almost certainly want to check this > condition inside QEMU and translate the opcode differently. > > See cpu_get_tb_cpu_state, which sets bits in *flags. These > flags can then be checked in tb->flags while translating.

Re: [Qemu-devel] s390x kvm and smp

2011-05-04 Thread Alexander Graf
Am 04.05.2011 um 18:13 schrieb Christian Borntraeger : > On 04/05/11 12:59, Jan Kiszka wrote: >> s390 just need to return a meaningful value from >> kvm_arch_process_async_events, e.g. env->halted, see other archs. > > Yes indeed. This patch fixes smp for kvm on s390x. > > Signed-off-by: Chr

[Qemu-devel] [Bug 723871] Re: qemu-kvm-0.14.0 Aborts with -vga qxl

2011-05-04 Thread Boris Derzhavets
@Serge, Sorry, but answer is no. I just learned how dh_make and dpkg-buildpackage works , picked up your's debian folder. Updated debian/patches/series and changelog . built new debian package ( based on new qemu-kvm-spice-0.14.0+noroms_0ubuntu4qxl3.orig.tar.gz) due to three recent commits

Re: [Qemu-devel] [PATCH v2] Import Linux headers for KVM and vhost

2011-05-04 Thread Andreas Färber
Am 04.05.2011 um 12:28 schrieb Jan Kiszka: On 2011-05-03 22:22, Peter Maydell wrote: On 3 May 2011 17:48, Jan Kiszka wrote: +++ b/scripts/update-linux-headers.sh +rm -rf $output/include/linux/* Given that updating the kernel headers will blow away large subsets of include/ like this, may

Re: [Qemu-devel] [PATCH v2] Import Linux headers for KVM and vhost

2011-05-04 Thread Jan Kiszka
On 2011-05-04 19:58, Andreas Färber wrote: > Am 04.05.2011 um 12:28 schrieb Jan Kiszka: > >> On 2011-05-03 22:22, Peter Maydell wrote: >>> On 3 May 2011 17:48, Jan Kiszka wrote: +++ b/scripts/update-linux-headers.sh > +rm -rf $output/include/linux/* >>> >>> Given that updating the kern

Re: [Qemu-devel] [PATCH 6/6] PPC: Qdev'ify e500 pci

2011-05-04 Thread Blue Swirl
On Mon, May 2, 2011 at 6:03 PM, Alexander Graf wrote: > The e500 PCI controller isn't qdev'ified yet. This leads to severe issues > when running with -drive. > > To be able to use a virtio disk with an e500 VM, let's convert the PCI > controller over to qdev. > > Signed-off-by: Alexander Graf > >

Re: [Qemu-devel] [PATCH 0/6] PPC: Add FSL (e500) MMU emulation v3

2011-05-04 Thread Blue Swirl
On Mon, May 2, 2011 at 6:03 PM, Alexander Graf wrote: > In a global effort to get rid of KVM-only targets, this is the next > important piece of the puzzle: e500 emulation :). > > We had support for running an e500 KVM guest for a while now, but the > code could not be tested without a real e500 m

Re: [Qemu-devel] [RFC 12/28] target-xtensa: implement shifts (ST1 and RST1 groups)

2011-05-04 Thread Richard Henderson
On 05/04/2011 09:39 AM, Max Filippov wrote: > To track immediate values written to SAR? You mean that there may be > some performance difference of fixed size shift vs indirect shift and > TCG is able to tell them apart? Well, not really fixed vs indirect, but if you know that the value in the SAR

Re: [Qemu-devel] [PATCH] vfio: Fix free in dma mapping error path

2011-05-04 Thread Tom Lyon
On Friday, April 29, 2011 03:05:54 pm Alex Williamson wrote: > This is allocated via vmalloc, so needs vfree, not kfree. > > Signed-off-by: Alex Williamson > --- > > drivers/vfio/vfio_dma.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/vfio/vfio_dma.c b

Re: [Qemu-devel] [PATCH 0/8] cpu interrupt cleanup

2011-05-04 Thread Blue Swirl
On Sun, May 1, 2011 at 1:24 AM, Richard Henderson wrote: > Blue Swirl pointed out that CPU_INTERRUPT_TIMER was unused, > and should therefore be remove.  This is a logical extension > of that, making all target specific cpu interrupts really be > private to the target. > > This will allow new port

Re: [Qemu-devel] [PATCH 0/3]: QMP: Introduce inject-nmi command

2011-05-04 Thread Blue Swirl
On Mon, May 2, 2011 at 6:57 PM, Luiz Capitulino wrote: > On Sat, 30 Apr 2011 09:33:15 +0300 > Blue Swirl wrote: > >> On Sat, Apr 30, 2011 at 1:40 AM, Luiz Capitulino >> wrote: >> > This series introduces the inject-nmi command for QMP, which sends an >> > NMI to _all_ guest's CPUs. >> > >> > Al

Re: [Qemu-devel] [RFC 20/28] target-xtensa: implement windowed registers

2011-05-04 Thread Blue Swirl
On Wed, May 4, 2011 at 3:59 AM, Max Filippov wrote: > See ISA, 4.7.1 for details. > > Physical registers and currently visible window are separate fields in > CPUEnv. Only current window is accessible to TCG. On operations that > change window base helpers copy current window to and from physical

Re: [Qemu-devel] [RFC 19/28] target-xtensa: implement RST2 group (32 bit mul/div/rem)

2011-05-04 Thread Blue Swirl
On Wed, May 4, 2011 at 3:59 AM, Max Filippov wrote: > Signed-off-by: Max Filippov > --- >  target-xtensa/translate.c |   60 > - >  1 files changed, 59 insertions(+), 1 deletions(-) > > diff --git a/target-xtensa/translate.c b/target-xtensa/translate.c

Re: [Qemu-devel] Build breakage on OpenSolaris - softfloat

2011-05-04 Thread Andreas Färber
On 1 May 2011 16:39, Andreas Färber wrote: > Looks like an issue with make_floatx80(). Any ideas? > $ gcc --version > gcc (GCC) 3.4.3 (csl-sol210-3_4-20050802) Hmm. I did a test build on x86 host with gcc 3.3.5 and gcc 3.4.6, which were both OK, so it looks like it might be

Re: [Qemu-devel] [RFC 24/28] target-xtensa: implement SIMCALL

2011-05-04 Thread Blue Swirl
On Wed, May 4, 2011 at 3:59 AM, Max Filippov wrote: > Tensilica iss provides support for applications running in freestanding > environment through SIMCALL command. It is used by Tensilica libc to > access argc/argv, for file I/O, etc. > > Signed-off-by: Max Filippov > --- >  target-xtensa/helper

Re: [Qemu-devel] [RFC 01/28] target-xtensa: add target stubs

2011-05-04 Thread Blue Swirl
On Wed, May 4, 2011 at 3:59 AM, Max Filippov wrote: > Signed-off-by: Max Filippov > --- >  Makefile.target           |    2 + >  arch_init.c               |    2 + >  arch_init.h               |    1 + >  cpu-exec.c                |   10 + >  elf.h                     |    2 + >  hw/xtensa_pi

Re: [Qemu-devel] [RFC 20/28] target-xtensa: implement windowed registers

2011-05-04 Thread Blue Swirl
On Wed, May 4, 2011 at 11:07 PM, Richard Henderson wrote: > On 05/04/2011 12:35 PM, Blue Swirl wrote: >> On Wed, May 4, 2011 at 3:59 AM, Max Filippov wrote: >>> See ISA, 4.7.1 for details. >>> >>> Physical registers and currently visible window are separate fields in >>> CPUEnv. Only current wind

Re: [Qemu-devel] [RFC 20/28] target-xtensa: implement windowed registers

2011-05-04 Thread Richard Henderson
On 05/04/2011 12:35 PM, Blue Swirl wrote: > On Wed, May 4, 2011 at 3:59 AM, Max Filippov wrote: >> See ISA, 4.7.1 for details. >> >> Physical registers and currently visible window are separate fields in >> CPUEnv. Only current window is accessible to TCG. On operations that >> change window base

Re: [Qemu-devel] [RFC 20/28] target-xtensa: implement windowed registers

2011-05-04 Thread Richard Henderson
On 05/04/2011 01:13 PM, Blue Swirl wrote: >> Sparc loses out on some TCG optimizations because of that, although >> to be fair the most effective of these are still in Aurlien's trees. > > Interesting. Which optimizations? What trees? How would you implement > the register windows then? Constant

Re: [Qemu-devel] [RFC 24/28] target-xtensa: implement SIMCALL

2011-05-04 Thread Peter Maydell
On 4 May 2011 20:48, Blue Swirl wrote: > On Wed, May 4, 2011 at 3:59 AM, Max Filippov wrote: >> Tensilica iss provides support for applications running in freestanding >> environment through SIMCALL command. It is used by Tensilica libc to >> access argc/argv, for file I/O, etc. >> >> Signed-off-

[Qemu-devel] [PATCH 0/8] cpu interrupt cleanup, v2

2011-05-04 Thread Richard Henderson
v1->v2 Rebase vs HEAD (d2d979c) Cleanup whitespace errors. r~ Richard Henderson (8): irq: Introduce CPU_INTERRUPT_TGT_* defines. irq: Introduce and use CPU_INTERRUPT_SSTEP_MASK. target-mips: Do not check CPU_INTERRUPT_TIMER. target-sparc: Do not check CPU_INTERRUPT_TIMER. irq: Remo

[Qemu-devel] [PATCH 1/8] irq: Introduce CPU_INTERRUPT_TGT_* defines.

2011-05-04 Thread Richard Henderson
These defines will be place-holders for cpu-specific functionality. Generic code will, at the end of the patch series, no longer have to concern itself about how SMI, NMI, etc should be handled. Instead, generic code will know only that the interrupt is internal or external. Signed-off-by: Richar

[Qemu-devel] [PATCH 6/8] target-arm: Privatize CPU_INTERRUPT_FIQ.

2011-05-04 Thread Richard Henderson
This interrupt name was only used by the ARM port. Signed-off-by: Richard Henderson --- cpu-all.h|1 - poison.h |1 - target-arm/cpu.h |4 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/cpu-all.h b/cpu-all.h index a30943f..b1305db 100644 --- a/cpu

[Qemu-devel] [PATCH 7/8] target-i386: Privatize some i386-specific interrupt names.

2011-05-04 Thread Richard Henderson
SMI, VIRQ, INIT, SIPI, and MCE are all only used by the i386 port. Signed-off-by: Richard Henderson --- cpu-all.h |5 - poison.h |2 -- target-i386/cpu.h |8 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/cpu-all.h b/cpu-all.h index b1305

[Qemu-devel] [PATCH 4/8] target-sparc: Do not check CPU_INTERRUPT_TIMER.

2011-05-04 Thread Richard Henderson
This bit is never set, therefore we should not read it either. Signed-off-by: Richard Henderson --- cpu-exec.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/cpu-exec.c b/cpu-exec.c index 5b42b25..6d43726 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@ -489,9 +489,6 @@ in

[Qemu-devel] [PATCH 3/8] target-mips: Do not check CPU_INTERRUPT_TIMER.

2011-05-04 Thread Richard Henderson
This bit is never set, therefore we should not read it either. Signed-off-by: Richard Henderson --- target-mips/exec.h |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/target-mips/exec.h b/target-mips/exec.h index b3c5a13..607edf1 100644 --- a/target-mips/exec.h +++ b/

[Qemu-devel] [PATCH 5/8] irq: Remove CPU_INTERRUPT_TIMER.

2011-05-04 Thread Richard Henderson
It is no longer used anywhere. Signed-off-by: Richard Henderson --- cpu-all.h |1 - poison.h |1 - 2 files changed, 0 insertions(+), 2 deletions(-) diff --git a/cpu-all.h b/cpu-all.h index bc0dad8..a30943f 100644 --- a/cpu-all.h +++ b/cpu-all.h @@ -828,7 +828,6 @@ extern CPUState *cpu_

  1   2   >