[Qemu-devel] Re: [PATCH v2 1/2] cdrom: Allow the TEST_UNIT_READY command after a cdrom change

2011-04-07 Thread Paolo Bonzini
On 04/07/2011 07:05 AM, Amit Shah wrote: We restrict the commands that a guest can send us after a cdrom change event. The current list includes REQUEST_SENSE and INQUIRY commands. Guests can also issue TEST_UNIT_READY to inquire for the status, so allow this command as well. Signed-off-by: Ami

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-07 Thread Jan Kiszka
On 2011-04-06 21:34, Anthony Liguori wrote: > On 04/06/2011 02:27 PM, Peter Maydell wrote: >>> Right, but honestly speaking, I don't know how this works for other arches. >>> >>> So, the best thing to do is to have a general design that can be used >>> by any architecture. Of course that we can als

[Qemu-devel] Re: [PATCH] configure: add --version flag

2011-04-07 Thread Paolo Bonzini
On 04/07/2011 07:12 AM, Mike Frysinger wrote: Standard autoconf scripts include a --version flag so people can easily query things. Add this to qemu's configure so it too can integrate with build systems that have standard autotool helpers. Signed-off-by: Mike Frysinger ACK Paolo

[Qemu-devel] Re: [PATCH v2 2/2] cdrom: Make disc change event visible to guests

2011-04-07 Thread Paolo Bonzini
On 04/07/2011 07:05 AM, Amit Shah wrote: Commit 93c8cfd9e67a62711b86f4c93747566885eb7928 tried to send a 'no disc' event after a cdrom change so that guests notice a cd change event between two 'cd present' states. However, we don't go from 'cd present' -> 'no cd' -> 'cd present' as the SE

[Qemu-devel] Re: [PATCH v2 2/2] cdrom: Make disc change event visible to guests

2011-04-07 Thread Amit Shah
On (Thu) 07 Apr 2011 [09:31:05], Paolo Bonzini wrote: > On 04/07/2011 07:05 AM, Amit Shah wrote: > >Commit 93c8cfd9e67a62711b86f4c93747566885eb7928 tried to send a 'no > >disc' event after a cdrom change so that guests notice a cd change event > >between two 'cd present' states. However, we don't

[Qemu-devel] How does the QEMU load the binary files bios.bin and vgabios-cirrus.bin?

2011-04-07 Thread Bei Guan
Hi, I have some questions about the qemu's bios. How does the QEMU load the binary files bios.bin and vgabios-cirrus.bin? Which function or code file need I to pay more attention to? For the loading of vgabios-cirrus.bin and bios.bin, I just trace them into the same funciton rom_add_file() in hw/

Re: [Qemu-devel] [PATCH] hw: improve multiboot module loading

2011-04-07 Thread Alexander Graf
On 07.04.2011, at 07:56, Ralf Ramsauer wrote: > Here the version with the correct coding style. Phew - please keep the commit message intact. What we do to apply patches is that we simply directly take your patch into git using "git am". With a patch description like this, if anyone looks at "

[Qemu-devel] Re: [PATCH v2 2/2] cdrom: Make disc change event visible to guests

2011-04-07 Thread Stefan Hajnoczi
On Thu, Apr 07, 2011 at 10:35:19AM +0530, Amit Shah wrote: > + /* > + * First, check if there's any pending media change > + * notification to be given. > + * > + * We want the guest to notice an empty tray between a cd > + * change, so send one

Re: [Qemu-devel] [PATCH 1/5] ppce500_mpc8544ds: Fix compile with --enable-debug and --disable-kvm

2011-04-07 Thread Alexander Graf
On 07.04.2011, at 05:02, David Gibson wrote: > From: Alexey Kardashevskiy > > When configured with --enable-debug, the makefile does not use any > optimization and compilation of hw/ppce500_mpc8544ds.c fails because gcc > does not remove the never called without kvm function > mpc8544_copy_soc_

[Qemu-devel] Re: [PATCH v2 1/2] cdrom: Allow the TEST_UNIT_READY command after a cdrom change

2011-04-07 Thread Stefan Hajnoczi
On Thu, Apr 07, 2011 at 10:35:18AM +0530, Amit Shah wrote: > @@ -1105,10 +1105,11 @@ static void ide_atapi_cmd(IDEState *s) > /* If there's a UNIT_ATTENTION condition pending, only > REQUEST_SENSE and INQUIRY commands are allowed to complete. */ > if (s->sense_key == SENSE_UNIT_AT

Re: [Qemu-devel] [PATCH] virtio-blk: fail unaligned requests

2011-04-07 Thread Stefan Hajnoczi
On Wed, Apr 06, 2011 at 08:28:34PM +0200, Christoph Hellwig wrote: > Like all block drivers virtio-blk should not allow small than block size > granularity access. But given that the protocol specifies a > byte unit length field we currently accept such requests, which cause > qemu to abort() in

Re: [Qemu-devel] [PATCH] hw: improve multiboot module loading

2011-04-07 Thread Stefan Hajnoczi
On Thu, Apr 07, 2011 at 12:19:01AM -, r...@humppa.name wrote: > @@ -267,6 +267,9 @@ int load_multiboot(void *fw_cfg, > /* if a space comes after the module filename, treat everything > after that as parameters */ > target_phys_addr_t c = mb_add_cmdline(

[Qemu-devel] [PATCH v3 1/2] cdrom: Allow the TEST_UNIT_READY command after a cdrom change

2011-04-07 Thread Amit Shah
We restrict the commands that a guest can send us after a cdrom change event. The current list includes REQUEST_SENSE and INQUIRY commands. Guests can also issue TEST_UNIT_READY to inquire for the status, so allow this command as well. This also gets rid of one cause of the HSM violation errors i

[Qemu-devel] Re: [PATCH v2 1/2] cdrom: Allow the TEST_UNIT_READY command after a cdrom change

2011-04-07 Thread Amit Shah
On (Thu) 07 Apr 2011 [09:42:30], Stefan Hajnoczi wrote: > On Thu, Apr 07, 2011 at 10:35:18AM +0530, Amit Shah wrote: > > @@ -1105,10 +1105,11 @@ static void ide_atapi_cmd(IDEState *s) > > /* If there's a UNIT_ATTENTION condition pending, only > > REQUEST_SENSE and INQUIRY commands are

[Qemu-devel] [PATCH v3 0/2] Correct transitions for cd change state

2011-04-07 Thread Amit Shah
Hello, These two patches fix the cd media size change bugs. The test scenario is: 1. create an iso image from a file 2. create a second iso image from a bigger file 3. mount 1st cd in guest 4. unmount it 5. change cd via qemu monitor 6. mount 2nd cd 7. copy file on cd to local disk -- shows erro

[Qemu-devel] [PATCH v3 2/2] cdrom: Make disc change event visible to guests

2011-04-07 Thread Amit Shah
Commit 93c8cfd9e67a62711b86f4c93747566885eb7928 sent a 'no disc' event after a cdrom change so that guests notice a cd change event between two 'cd present' states. However, we don't follow the 2nd arrow in: 'cd present' -> 'no cd' -> 'cd present' as the SENSE_UNIT_ATTENTION sense_key is writte

Re: [Qemu-devel] [PATCH 1/5] ppce500_mpc8544ds: Fix compile with --enable-debug and --disable-kvm

2011-04-07 Thread Alexey Kardashevskiy
On 07.04.2011 18:42, Alexander Graf wrote: On 07.04.2011, at 05:02, David Gibson wrote: From: Alexey Kardashevskiy When configured with --enable-debug, the makefile does not use any optimization and compilation of hw/ppce500_mpc8544ds.c fails because gcc does not remove the never called withou

[Qemu-devel] Re: [PATCH v2 2/2] rbd: allow configuration of rados from the rbd filename

2011-04-07 Thread Stefan Hajnoczi
On Thu, Apr 07, 2011 at 10:14:03AM +0900, Yoshiaki Tamura wrote: > 2011/3/29 Josh Durgin : > > The new format is > > rbd:pool/image[@snapshot][:option1=value1[:option2=value2...]] > > Each option is used to configure rados, and may be any Ceph option, or > > "conf". > > The "conf" option specifie

Re: [Qemu-devel] Assorted trivial bugfixes

2011-04-07 Thread Stefan Hajnoczi
On Thu, Apr 07, 2011 at 01:02:00PM +1000, David Gibson wrote: > This series contains 5 essentially unrelated trivial bugfixes for qemu > code. Most are aimed at eventually getting virtio devices working on > the pseries target, the others are just annoying build bugs. Thanks, patches 2-4 are in t

[Qemu-devel] Re: [PATCH v2 2/2] cdrom: Make disc change event visible to guests

2011-04-07 Thread Amit Shah
On (Thu) 07 Apr 2011 [09:41:09], Stefan Hajnoczi wrote: > On Thu, Apr 07, 2011 at 10:35:19AM +0530, Amit Shah wrote: > > + /* > > +* First, check if there's any pending media change > > +* notification to be given. > > +* > > +* We want the guest to notice an e

Re: [Qemu-devel] Re: [PATCH] configure: add --version flag

2011-04-07 Thread Edgar E. Iglesias
On Thu, Apr 07, 2011 at 09:31:24AM +0200, Paolo Bonzini wrote: > On 04/07/2011 07:12 AM, Mike Frysinger wrote: > > Standard autoconf scripts include a --version flag so people can easily > > query things. Add this to qemu's configure so it too can integrate with > > build systems that have standar

[Qemu-devel] Re: [PATCH v2 1/2] cdrom: Allow the TEST_UNIT_READY command after a cdrom change

2011-04-07 Thread Kevin Wolf
Am 07.04.2011 07:05, schrieb Amit Shah: > We restrict the commands that a guest can send us after a cdrom change > event. The current list includes REQUEST_SENSE and INQUIRY commands. > Guests can also issue TEST_UNIT_READY to inquire for the status, so > allow this command as well. > > Signed-of

[Qemu-devel] HELLO

2011-04-07 Thread Anita Abdul
I am writing this letter out of a genuine desperation to find a reliable partner in an unfolding transaction. I seek your help and genuine co-operation to our mutual benefit and I believe that you will not letdown the trust and confidence I am about to repose on you. I am Anita, Purchasi

Re: [Qemu-devel] [PATCH 1/5] ppce500_mpc8544ds: Fix compile with --enable-debug and --disable-kvm

2011-04-07 Thread Alexander Graf
On 07.04.2011, at 10:52, Alexey Kardashevskiy wrote: > On 07.04.2011 18:42, Alexander Graf wrote: >> On 07.04.2011, at 05:02, David Gibson wrote: >> >>> From: Alexey Kardashevskiy >>> >>> When configured with --enable-debug, the makefile does not use any >>> optimization and compilation of hw/p

[Qemu-devel] Re: [PATCH v2 1/2] cdrom: Allow the TEST_UNIT_READY command after a cdrom change

2011-04-07 Thread Amit Shah
On (Thu) 07 Apr 2011 [10:59:20], Kevin Wolf wrote: > Am 07.04.2011 07:05, schrieb Amit Shah: > > We restrict the commands that a guest can send us after a cdrom change > > event. The current list includes REQUEST_SENSE and INQUIRY commands. > > Guests can also issue TEST_UNIT_READY to inquire for

[Qemu-devel] Re: [PATCH v3 0/2] Correct transitions for cd change state

2011-04-07 Thread Stefan Hajnoczi
Windows Server 2003 works - media change is detected and size is updated correctly. Tested-by: Stefan Hajnoczi

[Qemu-devel] Re: [PATCH v3 0/2] Correct transitions for cd change state

2011-04-07 Thread Paolo Bonzini
On 04/07/2011 10:46 AM, Amit Shah wrote: Hello, These two patches fix the cd media size change bugs. The test scenario is: 1. create an iso image from a file 2. create a second iso image from a bigger file 3. mount 1st cd in guest 4. unmount it 5. change cd via qemu monitor 6. mount 2nd cd 7.

Re: [Qemu-devel] KVM call agenda for April 05

2011-04-07 Thread Harsh Bora
On 04/06/2011 02:00 AM, Anthony Liguori wrote: On 04/05/2011 03:25 PM, Peter Maydell wrote: On 5 April 2011 14:14, Stefan Hajnoczi wrote: This stems from the fact that development is centered around the mailing list. Some folks have put technical documentation on the wiki but a lot simply happe

[Qemu-devel] Re: [PATCH v2 2/2] rbd: allow configuration of rados from the rbd filename

2011-04-07 Thread Yoshiaki Tamura
2011/4/7 Stefan Hajnoczi : > On Thu, Apr 07, 2011 at 10:14:03AM +0900, Yoshiaki Tamura wrote: >> 2011/3/29 Josh Durgin : >> > The new format is >> > rbd:pool/image[@snapshot][:option1=value1[:option2=value2...]] >> > Each option is used to configure rados, and may be any Ceph option, or >> > "con

Re: [Qemu-devel] KVM call minutes for Apr 5

2011-04-07 Thread Stefan Hajnoczi
On Tue, Apr 5, 2011 at 6:37 PM, Lucas Meneghel Rodrigues wrote: Thanks for your detailed response! > On Tue, 2011-04-05 at 16:29 +0100, Stefan Hajnoczi wrote: >> * Public notifications of breakage, qemu.git/master failures to >> qemu-devel mailing list. > > ^ The challenge is to get enough data

Re: [Qemu-devel] GSoC 2011: S3 Trio, AHCI

2011-04-07 Thread Alon Levy
On Wed, Apr 06, 2011 at 11:54:47PM +0100, Paul Brook wrote: > > > Last year, I was also interested in working on S3 Trio emulation. This > > > year, the same idea is on the ideas list. The hardware is pretty > > > thoroughly documented through source code and textual documentation, and > > > I'm al

Re: [Qemu-devel] How long does it normally take patches to make their way into git?

2011-04-07 Thread Stefano Stabellini
On Wed, 6 Apr 2011, Stefan Hajnoczi wrote: > On Wed, Apr 6, 2011 at 3:59 PM, John Haxby wrote: > > Hello, > > > > How long does it normally take patches to make their way into git?  I > > only ask because > > > >  [PATCH 1/2][REPOST] Introduce a new 'connected' xendev op called when > > Connected.

Re: [Qemu-devel] GSoC 2011: S3 Trio, AHCI

2011-04-07 Thread Alon Levy
On Wed, Apr 06, 2011 at 11:54:47PM +0100, Paul Brook wrote: > > > Last year, I was also interested in working on S3 Trio emulation. This > > > year, the same idea is on the ideas list. The hardware is pretty > > > thoroughly documented through source code and textual documentation, and > > > I'm al

Re: [Qemu-devel] [PATCH] hw: improve multiboot module loading

2011-04-07 Thread Ralf Ramsauer
Leading spaces mustn't be stripped! The commandline could look like: qemu -kernel kern -initrd "1.mod arg=foo arg2=bar, 2.mod arg=asdf" The problem is, that the string "1.mod arg=foo arg2=bar, 2.mod arg=asdf" is divided at the ','. So we have two string "1.mod arg=foo arg2=bar" and " 2.mod arg=asdf

[Qemu-devel] Re: [PATCH v2 1/2] cdrom: Allow the TEST_UNIT_READY command after a cdrom change

2011-04-07 Thread Kevin Wolf
Am 07.04.2011 11:11, schrieb Amit Shah: > On (Thu) 07 Apr 2011 [10:59:20], Kevin Wolf wrote: >> Am 07.04.2011 07:05, schrieb Amit Shah: >>> We restrict the commands that a guest can send us after a cdrom change >>> event. The current list includes REQUEST_SENSE and INQUIRY commands. >>> Guests can

[Qemu-devel] [PATCH 0/5] kvm/vhost: enable durty logging during memory registration

2011-04-07 Thread Michael S. Tsirkin
I've tested and applied this patchset on my tree. Currently, vga cards that allocate vga ram, register it as regular ram, and then request dirty logging from kvm (which is required for this hack to function correctly). Both these operations involve memory slot update and flush in kvm and in vhost

[Qemu-devel] [PATCH 3/5] vhost: skip memory which needs dirty logging

2011-04-07 Thread Michael S. Tsirkin
vhost doesn't support write logging (except for migration), anyway. Signed-off-by: Michael S. Tsirkin --- hw/vhost.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/vhost.c b/hw/vhost.c index dc3d0e2..257e3dd 100644 --- a/hw/vhost.c +++ b/hw/vhost.c @@ -311,6 +311,

[Qemu-devel] [PATCH 1/5] cpu: add set_memory flag to request dirty logging

2011-04-07 Thread Michael S. Tsirkin
Pass the flag to all cpu notifiers, doing nothing at this point. Will be used by follow-up patches. Signed-off-by: Michael S. Tsirkin --- cpu-common.h | 22 +- exec.c | 14 -- hw/vhost.c |3 ++- kvm-all.c|3 ++- 4 files changed, 29 insertio

[Qemu-devel] [PATCH 2/5] kvm: halve number of set memory calls for vga

2011-04-07 Thread Michael S. Tsirkin
use the new api to reduce the number of these (expensive) system calls. Note: using this API, we should be able to get rid of vga_dirty_log_xxx APIs. Using them doesn't affect the performance though because we detects the log_dirty flag set and ignores the call. Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PATCH 5/5] cirrus_vga: flag on-device ram for dirty logging

2011-04-07 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- hw/cirrus_vga.c | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index bdf4c8b..7212849 100644 --- a/hw/cirrus_vga.c +++ b/hw/cirrus_vga.c @@ -2489,7 +2489,9 @@ static void map_linear_v

Re: [Qemu-devel] GSoC 2011: S3 Trio, AHCI

2011-04-07 Thread Natalia Portillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Roland, El 05/04/2011, a las 14:36, Roland Elek escribió: > Dear Qemu developers, > > First, I'd like to reintroduce myself, as my university and official duties > prevented me from being active in the community since last year. I am Roland >

[Qemu-devel] [PATCH 4/5] vhost: optimize out no-change assignment

2011-04-07 Thread Michael S. Tsirkin
Cirrus VGA (at least) calls register memory region with the same values again and again. The registration in vhost-net slows this a lot, optimize by checking that the same data is already registered. Signed-off-by: Michael S. Tsirkin --- hw/vhost.c | 54

[Qemu-devel] Re: [PATCH v2 1/2] cdrom: Allow the TEST_UNIT_READY command after a cdrom change

2011-04-07 Thread Amit Shah
On (Thu) 07 Apr 2011 [12:20:16], Kevin Wolf wrote: > Am 07.04.2011 11:11, schrieb Amit Shah: > > On (Thu) 07 Apr 2011 [10:59:20], Kevin Wolf wrote: > >> Am 07.04.2011 07:05, schrieb Amit Shah: > >>> We restrict the commands that a guest can send us after a cdrom change > >>> event. The current lis

Re: [Qemu-devel] [PATCH] hw: improve multiboot module loading

2011-04-07 Thread Ralf Ramsauer
On 07.04.2011 um 10:38, Alexander Graf wrote: > > Also, I just realized that you did miss another small part that needs change. > A few lines above, there is code to interpret the modules right before that > as well: > >if (initrd_filename) { >const char *r = initrd_filename; >

Re: [Qemu-devel] GSoC 2011: S3 Trio, AHCI

2011-04-07 Thread Alexander Graf
On 07.04.2011, at 12:57, Natalia Portillo wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Hi Roland, > > El 05/04/2011, a las 14:36, Roland Elek escribió: > >> Dear Qemu developers, >> >> First, I'd like to reintroduce myself, as my university and official duties >> prevented

Re: [Qemu-devel] [PATCH] hw: improve multiboot module loading

2011-04-07 Thread Alexander Graf
On 07.04.2011, at 14:07, Ralf Ramsauer wrote: > On 07.04.2011 um 10:38, Alexander Graf wrote: >> >> Also, I just realized that you did miss another small part that needs >> change. A few lines above, there is code to interpret the modules right >> before that as well: >> >> if (initrd_filen

Re: [Qemu-devel] [PATCH] hw: improve multiboot module loading

2011-04-07 Thread Ralf Ramsauer
Hello again, there's another problem with parsing the initrd string: If you want to start qemu with ... -initrd "mod1 arg=foo,bar , mod2 arg=bar,foo" it won't work The string is separated at every comma, arguments containing a comma are misinterpreted. So we'd think about another way deliverin

Re: [Qemu-devel] [PATCH] hw: improve multiboot module loading

2011-04-07 Thread Stefan Hajnoczi
Out of curiousity, why are you trying to kill spaces at all? Why not just use a correct command-line to invoke QEMU? Stefan

Re: [Qemu-devel] [PATCH] hw: improve multiboot module loading

2011-04-07 Thread Ralf Ramsauer
On 07.04.2011, at 14:48, Stefan Hajnoczi wrote: > Out of curiousity, why are you trying to kill spaces at all? > > Why not just use a correct command-line to invoke QEMU? > > Stefan Well it took me 2 days to find out why -initrd "module1, module2" didn't work. If there's a space after the comm

Re: [Qemu-devel] GSoC 2011: S3 Trio, AHCI

2011-04-07 Thread Anthony Liguori
On 04/06/2011 05:54 PM, Paul Brook wrote: Last year, I was also interested in working on S3 Trio emulation. This year, the same idea is on the ideas list. The hardware is pretty thoroughly documented through source code and textual documentation, and I'm already familiar with adding PCI devices t

[Qemu-devel] [Bug 732155] Re: system_reset doesn't work with qemu-kvm and latest SeaBIOS

2011-04-07 Thread Stefan Essl
qemu 0.12 and newer reboot of FreeBSD (m0n0wall.vmdk http://m0n0.ch/wall/ ) fails. The Server (IBM xSeries 206), on which i found this "problem", has no kvm support... finally i decided not to use the IBM server [it is awfully slow when booting, although ubuntu server is really fast available

Re: [Qemu-devel] How does the QEMU load the binary files bios.bin and vgabios-cirrus.bin?

2011-04-07 Thread Anthony Liguori
On 04/07/2011 03:22 AM, Bei Guan wrote: Hi, I have some questions about the qemu's bios. How does the QEMU load the binary files bios.bin and vgabios-cirrus.bin? Which function or code file need I to pay more attention to? For the loading of vgabios-cirrus.bin and bios.bin, I just trace them

Re: [Qemu-devel] [PATCH] hw: improve multiboot module loading

2011-04-07 Thread Stefan Hajnoczi
On Thu, Apr 7, 2011 at 1:56 PM, Ralf Ramsauer wrote: > On 07.04.2011, at 14:48, Stefan Hajnoczi wrote: > >> Out of curiousity, why are you trying to kill spaces at all? >> >> Why not just use a correct command-line to invoke QEMU? >> >> Stefan > > Well it took me 2 days to find out why -initrd "mo

Re: [Qemu-devel] [PATCH] virtio-blk: fail unaligned requests

2011-04-07 Thread Kevin Wolf
Am 06.04.2011 20:28, schrieb Christoph Hellwig: > Like all block drivers virtio-blk should not allow small than block size > granularity access. But given that the protocol specifies a > byte unit length field we currently accept such requests, which cause > qemu to abort() in lower layers. Add

[Qemu-devel] [GIT PULL] Trivial patches for 6-7 April 2011

2011-04-07 Thread Stefan Hajnoczi
The following changes since commit 3b8e6a2db1946b5f21e69fde31b39f43367f1928: exec: Handle registrations of the entire address space (2011-04-07 10:53:41 +0200) are available in the git repository at: git://repo.or.cz/qemu/stefanha.git trivial-patches Alexey Kardashevskiy (3): spapr_ll

[Qemu-devel] [PULL 00/15] Block patches

2011-04-07 Thread Kevin Wolf
The following changes since commit 3b8e6a2db1946b5f21e69fde31b39f43367f1928: exec: Handle registrations of the entire address space (2011-04-07 10:53:41 +0200) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Avishay Traeger (1): Fix integer overflow

[Qemu-devel] [PATCH 02/15] Do not delete BlockDriverState when deleting the drive

2011-04-07 Thread Kevin Wolf
From: Ryan Harper When removing a drive from the host-side via drive_del we currently have the following path: drive_del qemu_aio_flush() bdrv_close()// zaps bs->drv, which makes any subsequent I/O get // dropped. Works as designed drive_uninit() bdrv_delete() // frees the

[Qemu-devel] [PATCH 06/15] qemu-img rebase: Fix segfault if backing file can't be opened

2011-04-07 Thread Kevin Wolf
bdrv_delete must not be called for a NULL BlockDriverState. Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi --- qemu-img.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 074388c..d9c2c12 100644 --- a/qemu-img.c +++ b/qemu-img

[Qemu-devel] [PATCH 10/15] Set errno=ENOTSUP for attempts to use UNIX sockets on Windows platforms

2011-04-07 Thread Kevin Wolf
From: Nick Thomas Signed-off-by: Nick Thomas Signed-off-by: Kevin Wolf --- qemu-sockets.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/qemu-sockets.c b/qemu-sockets.c index c526324..eda1850 100644 --- a/qemu-sockets.c +++ b/qemu-sockets.c @@ -627,24 +627,28 @@ in

[Qemu-devel] [PATCH 03/15] trace: Trace bdrv_set_locked()

2011-04-07 Thread Kevin Wolf
From: Stefan Hajnoczi It can be handy to know when the guest locks/unlocks the CD-ROM tray. This trace event makes that possible. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block.c |2 ++ trace-events |1 + 2 files changed, 3 insertions(+), 0 deletions(-) diff

[Qemu-devel] [PATCH 05/15] qemu-img: Initial progress printing support

2011-04-07 Thread Kevin Wolf
From: Jes Sorensen This adds the basic infrastructure for supporting progress output on the command line, as well as progress support for qemu-img commands 'rebase' and 'convert'. Signed-off-by: Jes Sorensen Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- Makefile.objs|2 +

[Qemu-devel] [PATCH 12/15] NBD device: Separate out parsing configuration and opening sockets.

2011-04-07 Thread Kevin Wolf
From: Nick Thomas We also change the way the file parameter is parsed so IPv6 IP addresses can be used, e.g.: "drive=nbd:[::1]:5000" Signed-off-by: Nick Thomas Signed-off-by: Kevin Wolf --- block/nbd.c | 157 ++- 1 files changed, 102 in

[Qemu-devel] [PATCH 01/15] hw/xen_disk: ioreq not finished on error

2011-04-07 Thread Kevin Wolf
From: Feiran Zheng Bug fix: routines 'ioreq_runio_qemu_sync' and 'ioreq_runio_qemu_aio' won't call 'ioreq_unmap' or 'ioreq_finish' on errors, leaving ioreq in the blkdev->inflight list and a leak. Signed-off-by: Feiran Zheng Acked-by: Stefano Stabellini Signed-off-by: Kevin Wolf --- hw/xen_d

[Qemu-devel] [PATCH 09/15] NBD library: whitespace changes

2011-04-07 Thread Kevin Wolf
From: Nick Thomas Signed-off-by: Nick Thomas Signed-off-by: Kevin Wolf --- nbd.c | 835 + 1 files changed, 418 insertions(+), 417 deletions(-) diff --git a/nbd.c b/nbd.c index d8ebc42..abe0ecb 100644 --- a/nbd.c +++ b/nbd.c @@ -

[Qemu-devel] [PATCH 15/15] virtio-blk: fail unaligned requests

2011-04-07 Thread Kevin Wolf
From: Christoph Hellwig Like all block drivers virtio-blk should not allow small than block size granularity access. But given that the protocol specifies a byte unit length field we currently accept such requests, which cause qemu to abort() in lower layers. Add checks to the main read and wri

[Qemu-devel] [PATCH 04/15] block: Do not cache device size for removable media

2011-04-07 Thread Kevin Wolf
From: Stefan Hajnoczi The block layer caches the device size to avoid doing lseek(fd, 0, SEEK_END) every time this value is needed. For removable media the device size becomes stale if a new medium is inserted. This patch simply prevents device size caching for removable media. A smarter solut

[Qemu-devel] [PATCH 08/15] ide: consolidate drive_get(IF_IDE)

2011-04-07 Thread Kevin Wolf
From: Isaku Yamahata factor out ide initialization to call drive_get(IF_IDE) Signed-off-by: Isaku Yamahata Signed-off-by: Kevin Wolf --- hw/ide.h |3 +++ hw/ide/core.c | 14 ++ hw/mips_fulong2e.c |9 + hw/mips_malta.c| 10 +- hw/mips_

[Qemu-devel] [PATCH 07/15] exit if -drive specified is invalid instead of ignoring the "wrong" -drive

2011-04-07 Thread Kevin Wolf
From: Michael Tokarev This fixes the problem when qemu continues even if -drive specification is somehow invalid, resulting in a mess. Applicable for both current master and for stable-0.14 (and the same issue exist 0.13 and 0.12 too). The prob can actually be seriuos: when you start guest with

[Qemu-devel] [PATCH 14/15] Fix integer overflow in block migration bandwidth calculation

2011-04-07 Thread Kevin Wolf
From: Avishay Traeger block_mig_state.reads is an int, and multiplying by BLOCK_SIZE yielded a negative number, resulting in a negative bandwidth (running on a 32-bit machine). Change order to avoid. Signed-off-by: Avishay Traeger Signed-off-by: Kevin Wolf --- block-migration.c |2 +- 1

[Qemu-devel] [PATCH 11/15] NBD: Use qemu_socket functions to open TCP and UNIX sockets

2011-04-07 Thread Kevin Wolf
From: Nick Thomas This commit has the side-effect of making the qemu-nbd binary capable of binding to IPv6 addresses. ("-b ::1", for instance). block/nbd.c fails to parse IPv6 IP addresses correctly at this point, but will work over IPv6 when given a hostname. It still works over IPv4 as before.

[Qemu-devel] [PATCH 13/15] floppy: save and restore DIR register

2011-04-07 Thread Kevin Wolf
From: Jason Wang We need to keep DIR register unchanged across migration, but currently it depends on the media_changed flags from block layer. Since we do not save/restore it and the bdrv_open() called in dest node may set the media_changed flag when trying to open floppy image, guest driver may

Re: [Qemu-devel] How does the QEMU load the binary files bios.bin and vgabios-cirrus.bin?

2011-04-07 Thread Gleb Natapov
On Thu, Apr 07, 2011 at 08:28:37AM -0500, Anthony Liguori wrote: > On 04/07/2011 03:22 AM, Bei Guan wrote: > >Hi, > > > >I have some questions about the qemu's bios. How does the QEMU > >load the binary files bios.bin and vgabios-cirrus.bin? Which > >function or code file need I to pay more attenti

Re: [Qemu-devel] How does the QEMU load the binary files bios.bin and vgabios-cirrus.bin?

2011-04-07 Thread Anthony Liguori
On 04/07/2011 10:31 AM, Gleb Natapov wrote: On Thu, Apr 07, 2011 at 08:28:37AM -0500, Anthony Liguori wrote: On 04/07/2011 03:22 AM, Bei Guan wrote: Hi, I have some questions about the qemu's bios. How does the QEMU load the binary files bios.bin and vgabios-cirrus.bin? Which function or code

Re: [Qemu-devel] [PULL 00/15] Block patches

2011-04-07 Thread Anthony Liguori
On 04/07/2011 09:49 AM, Kevin Wolf wrote: The following changes since commit 3b8e6a2db1946b5f21e69fde31b39f43367f1928: exec: Handle registrations of the entire address space (2011-04-07 10:53:41 +0200) Pulled. Thanks. Regards, Anthony Liguori are available in the git repository at:

Re: [Qemu-devel] [GIT PULL] Trivial patches for 6-7 April 2011

2011-04-07 Thread Anthony Liguori
On 04/07/2011 09:15 AM, Stefan Hajnoczi wrote: The following changes since commit 3b8e6a2db1946b5f21e69fde31b39f43367f1928: exec: Handle registrations of the entire address space (2011-04-07 10:53:41 +0200) are available in the git repository at: git://repo.or.cz/qemu/stefanha.git trivia

Re: [Qemu-devel] How does the QEMU load the binary files bios.bin and vgabios-cirrus.bin?

2011-04-07 Thread Gleb Natapov
On Thu, Apr 07, 2011 at 10:42:56AM -0500, Anthony Liguori wrote: > On 04/07/2011 10:31 AM, Gleb Natapov wrote: > >On Thu, Apr 07, 2011 at 08:28:37AM -0500, Anthony Liguori wrote: > >>On 04/07/2011 03:22 AM, Bei Guan wrote: > >>>Hi, > >>> > >>>I have some questions about the qemu's bios. How does th

Re: [Qemu-devel] [GIT PULL] Trivial patches for 6-7 April 2011

2011-04-07 Thread Stefan Hajnoczi
On Thu, Apr 7, 2011 at 4:46 PM, Anthony Liguori wrote: > On 04/07/2011 09:15 AM, Stefan Hajnoczi wrote: >> >> The following changes since commit >> 3b8e6a2db1946b5f21e69fde31b39f43367f1928: >> >>   exec: Handle registrations of the entire address space (2011-04-07 >> 10:53:41 +0200) >> >> are avai

[Qemu-devel] Re: [PATCH v2 2/2] rbd: allow configuration of rados from the rbd filename

2011-04-07 Thread Yehuda Sadeh Weinraub
On Thu, Apr 7, 2011 at 2:54 AM, Yoshiaki Tamura wrote: > 2011/4/7 Stefan Hajnoczi : >> On Thu, Apr 07, 2011 at 10:14:03AM +0900, Yoshiaki Tamura wrote: >>> 2011/3/29 Josh Durgin : >>> > The new format is >>> > rbd:pool/image[@snapshot][:option1=value1[:option2=value2...]] >>> > Each option is use

Re: [Qemu-devel] How does the QEMU load the binary files bios.bin and vgabios-cirrus.bin?

2011-04-07 Thread Anthony Liguori
On 04/07/2011 10:51 AM, Gleb Natapov wrote: On Thu, Apr 07, 2011 at 10:42:56AM -0500, Anthony Liguori wrote: On 04/07/2011 10:31 AM, Gleb Natapov wrote: On Thu, Apr 07, 2011 at 08:28:37AM -0500, Anthony Liguori wrote: On 04/07/2011 03:22 AM, Bei Guan wrote: Hi, I have some questions about th

Re: [Qemu-devel] [PATCH RFC 0/5] kvm/vhost: enable durty logging during memory registration

2011-04-07 Thread Blue Swirl
On Thu, Apr 7, 2011 at 8:39 AM, Brad Hards wrote: > On Thu, 7 Apr 2011 06:41:35 am Michael S. Tsirkin wrote: >> As a solution, this adds an explicit flag that >> will enable dirty logging directly when registering >> the ram. kvm then needs a single system call >> to update tables for vga ram, vho

Re: [Qemu-devel] How does the QEMU load the binary files bios.bin and vgabios-cirrus.bin?

2011-04-07 Thread Bei Guan
2011/4/7 Anthony Liguori > On 04/07/2011 03:22 AM, Bei Guan wrote: > >> Hi, >> >> I have some questions about the qemu's bios. How does the QEMU load the >> binary files bios.bin and vgabios-cirrus.bin? Which function or code file >> need I to pay more attention to? >> >> For the loading of vgabi

Re: [Qemu-devel] How does the QEMU load the binary files bios.bin and vgabios-cirrus.bin?

2011-04-07 Thread malc
On Thu, 7 Apr 2011, Anthony Liguori wrote: > On 04/07/2011 10:31 AM, Gleb Natapov wrote: > > On Thu, Apr 07, 2011 at 08:28:37AM -0500, Anthony Liguori wrote: > > > On 04/07/2011 03:22 AM, Bei Guan wrote: > > > > Hi, > > > > > > > > I have some questions about the qemu's bios. How does the QEMU >

Re: [Qemu-devel] How does the QEMU load the binary files bios.bin and vgabios-cirrus.bin?

2011-04-07 Thread Bei Guan
2011/4/8 Bei Guan > > > 2011/4/7 Anthony Liguori > >> On 04/07/2011 03:22 AM, Bei Guan wrote: >> >>> Hi, >>> >>> I have some questions about the qemu's bios. How does the QEMU load the >>> binary files bios.bin and vgabios-cirrus.bin? Which function or code file >>> need I to pay more attention

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-07 Thread Peter Maydell
On 6 April 2011 20:34, Anthony Liguori wrote: > http://publib.boulder.ibm.com/infocenter/lnxinfo/v3r0m0/index.jsp?topic=/liaai/crashdump/liaaicrashdumpnmiipmi.htm > > If an OS is totally hosed (spinning with interrupts disabled), and NMI can > be used to generate a crash dump. > > It's a debug fea

Re: [Qemu-devel] [PATCH] hw: improve multiboot module loading

2011-04-07 Thread Adam Lackorzynski
On Thu Apr 07, 2011 at 14:52:34 +0100, Stefan Hajnoczi wrote: > On Thu, Apr 7, 2011 at 1:56 PM, Ralf Ramsauer > wrote: > > On 07.04.2011, at 14:48, Stefan Hajnoczi wrote: > > > >> Out of curiousity, why are you trying to kill spaces at all? > >> > >> Why not just use a correct command-line to inv

Re: [Qemu-devel] How does the QEMU load the binary files bios.bin and vgabios-cirrus.bin?

2011-04-07 Thread Jordan Justen
On Thu, Apr 7, 2011 at 09:08, Anthony Liguori wrote: > On 04/07/2011 10:51 AM, Gleb Natapov wrote: >> That may seams to be impossible but it is how HW works. And this is how >> QEMU emulates it. Look at target-i386/helper.c:cpu_reset() >> >>     cpu_x86_load_seg_cache(env, R_CS, 0xf000, 0x

[Qemu-devel] [PATCH] multiboot: Quote filename in error message.

2011-04-07 Thread Adam Lackorzynski
Quote filename in error message to spot possible whitespace character in the filename. Signed-off-by: Adam Lackorzynski --- hw/multiboot.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/multiboot.c b/hw/multiboot.c index 0d2bfb4..6be6fa0 100644 --- a/hw/multiboot.c

Re: [Qemu-devel] How does the QEMU load the binary files bios.bin and vgabios-cirrus.bin?

2011-04-07 Thread Gleb Natapov
On Thu, Apr 07, 2011 at 11:18:54AM -0700, Jordan Justen wrote: > On Thu, Apr 7, 2011 at 09:08, Anthony Liguori wrote: > > On 04/07/2011 10:51 AM, Gleb Natapov wrote: > >> That may seams to be impossible but it is how HW works. And this is how > >> QEMU emulates it. Look at target-i386/helper.c:cpu

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-07 Thread Anthony Liguori
On 04/07/2011 01:10 PM, Peter Maydell wrote: On 6 April 2011 20:34, Anthony Liguori wrote: http://publib.boulder.ibm.com/infocenter/lnxinfo/v3r0m0/index.jsp?topic=/liaai/crashdump/liaaicrashdumpnmiipmi.htm If an OS is totally hosed (spinning with interrupts disabled), and NMI can be used to ge

Re: [Qemu-devel] How does the QEMU load the binary files bios.bin and vgabios-cirrus.bin?

2011-04-07 Thread Anthony Liguori
On 04/07/2011 01:18 PM, Jordan Justen wrote: On Thu, Apr 7, 2011 at 09:08, Anthony Liguori wrote: On 04/07/2011 10:51 AM, Gleb Natapov wrote: That may seams to be impossible but it is how HW works. And this is how QEMU emulates it. Look at target-i386/helper.c:cpu_reset() cpu_x86_load_se

[Qemu-devel] [Bug 753916] [NEW] performance bug with SeaBios 0.6.x

2011-04-07 Thread DSR!
Public bug reported: in my tests SeaBios 0.5.1 has the best performance (100% faster) i run qemu port in windows xp (phenom II x4 945, 4 gigas ram DDR3) and windows xp (Pentium 4, 1 giga ram ddr) ** Affects: qemu Importance: Undecided Status: New -- You received this bug notifica

Re: [Qemu-devel] How does the QEMU load the binary files bios.bin and vgabios-cirrus.bin?

2011-04-07 Thread Gleb Natapov
On Thu, Apr 07, 2011 at 01:37:14PM -0500, Anthony Liguori wrote: > The CS base starts out at 0xf and IP is 0xfff0. That gives a > real address of 0x0. This is usually a trampoline to somewhere > else in the space. > >>>CS descriptor and CS selector don't have to be in sync (bi

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-07 Thread Gleb Natapov
On Thu, Apr 07, 2011 at 01:32:50PM -0500, Anthony Liguori wrote: > On 04/07/2011 01:10 PM, Peter Maydell wrote: > >On 6 April 2011 20:34, Anthony Liguori wrote: > >>http://publib.boulder.ibm.com/infocenter/lnxinfo/v3r0m0/index.jsp?topic=/liaai/crashdump/liaaicrashdumpnmiipmi.htm > >> > >>If an OS

Re: [Qemu-devel] git.qemu.org problem, down?

2011-04-07 Thread Gerhard Wiesinger
On Sun, 3 Apr 2011, Anthony Liguori wrote: http://git.qemu.org/git/qemu.git Is the right http URL. Website still has wrong URL. Ciao, Gerhard -- http://www.wiesinger.com/

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-07 Thread Blue Swirl
On Thu, Apr 7, 2011 at 9:51 PM, Gleb Natapov wrote: > On Thu, Apr 07, 2011 at 01:32:50PM -0500, Anthony Liguori wrote: >> On 04/07/2011 01:10 PM, Peter Maydell wrote: >> >On 6 April 2011 20:34, Anthony Liguori  wrote: >> >>http://publib.boulder.ibm.com/infocenter/lnxinfo/v3r0m0/index.jsp?topic=/li

Re: [Qemu-devel] How does the QEMU load the binary files bios.bin and vgabios-cirrus.bin?

2011-04-07 Thread Jordan Justen
On Thu, Apr 7, 2011 at 11:44, Gleb Natapov wrote: > On Thu, Apr 07, 2011 at 01:37:14PM -0500, Anthony Liguori wrote: >> The CS base starts out at 0xf and IP is 0xfff0.  That gives a >> real address of 0x0.  This is usually a trampoline to somewhere >> else in the space. >> >>>C

Re: [Qemu-devel] How does the QEMU load the binary files bios.bin and vgabios-cirrus.bin?

2011-04-07 Thread Gleb Natapov
On Thu, Apr 07, 2011 at 12:03:41PM -0700, Jordan Justen wrote: > On Thu, Apr 7, 2011 at 11:44, Gleb Natapov wrote: > > On Thu, Apr 07, 2011 at 01:37:14PM -0500, Anthony Liguori wrote: > >> The CS base starts out at 0xf and IP is 0xfff0.  That gives a > >> real address of 0x0.  This

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-07 Thread Gleb Natapov
On Thu, Apr 07, 2011 at 10:04:00PM +0300, Blue Swirl wrote: > On Thu, Apr 7, 2011 at 9:51 PM, Gleb Natapov wrote: > > On Thu, Apr 07, 2011 at 01:32:50PM -0500, Anthony Liguori wrote: > >> On 04/07/2011 01:10 PM, Peter Maydell wrote: > >> >On 6 April 2011 20:34, Anthony Liguori  wrote: > >> >>http:

Re: [Qemu-devel] How does the QEMU load the binary files bios.bin and vgabios-cirrus.bin?

2011-04-07 Thread Anthony Liguori
On 04/07/2011 01:44 PM, Gleb Natapov wrote: KVM doesn't support SMM although that's not because of this. KVM doesn't allow execution of ROM memory which makes it difficult to implement PAM in the way it's intended to be implemented. This makes SMM a bit tricky to make work. Since there's never

Re: [Qemu-devel] How does the QEMU load the binary files bios.bin and vgabios-cirrus.bin?

2011-04-07 Thread Olivier Galibert
On Thu, Apr 07, 2011 at 12:03:41PM -0700, Jordan Justen wrote: > But, Anthony's point ('there's never really been a pressing need to > support SMM') is probably the most important here, as I can't see a > compelling use for SMM in QEMU. Running real biosen instead of seabios? Of course that's mos

  1   2   >