On Thu, Apr 7, 2011 at 8:39 AM, Brad Hards <br...@frogmouth.net> wrote: > On Thu, 7 Apr 2011 06:41:35 am Michael S. Tsirkin wrote: >> As a solution, this adds an explicit flag that >> will enable dirty logging directly when registering >> the ram. kvm then needs a single system call >> to update tables for vga ram, vhost-net can simply ignore it. > I'm not very familiar with QEMU coding style and standards (so this could be > completely bogus), but I think that the code would be easier if you used a > integer flag / enum instead of a boolean. That would also give you options for > additional behaviour changes later too. So instead of passing true/false, pass > MEM_LOG_DIRTY_PAGES (or whatever you decide to call it).
Good idea, it's more descriptive. Maybe also calls to qemu_register_coalesced_mmio() could be avoided with another flag?
