[Qemu-devel] Re: [PATCH] w32: Fix compilation of new code

2011-04-01 Thread Paolo Bonzini
On 03/31/2011 10:58 PM, Stefan Weil wrote: Some recently added new code did not compile for w32 targets. The functions qemu_iohandler_fill and qemu_iohandler_poll need data type fd_set which is declared in winsock2.h for w32 targets. Moving the functions from qemu-common.h to qemu_socket.h fixe

Re: [Qemu-devel] [PATCH RFC] vga: flag vga ram for notifiers

2011-04-01 Thread Peter Maydell
On 31 March 2011 22:38, Michael S. Tsirkin wrote: > On Thu, Mar 31, 2011 at 10:32:11PM +0100, Peter Maydell wrote: >> On 31 March 2011 21:23, Anthony Liguori wrote: >> > Maybe the right approach here is to just use a virtio specific API and >> > register RAM as register_virtio_dma_area(). >> >> T

[Qemu-devel] Re: [PATCH V3] floppy: save and restore DIR register

2011-04-01 Thread Paolo Bonzini
On 04/01/2011 08:22 AM, Jason Wang wrote: + +if (drive->bs == NULL) { +return 1; Is it okay to return 1 here? Have you tested the case when both the source and the target drives have no floppy? (The "media_changed == 2" in my sample code was basically a way to save the "media p

[Qemu-devel] Re: [RFC PATCH] qed: add support for Copy-on-Read

2011-04-01 Thread Stefan Hajnoczi
On Wed, Mar 30, 2011 at 08:08:34PM -0500, Anthony Liguori wrote: > When creating an image using qemu-img, just pass '-o copy_on_read' and then > whenever QED reads from a backing file, it will write the block to the QED > file after the read completes ensuring that you only fetch from the backing >

[Qemu-devel] Re: [RFC][PATCH v1 10/12] guest agent: qemu-ga daemon

2011-04-01 Thread Jes Sorensen
On 03/25/11 20:47, Michael Roth wrote: > This is the actual guest daemon, it listens for requests over a > virtio-serial/isa-serial/unix socket channel and routes them through > to dispatch routines, and writes the results back to the channel in > a manner similar to Qmp. > > This is currently hor

[Qemu-devel] Re: [PATCH V3] floppy: save and restore DIR register

2011-04-01 Thread Jason Wang
Paolo Bonzini writes: > On 04/01/2011 08:22 AM, Jason Wang wrote: > > + > > +if (drive->bs == NULL) { > > +return 1; > > Is it okay to return 1 here? Have you tested the case when both the > source and the target drives have no floppy? > Thanks for the reminding, and it cou

Re: [Qemu-devel] [RFC PATCH] qed: add support for Copy-on-Read

2011-04-01 Thread Kevin Wolf
Am 31.03.2011 03:08, schrieb Anthony Liguori: > When creating an image using qemu-img, just pass '-o copy_on_read' and then > whenever QED reads from a backing file, it will write the block to the QED > file after the read completes ensuring that you only fetch from the backing > device once. As y

Re: [Qemu-devel] [PATCH RFC] vga: flag vga ram for notifiers

2011-04-01 Thread Michael S. Tsirkin
On Fri, Apr 01, 2011 at 08:12:48AM +0100, Peter Maydell wrote: > On 31 March 2011 22:38, Michael S. Tsirkin wrote: > > On Thu, Mar 31, 2011 at 10:32:11PM +0100, Peter Maydell wrote: > >> On 31 March 2011 21:23, Anthony Liguori wrote: > >> > Maybe the right approach here is to just use a virtio sp

[Qemu-devel] Re: [PATCH V3] floppy: save and restore DIR register

2011-04-01 Thread Paolo Bonzini
On 04/01/2011 12:03 PM, Jason Wang wrote: Paolo Bonzini writes: > On 04/01/2011 08:22 AM, Jason Wang wrote: > > + > > +if (drive->bs == NULL) { > > +return 1; > > Is it okay to return 1 here? Have you tested the case when both the > source and the target drives

[Qemu-devel] [PATCH v7 4/4] piix_pci: load path clean up

2011-04-01 Thread Isaku Yamahata
The previous patch didn't change the behavior when load, it resulted in ugly code. This patch cleans it up. With this patch, pic irq lines are manipulated when loaded. It is expected that it won't change the behaviour because the interrupts are level: at the moment e.g. pci devices already reasser

[Qemu-devel] [PATCH v7 1/4] pci: add accessor function to get irq levels

2011-04-01 Thread Isaku Yamahata
Introduce accessor function to know INTx levels. It will be used later by q35. Although piix_pci tracks the intx line levels, it can be eliminated by this helper function. Cc: Michael S. Tsirkin Signed-off-by: Isaku Yamahata --- hw/pci.c |7 +++ hw/pci.h |1 + 2 files changed, 8 ins

[Qemu-devel] [PATCH v7 2/4] piix_pci: eliminate PIIX3State::pci_irq_levels

2011-04-01 Thread Isaku Yamahata
PIIX3State::pci_irq_levels are redundant which is already tracked by PCIBus layer. So eliminate them. Cc: Juan Quintela Cc: Michael S. Tsirkin Signed-off-by: Isaku Yamahata --- Changes v3 -> v4: - use PCI_NUM_PINS instead of magic number 4 Changes v2 -> v3: - rename member s/dummy_for_save_loa

[Qemu-devel] [PATCH v7 0/4] piix_pci: optimize irq data path

2011-04-01 Thread Isaku Yamahata
Here is v7 which are rebased to pci branch. I tested this patch series as follows. please see the commit message for details. - 3/4 piix_pci: optimize set irq path Run linux as guest with 4 e1000 emulated devices. And confirmed that each PIRQ[A-D] are able to assert interrupts. - 4/4 piix_pci:

[Qemu-devel] [PATCH v7 3/4] piix_pci: optimize set irq path

2011-04-01 Thread Isaku Yamahata
optimize irq routing in piix_pic.c which has been a TODO. So far piix3 tracks each pirq level and checks whether a given pic pins is asserted by seeing if each pirq is mapped into the pic pin. This is independent on irq routing, but data path is on slow path. Given that irq routing is rarely chang

[Qemu-devel] Re: [RFC PATCH] qed: add support for Copy-on-Read

2011-04-01 Thread Anthony Liguori
On 04/01/2011 04:42 AM, Stefan Hajnoczi wrote: On Wed, Mar 30, 2011 at 08:08:34PM -0500, Anthony Liguori wrote: When creating an image using qemu-img, just pass '-o copy_on_read' and then whenever QED reads from a backing file, it will write the block to the QED file after the read completes ens

Re: [Qemu-devel] [RFC PATCH] qed: add support for Copy-on-Read

2011-04-01 Thread Anthony Liguori
On 04/01/2011 06:11 AM, Kevin Wolf wrote: Am 31.03.2011 03:08, schrieb Anthony Liguori: When creating an image using qemu-img, just pass '-o copy_on_read' and then whenever QED reads from a backing file, it will write the block to the QED file after the read completes ensuring that you only fetc

Re: [Qemu-devel] [RFC PATCH] qed: add support for Copy-on-Read

2011-04-01 Thread Kevin Wolf
Am 01.04.2011 14:36, schrieb Anthony Liguori: > On 04/01/2011 06:11 AM, Kevin Wolf wrote: >> Am 31.03.2011 03:08, schrieb Anthony Liguori: >>> When creating an image using qemu-img, just pass '-o copy_on_read' and then >>> whenever QED reads from a backing file, it will write the block to the QED >

Re: [Qemu-devel] [PATCH v24 00/10] usb-ccid

2011-04-01 Thread Anthony Liguori
On 03/28/2011 11:11 AM, Alon Levy wrote: This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone emulated card. It also introduces a new directory libcaccard

Re: [Qemu-devel] Re: [PATCH v2] qemu-img: Initial progress printing support

2011-04-01 Thread Jes Sorensen
On 03/31/11 13:49, Stefan Hajnoczi wrote: > On Thu, Mar 31, 2011 at 12:38 PM, Kevin Wolf wrote: >> Am 31.03.2011 13:15, schrieb Jes Sorensen: >>> On 03/31/11 12:38, Kevin Wolf wrote: >>> I have been a little reluctant to do this because it will break the ABI >>> for tools running qemu-img from a G

[Qemu-devel] [PATCH 09/10] target-arm: Don't leak TCG temp for UNDEFs in Neon load/store space

2011-04-01 Thread Peter Maydell
Move the allocation and freeing of the TCG temp used for the address for Neon load/store instructions so that we don't allocate the temporary until we've done enough decoding to know that the instruction is not an UNDEF pattern; this avoids leaking the TCG temp in these cases. Signed-off-by: Peter

[Qemu-devel] [PATCH 02/10] target-arm/neon_helper.c: Use make_float32/float32_val macros

2011-04-01 Thread Peter Maydell
Use the softfloat make_float32 and float32_val macros to convert between softfloat's float32 type and raw uint32_t types, rather than private conversion functions. Signed-off-by: Peter Maydell Reviewed-by: Nathan Froyd --- target-arm/neon_helper.c | 56 ++--

[Qemu-devel] [PATCH 06/10] softfloat: Add float*_min() and float*_max() functions

2011-04-01 Thread Peter Maydell
Add min and max operations to softfloat. This allows us to implement propagation of NaNs and handling of negative zero correctly (unlike the approach of having target helper routines return one of the operands based on the result of a comparison op). Signed-off-by: Peter Maydell --- fpu/softfloa

[Qemu-devel] [PATCH 04/10] target-arm: Fix VCLE.F32 #0, VCLT.F32 #0 NaN handling

2011-04-01 Thread Peter Maydell
Implementing the floating-point versions of VCLE #0 and VCLT #0 by doing a GT comparison and inverting the result gives the wrong result if the input is a NaN. Implement as a GT comparison with the operands swapped instead. Signed-off-by: Peter Maydell --- target-arm/translate.c | 18 +

[Qemu-devel] [PATCH 00/10] [PULL] ARM Neon fixes

2011-04-01 Thread Peter Maydell
This is a pull request for a set of patches fixing various minor Neon problems for ARM targets, which I sent to the list a couple of weeks ago. A few of them got reviewed-by Nathan, one had some minor discussion which didn't amount to a request for any change, the rest had no comments. The softflo

[Qemu-devel] [PATCH 07/10] target-arm: Use new softfloat min/max functions for VMAX, VMIN

2011-04-01 Thread Peter Maydell
Use the new softfloat min/max functions to implement the Neon VMAX and VMIN instructions. This allows us to get the right behaviour for NaN and negative zero. Signed-off-by: Peter Maydell --- target-arm/neon_helper.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a

[Qemu-devel] [PATCH 10/10] target-arm/helper.c: For float-int conversion helpers pass ints as ints

2011-04-01 Thread Peter Maydell
Correct the argument and return types for the float<->int conversion helper functions so that integer arguments and return values are declared as uint32_t/uint64_t, not float32/float64. This allows us to remove the hand-rolled functions which were doing bitwise copies between the types via unions.

[Qemu-devel] [PATCH 01/10] target-arm: Make Neon helper routines use correct FP status

2011-04-01 Thread Peter Maydell
Make the Neon helper routines use the correct FP status from the CPUEnv rather than using a dummy static one. This means they will correctly handle denormals and NaNs and will set FPSCR exception bits properly. Signed-off-by: Peter Maydell --- target-arm/helpers.h | 22 +++-

[Qemu-devel] [PATCH 05/10] target-arm: Correct ABD's handling of negative zeroes

2011-04-01 Thread Peter Maydell
Implement ABD by taking the absolute value of the difference of the operands (as the ARM ARM specifies) rather than by flipping the order of the operands to the subtract based on the results of a comparison. The latter approch gives the wrong answers for some edge cases like negative zero. Signed-

[Qemu-devel] Re: [PATCH v7 0/4] piix_pci: optimize irq data path

2011-04-01 Thread Michael S. Tsirkin
On Fri, Apr 01, 2011 at 08:43:20PM +0900, Isaku Yamahata wrote: > Here is v7 which are rebased to pci branch. > > I tested this patch series as follows. please see the commit message > for details. > - 3/4 piix_pci: optimize set irq path > Run linux as guest with 4 e1000 emulated devices. > An

Re: [Qemu-devel] Re: [PATCH v2 3/3] raw-posix: Re-open host CD-ROM after media change

2011-04-01 Thread Stefan Hajnoczi
On Thu, Mar 31, 2011 at 11:05 AM, Kevin Wolf wrote: > The other thing is that I'm not sure if everything in raw-posix is > prepared to deal with a -1 fd. At the very least, I think we'll get > -EBADF errors instead of the expected -ENOMEDIUM. Not all of block.c checks for !bdrv_is_inserted() so y

Re: [Qemu-devel] Re: [PATCH v2] qemu-img: Initial progress printing support

2011-04-01 Thread Stefan Hajnoczi
On Fri, Apr 1, 2011 at 2:41 PM, Jes Sorensen wrote: > On 03/31/11 13:49, Stefan Hajnoczi wrote: >> On Thu, Mar 31, 2011 at 12:38 PM, Kevin Wolf wrote: >>> Am 31.03.2011 13:15, schrieb Jes Sorensen: On 03/31/11 12:38, Kevin Wolf wrote: I have been a little reluctant to do this because it

[Qemu-devel] [PATCH 03/10] target-arm: Return right result for Neon comparison with NaNs

2011-04-01 Thread Peter Maydell
Fix the helper functions implementing the Neon floating point comparison ops (VCGE, VCGT, VCEQ, VACGT, VACGE) to return the right answer when one of the values being compared is a NaN. Signed-off-by: Peter Maydell --- target-arm/neon_helper.c | 28 ++-- 1 files changed,

[Qemu-devel] [PATCH 08/10] target-arm: Fix VLD of single element to all lanes

2011-04-01 Thread Peter Maydell
Fix several bugs in VLD of single element to all lanes: The "single element to all lanes" form of VLD1 differs from those for VLD2, VLD3 and VLD4 in that bit 5 indicates whether the loaded element should be written to one or two Dregs (rather than being a register stride). Handle this by special-c

[Qemu-devel] [PATCH v25 02/10] qemu-thread.h: include inttypes.h

2011-04-01 Thread Alon Levy
qemu-thread.h relies on uint64_t being defined, but doesn't include inttypes.h explicitly. This makes it easier to use it from vscclient (part of libcacard). --- qemu-thread.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/qemu-thread.h b/qemu-thread.h index edc7ab6..0a7

[Qemu-devel] [PATCH v25 04/10] introduce libcacard/vscard_common.h

2011-04-01 Thread Alon Levy
--- Signed-off-by: Alon Levy v20->v21 changes: (Jes Sorensen review) * license set to 2+ * long comment fixes, remove empty line at eof. * add reference to COPYING v19->v20 changes: * checkpatch.pl v15->v16 changes: Protocol change: * VSCMsgInit capabilities and magic * removed ReaderRe

[Qemu-devel] [PATCH v25 01/10] trace: move trace objects from Makefile to Makefile.objs

2011-04-01 Thread Alon Levy
--- Makefile | 32 Makefile.objs | 32 2 files changed, 32 insertions(+), 32 deletions(-) diff --git a/Makefile b/Makefile index 89e88b4..209e14d 100644 --- a/Makefile +++ b/Makefile @@ -112,38 +112,6 @@ ui/vnc.o: QEMU_CFL

[Qemu-devel] [PATCH v25 00/10] usb-ccid

2011-04-01 Thread Alon Levy
This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone emulated card. It also introduces a new directory libcaccard with CAC card emulation, CAC is a type of

[Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail

2011-04-01 Thread Michael Roth
Was playing around with Stefan's git hook for checkpatch.pl: http://blog.vmsplice.net/2011/03/how-to-automatically-run-checkpatchpl.html which seems really useful butter-finger coders such as myself. But some of warnings/errors that have carried over from the kernel have made this approach some

[Qemu-devel] [PATCH v25 03/10] usb-ccid: add CCID bus

2011-04-01 Thread Alon Levy
A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it, a passthru card and an emulated card. [1] http://www.usb.org/developers/devclass_docs/DWG_Smart-Card_CCID_R

Re: [Qemu-devel] GSoC: Improved image format compatibility

2011-04-01 Thread Lyu Mitnick
Hello Stefan Hello Mitnick, > > asynchronous i/o is also missing in block/vpc.c. > > All newer block drivers support asynchronous reads and writes, > only some old drivers don't. > > So adding asynchronous i/o to at least some of the old drivers > would improve their usability. > > Look for "aio"

[Qemu-devel] [PATCH v25 05/10] ccid: add passthru card device

2011-04-01 Thread Alon Levy
The passthru ccid card is a device sitting on the usb-ccid bus and using a chardevice to communicate with a remote device using the VSCard protocol defined in libcacard/vscard_common.h Usage docs available in following patch in docs/ccid.txt Signed-off-by: Alon Levy --- Changes from v23->v24:

[Qemu-devel] [PATCH 1/2] checkpatch.pl: add --no-fail-on-warn option

2011-04-01 Thread Michael Roth
checkpatch.pl complains about some things that are not strictly against QEMU's coding style guidelines. It's good to print these, but we shouldn't force a fail on these as it makes it difficult to automate checkpatch.pl runs. If we're supposed to fail on these cases, they should be handled as error

[Qemu-devel] [PATCH v25 04/10] introduce libcacard/vscard_common.h

2011-04-01 Thread Alon Levy
--- Signed-off-by: Alon Levy v20->v21 changes: (Jes Sorensen review) * license set to 2+ * long comment fixes, remove empty line at eof. * add reference to COPYING v19->v20 changes: * checkpatch.pl v15->v16 changes: Protocol change: * VSCMsgInit capabilities and magic * removed ReaderRe

[Qemu-devel] [PATCH v25 05/10] ccid: add passthru card device

2011-04-01 Thread Alon Levy
The passthru ccid card is a device sitting on the usb-ccid bus and using a chardevice to communicate with a remote device using the VSCard protocol defined in libcacard/vscard_common.h Usage docs available in following patch in docs/ccid.txt Signed-off-by: Alon Levy --- Changes from v23->v24:

[Qemu-devel] [PATCH v25 02/10] qemu-thread.h: include inttypes.h

2011-04-01 Thread Alon Levy
qemu-thread.h relies on uint64_t being defined, but doesn't include inttypes.h explicitly. This makes it easier to use it from vscclient (part of libcacard). --- qemu-thread.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/qemu-thread.h b/qemu-thread.h index edc7ab6..0a7

[Qemu-devel] [PATCH 2/2] checkpatch.pl: make C99 comments a warning, not error

2011-04-01 Thread Michael Roth
C99 comments are pretty heavilly used in QEMU, and don't violate anything mentioned in HACKING/CODING_STYLE. Make them warnings instead. Signed-off-by: Michael Roth --- scripts/checkpatch.pl |2 +- test.c|5 + 2 files changed, 6 insertions(+), 1 deletions(-) create m

[Qemu-devel] [PATCH v25 00/10] usb-ccid

2011-04-01 Thread Alon Levy
This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone emulated card. It also introduces a new directory libcaccard with CAC card emulation, CAC is a type of

[Qemu-devel] Re: [PATCH 2/2] checkpatch.pl: make C99 comments a warning, not error

2011-04-01 Thread Michael Roth
On 04/01/2011 10:20 AM, Michael Roth wrote: C99 comments are pretty heavilly used in QEMU, and don't violate anything mentioned in HACKING/CODING_STYLE. Make them warnings instead. Signed-off-by: Michael Roth --- scripts/checkpatch.pl |2 +- test.c|5 + 2 files ch

Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail

2011-04-01 Thread Peter Maydell
On 1 April 2011 16:20, Michael Roth wrote: > We also make C99 //comments a warning instead of an error, since they > don't actually violate QEMU's coding guidelines. We should either update the guidelines or fix the script... -- PMM

[Qemu-devel] [PATCH v25 10/10] ccid: add docs

2011-04-01 Thread Alon Levy
Add documentation for the usb-ccid device and accompanying two card devices, ccid-card-emulated and ccid-card-passthru. Signed-off-by: Alon Levy --- docs/ccid.txt | 135 + 1 files changed, 135 insertions(+), 0 deletions(-) create mode 100

Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail

2011-04-01 Thread Stefan Hajnoczi
On Fri, Apr 1, 2011 at 4:52 PM, Peter Maydell wrote: > On 1 April 2011 16:20, Michael Roth wrote: >> We also make C99 //comments a warning instead of an error, since they >> don't actually violate QEMU's coding guidelines. > > We should either update the guidelines or fix the script... There are

[Qemu-devel] [PATCH v25 09/10] ccid: add ccid-card-emulated device

2011-04-01 Thread Alon Levy
This devices uses libcacard (internal) to emulate a smartcard conforming to the CAC standard. It attaches to the usb-ccid bus. Usage instructions (example command lines) are in the following patch in docs/ccid.txt. It uses libcacard which uses nss, so it can work with both hw cards and certificates

Re: [Qemu-devel] [PATCH 2/2] checkpatch.pl: make C99 comments a warning, not error

2011-04-01 Thread Stefan Hajnoczi
On Fri, Apr 1, 2011 at 4:20 PM, Michael Roth wrote: > C99 comments are pretty heavilly used in QEMU, and don't violate > anything mentioned in HACKING/CODING_STYLE. Make them warnings instead. > > Signed-off-by: Michael Roth > --- >  scripts/checkpatch.pl |    2 +- >  test.c                |    5

[Qemu-devel] [PATCH v25 07/10] libcacard: add vscclient

2011-04-01 Thread Alon Levy
From: Robert Relyea client to talk to ccid-card-passthru and use smartcard on client to perform actual operations. v23->v24 changes: (Jes Sorensen review 2) * use qemu_socket instead of socket * use fprintf(stderr,..) for errors * remove unneccessary includes since using qemu_common.h --- li

[Qemu-devel] Re: [0/27] Implement emulation of pSeries logical partitions (v6)

2011-04-01 Thread Alexander Graf
On 01.04.2011, at 06:15, David Gibson wrote: > This patch series adds a "pseries" machine to qemu, allowing it to > emulate IBM pSeries logical partitions. More specifically it > implements the interface defined by the "PowerPC Architecture Platform > Requirements" document (PAPR, or sPAPR for s

Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail

2011-04-01 Thread Peter Maydell
On 1 April 2011 16:59, Stefan Hajnoczi wrote: > On Fri, Apr 1, 2011 at 4:52 PM, Peter Maydell > wrote: >> On 1 April 2011 16:20, Michael Roth wrote: >>> We also make C99 //comments a warning instead of an error, since they >>> don't actually violate QEMU's coding guidelines. >> >> We should eit

[Qemu-devel] [PATCH v25 03/10] usb-ccid: add CCID bus

2011-04-01 Thread Alon Levy
A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it, a passthru card and an emulated card. [1] http://www.usb.org/developers/devclass_docs/DWG_Smart-Card_CCID_R

[Qemu-devel] [PATCH v25 08/10] libcacard: add docs

2011-04-01 Thread Alon Levy
From: Robert Relyea --- docs/libcacard.txt | 483 1 files changed, 483 insertions(+), 0 deletions(-) create mode 100644 docs/libcacard.txt diff --git a/docs/libcacard.txt b/docs/libcacard.txt new file mode 100644 index 000..5dee6fa ---

[Qemu-devel] [Bug 741887] Re: virsh snapshot-create too slow (kvm, qcow2, savevm)

2011-04-01 Thread Kevin Wolf
In qemu 0.14 cache=writeback and cache=none are expected to perform well. The default cache=writethrough is a very conservative setting which is slow by design. I'm pretty sure that it has always been slow, even before 0.12.5. I think that the specific problem with savevm may be related to the VM

[Qemu-devel] Re: [0/27] Implement emulation of pSeries logical partitions (v6)

2011-04-01 Thread Alexander Graf
On 01.04.2011, at 18:22, Anthony Liguori wrote: > On 04/01/2011 11:18 AM, Alexander Graf wrote: >> On 01.04.2011, at 06:15, David Gibson wrote: >> >>> This patch series adds a "pseries" machine to qemu, allowing it to >>> emulate IBM pSeries logical partitions. More specifically it >>> implemen

[Qemu-devel] Re: [0/27] Implement emulation of pSeries logical partitions (v6)

2011-04-01 Thread Anthony Liguori
On 04/01/2011 11:18 AM, Alexander Graf wrote: On 01.04.2011, at 06:15, David Gibson wrote: This patch series adds a "pseries" machine to qemu, allowing it to emulate IBM pSeries logical partitions. More specifically it implements the interface defined by the "PowerPC Architecture Platform Requ

Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail

2011-04-01 Thread Michael Roth
On 04/01/2011 11:16 AM, Peter Maydell wrote: On 1 April 2011 16:59, Stefan Hajnoczi wrote: On Fri, Apr 1, 2011 at 4:52 PM, Peter Maydell wrote: On 1 April 2011 16:20, Michael Roth wrote: We also make C99 //comments a warning instead of an error, since they don't actually violate QEMU's codi

Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail

2011-04-01 Thread Peter Maydell
On 1 April 2011 17:55, Michael Roth wrote: > But there *are* some warnings that make sense to complain about without > saying "you can't do this", like extern's in .c files: some cases are > exceptional. I'd treat everything checkpatch says as a warning anyway, because it gets confused by things

[Qemu-devel] GSoC: Xen.org project to implement PV driver frontend for SeaBIOS

2011-04-01 Thread Ian Campbell
Hi, (I was unsure what the appropriate mailing list for this was, apologies for the cross post) You may or may not be aware that Xen intends to switch to using SeaBIOS as part of switching to using upstream qemu as our device model (hopefully in our next major release later this year). The switch

Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail

2011-04-01 Thread Stefan Hajnoczi
On Fri, Apr 01, 2011 at 11:55:39AM -0500, Michael Roth wrote: > I'd prefer to only document "strict" guidelines, and treat > checkpatch.pl warnings ("suggestions") as an extra "reward" you get > for taking the time to run it. I don't want to be punished for running checkpatch.pl like I'm supposed

Re: [Qemu-devel] GSoC: Improved image format compatibility

2011-04-01 Thread Stefan Weil
Am 01.04.2011 17:15, schrieb Lyu Mitnick: Hello Stefan Hello Mitnick, asynchronous i/o is also missing in block/vpc.c. All newer block drivers support asynchronous reads and writes, only some old drivers don't. So adding asynchronous i/o to at least some of the old drivers

[Qemu-devel] [PULL] PowerPC patch queue

2011-04-01 Thread Alexander Graf
Howdy, this is the current patch queue for PowerPC. I'm very excited this time, as we finally have a real PPC64 target machine available to play with! I also included a patch from Aurelien that he seems to have forgotten to push. Alex The following changes since commit a5086f95421e43c7b9e1b28a

Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail

2011-04-01 Thread Michael Roth
On 04/01/2011 11:58 AM, Peter Maydell wrote: On 1 April 2011 17:55, Michael Roth wrote: But there *are* some warnings that make sense to complain about without saying "you can't do this", like extern's in .c files: some cases are exceptional. I'd treat everything checkpatch says as a warning

Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail

2011-04-01 Thread Michael Roth
On 04/01/2011 12:01 PM, Stefan Hajnoczi wrote: On Fri, Apr 01, 2011 at 11:55:39AM -0500, Michael Roth wrote: I'd prefer to only document "strict" guidelines, and treat checkpatch.pl warnings ("suggestions") as an extra "reward" you get for taking the time to run it. I don't want to be punished

Re: [Qemu-devel] [0/27] Implement emulation of pSeries logical partitions (v6)

2011-04-01 Thread Anthony Liguori
On 03/31/2011 11:15 PM, David Gibson wrote: This patch series adds a "pseries" machine to qemu, allowing it to emulate IBM pSeries logical partitions. More specifically it implements the interface defined by the "PowerPC Architecture Platform Requirements" document (PAPR, or sPAPR for short). A

Re: [Qemu-devel] GSoC: Improved image format compatibility

2011-04-01 Thread Kevin Wolf
Am 01.04.2011 17:15, schrieb Lyu Mitnick: > Hello Stefan > > Hello Mitnick, > > asynchronous i/o is also missing in block/vpc.c. > > All newer block drivers support asynchronous reads and writes, > only some old drivers don't. > > So adding asynchronous i/o to at least some

Re: [Qemu-devel] [PULL] PowerPC patch queue

2011-04-01 Thread Anthony Liguori
On 04/01/2011 11:43 AM, Alexander Graf wrote: Howdy, this is the current patch queue for PowerPC. I'm very excited this time, as we finally have a real PPC64 target machine available to play with! I also included a patch from Aurelien that he seems to have forgotten to push. Alex The followi

[Qemu-devel] Re: [PATCH 8/9] eepro100: Pad received short frames

2011-04-01 Thread Stefan Weil
Am 31.03.2011 23:41, schrieb Michael S. Tsirkin: On Thu, Mar 31, 2011 at 10:33:30PM +0200, Stefan Weil wrote: QEMU sends frames smaller than 60 bytes to ethernet nics. This should be fixed in the networking code because normally such frames are rejected by real NICs and their emulations. To avoi

Re: [Qemu-devel] [PULL] PowerPC patch queue

2011-04-01 Thread Scott Wood
On Fri, 1 Apr 2011 18:43:33 +0200 Alexander Graf wrote: > Howdy, > > this is the current patch queue for PowerPC. I'm very excited this time, > as we finally have a real PPC64 target machine available to play with! How about http://patchwork.ozlabs.org/patch/66743/? -Scott

Re: [Qemu-devel] [PULL] PowerPC patch queue

2011-04-01 Thread Alexander Graf
On 01.04.2011, at 19:44, Scott Wood wrote: > On Fri, 1 Apr 2011 18:43:33 +0200 > Alexander Graf wrote: > >> Howdy, >> >> this is the current patch queue for PowerPC. I'm very excited this time, >> as we finally have a real PPC64 target machine available to play with! > > How about http://patc

[Qemu-devel] Re: [PATCH 2/9] eepro100: Fix endianness issues

2011-04-01 Thread Stefan Weil
Am 31.03.2011 23:52, schrieb Michael S. Tsirkin: On Thu, Mar 31, 2011 at 10:33:24PM +0200, Stefan Weil wrote: Like other Intel devices, e100 (eepro100) uses little endian byte order. This patch was tested with these combinations: i386 host, i386 + mipsel guests (le-le) mipsel host, i386 guest

Re: [Qemu-devel] [PULL] PowerPC patch queue

2011-04-01 Thread Scott Wood
On Fri, 1 Apr 2011 19:49:35 +0200 Alexander Graf wrote: > > On 01.04.2011, at 19:44, Scott Wood wrote: > > > On Fri, 1 Apr 2011 18:43:33 +0200 > > Alexander Graf wrote: > > > >> Howdy, > >> > >> this is the current patch queue for PowerPC. I'm very excited this time, > >> as we finally have

Re: [Qemu-devel] [PATCH 06/27] Correct ppc popcntb logic, implement popcntw and popcntd

2011-04-01 Thread Aurelien Jarno
On Fri, Apr 01, 2011 at 03:15:13PM +1100, David Gibson wrote: > From: David Gibson > > qemu already includes support for the popcntb instruction introduced > in POWER5 (although it doesn't actually allow you to choose POWER5). > > However, the logic is slightly incorrect: it will generate result

Re: [Qemu-devel] [PATCH 06/27] Correct ppc popcntb logic, implement popcntw and popcntd

2011-04-01 Thread Alexander Graf
On 01.04.2011, at 19:58, Aurelien Jarno wrote: > On Fri, Apr 01, 2011 at 03:15:13PM +1100, David Gibson wrote: >> From: David Gibson >> >> qemu already includes support for the popcntb instruction introduced >> in POWER5 (although it doesn't actually allow you to choose POWER5). >> >> However,

[Qemu-devel] [Bug 747583] [NEW] Windows 2008 Time Zone Change Even When Using -locatime

2011-04-01 Thread Preston Connors
Public bug reported: * What cpu model : Intel(R) Xeon(R) CPU E5620 @ 2.40GHz * What kvm version you are using. : qemu-kvm-0.12.3 * The host kernel version : 2.6.32-30-server * What host kernel arch you are using (i386 or x86_64) : x86_64 * What guest you are using, including OS type: Windows 2008

[Qemu-devel] [PATCH v25 01/10] trace: move trace objects from Makefile to Makefile.objs

2011-04-01 Thread Alon Levy
--- Makefile | 32 Makefile.objs | 32 2 files changed, 32 insertions(+), 32 deletions(-) diff --git a/Makefile b/Makefile index 89e88b4..209e14d 100644 --- a/Makefile +++ b/Makefile @@ -112,38 +112,6 @@ ui/vnc.o: QEMU_CFL

Re: [Qemu-devel] [0/27] Implement emulation of pSeries logical partitions (v6)

2011-04-01 Thread Alexander Graf
On 01.04.2011, at 19:28, Anthony Liguori wrote: > On 03/31/2011 11:15 PM, David Gibson wrote: >> This patch series adds a "pseries" machine to qemu, allowing it to >> emulate IBM pSeries logical partitions. More specifically it >> implements the interface defined by the "PowerPC Architecture Pla

Re: [Qemu-devel] [PATCH V2 4/9] Add tpm_tis driver to build process

2011-04-01 Thread Blue Swirl
On Wed, Mar 30, 2011 at 10:42 PM, Stefan Berger wrote: > The TPM interface (tpm_tis) needs to be explicitly enabled via > ./configure --enable-tpm. This restricts the building of the > TPM support to i386 and x86_64 targets since both backends I know > of, the Xen backend and the libtpms-based bac

Re: [Qemu-devel] [PATCH 01/10] target-arm: Make Neon helper routines use correct FP status

2011-04-01 Thread Blue Swirl
On Fri, Apr 1, 2011 at 5:30 PM, Peter Maydell wrote: > Make the Neon helper routines use the correct FP status from > the CPUEnv rather than using a dummy static one. This means > they will correctly handle denormals and NaNs and will set > FPSCR exception bits properly. > > Signed-off-by: Peter M

[Qemu-devel] [Bug 720787] Re: Fails to compile on MacOS

2011-04-01 Thread Nigel Horne
It's moved on a bit. Qemu still fails to compile, but this is the latest error: CCi386-darwin-user/main.o cc1: warning: /Users/nigel/src/qemu/darwin-user/i386: No such file or directory -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed t

Re: [Qemu-devel] GSoC: Improved image format compatibility

2011-04-01 Thread Lyu Mitnick
Hello I have some question about asynchronous i/o in QEMU block driver: Why a file format with asynchronous i/o support(ex. qcow) doesn't need to register bdrv_read/bdrv_write which is registered in vhd file format?? Would qcow block driver also support synchronous i/o?? thanks a lot Mitnick 20

Re: [Qemu-devel] [PATCH 10/10] target-arm/helper.c: For float-int conversion helpers pass ints as ints

2011-04-01 Thread Blue Swirl
On Fri, Apr 1, 2011 at 5:30 PM, Peter Maydell wrote: > Correct the argument and return types for the float<->int conversion helper > functions so that integer arguments and return values are declared as > uint32_t/uint64_t, not float32/float64. This allows us to remove the > hand-rolled functions

Re: [Qemu-devel] [PATCH 2/2] checkpatch.pl: make C99 comments a warning, not error

2011-04-01 Thread Blue Swirl
On Fri, Apr 1, 2011 at 6:20 PM, Michael Roth wrote: > C99 comments are pretty heavilly used in QEMU, and don't violate > anything mentioned in HACKING/CODING_STYLE. Make them warnings instead. > > Signed-off-by: Michael Roth > --- >  scripts/checkpatch.pl |    2 +- >  test.c                |    5

[Qemu-devel] [PATCH] virtio-9p: Return ENOSYS for unhandled requests.

2011-04-01 Thread Kusanagi Kouichi
Linux 2.6.39-rc1 guest causes qemu to abort when it sync or umount a rw 9p mount. Signed-off-by: Kusanagi Kouichi --- hw/virtio-9p.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c index 7c59988..03cd957 100644 --- a/hw/virtio-9p.c

Re: [Qemu-devel] [0/27] Implement emulation of pSeries logical partitions (v6)

2011-04-01 Thread Anthony Liguori
On 04/01/2011 01:01 PM, Alexander Graf wrote: On 01.04.2011, at 19:28, Anthony Liguori wrote: On 03/31/2011 11:15 PM, David Gibson wrote: This patch series adds a "pseries" machine to qemu, allowing it to emulate IBM pSeries logical partitions. More specifically it implements the interface de

Re: [Qemu-devel] [0/27] Implement emulation of pSeries logical partitions (v6)

2011-04-01 Thread Anthony Liguori
On 04/01/2011 01:01 PM, Alexander Graf wrote: On 01.04.2011, at 19:28, Anthony Liguori wrote: On 03/31/2011 11:15 PM, David Gibson wrote: This patch series adds a "pseries" machine to qemu, allowing it to emulate IBM pSeries logical partitions. More specifically it implements the interface de

Re: [Qemu-devel] [PATCH v3] ui/sdl: Load optional QEMU icon

2011-04-01 Thread Aurelien Jarno
On Wed, Feb 16, 2011 at 09:15:40PM +0100, Stefan Weil wrote: > Load an optional QEMU icon file. If there is no icon file named > qemu.bmp in QEMU's default search path, QEMU will run with > the usual system default icon. > > A matching icon file will be loaded and used by X Windows managers > or

Re: [Qemu-devel] [PATCH V2 4/9] Add tpm_tis driver to build process

2011-04-01 Thread Stefan Berger
On 04/01/2011 02:14 PM, Blue Swirl wrote: On Wed, Mar 30, 2011 at 10:42 PM, Stefan Berger wrote: The TPM interface (tpm_tis) needs to be explicitly enabled via ./configure --enable-tpm. This restricts the building of the TPM support to i386 and x86_64 targets since both backends I know of, the

Re: [Qemu-devel] [PATCH] Register only one qbus_reset_all_fn() for system bus

2011-04-01 Thread Aurelien Jarno
On Mon, Feb 21, 2011 at 02:08:53AM +0300, Dmitry Eremin-Solenikov wrote: > Currently reset handler is registered for System bus twice: once during > bus creation and once in vl.c. Remove the second qemu_register_reset() > invocation. Also while we are at it, remove incorrect check at > qbus_create_

Re: [Qemu-devel] [PATCH] fix build errors when we enable acpi_piix4 debug

2011-04-01 Thread Aurelien Jarno
On Mon, Feb 28, 2011 at 10:22:33AM +0800, Wen Congyang wrote: > I enable acpi_piix4 debug, and got the following build errors: > # make > CClibhw64/acpi_piix4.o > cc1: warnings being treated as errors > /home/wency/source/qemu/hw/acpi_piix4.c: In function ‘pm_ioport_write’: > /home/wency/sour

[Qemu-devel] Re: lsi53c895a: add support for ABORT messages

2011-04-01 Thread Aurelien Jarno
On Mon, Sep 06, 2010 at 04:42:54AM -, Bernhard Kohl wrote: > If these messages are not handled correctly the guest driver may hang. > > Always mandatory: > - ABORT > - BUS DEVICE RESET > > Mandatory if tagged queuing is implemented (which disks usually do): > - ABORT TAG > - CLEAR QUEUE > >

[Qemu-devel] [Bug 731344] Re: When accessing to disk with qemu-system-arm Error occours

2011-04-01 Thread Aurelien Jarno
** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/731344 Title: When accessing to disk with qemu-system-arm Error occours Status in QEMU: Fix

Re: [Qemu-devel] [PATCH] get rid of private bitmap functions in block/sheepdog.c, use generic ones

2011-04-01 Thread Aurelien Jarno
On Thu, Mar 10, 2011 at 05:03:41PM +0300, Michael Tokarev wrote: > qemu now has generic bitmap functions, > so don't redefine them in sheepdog.c, > use common header instead. A small cleanup. > > Here's only one function which is actually > used in sheepdog and gets replaced with > a generic one

Re: [Qemu-devel] [PATCH RESEND(REBASED)] Fix trivial "endianness bugs"

2011-04-01 Thread Aurelien Jarno
On Sun, Mar 13, 2011 at 03:44:02PM +0100, Stefan Weil wrote: > Replace endianess -> endianness. Given it concerns code and not comments, I am reluctant for this kind of patches unless we have a very good reason. Do you have some pointers about "endianness" being the correct wording? It seems both

Re: [Qemu-devel] [PATCH] vnc: added missing name->keysym pairs for Polish national characters

2011-04-01 Thread Aurelien Jarno
On Mon, Mar 14, 2011 at 10:30:08AM +0100, Leszek Grzegorek wrote: > Hi, > > There are no { name, keysym } values in name2keysym[] array for Polish > national characters so "-k pl" option has no effect. > > Regards, > Leszek > > > Signed-off-by: Leszek Grzegorek > --- Thanks, applied. > diff

  1   2   >