On 1 April 2011 16:59, Stefan Hajnoczi <stefa...@gmail.com> wrote: > On Fri, Apr 1, 2011 at 4:52 PM, Peter Maydell <peter.mayd...@linaro.org> > wrote: >> On 1 April 2011 16:20, Michael Roth <mdr...@linux.vnet.ibm.com> wrote: >>> We also make C99 //comments a warning instead of an error, since they >>> don't actually violate QEMU's coding guidelines. >> >> We should either update the guidelines or fix the script... > > There are a whole bunch of // in the codebase. I prefer /* */ but as > it stands I think // should not even raise a warning.
I don't care much either, really. I just don't think we should be introducing random coding standards rules by the back door because checkpatch happens to complain about them. -- PMM
