[Qemu-devel] [PATCH 03/15] Fix a few coding style violations in cpus.c

2011-02-07 Thread Jan Kiszka
No functional changes. Signed-off-by: Jan Kiszka --- cpus.c | 71 +++ 1 files changed, 44 insertions(+), 27 deletions(-) diff --git a/cpus.c b/cpus.c index cd764f2..e93d8b9 100644 --- a/cpus.c +++ b/cpus.c @@ -130,10 +130,12 @@ stati

Re: [Qemu-devel] [PATCH] block/vdi: Fix wrong size in conditionally used memset, memcmp

2011-02-07 Thread Kevin Wolf
Am 04.02.2011 21:19, schrieb Anthony Liguori: > On 02/04/2011 02:01 PM, Stefan Weil wrote: >> Error report from cppcheck: >> block/vdi.c:122: error: Using sizeof for array given as function argument >> returns the size of pointer. >> block/vdi.c:128: error: Using sizeof for array given as function

Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift

2011-02-07 Thread Anthony Liguori
On 02/07/2011 07:14 AM, Avi Kivity wrote: On 02/07/2011 03:11 PM, Anthony Liguori wrote: On 02/07/2011 06:34 AM, Avi Kivity wrote: On 02/04/2011 10:56 AM, Jan Kiszka wrote: > > This should be a rare event. If you are missing 50% of your > notifications, not amount of gradual catchup is goin

[Qemu-devel] Re: RFC: New API for PPC for vcpu mmu access

2011-02-07 Thread Avi Kivity
On 02/03/2011 11:19 AM, Alexander Graf wrote: > > I have no idea what things will look like 10 years down the road, but > currently e500mc has 576 entries (512 TLB0, 64 TLB1). That sums up to 64 * 576 bytes, which is 36kb. Ouch. Certainly nothing we want to transfer every time qemu feels like

[Qemu-devel] [PATCH v3] Softfloat: Add support to softfloat to return floatxx_default_nan when, the corresponding target status flag is set.

2011-02-07 Thread Christophe Lyon
Some CPUs have a status flag imposing to return floatxx_default_nan whatever the input value, when converting from one FP format to another. Implement this, using the already existing default_nan_mode status flag (currently used on ARM and SH4 at the moment). Signed-off-by: Christophe Lyon ---

[Qemu-devel] new->old version migration

2011-02-07 Thread Michael S. Tsirkin
New thread stated intentionally, the original patch is Message-ID: <349e93a4cfc6e1effc1b681cae53f805fdb9624e.1296713825.git.amit.s...@redhat.com> On Thu, Feb 03, 2011 at 11:47:08AM +0530, Amit Shah wrote: > Add a compat property for older machine types. When this is used (via > -M pc-0.13, for ex

[Qemu-devel] Re: [PATCH] e1000: clear EOP for multi-buffer descriptors

2011-02-07 Thread Alex Williamson
On Mon, 2011-02-07 at 14:30 +0200, Michael S. Tsirkin wrote: > The e1000 spec says: if software statically allocates > buffers, and uses memory read to check for completed descriptors, it > simply has to zero the status byte in the descriptor to make it ready > for reuse by hardware. This is not a

Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift

2011-02-07 Thread Jan Kiszka
On 2011-02-07 15:54, Anthony Liguori wrote: > On 02/07/2011 08:43 AM, Jan Kiszka wrote: >> On 2011-02-07 15:28, Anthony Liguori wrote: >> >>> On 02/07/2011 08:10 AM, Jan Kiszka wrote: >>> Again: please not in an ad-hoc fashion but as a generic services usable by _all_ periodic t

[Qemu-devel] [STABLE 0.14][PULL 00/14] Block patches for stable-0.14

2011-02-07 Thread Kevin Wolf
The following changes since commit fd08f20c23465c82c62187d463dacc6d00f79508: do not pass NULL to strdup. (2011-02-04 21:23:05 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-stable-0.14 Alexander Graf (5): ahci: add license header in ahci.h ahci

[Qemu-devel] Re: [SeaBIOS] IO APIC emulation failure with qemu-kvm

2011-02-07 Thread Ravi Kumar Kulkarni
On Mon, Feb 7, 2011 at 2:59 PM, Avi Kivity wrote: > On 02/07/2011 11:24 AM, Ravi Kumar Kulkarni wrote: >> >> On Mon, Feb 7, 2011 at 2:19 PM, Avi Kivity  wrote: >> >  On 02/07/2011 10:33 AM, Ravi Kumar Kulkarni wrote: >> >> >> >>  On Sun, Feb 6, 2011 at 10:50 PM, Avi Kivity    wrote: >> >>> >> >>>

[Qemu-devel] [PATCH] qemu-timer.c: fix build on windows.

2011-02-07 Thread Tristan Gingold
The function qemu_next_alarm_deadline is needed by windows. Signed-off-by: Tristan Gingold --- qemu-timer.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index 658f637..f81300b 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@ -708,8 +708,6

[Qemu-devel] [PATCH 3/9] linux-user: add ppoll syscall support

2011-02-07 Thread Mike Frysinger
Some architectures (like Blackfin) only implement ppoll (and skip poll). So add support for it using existing poll code. Reviewed-by: Peter Maydell Signed-off-by: Mike Frysinger --- linux-user/syscall.c | 57 - 1 files changed, 55 insertions(+),

[Qemu-devel] Re: [PATCH] e1000: clear EOP for multi-buffer descriptors

2011-02-07 Thread Stefan Hajnoczi
On Mon, Feb 07, 2011 at 02:30:26PM +0200, Michael S. Tsirkin wrote: > The e1000 spec says: if software statically allocates > buffers, and uses memory read to check for completed descriptors, it > simply has to zero the status byte in the descriptor to make it ready > for reuse by hardware. This is

[Qemu-devel] Re: [SeaBIOS] IO APIC emulation failure with qemu-kvm

2011-02-07 Thread Avi Kivity
On 02/07/2011 12:28 PM, Ravi Kumar Kulkarni wrote: On Mon, Feb 7, 2011 at 3:24 PM, Avi Kivity wrote: > On 02/07/2011 11:47 AM, Ravi Kumar Kulkarni wrote: >> >> > >> >That is not the same address. And the code you posted doesn't make any >> >sense. >> > >>sorry for the mistake.

[Qemu-devel] Re: [PATCH master/0.14 2/2] virtio-serial: Add older machine compat property for flow control

2011-02-07 Thread Michael S. Tsirkin
On Mon, Feb 07, 2011 at 08:47:11AM -0700, Alex Williamson wrote: > On Thu, 2011-02-03 at 11:47 +0530, Amit Shah wrote: > > Add a compat property for older machine types. When this is used (via > > -M pc-0.13, for example), the new flow control mechanisms will not be > > used. This is done to keep

Re: [Qemu-devel] [PATCH 03/16] qdev-properties: add PROP_TYPE_ENUM

2011-02-07 Thread Anthony Liguori
On 02/07/2011 04:43 AM, Alon Levy wrote: On Mon, Feb 07, 2011 at 09:53:44AM +0100, Markus Armbruster wrote: I haven't been able to follow the evolution of this series, my apologies if I'm missing things already discussed. Alon Levy writes: Example usage: EnumTable foo_enum_table[]

Re: [Qemu-devel] [PATCH] Softfloat: Add support to softfloat to return floatxx_default_nan when the corresponding target status flag is set.

2011-02-07 Thread Christophe Lyon
On 04.02.2011 20:47, Aurelien Jarno wrote: > On Fri, Feb 04, 2011 at 02:44:48PM +, Peter Maydell wrote: >> On 4 February 2011 14:01, Christophe Lyon wrote: >> >> The target-specific #ifdef is pretty ugly. I wanted to be safe (not breaking other targets), and as there are already some #ifdef i

[Qemu-devel] [STABLE 0.14][PATCH 09/14] ahci: make number of ports runtime determined

2011-02-07 Thread Kevin Wolf
From: Alexander Graf Different AHCI controllers have a different number of ports, so the core shouldn't care about the amount of ports available. This patch makes the number of ports available to the AHCI core runtime configurable, allowing us to have multiple different AHCI implementations with

Re: [Qemu-devel] Buildbot for qemu.git/master

2011-02-07 Thread Stefan Hajnoczi
On Mon, Feb 7, 2011 at 3:02 PM, Richard W.M. Jones wrote: > > On Sat, Feb 05, 2011 at 04:36:11PM +, Stefan Hajnoczi wrote: >> Occassionally a commit that breaks the build gets merged into >> qemu.git/master.  Build testing manually across all host platforms is >> not feasible for most develope

[Qemu-devel] [STABLE 0.14][PATCH 11/14] blockdev: add refcount to DriveInfo

2011-02-07 Thread Kevin Wolf
From: Marcelo Tosatti The host part of a block device can be deleted with in progress block migration. To fix this, add a reference count to DriveInfo, freeing resources on last reference. Signed-off-by: Marcelo Tosatti CC: Markus Armbruster Signed-off-by: Kevin Wolf (cherry picked from comm

Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift

2011-02-07 Thread Jan Kiszka
On 2011-02-07 16:13, Avi Kivity wrote: > On 02/07/2011 05:01 PM, Anthony Liguori wrote: >> >> typedef struct PeriodicTimer PeriodicTimer; >> >> /** >> * @accumulated_ticks: the number of unacknowledged ticks in total >> since the creation of the timer >> **/ > > Outdated comment even before th

[Qemu-devel] Re: [SeaBIOS] IO APIC emulation failure with qemu-kvm

2011-02-07 Thread Avi Kivity
On 02/04/2011 03:58 PM, Jan Kiszka wrote: > when i run my kernel image with qemu-kvm it gives emulation error failure > trying to execute the code outside ROM or RAM at fec0(IO APIC base address) > but the same code runs fine with qemu. can anyone please point me > where might be the pr

[Qemu-devel] [PATCH 11/15] kvm: Remove unneeded memory slot reservation

2011-02-07 Thread Jan Kiszka
The number of slots and the location of private ones changed several times in KVM's early days. However, it's stable since 2.6.29 (our required baseline), and slots 8..11 are no longer reserved since then. So remove this unneeded restriction. Signed-off-by: Jan Kiszka CC: Alex Williamson --- kv

[Qemu-devel] [PATCH 0.14] slirp: fix buffer overrun

2011-02-07 Thread Bruce Rogers
Since the addition of the slirp member to struct mbuf, the value of SLIRP_MSIZE and the initialization of m_size have not been correct, resulting in overrunning the end of the malloc'd buffer in some cases. Signed-off-by: Bruce Rogers --- slirp/mbuf.c |4 ++-- 1 files changed, 2 insertions(+

[Qemu-devel] [PULL 00/14] Block patches for master

2011-02-07 Thread Kevin Wolf
The following changes since commit ad36ce8ba95a756ef558579c6e9ecedfae4dfd0b: checkpatch.pl: don't complain about old lines with tabs (2011-02-05 13:18:20 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git block Alexander Graf (5): ahci: add license header i

Re: [Qemu-devel] [PATCH] configure: allow user to override cflags.

2011-02-07 Thread Markus Armbruster
Anthony Liguori writes: > On 02/07/2011 08:05 AM, Tristan Gingold wrote: >> In order to allow user to override cflags, predefined flags must be inserted >> before user cflags. >> >> Signed-off-by: Tristan Gingold >> > > I think there's a very specific reason we do it this way but I cannot > r

[Qemu-devel] [PATCH 13/14] Add flag to indicate external users to block device

2011-02-07 Thread Kevin Wolf
From: Marcelo Tosatti Certain operations such as drive_del or resize cannot be performed while external users (eg. block migration) reference the block device. Add a flag to indicate that. Signed-off-by: Marcelo Tosatti Signed-off-by: Kevin Wolf --- block.c | 11 +++ block.h

[Qemu-devel] Re: Buildbot for qemu.git/master

2011-02-07 Thread Alexander Graf
On 07.02.2011, at 15:36, Stefan Hajnoczi wrote: > On Mon, Feb 7, 2011 at 1:00 PM, Alexander Graf wrote: >> >> On 05.02.2011, at 21:32, Stefan Hajnoczi wrote: >> >>> Here is the buildbot. It currently has a debian-x86_64 slave building >>> qemu.git/master every 24 hours: >>> http://buildbot.vm

[Qemu-devel] [PATCH 7/7] ccid: configure: improve --enable-smartcard flags

2011-02-07 Thread Alon Levy
* add --enable-smartcard and --disable-smartcard flags * let the nss check only disable building the ccid-card-emulated device * report only if nss is found or not, not smartcard build inclusion * don't link with NSS if --disable-smartcard-nss --- Makefile.objs |3 ++- Makefile.target |

[Qemu-devel] [PATCH 3/7] ccid: add passthru card device

2011-02-07 Thread Alon Levy
The passthru ccid card is a device sitting on the usb-ccid bus and using a chardevice to communicate with a remote device using the VSCard protocol defined in libcacard/vscard_common.h Usage docs available in following patch in docs/ccid.txt Signed-off-by: Alon Levy --- Changes from v18->v19:

[Qemu-devel] Re: [PULL 00/14] Block patches for master

2011-02-07 Thread Anthony Liguori
On 02/07/2011 06:40 AM, Kevin Wolf wrote: The following changes since commit ad36ce8ba95a756ef558579c6e9ecedfae4dfd0b: checkpatch.pl: don't complain about old lines with tabs (2011-02-05 13:18:20 +) Pulled. Thanks. Regards, Anthony Liguori are available in the git repository a

[Qemu-devel] [PATCH 2/9] linux-user/elfload: add FDPIC support

2011-02-07 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- elf.h| 19 + linux-user/elfload.c | 71 ++ linux-user/qemu.h|7 + 3 files changed, 97 insertions(+), 0 deletions(-) diff --git a/elf.h b/elf.h index 7067c90..d2f24f4 1006

[Qemu-devel] Re: [PATCH 15/15] kvm: x86: Introduce kvmclock device to save/restore its state

2011-02-07 Thread Jan Kiszka
On 2011-02-07 14:40, Glauber Costa wrote: > On Mon, 2011-02-07 at 13:36 +0100, Jan Kiszka wrote: >> On 2011-02-07 13:27, Glauber Costa wrote: >>> On Mon, 2011-02-07 at 12:19 +0100, Jan Kiszka wrote: If kvmclock is used, which implies the kernel supports it, register a kvmclock device with

Re: [Qemu-devel] New stable branch information

2011-02-07 Thread Anthony Liguori
On 02/05/2011 03:11 AM, Michael Tokarev wrote: 04.02.2011 15:25, Anthony Liguori wrote: To help make the stable branch more active than it has been in the past, I'd like to split the stable branch into a separate tree to allow the tree to develop a life of its own over time. What's th

[Qemu-devel] Re: [SeaBIOS] IO APIC emulation failure with qemu-kvm

2011-02-07 Thread Avi Kivity
On 02/07/2011 11:24 AM, Ravi Kumar Kulkarni wrote: On Mon, Feb 7, 2011 at 2:19 PM, Avi Kivity wrote: > On 02/07/2011 10:33 AM, Ravi Kumar Kulkarni wrote: >> >> On Sun, Feb 6, 2011 at 10:50 PM, Avi Kivitywrote: >>> >>> >On 02/04/2011 03:58 PM, Jan Kiszka wrote: >> >

[Qemu-devel] [PATCH] e1000: clear EOP for multi-buffer descriptors

2011-02-07 Thread Michael S. Tsirkin
The e1000 spec says: if software statically allocates buffers, and uses memory read to check for completed descriptors, it simply has to zero the status byte in the descriptor to make it ready for reuse by hardware. This is not a hardware requirement (moving the hardware tail pointer is), but is ne

[Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus

2011-02-07 Thread Alon Levy
A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it, a passthru card and an emulated card. [1] http://www.usb.org/developers/devclass_docs/DWG_Smart-Card_CCID_R

[Qemu-devel] [PATCH 0/7] usb-ccid (v19)

2011-02-07 Thread Alon Levy
This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone emulated card. It also introduces a new directory libcaccard with CAC card emulation, CAC is a type of

[Qemu-devel] Re: new->old version migration

2011-02-07 Thread Michael S. Tsirkin
On Mon, Feb 07, 2011 at 09:40:14AM -0700, Alex Williamson wrote: > On Mon, 2011-02-07 at 18:07 +0200, Michael S. Tsirkin wrote: > > New thread stated intentionally, the original patch is Message-ID: > > <349e93a4cfc6e1effc1b681cae53f805fdb9624e.1296713825.git.amit.s...@redhat.com> > > > > On Thu,

Re: [Qemu-devel] [PATCH] Remove a detached device from qemu_device_opts.

2011-02-07 Thread William Dauchy
On Thu, 2011-01-27 at 18:00 +0900, Ken'ichi Ohmichi wrote: > Hi, > > When I tried to attach the interface after detaching the same interface, > the virsh command output the following and it failed: > > # virsh detach-interface Domain01 network --mac 52:54:00:0d:78:92 > Interface detached succ

[Qemu-devel] [PATCH 12/14] block-migration: add reference to target DriveInfo

2011-02-07 Thread Kevin Wolf
From: Marcelo Tosatti So that ejection of attached device by guest does not free data in use by block migration instance. Signed-off-by: Marcelo Tosatti CC: Markus Armbruster Signed-off-by: Kevin Wolf --- block-migration.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --

[Qemu-devel] [STABLE 0.14][PATCH 06/14] ahci: split ICH and AHCI even more

2011-02-07 Thread Kevin Wolf
From: Alexander Graf Sebastian's patch already did a pretty good job at splitting up ICH-9 AHCI code and the AHCI core. We need some more though. Copyright was missing, the lspci dump belongs to ICH-9, we don't need the AHCI core to have its own qdev device duplicate. So let's split them a bit m

[Qemu-devel] [PATCH 06/14] ahci: split ICH and AHCI even more

2011-02-07 Thread Kevin Wolf
From: Alexander Graf Sebastian's patch already did a pretty good job at splitting up ICH-9 AHCI code and the AHCI core. We need some more though. Copyright was missing, the lspci dump belongs to ICH-9, we don't need the AHCI core to have its own qdev device duplicate. So let's split them a bit m

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-07 Thread Anthony Liguori
On 02/07/2011 11:10 AM, Jan Kiszka wrote: On 2011-02-07 17:23, Paolo Bonzini wrote: On 02/07/2011 05:03 PM, Marcelo Tosatti wrote: Is there any other issue that prevents turning CONFIG_IOTHREAD on by default? I think Windows support. Signal support is actually easy because w

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-07 Thread Edgar E. Iglesias
On Mon, Feb 07, 2011 at 08:12:55AM -0200, Marcelo Tosatti wrote: > On Tue, Jan 25, 2011 at 11:34:53AM -0200, Marcelo Tosatti wrote: > > On Tue, Jan 25, 2011 at 10:17:41AM +0100, Edgar E. Iglesias wrote: > > > On Mon, Jan 24, 2011 at 04:28:48PM -0600, Anthony Liguori wrote: > > > > On 01/24/2011 03:

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-07 Thread Aurelien Jarno
On Mon, Feb 07, 2011 at 02:03:50PM -0200, Marcelo Tosatti wrote: > On Mon, Feb 07, 2011 at 08:12:55AM -0200, Marcelo Tosatti wrote: > > > > One more thing I didn't mention on the email-thread or on IRC is > > > > that last time I checked, qemu with io-thread was performing > > > > significantly slo

Re: [Qemu-devel] [PATCH 15/15] kvm: x86: Introduce kvmclock device to save/restore its state

2011-02-07 Thread Blue Swirl
On Mon, Feb 7, 2011 at 1:19 PM, Jan Kiszka wrote: > If kvmclock is used, which implies the kernel supports it, register a > kvmclock device with the sysbus. Its main purpose is to save and restore > the kernel state on migration, but this will also allow to visualize it > one day. > > Signed-off-b

[Qemu-devel] [STABLE 0.14][PATCH 14/14] block: enable in_use flag

2011-02-07 Thread Kevin Wolf
From: Marcelo Tosatti Set block device in use during block migration, disallow drive_del and bdrv_truncate for in use devices. Signed-off-by: Marcelo Tosatti Signed-off-by: Kevin Wolf (cherry picked from commit 8591675f44929a9e4b5d3a5fd702a4b6d41c7903) --- block-migration.c |2 ++ block.c

Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift

2011-02-07 Thread Jan Kiszka
On 2011-02-07 14:23, Anthony Liguori wrote: > On 02/07/2011 07:14 AM, Avi Kivity wrote: >> On 02/07/2011 03:11 PM, Anthony Liguori wrote: >>> On 02/07/2011 06:34 AM, Avi Kivity wrote: On 02/04/2011 10:56 AM, Jan Kiszka wrote: > > > > This should be a rare event. If you are missing 50

[Qemu-devel] Re: new->old version migration

2011-02-07 Thread Anthony Liguori
On 02/07/2011 10:51 AM, Michael S. Tsirkin wrote: On Mon, Feb 07, 2011 at 09:40:14AM -0700, Alex Williamson wrote: On Mon, 2011-02-07 at 18:07 +0200, Michael S. Tsirkin wrote: New thread stated intentionally, the original patch is Message-ID: <349e93a4cfc6e1effc1b681cae53f805fdb9624e.

[Qemu-devel] Re: RFC: New API for PPC for vcpu mmu access

2011-02-07 Thread Scott Wood
On Mon, 7 Feb 2011 16:43:02 +0100 Alexander Graf wrote: > On 04.02.2011, at 23:33, Scott Wood wrote: > > > On Thu, 3 Feb 2011 10:19:06 +0100 > > Alexander Graf wrote: > > > >> Makes sense. So we basically need an ioctl that tells KVM the MMU type and > >> TLB size. Remember, the userspace too

[Qemu-devel] Re: [PATCH 00/17] LatticeMico32 target

2011-02-07 Thread Alexander Graf
On 31.01.2011, at 01:30, Michael Walle wrote: > This patchset adds support for the LatticeMico32 softcore processor by > Lattice Semiconductor. > > This is the first part of a larger patchset. It adds target support and two > simple BSPs. The second part will add support for the milkymist hardwa

Re: [Qemu-devel] Re: [PATCH] qemu-timer: Fix compilation of new timer code for w32, w64

2011-02-07 Thread Blue Swirl
Thanks, applied. On Sat, Feb 5, 2011 at 5:36 PM, Paolo Bonzini wrote: > On 02/04/2011 10:01 PM, Stefan Weil wrote: >> >> qemu_next_alarm_deadline() is needed by MinGW, too. >> >> Cc: Paolo Bonzini >> Cc: Anthony Liguori >> Signed-off-by: Stefan Weil >> --- >>  qemu-timer.c |    4 ++-- >>  1 files

[Qemu-devel] [PATCH 5/7] ccid: add ccid-card-emulated device

2011-02-07 Thread Alon Levy
This devices uses libcacard (internal) to emulate a smartcard conforming to the CAC standard. It attaches to the usb-ccid bus. Usage instructions (example command lines) are in the following patch in docs/ccid.txt. It uses libcacard which uses nss, so it can work with both hw cards and certificates

[Qemu-devel] Re: new->old version migration

2011-02-07 Thread Anthony Liguori
On 02/07/2011 10:07 AM, Michael S. Tsirkin wrote: New thread stated intentionally, the original patch is Message-ID: <349e93a4cfc6e1effc1b681cae53f805fdb9624e.1296713825.git.amit.s...@redhat.com> On Thu, Feb 03, 2011 at 11:47:08AM +0530, Amit Shah wrote: Add a compat property for older mach

[Qemu-devel] Re: new->old version migration

2011-02-07 Thread Michael S. Tsirkin
On Mon, Feb 07, 2011 at 01:33:57PM -0600, Anthony Liguori wrote: > On 02/07/2011 10:07 AM, Michael S. Tsirkin wrote: > >New thread stated intentionally, the original patch is Message-ID: > ><349e93a4cfc6e1effc1b681cae53f805fdb9624e.1296713825.git.amit.s...@redhat.com> > > > >On Thu, Feb 03, 2011 at

[Qemu-devel] Re: new->old version migration

2011-02-07 Thread Alex Williamson
On Mon, 2011-02-07 at 18:07 +0200, Michael S. Tsirkin wrote: > New thread stated intentionally, the original patch is Message-ID: > <349e93a4cfc6e1effc1b681cae53f805fdb9624e.1296713825.git.amit.s...@redhat.com> > > On Thu, Feb 03, 2011 at 11:47:08AM +0530, Amit Shah wrote: > > Add a compat propert

Re: [Qemu-devel] [PATCH v3 01/16] vnc: qemu can die if the client is disconnected while updating screen

2011-02-07 Thread Alexander Graf
On 04.02.2011, at 13:51, Anthony Liguori wrote: > On 02/04/2011 02:05 AM, Corentin Chary wrote: >> agraf reported that qemu_mutex_destroy(vs->output_mutex) while failing >> in vnc_disconnect_finish(). >> >> It's because vnc_worker_thread_loop() tries to unlock the mutex while >> not locked. The

Re: [Qemu-devel] [PATCH 00/16] usb-ccid (v18)

2011-02-07 Thread Anthony Liguori
On 02/07/2011 09:56 AM, Eric Blake wrote: [adding libvir-list as well] On 02/07/2011 08:44 AM, Alon Levy wrote: I guess I'll wait a little longer for more feedback? Should I split the enum property separately? it's only used by ccid-card-emualted atm. The only non-cosmetic conc

Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift

2011-02-07 Thread Anthony Liguori
On 02/07/2011 09:29 AM, Avi Kivity wrote: On 02/07/2011 05:17 PM, Jan Kiszka wrote: On 2011-02-07 16:13, Avi Kivity wrote: > On 02/07/2011 05:01 PM, Anthony Liguori wrote: >> >> typedef struct PeriodicTimer PeriodicTimer; >> >> /** >> * @accumulated_ticks: the number of unacknowledged tick

Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift

2011-02-07 Thread Anthony Liguori
On 02/07/2011 09:20 AM, Jan Kiszka wrote: On 2011-02-07 16:13, Avi Kivity wrote: PeriodicTimer *periodic_timer_new(PeriodicTimerFunc *cb, void *opaque); void periodic_timer_init(PeriodicTimer *timer, PeriodicTimerFunc *cb); It is better to embed than to reference. And embed

Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift

2011-02-07 Thread Anthony Liguori
On 02/07/2011 08:10 AM, Jan Kiszka wrote: Again: please not in an ad-hoc fashion but as a generic services usable by _all_ periodic timer sources that want to implement compensation. This infrastructure should also be designed to once integrate IRQ coalescing information as well. The point why I

Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift

2011-02-07 Thread Avi Kivity
On 02/07/2011 05:17 PM, Jan Kiszka wrote: On 2011-02-07 16:13, Avi Kivity wrote: > On 02/07/2011 05:01 PM, Anthony Liguori wrote: >> >> typedef struct PeriodicTimer PeriodicTimer; >> >> /** >> * @accumulated_ticks: the number of unacknowledged ticks in total >> since the creation of the ti

Re: [Qemu-devel] [PING 0.14] Missing patches (mostly fixes)

2011-02-07 Thread Stefan Weil
Am 07.02.2011 19:54, schrieb Luiz Capitulino: This wasn't denied, what Markus said is that this is test code and thus it isn't high priority for the (now released) 0.14 release. That's ok. Fixing the code in master is fine. Thanks, Stefan

[Qemu-devel] Re: [PATCH 15/15] kvm: x86: Introduce kvmclock device to save/restore its state

2011-02-07 Thread Glauber Costa
On Mon, 2011-02-07 at 13:36 +0100, Jan Kiszka wrote: > On 2011-02-07 13:27, Glauber Costa wrote: > > On Mon, 2011-02-07 at 12:19 +0100, Jan Kiszka wrote: > >> If kvmclock is used, which implies the kernel supports it, register a > >> kvmclock device with the sysbus. Its main purpose is to save and

Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift

2011-02-07 Thread Jan Kiszka
On 2011-02-07 16:01, Anthony Liguori wrote: > On 02/07/2011 08:57 AM, Jan Kiszka wrote: >> There should rather be a special vmstate struct for PeriodicTimer, just >> like we already have for normal timers. >> > > Agreed. > >>> It's convenient because then if we lose ticks in the PeriodicTimer

[Qemu-devel] [Bug 714629] [NEW] BIOS doesn't load when read() returns less than the full ROM length

2011-02-07 Thread Matthew Bloch
Public bug reported: When qemu is running over a 9p filesystem (e.g. when running underneath -virtfs of another qemu), and probably some other network filesystems, it fails to read its BIOS image. This is because it uses a single low- level read() call on the bios.bin, asking for the full file.

Re: [Qemu-devel] [PATCH 00/16] usb-ccid (v18)

2011-02-07 Thread Alon Levy
On Mon, Feb 07, 2011 at 08:56:30AM -0700, Eric Blake wrote: > [adding libvir-list as well] > > On 02/07/2011 08:44 AM, Alon Levy wrote: > >>> I guess I'll wait a little longer for more feedback? Should I split > >>> the enum property separately? it's only used by ccid-card-emualted atm. > >> > >>

[Qemu-devel] [PATCH 01/14] qcow2: Really use cache=unsafe for image creation

2011-02-07 Thread Kevin Wolf
For cache=unsafe we also need to set BDRV_O_CACHE_WB, otherwise we have some strange unsafe writethrough mode. Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi --- block/qcow2.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index

Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift

2011-02-07 Thread Anthony Liguori
On 02/07/2011 08:43 AM, Jan Kiszka wrote: On 2011-02-07 15:28, Anthony Liguori wrote: On 02/07/2011 08:10 AM, Jan Kiszka wrote: Again: please not in an ad-hoc fashion but as a generic services usable by _all_ periodic timer sources that want to implement compensation. This infrastruct

Re: [Qemu-devel] Re: Buildbot for qemu.git/master

2011-02-07 Thread Alexander Graf
On 07.02.2011, at 22:18, Stefan Hajnoczi wrote: > On Mon, Feb 7, 2011 at 7:03 PM, Luiz Capitulino > wrote: >> On Sat, 5 Feb 2011 20:32:06 + >> Stefan Hajnoczi wrote: >> >>> Here is the buildbot. It currently has a debian-x86_64 slave building >>> qemu.git/master every 24 hours: >>> http:

[Qemu-devel] [PATCH 05/14] ahci: add license header in ahci.h

2011-02-07 Thread Kevin Wolf
From: Alexander Graf Due to popular request, this patch adds a license header to ahci.h Signed-off-by: Alexander Graf Signed-off-by: Kevin Wolf --- hw/ide/ahci.h | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/hw/ide/ahci.h b/hw/ide/ahci.h index

Re: [Qemu-devel] [PATCH] Softfloat: Add support to softfloat to return floatxx_default_nan when the corresponding target status flag is set.

2011-02-07 Thread Peter Maydell
On 7 February 2011 10:17, Christophe Lyon wrote: > I was also wondering about the float16 case? The ARM ARM describes it > uses default_nan too, but I couldn't find that right piece of code to patch > in softfloat. Any idea? It seems to behave a bit differently from other FP > formats. Hm. My sug

[Qemu-devel] Re: RFC: New API for PPC for vcpu mmu access

2011-02-07 Thread Alexander Graf
On 07.02.2011, at 17:40, Yoder Stuart-B08248 wrote: > >>> A fixed array does mean you wouldn't have to worry about whether qemu >>> supports the more advanced struct format if fields are added -- you >>> can just unconditionally write it, as long as it's backwards >>> compatible. Unless you hit

[Qemu-devel] [PATCH 2/7] introduce libcacard/vscard_common.h

2011-02-07 Thread Alon Levy
--- Signed-off-by: Alon Levy v15->v16 changes: Protocol change: * VSCMsgInit capabilities and magic * removed ReaderResponse, will use Error instead with code==VSC_SUCCESS. * adaded Flush and FlushComplete, remove Reconnect. * define VSCARD_MAGIC * added error code VSC_SUCCESS. Fixes: *

Re: [Qemu-devel] [PATCH] configure: allow user to override cflags.

2011-02-07 Thread Anthony Liguori
On 02/07/2011 08:05 AM, Tristan Gingold wrote: In order to allow user to override cflags, predefined flags must be inserted before user cflags. Signed-off-by: Tristan Gingold I think there's a very specific reason we do it this way but I cannot remember at the moment. Regards, Anthony

Re: [Qemu-devel] [PATCH 00/16] usb-ccid (v18)

2011-02-07 Thread Anthony Liguori
On 02/07/2011 05:03 AM, Alon Levy wrote: Hi, I have a v19 waiting to be sent, but it's basically the same just with patches folded were appropriate, and the fixes Markus pointed out for the Enumeration property type. I guess I'll wait a little longer for more feedback? Should I split the en

[Qemu-devel] [PATCH v2] Softfloat: Add support to softfloat to return floatxx_default_nan when, the corresponding target status flag is set.

2011-02-07 Thread Christophe Lyon
Some CPUs have a status flag imposing to return floatxx_default_nan whatever the input value, when converting from one FP format to another. Implement this, using the already existing default_nan_mode status flag (currently used on ARM and SH4 at the moment). Signed-off-by: Christophe Lyon --- N

[Qemu-devel] [PATCH] configure: allow user to override cflags.

2011-02-07 Thread Tristan Gingold
In order to allow user to override cflags, predefined flags must be inserted before user cflags. Signed-off-by: Tristan Gingold --- configure |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 598e8e1..f18ed0d 100755 --- a/configure +++ b/co

[Qemu-devel] [PATCH 02/14] Documentation: add Sheepdog disk images

2011-02-07 Thread Kevin Wolf
From: MORITA Kazutaka Signed-off-by: MORITA Kazutaka Signed-off-by: Kevin Wolf --- qemu-doc.texi | 52 1 files changed, 52 insertions(+), 0 deletions(-) diff --git a/qemu-doc.texi b/qemu-doc.texi index 22a8663..86e017c 100644 --- a/qemu-d

[Qemu-devel] [STABLE 0.14][PATCH 02/14] Documentation: add Sheepdog disk images

2011-02-07 Thread Kevin Wolf
From: MORITA Kazutaka Signed-off-by: MORITA Kazutaka Signed-off-by: Kevin Wolf (cherry picked from commit 42af9c30ea9a963ce604ac96230fde2f987634db) --- qemu-doc.texi | 52 1 files changed, 52 insertions(+), 0 deletions(-) diff --git a/qem

Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift

2011-02-07 Thread Jan Kiszka
On 2011-02-07 15:28, Anthony Liguori wrote: > On 02/07/2011 08:10 AM, Jan Kiszka wrote: >> Again: please not in an ad-hoc fashion but as a generic services usable >> by _all_ periodic timer sources that want to implement compensation. >> This infrastructure should also be designed to once integrate

[Qemu-devel] Re: [PATCH master/0.14 1/2] virtio-serial: Use a struct to pass config information from proxy

2011-02-07 Thread Alex Williamson
On Thu, 2011-02-03 at 11:47 +0530, Amit Shah wrote: > Instead of using a single variable to pass to the virtio_serial_init > function, use a struct so that expanding the number of variables to be > passed on later is easier. > > Signed-off-by: Amit Shah > --- > hw/virtio-pci.c| 12

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-07 Thread Scott Wood
On Mon, 7 Feb 2011 14:03:50 -0200 Marcelo Tosatti wrote: > Is there any other issue that prevents turning CONFIG_IOTHREAD on by > default? > This patch is needed for ppce500_mpc8544ds and ppc440_bamboo to work with I/O thread enabled: http://patchwork.ozlabs.org/patch/66743/ -Scott

[Qemu-devel] RE: RFC: New API for PPC for vcpu mmu access

2011-02-07 Thread Yoder Stuart-B08248
> -Original Message- > From: Wood Scott-B07421 > Sent: Monday, February 07, 2011 12:52 PM > To: Alexander Graf > Cc: Yoder Stuart-B08248; Wood Scott-B07421; kvm-...@vger.kernel.org; > k...@vger.kernel.org; qemu-devel@nongnu.org > Subject: Re: RFC: New API for PPC for vcpu mmu access > >

Re: [Qemu-devel] Re: Buildbot for qemu.git/master

2011-02-07 Thread Stefan Hajnoczi
On Mon, Feb 7, 2011 at 7:03 PM, Luiz Capitulino wrote: > On Sat, 5 Feb 2011 20:32:06 + > Stefan Hajnoczi wrote: > >> Here is the buildbot.  It currently has a debian-x86_64 slave building >> qemu.git/master every 24 hours: >> http://buildbot.vmsplice.net/ > > Nice, what about also building ma

Re: [Qemu-devel] [PATCH 7/8] target-arm: implement vsli.64, vsri.64

2011-02-07 Thread Peter Maydell
On 31 January 2011 18:06, wrote: > From: Christophe Lyon > > Signed-off-by: Christophe Lyon > --- >  target-arm/translate.c |   11 ++- >  1 files changed, 10 insertions(+), 1 deletions(-) > > diff --git a/target-arm/translate.c b/target-arm/translate.c > index 61d4c4c..9150242 100644 >

Re: [Qemu-devel] Re: [PING 0.14] Missing patches (mostly fixes)

2011-02-07 Thread Anthony Liguori
On 02/05/2011 01:40 PM, riku voipio wrote: On 02/03/2011 12:16 PM, Laurent Vivier wrote: On Wed, Feb 02, 2011 at 08:28:15PM +0100, Stefan Weil wrote: [PATCH] linux-user: Fix possible realloc memory leak (http://patchwork.ozlabs.org/patch/79217/) Looks ok for me. And this one ? linux-user:

[Qemu-devel] Re: [SeaBIOS] IO APIC emulation failure with qemu-kvm

2011-02-07 Thread Avi Kivity
On 02/07/2011 11:47 AM, Ravi Kumar Kulkarni wrote: > > That is not the same address. And the code you posted doesn't make any > sense. > sorry for the mistake. here's the correct one (qemu) xp /20iw 0x1e2f3f7b 0x1e2f3f7b: (bad) 0x0

Re: [Qemu-devel] [PATCH 03/16] qdev-properties: add PROP_TYPE_ENUM

2011-02-07 Thread Markus Armbruster
Alon Levy writes: > On Mon, Feb 07, 2011 at 09:53:44AM +0100, Markus Armbruster wrote: >> I haven't been able to follow the evolution of this series, my apologies >> if I'm missing things already discussed. >> >> Alon Levy writes: >> >> > Example usage: >> > >> > EnumTable foo_enum_table[] = {

[Qemu-devel] [STABLE 0.14][PATCH 03/14] block/vdi: Fix wrong size in conditionally used memset, memcmp

2011-02-07 Thread Kevin Wolf
From: Stefan Weil Error report from cppcheck: block/vdi.c:122: error: Using sizeof for array given as function argument returns the size of pointer. block/vdi.c:128: error: Using sizeof for array given as function argument returns the size of pointer. Fix both by setting the correct size. The

[Qemu-devel] Re: [PATCH] Change snapshot_blkdev hmp to use correct argument type for device

2011-02-07 Thread Kevin Wolf
Am 04.02.2011 09:22, schrieb jes.soren...@redhat.com: > From: Jes Sorensen > > Pointed out by Markus > > Signed-off-by: Jes Sorensen Thanks, applied to the block branch. Kevin

[Qemu-devel] [PATCH 05/15] Refactor debug and vmstop request interface

2011-02-07 Thread Jan Kiszka
Instead of fiddling with debug_requested and vmstop_requested directly, introduce qemu_system_debug_request and turn qemu_system_vmstop_request into a public interface. This aligns those services with exiting ones in vl.c. Signed-off-by: Jan Kiszka --- cpus.c |9 + cpus.h |2

Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift

2011-02-07 Thread Anthony Liguori
On 02/07/2011 06:34 AM, Avi Kivity wrote: On 02/04/2011 10:56 AM, Jan Kiszka wrote: > > This should be a rare event. If you are missing 50% of your > notifications, not amount of gradual catchup is going to help you out. But that's the only thing this patch is after: lost ticks at QEMU lev

[Qemu-devel] [PATCH] vhost: disable on tap link down

2011-02-07 Thread Michael S. Tsirkin
qemu makes it possible to disable link at tap which is not communicated to the guest but causes all packets to be dropped. Handle this with vhost simply by moving to the userspace emulation. Note: it might be a good idea to make peer link status match tap in this case, so the guest gets an event

[Qemu-devel] [PATCH 4/9] linux-user: decode MAP_{UNINITIALIZED, EXECUTABLE} in strace

2011-02-07 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- linux-user/strace.c |4 linux-user/syscall_defs.h |1 + 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index bf9a0d9..a8786bb 100644 --- a/linux-user/strace.c +++ b/linux-user/strace.c @

Re: [Qemu-devel] [PATCH 15/15] kvm: x86: Introduce kvmclock device to save/restore its state

2011-02-07 Thread Jan Kiszka
On 2011-02-07 20:39, Blue Swirl wrote: > On Mon, Feb 7, 2011 at 1:19 PM, Jan Kiszka wrote: >> If kvmclock is used, which implies the kernel supports it, register a >> kvmclock device with the sysbus. Its main purpose is to save and restore >> the kernel state on migration, but this will also allow

[Qemu-devel] [PATCH 1/9] linux-user: fix sizeof handling for getsockopt

2011-02-07 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- linux-user/syscall.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 499c4d7..6116ab5 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -1448,7 +1448,7 @@ static abi_long

[Qemu-devel] Re: Buildbot for qemu.git/master

2011-02-07 Thread Stefan Hajnoczi
On Mon, Feb 7, 2011 at 8:30 AM, Daniel Gollub wrote: > How do you want to combine this service? > Share buildslave and merge the build-master? > > Actually the buildbot configuration for qemu-kvm.git and qemu.git should be > quite similar. We could also provide testing different qemu branches if y

[Qemu-devel] Re: new->old version migration

2011-02-07 Thread Anthony Liguori
On 02/07/2011 01:53 PM, Michael S. Tsirkin wrote: On Mon, Feb 07, 2011 at 01:33:57PM -0600, Anthony Liguori wrote: On 02/07/2011 10:07 AM, Michael S. Tsirkin wrote: New thread stated intentionally, the original patch is Message-ID: <349e93a4cfc6e1effc1b681cae53f805fdb9624e.1296713825.

  1   2   3   >