Andreas Färber writes:
> Am 28.01.2011 um 13:41 schrieb Markus Armbruster:
>
>> Andreas Färber writes:
>>
>>> From: Hervé Poussineau
>>>
>>> v1:
>>> * Rebased.
>>
>> Patch versioning goes below the --- line, so it doesn't end up in git.
>
> I disagree: I always put it into the commit message, s
Both patches look fine to me.
On Fri, Jan 28, 2011 at 04:50:59PM +0100, christophe.l...@st.com wrote:
> From: Christophe Lyon
>
> Handle corner cases where the addition of the rounding constant could
> cause overflows.
After applying this patch, I get the following gcc warning:
CCtranslate.o
cc1: warnings being treated
Hi,
On Tue, Jan 25, 2011 at 01:27:49PM +0100, Edgar E. Iglesias wrote:
> On Mon, Jan 10, 2011 at 07:23:46PM -0800, Richard Henderson wrote:
> > Special case deposits that are implementable with byte and word stores.
> > Otherwise implement with double-word shift plus rotates.
> >
> > Expose tcg_s
Am 29.01.2011 09:41, schrieb Blue Swirl:
> Variables l2_modified and l2_size are not really used, remove them.
> Spotted by GCC 4.6.0:
> CCblock/qcow2-refcount.o
> /src/qemu/block/qcow2-refcount.c: In function
> 'qcow2_update_snapshot_refcount':
> /src/qemu/block/qcow2-refcount.c:708:37: err
Currently linuxboot.bin and multiboot.bin option roms override int19
vector to intercept boot process. No sane option rom should do that.
Provide bev entry instead that will be called by BIOS if option rom
is selected for booting.
Signed-off-by: Gleb Natapov
---
Note that this patch should be ap
On 31.01.2011 09:20, Aurelien Jarno wrote:
> On Fri, Jan 28, 2011 at 04:50:59PM +0100, christophe.l...@st.com wrote:
>> From: Christophe Lyon
>>
>> Handle corner cases where the addition of the rounding constant could
>> cause overflows.
>
> After applying this patch, I get the following gcc warn
On Mon, Jan 31, 2011 at 10:35:30AM +0100, Christophe Lyon wrote:
> On 31.01.2011 09:20, Aurelien Jarno wrote:
> > On Fri, Jan 28, 2011 at 04:50:59PM +0100, christophe.l...@st.com wrote:
> >> From: Christophe Lyon
> >>
> >> Handle corner cases where the addition of the rounding constant could
> >>
On 01/27/2011 03:09 PM, Jan Kiszka wrote:
If we call qemu_cpu_kick more than once before the target was able to
process the signal, pthread_kill will fail, and qemu will abort. Prevent
this by avoiding the redundant signal.
Doesn't fit with the manual page (or with the idea that signals are
a
On 01/27/2011 03:09 PM, Jan Kiszka wrote:
If there is any pending request that requires us to leave the inner loop
if main_loop, makes sure we do this as soon as possible by enforcing
non-blocking IO processing.
At this change, move variable definitions out of the inner loop to
improve readabili
On Mon, Jan 31, 2011 at 10:44:14AM +0100, Aurelien Jarno wrote:
> On Mon, Jan 31, 2011 at 10:35:30AM +0100, Christophe Lyon wrote:
> > On 31.01.2011 09:20, Aurelien Jarno wrote:
> > > On Fri, Jan 28, 2011 at 04:50:59PM +0100, christophe.l...@st.com wrote:
> > >> From: Christophe Lyon
> > >>
> > >>
On 01/27/2011 04:33 PM, Jan Kiszka wrote:
Found by Stefan Hajnoczi: There is a race in kvm_cpu_exec between
checking for exit_request on vcpu entry and timer signals arriving
before KVM starts to catch them. Plug it by blocking both timer related
signals also on !CONFIG_IOTHREAD and process those
Please send in any agenda items you are interested incovering.
Thanks, Juan.
On 01/27/2011 03:10 PM, Jan Kiszka wrote:
Align with qemu-kvm and prepare for IO exit fix: There is no need to run
kvm_arch_process_irqchip_events in the inner VCPU loop. Any state change
this service processes will first cause an exit from kvm_cpu_exec
anyway. And we will have to reenter the ker
On 01/27/2011 03:09 PM, Jan Kiszka wrote:
This second round of patches focus on issues in cpus.c, primarily signal
related. The highlights are
- Add missing KVM_RUN continuation after I/O exits
- Fix for timer signal race in KVM entry code under !CONFIG_IOTHREAD
(based on Stefan's findin
On 01/28/2011 11:27 PM, Blue Swirl wrote:
On Fri, Jan 28, 2011 at 1:55 PM, Fabien Chouteau wrote:
On 01/27/2011 11:40 AM, Fabien Chouteau wrote:
The "leon3_cache_control_int" (op_helper.c) function is called within
leon3.c
which leads to segfault error with the global "env".
Now cache control
The "leon3_cache_control_int" (op_helper.c) function is called within leon3.c
which leads to segfault error with the global "env".
Now cache control is a CPU feature and everything is handled in op_helper.c.
Signed-off-by: Fabien Chouteau
---
hw/leon3.c |5 ++---
target-sparc/
On 30/01/11 22:14, Blue Swirl wrote:
Well, mine doesn't. The change was introduced in mingw-runtime 3.15,
which was released in September 2008, but Debian still hasn't updated
from 3.13. Maybe other distros are not so lagging and someone who
wishes to build QEMU on Windows is not pampered with d
The Ubuntu 10.10 gcc for ARM complains that we might be overrunning
the cpu_irqs[][] array: silence this by correcting the bounds on the
loop. (In fact we would not have overrun the array because bit
MAX_PILS in pil_pending and irl_out will always be 0.)
Also add a comment about why the loop's low
Let the callers build the optstr. Only one wants to. All the others
become simpler, because they don't have to worry about escaping '%'.
Signed-off-by: Markus Armbruster
---
v2: Clean up shadowing of local variable buf[] in main(). Pointed out
by Kevin.
blockdev.c |8 +---
blockdev.h
Am 28.01.2011 11:21, schrieb Markus Armbruster:
> Kevin found a bug in my recent "[PATCH 3+5/5] -drive/drive_add fixes".
> This is a rework of those two patches, plus a fix for the -drive
> if=scsi,index=N regression, plus the odd bonus fix found on the way.
>
> v2: fix for the -drive if=scsi,inde
On 2011-01-31 10:44, Avi Kivity wrote:
> On 01/27/2011 03:09 PM, Jan Kiszka wrote:
>> If we call qemu_cpu_kick more than once before the target was able to
>> process the signal, pthread_kill will fail, and qemu will abort. Prevent
>> this by avoiding the redundant signal.
>>
>
> Doesn't fit with
On 2011-01-31 10:52, Avi Kivity wrote:
> On 01/27/2011 03:09 PM, Jan Kiszka wrote:
>> If there is any pending request that requires us to leave the inner loop
>> if main_loop, makes sure we do this as soon as possible by enforcing
>> non-blocking IO processing.
>>
>> At this change, move variable d
On 2011-01-31 11:03, Avi Kivity wrote:
> On 01/27/2011 04:33 PM, Jan Kiszka wrote:
>> Found by Stefan Hajnoczi: There is a race in kvm_cpu_exec between
>> checking for exit_request on vcpu entry and timer signals arriving
>> before KVM starts to catch them. Plug it by blocking both timer related
>>
On 2011-01-31 11:08, Avi Kivity wrote:
> On 01/27/2011 03:10 PM, Jan Kiszka wrote:
>> Align with qemu-kvm and prepare for IO exit fix: There is no need to run
>> kvm_arch_process_irqchip_events in the inner VCPU loop. Any state change
>> this service processes will first cause an exit from kvm_cpu_
On Sun, 30 Jan 2011 16:06:20 +0100
Alexander Graf wrote:
>
> On 28.01.2011, at 21:10, Luiz Capitulino wrote:
>
> > Hi there,
> >
> > GSoC 2011 has been announced[1]. As we were pretty successful last year,
> > I think we should participate again. I've already created a wiki page:
> >
> > http
On 31.01.2011, at 10:02, Gleb Natapov wrote:
> Currently linuxboot.bin and multiboot.bin option roms override int19
> vector to intercept boot process. No sane option rom should do that.
> Provide bev entry instead that will be called by BIOS if option rom
> is selected for booting.
>
> Signed-o
On Mon, Jan 31, 2011 at 12:41:46PM +0100, Alexander Graf wrote:
> > Signed-off-by: Gleb Natapov
> The idea behind the OPTION_ROM and BOOT_ROM split was to have a generic
> header that can be used as template for random option roms or boot roms
> alike. Your patch munges those two use-cases toget
On 31.01.2011, at 12:50, Gleb Natapov wrote:
> On Mon, Jan 31, 2011 at 12:41:46PM +0100, Alexander Graf wrote:
>>> Signed-off-by: Gleb Natapov
>> The idea behind the OPTION_ROM and BOOT_ROM split was to have a generic
>> header that can be used as template for random option roms or boot roms
>
On 2011-01-31 11:12, Avi Kivity wrote:
> On 01/27/2011 03:09 PM, Jan Kiszka wrote:
>> This second round of patches focus on issues in cpus.c, primarily signal
>> related. The highlights are
>>
>> - Add missing KVM_RUN continuation after I/O exits
>> - Fix for timer signal race in KVM entry code
On Mon, Jan 31, 2011 at 11:27 AM, Jan Kiszka wrote:
> On 2011-01-31 11:03, Avi Kivity wrote:
>> On 01/27/2011 04:33 PM, Jan Kiszka wrote:
>>> Found by Stefan Hajnoczi: There is a race in kvm_cpu_exec between
>>> checking for exit_request on vcpu entry and timer signals arriving
>>> before KVM star
On 2011-01-31 13:13, Stefan Hajnoczi wrote:
> On Mon, Jan 31, 2011 at 11:27 AM, Jan Kiszka wrote:
>> On 2011-01-31 11:03, Avi Kivity wrote:
>>> On 01/27/2011 04:33 PM, Jan Kiszka wrote:
Found by Stefan Hajnoczi: There is a race in kvm_cpu_exec between
checking for exit_request on vcpu en
On 2011-01-31 12:36, Jan Kiszka wrote:
> On 2011-01-31 11:08, Avi Kivity wrote:
>> On 01/27/2011 03:10 PM, Jan Kiszka wrote:
>>> Align with qemu-kvm and prepare for IO exit fix: There is no need to run
>>> kvm_arch_process_irqchip_events in the inner VCPU loop. Any state change
>>> this service pro
Currently linuxboot.bin and multiboot.bin option roms override int19
vector to intercept boot process. No sane option rom should do that.
Provide bev entry instead that will be called by BIOS if option rom
is selected for booting.
Signed-off-by: Gleb Natapov
---
Note that this patch should be ap
The following changes since commit 45d1aa828f8c94b082a0aa2dbf76535594ee45df:
Update OpenBIOS images to r1018 (2011-01-30 13:10:10 +)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git for_anthony
Isaku Yamahata (2):
pci: memory leak o
On 01/31/2011 01:19 PM, Jan Kiszka wrote:
On 2011-01-31 10:44, Avi Kivity wrote:
> On 01/27/2011 03:09 PM, Jan Kiszka wrote:
>> If we call qemu_cpu_kick more than once before the target was able to
>> process the signal, pthread_kill will fail, and qemu will abort. Prevent
>> this by avoiding
On 01/31/2011 01:22 PM, Jan Kiszka wrote:
On 2011-01-31 10:52, Avi Kivity wrote:
> On 01/27/2011 03:09 PM, Jan Kiszka wrote:
>> If there is any pending request that requires us to leave the inner loop
>> if main_loop, makes sure we do this as soon as possible by enforcing
>> non-blocking IO p
On 01/31/2011 01:27 PM, Jan Kiszka wrote:
On 2011-01-31 11:03, Avi Kivity wrote:
> On 01/27/2011 04:33 PM, Jan Kiszka wrote:
>> Found by Stefan Hajnoczi: There is a race in kvm_cpu_exec between
>> checking for exit_request on vcpu entry and timer signals arriving
>> before KVM starts to catch
On Mon, Jan 31, 2011 at 12:18 PM, Jan Kiszka wrote:
> On 2011-01-31 13:13, Stefan Hajnoczi wrote:
>> On Mon, Jan 31, 2011 at 11:27 AM, Jan Kiszka wrote:
>>> On 2011-01-31 11:03, Avi Kivity wrote:
On 01/27/2011 04:33 PM, Jan Kiszka wrote:
> Found by Stefan Hajnoczi: There is a race in kvm
On Mon, Jan 24, 2011 at 05:23:01AM -0500, Mike Frysinger wrote:
> I finally got around to getting this port past the "only crashes" phase.
> Using the GNU sim Blackfin port as a nice working standard, it was just
> a matter of replacing the sim bits with TCG ops. Now we have a linux-user
> port fo
On 31.01.2011 10:44, Aurelien Jarno wrote:
> On Mon, Jan 31, 2011 at 10:35:30AM +0100, Christophe Lyon wrote:
>> On 31.01.2011 09:20, Aurelien Jarno wrote:
>>> On Fri, Jan 28, 2011 at 04:50:59PM +0100, christophe.l...@st.com wrote:
From: Christophe Lyon
Handle corner cases where the
On Thu, Jan 27, 2011 at 8:04 PM, Stefan Hajnoczi wrote:
> Let's plan testing for the upcoming 0.14 release here:
>
> http://wiki.qemu.org/Planning/0.14/Testing
>
> It's easy. Add yourself for the testing you are willing to do on the
> release candidates.
Folks have started to add the QEMU 0.14 r
On 2011-01-31 14:22, Avi Kivity wrote:
> On 01/31/2011 01:27 PM, Jan Kiszka wrote:
>> On 2011-01-31 11:03, Avi Kivity wrote:
>>> On 01/27/2011 04:33 PM, Jan Kiszka wrote:
Found by Stefan Hajnoczi: There is a race in kvm_cpu_exec between
checking for exit_request on vcpu entry and timer
On 2011-01-31 14:17, Avi Kivity wrote:
> On 01/31/2011 01:22 PM, Jan Kiszka wrote:
>> On 2011-01-31 10:52, Avi Kivity wrote:
>>> On 01/27/2011 03:09 PM, Jan Kiszka wrote:
If there is any pending request that requires us to leave the inner loop
if main_loop, makes sure we do this as soo
On 01/18/2011 08:13 AM, Anthony Liguori wrote:
On 01/18/2011 08:02 AM, Gerd Hoffmann wrote:
On 01/17/11 15:53, Michael Roth wrote:
On 01/17/2011 07:53 AM, Gerd Hoffmann wrote:
What is your plan to handle system-level queries+actions (such as
reboot) vs. per-user stuff (such as cut+paste)?
Th
> After thinking about it more, qemu-img update does also serve a
> purpose. Sometimes it is necessary to set options on many images in
> bulk or from provisioning scripts instead of at runtime.
>
> I guess my main fear of qemu-img update is that it adds a new
> interface that only FVD exploits s
On 18/01/11 21:10, Igor V. Kovalenko wrote:
From: Igor V. Kovalenko
- fix snprintf off by one
pci domain and slot number formatting snprintf calls
require extra space for trailing null character
without this change devices are assigned the same path name
which triggers assertion in
Signed-off-by: Dmitry Eremin-Solenikov
---
.gitignore |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/.gitignore b/.gitignore
index 3efb4ec..26703e1 100644
--- a/.gitignore
+++ b/.gitignore
@@ -51,6 +51,8 @@ QMP/qmp-commands.txt
*.vr
*.d
*.o
+*.swp
+*.orig
.pc
patc
Signed-off-by: Dmitry Eremin-Solenikov
---
hw/sysbus.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/sysbus.c b/hw/sysbus.c
index 1583bd8..1928b51 100644
--- a/hw/sysbus.c
+++ b/hw/sysbus.c
@@ -178,6 +178,7 @@ static void sysbus_dev_print(Monitor *mon, DeviceState
*
These two fields were added as a part of ARMv7 support patch (back in
2007), were never used by any code, so can be dropped.
Signed-off-by: Dmitry Eremin-Solenikov
---
target-arm/cpu.h |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/target-arm/cpu.h b/target-arm/cpu.h
Some ARM processors (consider PXA2xx, Omap1, etc.) want to be able to send
CPU_INTERRUPT_EXITTB to the cpu. Support doing that through common arm_pic.
Signed-off-by: Dmitry Eremin-Solenikov
---
hw/arm-misc.h |1 +
hw/arm_pic.c |6 +-
2 files changed, 6 insertions(+), 1 deletions(-)
Seceral files contained onnecessary dependencies on hw/pxa.h header.
Drop unused references.
Signed-off-by: Dmitry Eremin-Solenikov
---
hw/mainstone.c |2 +-
hw/mainstone.h |2 +-
hw/mst_fpga.c |9 -
hw/tc6393xb.c |1 -
hw/zaurus.c|1 -
5 files changed, 6 insert
pxa2xx_pic duplicated some code from arm-pic. Drop it, replacing with
references to arm-pic. Also use qdev/sysbus framework to handle
pxa2xx-pic.
Signed-off-by: Dmitry Eremin-Solenikov
---
hw/pxa2xx_pic.c | 125 +--
1 files changed, 66 inserti
Now the only user of mainstone.h is mainstone.c file. Merge header
into board file.
Signed-off-by: Dmitry Eremin-Solenikov
---
hw/mainstone.c | 23 ++-
hw/mainstone.h | 35 ---
2 files changed, 22 insertions(+), 36 deletions(-)
delete mode
Currently pxa2xx_pic exposes it's internal gpio_in array. Replace all
references to the array with calls to qdev_get_gpio_in().
Signed-off-by: Dmitry Eremin-Solenikov
---
hw/mst_fpga.c |7 ---
hw/pxa.h | 10 +-
hw/pxa2xx.c | 53 ++---
Signed-off-by: Dmitry Eremin-Solenikov
---
hw/zaurus.c | 19 ++-
1 files changed, 18 insertions(+), 1 deletions(-)
diff --git a/hw/zaurus.c b/hw/zaurus.c
index fca11a5..90fedc9 100644
--- a/hw/zaurus.c
+++ b/hw/zaurus.c
@@ -181,17 +181,34 @@ static int scoop_init(SysBusDevice *
From: Jes Sorensen
isspace() behavior is undefined for signed char.
Bug pointed out by Eric Blake, thanks!
Signed-off-by: Jes Sorensen
Signed-off-by: Kevin Wolf
---
cutils.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/cutils.c b/cutils.c
index 4d2e27c..a067
Signed-off-by: Dmitry Eremin-Solenikov
---
hw/tc6393xb.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/tc6393xb.c b/hw/tc6393xb.c
index c3fbe4e..0cadcde 100644
--- a/hw/tc6393xb.c
+++ b/hw/tc6393xb.c
@@ -381,7 +381,7 @@ static void tc6393xb_nand_writeb(TC6393xbState
The following changes since commit 45d1aa828f8c94b082a0aa2dbf76535594ee45df:
Update OpenBIOS images to r1018 (2011-01-30 13:10:10 +)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git block
Blue Swirl (1):
qcow2-refcount: remove write-only variables
Christoph
From: Stefan Hajnoczi
It is not possible to use virtio-ioeventfd when building without an I/O
thread. We rely on a signal to kick us out of vcpu execution. Timers
and AIO use SIGALRM and SIGUSR2 respectively. Unfortunately eventfd
does not support O_ASYNC (SIGIO) so eventfd cannot be used in a
From: Jes Sorensen
Signed-off-by: Jes Sorensen
Signed-off-by: Kevin Wolf
---
cutils.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/cutils.c b/cutils.c
index 369a016..8d562b2 100644
--- a/cutils.c
+++ b/cutils.c
@@ -324,26 +324,26 @@ int64_t strtosz_suffix(c
From: Christoph Hellwig
Raise a config change interrupt when the size changed. This allows
virtio-blk guest drivers to read-read the information from the
config space once it got the config chaged interrupt.
Signed-off-by: Christoph Hellwig
Signed-off-by: Kevin Wolf
---
hw/virtio-blk.c | 1
Signed-off-by: Dmitry Eremin-Solenikov
---
hw/mainstone.c | 10 +++--
hw/mainstone.h |3 --
hw/mst_fpga.c | 103 +--
3 files changed, 53 insertions(+), 63 deletions(-)
diff --git a/hw/mainstone.c b/hw/mainstone.c
index 61cac8a..7d13972
From: Blue Swirl
Variables l2_modified and l2_size are not really used, remove them.
Spotted by GCC 4.6.0:
CCblock/qcow2-refcount.o
/src/qemu/block/qcow2-refcount.c: In function 'qcow2_update_snapshot_refcount':
/src/qemu/block/qcow2-refcount.c:708:37: error: variable 'l2_modified' set but
From: Jes Sorensen
Signed-off-by: Jes Sorensen
Signed-off-by: Kevin Wolf
---
cutils.c |7 +--
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/cutils.c b/cutils.c
index a067cf4..78d35e2 100644
--- a/cutils.c
+++ b/cutils.c
@@ -323,16 +323,14 @@ int64_t strtosz_suffix(cons
This adds a bdrv_discard function to qcow2 that frees the discarded clusters.
It does not yet pass the discard on to the underlying file system driver, but
the space can be reused by future writes to the image.
Signed-off-by: Kevin Wolf
Reviewed-by: Stefan Hajnoczi
---
block/qcow2-cluster.c |
From: Stefan Hajnoczi
The consistency check on open is necessary in order to fix inconsistent
table offsets left as a result of a crash mid-operation. Images with a
backing file actually flush before updating table offsets and are
therefore guaranteed to be consistent. Do not mark these images
From: MORITA Kazutaka
This patch parses the input filename in sd_create(), and enables us
specifying a target server to create sheepdog images.
Signed-off-by: MORITA Kazutaka
Signed-off-by: Kevin Wolf
---
block/sheepdog.c | 17 ++---
1 files changed, 14 insertions(+), 3 deletion
From: Christoph Hellwig
Add a monitor command that allows resizing of block devices while
qemu is running. It uses the existing bdrv_truncate method already
used by qemu-img to do it's work. Compared to qemu-img the size
parsing is very simplicistic, but I think having a properly numering
objec
From: Markus Armbruster
Let the callers build the optstr. Only one wants to. All the others
become simpler, because they don't have to worry about escaping '%'.
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
blockdev.c |8 +---
blockdev.h |5 +
vl.c |
From: Stefan Hajnoczi
The len and is_write arguments to cpu_physical_memory_unmap() were
swapped. This patch changes calls to use the correct argument ordering.
Signed-off-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
hw/ide/ahci.c | 10 +-
1 files changed, 5 insertions(+), 5 d
From: Markus Armbruster
drive_init() picks the first free bus and unit number, unless the user
specifies them.
This isn't a good fit for the drive_add monitor command, because there
we specify the controller by PCI address instead of using bus number
set by drive_init().
scsi_hot_add() takes ca
From: Christoph Hellwig
Extend the change_cb callback with a reason argument, and use it
to tell drivers about size changes.
Signed-off-by: Christoph Hellwig
Signed-off-by: Kevin Wolf
---
block.c | 12
block.h |3 ++-
block_int.h |5 -
hw/ide/core.c |
Signed-off-by: Kevin Wolf
---
block/raw-win32.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/raw-win32.c b/block/raw-win32.c
index 06c9710..c204a80 100644
--- a/block/raw-win32.c
+++ b/block/raw-win32.c
@@ -153,7 +153,7 @@ static int raw_flush(BlockDriverState *
From: Jes Sorensen
Move size after the two pointers in struct Qcow2Cache to get better
packing of struct elements on 64 bit architectures.
Signed-off-by: Jes Sorensen
Signed-off-by: Kevin Wolf
---
block/qcow2-cache.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/bl
On 25.01.2011 18:18, Christophe Lyon wrote:
> This patch fixes the errors reported by my tests in VSRA.
>
ping?
From: Markus Armbruster
Turns drive_init()'s lengthy conditional into a concise loop, and
makes the data available elsewhere.
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
blockdev.c | 51 +--
1 files changed, 21 insertions(+)
From: Markus Armbruster
Watch this:
(qemu) drive_add 0 if=none
(qemu) info block
none0: type=hd removable=0 [not inserted]
(qemu) drive_del none0
Segmentation fault (core dumped)
add_init_drive() is confused about drive_init()'s failure modes, and
cleans up when it shouldn't
From: Markus Armbruster
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
blockdev.c | 22 ++
1 files changed, 14 insertions(+), 8 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 6d828f2..a42c5e4 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -75,6 +75,
From: Markus Armbruster
Before, type & index were hidden in printf-like fmt, ... parameters,
which get expanded into an option string. Rather inconvenient for
uses later in this series.
New IF_DEFAULT to ask for the machine's default interface. Before,
that was done by having no option "if" in
From: Jes Sorensen
Signed-off-by: Jes Sorensen
Acked-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
qemu-common.h |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/qemu-common.h b/qemu-common.h
index c351131..79e1149 100644
--- a/qemu-common.h
+++ b/qemu-comm
From: Markus Armbruster
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
blockdev.c |7 +++
blockdev.h |1 +
2 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index a42c5e4..01228f6 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -136,
From: Markus Armbruster
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
blockdev.h|6 ++
qemu-common.h |6 --
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/blockdev.h b/blockdev.h
index 3ed6634..2cbbb87 100644
--- a/blockdev.h
+++ b/blockdev.
From: Markus Armbruster
qdev_init_bdrv() doesn't belong into qdev.c; it's about drives, not
qdevs. Rename to drive_get_next, move to blockdev.c, drop the bogus
DeviceState argument, and return DriveInfo instead of
BlockDriverState.
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
--
From: Markus Armbruster
We silently ignore multiple definitions for the same drive:
$ qemu-system-x86_64 -nodefaults -vnc :1 -S -monitor stdio -drive
if=ide,index=1,file=tmp.qcow2 -drive if=ide,index=1,file=nonexistant
QEMU 0.13.50 monitor - type 'help' for more information
(qemu) i
qemu-io passed bytes where it's supposed to pass sectors, so discard requests
were off.
Signed-off-by: Kevin Wolf
Reviewed-by: Stefan Hajnoczi
---
qemu-io.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qemu-io.c b/qemu-io.c
index 5b24c5e..4470e49 100644
--- a/qemu-i
On 31 January 2011 15:20, Dmitry Eremin-Solenikov wrote:
> These two fields were added as a part of ARMv7 support patch (back in
> 2007), were never used by any code, so can be dropped.
>
> Signed-off-by: Dmitry Eremin-Solenikov
Reviewed-by: Peter Maydell
-- PMM
On 24.01.2011 13:41, Christophe Lyon wrote:
> Here is an updated patch with these minor fixes.
>
ping?
From: Markus Armbruster
Before commit 622b520f, index=12 meant bus=1,unit=5.
Since the commit, it means bus=0,unit=12. The drive is created, but
not the guest device. That's because the controllers we use with
if=scsi drives (lsi53c895a and esp) support only 7 units, and
scsi_bus_legacy_handle
On 2011-01-31 14:04, Jan Kiszka wrote:
> On 2011-01-31 12:36, Jan Kiszka wrote:
>> On 2011-01-31 11:08, Avi Kivity wrote:
>>> On 01/27/2011 03:10 PM, Jan Kiszka wrote:
Align with qemu-kvm and prepare for IO exit fix: There is no need to run
kvm_arch_process_irqchip_events in the inner VCP
From: Jes Sorensen
Signed-off-by: Jes Sorensen
Signed-off-by: Kevin Wolf
---
cutils.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/cutils.c b/cutils.c
index 78d35e2..369a016 100644
--- a/cutils.c
+++ b/cutils.c
@@ -304,8 +304,8 @@ int64_t strtosz_suffix(const cha
On Wed, 26 Jan 2011, Anthony Liguori wrote:
> > +void qemu_invalidate_map_cache(void)
> > +{
> > +unsigned long i;
> > +MapCacheRev *reventry;
> > +
> > +qemu_aio_flush();
> >
>
> This is bizarre? Why is this needed?
>
Sorry, I forgot to reply to this question.
Xen might send an IO
On 01/31/2011 04:31 PM, Jan Kiszka wrote:
>>
>> And how would you be kicked out of the select() call if it is waiting
>> with a timeout? We only have a single thread here.
>
> If we use signalfd() (either kernel provided or thread+pipe), we kick
> out of select by select()ing it (though I don
On Mon, Jan 31, 2011 at 04:40:34PM +0100, Jan Kiszka wrote:
> On 2011-01-31 14:04, Jan Kiszka wrote:
> > On 2011-01-31 12:36, Jan Kiszka wrote:
> >> On 2011-01-31 11:08, Avi Kivity wrote:
> >>> On 01/27/2011 03:10 PM, Jan Kiszka wrote:
> Align with qemu-kvm and prepare for IO exit fix: There i
Christophe Lyon a écrit :
> On 31.01.2011 10:44, Aurelien Jarno wrote:
>> On Mon, Jan 31, 2011 at 10:35:30AM +0100, Christophe Lyon wrote:
>>> On 31.01.2011 09:20, Aurelien Jarno wrote:
On Fri, Jan 28, 2011 at 04:50:59PM +0100, christophe.l...@st.com wrote:
> From: Christophe Lyon
>
>
On 31.01.2011, at 14:11, Gleb Natapov wrote:
> Currently linuxboot.bin and multiboot.bin option roms override int19
> vector to intercept boot process. No sane option rom should do that.
> Provide bev entry instead that will be called by BIOS if option rom
> is selected for booting.
No idea abou
On 2011-01-31 17:38, Gleb Natapov wrote:
> On Mon, Jan 31, 2011 at 04:40:34PM +0100, Jan Kiszka wrote:
>> On 2011-01-31 14:04, Jan Kiszka wrote:
>>> On 2011-01-31 12:36, Jan Kiszka wrote:
On 2011-01-31 11:08, Avi Kivity wrote:
> On 01/27/2011 03:10 PM, Jan Kiszka wrote:
>> Align with q
On 31 January 2011 15:59, Aurelien Jarno wrote:
> Christophe Lyon a écrit :
>> Well, I can't reproduce this error :-(
>> For the record, I configure with --target-list=arm-softmmu,arm-linux-user
>> --disable-bluez --enable-debug --disable-sdl and point --host-cc and --cc to
>> GCC-4.5.1.
>>
>
>
On 2011-01-31 17:41, Jan Kiszka wrote:
> On 2011-01-31 17:38, Gleb Natapov wrote:
>> On Mon, Jan 31, 2011 at 04:40:34PM +0100, Jan Kiszka wrote:
>>> On 2011-01-31 14:04, Jan Kiszka wrote:
On 2011-01-31 12:36, Jan Kiszka wrote:
> On 2011-01-31 11:08, Avi Kivity wrote:
>> On 01/27/2011 0
On Mon, Jan 31, 2011 at 05:52:13PM +0100, Jan Kiszka wrote:
> On 2011-01-31 17:50, Gleb Natapov wrote:
> > On Mon, Jan 31, 2011 at 05:41:24PM +0100, Jan Kiszka wrote:
> >> On 2011-01-31 17:38, Gleb Natapov wrote:
> >>> On Mon, Jan 31, 2011 at 04:40:34PM +0100, Jan Kiszka wrote:
> On 2011-01-31
1 - 100 of 147 matches
Mail list logo
