On 31.01.2011, at 12:50, Gleb Natapov wrote: > On Mon, Jan 31, 2011 at 12:41:46PM +0100, Alexander Graf wrote: >>> Signed-off-by: Gleb Natapov <g...@redhat.com> >> The idea behind the OPTION_ROM and BOOT_ROM split was to have a generic >> header that can be used as template for random option roms or boot roms >> alike. Your patch munges those two use-cases together by providing bev logic >> in the generic option rom part. >> >> Please split it out into the BOOT_ROM macro, or - if necessary - create a >> new macro. >> >> > Like this? > > diff --git a/pc-bios/optionrom/linuxboot.S b/pc-bios/optionrom/linuxboot.S > index c109363..79b3ae8 100644 > --- a/pc-bios/optionrom/linuxboot.S > +++ b/pc-bios/optionrom/linuxboot.S > @@ -22,6 +22,8 @@ > > #include "optionrom.h" > > +#define PRODUCT "Linux loader"
Please make this BOOT_ROM_PRODUCT Otherwise, yes, a lot better :) Alex
