[Qemu-devel] Welcome to Homerun!

2011-01-17 Thread HomeRun
Welcome to HomeRun! Thanks for joining the HomeRun community. Are you ready to have fun? Give us a few minutes and you'll see how we make buying more fun, social, and rewarding than anywhere else. And, oh yeah, we forgot to mention that the prices are pretty unbelievable too :) What should you

Re: [Qemu-devel] paravirtual mouse/tablet

2011-01-17 Thread Gerd Hoffmann
Hi, I was just talking to Chase Douglas here at the ubuntu sprint about this, and he pointed me at https://launchpad.net/rinput which is a program which can forward remote events including multitouch over the network (including forwarding from both Linux and MacOS X clients). Maybe that would

Re: [Qemu-devel] paravirtual tablet v3

2011-01-17 Thread Gerd Hoffmann
On 01/14/11 21:48, Anthony Liguori wrote: On 01/14/2011 10:35 AM, Gerd Hoffmann wrote: Hi, Now v3 featuring multitouch ;) cheers, Gerd I really think multitouch needs to be a feature such that the guest can nack it and the host can adjust accordingly. If it's there from day 1, that's fine, b

Re: [Qemu-devel] [PATCH 2/3] block: tell drivers about an image resize

2011-01-17 Thread Christoph Hellwig
> Do we want to check to ensure the size_changed flag isn't set before > doing a second resize event? I'm wondering if the truncate takes > $longtime and user gets impatient and issues a second resize command. > How should we respond? Ignore it? queue it up? The truncate is synchronous and the

[Qemu-devel] Re: [PATCH] usb-msd: Add usb-storage, removable=on|off property

2011-01-17 Thread Christoph Hellwig
The actual removable bit looks fine, but I don't think the connection of the change callback looks sane. What's the rationale for it?

Re: [Qemu-devel] [PATCH] pci: Remove unneeded null pointer check

2011-01-17 Thread Kevin Wolf
Am 15.01.2011 19:01, schrieb Stefan Weil: > With bm == NULL, other code in the same function would crash. > > This bug was reported by cppcheck: > hw/ide/pci.c:280: error: Possible null pointer dereference: bm > > Cc: Michael S. Tsirkin > Signed-off-by: Stefan Weil Thanks, applied to the block

[Qemu-devel] Re: [PATCH uq/master 2/2] MCE, unpoison memory address across reboot

2011-01-17 Thread Jan Kiszka
On 2011-01-17 03:08, Huang Ying wrote: As indicated, I'm sitting on lots of fixes and refactorings of the MCE user space code. How do you test your patches? Any suggestions how to do this efficiently would be warmly welcome. >>> >>> We use a self-made test script to test. Repository

Re: [Qemu-devel] [PATCH 08/12] Threadlet: Add aio_signal_handler threadlet API

2011-01-17 Thread Stefan Hajnoczi
On Thu, Jan 13, 2011 at 12:14 PM, Arun R Bharadwaj wrote: > +static void threadlet_io_completion_signal_handler(int signum) > +{ > +    qemu_service_io(); > +} > + > +static void threadlet_register_signal_handler(void) > +{ > +    struct sigaction act; > +    sigfillset(&act.sa_mask); > +    act.s

Re: [Qemu-devel] [PATCH 10/12] Move threadlet code to qemu-threadlets.c

2011-01-17 Thread Stefan Hajnoczi
On Thu, Jan 13, 2011 at 12:15 PM, Arun R Bharadwaj wrote: > This patch moves the threadlet queue API code to > qemu-threadlets.c where these APIs can be used by > other subsystems. qemu-threadlet.c would be consistent with qemu-thread.c (not qemu-threads.c). Stefan

[Qemu-devel] MIPS, io-thread, icount and wfi

2011-01-17 Thread Edgar E. Iglesias
Hi, I'm running an io-thread enabled qemu-system-mipsel with icount. When the guest (linux) goes to sleep through the wait insn (waiting to be woken up by future timer interrupts), the thing deadlocks. IIUC, this is because vm timers are driven by icount, but the CPU is halted so icount makes no

Re: [Qemu-devel] Re: [PATCH] usb-msd: Add usb-storage, removable=on|off property

2011-01-17 Thread Stefan Hajnoczi
On Mon, Jan 17, 2011 at 10:21:26AM +0100, Christoph Hellwig wrote: > The actual removable bit looks fine, but I don't think the connection of > the change callback looks sane. What's the rationale for it? Since we're using bdrv_set_removable(), the user may try to eject the block device from the

[Qemu-devel] Re: [PATCH v2 0/5] iohandlers: Add support for enabling/disabling individual handlers

2011-01-17 Thread Amit Shah
On (Thu) Jan 13 2011 [13:17:22], Anthony Liguori wrote: > On 01/13/2011 09:00 AM, Amit Shah wrote: > >Hi, > > > >This patchset adds new interfaces to work with iohandlers. It adds: > > > >int assign_fd_handlers(int fd, IOHandlerOps *ops, void *opaque) > >-- Specify io handlers for an fd > >int

Re: [Qemu-devel] [PATCH 00/12] Threadlets Infrastructure.

2011-01-17 Thread Stefan Hajnoczi
This series needs a new pair of eyes for review. I'm probably missing things here after seeing it many times. posix-aio-compat.c:handle_work() doesn't need to take aiocb_mutex for container_of(), which just calculates an address but doesn't actually access the aiocb. dequeue_work_on_queue() is i

Re: [Qemu-devel] [RFC] Propose the Fast Virtual Disk (FVD) image format that outperforms QCOW2 by 249%

2011-01-17 Thread Stefan Hajnoczi
Resend because qemu-devel was dropped from CC. Thanks for pointing it out Kevin. On Sat, Jan 15, 2011 at 12:25 PM, Stefan Hajnoczi wrote: > On Sat, Jan 15, 2011 at 3:28 AM, Chunqiang Tang wrote: >> T1) To address the problems of B1- B3, I implemented an emulated disk in >> block/sim.c, which al

[Qemu-devel] [PATCH v2 1/3] qcow2: Add QcowCache

2011-01-17 Thread Kevin Wolf
This adds some new cache functions to qcow2 which can be used for caching refcount blocks and L2 tables. When used with cache=writethrough they work like the old caching code which is spread all over qcow2, so for this case we have merely a cleanup. The interesting case is with writeback caching (

[Qemu-devel] [PATCH v2 3/3] qcow2: Batch flushes for COW

2011-01-17 Thread Kevin Wolf
qcow2 calls bdrv_flush() after performing COW in order to ensure that the L2 table change is never written before the copy is safe on disk. Now that the L2 table is cached, we can wait with flushing until we write out the next L2 table. Signed-off-by: Kevin Wolf --- block/qcow2-cache.c | 20

[Qemu-devel] [PATCH v2 2/3] qcow2: Use QcowCache

2011-01-17 Thread Kevin Wolf
Use the new functions of qcow2-cache.c for everything that works on refcount block and L2 tables. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 206 ++-- block/qcow2-refcount.c | 249 +++- block/qcow2.c

[Qemu-devel] [PATCH v2 0/3] qcow2 metadata cache

2011-01-17 Thread Kevin Wolf
block-queue turned out to be too big effort to be useful for quickly fixing the performance problems that qcow2 got since we introduced the metadata flushes. While I still think the idea is right, it needs more time and qcow2 doesn't have more time. Let's come back to block-queue later when the mos

Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command

2011-01-17 Thread Stefan Hajnoczi
On Fri, Jan 14, 2011 at 4:20 PM, Christoph Hellwig wrote: > +STEXI > +@item resize > +@findex resize > +Resize a block image while a guest is running.  Usuaully requires guest s/Usuaully/Usually/ > +action to see the updated size.  Resize to a lower size is supported, > +but should be used with

Re: [Qemu-devel] [PATCH v2 1/6] Emulation of GRLIB GPTimer as defined in GRLIB IP Core User's Manual.

2011-01-17 Thread Fabien Chouteau
On 01/04/2011 07:46 PM, Blue Swirl wrote: On Mon, Jan 3, 2011 at 2:07 PM, Fabien Chouteau wrote:+} +static uint32_t grlib_gptimer_readl(void *opaque, target_phys_addr_t addr) +{ +GPTimerUnit *unit = opaque; +uint32_t value = 0; + +addr&= 0xff; Not needed. When io-memory st

Re: [Qemu-devel] TCG flow vs dyngen

2011-01-17 Thread Lluís
Stefano Bonifazi writes: > Hi! > In case you are interested in helping me, I'll give you a big piece of news > I've just got (even my teacher is not informed yet! :) ) I still don't understand what is your high-level objective... Lluis -- "And it's much the same thing with knowledge, for wh

[Qemu-devel] [RFC][PATCH v6 00/23] virtagent: host/guest RPC communication agent

2011-01-17 Thread Michael Roth
These patches apply to master (1-14-2011), and can also be obtained from: git://repo.or.cz/qemu/mdroth.git virtagent_v6 CHANGES IN V6: - Added a sentinel value to reliably detect the start of an "http" hdr. Used to skip past partially sent http content from previous "sessions" - Added http hdr

[Qemu-devel] [RFC][PATCH v6 02/23] Add qemu_set_fd_handler() wrappers to qemu-tools.c

2011-01-17 Thread Michael Roth
This adds state information for managing fd handlers to qemu-tools.c so that tools that build against it can implement an I/O loop for interacting with objects that use qemu_set_fd_handler() Signed-off-by: Michael Roth --- qemu-tool.c | 25 - 1 files changed, 24 inserti

[Qemu-devel] [RFC][PATCH v6 01/23] Move code related to fd handlers into utility functions

2011-01-17 Thread Michael Roth
This allows us to implement an i/o loop outside of vl.c that can interact with objects that use qemu_set_fd_handler() Signed-off-by: Michael Roth --- Makefile.objs |2 +- qemu-char.h |4 ++ qemu-ioh.c| 115 + qemu-ioh.h|

[Qemu-devel] [RFC][PATCH v6 11/23] virtagent: add agent_viewdmesg qmp/hmp commands

2011-01-17 Thread Michael Roth
Add commands to view guest dmesg output. Currently it is a 16K buffer. Signed-off-by: Michael Roth --- hmp-commands.hx | 16 + qmp-commands.hx | 35 + virtagent.c | 92 +++ virtagent.h |3 ++ 4 file

[Qemu-devel] [RFC][PATCH v6 03/23] Make qemu timers available for tools

2011-01-17 Thread Michael Roth
To be able to use qemu_mod_timer() and friends to register timeout events for virtagent's qemu-va tool, we need to do the following: Move several blocks of code out of cpus.c that handle initialization of qemu's io_thread_fd and working with it via qemu_notify_event()/qemu_event_read()/etc, and ma

[Qemu-devel] [RFC][PATCH v6 06/23] virtagent: base client definitions

2011-01-17 Thread Michael Roth
Functions for managing client capabilities and creating client RPC jobs. Signed-off-by: Michael Roth --- qerror.c |8 +++ qerror.h |6 ++ roms/seabios |2 +- virtagent.c | 158 ++ virtagent.h | 34 5 fi

[Qemu-devel] [RFC][PATCH v6 05/23] virtagent: transport definitions read/send callback functions

2011-01-17 Thread Michael Roth
Signed-off-by: Michael Roth --- virtagent-common.c | 415 virtagent-common.h |1 + 2 files changed, 416 insertions(+), 0 deletions(-) diff --git a/virtagent-common.c b/virtagent-common.c index c487252..f8b7d74 100644 --- a/virtagent-comm

[Qemu-devel] [RFC][PATCH v6 08/23] virtagent: add va.getfile RPC

2011-01-17 Thread Michael Roth
Add RPC to retrieve a guest file. This interface is intended for smaller reads like peeking at logs and /proc and such. Signed-off-by: Michael Roth --- virtagent-server.c | 59 1 files changed, 59 insertions(+), 0 deletions(-) diff --git a/

[Qemu-devel] [RFC][PATCH v6 04/23] virtagent: common code for managing client/server rpc jobs

2011-01-17 Thread Michael Roth
This implements a simple state machine to manage client/server rpc jobs being multiplexed over a single channel. A client job consists of sending an rpc request, reading an rpc response, then making the appropriate callbacks. We allow one client job to be processed at a time, which will make the f

[Qemu-devel] [RFC][PATCH v6 14/23] virtagent: add va.ping RPC

2011-01-17 Thread Michael Roth
Do-nothing RPC that can be used to "ping" the RPC server Signed-off-by: Michael Roth --- virtagent-server.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/virtagent-server.c b/virtagent-server.c index d48c61e..ab8994b 100644 --- a/virtagent-server.c +++

[Qemu-devel] [RFC][PATCH v6 15/23] virtagent: add agent_ping qmp/hmp commands

2011-01-17 Thread Michael Roth
Monitor command to ping the RPC server. Signed-off-by: Michael Roth --- hmp-commands.hx | 16 qmp-commands.hx | 32 +++ virtagent.c | 74 +++ virtagent.h |3 ++ 4 files changed, 125 insertions(

[Qemu-devel] [RFC][PATCH v6 07/23] virtagent: base server definitions

2011-01-17 Thread Michael Roth
Signed-off-by: Michael Roth --- virtagent-server.c | 111 virtagent-server.h | 34 2 files changed, 145 insertions(+), 0 deletions(-) create mode 100644 virtagent-server.c create mode 100644 virtagent-server.h diff --git

[Qemu-devel] [RFC][PATCH v6 09/23] virtagent: add agent_viewfile qmp/hmp command

2011-01-17 Thread Michael Roth
Utilize the getfile RPC to provide a means to view text files in the guest. Getfile can handle binary files as well but we don't advertise that here due to the special handling requiring to store it and provide it back to the user (base64 encoding it for instance). Hence the otherwise confusing "vi

[Qemu-devel] [RFC][PATCH v6 18/23] virtagent: add va.hello RPC

2011-01-17 Thread Michael Roth
This RPC tells us the guest agent is up and ready, and invokes guest agent capability negotiation Signed-off-by: Michael Roth --- virtagent-server.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/virtagent-server.c b/virtagent-server.c index ab8994

[Qemu-devel] [RFC][PATCH v6 12/23] virtagent: add va.shutdown RPC

2011-01-17 Thread Michael Roth
RPC to initiate guest reboot/halt/powerdown Signed-off-by: Michael Roth --- virtagent-server.c | 58 1 files changed, 58 insertions(+), 0 deletions(-) diff --git a/virtagent-server.c b/virtagent-server.c index f97e4b1..d48c61e 100644 --- a/

[Qemu-devel] [RFC][PATCH v6 13/23] virtagent: add agent_shutdown qmp/hmp commands

2011-01-17 Thread Michael Roth
Provide monitor command to initiate guest reboot/halt/powerdown Signed-off-by: Michael Roth --- hmp-commands.hx | 16 ++ qmp-commands.hx | 32 + virtagent.c | 59 +++ virtagent.h |2 + 4

[Qemu-devel] [RFC][PATCH v6 10/23] virtagent: add va.getdmesg RPC

2011-01-17 Thread Michael Roth
Add RPC to view guest dmesg output. Signed-off-by: Michael Roth --- virtagent-server.c | 46 ++ 1 files changed, 46 insertions(+), 0 deletions(-) diff --git a/virtagent-server.c b/virtagent-server.c index af4b940..f97e4b1 100644 --- a/virtagent-serv

[Qemu-devel] [RFC][PATCH v6 16/23] virtagent: add agent_capabilities qmp/hmp commands

2011-01-17 Thread Michael Roth
Call guest agent's built-in introspection functions to get a list of supported RPCs, and re-negotiate guest agent capabilities to determine what agent_* commands are supported. Signed-off-by: Michael Roth --- hmp-commands.hx | 16 + qmp-commands.hx | 32 ++ virtagent.

Re: [Qemu-devel] [PATCH 0/8] Some more AHCI work

2011-01-17 Thread Gerd Hoffmann
On 12/20/10 22:13, Alexander Graf wrote: Clearly, AHCI as is is not perfect yet (intentionally, release early, release often, remember?). This patch set makes it work with SeaBIOS so booting Windows 7 works flawlessly for me. Confirmed. Had to reinstall my win7 test vm today, tried with this

[Qemu-devel] [RFC][PATCH v6 17/23] virtagent: add client capabilities init function

2011-01-17 Thread Michael Roth
Non-monitor version of agent_capabilities monitor function. This is called by the local RPC server when it gets a "hello" from the guest agent to re-negotiate guest agent capabilities. Signed-off-by: Michael Roth --- virtagent.c | 18 ++ virtagent.h |1 + 2 files changed, 1

[Qemu-devel] [RFC][PATCH v6 19/23] virtagent: add "hello" notification function for guest agent

2011-01-17 Thread Michael Roth
This tells the host RPC server (QEMU) that we're up and running Signed-off-by: Michael Roth --- virtagent.c | 47 +++ virtagent.h |1 + 2 files changed, 48 insertions(+), 0 deletions(-) diff --git a/virtagent.c b/virtagent.c index 3ea6b85..b5e79

[Qemu-devel] [RFC][PATCH v6 20/23] virtagent: add va.capabilities RPC

2011-01-17 Thread Michael Roth
Signed-off-by: Michael Roth --- virtagent-server.c | 37 + 1 files changed, 37 insertions(+), 0 deletions(-) diff --git a/virtagent-server.c b/virtagent-server.c index b7e51ed..5961905 100644 --- a/virtagent-server.c +++ b/virtagent-server.c @@ -252,6 +252,

[Qemu-devel] [RFC][PATCH v6 21/23] virtagent: add virtagent guest daemon

2011-01-17 Thread Michael Roth
Signed-off-by: Michael Roth --- Makefile |4 +- qemu-va.c | 238 virtagent-common.h |1 + 3 files changed, 242 insertions(+), 1 deletions(-) create mode 100644 qemu-va.c diff --git a/Makefile b/Makefile index 6d60

[Qemu-devel] [RFC][PATCH v6 22/23] virtagent: integrate virtagent server/client via chardev

2011-01-17 Thread Michael Roth
This adds a new chardev, virtagent, which actually just passes back a socket chardev after connecting to it and initializing the agent. Signed-off-by: Michael Roth --- qemu-char.c | 44 1 files changed, 44 insertions(+), 0 deletions(-) diff --git a

Re: [Qemu-devel] [RFC][PATCH v6 00/23] virtagent: host/guest RPC communication agent

2011-01-17 Thread Gerd Hoffmann
Hi, OVERVIEW: There are a wide range of use cases motivating the need for a guest agent of some sort to extend the functionality/usability/control offered by QEMU. Some examples include graceful guest shutdown/reboot and notifications thereof, copy/paste syncing between host/guest, guest stat

Re: [Qemu-devel] [RFC][PATCH v6 01/23] Move code related to fd handlers into utility functions

2011-01-17 Thread Gerd Hoffmann
Hi, +/* XXX: fd_read_poll should be suppressed, but an API change is + necessary in the character devices to suppress fd_can_read(). */ FYI: Amit (Cc'ed) looks at this api issue too for other reasons. cheers, Gerd

[Qemu-devel] [RFC][PATCH v6 23/23] virtagent: various bits to build QEMU with virtagent

2011-01-17 Thread Michael Roth
Signed-off-by: Michael Roth --- Makefile.target |2 +- configure | 32 2 files changed, 33 insertions(+), 1 deletions(-) diff --git a/Makefile.target b/Makefile.target index e15b1c4..8564a8f 100644 --- a/Makefile.target +++ b/Makefile.target @@ -186,

[Qemu-devel] Re: [patch 1/2] document QEMU<->ACPIBIOS PCI hotplug interface

2011-01-17 Thread Michael S. Tsirkin
On Tue, Jan 11, 2011 at 02:20:38PM -0200, Marcelo Tosatti wrote: > Document how QEMU communicates with ACPI BIOS for PCI hotplug. > > Signed-off-by: Marcelo Tosatti This one seems to add whitespae errors: /scm/qemu/.git/rebase-apply/patch:5: new blank line at EOF. + warning: 1 line adds whitespa

[Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-17 Thread Jan Kiszka
On 2010-12-20 22:13, Alexander Graf wrote: > When not using MSI, receiving an interrupt while the interrupt line is active > pulses the interrupt line. Without this, guests don't realize that a new > interrupt occured. This doesn't look OK. The device model should look at the currently used mode a

[Qemu-devel] [PATCH] Documentation: Add qemu-img check/rebase

2011-01-17 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- qemu-img.texi | 41 + 1 files changed, 41 insertions(+), 0 deletions(-) diff --git a/qemu-img.texi b/qemu-img.texi index 1b90ddb..ced64a4 100644 --- a/qemu-img.texi +++ b/qemu-img.texi @@ -59,6 +59,13 @@ lists all snapshots

Re: [Qemu-devel] [RFC][PATCH v6 00/23] virtagent: host/guest RPC communication agent

2011-01-17 Thread Michael Roth
On 01/17/2011 07:53 AM, Gerd Hoffmann wrote: Hi, OVERVIEW: There are a wide range of use cases motivating the need for a guest agent of some sort to extend the functionality/usability/control offered by QEMU. Some examples include graceful guest shutdown/reboot and notifications thereof, copy/

[Qemu-devel] [PATCH 1/2] strtosz() use unsigned char as isspace() is not defined for signed char

2011-01-17 Thread Jes . Sorensen
From: Jes Sorensen Bug pointed out by Erik Blake, thanks! Signed-off-by: Jes Sorensen --- cutils.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/cutils.c b/cutils.c index 7984bc1..f97ef39 100644 --- a/cutils.c +++ b/cutils.c @@ -294,7 +294,8 @@ int fcntl_setfl(int

[Qemu-devel] [PATCH 2/2] strtosz() use toupper() to simply switch statement

2011-01-17 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- cutils.c |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/cutils.c b/cutils.c index f97ef39..f7aa90c 100644 --- a/cutils.c +++ b/cutils.c @@ -323,16 +323,14 @@ ssize_t strtosz_suffix(const char *nptr, char **end,

[Qemu-devel] Re: [PATCH v2 0/5] iohandlers: Add support for enabling/disabling individual handlers

2011-01-17 Thread Anthony Liguori
On 01/17/2011 04:18 AM, Amit Shah wrote: On (Thu) Jan 13 2011 [13:17:22], Anthony Liguori wrote: On 01/13/2011 09:00 AM, Amit Shah wrote: Hi, This patchset adds new interfaces to work with iohandlers. It adds: int assign_fd_handlers(int fd, IOHandlerOps *ops, void *opaque) -- S

Re: [Qemu-devel] paravirtual tablet v3

2011-01-17 Thread Anthony Liguori
On 01/17/2011 02:19 AM, Gerd Hoffmann wrote: On 01/14/11 21:48, Anthony Liguori wrote: On 01/14/2011 10:35 AM, Gerd Hoffmann wrote: Hi, Now v3 featuring multitouch ;) cheers, Gerd I really think multitouch needs to be a feature such that the guest can nack it and the host can adjust accordi

Re: [Qemu-devel] RFC: mass comment conversion from C99 to C89

2011-01-17 Thread Anthony Liguori
On 01/16/2011 06:12 PM, Peter Maydell wrote: On 15 January 2011 16:02, Blue Swirl wrote: With the sed script below (my first I think), I'm able to convert most files in QEMU from C99 comment style to C89. When successive line with C99 comments are converted, the comments are merged. Two fil

[Qemu-devel] Re: [Xen-devel] [PATCH V2 3/3] xen: Introduce VGA sync dirty bitmap support

2011-01-17 Thread Stefano Stabellini
On Fri, 14 Jan 2011, anthony.per...@citrix.com wrote: > From: Anthony PERARD > > This patch introduces phys memory client for Xen. > > Only sync dirty_bitmap and set_memory are actually implemented. > migration_log will stay empty for the moment. > > Xen can only log one range for bit change, s

[Qemu-devel] [PATCH v2 0/2] strtosz() cleanup

2011-01-17 Thread Jes . Sorensen
From: Jes Sorensen Fix issue with signed char and isspace() as well as clean up switch statement using toupper(). V2 of the patch fixes some types in the commit messages and spells Eric correctly. My apologies for getting it wrong. Jes Sorensen (2): strtosz() use unsigned char as isspace() is

[Qemu-devel] [PATCH 2/2] strtosz() use toupper() to simplify switch statement

2011-01-17 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- cutils.c |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/cutils.c b/cutils.c index f97ef39..f7aa90c 100644 --- a/cutils.c +++ b/cutils.c @@ -323,16 +323,14 @@ ssize_t strtosz_suffix(const char *nptr, char **end,

[Qemu-devel] [PATCH 1/2] strtosz() use unsigned char as isspace() is not defined for signed char

2011-01-17 Thread Jes . Sorensen
From: Jes Sorensen Bug pointed out by Eric Blake, thanks! Signed-off-by: Jes Sorensen --- cutils.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/cutils.c b/cutils.c index 7984bc1..f97ef39 100644 --- a/cutils.c +++ b/cutils.c @@ -294,7 +294,8 @@ int fcntl_setfl(int

[Qemu-devel] Re: [PATCH v2 0/2] strtosz() cleanup

2011-01-17 Thread Alex Williamson
On Mon, 2011-01-17 at 16:14 +0100, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > Fix issue with signed char and isspace() as well as clean up switch > statement using toupper(). > > V2 of the patch fixes some types in the commit messages and spells > Eric correctly. My apologies for ge

Re: [Qemu-devel] [PATCH] Documentation: Add qemu-img check/rebase

2011-01-17 Thread Stefan Hajnoczi
On Mon, Jan 17, 2011 at 2:39 PM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- >  qemu-img.texi |   41 + >  1 files changed, 41 insertions(+), 0 deletions(-) Reviewed-by: Stefan Hajnoczi

[Qemu-devel] Re: [PATCH 08/12] Threadlet: Add aio_signal_handler threadlet API

2011-01-17 Thread Paolo Bonzini
On 01/17/2011 10:56 AM, Stefan Hajnoczi wrote: This would be the right place to create qemu-threadlet.c, You mean .h? Paolo

[Qemu-devel] Re: [PATCH V2 1/3] Introduce log_start/log_stop in CPUPhysMemoryClient

2011-01-17 Thread Jan Kiszka
On 2011-01-14 19:10, anthony.per...@citrix.com wrote: > From: Anthony PERARD > > In order to use log_start/log_stop with Xen as well in the vga code, > this two operations have been put in CPUPhysMemoryClient. > > The two new functions cpu_physical_log_start,cpu_physical_log_stop are > used in h

Re: [Qemu-devel] [PATCH 0/7] usb-ccid (v15)

2011-01-17 Thread Alon Levy
Ping On Tue, Jan 11, 2011 at 10:42:31AM +0200, Alon Levy wrote: > This patchset adds three new devices, usb-ccid, ccid-card-passthru and > ccid-card-emulated, providing a CCID bus, a simple passthru protocol > implementing card requiring a client, and a standalone emulated card. > > It also intro

Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command

2011-01-17 Thread Christoph Hellwig
On Mon, Jan 17, 2011 at 11:28:47AM +, Stefan Hajnoczi wrote: > > + ? ?if (bdrv_get_type_hint(bs) == BDRV_TYPE_CDROM) { > > + ? ? ? ?error_report("Can not resize CDROM devices\n"); > > + ? ? ? ?return -1; > > + ? ?} > > Hrm...BDRV_TYPE_FLOPPY probably too? If we want to be consistent, yes. Or

[Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-17 Thread Alexander Graf
Jan Kiszka wrote: > On 2010-12-20 22:13, Alexander Graf wrote: > >> When not using MSI, receiving an interrupt while the interrupt line is active >> pulses the interrupt line. Without this, guests don't realize that a new >> interrupt occured. >> > > This doesn't look OK. The device model s

Re: [Qemu-devel] [PATCH v2 5/6] Emulation of Leon3.

2011-01-17 Thread Fabien Chouteau
On 01/04/2011 07:56 PM, Blue Swirl wrote: On Mon, Jan 3, 2011 at 2:07 PM, Fabien Chouteau wrote: diff --git a/hw/leon3.c b/hw/leon3.c new file mode 100644 index 000..d5fe863 --- /dev/null +++ b/hw/leon3.c @@ -0,0 +1,202 @@ +/* + * QEMU Leon3 System Emulator + * + * Copyright (c) 2010-2011 A

[Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-17 Thread Jan Kiszka
On 2011-01-17 17:00, Alexander Graf wrote: > Jan Kiszka wrote: >> On 2010-12-20 22:13, Alexander Graf wrote: >> >>> When not using MSI, receiving an interrupt while the interrupt line is >>> active >>> pulses the interrupt line. Without this, guests don't realize that a new >>> interrupt occure

Re: [Qemu-devel] Re: [PATCH] usb-msd: Add usb-storage, removable=on|off property

2011-01-17 Thread Christoph Hellwig
On Mon, Jan 17, 2011 at 10:04:05AM +, Stefan Hajnoczi wrote: > I was considering not using bdrv_set_removable() and instead adding a > hint to the BlockDriverState which gets checked when constructing the > SCSI INQUIRY response. If we take that approach, then QEMU doesn't > consider the block

[Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-17 Thread Alexander Graf
Jan Kiszka wrote: > On 2011-01-17 17:00, Alexander Graf wrote: > >> Jan Kiszka wrote: >> >>> On 2010-12-20 22:13, Alexander Graf wrote: >>> >>> When not using MSI, receiving an interrupt while the interrupt line is active pulses the interrupt line. Without this, gu

Re: [Qemu-devel] [PULL] rtl8139, pci, ioeventfd

2011-01-17 Thread Anthony Liguori
On 01/11/2011 04:42 PM, Michael S. Tsirkin wrote: The following changes since commit 05bf441eb69a813d3893174d54faa6afa8c0d39b: cris: Remove unused orig_flags (2011-01-10 23:28:08 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git for_

[Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-17 Thread Jan Kiszka
On 2011-01-17 17:04, Alexander Graf wrote: > Jan Kiszka wrote: >> On 2011-01-17 17:00, Alexander Graf wrote: >> >>> Jan Kiszka wrote: >>> On 2010-12-20 22:13, Alexander Graf wrote: > When not using MSI, receiving an interrupt while the interrupt line is > a

[Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-17 Thread Alexander Graf
Jan Kiszka wrote: > On 2011-01-17 17:04, Alexander Graf wrote: > >> Jan Kiszka wrote: >> >>> On 2011-01-17 17:00, Alexander Graf wrote: >>> >>> Jan Kiszka wrote: > On 2010-12-20 22:13, Alexander Graf wrote: > > > >>

[Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-17 Thread Jan Kiszka
On 2011-01-17 17:33, Alexander Graf wrote: > Jan Kiszka wrote: >> On 2011-01-17 17:04, Alexander Graf wrote: >> >>> Jan Kiszka wrote: >>> On 2011-01-17 17:00, Alexander Graf wrote: > Jan Kiszka wrote: > > >> On 2010-12-20 22:13, Alexand

[Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-17 Thread Alexander Graf
Jan Kiszka wrote: > On 2011-01-17 17:33, Alexander Graf wrote: > >> Jan Kiszka wrote: >> >>> On 2011-01-17 17:04, Alexander Graf wrote: >>> >>> Jan Kiszka wrote: > On 2011-01-17 17:00, Alexander Graf wrote: > > > >>

[Qemu-devel] [PATCH][qemu-iotests] add support for rbd and sheepdog protocols

2011-01-17 Thread MORITA Kazutaka
This patch introduces tests for protocols other than file, and initially supports rbd and sheepdog. Signed-off-by: MORITA Kazutaka --- 001 |1 + 002 |1 + 003 |1 + 004 |1 + 005 |6 ++ 006 |1 + 007 |1 + 008 |1

[Qemu-devel] Re: [PATCH v2 0/2] strtosz() cleanup

2011-01-17 Thread Alex Williamson
On Mon, 2011-01-17 at 08:24 -0700, Alex Williamson wrote: > On Mon, 2011-01-17 at 16:14 +0100, jes.soren...@redhat.com wrote: > > From: Jes Sorensen > > > > Fix issue with signed char and isspace() as well as clean up switch > > statement using toupper(). > > > > V2 of the patch fixes some types

[Qemu-devel] [PATCH 1/2] strtosz(): Fix name confusion in use of modf()

2011-01-17 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- cutils.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cutils.c b/cutils.c index f7aa90c..328738c 100644 --- a/cutils.c +++ b/cutils.c @@ -304,8 +304,8 @@ ssize_t strtosz_suffix(const char *nptr, char **end, const

[Qemu-devel] [PATCH 0/2] strtosz() more cleanups

2011-01-17 Thread Jes . Sorensen
From: Jes Sorensen Another two cleanups to strtosz() suggested by Alex Williamson. I had reversed the use of the names of the return arguments to modf(), and use the STRTOSZ_DESUFFIX_ macros in the switch() statement. Cheers, Jes Jes Sorensen (2): strtosz(): Fix name confusion in use of mod

[Qemu-devel] Re: [PATCH 0/2] strtosz() more cleanups

2011-01-17 Thread Alex Williamson
On Mon, 2011-01-17 at 18:12 +0100, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > Another two cleanups to strtosz() suggested by Alex Williamson. > > I had reversed the use of the names of the return arguments to modf(), > and use the STRTOSZ_DESUFFIX_ macros in the switch() statement.

[Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-17 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- cutils.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cutils.c b/cutils.c index 328738c..f2c8bbd 100644 --- a/cutils.c +++ b/cutils.c @@ -324,26 +324,26 @@ ssize_t strtosz_suffix(const char *nptr, char **end

Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command

2011-01-17 Thread Kevin Wolf
Am 14.01.2011 17:20, schrieb Christoph Hellwig: > Add a monitor command that allows resizing of block devices while > qemu is running. It uses the existing bdrv_truncate method already > used by qemu-img to do it's work. Compared to qemu-img the size > parsing is very simplicistic, but I think ha

[Qemu-devel] Re: [PATCH 08/12] Threadlet: Add aio_signal_handler threadlet API

2011-01-17 Thread Stefan Hajnoczi
On Mon, Jan 17, 2011 at 3:54 PM, Paolo Bonzini wrote: > On 01/17/2011 10:56 AM, Stefan Hajnoczi wrote: >> >> This would be the right place to create qemu-threadlet.c, > > You mean .h? We need both qemu-threadlet.c and qemu-threadlet.h. Stefan

Re: [Qemu-devel] [PATCH] qed: Refuse to create images on block devices

2011-01-17 Thread Kevin Wolf
Am 14.01.2011 23:44, schrieb Stefan Hajnoczi: > QED relies on the underlying filesystem to extend the file and maintain > its size. Check that images are not created on a block device. > > Signed-off-by: Stefan Hajnoczi Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] Re: [PATCH] usb-msd: Add usb-storage, removable=on|off property

2011-01-17 Thread Stefan Hajnoczi
On Mon, Jan 17, 2011 at 4:01 PM, Christoph Hellwig wrote: > On Mon, Jan 17, 2011 at 10:04:05AM +, Stefan Hajnoczi wrote: >> I was considering not using bdrv_set_removable() and instead adding a >> hint to the BlockDriverState which gets checked when constructing the >> SCSI INQUIRY response.  

[Qemu-devel] Re: [PATCH V2 1/3] Introduce log_start/log_stop in CPUPhysMemoryClient

2011-01-17 Thread Anthony PERARD
On Mon, 17 Jan 2011, Jan Kiszka wrote: > On 2011-01-14 19:10, anthony.per...@citrix.com wrote: > > From: Anthony PERARD > > > > In order to use log_start/log_stop with Xen as well in the vga code, > > this two operations have been put in CPUPhysMemoryClient. > > > > The two new functions cpu_phys

[Qemu-devel] [PATCH 4/5] blockdev: Fix drive_del not to crash when drive is not in use

2011-01-17 Thread Markus Armbruster
Watch this: (qemu) drive_add 0 if=none,file=tmp.img OK (qemu) info block none0: type=hd removable=0 file=tmp.img ro=0 drv=raw encrypted=0 (qemu) drive_del none0 Segmentation fault (core dumped) do_drive_del()'s code to clean up the pointer from a qdev using the drive back

[Qemu-devel] [PATCH 0/5] -drive/drive_add fixes

2011-01-17 Thread Markus Armbruster
Note: PATCH 3/5 makes -drive reject duplicate definitions instead of ignoring all but the first silently. If this isn't sufficiently bug-compatible for you, we need to talk. Markus Armbruster (5): blockdev: Fix error message for invalid -drive CHS blockdev: Make drive_init() use error_report(

Re: [Qemu-devel] Re: [PATCH v2 0/5] iohandlers: Add support for enabling/disabling individual handlers

2011-01-17 Thread Michael Roth
On 01/17/2011 08:57 AM, Anthony Liguori wrote: On 01/17/2011 04:18 AM, Amit Shah wrote: On (Thu) Jan 13 2011 [13:17:22], Anthony Liguori wrote: On 01/13/2011 09:00 AM, Amit Shah wrote: Hi, This patchset adds new interfaces to work with iohandlers. It adds: int assign_fd_handlers(int fd, IOHa

[Qemu-devel] [PATCH 1/5] blockdev: Fix error message for invalid -drive CHS

2011-01-17 Thread Markus Armbruster
When cyls, heads or secs are out of range, the error message prints buf, which points to the value of option "if". Bogus, may even be null. Drop that. Signed-off-by: Markus Armbruster --- blockdev.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/bloc

[Qemu-devel] [PATCH 2/5] blockdev: Make drive_init() use error_report()

2011-01-17 Thread Markus Armbruster
This makes the errors point to the error location, and fixes drive_add to report errors in the monitor instead of stderr. While there, tweak a few error messages for consistency. Signed-off-by: Markus Armbruster --- blockdev.c | 59 ---

[Qemu-devel] [PATCH 5/5] blockdev: Fix drive_add for drives without media

2011-01-17 Thread Markus Armbruster
Watch this: (qemu) drive_add 0 if=none (qemu) info block none0: type=hd removable=0 [not inserted] (qemu) drive_del none0 Segmentation fault (core dumped) add_init_drive() is confused about drive_init()'s failure modes, and cleans up when it shouldn't. This leaves the DriveIn

[Qemu-devel] [PATCH 3/5] blockdev: Reject multiple definitions for the same drive

2011-01-17 Thread Markus Armbruster
For reasons lost in the mist of time, we silently ignore multiple definitions for the same drive: $ qemu-system-x86_64 -nodefaults -vnc :1 -S -monitor stdio -drive if=ide,index=1,file=tmp.qcow2 -drive if=ide,index=1,file=nonexistant QEMU 0.13.50 monitor - type 'help' for more information

[Qemu-devel] Error running qemu on powerpc

2011-01-17 Thread Dushyant Bansal
Hi, I have installed qemu on x86 system. I downloaded debian-powerpc image from http://people.debian.org/~aurel32/qemu/powerpc/ and used it with "qemu-system-ppc". This is the cpuinfo of the guest os (debian-507-powerpc (2.6.26-1-powerpc) ) processor: 0 cpu: 740/750 temperature

[Qemu-devel] KVM call agenda for Jan 18

2011-01-17 Thread Chris Wright
Please send in any agenda items you are interested in covering. thanks, -chris

[Qemu-devel] Re: [PATCH v2 3/3] checkpatch: adjust to QEMUisms

2011-01-17 Thread Blue Swirl
On Mon, Jan 17, 2011 at 7:40 AM, Paolo Bonzini wrote: > On 01/15/2011 06:45 PM, Blue Swirl wrote: >> >> +                       if ($level == 0 && !$block =~ /^\s*\{/ && >> !$allowed) { > > I'm not a Perl expert at all, but I think you need parentheses for the > argument of "!": ! has higher prec

Re: [Qemu-devel] [PATCH v2 1/6] Emulation of GRLIB GPTimer as defined in GRLIB IP Core User's Manual.

2011-01-17 Thread Blue Swirl
On Mon, Jan 17, 2011 at 11:43 AM, Fabien Chouteau wrote: > On 01/04/2011 07:46 PM, Blue Swirl wrote: >> >> On Mon, Jan 3, 2011 at 2:07 PM, Fabien Chouteau >>  wrote:+} >>> >>> +static uint32_t grlib_gptimer_readl(void *opaque, target_phys_addr_t >>> addr) >>> +{ >>> +    GPTimerUnit *unit  = opaqu

Re: [Qemu-devel] [PATCH 1/2] strtosz() use unsigned char as isspace() is not defined for signed char

2011-01-17 Thread Blue Swirl
On Mon, Jan 17, 2011 at 3:14 PM, wrote: > From: Jes Sorensen This is exactly why we have qemu_isspace().

  1   2   >