On Mon, 2011-01-17 at 08:24 -0700, Alex Williamson wrote: > On Mon, 2011-01-17 at 16:14 +0100, jes.soren...@redhat.com wrote: > > From: Jes Sorensen <jes.soren...@redhat.com> > > > > Fix issue with signed char and isspace() as well as clean up switch > > statement using toupper(). > > > > V2 of the patch fixes some types in the commit messages and spells > > Eric correctly. My apologies for getting it wrong. > > > > Jes Sorensen (2): > > strtosz() use unsigned char as isspace() is not defined for signed > > char > > strtosz() use toupper() to simplify switch statement > > > > cutils.c | 10 +++------- > > 1 files changed, 3 insertions(+), 7 deletions(-) > > > > And the modf() usage? Or using STRTOSZ_DEFSUFFIX_* in the switch? Or > avoiding the extra variable in 13/18? Thanks,
Sorry, I'm crossing my mailing lists. These are a fine first step. Acked-by: Alex Williamson <alex.william...@redhat.com>