[Qemu-devel] [PATCH] MIPS Initial support of Godson-3a multicore CPU

2010-12-07 Thread Jin Guojie
Signed-off-by: "Jin Guojie" Reviewed-by: "Gao Xiang" Reviewed-by: "Chen Huacai" A patch for Godson-3a CPU simulation. Godson-3a is a newly developed MIPS-III like, multicore CPU by ICT, China. We believe this patch could be helpful for other Godson developers. For you review. Any comment is

[Qemu-devel] [PATCH] fix do_socket(): type conversion for all targets

2010-12-07 Thread Jin Guojie
Signed-off-by: "Jin Guojie" Signed-off-by: "Yin Yixiao" Reviewed-by: "Gao Xiang" A patch for do_socket() in Linux user mode. The original code only handles socket constants conversion for target MIPS. We encountered this problem when emulating X86 apps on MIPS machines. This patch extends t

[Qemu-devel] [PATCH 1/4] qemu-option: Don't reinvent append_option_parameters()

2010-12-07 Thread Stefan Hajnoczi
parse_option_parameters() may need to create a new option parameter list from a template list. Use append_option_parameters() instead of duplicating the code. Signed-off-by: Stefan Hajnoczi --- qemu-option.c |9 + 1 files changed, 1 insertions(+), 8 deletions(-) diff --git a/qemu-o

[Qemu-devel] [PATCH 0/4] qemu-img: Fail creation if backing format is invalid

2010-12-07 Thread Stefan Hajnoczi
This patch series adds a check to validate the backing format before creating an image file. This ensures we provide a clear error message as early as possible when an unsupported format is used. The first three patches clean up code on the way and the last patch makes the actual backing format v

[Qemu-devel] [PATCH 3/4] qemu-img: Free option parameter lists in img_create()

2010-12-07 Thread Stefan Hajnoczi
Free option parameter lists in the img_create() error return path. Signed-off-by: Stefan Hajnoczi --- qemu-img.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 5b6e648..23bb7dc 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -439,8 +439,6 @@

[Qemu-devel] [PATCH 4/4] qemu-img: Fail creation if backing format is invalid

2010-12-07 Thread Stefan Hajnoczi
The qemu-img create command should check the backing format to ensure only image files with valid backing formats are created. By checking in qemu-img.c we can print a useful error message. Signed-off-by: Stefan Hajnoczi --- qemu-img.c | 22 -- 1 files changed, 12 insertio

[Qemu-devel] [PATCH 2/4] qemu-option: Fix parse_option_parameters() documentation typo

2010-12-07 Thread Stefan Hajnoczi
Yoda said, "list is the templace is". Fix this. Signed-off-by: Stefan Hajnoczi --- qemu-option.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index e380fc1..65db542 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -394,8 +394,8 @@ QE

Re: [Qemu-devel] [PATCH 1/6] [RFC] Emulation of GRLIB GPTimer as defined in GRLIB IP Core User's Manual.

2010-12-07 Thread Fabien Chouteau
On 12/06/2010 06:12 PM, Blue Swirl wrote: On Mon, Dec 6, 2010 at 9:26 AM, Fabien Chouteau wrote: Signed-off-by: Fabien Chouteau --- hw/grlib_gptimer.c | 448 1 files changed, 448 insertions(+), 0 deletions(-) diff --git a/hw/grlib_gptim

Re: [Qemu-devel] [PATCH, RFT] monitor: implement x86 info tlb for PAE and long modes

2010-12-07 Thread Ian Campbell
On Mon, 2010-12-06 at 18:41 +, Blue Swirl wrote: > On Mon, Dec 6, 2010 at 1:05 PM, Ian Campbell wrote: > > On Mon, 2010-12-06 at 12:12 +0100, Alexander Graf wrote: > >> On 05.12.2010, at 17:25, Blue Swirl wrote: > >> > >> > 'info tlb' didn't show correct information for PAE mode and > >> > x86

Re: [Qemu-devel] [PATCH, RFT] monitor: implement x86 info tlb for PAE and long modes

2010-12-07 Thread Alexander Graf
On 06.12.2010, at 19:38, Blue Swirl wrote: > On Mon, Dec 6, 2010 at 11:12 AM, Alexander Graf wrote: >> >> On 05.12.2010, at 17:25, Blue Swirl wrote: >> >>> 'info tlb' didn't show correct information for PAE mode and >>> x86_64 long mode. >>> >>> Implement the missing modes. Also print NX bit

Re: [Qemu-devel] [PATCH 0/6] usb-ccid (v8)

2010-12-07 Thread Alon Levy
ping. Blue Swirl - one patch I forgot is in a later message titled "..v8.1.." with the removal of the libcaccard build. On Sun, Nov 28, 2010 at 04:46:41PM +0200, Alon Levy wrote: > This patchset adds three new devices, usb-ccid, ccid-card-passthru and > ccid-card-emulated, providing a CCID bus, a

[Qemu-devel] Re: [RFC][PATCH v5 00/21] virtagent: host/guest RPC communication agent

2010-12-07 Thread Jes Sorensen
On 12/03/10 19:03, Michael Roth wrote: > These patches apply to master, and can also be obtained from: > git://repo.or.cz/qemu/mdroth.git virtagent_v5 > > CHANGES IN V5: > > - Dependency on virtproxy dropped, virtagent now handles transport and > multiplexing of bi-directional RPCs internally >

[Qemu-devel] QEMU 91c111 emulation bug?

2010-12-07 Thread Daniel Drubin
Greetings, I am writing my own application to run on QEMU emulated ARM versatile board. I observe some strange behavior when trying to emply the 91c11 LAN. Initialization passes OK, and I can receive and send ethernet frames (verified with network sniffer). However, after the first transmit the TX

Re: [Qemu-devel] [PATCH 2/6] [RFC] Emulation of GRLIB IRQMP as defined in GRLIB IP Core User's Manual.

2010-12-07 Thread Fabien Chouteau
On 12/06/2010 06:25 PM, Blue Swirl wrote: On Mon, Dec 6, 2010 at 9:26 AM, Fabien Chouteau wrote: Signed-off-by: Fabien Chouteau --- hw/grlib_irqmp.c | 416 ++ 1 files changed, 416 insertions(+), 0 deletions(-) diff --git a/hw/grlib_irqmp

Re: [Qemu-devel] [PATCH 3/6] [RFC] Emulation of GRLIB APB UART as defined in GRLIB IP Core User's Manual.

2010-12-07 Thread Fabien Chouteau
On 12/06/2010 06:29 PM, Blue Swirl wrote: On Mon, Dec 6, 2010 at 9:26 AM, Fabien Chouteau wrote: Signed-off-by: Fabien Chouteau --- hw/grlib_apbuart.c | 231 1 files changed, 231 insertions(+), 0 deletions(-) diff --git a/hw/grlib_apbua

Re: [Qemu-devel] [PATCH 4/6] [RFC] Header file for the GRLIB components.

2010-12-07 Thread Fabien Chouteau
On 12/06/2010 06:31 PM, Blue Swirl wrote: On Mon, Dec 6, 2010 at 9:26 AM, Fabien Chouteau wrote: Signed-off-by: Fabien Chouteau --- hw/grlib.h | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/hw/grlib.h b/hw/grlib.h new file mode 100644 ind

[Qemu-devel] [PATCH 1/1] qemu-img: Deprecate obsolete -6 and -e options

2010-12-07 Thread Jes . Sorensen
From: Jes Sorensen If -6 or -e is specified, an error message is printed and we exit. It does not print help() to avoid the error message getting lost in the noise. Signed-off-by: Jes Sorensen --- block_int.h |1 - qemu-img.c | 53 ++--- 2

Re: [Qemu-devel] [PATCH 5/6] [RFC] Emulation of Leon3.

2010-12-07 Thread Fabien Chouteau
On 12/06/2010 06:53 PM, Blue Swirl wrote: On Mon, Dec 6, 2010 at 9:26 AM, Fabien Chouteau wrote: Signed-off-by: Fabien Chouteau --- Makefile.target |5 +- hw/leon3.c | 310 ++ target-sparc/cpu.h | 10 ++ targe

[Qemu-devel] User mode restart execution

2010-12-07 Thread John Vele
Grettings, I am using user mode qemu for running stand-alone i386 binaries in linux. What I want to do is this: I want to run a binary until it ends, but I don't want qemu-i386 to exit (that is what it does normally) but restart the execution of the same binary from the beginning without exiting.

Re: [Qemu-devel] [PATCH 6/6] [RFC] SPARCV8 asr17 register support.

2010-12-07 Thread Fabien Chouteau
On 12/06/2010 07:01 PM, Blue Swirl wrote: On Mon, Dec 6, 2010 at 9:26 AM, Fabien Chouteau wrote: Signed-off-by: Fabien Chouteau --- hw/leon3.c |6 ++ target-sparc/cpu.h |1 + target-sparc/machine.c |2 ++ target-sparc/translate.c | 10 ++ 4

Re: [Qemu-devel] [PATCH 01/25] QMP: Rename query handlers

2010-12-07 Thread Miguel Di Ciurcio Filho
On Mon, Dec 6, 2010 at 4:23 PM, Luiz Capitulino wrote: > Query handlers still carry their human monitor name. This commit > renames all of them to a more QMP-like name. > > For example, do_info_version() is renamed to qmp_query_version(). > - * do_info_balloon(): Balloon information > + * qmp_quer

[Qemu-devel] Re: [RFC][PATCH v5 01/21] Move code related to fd handlers into utility functions

2010-12-07 Thread Jes Sorensen
On 12/03/10 19:03, Michael Roth wrote: > This allows us to implement an i/o loop outside of vl.c that can > interact with objects that use qemu_set_fd_handler() > > Signed-off-by: Michael Roth This commit message really tells us nothing. Please be more specific about what is in the commit. > di

Re: [Qemu-devel] [PATCH 01/25] QMP: Rename query handlers

2010-12-07 Thread Luiz Capitulino
On Tue, 7 Dec 2010 10:28:25 -0200 Miguel Di Ciurcio Filho wrote: > On Mon, Dec 6, 2010 at 4:23 PM, Luiz Capitulino > wrote: > > Query handlers still carry their human monitor name. This commit > > renames all of them to a more QMP-like name. > > > > For example, do_info_version() is renamed to

[Qemu-devel] Re: [RFC][PATCH v5 03/21] virtagent: common code for managing client/server rpc jobs

2010-12-07 Thread Jes Sorensen
On 12/03/10 19:03, Michael Roth wrote: > This implements a simple state machine to manage client/server rpc > jobs being multiplexed over a single channel. > > A client job consists of sending an rpc request, reading an > rpc response, then making the appropriate callbacks. We allow one > client j

[Qemu-devel] Re: [RFC][PATCH v5 04/21] virtagent: transport definitions and job callbacks

2010-12-07 Thread Jes Sorensen
On 12/03/10 19:03, Michael Roth wrote: > +static void va_server_read_cb(const char *content, size_t content_len) > +{ > +xmlrpc_mem_block *resp_xml; > +VAServerData *server_data = &va_state->server_data; > +int ret; > + > +TRACE("called"); > +resp_xml = xmlrpc_registry_process_c

[Qemu-devel] [[PATCH][RESEND]] virtio-serial-bus: Bump up control vq descriptors to min. required

2010-12-07 Thread Amit Shah
The current default of 16 buffers for the control vq is too small for the default max_nr_ports of 32. We can get more entries in there, example when asking the guest to add max. allowed ports. Default to using the minimum required (next power of 2) of the max_nr_ports in use. Signed-off-by: Amit

[Qemu-devel] Re: [RFC][PATCH v5 05/21] virtagent: base client definitions

2010-12-07 Thread Jes Sorensen
On 12/03/10 19:03, Michael Roth wrote: > +#ifndef VIRTAGENT_H > +#define VIRTAGENT_H > + > +#include "monitor.h" > + > +#define GUEST_AGENT_PATH_CLIENT "/tmp/virtagent-guest-client.sock" > +#define HOST_AGENT_PATH_CLIENT "/tmp/virtagent-host-client.sock" As mentioned last time, this belongs in a c

[Qemu-devel] Re: [RFC][PATCH v5 06/21] virtagent: base server definitions

2010-12-07 Thread Jes Sorensen
On 12/03/10 19:03, Michael Roth wrote: > +#define GUEST_AGENT_SERVICE_ID "virtagent" > +#define GUEST_AGENT_PATH "/tmp/virtagent-guest.sock" > +#define HOST_AGENT_SERVICE_ID "virtagent-host" > +#define HOST_AGENT_PATH "/tmp/virtagent-host.sock" > +#define VA_GETFILE_MAX 1 << 30 > +#define VA_FILEBU

Re: [Qemu-devel] Re: [RFC][PATCH v5 08/21] virtagent: add agent_viewfile qmp/hmp command

2010-12-07 Thread Michael Roth
On 12/06/2010 05:20 PM, Michael Roth wrote: On 12/06/2010 04:08 PM, Adam Litke wrote: On Fri, 2010-12-03 at 12:03 -0600, Michael Roth wrote: Utilize the getfile RPC to provide a means to view text files in the guest. Getfile can handle binary files as well but we don't advertise that here due t

Re: [Qemu-devel] [PATCH] MIPS Initial support of Godson-3a multicore CPU

2010-12-07 Thread chen huacai
1, signed-off-by and reviewed-by should put after the introduction and before the code, not at first. 2, You'd better split the big patch to 2~3 small patches, E.g. CPU definition and board emulation should be split. The format of email title will be [Patch 0/3], [Patch 1/3] and so on. [Patch 0/3]

[Qemu-devel] [PATCH 0/5] ARM: fix VQSHL (register)

2010-12-07 Thread Peter Maydell
This patchset fixes bugs in the decode and implementation of the ARM Neon VQSHL (register) instruction form. It is a split out version of those parts of the maemo-qemu tree commit 03a2445a which deal with this instruction form; the remainder which address VQSHL (immediate) I'll send in a separate p

[Qemu-devel] Re: [RFC][PATCH v5 07/21] virtagent: add va.getfile RPC

2010-12-07 Thread Jes Sorensen
On 12/03/10 19:03, Michael Roth wrote: > Add RPC to retrieve a guest file. This interface is intended > for smaller reads like peeking at logs and /proc and such. I think you need to redesign your approach here. see below. In 06/21 you had: +#define VA_GETFILE_MAX 1 << 30 > +while ((ret

[Qemu-devel] Re: [RFC][PATCH v5 08/21] virtagent: add agent_viewfile qmp/hmp command

2010-12-07 Thread Jes Sorensen
On 12/03/10 19:03, Michael Roth wrote: > Utilize the getfile RPC to provide a means to view text files in the > guest. Getfile can handle binary files as well but we don't advertise > that here due to the special handling requiring to store it and provide > it back to the user (base64 encoding it f

[Qemu-devel] [PATCH 3/5] ARM: Fix VQSHL of signed 64 bit values by shift counts >= 64

2010-12-07 Thread Peter Maydell
VQSHL of a signed 64 bit non-zero value by a shift count >= 64 should saturate; return the correct value in this case. Signed-off-by: Peter Maydell --- target-arm/neon_helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-arm/neon_helper.c b/target-arm/neon_he

[Qemu-devel] [PATCH 5/5] ARM: Correct result in saturating cases for VQSHL of s8/16/32

2010-12-07 Thread Peter Maydell
Where VQSHL of a signed 8/16/32 bit value saturated, the result value was not being calculated correctly (it should be either the minimum or maximum value for the size of the signed type). Signed-off-by: Peter Maydell --- target-arm/neon_helper.c | 15 --- 1 files changed, 12 inser

[Qemu-devel] [PATCH 4/5] ARM: remove pointless else clause in VQSHL of u64

2010-12-07 Thread Peter Maydell
From: Juha Riihimäki Remove a pointless else clause in the neon_qshl_u64 helper. Signed-off-by: Juha Riihimäki Reviewed-by: Peter Maydell --- target-arm/neon_helper.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c

[Qemu-devel] [PATCH 2/5] ARM: Fix VQSHL of signed 64 bit values

2010-12-07 Thread Peter Maydell
From: Juha Riihimäki Add a missing '-' which meant that we were misinterpreting the shift argument for VQSHL of 64 bit signed values and treating almost every shift value as if it were an extremely large right shift. Signed-off-by: Juha Riihimäki Reviewed-by: Peter Maydell --- target-arm/neon

[Qemu-devel] [PATCH 1/5] ARM: Fix arguments passed to VQSHL helpers

2010-12-07 Thread Peter Maydell
From: Juha Riihimäki Correct the arguments passed when generating neon qshl_{u,s}64() helpers so that we use the correct registers. Signed-off-by: Juha Riihimäki Reviewed-by: Peter Maydell --- target-arm/translate.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/t

Re: [Qemu-devel] Re: [RFC][PATCH v5 00/21] virtagent: host/guest RPC communication agent

2010-12-07 Thread Michael Roth
On 12/07/2010 04:24 AM, Jes Sorensen wrote: On 12/03/10 19:03, Michael Roth wrote: These patches apply to master, and can also be obtained from: git://repo.or.cz/qemu/mdroth.git virtagent_v5 CHANGES IN V5: - Dependency on virtproxy dropped, virtagent now handles transport and multiplexing o

[Qemu-devel] Re: [RFC][PATCH v5 09/21] virtagent: add va.getdmesg RPC

2010-12-07 Thread Jes Sorensen
On 12/03/10 19:03, Michael Roth wrote: > Add RPC to view guest dmesg output. > > Signed-off-by: Michael Roth > --- > virtagent-server.c | 46 ++ > 1 files changed, 46 insertions(+), 0 deletions(-) > > diff --git a/virtagent-server.c b/virtagent-serv

[Qemu-devel] Re: [RFC][PATCH v5 20/21] virtagent: integrate virtagent server/client via chardev

2010-12-07 Thread Jes Sorensen
On 12/03/10 19:03, Michael Roth wrote: > +#include "virtagent-common.h" > + > +static CharDriverState *qemu_chr_open_virtagent(QemuOpts *opts) > +{ > +CharDriverState *chr; > +int fd, ret; > + > +/* revert to/enforce default socket chardev options for virtagent */ > +if (qemu_opt_ge

Re: [Qemu-devel] Re: [RFC][PATCH v5 01/21] Move code related to fd handlers into utility functions

2010-12-07 Thread Michael Roth
On 12/07/2010 07:31 AM, Jes Sorensen wrote: On 12/03/10 19:03, Michael Roth wrote: This allows us to implement an i/o loop outside of vl.c that can interact with objects that use qemu_set_fd_handler() Signed-off-by: Michael Roth This commit message really tells us nothing. Please be more spec

Re: [Qemu-devel] Re: [RFC][PATCH v5 01/21] Move code related to fd handlers into utility functions

2010-12-07 Thread Jes Sorensen
On 12/07/10 15:48, Michael Roth wrote: > On 12/07/2010 07:31 AM, Jes Sorensen wrote: >> On 12/03/10 19:03, Michael Roth wrote: >>> This allows us to implement an i/o loop outside of vl.c that can >>> interact with objects that use qemu_set_fd_handler() >>> >>> Signed-off-by: Michael Roth >> >> This

Re: [Qemu-devel] Re: [RFC][PATCH v5 03/21] virtagent: common code for managing client/server rpc jobs

2010-12-07 Thread Michael Roth
On 12/07/2010 07:38 AM, Jes Sorensen wrote: On 12/03/10 19:03, Michael Roth wrote: This implements a simple state machine to manage client/server rpc jobs being multiplexed over a single channel. A client job consists of sending an rpc request, reading an rpc response, then making the appropria

Re: [Qemu-devel] KVM call agenda for Dec 7

2010-12-07 Thread Jes Sorensen
On 12/07/10 00:51, Chris Wright wrote: > Please send in any agenda items you are interested in covering. > > thanks, > -chris > No agenda, no replies Call canceled I presume? Jes

Re: [Qemu-devel] KVM call agenda for Dec 7

2010-12-07 Thread Chris Wright
* Jes Sorensen (jes.soren...@redhat.com) wrote: > On 12/07/10 00:51, Chris Wright wrote: > > Please send in any agenda items you are interested in covering. > > > > thanks, > > -chris > > > > No agenda, no replies > > Call canceled I presume? Indeed, next week, then pick up next year...

[Qemu-devel] Re: arm: fix ldrexd/strexd

2010-12-07 Thread Nathan Froyd
On Thu, Nov 04, 2010 at 07:47:45AM -, Peter Maydell wrote: > Correct ldrexd and strexd code to always read and write the > high word of the 64-bit value from addr+4. > Also make ldrexd and strexd agree that for a 64 bit value the > address in env->exclusive_addr is that of the low word. > > Th

[Qemu-devel] [Bug 686613] [NEW] USB MSD are not marked as removable

2010-12-07 Thread Justin M. Forbes
Public bug reported: Filed from Fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=589130 Guests can access USB Mass Storage Device, but fail to mark them as removable. ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are

[Qemu-devel] [PATCH 04/14] ARM: fix ldrexd/strexd

2010-12-07 Thread Peter Maydell
Correct ldrexd and strexd code to always read and write the high word of the 64-bit value from addr+4. Also make ldrexd and strexd agree that for a 64 bit value the address in env->exclusive_addr is that of the low word. This fixes the issues reported in https://bugs.launchpad.net/qemu/+bug/670883

[Qemu-devel] [PATCH 11/14] ARM: Return correct result for single<->double conversion of NaN

2010-12-07 Thread Peter Maydell
The ARM ARM defines that if the input to a single<->double conversion is a NaN then the output is always forced to be a quiet NaN by setting the most significant bit of the fraction part. Signed-off-by: Peter Maydell Reviewed-by: Nathan Froyd --- target-arm/helper.c | 12 ++-- 1 files

[Qemu-devel] [PATCH 05/14] ARM: Fix decoding of VFP forms of VCVT between float and int/fixed

2010-12-07 Thread Peter Maydell
Correct the decoding of source and destination registers for the VFP forms of the VCVT instructions which convert between floating point and integer or fixed-point. Signed-off-by: Peter Maydell Reviewed-by: Nathan Froyd --- target-arm/translate.c | 19 --- 1 files changed, 12

[Qemu-devel] [PATCH 00/14] [PULL] ARM fixes, v2

2010-12-07 Thread Peter Maydell
Anthony, This is a pull request for patches which fix problems with the generated code for ARM targets. This updates the VCVT patches as reviewed by Nathan Froyd; all the included patches have Reviewed-by: tags from him. They've been sent to the list previously, and I've reviewed and tested them.

[Qemu-devel] [PATCH 14/14] ARM: Implement VCVT to 16 bit integer using new softfloat routines

2010-12-07 Thread Peter Maydell
Use the softfloat conversion routines for conversion to 16 bit integers, because just casting to a 16 bit type truncates the value rather than saturating it at 16-bit MAXINT/MININT. Signed-off-by: Peter Maydell Reviewed-by: Nathan Froyd --- target-arm/helper.c |2 +- 1 files changed, 1 inse

[Qemu-devel] [PATCH 13/14] softfloat: Add float/double to 16 bit integer conversion functions

2010-12-07 Thread Peter Maydell
The ARM architecture needs float/double to 16 bit integer conversions. (The 32 bit versions aren't sufficient because of the requirement to saturate at 16 bit MAXINT/MININT and to get the exception bits right.) Signed-off-by: Peter Maydell Reviewed-by: Nathan Froyd --- fpu/softfloat.c | 136 ++

[Qemu-devel] [PATCH 10/14] softfloat: Add float*_maybe_silence_nan() functions

2010-12-07 Thread Peter Maydell
Add functions float*_maybe_silence_nan() which ensure that a value is not a signaling NaN by turning it into a quiet NaN. Signed-off-by: Peter Maydell Reviewed-by: Nathan Froyd --- fpu/softfloat-specialize.h | 38 ++ fpu/softfloat.h|2 ++ 2

[Qemu-devel] [PATCH 09/14] ARM: Return correct result for float-to-integer conversion of NaN

2010-12-07 Thread Peter Maydell
The ARM architecture mandates that converting a NaN value to integer gives zero (if Invalid Operation FP exceptions are not being trapped). This isn't the behaviour of the SoftFloat library, so NaNs must be special-cased. Signed-off-by: Peter Maydell Reviewed-by: Nathan Froyd --- target-arm/hel

[Qemu-devel] [PATCH 03/14] target-arm: Handle 'smc' as an undefined instruction

2010-12-07 Thread Peter Maydell
From: Adam Lackorzynski Refine check on bkpt so that smc and undefined instruction encodings are handled as an undefined instruction and trap. Signed-off-by: Adam Lackorzynski Signed-off-by: Peter Maydell Reviewed-by: Nathan Froyd --- target-arm/translate.c |9 - 1 files changed,

[Qemu-devel] [PATCH 02/14] target-arm: Fix mixup in decoding of saturating add and sub

2010-12-07 Thread Peter Maydell
From: Johan Bengtsson The thumb2 decoder contained a mixup between the bit controlling doubling and the bit controlling if the operation was an add or a sub. Signed-off-by: Johan Bengtsson Signed-off-by: Peter Maydell Reviewed-by: Nathan Froyd --- target-arm/translate.c |4 ++-- 1 files

[Qemu-devel] [PATCH 06/14] ARM: Fix decoding of Neon forms of VCVT between float and fixed point

2010-12-07 Thread Peter Maydell
Fix errors in the decoding of the Neon forms of fixed-point VCVT: * fixed-point VCVT is op 14 and 15, not 15 and 16 * the fbits immediate field was being misinterpreted * the sense of the to_fixed bit was inverted Signed-off-by: Peter Maydell Reviewed-by: Nathan Froyd --- target-arm/translat

[Qemu-devel] [PATCH 12/14] ARM: Ignore top 16 bits when doing VCVT from 16 bit fixed point

2010-12-07 Thread Peter Maydell
VCVT of 16 bit fixed point to float should ignore the top 16 bits of the source register. Cast to int16_t and friends rather than int16 -- the former is guaranteed exactly 16 bits wide where the latter is merely at least 16 bits wide (and so is usually 32 bits). Signed-off-by: Peter Maydell Revie

Re: [Qemu-devel] [PATCH 00/14] [PULL] ARM fixes, v2

2010-12-07 Thread Peter Maydell
Embarrassingly, I managed to fail to include the critical item for a pull request, ie the git repo url. Here it is, with apologies for the error: The following changes since commit 2c90fe2b71df2534884bce96d90cbfcc93aeedb8: Kirill Batuzov (1): Speedup 'tb_find_slow' by using the same heu

[Qemu-devel] [PATCH 08/14] softfloat: Add float*_is_any_nan() functions

2010-12-07 Thread Peter Maydell
Add float*_is_any_nan() functions which return true if the argument is a NaN of any kind (quiet or signalling). Signed-off-by: Peter Maydell Reviewed-by: Nathan Froyd --- fpu/softfloat.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/fpu/softfloat.h b/fpu/sof

[Qemu-devel] [PATCH 01/14] target-arm: Add support for PKHxx in thumb2

2010-12-07 Thread Peter Maydell
From: Johan Bengtsson The PKHxx instructions were not recognized by the thumb2 decoder. The solution provided in this changeset is identical to the arm-mode implementation. Signed-off-by: Johan Bengtsson Signed-off-by: Peter Maydell Reviewed-by: Nathan Froyd --- target-arm/translate.c | 63

[Qemu-devel] [PATCH 07/14] ARM: Fix sense of to_integer bit in Neon VCVT float/int conversion

2010-12-07 Thread Peter Maydell
Signed-off-by: Peter Maydell Reviewed-by: Nathan Froyd --- target-arm/translate.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 0b3e4e6..d4a0666 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.

[Qemu-devel] Re: [PATCH 1/1] qemu-img: Deprecate obsolete -6 and -e options

2010-12-07 Thread Kevin Wolf
Am 07.12.2010 12:31, schrieb jes.soren...@redhat.com: > From: Jes Sorensen > > If -6 or -e is specified, an error message is printed and we exit. It > does not print help() to avoid the error message getting lost in the > noise. > > Signed-off-by: Jes Sorensen > --- > block_int.h |1 - > q

[Qemu-devel] Re: [RFC][PATCH v5 07/21] virtagent: add va.getfile RPC

2010-12-07 Thread Adam Litke
Hi Jes, you raise some good points and pitfalls with the current getfile approach. I've been thinking about an alternative and am wondering what you (and others) think... First off, I think we should switch to a copyfile() API that allows us to avoid presenting the file contents to the user. Nei

[Qemu-devel] Re: [PATCH 1/1] qemu-img: Deprecate obsolete -6 and -e options

2010-12-07 Thread Jes Sorensen
On 12/07/10 17:02, Kevin Wolf wrote: >> @@ -323,11 +310,13 @@ static int img_create(int argc, char **argv) >> fmt = optarg; >> break; >> case 'e': >> -flags |= BLOCK_FLAG_ENCRYPT; >> -break; >> +printf("qemu-img: option -e is de

[Qemu-devel] [PATCH v2 1/1] qemu-img: Deprecate obsolete -6 and -e options

2010-12-07 Thread Jes . Sorensen
From: Jes Sorensen If -6 or -e is specified, an error message is printed and we exit. It does not print help() to avoid the error message getting lost in the noise. Signed-off-by: Jes Sorensen --- block_int.h |1 - qemu-img.c | 53 ++--- 2

[Qemu-devel] Re: [PATCH v2 1/1] qemu-img: Deprecate obsolete -6 and -e options

2010-12-07 Thread Kevin Wolf
Am 07.12.2010 17:44, schrieb jes.soren...@redhat.com: > From: Jes Sorensen > > If -6 or -e is specified, an error message is printed and we exit. It > does not print help() to avoid the error message getting lost in the > noise. > > Signed-off-by: Jes Sorensen Thanks, applied to the block bran

[Qemu-devel] Re: [PATCH v2 1/2] Do not register kvmclock savevm section if kvmclock is disabled.

2010-12-07 Thread Glauber Costa
On Mon, 2010-12-06 at 19:04 -0200, Marcelo Tosatti wrote: > On Mon, Dec 06, 2010 at 09:03:46AM -0500, Glauber Costa wrote: > > Usually nobody usually thinks about that scenario (me included and > > specially), > > but kvmclock can be actually disabled in the host. > > > > It happens in two scenar

Re: [Qemu-devel] Re: [RFC][PATCH v5 04/21] virtagent: transport definitions and job callbacks

2010-12-07 Thread Michael Roth
On 12/07/2010 07:44 AM, Jes Sorensen wrote: On 12/03/10 19:03, Michael Roth wrote: +static void va_server_read_cb(const char *content, size_t content_len) +{ +xmlrpc_mem_block *resp_xml; +VAServerData *server_data =&va_state->server_data; +int ret; + +TRACE("called"); +resp_x

Re: [Qemu-devel] Re: [RFC][PATCH v5 09/21] virtagent: add va.getdmesg RPC

2010-12-07 Thread Michael Roth
On 12/07/2010 08:37 AM, Jes Sorensen wrote: On 12/03/10 19:03, Michael Roth wrote: Add RPC to view guest dmesg output. Signed-off-by: Michael Roth --- virtagent-server.c | 46 ++ 1 files changed, 46 insertions(+), 0 deletions(-) diff --git a/vir

[Qemu-devel] [PATCH 1/1] qemu-img.c: Clean up handling of image size in img_create()

2010-12-07 Thread Jes . Sorensen
From: Jes Sorensen This cleans up the handling of image size in img_create() by parsing the value early, and then only setting it once if a value has been added as the last argument to the command line. Signed-off-by: Jes Sorensen --- qemu-img.c | 19 +++ 1 files changed, 11

Re: [Qemu-devel] [PATCH 0/6] [RFC] New SPARC machine: Leon3

2010-12-07 Thread Fabien Chouteau
On 12/06/2010 07:12 PM, Blue Swirl wrote: On Mon, Dec 6, 2010 at 3:07 PM, Fabien Chouteau wrote: On 12/06/2010 11:44 AM, Artyom Tarasenko wrote: On Mon, Dec 6, 2010 at 10:26 AM, Fabien Chouteau wrote: Hi everyone, I'm glad to submit my first patches to the Qemu-devel list. This patch set

[Qemu-devel] Using the mailing list for asking questions about the source code

2010-12-07 Thread Stefano Bonifazi
Hi All! I am new in QEMU developing and I am not sure if I can use this mailing list for asking general questions about QEMU source code as I could not find any guidelines about it. I noticed that, usually, questions about the source code in the QEMU forum never receive answers. Surely the bes

Re: [Qemu-devel] [PATCH 1/1] qemu-img.c: Clean up handling of image size in img_create()

2010-12-07 Thread Stefan Hajnoczi
On Tue, Dec 7, 2010 at 5:39 PM, wrote: >     // The size for the image must always be specified, with one exception: >     // If we are using a backing file, we can obtain the size from there > -    if (get_option_parameter(param, BLOCK_OPT_SIZE)->value.n == -1) { > - > +    if (get_option_parame

Re: [Qemu-devel] Using the mailing list for asking questions about the source code

2010-12-07 Thread Stefan Weil
Am 07.12.2010 21:22, schrieb Stefano Bonifazi: Hi All! I am new in QEMU developing and I am not sure if I can use this mailing list for asking general questions about QEMU source code as I could not find any guidelines about it. I noticed that, usually, questions about the source code in the Q

Re: [Qemu-devel] Using the mailing list for asking questions about the source code

2010-12-07 Thread Stefano Bonifazi
On 12/07/2010 10:01 PM, Stefan Weil wrote: Hi Stefano, you found this mailing list, so I assume you read everything which is available on http://wiki.qemu.org/Main_Page, and you also tried hard to find the answers to your questions yourself, didn't you? If there remain concrete questions, you

Re: [Qemu-devel] [PATCH 1/1] qemu-img.c: Clean up handling of image size in img_create()

2010-12-07 Thread Jes Sorensen
On 12/07/10 21:36, Stefan Hajnoczi wrote: > On Tue, Dec 7, 2010 at 5:39 PM, wrote: >> // The size for the image must always be specified, with one exception: >> // If we are using a backing file, we can obtain the size from there >> -if (get_option_parameter(param, BLOCK_OPT_SIZE)->va

Re: [Qemu-devel] [PATCH 06/21] vl: add a tmp pointer so that a handler can delete the entry to which it belongs.

2010-12-07 Thread Isaku Yamahata
QLIST_FOREACH_SAFE? On Thu, Nov 25, 2010 at 03:06:45PM +0900, Yoshiaki Tamura wrote: > By copying the next entry to a tmp pointer, > qemu_del_vm_change_state_handler() can be called in the handler. > > Signed-off-by: Yoshiaki Tamura > --- > vl.c |5 +++-- > 1 files changed, 3 insertions(+),