On 12/03/10 19:03, Michael Roth wrote:
> +#include "virtagent-common.h"
> +
> +static CharDriverState *qemu_chr_open_virtagent(QemuOpts *opts)
> +{
> + CharDriverState *chr;
> + int fd, ret;
> +
> + /* revert to/enforce default socket chardev options for virtagent */
> + if (qemu_opt_get(opts, "path") == NULL) {
> + qemu_opt_set(opts, "path", "/tmp/virtagent-client.sock");
> + }
More hardcoded paths, which you defined somewhere in a header already.
Again, please make it configurable.
> + //qemu_opt_set(opts, "id", "virtagent");
If it isn't needed, please remove it.
Cheers,
Jes
