Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

2010-11-21 Thread Gleb Natapov
On Sat, Nov 20, 2010 at 10:17:09PM +0200, Michael S. Tsirkin wrote: > On Fri, Nov 19, 2010 at 10:38:42PM +0200, Gleb Natapov wrote: > > On Fri, Nov 19, 2010 at 06:02:58PM +0100, Markus Armbruster wrote: > > > "Michael S. Tsirkin" writes: > > > > > > > On Tue, Nov 09, 2010 at 11:41:43AM +0900, Isa

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

2010-11-21 Thread Michael S. Tsirkin
On Sun, Nov 21, 2010 at 10:32:11AM +0200, Gleb Natapov wrote: > On Sat, Nov 20, 2010 at 10:17:09PM +0200, Michael S. Tsirkin wrote: > > On Fri, Nov 19, 2010 at 10:38:42PM +0200, Gleb Natapov wrote: > > > On Fri, Nov 19, 2010 at 06:02:58PM +0100, Markus Armbruster wrote: > > > > "Michael S. Tsirkin"

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

2010-11-21 Thread Gleb Natapov
On Sun, Nov 21, 2010 at 11:50:18AM +0200, Michael S. Tsirkin wrote: > On Sun, Nov 21, 2010 at 10:32:11AM +0200, Gleb Natapov wrote: > > On Sat, Nov 20, 2010 at 10:17:09PM +0200, Michael S. Tsirkin wrote: > > > On Fri, Nov 19, 2010 at 10:38:42PM +0200, Gleb Natapov wrote: > > > > On Fri, Nov 19, 201

[Qemu-devel] Oudated vgabios.git on git.qemu.org

2010-11-21 Thread Avi Kivity
qemu.git points to vgabios.git 19ea12c230ded95928ecaef0db47a82231c2e485, which isn't available on git.qemu.org/vgabios.git. -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

2010-11-21 Thread Michael S. Tsirkin
On Sun, Nov 21, 2010 at 12:19:03PM +0200, Gleb Natapov wrote: > On Sun, Nov 21, 2010 at 11:50:18AM +0200, Michael S. Tsirkin wrote: > > On Sun, Nov 21, 2010 at 10:32:11AM +0200, Gleb Natapov wrote: > > > On Sat, Nov 20, 2010 at 10:17:09PM +0200, Michael S. Tsirkin wrote: > > > > On Fri, Nov 19, 201

Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects

2010-11-21 Thread Jes Sorensen
On 11/20/10 19:31, Stefan Hajnoczi wrote: > On Sat, Nov 20, 2010 at 6:04 PM, Andreas Färber > wrote: >> http://developer.apple.com/library/mac/#documentation/Darwin/Reference/ManPages/man3/daemon.3.html > > Deprecated in favor of using launchd. > > Removing qemu-nbd from the build because there

Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects

2010-11-21 Thread Jes Sorensen
On 11/20/10 18:22, Andreas Färber wrote: > Am 19.11.2010 um 17:30 schrieb jes.soren...@redhat.com: > >> From: Jes Sorensen >> >> Signed-off-by: Jes Sorensen >> --- >> Makefile |2 +- >> Makefile.objs | 12 ++-- >> 2 files changed, 11 insertions(+), 3 deletions(-) > > Tested-by:

Re: [Qemu-devel] [PATCH 10/11] config: Add header file for device config options

2010-11-21 Thread Blue Swirl
On Fri, Nov 19, 2010 at 2:56 AM, Alexander Graf wrote: > So far we have C preprocessor defines for target and host config > options, but we're lacking any information on which devices are > available. > > We do need that information at times though, for example in the > ahci patch where we need to

Re: [Qemu-devel] [PATCH 10/11] config: Add header file for device config options

2010-11-21 Thread Alexander Graf
On 21.11.2010, at 13:37, Blue Swirl wrote: > On Fri, Nov 19, 2010 at 2:56 AM, Alexander Graf wrote: >> So far we have C preprocessor defines for target and host config >> options, but we're lacking any information on which devices are >> available. >> >> We do need that information at times tho

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

2010-11-21 Thread Gleb Natapov
On Sun, Nov 21, 2010 at 01:53:26PM +0200, Michael S. Tsirkin wrote: > > > The guests. > > Which one? There are many guests. Your favorite? > > > > > For CLI, we need an easy way to map a device in guest to the > > > device in qemu and back. > > Then use eth0, /dev/sdb, or even C:. Your way is not

Re: [Qemu-devel] [PATCH 10/11] config: Add header file for device config options

2010-11-21 Thread Blue Swirl
On Sun, Nov 21, 2010 at 12:45 PM, Alexander Graf wrote: > > On 21.11.2010, at 13:37, Blue Swirl wrote: > >> On Fri, Nov 19, 2010 at 2:56 AM, Alexander Graf wrote: >>> So far we have C preprocessor defines for target and host config >>> options, but we're lacking any information on which devices a

[Qemu-devel] Re: Oudated vgabios.git on git.qemu.org

2010-11-21 Thread Anthony Liguori
On 11/21/2010 04:23 AM, Avi Kivity wrote: qemu.git points to vgabios.git 19ea12c230ded95928ecaef0db47a82231c2e485, which isn't available on git.qemu.org/vgabios.git. As I mentioned in another mail, I had to switch the repo from mirror to push mode. It's all now fixed up. Regards, Anthony

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

2010-11-21 Thread Michael S. Tsirkin
On Sun, Nov 21, 2010 at 02:50:14PM +0200, Gleb Natapov wrote: > On Sun, Nov 21, 2010 at 01:53:26PM +0200, Michael S. Tsirkin wrote: > > > > The guests. > > > Which one? There are many guests. Your favorite? > > > > > > > For CLI, we need an easy way to map a device in guest to the > > > > device i

Re: [Qemu-devel] [PATCH] configure: Add compiler option -Wmissing-format-attribute

2010-11-21 Thread Anthony Liguori
On 11/15/2010 02:22 PM, Stefan Weil wrote: With the previous patches, hopefully all functions with printf like arguments use gcc's format checking. This was tested with default build configuration on linux and windows hosts (including some cross compilations), so chances are good that there rema

Re: [Qemu-devel] [PATCH] configure: Add compiler option -Wmissing-format-attribute

2010-11-21 Thread Stefan Weil
Am 21.11.2010 15:51, schrieb Anthony Liguori: On 11/15/2010 02:22 PM, Stefan Weil wrote: With the previous patches, hopefully all functions with printf like arguments use gcc's format checking. This was tested with default build configuration on linux and windows hosts (including some cross com

Re: [Qemu-devel] [PATCH] vgabios update: handle compatibility with older qemu versions

2010-11-21 Thread Anthony Liguori
On 11/17/2010 05:06 AM, Gerd Hoffmann wrote: As pointed out by avi the vgabios update is guest-visible and thus has migration implications. One change is that the vga has a valid pci rom bar now. We already have a pci bus property to enable/disable the rom bar and we'll load the bios via fw_cfg

Re: [Qemu-devel] [PATCH][RESEND] pcnet: Do not receive external frames in loopback mode

2010-11-21 Thread Anthony Liguori
On 10/19/2010 10:03 AM, Jan Kiszka wrote: While not explicitly stated in the spec, it was observed on real systems that enabling loopback testing on the pcnet controller disables reception of external frames. And some legacy software relies on it, so provide this behavior. Signed-off-by: Jan Kis

Re: [Qemu-devel] [PATCH 0/2] msi support for virtfs

2010-11-21 Thread Anthony Liguori
On 11/11/2010 05:59 AM, Gerd Hoffmann wrote: Hi, This tiny patch series adds msi support for virtfs. It's two patches only because we need a compat property to stay compatible with -stable and we don't have a pc-0.14 machine type yet, so this is added first. Applied all. Thanks. Rega

Re: [Qemu-devel] [PATCH] optionrom: fix bugs in signrom.sh

2010-11-21 Thread Anthony Liguori
On 11/16/2010 08:33 AM, Avi Kivity wrote: signrom.sh has multiple bugs: - the last byte is considered when calculating the existing checksum, but not when computing the correction - apprently the 'expr' expression overflows and produces incorrect results with larger roms - if the checksum

Re: [Qemu-devel] [PATCH v3 0/2] Type-safe ioport callbacks

2010-11-21 Thread Anthony Liguori
On 11/17/2010 03:50 AM, Avi Kivity wrote: A not-so-recent qemu -> qemu-kvm merge broke cpu hotplug without the compiler complaining because of the type-unsafeness of the ioport callbacks. This patchset adds a type-safe variant of ioport callbacks and coverts a sample ioport. Converting the oth

Re: [Qemu-devel] [PATCH v2] pc: disable the BOCHS BIOS panic port

2010-11-21 Thread Anthony Liguori
On 11/16/2010 06:28 AM, Bernhard Kohl wrote: We have an OS which writes to port 0x400 when probing for special hardware. This causes an exit of the VM. With SeaBIOS this port isn't used anyway. Signed-off-by: Bernhard Kohl Applied. Thanks. Regards, Anthony Liguori --- Changes v1 -> v

Re: [Qemu-devel] [PATCH] trace: Trace vm_start()/vm_stop()

2010-11-21 Thread Anthony Liguori
On 11/16/2010 06:20 AM, Stefan Hajnoczi wrote: VM state change notifications are invoked from vm_start()/vm_stop(). Trace these state changes so we can reason about the state of the VM from trace output. Signed-off-by: Stefan Hajnoczi Applied. Thanks. Regards, Anthony Liguori --- tr

Re: [Qemu-devel] [PATCH 0/4] virtio: Convert fprintf() to error_report()

2010-11-21 Thread Anthony Liguori
On 11/15/2010 02:44 PM, Stefan Hajnoczi wrote: The virtio hardware emulation code uses fprintf(stderr, ...) error messages. Improve things slightly by moving to error_report() so error messages will be printed to the monitor, if present. We want to handle device error states properly instead of

Re: [Qemu-devel] [PATCH] trace: Use fprintf_function (format checking)

2010-11-21 Thread Anthony Liguori
On 11/15/2010 02:17 PM, Stefan Weil wrote: fprintf_function adds format checking with GCC_FMT_ATTR. Cc: Blue Swirl Signed-off-by: Stefan Weil Applied. Thanks. Regards, Anthony Liguori --- simpletrace.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/si

Re: [Qemu-devel] [PATCH] slirp: Remove unused code for bad sprintf

2010-11-21 Thread Anthony Liguori
On 11/15/2010 02:15 PM, Stefan Weil wrote: Neither DECLARE_SPRINTF nor BAD_SPRINTF are needed for QEMU. QEMU won't support systems with missing or bad declarations for sprintf. The unused code was detected while looking for functions with missing format checking. Instead of adding GCC_FMT_ATTR,

Re: [Qemu-devel] [PATCH v3] virtio-9p: fix build on !CONFIG_UTIMENSAT

2010-11-21 Thread Anthony Liguori
On 11/14/2010 08:15 PM, Hidetoshi Seto wrote: This patch introduce a fallback mechanism for old systems that do not support utimensat(). This fix build failure with following warnings: hw/virtio-9p-local.c: In function 'local_utimensat': hw/virtio-9p-local.c:479: warning: implicit declaration o

Re: [Qemu-devel] [patch 0/3] block migration fixes

2010-11-21 Thread Anthony Liguori
On 11/08/2010 01:02 PM, Marcelo Tosatti wrote: Following patchset fixes block migration corruption issues Applied all. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] Makefile: Fix check dependency breakage

2010-11-21 Thread Anthony Liguori
On 11/12/2010 08:55 AM, Luiz Capitulino wrote: Commit b152aa84d52882bb1846485a89baf13aa07c86bc broke the unit-tests build, fix it. Signed-off-by: Luiz Capitulino Applied. Thanks. Regards, Anthony Liguori --- Makefile | 14 -- 1 files changed, 8 insertions(+), 6 deleti

[Qemu-devel] [PATCH vgabios] Add 1280x768 mode

2010-11-21 Thread Avi Kivity
Signed-off-by: Avi Kivity --- vbetables-gen.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/vbetables-gen.c b/vbetables-gen.c index 550935a..76b8842 100644 --- a/vbetables-gen.c +++ b/vbetables-gen.c @@ -55,6 +55,9 @@ ModeInfo modes[] = { { 1152, 864, 16

[Qemu-devel] Re: [PATCH vgabios] Add 1280x768 mode

2010-11-21 Thread Avi Kivity
On 11/21/2010 05:33 PM, Avi Kivity wrote: Signed-off-by: Avi Kivity --- vbetables-gen.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/vbetables-gen.c b/vbetables-gen.c index 550935a..76b8842 100644 --- a/vbetables-gen.c +++ b/vbetables-gen.c @@ -55,6 +55,9 @@ ModeI

[Qemu-devel] Re: Oudated vgabios.git on git.qemu.org

2010-11-21 Thread Avi Kivity
On 11/21/2010 04:36 PM, Anthony Liguori wrote: On 11/21/2010 04:23 AM, Avi Kivity wrote: qemu.git points to vgabios.git 19ea12c230ded95928ecaef0db47a82231c2e485, which isn't available on git.qemu.org/vgabios.git. As I mentioned in another mail, I had to switch the repo from mirror to push mo

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

2010-11-21 Thread Gleb Natapov
On Sun, Nov 21, 2010 at 04:48:44PM +0200, Michael S. Tsirkin wrote: > On Sun, Nov 21, 2010 at 02:50:14PM +0200, Gleb Natapov wrote: > > On Sun, Nov 21, 2010 at 01:53:26PM +0200, Michael S. Tsirkin wrote: > > > > > The guests. > > > > Which one? There are many guests. Your favorite? > > > > > > > >

[Qemu-devel] [PATCH] ide: convert bmdma address ioport to ioport_register()

2010-11-21 Thread Avi Kivity
cmd646, via compile tested, pci lightly boot tested. Signed-off-by: Avi Kivity --- hw/ide/cmd646.c |8 + hw/ide/internal.h |2 + hw/ide/pci.c | 71 +--- hw/ide/pci.h |7 + hw/ide/piix.c |8 + hw/ide/via

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

2010-11-21 Thread Michael S. Tsirkin
On Sun, Nov 21, 2010 at 06:01:11PM +0200, Gleb Natapov wrote: > On Sun, Nov 21, 2010 at 04:48:44PM +0200, Michael S. Tsirkin wrote: > > On Sun, Nov 21, 2010 at 02:50:14PM +0200, Gleb Natapov wrote: > > > On Sun, Nov 21, 2010 at 01:53:26PM +0200, Michael S. Tsirkin wrote: > > > > > > The guests. > >

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

2010-11-21 Thread Gleb Natapov
On Sun, Nov 21, 2010 at 06:38:31PM +0200, Michael S. Tsirkin wrote: > On Sun, Nov 21, 2010 at 06:01:11PM +0200, Gleb Natapov wrote: > > On Sun, Nov 21, 2010 at 04:48:44PM +0200, Michael S. Tsirkin wrote: > > > On Sun, Nov 21, 2010 at 02:50:14PM +0200, Gleb Natapov wrote: > > > > On Sun, Nov 21, 201

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

2010-11-21 Thread Michael S. Tsirkin
On Sun, Nov 21, 2010 at 06:01:11PM +0200, Gleb Natapov wrote: > > This FW is given to guest by qemu. It only assigns bus numbers > > because qemu told it to do so. > Seabios is just a guest qemu ships. There are other FW for qemu. We don't support them though, do we? > Bochs > bios, openfirmware,

[Qemu-devel] [PATCHv3 RFC] qemu-kvm: stop devices on vmstop

2010-11-21 Thread Michael S. Tsirkin
Stop running devices on vmstop, so that VM does not interact with outside world at that time. Whitelist system handlers which run even when VM is stopped. These are specific handlers like monitor, gdbstub, migration. I'm not really sure about ui: spice and vnc: do they need to run? Untested. Sig

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

2010-11-21 Thread Gleb Natapov
On Sun, Nov 21, 2010 at 08:22:03PM +0200, Michael S. Tsirkin wrote: > On Sun, Nov 21, 2010 at 06:01:11PM +0200, Gleb Natapov wrote: > > > This FW is given to guest by qemu. It only assigns bus numbers > > > because qemu told it to do so. > > Seabios is just a guest qemu ships. There are other FW fo

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

2010-11-21 Thread Michael S. Tsirkin
On Sun, Nov 21, 2010 at 09:29:59PM +0200, Gleb Natapov wrote: > > We can control the bus numbers that the BIOS will assign to pci root. > And if you need to insert device that sits behind pci-to-pci bridge? Do > you want to control that bus address too? And bus number do not unambiguously > describ

[Qemu-devel] [PATCH 1/1] iscsi: add iSCSI block device support

2010-11-21 Thread ronnie sahlberg
List, Please find attached a gzipped patch against master that adds support of iSCSI. It is sent in gz format because of its uncompressed size, >100kb. This patch adds support for attaching directorly to iSCSI resources, both DISK/SBC and CDROM/MMC, without the need to make the devices visible t

Re: [Qemu-devel] [PATCH 1/1] iscsi: add iSCSI block device support

2010-11-21 Thread FUJITA Tomonori
On Mon, 22 Nov 2010 09:17:50 +1100 ronnie sahlberg wrote: > This patch adds support for attaching directorly to iSCSI resources, > both DISK/SBC and CDROM/MMC, without the need to make the devices > visible to the host. This adds the iscsi initiator feature to qemu (as you did to dbench), right?

Re: [Qemu-devel] [PATCH 1/1] iscsi: add iSCSI block device support

2010-11-21 Thread ronnie sahlberg
On Mon, Nov 22, 2010 at 10:13 AM, FUJITA Tomonori wrote: > On Mon, 22 Nov 2010 09:17:50 +1100 > ronnie sahlberg wrote: > >> This patch adds support for attaching directorly to iSCSI resources, >> both DISK/SBC and CDROM/MMC, without the need to make the devices >> visible to the host. > > This ad

[Qemu-devel] [Bug 678363] [NEW] Swapping caps lock and control causes qemu confusion

2010-11-21 Thread Ralph Loader
Public bug reported: Running Fedora14 [host], I have caps-lock and control swapped over in my keyboard preferences. Qemu doesn't cope very well with this; running an OS inside Qemu (again fedora, suspect that it doesn't matter): The physical caps-lock key [which the host uses as control] toggles

Re: [Qemu-devel] [PATCH] stop the iteration when too many pages is transferred

2010-11-21 Thread Wen Congyang
At 2010年11月20日 10:23, Anthony Liguori Write: > On 11/17/2010 08:32 PM, Wen Congyang wrote: >> When the total sent page size is larger than max_factor >> times of the size of guest OS's memory, stop the >> iteration. >> The default value of max_factor is 3. >> >> This is similar to XEN. >> >> >> Sig

[Qemu-devel] snapshots structure

2010-11-21 Thread chandra shekar
Hi, everyone i have applied a patch and copied the snapshot out of the qcow2 image file and i tried to open it with many editors but it does not open is there any way that we can analyse the snapshot file or any source which explains snapshot file,thanks

[Qemu-devel] Weird Issue with IDE

2010-11-21 Thread Adhyas Avasthi
I am doing something specific and slightly different than normal uses. Would appreciate if someone can help me with a pointer as to what I can do next. I am kinda stuck at this point. My experiment is trying to move the PIIX4 chipset (which currently resides on dev 1, func 0/1/2/3/) to dev 2 (same

[Qemu-devel] Re: [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM

2010-11-21 Thread Michael S. Tsirkin
On Tue, Oct 19, 2010 at 11:08:21PM +0200, Stefan Weil wrote: > PCI devices with different vendor or device ids sometimes share > the same rom code. Only the ids and the checksum > differs in a boot rom for such devices. > > The i825xx ethernet controller family is a typical example > which is impl

Re: [Qemu-devel] [PATCH v3] virtio-9p: fix build on !CONFIG_UTIMENSAT

2010-11-21 Thread Jes Sorensen
On 11/21/10 16:22, Anthony Liguori wrote: > On 11/14/2010 08:15 PM, Hidetoshi Seto wrote: >> This patch introduce a fallback mechanism for old systems that do not >> support utimensat(). This fix build failure with following warnings: >> >> hw/virtio-9p-local.c: In function 'local_utimensat': >> h

Re: [Qemu-devel] [PATCH] stop the iteration when too many pages is transferred

2010-11-21 Thread KAMEZAWA Hiroyuki
On Fri, 19 Nov 2010 20:23:55 -0600 Anthony Liguori wrote: > On 11/17/2010 08:32 PM, Wen Congyang wrote: > > When the total sent page size is larger than max_factor > > times of the size of guest OS's memory, stop the > > iteration. > > The default value of max_factor is 3. > > > > This is similar

Re: [Qemu-devel] [PATCH 12/16] scsi-generic: use plain ioctl

2010-11-21 Thread Hannes Reinecke
On 11/20/2010 02:25 AM, adq wrote: > On 20 November 2010 00:41, Nicholas A. Bellinger wrote: >> On Fri, 2010-11-19 at 19:39 +0100, Christoph Hellwig wrote: >>> On Thu, Nov 18, 2010 at 03:47:36PM +0100, Hannes Reinecke wrote: aio_ioctl is emulated anyway and currently broken. >>> >>> What

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

2010-11-21 Thread Gleb Natapov
On Sun, Nov 21, 2010 at 10:39:31PM +0200, Michael S. Tsirkin wrote: > On Sun, Nov 21, 2010 at 09:29:59PM +0200, Gleb Natapov wrote: > > > We can control the bus numbers that the BIOS will assign to pci root. > > And if you need to insert device that sits behind pci-to-pci bridge? Do > > you want to

[Qemu-devel] Re: [PATCH v2 0/6] qdev reset refactoring and pci bus reset

2010-11-21 Thread Michael S. Tsirkin
On Fri, Nov 19, 2010 at 06:55:57PM +0900, Isaku Yamahata wrote: > Here is v2. I updated the comments, and dropped the pci qdev reset patch. > > Patch description: > The goal of this patch series is to implement secondary bus reset > emulation in pci-to-pci bridge. > At first, this patch series ref