At 2010年11月20日 10:23, Anthony Liguori Write: > On 11/17/2010 08:32 PM, Wen Congyang wrote: >> When the total sent page size is larger than max_factor >> times of the size of guest OS's memory, stop the >> iteration. >> The default value of max_factor is 3. >> >> This is similar to XEN. >> >> >> Signed-off-by: Wen Congyang >> > > I'm strongly opposed to doing this. I think Xen gets this totally wrong. > > Migration is a contract. When you set the stop time, you're saying that > you want only want the guest to experience a fixed amount of downtime. > Stopping the guest after some arbitrary number of iterations makes the > downtime non-deterministic. With a very large guest, this could wreak > havoc causing dropped networking connections, etc. >
Thanks for your comment. As a developer, I know the downtime. But as a user, he does not know the downtime. When he migrates a very large guest lively without setting the stop time, he does not say "I want the guest to experience a fixed amount of downtime", he only wants to migrate the guest in a short time, the migration should be done during some minutes, not ever for ever. If we set the stop time too larger, this could also wreak havoc causing dropped networking connections, etc. I think we can do it as the following: 1. If the user does not set the stop time, we should complete the migration in a short time. 2. If the user sets the stop time, we do it as now. > It's totally unsafe. > > If a management tool wants this behavior, they can set a timeout and > explicitly stop the guest during the live migration. IMHO, such a > management tool is not doing it's job properly but it still can be > implemented. > > Regards, > > Anthony Liguori >
