[Qemu-devel] Re: [PATCH] vhost-net: Do not set features for backend when peer was deleted

2010-10-27 Thread Jason Wang
Michael S. Tsirkin writes: > On Wed, Oct 27, 2010 at 12:43:51AM +0800, Jason Wang wrote: > > When hot-unplug a virtio nic with vhost-net backend, guest may > > continue to program the nic even if its peer have been deleted. We can > > not set features at this time as vhost_net_ack_features() ma

Re: [Qemu-devel] [PATCH v2] Add a DTrace tracing backend targetted for SystemTAP compatability

2010-10-27 Thread Prerna Saxena
ACK, works well! A suggestion though.. On 10/20/2010 07:39 PM, Daniel P. Berrange wrote: eg, instead of probe process("qemu").mark("qemu_malloc") { printf("Malloc %d %p\n", $arg1, $arg2); } The addition of qemu.stp to /usr/share/systemtap/tapset/ lets users write probe qemu.qem

Re: [Qemu-devel] Which qemu ports actually work?

2010-10-27 Thread Alexander Graf
On 27.10.2010, at 01:39, Torbjorn Granlund wrote: >> "install64", which comes a bit longer. It fails in a new way: it >> ignores keyboard input, This happens after the kernel has booted, and >> the installer has started. > > Yes, ignoring keyboard input sounds right. The issue here is that >

Re: [Qemu-devel] [PATCH 0/5] boot order specification

2010-10-27 Thread Gleb Natapov
On Tue, Oct 26, 2010 at 04:14:24PM -0500, Scott Wood wrote: > On Tue, 26 Oct 2010 22:34:51 +0200 > Gleb Natapov wrote: > > > On Tue, Oct 26, 2010 at 07:57:00PM +, Blue Swirl wrote: > > > On Tue, Oct 26, 2010 at 7:35 PM, Gleb Natapov wrote: > > > > But looking elsewhere I found some descripti

Re: [Qemu-devel] Which qemu ports actually work?

2010-10-27 Thread Torbjorn Granlund
> "install64", which comes a bit longer. It fails in a new way: it > ignores keyboard input, This happens after the kernel has booted, and > the installer has started. Yes, ignoring keyboard input sounds right. The issue here is that we're basically emulating a PPC32 machine, but plug

Re: [Qemu-devel] [PATCH v2] Add a DTrace tracing backend targetted for SystemTAP compatability

2010-10-27 Thread Daniel P. Berrange
On Wed, Oct 27, 2010 at 12:26:50PM +0530, Prerna Saxena wrote: > ACK, works well! > A suggestion though.. > > On 10/20/2010 07:39 PM, Daniel P. Berrange wrote: > > > >eg, instead of > > > > probe process("qemu").mark("qemu_malloc") { > > printf("Malloc %d %p\n", $arg1, $arg2); > > } > > >

Re: [Qemu-devel] v6: [PATCH 0/3]: Threadlets: A generic task offloading framework

2010-10-27 Thread Amit Shah
On (Sat) Oct 23 2010 [13:05:48], Stefan Hajnoczi wrote: > >> >You cannot access guest memory using QEMU RAM functions (or use the > >> >virtqueue_pop() function which uses them) from a thread without taking > >> >the QEMU global mutex. > >> > > >> >The abort stack trace is a result of accessing gue

Re: [Qemu-devel] v6: [PATCH 0/3]: Threadlets: A generic task offloading framework

2010-10-27 Thread Stefan Hajnoczi
On Wed, Oct 27, 2010 at 8:57 AM, Amit Shah wrote: > On (Sat) Oct 23 2010 [13:05:48], Stefan Hajnoczi wrote: >> >> >You cannot access guest memory using QEMU RAM functions (or use the >> >> >virtqueue_pop() function which uses them) from a thread without taking >> >> >the QEMU global mutex. >> >> >

Re: [Qemu-devel] [PATCH 2/3] Make paio subsystem use threadlets

2010-10-27 Thread Stefan Hajnoczi
On Tue, Oct 26, 2010 at 3:14 PM, Arun R Bharadwaj wrote: > @@ -536,14 +442,15 @@ static void paio_cancel(BlockDriverAIOCB *blockacb) >     struct qemu_paiocb *acb = (struct qemu_paiocb *)blockacb; >     int active = 0; > > -    mutex_lock(&lock); >     if (!acb->active) { > -        QTAILQ_REMOVE(

[Qemu-devel] Re: [PATCH] QEMU_OPTION_spice is not guarded by ifdef

2010-10-27 Thread Gerd Hoffmann
I did a "make clean" before but I am still getting error about QEMU_OPTION_spice. Log: (...) LINK qemu-io.exe GEN libhw32/qemu-options.def CClibhw32/vl.o C:/msys/home/User/qemu/vl.c: In function `qemu_main': C:/msys/home/User/qemu/vl.c:2601: error: `QEMU_OPTION_spice' undeclared (f

Re: [Qemu-devel] Which qemu ports actually work?

2010-10-27 Thread Torbjorn Granlund
Alexander Graf writes: > Device tree strings 0x0245 -> 0x024504d9 > Device tree struct 0x02451000 -> 0x02453000 > Calling quiesce ... > returning from prom_init > > it hangs. It doesn't hang. It tries to display stuff on the graphical scr

[Qemu-devel] Re: Which qemu ports actually work?

2010-10-27 Thread Paolo Bonzini
On 10/27/2010 11:21 AM, Torbjorn Granlund wrote: You might have different goals than me. Speed is nice, and sometimes critically important. But for my project to get (pseudo) access to lots of more hardware for GNU software testing purposes, speed is not a major issue. Stability, robustness, r

Re: [Qemu-devel] [PATCH 1/2] Type-safe ioport callbacks

2010-10-27 Thread Avi Kivity
On 10/26/2010 08:33 PM, Blue Swirl wrote: > > Why two types? I think some devices use PIO on a PC and MMIO on other > architectures. Sharing the type would allow sharing code. Then there are the functions provided by rwhandler.c. I think that interface makes even more sense compared to 8/16

[al...@redhat.com: [Qemu-devel] [PATCH 0/2] add optional root to info qtree]

2010-10-27 Thread Alon Levy
bump. Doesn't anyone find it useful to view only a part of the whole qtree? Is there some easy way to do this with current qemu monitor? - Forwarded message from Alon Levy - Date: Thu, 21 Oct 2010 08:37:18 +0200 From: Alon Levy To: qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH 0/2]

Re: [Qemu-devel] Which qemu ports actually work?

2010-10-27 Thread Alexander Graf
On 27.10.2010, at 02:21, Torbjorn Granlund wrote: > Alexander Graf writes: > >> Device tree strings 0x0245 -> 0x024504d9 >> Device tree struct 0x02451000 -> 0x02453000 >> Calling quiesce ... >> returning from prom_init >> >> it hangs. > > It doesn't hang.

Re: [Qemu-devel] Which qemu ports actually work?

2010-10-27 Thread Torbjorn Granlund
Alexander Graf writes: Sounds great :). Please keep in mind that if you're running into these issues, others might too. And if you find something out and miss documentation, please create some. That's why we made everything be a wiki these days :). If I get a meaningful number of OS/qemu

[Qemu-devel] [PATCH 0/6] pcie: fixes for pci branch

2010-10-27 Thread Isaku Yamahata
This patch series fixes isseus which introduced by 5704608988972359473ce609f9e4884808115b58 cd870502e228f8f028f93fb585ae3b208fcb46c7 4b78560503a802eae3663ace9f9cf080319e7265 Isaku Yamahata (6): pcie: fix pcie_cap_slot_write_config(). pcie/slot: fix hotplug_event_notify(). pcie/slot: clean up

[Qemu-devel] [PATCH 1/6] pcie: fix pcie_cap_slot_write_config().

2010-10-27 Thread Isaku Yamahata
This patch fixes pcie_cap_slot_write_config() which is broken by 5704608988972359473ce609f9e4884808115b58 The command completion event should generated only when the command is issued (and the command is completed). >From 6.7.3.2 > Software issues a command to a hot-plug capable Downstream Port by

[Qemu-devel] [PATCH 3/6] pcie/slot: clean up of hotplug_event_notify().

2010-10-27 Thread Isaku Yamahata
remove redundant return and blank line from hotplug_event_notify(). Signed-off-by: Isaku Yamahata --- hw/pcie.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/pcie.c b/hw/pcie.c index 3c52849..37d7457 100644 --- a/hw/pcie.c +++ b/hw/pcie.c @@ -164,9 +164,7 @@ static

[Qemu-devel] [PATCH 2/6] pcie/slot: fix hotplug_event_notify().

2010-10-27 Thread Isaku Yamahata
This patch fixes the miscondition to trigger slot event which is introduced by cd870502e228f8f028f93fb585ae3b208fcb46c7. Signed-off-by: Isaku Yamahata --- hw/pcie.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pcie.c b/hw/pcie.c index 64cc003..3c52849 100644 --- a

[Qemu-devel] [PATCH 4/6] pcie/slot: factor out the logic to update hotplug event status.

2010-10-27 Thread Isaku Yamahata
This patch factors out the hot plug event logic. Signed-off-by: Isaku Yamahata --- hw/pcie.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/pcie.c b/hw/pcie.c index 37d7457..97d17fa 100644 --- a/hw/pcie.c +++ b/hw/pcie.c @@ -139,9 +139,8 @@ void pcie_cap_dev

[Qemu-devel] [PATCH 5/6] pcie/slot: fix save/load

2010-10-27 Thread Isaku Yamahata
This patch fixes save/load of pcie slot which was broken by cd870502e228f8f028f93fb585ae3b208fcb46c7. Signed-off-by: Isaku Yamahata --- hw/ioh3420.c|1 + hw/pcie.c |7 +++ hw/pcie.h |1 + hw/xio3130_downstream.c |1 + 4 files changed, 1

[Qemu-devel] [PATCH 6/6] msix: remove range checks.

2010-10-27 Thread Isaku Yamahata
Same as 4b78560503a802eae3663ace9f9cf080319e7265 > config write handlers should be idempotent. > So no need for range checks. Signed-off-by: Isaku Yamahata --- hw/msix.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/hw/msix.c b/hw/msix.c index f66d255..20caa5e 1006

[Qemu-devel] [PATCH 1/3] ide: Handle immediate bdrv_aio_flush failure

2010-10-27 Thread Kevin Wolf
If bdrv_aio_flush returns NULL, this should be treated as an error. Signed-off-by: Kevin Wolf --- hw/ide/core.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index bc3e916..484e0ca 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c

[Qemu-devel] [PATCH 3/3] scsi-disk: Fix immediate failure of bdrv_aio_*

2010-10-27 Thread Kevin Wolf
Fix scsi-disk to use the usual completion paths that involve rerror/werror handling instead of directly completing the requests in cases where bdrv_aio_readv/writev returns NULL. Signed-off-by: Kevin Wolf --- hw/scsi-disk.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) di

[Qemu-devel] [PATCH 2/3] virtio-blk: Handle immediate flush failure properly

2010-10-27 Thread Kevin Wolf
Fix virtio-blk to use the usual completion path that involves werror handling instead of directly completing the request in cases where bdrv_aio_flush returns NULL. Signed-off-by: Kevin Wolf --- hw/virtio-blk.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/virtio-b

[Qemu-devel] [PATCH 0/3] Consider werror/rerror on immediate bdrv_aio_* failure

2010-10-27 Thread Kevin Wolf
There are still paths where werror/rerror is ignored and an error is directly communicated to the guest. This series fixes some of them. Kevin Wolf (3): ide: Handle immediate bdrv_aio_flush failure virtio-blk: Handle immediate flush failure properly scsi-disk: Fix immediate failure of bdrv_a

Re: [Qemu-devel] Re: [PATCH] vhost-net: Do not set features for backend when peer was deleted

2010-10-27 Thread Michael S. Tsirkin
On Wed, Oct 27, 2010 at 02:59:16PM +0800, Jason Wang wrote: > Michael S. Tsirkin writes: > > On Wed, Oct 27, 2010 at 12:43:51AM +0800, Jason Wang wrote: > > > When hot-unplug a virtio nic with vhost-net backend, guest may > > > continue to program the nic even if its peer have been deleted. We c

Re: [Qemu-devel] Re: [PATCH v6 07/12] pcie/hotplug: introduce pushing attention button command

2010-10-27 Thread Michael S. Tsirkin
On Wed, Oct 27, 2010 at 10:47:11AM +0900, Isaku Yamahata wrote: > On Mon, Oct 25, 2010 at 04:02:36PM +0900, Isaku Yamahata wrote: > > > > > What I am also saying is that the same command should be able > > > > > to work for pci and express I think. > > > > > > > > I see. Then, I think that the slo

[Qemu-devel] [PATCH] pci: improve w1c mask handling

2010-10-27 Thread Michael S. Tsirkin
- save/restore must not check w1c bits since they are in fact guest controlled - clear w1c bits on reset Note: for express there are different kinds of reset, some leave part of config space alone. We will likely need a sticky bit mask to implement this. Signed-off-by: Michael S. Tsirkin ---

[Qemu-devel] [PATCH] msi: minor cleanups

2010-10-27 Thread Michael S. Tsirkin
Comment fixup (tell what it does not what it does not do), typo fix, whitespace fix. Signed-off-by: Michael S. Tsirkin --- hw/msi.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/msi.c b/hw/msi.c index 016e7a4..f03f519 100644 --- a/hw/msi.c +++ b/hw/msi.c @@ -1

[Qemu-devel] [PATCH] msi: simplify range checks

2010-10-27 Thread Michael S. Tsirkin
config write handlers should be idempotent. So no need for complex range checks: a simple one checking that we are touching the relevant capability will do. Signed-off-by: Michael S. Tsirkin --- How does the below look? hw/msi.c | 46 +- 1 files ch

[Qemu-devel] Re: [PATCH 6/6] msix: remove range checks.

2010-10-27 Thread Michael S. Tsirkin
On Wed, Oct 27, 2010 at 07:21:21PM +0900, Isaku Yamahata wrote: > Same as 4b78560503a802eae3663ace9f9cf080319e7265 > > config write handlers should be idempotent. > > So no need for range checks. > > Signed-off-by: Isaku Yamahata Well I changed my mind on 4b78560503a802eae3663ace9f9cf080319e7265

Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport

2010-10-27 Thread Ian Molton
On 19/10/10 11:39, Avi Kivity wrote: On 10/19/2010 12:31 PM, Ian Molton wrote: 2. should start with a patch to the virtio-pci spec to document what you're doing Where can I find that spec? http://ozlabs.org/~rusty/virtio-spec/ Ok, but I'm not patching that until theres been some review.

[Qemu-devel] Re: [SeaBIOS] [PATCH] mark irq9 active high in DSDT

2010-10-27 Thread Avi Kivity
On 10/25/2010 12:52 PM, Avi Kivity wrote: I'm okay with making tags and branches of seabios for bug fixes. So far qemu/kvm has just grabbed various builds of seabios - is it worthwhile to branch off of the seabios-0.6.1 version - which would mean qemu/kvm would pull in additional changes beyond

[Qemu-devel] [Bug 655120] Re: VirtFS EFAULT when accessing not existing files

2010-10-27 Thread James Morse
Reproducible here with guest kernel 2.6.36 built for i686 and qemu-kvm built from a fresh git clone taken on 27/10/2010. Host kernel is 2.6.30.10105.2.23.fc11.i686.PAE Guest 9p filesystem mounted as both 9p2000.u and 9p2000.L with the same problem. In the guest syscall 'stat' on a non-existent pa

[Qemu-devel] bonito: PCI_STATUS questions

2010-10-27 Thread Michael S. Tsirkin
I see code in bonito.c that clears bits: PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_REC_TARGET_ABORT on each read and write. However 1. I don't see anything in code that would set these bits 2. The PCI spec says this about the status register: Reads to this register behave normally. Writes

[Qemu-devel] Re: [PATCH 0/6] pcie: fixes for pci branch

2010-10-27 Thread Michael S. Tsirkin
On Wed, Oct 27, 2010 at 07:21:15PM +0900, Isaku Yamahata wrote: > This patch series fixes isseus which introduced by > 5704608988972359473ce609f9e4884808115b58 > cd870502e228f8f028f93fb585ae3b208fcb46c7 > 4b78560503a802eae3663ace9f9cf080319e7265 OK, I applied this, except I basically backed out ra

[Qemu-devel] Re: [PULL-stable] virtio, vhost, migration

2010-10-27 Thread Michael S. Tsirkin
On Tue, Oct 26, 2010 at 05:22:55PM +0200, Michael S. Tsirkin wrote: > > The following changes since commit 6ed912999d6ef636a5be5ccb266d7d3c0f0310b4: > > Update for 0.13.0 release (2010-10-14 10:00:59 -0500) > > are available in the git repository at: > git://git.kernel.org/pub/scm/linux/kern

Re: [Qemu-devel] [PATCH 0/6] The windows 7 audio support patch series.

2010-10-27 Thread malc
On Wed, 27 Oct 2010, Gerd Hoffmann wrote: > Hi, > > This patch series brings a bunch of pulseaudio tweaks and two new sound > devices. Number one is the slightly improved usb-audio patch which was > originally created by hpa. Number two is a virtual HD Audio controller > with HDA codecs. >

Re: [Qemu-devel] [PATCH 0/6] The windows 7 audio support patch series.

2010-10-27 Thread malc
On Wed, 27 Oct 2010, malc wrote: > On Wed, 27 Oct 2010, Gerd Hoffmann wrote: > > > Hi, > > > > This patch series brings a bunch of pulseaudio tweaks and two new sound > > devices. Number one is the slightly improved usb-audio patch which was > > originally created by hpa. Number two is a vir

[Qemu-devel] [PATCH] block: fix the use of protocols in backing files

2010-10-27 Thread Anthony Liguori
Signed-off-by: Anthony Liguori diff --git a/block.c b/block.c index 1a965b2..00b6f21 100644 --- a/block.c +++ b/block.c @@ -603,10 +603,16 @@ int bdrv_open(BlockDriverState *bs, const char *filename, int flags, BlockDriver *back_drv = NULL; bs->backing_hd = bdrv_new(""); -

Re: [Qemu-devel] [RFC 0/2]: QMP: Human Monitor passthrough

2010-10-27 Thread Anthony Liguori
On 10/25/2010 03:06 PM, Luiz Capitulino wrote: This is my first try on implementing HMP passthrough via QMP. I've tried to follow Anthony's advice on creating a buffered char device. If this approach is good (and the implementation is not faulty), I believe this is very near a mergeble state (al

Re: [Qemu-devel] [PATCH] block: fix the use of protocols in backing files

2010-10-27 Thread malc
On Wed, 27 Oct 2010, Anthony Liguori wrote: > Signed-off-by: Anthony Liguori > > diff --git a/block.c b/block.c > index 1a965b2..00b6f21 100644 > --- a/block.c > +++ b/block.c > @@ -603,10 +603,16 @@ int bdrv_open(BlockDriverState *bs, const char > *filename, int flags, > BlockDriver *

Re: [Qemu-devel] [PATCH] block: fix the use of protocols in backing files

2010-10-27 Thread Anthony Liguori
On 10/27/2010 02:22 PM, malc wrote: On Wed, 27 Oct 2010, Anthony Liguori wrote: Signed-off-by: Anthony Liguori diff --git a/block.c b/block.c index 1a965b2..00b6f21 100644 --- a/block.c +++ b/block.c @@ -603,10 +603,16 @@ int bdrv_open(BlockDriverState *bs, const char *filename, int flags

[Qemu-devel] AIX emulated on x86 host

2010-10-27 Thread glen . c . bodie
I have an old AIX machine (IBM RS/6000 running AIX v5.x) and it's about to fall apart. I would like to migrate that machine's functions onto one of my VMware hosts, all of which are DELL 2950 servers (x86 architecture). I know VMware only runs x86 architecture guests. So I am planning a Windows

[Qemu-devel] [PATCH] block: fix the use of protocols in backing files (v2)

2010-10-27 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- v1 -> v2 - Fix up CODING_STYLE of modified code diff --git a/block.c b/block.c index 1a965b2..029017e 100644 --- a/block.c +++ b/block.c @@ -603,10 +603,17 @@ int bdrv_open(BlockDriverState *bs, const char *filename, int flags, BlockDriver *back_drv =

Re: [Qemu-devel] About QEMU debugging console

2010-10-27 Thread Blue Swirl
On Wed, Oct 27, 2010 at 1:10 AM, Zhiyuan Shao wrote: > On Tue, 2010-10-26 at 18:59 +, Blue Swirl wrote: >> On Tue, Oct 26, 2010 at 12:22 PM, Zhiyuan Shao wrote: >> > Hi team, >> > >> > I am a Qemu User, and using Qemu 0.13.0 to debugging the linux kernel >> > code (Qemu+GDB). >> > >> > During

Re: [Qemu-devel] guest physical address equal host virtual address ?

2010-10-27 Thread Blue Swirl
On Wed, Oct 27, 2010 at 6:14 AM, wrote: > >>As I remember it, it's on the lines of: > >>tlb_entry = env->tlb_table[mem_index][hash(guest_virtual_address)]; >>if (tlb_entry. == guest_virtual_address) { >>   host_virtual_address = tlb_entry.addend >>} else { >>  call the slow path through __ld rout

[Qemu-devel] AIX emulated on x86 host

2010-10-27 Thread glen . c . bodie
Sorry - first message had non-plain text by mistake. Trying again ... I have an old AIX machine (IBM RS/6000 running AIX v5.x) and it's about to fall apart. I would like to migrate that machine's functions onto one of my VMware hosts, all of which are DELL 2950 servers (x86 architecture). I kno

Re: [Qemu-devel] [PATCH 1/2] Type-safe ioport callbacks

2010-10-27 Thread Blue Swirl
On Wed, Oct 27, 2010 at 9:26 AM, Avi Kivity wrote: >  On 10/26/2010 08:33 PM, Blue Swirl wrote: >> >> > >> >  Why two types?  I think some devices use PIO on a PC and MMIO on other >> >  architectures.  Sharing the type would allow sharing code. >> >> Then there are the functions provided by rwhan

Re: [Qemu-devel] Which qemu ports actually work?

2010-10-27 Thread Blue Swirl
On Wed, Oct 27, 2010 at 8:39 AM, Torbjorn Granlund wrote: >  > "install64", which comes a bit longer.  It fails in a new way: it >  > ignores keyboard input, This happens after the kernel has booted, and >  > the installer has started. > >  Yes, ignoring keyboard input sounds right. The issue here

[Qemu-devel] Chandra has invited you to join MySpace

2010-10-27 Thread Myspace
Title: Chandra has invited you to join MySpace       Hello. Chandra has invited you to join MySpace.After accepting, you will be automatically connected with Chandra and have access to premium content, new friends and a huge music and video library. See you on MySpace!

Re: [Qemu-devel] Which qemu ports actually work?

2010-10-27 Thread Torbjorn Granlund
Blue Swirl writes: On Wed, Oct 27, 2010 at 8:39 AM, Torbjorn Granlund wrote: >  > "install64", which comes a bit longer.  It fails in a new way: it >  > ignores keyboard input, This happens after the kernel has booted, and >  > the installer has started. > >  Yes, ignoring keyboard i

[Qemu-devel] Re: bonito: PCI_STATUS questions

2010-10-27 Thread chen huacai
Because the code in PMON and Linux kernel use these bits to verify r/w operations. If one of them is 1 after r/w, PMON and Linux will consider r/w has failed. I guess that software will not set them to 1, because it is set by hardware when operation fails. On Thu, Oct 28, 2010 at 12:12 AM, Michael

[Qemu-devel] Re: [PATCH] msi: minor cleanups

2010-10-27 Thread Isaku Yamahata
Looks good. On Wed, Oct 27, 2010 at 04:30:03PM +0200, Michael S. Tsirkin wrote: > Comment fixup (tell what it does not what it does not do), > typo fix, whitespace fix. > > Signed-off-by: Michael S. Tsirkin > --- > hw/msi.c |7 +++ > 1 files changed, 3 insertions(+), 4 deletions(-) > >

[Qemu-devel] Re: [PATCH] pci: improve w1c mask handling

2010-10-27 Thread Isaku Yamahata
On Wed, Oct 27, 2010 at 04:05:58PM +0200, Michael S. Tsirkin wrote: > - save/restore must not check w1c bits > since they are in fact guest controlled > - clear w1c bits on reset > > Note: for express there are different kinds of > reset, some leave part of config space alone. > We will likely n

Re: [Qemu-devel] About QEMU debugging console

2010-10-27 Thread Zhiyuan Shao
On Wed, 2010-10-27 at 20:07 +, Blue Swirl wrote: > On Wed, Oct 27, 2010 at 1:10 AM, Zhiyuan Shao wrote: > > On Tue, 2010-10-26 at 18:59 +, Blue Swirl wrote: > >> On Tue, Oct 26, 2010 at 12:22 PM, Zhiyuan Shao wrote: > >> > Hi team, > >> > > >> > I am a Qemu User, and using Qemu 0.13.0 to

[Qemu-devel] Re: [PATCH 0/6] pcie: fixes for pci branch

2010-10-27 Thread Isaku Yamahata
On Wed, Oct 27, 2010 at 06:40:48PM +0200, Michael S. Tsirkin wrote: > On Wed, Oct 27, 2010 at 07:21:15PM +0900, Isaku Yamahata wrote: > > This patch series fixes isseus which introduced by > > 5704608988972359473ce609f9e4884808115b58 > > cd870502e228f8f028f93fb585ae3b208fcb46c7 > > 4b78560503a802ea

[Qemu-devel] Re: bonito: PCI_STATUS questions

2010-10-27 Thread Michael S. Tsirkin
On Thu, Oct 28, 2010 at 08:57:01AM +0800, chen huacai wrote: > Because the code in PMON and Linux kernel use these bits to verify r/w > operations. If one of them is 1 after r/w, PMON and Linux will > consider r/w has failed. Where's that code in Linux? > I guess that software will not set them t

[Qemu-devel] Re: [PATCH] pci: improve w1c mask handling

2010-10-27 Thread Michael S. Tsirkin
On Thu, Oct 28, 2010 at 11:02:48AM +0900, Isaku Yamahata wrote: > On Wed, Oct 27, 2010 at 04:05:58PM +0200, Michael S. Tsirkin wrote: > > - save/restore must not check w1c bits > > since they are in fact guest controlled > > - clear w1c bits on reset > > > > Note: for express there are different

[Qemu-devel] [PATCH v2 0/2] pciinit: fix overflow when bar allocation

2010-10-27 Thread Isaku Yamahata
Okay, now added comments to members and functions as requested. No essential code change. Changes v1 -> v2: - add comment. Patch description: This patch set fixes PCI bar allocation when bar overflow occured. I checked if pmm_alloc facility can be used, but it doesn't suit for pci bar allocation.

[Qemu-devel] [PATCH v2 2/2] pciinit: use pci_region functions.

2010-10-27 Thread Isaku Yamahata
This patch cleans up pci region allocation with pci_region. Now it is aware of overflow. Signed-off-by: Isaku Yamahata --- src/pciinit.c | 122 - 1 files changed, 60 insertions(+), 62 deletions(-) diff --git a/src/pciinit.c b/src/pciinit.

[Qemu-devel] [PATCH v2 1/2] pci: introduce pci_region to manage pci io/memory/prefmemory regions.

2010-10-27 Thread Isaku Yamahata
This patch adds helper functions to manage pci area. Signed-off-by: Isaku Yamahata --- Changes v1 -> v2 - add comments --- Makefile |3 +- src/pci_region.c | 77 ++ src/util.h | 28 +++ 3 files changed, 10

[Qemu-devel] Re: [PATCH v2 1/2] pci: introduce pci_region to manage pci io/memory/prefmemory regions.

2010-10-27 Thread Michael S. Tsirkin
On Thu, Oct 28, 2010 at 02:04:05PM +0900, Isaku Yamahata wrote: > This patch adds helper functions to manage pci area. > > Signed-off-by: Isaku Yamahata > > --- > Changes v1 -> v2 > - add comments > --- > Makefile |3 +- > src/pci_region.c | 77 > +

[Qemu-devel] [PULL] virtio, vhost, migration, pci, net

2010-10-27 Thread Michael S. Tsirkin
OK this is try 2, with bad vhost patch dropped, but I also tacked on pcie support and some other fixes. The following changes since commit 758c309f0a5cb52441a1ee015566cf9cd96fa933: seabios: Update to 0.6.1 (2010-10-25 16:43:41 -0500) are available in the git repository at: git://git.kernel.o

[Qemu-devel] aminata

2010-10-27 Thread aminata
Cher Monsieur C'est avec plaisir que je m'adresse à ma lettre, je suis HAJI Barry Aminata l'épouse de feu le général de la Guinée. Mon mari a été assassiné pour des raisons politiques en Guinée. Et avant sa mort, il avait gagné et un contrat avec le gouvernement d'une très grande quantité d'arg

[Qemu-devel] Re: [PATCH v2 1/2] pci: introduce pci_region to manage pci io/memory/prefmemory regions.

2010-10-27 Thread Isaku Yamahata
On Thu, Oct 28, 2010 at 07:56:41AM +0200, Michael S. Tsirkin wrote: > > diff --git a/src/util.h b/src/util.h > > index 5cc9f17..17eedd0 100644 > > --- a/src/util.h > > +++ b/src/util.h > > @@ -344,6 +344,34 @@ void qemu_prep_reset(void); > > void smm_save_and_copy(void); > > void smm_relocate_and

[Qemu-devel] Re: [PATCH v2 2/2] pciinit: use pci_region functions.

2010-10-27 Thread Michael S. Tsirkin
As a sepaate note, BIOS currently seems to allocate regions in-order, correct? A classical trick is to allocate regions behind each bridge in the reverse order of their size. This avoids holes due to alignment. -- MST