Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM

2010-10-19 Thread Michael S. Tsirkin
On Mon, Oct 18, 2010 at 09:11:55PM +0200, Stefan Weil wrote: > QEMU must only make sure that patching of the supported roms > with supported devices work. I think that's what Anthony was saying too - make this depend on a qdev property and set it only in eepro100 for now. -- MST

[Qemu-devel] [PATCH v5 04/14] pci/bridge: fix pci_bridge_reset()

2010-10-19 Thread Isaku Yamahata
The default value of base/limit registers aren't specified in the spec. So pci_bridge_reset() shouldn't touch them. Instead, introduced two functions to reset those registers in a way of typical implementation. zero base/limit registers or disable forwarding. They will be used later. Signed-off-by

[Qemu-devel] [PATCH v5 13/14] pcie/hotplug: introduce pushing attention button command

2010-10-19 Thread Isaku Yamahata
glue pcie_push_attention_button command. Signed-off-by: Isaku Yamahata --- hw/pcie_port.c | 82 +++ qemu-monitor.hx | 14 + sysemu.h|4 +++ 3 files changed, 100 insertions(+), 0 deletions(-) diff --git a/hw/pcie_port.c

[Qemu-devel] [PATCH v5 02/14] pci: introduce helper function to handle msi-x and msi.

2010-10-19 Thread Isaku Yamahata
this patch implements helper functions to handle msi-x and msi uniformly. They will be used later. Signed-off-by: Isaku Yamahata --- hw/pci.c | 19 +++ hw/pci.h |3 +++ 2 files changed, 22 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index e3462a9..300079

[Qemu-devel] [PATCH v5 14/14] pcie/aer: glue aer error injection into qemu monitor

2010-10-19 Thread Isaku Yamahata
introduce pcie_aer_inject_error command. Signed-off-by: Isaku Yamahata --- Changes v3 -> v4: - s/PCIE_AER/PCIEAER/g for structure names. - compilation adjustment. Changes v2 -> v3: - compilation adjustment. --- hw/pcie_aer.c | 84 +++ qemu

[Qemu-devel] [PATCH v5 01/14] pci: introduce helper functions to test-and-{clear, set} mask in configuration space

2010-10-19 Thread Isaku Yamahata
This patch introduces helper functions to test-and-{clear, set} mask in configuration space. pci_{byte, word, long, quad}_test_and_{clear, set}_mask(). They will be used later. Signed-off-by: Isaku Yamahata --- hw/pci.h | 70 ++ 1 fi

[Qemu-devel] [PATCH v5 03/14] pci: use pci_word_test_and_clear_mask() in pci_device_reset()

2010-10-19 Thread Isaku Yamahata
use pci_clear_bit_word() in pci_device_reset() where appropriate. Signed-off-by: Isaku Yamahata --- Changes v4 -> v5 - use pci_word_test_and_clear_mask() --- hw/pci.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 300079f..409e2c0 100644 --

[Qemu-devel] [PATCH v5 00/14] pcie port switch emulators

2010-10-19 Thread Isaku Yamahata
Here is v5 of the pcie patch series. I hope I addressed the blockers. On uncorrectable error status register in pcie_aer_write_config(). The register is RW1CS, so making it writable and test-and-clear doesn't work. new patches: 1, 2, updasted patches except trivial change: 4, 7, 8 BTW, as 0.13 i

[Qemu-devel] Re: [Tracing][v4 PATCH 1/2] Introduce QMP interfaces

2010-10-19 Thread Stefan Hajnoczi
On Tue, Oct 19, 2010 at 11:55:50AM +0530, Prerna Saxena wrote: > [PATCH 1/2] Introduce QMP interfaces : > - query-trace > - query-trace-events > - query-trace-file > > > Signed-off-by: Prerna Saxena > --- > monitor.c | 53 --- > simpletrace.c |

[Qemu-devel] [PATCH v5 11/14] x3130: pcie upstream port

2010-10-19 Thread Isaku Yamahata
Implement TI x3130 pcie upstream port switch. Signed-off-by: Isaku Yamahata --- Changes v4 -> v5: - remove flr related stuff. This will be addressed at the next phase. - use pci_xxx_test_and_xxx_mask(). Chnages v3 -> v4: - rename pcie_upstream -> x3130_upstream. - compilation adjustment. Chan

[Qemu-devel] [PATCH v5 08/14] pcie/aer: helper functions for pcie aer capability

2010-10-19 Thread Isaku Yamahata
This patch implements helper functions for pcie aer capability which will be used later. Signed-off-by: Isaku Yamahata --- Changes v4 -> v5: - use pci_xxx_test_and_xxx_mask() - rewrote PCIDevice::written bits. - eliminated pcie_aer_notify() - introduced PCIExpressDevice::aer_intx Changes v3 -> v

[Qemu-devel] [PATCH v5 06/14] pcie: add pcie constants to pcie_regs.h

2010-10-19 Thread Isaku Yamahata
add pcie constants to pcie_regs.h. Those constants should go to Linux pci_regs.h and then the file should go away eventually. Signed-off-by: Isaku Yamahata --- Changes v3 -> v4: - removed copyright notice as requested. Changes v2 -> v3: - moved out pcie constants from pcie.c to pcie_regs.h. - re

[Qemu-devel] Re: [Tracing][v4 PATCH 2/2] Add documentation for QMP interfaces

2010-10-19 Thread Stefan Hajnoczi
On Tue, Oct 19, 2010 at 11:57:50AM +0530, Prerna Saxena wrote: > [PATCH 2/2] Add documentation for QMP commands: > - query-trace > - query-trace-events > - query-trace-file. > > > Signed-off-by: Prerna Saxena > --- > qmp-commands.hx | 94 > +

[Qemu-devel] [PATCH v5 07/14] pcie: helper functions for pcie capability and extended capability

2010-10-19 Thread Isaku Yamahata
This patch implements helper functions for pci express capability and pci express extended capability allocation. NOTE: presence detection depends on pci_qdev_init() change. Signed-off-by: Isaku Yamahata --- Changes v4 -> v5: - dropped FLR related members. This will be addressed at the next phase

[Qemu-devel] [PATCH v5 05/14] msi: implements msi

2010-10-19 Thread Isaku Yamahata
implements msi related functions. Signed-off-by: Isaku Yamahata --- Changes v4 -> v5: - use pci_xxx_test_and_clear/set_mask(). Changes v3 -> v4: - use pci_set_bit_xxx helper function. - make nr_vectors, vector unsigned int. - introduce PCI_MSI_VECTORS_MAX. - fix undefined bit operations. - elim

[Qemu-devel] [PATCH v5 12/14] x3130: pcie downstream port

2010-10-19 Thread Isaku Yamahata
Implement TI x3130 pcie downstream port switch. Signed-off-by: Isaku Yamahata --- Changes v4 -> v5: - use pci_xxx_test_and_xxx_mask(). - removed flr related stuff. Changes v3 -> v4: - rename: pcie_downstream -> x3130_downstream - compilation adjustment. Changes v2 -> v3: - compilation adjustmen

[Qemu-devel] [PATCH v5 09/14] pcie port: define struct PCIEPort/PCIESlot and helper functions

2010-10-19 Thread Isaku Yamahata
define struct PCIEPort which represents common part of pci express port.(root, upstream and downstream.) add a helper function for pcie port which can be used commonly by root/upstream/downstream port. define struct PCIESlot which represents common part of pcie slot.(root and downstream.) and helpe

[Qemu-devel] [PATCH v5 10/14] ioh3420: pcie root port in X58 ioh

2010-10-19 Thread Isaku Yamahata
Implements pcie root port switch in intel X58 ioh whose device id is 0x3420. Signed-off-by: Isaku Yamahata --- Changes v4 -> v5: - use pci_xxx_test_and_xxx_mask() Changes v3 -> v4: - rename pcie_root -> ioh3420 - compilation adjustment. Changes v2 -> v3: - compilation adjustment. --- Makefile.

Re: Testing of russian keymap (was Re: [Qemu-devel] [PATCH] fix '/' and '|' on russian keymap)

2010-10-19 Thread Daniel P. Berrange
On Mon, Oct 18, 2010 at 01:59:15PM -0500, Anthony Liguori wrote: > On 10/18/2010 12:30 PM, Oleg Sadov wrote: > >I don't understand reasons for such locale-default keyboard settings for > >qemu too, but may be it's useful for someone... > > > > -k only exists to deal with crappy VNC clients. >

[Qemu-devel] qemu aborts if i add a already registered device from qemu monitor ..

2010-10-19 Thread pradeep
Hi I tried to add a device to guest from upstream qemu monitor using "device_add". Unknowingly i try to add already registered devices from qemu monitor, my qemu monitor is aborted. I don't see a reason to kill monitor. I think abort() is a bit rough. we need a better way to handle it. If a user

Re: [Qemu-devel] [PATCH] Add a DTrace tracing backend targetted for SystemTAP compatability

2010-10-19 Thread Stefan Hajnoczi
On Mon, Oct 18, 2010 at 3:04 PM, Daniel P. Berrange wrote: > This introduces a new tracing backend that targets the SystemTAP > implementation of DTrace userspace tracing. The core functionality > should be applicable and standard across any DTrace implementation > on Solaris, OS-X, *BSD, but the

Re: [Qemu-devel] [PATCH 1/2] Add drive_get_by_id

2010-10-19 Thread Stefan Hajnoczi
On Mon, Oct 18, 2010 at 11:17 PM, Ryan Harper wrote: > Add a function to find a drive by id string. > > Signed-off-by: Ryan Harper > --- >  blockdev.c |   12 >  blockdev.h |    1 + >  2 files changed, 13 insertions(+), 0 deletions(-) > > diff --git a/blockdev.c b/blockdev.c > index f

[Qemu-devel] [PATCH 1/3] qdev: make qdev_find_recursive public

2010-10-19 Thread Alon Levy
--- hw/qdev.c |2 +- hw/qdev.h |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 35858cb..d669a9d 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -477,7 +477,7 @@ static BusState *qbus_find_recursive(BusState *bus, const char *name, return NUL

[Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v2)

2010-10-19 Thread Alon Levy
This patchset uses id like device_del for attaching/detaching usb devices. The first two patches ready the way: 1. makes qdev_find_recursive non static and in qdev.h 2. adds a usb_device_by_id which goes over the usb buses calling qdev_find_recursive 3. adds the commands that use usb_device_by

[Qemu-devel] [PATCH 2/3] usb: add public usb_device_by_id

2010-10-19 Thread Alon Levy
--- hw/usb-bus.c | 16 hw/usb.h |1 + 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index b692503..d732bd3 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -189,6 +189,22 @@ int usb_device_detach(USBDevice *dev) return 0;

[Qemu-devel] [PATCH 3/3] monitor: add usb_attach and usb_detach

2010-10-19 Thread Alon Levy
--- hmp-commands.hx | 34 ++ sysemu.h|2 ++ vl.c| 31 +++ 3 files changed, 67 insertions(+), 0 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 81999aa..660205c 100644 --- a/hmp-commands.hx ++

[Qemu-devel] [PATCH 10/10] Add savevm/loadvm support for MCE

2010-10-19 Thread Marcelo Tosatti
Port qemu-kvm's commit 1bab5d11545d8de5facf46c28630085a2f9651ae Author: Huang Ying Date: Wed Mar 3 16:52:46 2010 +0800 Add savevm/loadvm support for MCE MCE registers are saved/load into/from CPUState in kvm_arch_save/load_regs. To simulate the MCG_STATUS clearing upon reset,

[Qemu-devel] [PATCH 09/10] MCE: Relay UCR MCE to guest

2010-10-19 Thread Marcelo Tosatti
Port qemu-kvm's commit 4b62fff1101a7ad77553147717a8bd3bf79df7ef Author: Huang Ying Date: Mon Sep 21 10:43:25 2009 +0800 MCE: Relay UCR MCE to guest UCR (uncorrected recovery) MCE is supported in recent Intel CPUs, where some hardware error such as some memory error can be reported

[Qemu-devel] Re: [PATCH] Implement a virtio GPU transport

2010-10-19 Thread Ian Molton
On 10/10/10 16:11, Avi Kivity wrote: On 10/06/2010 05:59 PM, Ian Molton wrote: This patch implements a virtio-based transport for use by a virtualised OpenGL passthrough implementation. The libGL and qemu-gl code to support this patch are available here: http://gitorious.org/vm-gl-accel/qemu-g

Re: [Qemu-devel] [PATCH][block] qcow2: Support exact L1 table growth

2010-10-19 Thread Kevin Wolf
Am 18.10.2010 17:53, schrieb Stefan Hajnoczi: > The L1 table grow operation includes a size calculation that bumps up > the new L1 table size in order to anticipate the size needs of vmstate > data. This helps reduce the number of times that the L1 table has to be > grown when vmstate data is appe

[Qemu-devel] [PATCH 05/10] Expose thread_id in info cpus

2010-10-19 Thread Marcelo Tosatti
commit ce6325ff1af34dbaee91c8d28e792277e43f1227 Author: Glauber Costa Date: Wed Mar 5 17:01:10 2008 -0300 Augment info cpus This patch exposes the thread id associated with each cpu through the already well known 'info cpus' interface. Signed-off-by: Marcelo Tosatti Signed-off-by

[Qemu-devel] [PATCH 04/10] iothread: use signalfd

2010-10-19 Thread Marcelo Tosatti
Block SIGALRM, SIGIO and consume them via signalfd. Signed-off-by: Marcelo Tosatti Signed-off-by: Avi Kivity --- cpus.c | 74 +++ 1 files changed, 69 insertions(+), 5 deletions(-) diff --git a/cpus.c b/cpus.c index b09f5e3..3875657

[Qemu-devel] [PATCH 00/10] [PULL] qemu-kvm.git uq/master queue

2010-10-19 Thread Marcelo Tosatti
The following changes since commit 38cc9b607f85017b095793cab6c129bc9844f441: issue snd_pcm_start() when capturing audio (2010-10-18 00:39:06 +0400) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master Huang Ying (1): Add RAM -> physical a

[Qemu-devel] Re: [PATCH] Implement a virtio GPU transport

2010-10-19 Thread Avi Kivity
On 10/19/2010 12:31 PM, Ian Molton wrote: an virtualization@, many virtio developers live there. you mean virtualizat...@lists.osdl.org ? Yes. 2. should start with a patch to the virtio-pci spec to document what you're doing Where can I find that spec? http://ozlabs.org/~rusty/virt

[Qemu-devel] [PATCH 02/10] Add svm cpuid features

2010-10-19 Thread Marcelo Tosatti
From: Joerg Roedel This patch adds the svm cpuid feature flags to the qemu intialization path. It also adds the svm features available on phenom to its cpu-definition and extends the host cpu type to support all svm features KVM can provide. Signed-off-by: Joerg Roedel Signed-off-by: Avi Kivity

[Qemu-devel] [PATCH 06/10] kvm: x86: add mce support

2010-10-19 Thread Marcelo Tosatti
Port qemu-kvm's MCE support commit c68b2374c9048812f488e00ffb95db66c0bc07a7 Author: Huang Ying Date: Mon Jul 20 10:00:53 2009 +0800 Add MCE simulation support to qemu/kvm KVM ioctls are used to initialize MCE simulation and inject MCE. The real MCE simulation is implemented in Lin

Re: [Qemu-devel] [PATCH 2/2] Fix Block Hotplug race with drive_unplug()

2010-10-19 Thread Stefan Hajnoczi
On Mon, Oct 18, 2010 at 11:17 PM, Ryan Harper wrote: > Block hot unplug is racy since the guest is required to acknowlege the ACPI > unplug event; this may not happen synchronously with the device removal > command > > This series aims to close a gap where by mgmt applications that assume the > b

[Qemu-devel] [PATCH 07/10] Export qemu_ram_addr_from_host

2010-10-19 Thread Marcelo Tosatti
To be used by next patches. Signed-off-by: Marcelo Tosatti Signed-off-by: Avi Kivity --- cpu-common.h |3 ++- exec-all.h |2 +- exec.c | 26 +- 3 files changed, 20 insertions(+), 11 deletions(-) diff --git a/cpu-common.h b/cpu-common.h index 0426bc8..a

[Qemu-devel] [PATCH 08/10] Add RAM -> physical addr mapping in MCE simulation

2010-10-19 Thread Marcelo Tosatti
From: Huang Ying In QEMU-KVM, physical address != RAM address. While MCE simulation needs physical address instead of RAM address. So kvm_physical_memory_addr_from_ram() is implemented to do the conversion, and it is invoked before being filled in the IA32_MCi_ADDR MSR. Reported-by: Dean Nelson

[Qemu-devel] [PATCH 01/10] Set cpuid definition to 0 before initializing it

2010-10-19 Thread Marcelo Tosatti
From: Joerg Roedel This patch cleans the (stack-allocated) cpuid definition to 0 before actually initializing it. Signed-off-by: Joerg Roedel Signed-off-by: Avi Kivity --- target-i386/cpuid.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/target-i386/cpuid.c b/targe

[Qemu-devel] [PATCH 03/10] signalfd compatibility

2010-10-19 Thread Marcelo Tosatti
Port qemu-kvm's signalfd compat code. commit 5a7fdd0abd7cd24dac205317a4195446ab8748b5 Author: Anthony Liguori Date: Wed May 7 11:55:47 2008 -0500 Use signalfd() in io-thread This patch reworks the IO thread to use signalfd() instead of sigtimedwait() This will eliminate the need t

[Qemu-devel] Re: [PATCH v5 00/14] pcie port switch emulators

2010-10-19 Thread Michael S. Tsirkin
On Tue, Oct 19, 2010 at 06:06:27PM +0900, Isaku Yamahata wrote: > On uncorrectable error status register in pcie_aer_write_config(). > The register is RW1CS, so making it writable and test-and-clear doesn't > work. Sure. But isn't this what w1cmask implements? Also - mail to ad...@khaleel.us seem

[Qemu-devel] Re: [PATCH v5 07/14] pcie: helper functions for pcie capability and extended capability

2010-10-19 Thread Michael S. Tsirkin
On Tue, Oct 19, 2010 at 06:06:34PM +0900, Isaku Yamahata wrote: > This patch implements helper functions for pci express capability > and pci express extended capability allocation. > NOTE: presence detection depends on pci_qdev_init() change. > > Signed-off-by: Isaku Yamahata > --- > Changes v4

[Qemu-devel] Re: [PATCH v5 00/14] pcie port switch emulators

2010-10-19 Thread Michael S. Tsirkin
On Tue, Oct 19, 2010 at 06:06:27PM +0900, Isaku Yamahata wrote: > Here is v5 of the pcie patch series. > I hope I addressed the blockers. > On uncorrectable error status register in pcie_aer_write_config(). > The register is RW1CS, so making it writable and test-and-clear doesn't > work. > > new p

Re: [Qemu-devel] qemu aborts if i add a already registered device from qemu monitor ..

2010-10-19 Thread Luiz Capitulino
On Tue, 19 Oct 2010 15:27:37 +0530 pradeep wrote: > Hi > > I tried to add a device to guest from upstream qemu monitor using > "device_add". Are you developing a new device or does it happen with existing ones? If it's the latter, can you describe steps to reproduce it? > Unknowingly i try to

[Qemu-devel] Re: [PATCH v5 04/14] pci/bridge: fix pci_bridge_reset()

2010-10-19 Thread Michael S. Tsirkin
On Tue, Oct 19, 2010 at 06:06:31PM +0900, Isaku Yamahata wrote: > The default value of base/limit registers aren't specified in the spec. > So pci_bridge_reset() shouldn't touch them. > Instead, introduced two functions to reset those registers in a way > of typical implementation. zero base/limit

Re: [Qemu-devel] [Tracing][v4 PATCH 2/2] Add documentation for QMP interfaces

2010-10-19 Thread Prerna Saxena
On 10/19/2010 11:57 AM, Prerna Saxena wrote: [PATCH 2/2] Add documentation for QMP commands: - query-trace - query-trace-events - query-trace-file. I've been trying ways to avoid building this documentation for other trace backends ( since these commands are only available with the 's

Re: [Qemu-devel] Re: KVM call agenda for Oct 19

2010-10-19 Thread Dor Laor
On 10/19/2010 04:11 AM, Chris Wright wrote: * Juan Quintela (quint...@redhat.com) wrote: Please send in any agenda items you are interested in covering. - 0.13.X -stable handoff - 0.14 planning - threadlet work - virtfs proposals - Live snapshots - We were asked to add this feature for e

[Qemu-devel] [PATCH 0/1] ccid emulated card (v2, for usb-ccid v3)

2010-10-19 Thread Alon Levy
v2 changes: fixed a bug that made certificates emulation not work, and some cleanup. v1 message: Meant to be applied after the usb-ccid v3 patch on the list. Causes --enable-smartcard to depend on libcac_card, library for emulating CAC compliant smart cards at http://cgit.freedesktop.org/~alon/c

[Qemu-devel] [PATCH 1/1] add ccid-card-emulated device (v2)

2010-10-19 Thread Alon Levy
changes from v1: remove stale comments, use only c-style comments bugfix, forgot to set recv_len change reader name to 'Virtual Reader' Signed-off-by: Alon Levy --- Makefile.objs |2 +- configure | 20 ++ hw/ccid-card-emulated.c | 495 ++

Re: [Qemu-devel] Re: KVM call agenda for Oct 19

2010-10-19 Thread Avi Kivity
On 10/19/2010 02:48 PM, Dor Laor wrote: On 10/19/2010 04:11 AM, Chris Wright wrote: * Juan Quintela (quint...@redhat.com) wrote: Please send in any agenda items you are interested in covering. - 0.13.X -stable handoff - 0.14 planning - threadlet work - virtfs proposals - Live snapshots

Re: [Qemu-devel] Re: KVM call agenda for Oct 19

2010-10-19 Thread Dor Laor
On 10/19/2010 02:55 PM, Avi Kivity wrote: On 10/19/2010 02:48 PM, Dor Laor wrote: On 10/19/2010 04:11 AM, Chris Wright wrote: * Juan Quintela (quint...@redhat.com) wrote: Please send in any agenda items you are interested in covering. - 0.13.X -stable handoff - 0.14 planning - threadlet wor

Re: [Qemu-devel] Re: KVM call agenda for Oct 19

2010-10-19 Thread Anthony Liguori
On 10/19/2010 08:03 AM, Avi Kivity wrote: On 10/19/2010 02:58 PM, Dor Laor wrote: On 10/19/2010 02:55 PM, Avi Kivity wrote: On 10/19/2010 02:48 PM, Dor Laor wrote: On 10/19/2010 04:11 AM, Chris Wright wrote: * Juan Quintela (quint...@redhat.com) wrote: Please send in any agenda items you a

Re: [Qemu-devel] [PATCH 2/3] usb: add public usb_device_by_id

2010-10-19 Thread Alon Levy
- "Gerd Hoffmann" wrote: > > +USBDevice *usb_device_by_id(const char* id) > > +{ > > +USBBus *bus; > > +DeviceState *qdev; > > +USBDevice *dev; > > + > > +QTAILQ_FOREACH(bus,&busses, next) { > > +qdev = qdev_find_recursive(&bus->qbus, id); > > +if (qdev != NUL

[Qemu-devel] Re: [PATCH] virtio: Use ioeventfd for virtqueue notify

2010-10-19 Thread Anthony Liguori
On 10/19/2010 08:07 AM, Stefan Hajnoczi wrote: Is there anything stopping this patch from being merged? Michael, any objections? If not, I'll merge it. Regards, Anthony Liguori Thanks, Stefan

Re: [Qemu-devel] [PATCH 2/3] usb: add public usb_device_by_id

2010-10-19 Thread Gerd Hoffmann
+USBDevice *usb_device_by_id(const char* id) +{ +USBBus *bus; +DeviceState *qdev; +USBDevice *dev; + +QTAILQ_FOREACH(bus,&busses, next) { +qdev = qdev_find_recursive(&bus->qbus, id); +if (qdev != NULL) { +dev = DO_UPCAST(USBDevice, qdev, qdev); +

[Qemu-devel] Static tracepoint control via trace-event

2010-10-19 Thread Jan Kiszka
Hi Stefan, just had a closer look at qemu's new tracing framework. Looks cool, though it leaves a bit room for improvements. ;) One quirk I stumbled over quickly was the "disable" tag in trace-events. It confused me first as qemu starts without any tracepoint enabled by default and I thought I ha

Re: [Qemu-devel] Re: KVM call agenda for Oct 19

2010-10-19 Thread Avi Kivity
On 10/19/2010 03:22 PM, Anthony Liguori wrote: I had assumed that this would involve: qemu -hda windows.img (qemu) snapshot ide0-disk0 snap0.img 1) create snap0.img internally by doing the equivalent of `qemu-img create -f qcow2 -b windows.img snap0.img' 2) bdrv_flush('ide0-disk0') 3) bdrv

Re: [Qemu-devel] Re: KVM call agenda for Oct 19

2010-10-19 Thread Anthony Liguori
On 10/19/2010 07:48 AM, Dor Laor wrote: On 10/19/2010 04:11 AM, Chris Wright wrote: * Juan Quintela (quint...@redhat.com) wrote: Please send in any agenda items you are interested in covering. - 0.13.X -stable handoff - 0.14 planning - threadlet work - virtfs proposals - Live snapshots

[Qemu-devel] Re: [PATCH] virtio: Use ioeventfd for virtqueue notify

2010-10-19 Thread Stefan Hajnoczi
On Thu, Sep 30, 2010 at 03:01:52PM +0100, Stefan Hajnoczi wrote: > Virtqueue notify is currently handled synchronously in userspace virtio. > This prevents the vcpu from executing guest code while hardware > emulation code handles the notify. > > On systems that support KVM, the ioeventfd mechanis

[Qemu-devel] Re: [PATCH v5 00/14] pcie port switch emulators

2010-10-19 Thread Michael S. Tsirkin
On Tue, Oct 19, 2010 at 06:06:27PM +0900, Isaku Yamahata wrote: > Here is v5 of the pcie patch series. > I hope I addressed the blockers. > On uncorrectable error status register in pcie_aer_write_config(). > The register is RW1CS, so making it writable and test-and-clear doesn't > work. > > new p

Re: [Qemu-devel] Static tracepoint control via trace-event

2010-10-19 Thread Daniel P. Berrange
On Tue, Oct 19, 2010 at 03:08:08PM +0200, Jan Kiszka wrote: > Hi Stefan, > > just had a closer look at qemu's new tracing framework. Looks cool, > though it leaves a bit room for improvements. ;) > > One quirk I stumbled over quickly was the "disable" tag in trace-events. > It confused me first a

Re: [Qemu-devel] Re: KVM call agenda for Oct 19

2010-10-19 Thread Stefan Hajnoczi
On Tue, Oct 19, 2010 at 2:33 PM, Anthony Liguori wrote: > On 10/19/2010 08:27 AM, Avi Kivity wrote: >> >>  On 10/19/2010 03:22 PM, Anthony Liguori wrote: >>> >>> I had assumed that this would involve: >>> >>> qemu -hda windows.img >>> >>> (qemu) snapshot ide0-disk0 snap0.img >>> >>> 1) create snap

Re: [Qemu-devel] [PATCH 00/10] [PULL] qemu-kvm.git uq/master queue

2010-10-19 Thread Anthony Liguori
’ from incompatible pointer type /home/anthony/git/qemu/kvm.h:180: note: expected ‘target_phys_addr_t *’ but argument is of type ‘long unsigned int *’ make[1]: *** [kvm.o] Error 1 make: *** [subdir-i386-softmmu] Error 2 I've pushed my tree to http://repo.or.cz/w/qemu/aliguori.git qemu-kvm-201

[Qemu-devel] Re: [PATCH] virtio: Use ioeventfd for virtqueue notify

2010-10-19 Thread Michael S. Tsirkin
On Tue, Oct 19, 2010 at 08:12:42AM -0500, Anthony Liguori wrote: > On 10/19/2010 08:07 AM, Stefan Hajnoczi wrote: > >Is there anything stopping this patch from being merged? > > Michael, any objections? If not, I'll merge it. I don't really understand what's going on there. The extra state in n

[Qemu-devel] Re: [PATCH] virtio: Use ioeventfd for virtqueue notify

2010-10-19 Thread Stefan Hajnoczi
On Tue, Oct 19, 2010 at 2:35 PM, Michael S. Tsirkin wrote: > On Tue, Oct 19, 2010 at 08:12:42AM -0500, Anthony Liguori wrote: >> On 10/19/2010 08:07 AM, Stefan Hajnoczi wrote: >> >Is there anything stopping this patch from being merged? >> >> Michael, any objections?  If not, I'll merge it. > > I

[Qemu-devel] Re: [PATCH] virtio: Use ioeventfd for virtqueue notify

2010-10-19 Thread Michael S. Tsirkin
As a general comment, could you please try to split this patch up, to make it easier to review? I did a pass over it but I am still not understanding it completely. My main concern is with the fact that we add more state in notifiers that can easily get out of sync with users. If we absolutely nee

[Qemu-devel] CFP: 1st International QEMU Users Forum

2010-10-19 Thread Wolfgang Mueller
* Call for Presentations 1st International QEMU Users Forum March 18th, 2011, Grenoble, France * Deadlines: Extended abstract

Re: [Qemu-devel] Re: KVM call agenda for Oct 19

2010-10-19 Thread Anthony Liguori
On 10/19/2010 07:48 AM, Dor Laor wrote: On 10/19/2010 04:11 AM, Chris Wright wrote: * Juan Quintela (quint...@redhat.com) wrote: Please send in any agenda items you are interested in covering. - 0.13.X -stable handoff - 0.14 planning - threadlet work - virtfs proposals - Live snapshots

Re: [Qemu-devel] [PATCH 3/3] monitor: add usb_attach and usb_detach

2010-10-19 Thread Gerd Hoffmann
Hi, +.help = "attach USB device 'bus.addr'", +...@item usb_attach @var{devname} /me sees a mismatch here. There is still the use case question. Also note that this might have unwanted side effects when drivers automagically attach/detach devices like usb-host. Having t

Re: [Qemu-devel] [PATCH 2/3] usb: add public usb_device_by_id

2010-10-19 Thread Gerd Hoffmann
Hi, There is no problem to loop over all usb devices. But first of all I don't want to loop on used, since then I miss any detached devices, so I actually do want the same behavior of qdev_find_recursive, and since it's already available, why rewrite it in a different compilation unit? Point

Re: [Qemu-devel] Re: KVM call agenda for Oct 19

2010-10-19 Thread Avi Kivity
On 10/19/2010 02:58 PM, Dor Laor wrote: On 10/19/2010 02:55 PM, Avi Kivity wrote: On 10/19/2010 02:48 PM, Dor Laor wrote: On 10/19/2010 04:11 AM, Chris Wright wrote: * Juan Quintela (quint...@redhat.com) wrote: Please send in any agenda items you are interested in covering. - 0.13.X -stab

Re: [Qemu-devel] Re: KVM call agenda for Oct 19

2010-10-19 Thread Anthony Liguori
On 10/19/2010 08:27 AM, Avi Kivity wrote: On 10/19/2010 03:22 PM, Anthony Liguori wrote: I had assumed that this would involve: qemu -hda windows.img (qemu) snapshot ide0-disk0 snap0.img 1) create snap0.img internally by doing the equivalent of `qemu-img create -f qcow2 -b windows.img snap

[Qemu-devel] Re: Static tracepoint control via trace-event

2010-10-19 Thread Stefan Hajnoczi
On Tue, Oct 19, 2010 at 03:08:08PM +0200, Jan Kiszka wrote: > One quirk I stumbled over quickly was the "disable" tag in trace-events. > It confused me first as qemu starts without any tracepoint enabled by > default and I thought I had to hack the file. Then I read the doc and > wondered which exi

[Qemu-devel] Re: Static tracepoint control via trace-event

2010-10-19 Thread Jan Kiszka
Am 19.10.2010 15:30, Stefan Hajnoczi wrote: > On Tue, Oct 19, 2010 at 03:08:08PM +0200, Jan Kiszka wrote: >> One quirk I stumbled over quickly was the "disable" tag in trace-events. >> It confused me first as qemu starts without any tracepoint enabled by >> default and I thought I had to hack the f

[Qemu-devel] Re: [PATCH] virtio: Use ioeventfd for virtqueue notify

2010-10-19 Thread Michael S. Tsirkin
On Tue, Oct 19, 2010 at 02:44:35PM +0100, Stefan Hajnoczi wrote: > On Tue, Oct 19, 2010 at 2:35 PM, Michael S. Tsirkin wrote: > > On Tue, Oct 19, 2010 at 08:12:42AM -0500, Anthony Liguori wrote: > >> On 10/19/2010 08:07 AM, Stefan Hajnoczi wrote: > >> >Is there anything stopping this patch from be

Re: [Qemu-devel] Re: Static tracepoint control via trace-event

2010-10-19 Thread Stefan Hajnoczi
On Tue, Oct 19, 2010 at 2:46 PM, Jan Kiszka wrote: > Am 19.10.2010 15:30, Stefan Hajnoczi wrote: >> On Tue, Oct 19, 2010 at 03:08:08PM +0200, Jan Kiszka wrote: >>> One quirk I stumbled over quickly was the "disable" tag in trace-events. >>> It confused me first as qemu starts without any tracepoin

[Qemu-devel] [PATCH] Fix test suite build with tracing enabled

2010-10-19 Thread Jan Kiszka
qemu_malloc instrumentations require linking against the trace objects. Signed-off-by: Jan Kiszka --- Makefile | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index 252c817..106a401 100644 --- a/Makefile +++ b/Makefile @@ -140,12 +140,12 @@

Re: [Qemu-devel] Static tracepoint control via trace-event

2010-10-19 Thread Stefan Hajnoczi
On Tue, Oct 19, 2010 at 2:36 PM, Daniel P. Berrange wrote: > On Tue, Oct 19, 2010 at 03:08:08PM +0200, Jan Kiszka wrote: >> Hi Stefan, >> >> just had a closer look at qemu's new tracing framework. Looks cool, >> though it leaves a bit room for improvements. ;) >> >> One quirk I stumbled over quick

[Qemu-devel] Re: [PATCH v5 00/14] pcie port switch emulators

2010-10-19 Thread Isaku Yamahata
> > Isaku Yamahata (14): > > pci: introduce helper functions to test-and-{clear, set} mask in > > configuration space > > pci: introduce helper function to handle msi-x and msi. > > pci: use pci_word_test_and_clear_mask() in pci_device_reset() > > pci/bridge: fix pci_bridge_reset() > >

Re: [Qemu-devel] Re: KVM call agenda for Oct 19

2010-10-19 Thread Avi Kivity
On 10/19/2010 03:38 PM, Stefan Hajnoczi wrote: bdrv_aio_freeze() or any mechanism to deal with pending requests in the generic block code would be a good step for future "live" support of other operations like truncate. + logical disk grow, etc. -- error compiling committee.c: too many argume

Re: [Qemu-devel] Re: Static tracepoint control via trace-event

2010-10-19 Thread Daniel P. Berrange
On Tue, Oct 19, 2010 at 03:46:35PM +0200, Jan Kiszka wrote: > Am 19.10.2010 15:30, Stefan Hajnoczi wrote: > > On Tue, Oct 19, 2010 at 03:08:08PM +0200, Jan Kiszka wrote: > >> One quirk I stumbled over quickly was the "disable" tag in trace-events. > >> It confused me first as qemu starts without an

Re: [Qemu-devel] Static tracepoint control via trace-event

2010-10-19 Thread Jan Kiszka
Am 19.10.2010 15:52, Stefan Hajnoczi wrote: > On Tue, Oct 19, 2010 at 2:36 PM, Daniel P. Berrange > wrote: >> On Tue, Oct 19, 2010 at 03:08:08PM +0200, Jan Kiszka wrote: >>> Hi Stefan, >>> >>> just had a closer look at qemu's new tracing framework. Looks cool, >>> though it leaves a bit room for

[Qemu-devel] [PATCH] simpletrace: Inline runtime state check

2010-10-19 Thread Jan Kiszka
Instead of preparing all traced args, jumping into the common trace function, even collecting a timestamp, do the check if a particular tracepoint is enabled inline. Also, mark the enabled case unlikely to motivate the compiler to push the trace code out of the fastpath. Signed-off-by: Jan Kiszka

[Qemu-devel] Re: [PATCH] Fix test suite build with tracing enabled

2010-10-19 Thread Stefan Hajnoczi
On Tue, Oct 19, 2010 at 04:03:15PM +0200, Jan Kiszka wrote: > qemu_malloc instrumentations require linking against the trace objects. > > Signed-off-by: Jan Kiszka > --- > Makefile | 12 ++-- > 1 files changed, 6 insertions(+), 6 deletions(-) Acked-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH 0/7] ATAPI CDROM passthrough v5

2010-10-19 Thread Michal Suchanek
On 19 October 2010 08:17, Alexander Graf wrote: > > Am 19.10.2010 um 02:10 schrieb Anthony Liguori : > >> On 10/18/2010 06:29 PM, Alexander Graf wrote: A user will get a really nasty surprise if they think they can use a flag or rely on QEMU to prevent a VM from doing something nasty wi

Tracing block devices (was: Re: [Qemu-devel] Static tracepoint control via trace-event)

2010-10-19 Thread Richard W.M. Jones
On Tue, Oct 19, 2010 at 03:59:36PM +0200, Jan Kiszka wrote: > Once we have "-trace events=...", defining the list of active > tracepoints before starting qemu will be trivial (e.g. via a config > file). Of course, this requires that all tracepoints are built-in... Sorry that I've not been followin

Re: [Qemu-devel] Re: Static tracepoint control via trace-event

2010-10-19 Thread Jan Kiszka
Am 19.10.2010 16:12, Daniel P. Berrange wrote: > On Tue, Oct 19, 2010 at 03:46:35PM +0200, Jan Kiszka wrote: >> Am 19.10.2010 15:30, Stefan Hajnoczi wrote: >>> On Tue, Oct 19, 2010 at 03:08:08PM +0200, Jan Kiszka wrote: One quirk I stumbled over quickly was the "disable" tag in trace-events. >

[Qemu-devel] [PATCH 1/2] v2 Add drive_get_by_id

2010-10-19 Thread Ryan Harper
Add a function to find a drive by id string. Changes since v1: -Coding Style fix Signed-off-by: Ryan Harper --- blockdev.c | 13 + blockdev.h |1 + 2 files changed, 14 insertions(+), 0 deletions(-) diff --git a/blockdev.c b/blockdev.c index ff7602b..5fc3b9b 100644 --- a/block

[Qemu-devel] Re: Tracing block devices

2010-10-19 Thread Jan Kiszka
Am 19.10.2010 16:29, Richard W.M. Jones wrote: > On Tue, Oct 19, 2010 at 03:59:36PM +0200, Jan Kiszka wrote: >> Once we have "-trace events=...", defining the list of active >> tracepoints before starting qemu will be trivial (e.g. via a config >> file). Of course, this requires that all tracepoint

[Qemu-devel] [PATCH 09/10] MCE: Relay UCR MCE to guest (v2)

2010-10-19 Thread Marcelo Tosatti
Port qemu-kvm's commit 4b62fff1101a7ad77553147717a8bd3bf79df7ef Author: Huang Ying Date: Mon Sep 21 10:43:25 2009 +0800 MCE: Relay UCR MCE to guest UCR (uncorrected recovery) MCE is supported in recent Intel CPUs, where some hardware error such as some memory error can be reporte

[Qemu-devel] [PATCH 0/2] v2 Decouple block device removal from device removal

2010-10-19 Thread Ryan Harper
This patch series decouples the detachment of a block device from the removal of the backing pci-device. Removal of a hotplugged pci device requires the guest to respond before qemu tears down the block device. In some cases, the guest may not respond leaving the guest with continued access to the

Re: Tracing block devices (was: Re: [Qemu-devel] Static tracepoint control via trace-event)

2010-10-19 Thread Stefan Hajnoczi
On Tue, Oct 19, 2010 at 03:29:51PM +0100, Richard W.M. Jones wrote: > On Tue, Oct 19, 2010 at 03:59:36PM +0200, Jan Kiszka wrote: > > Once we have "-trace events=...", defining the list of active > > tracepoints before starting qemu will be trivial (e.g. via a config > > file). Of course, this requ

Re: Testing of russian keymap (was Re: [Qemu-devel] [PATCH] fix '/' and '|' on russian keymap)

2010-10-19 Thread Oleg Sadov
19/10/2010 10:32 +0100, Daniel P. Berrange wrote: > On Mon, Oct 18, 2010 at 01:59:15PM -0500, Anthony Liguori wrote: > > On 10/18/2010 12:30 PM, Oleg Sadov wrote: > > >I don't understand reasons for such locale-default keyboard settings for > > >qemu too, but may be it's useful for someone... > > >

[Qemu-devel] [PATCH 2/2] v2 Fix Block Hotplug race with drive_unplug()

2010-10-19 Thread Ryan Harper
Block hot unplug is racy since the guest is required to acknowlege the ACPI unplug event; this may not happen synchronously with the device removal command This series aims to close a gap where by mgmt applications that assume the block resource has been removed without confirming that the guest h

[Qemu-devel] [PATCH][RESEND] char: Flush read buffer in mux_chr_can_read

2010-10-19 Thread Jan Kiszka
Move the buffer flush from mux_chr_read to mux_chr_can_read. While the latter is called periodically, the former will only be invoked when new characters arrive at the back-end. This caused problems to front-end drivers whenever they were unable to read data immediately, e.g. virtio-console attache

[Qemu-devel] [PATCH][RESEND] pcnet: Do not receive external frames in loopback mode

2010-10-19 Thread Jan Kiszka
While not explicitly stated in the spec, it was observed on real systems that enabling loopback testing on the pcnet controller disables reception of external frames. And some legacy software relies on it, so provide this behavior. Signed-off-by: Jan Kiszka --- hw/pcnet.c |5 +++-- 1 files c

[Qemu-devel] [PATCH 1/2] ide: Factor ide_flush_cache out

2010-10-19 Thread Kevin Wolf
The next patch reuses this code, so put it in its own function. Signed-off-by: Kevin Wolf --- hw/ide/core.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 5ccb09c..6d8606e 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @

[Qemu-devel] [PATCH 0/2] ide: Handle bdrv_aio_flush errors

2010-10-19 Thread Kevin Wolf
Until now, errors returned by bdrv_aio_flush were silently ignored, so that from a guest point of view, FLUSH would never fail even if the data hasn't made it to the host disk. This applies the werror option also to flushes, so that by default errors are reported back to the guest, and qemu can be

[Qemu-devel] [PATCH 2/2] ide: Handle flush failure

2010-10-19 Thread Kevin Wolf
Instead of always assuming success for bdrv_aio_flush, actually do something with the error. This respects the werror option and accordingly ignores the error, reports it to the guest or stops the VM and retries after cont. Ignoring the error is trivial, obviously. For stopping the VM and retrying

  1   2   >