Signed-off-by: Markus Armbruster
---
hw/ide/cmd646.c |4 ++--
hw/ide/core.c | 30 ++
hw/ide/internal.h |5 +++--
hw/ide/isa.c|2 +-
hw/ide/macio.c |2 +-
hw/ide/microdrive.c |3 ++-
hw/ide/mmio.c |2 +-
hw/ide/p
Signed-off-by: Markus Armbruster
---
hw/ide/core.c | 32 +---
1 files changed, 17 insertions(+), 15 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index c3334b1..443ff10 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -2633,27 +2633,29 @@ void ide_init_d
It needs to be a qdev property, because it belongs to the drive's
guest part.
Bonus: info qtree now shows the serial number.
Signed-off-by: Markus Armbruster
---
hw/ide/core.c | 11 ++-
hw/ide/internal.h |4 +++-
hw/ide/qdev.c | 16 +++-
3 files changed, 24 i
Show the actual default value instead of when the property has
not been set.
Signed-off-by: Markus Armbruster
---
hw/ide/qdev.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c
index 5e549d9..6231d77 100644
--- a/hw/ide/qdev.c
+++ b/hw/ide
It needs to be a qdev property, because it belongs to the drive's
guest part.
Bonus: info qtree now shows the serial number.
Signed-off-by: Markus Armbruster
---
hw/scsi-disk.c | 17 +
1 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-dis
Show the actual default value instead of when the property has
not been set.
Signed-off-by: Markus Armbruster
---
hw/scsi-disk.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index e8c066a..a3559d1 100644
--- a/hw/scsi-disk.c
+++
parse_string() qemu_strdup()s the property value. It is never freed.
It needs to be freed along with the device. Otherwise, the value of
scsi-disk property "ver" gets leaked when hot-unplugging the disk, for
instance.
Call new PropertyInfo method free() from qdev_free(). Implement it
for qdev_p
Commit 428c149b added IDEState member conf to let commit 0009baf1 find
the BlockConf from there. It exists only for qdev drives, created via
ide_drive_initfn(), not for drives created via ide_init2().
But for a qdev drive, we can just as well reach its IDEDevice, which
contains the BlockConf. Do
I'm working on cleanly separating block device host and guest parts.
I'd like to route all this work through Kevin's block tree. This is
just preliminaries.
v2: Don't break IDE serial
Markus Armbruster (14):
blockdev: Belatedly remove MAX_DRIVES
blockdev: Belatedly remove driveopts
usb: Re
On 05/12/2010 08:12 AM, Pierre Riteau wrote:
When a page with all identical bytes is transferred, it is counted
as a full page (TARGET_PAGE_SIZE) although only one byte is actually
sent. Fix this by changing ram_save_block() to return the number of
bytes sent instead of a boolean value. This make
Signed-off-by: Markus Armbruster
---
hw/qdev-properties.c |5 +
hw/qdev.h|1 +
2 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 9ffdba7..b6ee50f 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev-properties.c
@@
Unused since commit b3e461d3.
Signed-off-by: Markus Armbruster
---
vl.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/vl.c b/vl.c
index 9283469..76a9b25 100644
--- a/vl.c
+++ b/vl.c
@@ -1315,7 +1315,7 @@ static void smp_parse(const char *optarg)
/
Unused since commit 9dfd7c7a.
Signed-off-by: Markus Armbruster
---
sysemu.h |1 -
vl.c |1 -
2 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/sysemu.h b/sysemu.h
index 063319c..fd83b7d 100644
--- a/sysemu.h
+++ b/sysemu.h
@@ -178,7 +178,6 @@ typedef struct DriveInfo {
Unused since commit 751c6a17.
Signed-off-by: Markus Armbruster
---
sysemu.h |1 -
vl.c |2 --
2 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/sysemu.h b/sysemu.h
index 879446a..063319c 100644
--- a/sysemu.h
+++ b/sysemu.h
@@ -176,7 +176,6 @@ typedef struct DriveInfo {
On 06/01/2010 01:35 PM, Markus Armbruster wrote:
Luiz Capitulino writes:
On Tue, 01 Jun 2010 16:44:24 +0200
Markus Armbruster wrote:
Luiz Capitulino writes:
On Mon, 31 May 2010 16:13:12 +0200
Markus Armbruster wrote:
We need Device IDs to be unique and not
On 05/31/2010 12:43 PM, Luiz Capitulino wrote:
From: Jan Kiszka
Push the doc fragments for the info command to the end of
qemu-monitor.hx. This helps to establish a proper layout in the upcoming
QMP documentation.
Signed-off-by: Jan Kiszka
Applied all. Thanks.
Regards,
Anthony Liguori
The code comes from
http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02788.html
Without this patch it is not possible to send at least 10 special
characters (\|'"`~:;[]{}) via the monitor sendkey command.
Signed-off-by: Bernhard M. Wiedemann
---
monitor.c |6 ++
1 files changed,
On 06/01/2010 02:29 PM, Bernhard M. Wiedemann wrote:
The code comes from
http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02788.html
Without this patch it is not possible to send at least 10 special
characters (\|'"`~:;[]{}) via the monitor sendkey command.
Signed-off-by: Bernhard M. Wie
2010/6/1 Blue Swirl :
> On Sun, May 30, 2010 at 10:35 PM, Artyom Tarasenko
> wrote:
>> lower interrupt during chip reset. Otherwise the ESP_RSTAT register
>> may get out of sync with the IRQ line status. This effect became
>> visible after commit 65899fe3
>
> Hard reset handlers should not touch q
On Tue, Jun 1, 2010 at 7:56 PM, Artyom Tarasenko
wrote:
> 2010/6/1 Blue Swirl :
>> On Sun, May 30, 2010 at 10:35 PM, Artyom Tarasenko
>> wrote:
>>> lower interrupt during chip reset. Otherwise the ESP_RSTAT register
>>> may get out of sync with the IRQ line status. This effect became
>>> visible
From: Igor V. Kovalenko
- set mmu tag access register on FAULT and PROT traps as well
Signed-off-by: Igor V. Kovalenko
---
target-sparc/helper.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/target-sparc/helper.c b/target-sparc/helper.c
index 96a22f3..aa1fd63 100
assorted changes, linux kernel can now work with 32bit init task
---
Igor V. Kovalenko (8):
sparc64: fix tag access register on mmu traps
sparc64: fix missing address masking
sparc64: fix 32bit load sign extension
sparc64: fix ldxfsr insn
sparc64: use symbolic name f
From: Igor V. Kovalenko
- rearrange code to break from switch when appropriate
- allow deprecated ldfsr insn
Signed-off-by: Igor V. Kovalenko
---
target-sparc/translate.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/target-sparc/translate.c b/target-sparc/trans
From: Igor V. Kovalenko
- address masking for ldqf and stqf insns
- address masking for lddf and stdf insns
- address masking for translating ASI (Ultrasparc IIi)
Signed-off-by: Igor V. Kovalenko
---
target-sparc/op_helper.c | 47 ++
target-sparc/t
From: Igor V. Kovalenko
- change return type of ldl_* to uint32_t to prevent unwanted sign extension
visible in sparc64 load alternate address space methods
- note this change makes ldl_* softmmu implementations match ldl_phys one
Signed-off-by: Igor V. Kovalenko
---
softmmu_header.h |2 +
From: Igor V. Kovalenko
- truncate and sign or zero extend operands before multiplication
- factor out common code to gen_op_multiply() with parameter to sign/zero extend
- call gen_op_multiply from gen_op_umul and gen_op_smul
Signed-off-by: Igor V. Kovalenko
---
target-sparc/translate.c | 5
From: Igor V. Kovalenko
- implemented block load/store primary/secondary with user privilege
Signed-off-by: Igor V. Kovalenko
---
target-sparc/op_helper.c | 28
1 files changed, 28 insertions(+), 0 deletions(-)
diff --git a/target-sparc/op_helper.c b/target-spar
2010/6/1 Blue Swirl :
> On Tue, Jun 1, 2010 at 7:56 PM, Artyom Tarasenko
> wrote:
>> 2010/6/1 Blue Swirl :
>>> On Sun, May 30, 2010 at 10:35 PM, Artyom Tarasenko
>>> wrote:
lower interrupt during chip reset. Otherwise the ESP_RSTAT register
may get out of sync with the IRQ line status.
From: Igor V. Kovalenko
Signed-off-by: Igor V. Kovalenko
---
target-sparc/op_helper.c | 28
1 files changed, 16 insertions(+), 12 deletions(-)
diff --git a/target-sparc/op_helper.c b/target-sparc/op_helper.c
index f5e153d..b9af52b 100644
--- a/target-sparc/op_hel
From: Igor V. Kovalenko
- truncate second operand to 32bit
Signed-off-by: Igor V. Kovalenko
---
target-sparc/op_helper.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-sparc/op_helper.c b/target-sparc/op_helper.c
index 83067ae..4c5155f 100644
--- a/target-sp
This patch fluesh the debug messages to the log file at the end of each
debug message.
Signed-off-by: Venkateswararao Jujjuri
---
hw/virtio-9p-debug.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-9p-debug.c b/hw/virtio-9p-debug.c
index 2fb2673..5bfa689 100
Drop ATA_CMD constants and use constants from ide/internal.h.
Signed-off-by: Sebastian Herbszt
diff --git a/hw/ahci.c b/hw/ahci.c
index 9987459..b4eafdf 100644
--- a/hw/ahci.c
+++ b/hw/ahci.c
@@ -153,33 +153,6 @@ do { fprintf(stderr,"ahci: " fmt , ## __VA_ARGS__); }
while (0)
#define STATE_RES
Jes Sorensen wrote:
Handle 0x0401, DMI type 4, 32 bytes
Processor Information
- Socket Designation: CPU 1
+ Socket Designation: CPU01
smbios.c got
snprintf((char*)start, 6, "CPU%2x", cpu_number);
It should print "CPU 1" instead of "CPU01" because the
padding should be done with spa
This patch rearranges the fileop structures by moving the structure definitions
from virtio-9p.c to virtio-9p.h file. No functional changes.
Signed-off-by: Venkateswararao Jujjuri
---
hw/virtio-9p.c | 185 ++--
hw/virtio-9p.h | 92 ++
Hi,
> We currently only clear SVM_EVTINJ_VALID after successful interrupt
> delivery. This apparently does not match real hardware which clears the
> whole event_inj field on every vmexit, including unsuccessful interrupt
> delivery.
Thanks for the patch. It is a bit hard for me to test right no
Signed-off-by: Luiz Capitulino
---
qdict.c | 18 ++
qdict.h |1 +
2 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/qdict.c b/qdict.c
index 175bc17..ca3c3b1 100644
--- a/qdict.c
+++ b/qdict.c
@@ -287,6 +287,24 @@ int64_t qdict_get_try_int(const QDict *qdict, co
Current QMP's client argument checker implementation is more complex than it
should be and has a flaw: it ignores unknown arguments.
This series solves both problems by introducing a new, simple and ultra-poweful
argument checker. This wasn't trivial to get right due to the number of errors
combin
This commit introduces the first half of qmp_check_client_args(),
which is the new client argument checker.
It's introduced on top of the existing code, so that there are
no regressions during the transition.
It works this way: the command's args_type field (from
qemu-monitor.hx) is transformed i
This is similar to qmp_check_client_args(), but checks if
the input object follows the specification (QMP/qmp-spec.txt
section 2.3).
As we're limited to three keys, the work here is quite simple:
we iterate over the input object, each time checking if the
given argument complies to the specificati
Historically, user monitor arguments beginning with '-' (eg. '-f')
were passed as integers down to handlers.
I've maintained this behavior in the new monitor because we didn't
have a boolean type at the very beginning of QMP. Today we have it
and this behavior is causing trouble to the code that c
We couldn't do it before, otherwise we would break the intention
of the previous checker, which was to ensure that opts_list wasn't
a NULL before checking it.
Debug code, pretty minor, still I decided to maintain its original
behavior.
Signed-off-by: Luiz Capitulino
---
monitor.c |2 +-
1 f
Previous commit added qmp_check_input_obj(), it does this
checking for us.
Signed-off-by: Luiz Capitulino
---
monitor.c |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/monitor.c b/monitor.c
index 654b193..f849456 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4347,9 +43
Previous two commits added qmp_check_client_args(), which
fully replaces this code and is way better.
It's important to note that the new checker doesn't support
the '/' arg type. As we don't have any of those handlers
converted to QMP, this is just dead code.
Signed-off-by: Luiz Capitulino
---
Signed-off-by: Luiz Capitulino
---
qerror.c |4
qerror.h |3 +++
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/qerror.c b/qerror.c
index 44d0bf8..b26224e 100644
--- a/qerror.c
+++ b/qerror.c
@@ -177,6 +177,10 @@ static const QErrorStringTable qerror_table[] = {
On 06/01/2010 01:12 PM, Igor V. Kovalenko wrote:
> +if ((env->pstate & PS_AM) && is_translating_asi(asi)) {
> +addr &= 0xULL;
> +}
I suggest that these be written instead as
if (is_translating_asi(asi)) {
addr = address_mask(addr);
}
That should allow you to remov
This commit introduces check_client_args_type(), which is
called by qmp_check_client_args() and complements the
previous commit.
Now the new client's argument checker code is capable of
doing type checking and detecting unknown arguments.
It works this way: we iterate over the client's arguments
On Thu, May 27, 2010 at 4:28 PM, Richard Henderson wrote:
> On 05/26/2010 11:21 PM, Corentin Chary wrote:
>> - int rep = 0; \
>> + int i = 0, rep = 0; \
>
> Dead initialization.
>
>
> r~
>
Hi,
Here is two small tight fix and another small patch related to vnc encodings.
Thanks,
Corentin Chary (3):
vnc: tight: don't forget last pixel in tight_encode_indexed_rect
vnc: tight: don't forget the third color
vnc: add missing target for vnc-encodings-*.o
Makefile |6
A simple patch would have been to just remove count -= 1, but this
one also replace the while (count--) with a for(i = 0; i < count; i++)
which I believe is more easy to understand.
Signed-off-by: Corentin Chary
---
vnc-encoding-tight.c |9 -
1 files changed, 4 insertions(+), 5 delet
While couting color, if the third color was only present one
time it wasn't added to the palette.
Signed-off-by: Corentin Chary
---
vnc-encoding-tight.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/vnc-encoding-tight.c b/vnc-encoding-tight.c
index c8effe6..efb57e7 100
vnc-encodings-*.c dependencies where missing.
Signed-off-by: Corentin Chary
---
Makefile |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index cc5fc45..221fbd8 100644
--- a/Makefile
+++ b/Makefile
@@ -120,11 +120,11 @@ vnc-auth-vencrypt.o: vnc-au
On 06/01/2010 04:05 PM, Corentin Chary wrote:
A simple patch would have been to just remove count -= 1, but this
one also replace the while (count--) with a for(i = 0; i< count; i++)
which I believe is more easy to understand.
Signed-off-by: Corentin Chary
Applied all. Thanks.
Regards,
Resubmitting a patch that was submitted in December[1]. It was on the staging
tree but somehow it got dropped. I have rebased it to current master branch on
git.
[1] http://article.gmane.org/gmane.comp.emulators.qemu/59813
This changes the monitor eject_device() function to not check
Not that CPU hotplug currently works, but if you make the mistake of
trying it on a VM started without specifying a -cpu value, you hit
a segfault from trying to strdup(NULL) in cpu_x86_find_by_name().
Signed-off-by: Alex Williamson
---
hw/pc.c | 16
1 files changed, 8 insert
On Tue, Jun 01, 2010 at 10:26:12PM +0200, Sebastian Herbszt wrote:
> Jes Sorensen wrote:
> >Handle 0x0401, DMI type 4, 32 bytes
> >Processor Information
> >- Socket Designation: CPU 1
> >+ Socket Designation: CPU01
>
> smbios.c got
> snprintf((char*)start, 6, "CPU%2x", cpu_number);
>
Commit dd4239d6574ca41c94fc0d0f77ddc728510ffc57 broke multiboot. It replaced the
instruction "rep insb (%dx), %es:(%edi)" by the binary output of
"addr32 rep insb (%dx), %es:(%di)".
Linuxboot calls the respective helper function in a code16 section. So the
original instruction was automatically tr
On Tue, Jun 01, 2010 at 08:05:26AM +0200, Jes Sorensen wrote:
> On 06/01/10 07:34, Markus Armbruster wrote:
> > "Sebastian Herbszt" writes:
> >> Gleb Natapov wrote:
> >>> I don't care much as long as we will not have "CPU :". It looks like
> >>> something
> >>> that can change after BIOS upgrade,
Ok, building from source now:
Passing SSE4.* to the guest does not work for me thru qemu-kvm-0.12.4,
but it _does_ work at current head (git:aa22e82, 0.12.50). I can bisect
further if anybody cares...
--
qemu fails to recognize host features SSE4.1, SSE4.2
https://bugs.launchpad.net/bugs/588127
* john cooper [2010-03-25 00:45]:
> This series adds the minimal support to qemu and virtio_blk
> to support passing of a virtio_blk serial id string from qemu
> through the guest driver and to the guest userland.
>
> This is derived in part from a patch set posted by Rusty some
> time ago, but h
This patch applies on-top of John's virtio-blk serial patches.
Generate default serial numbers for virtio drives based on DriveInfo.unit which
is
incremented for each additional virtio-blk device. This provides a
per-virtio-blk number to use in the default string: QM%05d that is used in
hw/ide/c
Ryan Harper wrote:
> I've applied the qemu and kernel side of this patch series and tested
> this out using the sample code below. I've also reworked this example
> into a virtioblk_id tool to work with udev to generate /dev/disk/by-id
> links; I'll be submitting a patch set to linux-hotplug with
The code comes from
http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02788.html
Without this patch it is not possible to send at least 10 special
characters (\|'"`~:;[]{}) via the monitor sendkey command.
Signed-off-by: Bernhard M. Wiedemann
---
monitor.c |7 ++-
1 files changed,
On Wed, Jun 2, 2010 at 12:44 AM, Richard Henderson wrote:
> On 06/01/2010 01:12 PM, Igor V. Kovalenko wrote:
>> + if ((env->pstate & PS_AM) && is_translating_asi(asi)) {
>> + addr &= 0xULL;
>> + }
>
> I suggest that these be written instead as
>
> if (is_translating_asi(asi))
Luiz Capitulino writes:
> Signed-off-by: Luiz Capitulino
> ---
> qdict.c | 18 ++
> qdict.h |1 +
> 2 files changed, 19 insertions(+), 0 deletions(-)
>
> diff --git a/qdict.c b/qdict.c
> index 175bc17..ca3c3b1 100644
> --- a/qdict.c
> +++ b/qdict.c
> @@ -287,6 +287,24 @@ i
On 06/01/10 22:26, Sebastian Herbszt wrote:
> Jes Sorensen wrote:
>> Handle 0x0401, DMI type 4, 32 bytes
>> Processor Information
>> - Socket Designation: CPU 1
>> + Socket Designation: CPU01
>
> smbios.c got
> snprintf((char*)start, 6, "CPU%2x", cpu_number);
>
> It should print "CPU
Erik van der Kouwe wrote:
> Hi,
>
>> We currently only clear SVM_EVTINJ_VALID after successful interrupt
>> delivery. This apparently does not match real hardware which clears the
>> whole event_inj field on every vmexit, including unsuccessful interrupt
>> delivery.
>
> Thanks for the patch. It
02.06.2010 05:48, Ryan Harper wrote:
[]
hw/virtio-blk.c |3 +++
+if (strlen(s->sn) == 0) {
Just out of curiocity (not that it is wrong or inefficient):
why
strlen(s->sn)
and not, say,
!s->sn[0]
?
/mjt
Luiz Capitulino writes:
> This commit introduces the first half of qmp_check_client_args(),
> which is the new client argument checker.
>
> It's introduced on top of the existing code, so that there are
> no regressions during the transition.
>
> It works this way: the command's args_type field (
101 - 168 of 168 matches
Mail list logo
