Re: [Qemu-devel] [PATCH 1/2] ioport: add function to check whenever a port is assigned or not

2010-05-26 Thread Markus Armbruster
Gerd Hoffmann writes: > On 05/24/10 14:32, Paul Brook wrote: >>> +int is_ioport_assigned(pio_addr_t addr) >> >> Shouldn't we move this into register_ioport_{read,write}, and have that fail >> if the port has already been assigned? > > It already checks and fails with hw_error(). Problem with tha

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-05-26 Thread Gleb Natapov
On Tue, May 25, 2010 at 11:44:50PM +0200, Jan Kiszka wrote: > > > >> I think the real solution to coalescing is put the logic inside one > >> device, in this case APIC because it has the information about irq > >> delivery. APIC could monitor incoming RTC irqs for frequency > >> information and wh

Re: [Qemu-devel] [PATCH 0/5] vnc: desktop size patches.

2010-05-26 Thread Daniel P. Berrange
On Tue, May 25, 2010 at 06:25:15PM +0200, Gerd Hoffmann wrote: > Hi, > > This series brings a bunch of vnc desktop size patches, fixing the > issues discussed in the "Possible race condition in VNC display > resizing" thread. Check list archive here: > > http://lists.gnu.org/archive/html/qemu-

[Qemu-devel] [PATCH] all vga: refuse hotplugging.

2010-05-26 Thread Gerd Hoffmann
Try to pci hotplug a vga card, watch qemu die with hw_error(). This patch fixes it. Signed-off-by: Gerd Hoffmann --- hw/cirrus_vga.c |4 hw/vga-pci.c|4 hw/vmware_vga.c |4 3 files changed, 12 insertions(+), 0 deletions(-) diff --git a/hw/cirrus_vga.c b/hw/cirrus_

Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Kevin Wolf
Am 26.05.2010 03:31, schrieb Anthony Liguori: > On 05/25/2010 04:01 PM, Aurelien Jarno wrote: >> >> I really think this patch can be useful, in my own case when testing >> debian-installer (I already cache=writeback). In short all that is about >> developing and testing, as opposed to run a VM in p

[Qemu-devel] Re: [PATCH] Release usb devices on shutdown and usb_del command

2010-05-26 Thread Shahar Havivi
On Tue, May 25, 2010 at 10:58:50AM +0200, Gerd Hoffmann wrote: > Date: Tue, 25 May 2010 10:58:50 +0200 > From: Gerd Hoffmann > To: Shahar Havivi > CC: "David S. Ahern" , > Markus Armbruster , qemu-devel@nongnu.org > Subject: Re: [PATCH] Release usb devices on shutdown and usb_del command >

Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Aurelien Jarno
On Tue, May 25, 2010 at 08:31:20PM -0500, Anthony Liguori wrote: > On 05/25/2010 04:01 PM, Aurelien Jarno wrote: > > > >I really think this patch can be useful, in my own case when testing > >debian-installer (I already cache=writeback). In short all that is about > >developing and testing, as oppo

Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-26 Thread Avi Kivity
On 05/25/2010 05:02 PM, Anthony Liguori wrote: On 05/25/2010 08:57 AM, Avi Kivity wrote: On 05/25/2010 04:54 PM, Anthony Liguori wrote: On 05/25/2010 08:36 AM, Avi Kivity wrote: We'd need a kernel-level generic snapshot API for this eventually. or (2) implement BUSE to complement FUSE and CU

[Qemu-devel] Re: [PATCH] add support for protocol driver create_options

2010-05-26 Thread Kevin Wolf
Am 26.05.2010 04:35, schrieb MORITA Kazutaka: > At Tue, 25 May 2010 15:43:17 +0200, > Kevin Wolf wrote: >> >> Am 24.05.2010 08:34, schrieb MORITA Kazutaka: >>> At Fri, 21 May 2010 18:57:36 +0200, >>> Kevin Wolf wrote: Am 20.05.2010 07:36, schrieb MORITA Kazutaka: > + > +/* > +

Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Kevin Wolf
Am 26.05.2010 10:52, schrieb Aurelien Jarno: > On Tue, May 25, 2010 at 08:31:20PM -0500, Anthony Liguori wrote: >> On 05/25/2010 04:01 PM, Aurelien Jarno wrote: >>> >>> I really think this patch can be useful, in my own case when testing >>> debian-installer (I already cache=writeback). In short al

Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-26 Thread Avi Kivity
On 05/25/2010 08:12 PM, Sage Weil wrote: On Tue, 25 May 2010, Avi Kivity wrote: What's the reason for not having these drivers upstream? Do we gain anything by hiding them from our users and requiring them to install the drivers separately from somewhere else? Six months. FW

[Qemu-devel] [PATCH v5] KVM: VMX: Enable XSAVE/XRSTORE for guest

2010-05-26 Thread Sheng Yang
From: Dexuan Cui This patch enable guest to use XSAVE/XRSTORE instructions. We assume that host_xcr0 would use all possible bits that OS supported. And we loaded xcr0 in the same way we handled fpu - do it as late as we can. Signed-off-by: Dexuan Cui Signed-off-by: Sheng Yang --- I've done

[Qemu-devel] [PATCH] drive: allow rerror, werror and readonly for if=none

2010-05-26 Thread Gerd Hoffmann
When creating guest disks the qdev way using ... -drive if=none,id=$name,args -device $driver,drive=$name it is not possible to specify rerror, werror and readonly arguments for drive as drive_init allows/blocks them based on the interface (if=) specified and none isn't white-listed there. S

Re: [Qemu-devel] [PATCH 1/2 v4] Support for multiple keyboard devices

2010-05-26 Thread Shahar Havivi
On Mon, May 10, 2010 at 03:18:29PM -0500, Anthony Liguori wrote: > Date: Mon, 10 May 2010 15:18:29 -0500 > From: Anthony Liguori > To: Shahar Havivi > CC: qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATCH 1/2 v4] Support for multiple keyboard > devices > > On 04/18/2010 02:21 PM, Shahar

Re: [Qemu-devel] [PATCH] drive: allow rerror, werror and readonly for if=none

2010-05-26 Thread Kevin Wolf
Am 26.05.2010 10:44, schrieb Gerd Hoffmann: > When creating guest disks the qdev way using ... > > -drive if=none,id=$name,args > -device $driver,drive=$name > > it is not possible to specify rerror, werror and readonly arguments > for drive as drive_init allows/blocks them based on the inter

[Qemu-devel] Re: [PATCH v5] KVM: VMX: Enable XSAVE/XRSTORE for guest

2010-05-26 Thread Avi Kivity
On 05/26/2010 12:19 PM, Sheng Yang wrote: From: Dexuan Cui This patch enable guest to use XSAVE/XRSTORE instructions. We assume that host_xcr0 would use all possible bits that OS supported. And we loaded xcr0 in the same way we handled fpu - do it as late as we can. Looks really good n

[Qemu-devel] hw/serial.c: Xmit fifo never used

2010-05-26 Thread Frank Mehnert
Hi, the xmit fifo of the serial device is never used. If qemu_chr_write() fails (interface currently not able to send characters) then the transmit_timer should be engaged to try to send the current character from the fifo again after some time. The code is } else if (qemu_chr_write(s->chr, &

Re: [Qemu-devel] Re: [PATCH 3/5] QMP: Introduce MIGRATION events

2010-05-26 Thread Daniel P. Berrange
On Tue, May 25, 2010 at 11:33:15AM -0500, Anthony Liguori wrote: > On 05/25/2010 11:25 AM, Daniel P. Berrange wrote: > > With some disk locking > >approaches we need todo a lock transfer before allowing the dest > >to continue running. > > QEMU is going to read the disk before the migration compl

[Qemu-devel] [PATCH] qdev-properties: Fix (u)intXX parsers

2010-05-26 Thread Kevin Wolf
scanf calls must not use PRI constants, they have probably the wrong size and corrupt memory. We could replace them by SCN ones, but strtol is simpler than scanf here anyway. While at it, also fix the parsers to reject garbage after the number ("4096xyz" was accepted before). Signed-off-by: Kevin

[Qemu-devel] Re: hw/serial.c: Xmit fifo never used

2010-05-26 Thread Jan Kiszka
Frank Mehnert wrote: > Hi, > > the xmit fifo of the serial device is never used. If qemu_chr_write() > fails (interface currently not able to send characters) then the > transmit_timer should be engaged to try to send the current character > from the fifo again after some time. The code is > >

Re: [Qemu-devel] [PATCH] qdev-properties: Fix (u)intXX parsers

2010-05-26 Thread Daniel P. Berrange
On Wed, May 26, 2010 at 12:28:13PM +0200, Kevin Wolf wrote: > scanf calls must not use PRI constants, they have probably the wrong size and > corrupt memory. We could replace them by SCN ones, but strtol is simpler than > scanf here anyway. While at it, also fix the parsers to reject garbage after

Re: [Qemu-devel] [PATCH] resent: x86/cpuid: propagate further CPUID leafs when -cpu host

2010-05-26 Thread Andre Przywara
Anthony Liguori wrote: On 05/25/2010 08:21 AM, Andre Przywara wrote: What's the benefit of exposing this information to the guest? That is mostly to propagate the cache size and organization parameters to the guest: +/* safe CPUID leafs to propagate to guest if -cpu host is specified + * Intel

Re: [Qemu-devel] [PATCH] qdev-properties: Fix (u)intXX parsers

2010-05-26 Thread Kevin Wolf
Am 26.05.2010 12:45, schrieb Daniel P. Berrange: > On Wed, May 26, 2010 at 12:28:13PM +0200, Kevin Wolf wrote: >> scanf calls must not use PRI constants, they have probably the wrong size and >> corrupt memory. We could replace them by SCN ones, but strtol is simpler than >> scanf here anyway. Whil

Re: [Qemu-devel] [PATCH] all vga: refuse hotplugging.

2010-05-26 Thread Stefano Stabellini
On Wed, 26 May 2010, Gerd Hoffmann wrote: > Try to pci hotplug a vga card, watch qemu die with hw_error(). > This patch fixes it. > Do you know the reason why we get hw_error()? Theoretically vga hotplug should be possible at least for secondary graphic cards (even though I suspect most operating

[Qemu-devel] Re: [PATCH v5] KVM: VMX: Enable XSAVE/XRSTORE for guest

2010-05-26 Thread Jan Kiszka
Avi Kivity wrote: > On 05/26/2010 12:19 PM, Sheng Yang wrote: >> I've done a prototype of LM support, would send out tomorrow. But the >> test >> case in QEmu side seems got something wrong. I always got an segfault at: >> qemu-kvm/hw/fw_cfg.c:223 >> 223 s->entries[arch][key].data = data; >

Re: [Qemu-devel] Re: hw/serial.c: Xmit fifo never used

2010-05-26 Thread Frank Mehnert
On Wednesday 26 May 2010, Jan Kiszka wrote: > Frank Mehnert wrote: > > I assume the correct condition would be '>= 0', that is > > > > ... > > if ((s->tsr_retry >= 0) && (s->tsr_retry <= MAX_XMIT_RETRY)) { > > s->tsr_retry++; > > ... > > Makes sense, patch welcom

Re: [Qemu-devel] [PATCH] qdev-properties: Fix (u)intXX parsers

2010-05-26 Thread Markus Armbruster
Kevin Wolf writes: > scanf calls must not use PRI constants, they have probably the wrong size and > corrupt memory. We could replace them by SCN ones, but strtol is simpler than > scanf here anyway. While at it, also fix the parsers to reject garbage after > the number ("4096xyz" was accepted be

[Qemu-devel] Re: hw/serial.c: Xmit fifo never used

2010-05-26 Thread Jan Kiszka
Frank Mehnert wrote: > On Wednesday 26 May 2010, Jan Kiszka wrote: >> Frank Mehnert wrote: >>> I assume the correct condition would be '>= 0', that is >>> >>> ... >>> if ((s->tsr_retry >= 0) && (s->tsr_retry <= MAX_XMIT_RETRY)) { >>> s->tsr_retry++; >>> ... >> Ma

Re: [Qemu-devel] [PATCH] qdev-properties: Fix (u)intXX parsers

2010-05-26 Thread Kevin Wolf
Am 26.05.2010 13:13, schrieb Markus Armbruster: > Kevin Wolf writes: > >> scanf calls must not use PRI constants, they have probably the wrong size and >> corrupt memory. We could replace them by SCN ones, but strtol is simpler than >> scanf here anyway. While at it, also fix the parsers to rejec

Re: [Qemu-devel] [PATCH] all vga: refuse hotplugging.

2010-05-26 Thread Gerd Hoffmann
On 05/26/10 12:59, Stefano Stabellini wrote: On Wed, 26 May 2010, Gerd Hoffmann wrote: Try to pci hotplug a vga card, watch qemu die with hw_error(). This patch fixes it. Do you know the reason why we get hw_error()? Because the card tries to register the legacy vga ports which are already

[Qemu-devel] Re: [PATCH v5] KVM: VMX: Enable XSAVE/XRSTORE for guest

2010-05-26 Thread Avi Kivity
On 05/26/2010 01:52 PM, Jan Kiszka wrote: Avi Kivity wrote: On 05/26/2010 12:19 PM, Sheng Yang wrote: I've done a prototype of LM support, would send out tomorrow. But the test case in QEmu side seems got something wrong. I always got an segfault at: qemu-kvm/hw/fw_cfg.c:223 223

[Qemu-devel] [PATCH v2] qdev-properties: Fix (u)intXX parsers

2010-05-26 Thread Kevin Wolf
scanf calls must not use PRI constants, they have probably the wrong size and corrupt memory. We could replace them by SCN ones, but strtol is simpler than scanf here anyway. While at it, also fix the parsers to reject garbage after the number ("4096xyz" was accepted before). Signed-off-by: Kevin

[Qemu-devel] Re: [PATCH 3/5] QMP: Introduce MIGRATION events

2010-05-26 Thread Daniel P. Berrange
On Tue, May 25, 2010 at 06:43:13PM +0200, Juan Quintela wrote: > Anthony Liguori wrote: > > On 05/25/2010 11:25 AM, Daniel P. Berrange wrote: > >> On Tue, May 25, 2010 at 06:04:17PM +0200, Juan Quintela wrote: > >> > >>> Anthony Liguori wrote: > > > I'm not sure why you would need a notifica

Re: [Qemu-devel] Re: hw/serial.c: Xmit fifo never used

2010-05-26 Thread Stefano Stabellini
On Wed, 26 May 2010, Jan Kiszka wrote: > Frank Mehnert wrote: > > On Wednesday 26 May 2010, Jan Kiszka wrote: > >> Frank Mehnert wrote: > >>> I assume the correct condition would be '>= 0', that is > >>> > >>> ... > >>> if ((s->tsr_retry >= 0) && (s->tsr_retry <= MAX_XMIT_RETRY)) {

Re: [Qemu-devel] [PATCH] all vga: refuse hotplugging.

2010-05-26 Thread Stefano Stabellini
On Wed, 26 May 2010, Gerd Hoffmann wrote: > On 05/26/10 12:59, Stefano Stabellini wrote: > > On Wed, 26 May 2010, Gerd Hoffmann wrote: > >> Try to pci hotplug a vga card, watch qemu die with hw_error(). > >> This patch fixes it. > >> > > > > Do you know the reason why we get hw_error()? > > Becaus

Re: [Qemu-devel] Re: irq problems after live migration with 0.12.4

2010-05-26 Thread Peter Lieven
Michael Tokarev wrote: 25.05.2010 15:03, Peter Lieven wrote: Michael Tokarev wrote: 23.05.2010 13:55, Peter Lieven wrote: [] [64442.298521] irq 10: nobody cared (try booting with the "irqpoll" option) [] [64442.299433] handlers: [64442.299840] [] (e1000_intr+0x0/0x190 [e1000]) [64442.300046

Re: [Qemu-devel] RFC: ehci -> uhci handoff suggestions

2010-05-26 Thread Gerd Hoffmann
On 05/25/10 15:40, David S. Ahern wrote: USB 2.0 leverages companion UHCI or OHCI host controllers for full and low speed devices. I do not see an appropriate means for doing that bus transition and could use some suggestions. Hmm. Well. That doesn't really fit into the qdev tree model ...

Re: [Qemu-devel] RFC: ehci -> uhci handoff suggestions

2010-05-26 Thread Kevin Wolf
Am 26.05.2010 13:47, schrieb Gerd Hoffmann: > On 05/25/10 15:40, David S. Ahern wrote: >> >> USB 2.0 leverages companion UHCI or OHCI host controllers for full and >> low speed devices. I do not see an appropriate means for doing that bus >> transition and could use some suggestions. > > Hmm. Wel

[Qemu-devel] [Bug 532733] Re: apt/dpkg in qemu-system-arm hangs if a big task is installed

2010-05-26 Thread Arvind Singh
I am seeing similar issue on Lucid. Rootstock version: rootstock-0.1.99.3 Here is my command line: sudo ./rootstock --fqdn beagleboard --login ubuntu --password beagle --imagesize 4G --swapsize 512 --components "main,universe,multiverse" --seed openssh-server,build-essential,apache2,postgresql-s

[Qemu-devel] Re: [PATCH v2] qdev-properties: Fix (u)intXX parsers

2010-05-26 Thread Gerd Hoffmann
On 05/26/10 13:27, Kevin Wolf wrote: scanf calls must not use PRI constants, they have probably the wrong size and corrupt memory. We could replace them by SCN ones, but strtol is simpler than scanf here anyway. While at it, also fix the parsers to reject garbage after the number ("4096xyz" was a

[Qemu-devel] [Bug 532733] Re: apt/dpkg in qemu-system-arm hangs if a big task is installed

2010-05-26 Thread Oliver Grawert
@arvind this is not related to this bug, please open a new one -- apt/dpkg in qemu-system-arm hangs if a big task is installed https://bugs.launchpad.net/bugs/532733 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: New St

[Qemu-devel] [Bug 532733] Re: apt/dpkg in qemu-system-arm hangs if a big task is installed

2010-05-26 Thread Arvind Singh
Sure Thanks. -- apt/dpkg in qemu-system-arm hangs if a big task is installed https://bugs.launchpad.net/bugs/532733 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: New Status in “qemu-kvm” package in Ubuntu: Incomplete S

Re: [Qemu-devel] RFC: ehci -> uhci handoff suggestions

2010-05-26 Thread Gerd Hoffmann
Hi, USB devices can support both 1.1 and 2.0, right? Who decides which protocol is used then? I think the OS can speak 1.1 to the device even in case a ehci controller is present (but unused by the OS), right? AFAIK the OS must tell the EHCI that it should hand the device off to the UHCI/O

Re: [Qemu-devel] [PATCH] all vga: refuse hotplugging.

2010-05-26 Thread Gerd Hoffmann
Hi, Yes. Assuming the virtual hardware in question can actually act as secondary, i.e. is fully programmable without the legacy vga ports. The standard vga can't. The cirrus looks doable, at least you can access the vga ports using the mmio bar. I see, good point. I guess the right fix h

Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Avi Kivity
On 05/17/2010 03:58 PM, Anthony Liguori wrote: On 05/17/2010 05:14 AM, Alexander Graf wrote: Usually the guest can tell the host to flush data to disk. In some cases we don't want to flush though, but try to keep everything in cache. So let's add a new cache value to -drive that allows us to s

Re: [Qemu-devel] RFC: ehci -> uhci handoff suggestions

2010-05-26 Thread David S. Ahern
On 05/26/2010 06:48 AM, Gerd Hoffmann wrote: > > Hi, > >>> USB devices can support both 1.1 and 2.0, right? Who decides which >>> protocol is used then? I think the OS can speak 1.1 to the device even >>> in case a ehci controller is present (but unused by the OS), right? >> >> AFAIK the OS

Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Avi Kivity
On 05/25/2010 09:48 PM, Anthony Liguori wrote: On 05/25/2010 12:59 PM, Alexander Graf wrote: I see it as the equivalent to the Taint bit in Linux. I want to make it clear to users up front that if you use this option, and you have data loss issues, don't complain. Just putting something in qem

Re: [Qemu-devel] [PATCH] all vga: refuse hotplugging.

2010-05-26 Thread Stefano Stabellini
On Wed, 26 May 2010, Gerd Hoffmann wrote: >Hi, > > >> Yes. Assuming the virtual hardware in question can actually act as > >> secondary, i.e. is fully programmable without the legacy vga ports. The > >> standard vga can't. The cirrus looks doable, at least you can access > >> the vga ports

Re: [Qemu-devel] [PATCH 3/5] QMP: Introduce MIGRATION events

2010-05-26 Thread Luiz Capitulino
On Tue, 25 May 2010 13:51:01 -0500 Anthony Liguori wrote: > On 05/25/2010 01:31 PM, Luiz Capitulino wrote: > > On Tue, 25 May 2010 16:21:03 +0200 > > Juan Quintela wrote: > > > > > >> They are emitted when migration starts, ends, has a failure or is canceled. > >> > >> Signed-off-by: Juan Qu

Re: [Qemu-devel] RFC: ehci -> uhci handoff suggestions

2010-05-26 Thread Kevin Wolf
Am 26.05.2010 15:06, schrieb David S. Ahern: > > > On 05/26/2010 06:48 AM, Gerd Hoffmann wrote: >> >> Hi, >> USB devices can support both 1.1 and 2.0, right? Who decides which protocol is used then? I think the OS can speak 1.1 to the device even in case a ehci controller is pr

Re: [Qemu-devel] [PATCH] all vga: refuse hotplugging.

2010-05-26 Thread Gerd Hoffmann
Hi, I think having two gfx screens mapped to two qemu consoles, then be able to switch between them via Ctrl-Alt- (like you switch today to text consoles) could be doable without too much effort. Question is how useful this would be as you can't see your two screens at the same time. Actua

Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Anthony Liguori
On 05/26/2010 03:43 AM, Kevin Wolf wrote: Am 26.05.2010 03:31, schrieb Anthony Liguori: On 05/25/2010 04:01 PM, Aurelien Jarno wrote: I really think this patch can be useful, in my own case when testing debian-installer (I already cache=writeback). In short all that is about developin

Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Anthony Liguori
On 05/26/2010 03:52 AM, Aurelien Jarno wrote: On Tue, May 25, 2010 at 08:31:20PM -0500, Anthony Liguori wrote: On 05/25/2010 04:01 PM, Aurelien Jarno wrote: I really think this patch can be useful, in my own case when testing debian-installer (I already cache=writeback). In short all

Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Anthony Liguori
On 05/26/2010 08:06 AM, Avi Kivity wrote: On 05/17/2010 03:58 PM, Anthony Liguori wrote: On 05/17/2010 05:14 AM, Alexander Graf wrote: Usually the guest can tell the host to flush data to disk. In some cases we don't want to flush though, but try to keep everything in cache. So let's add a ne

[Qemu-devel] [Bug 532733] Re: apt/dpkg in qemu-system-arm hangs if a big task is installed

2010-05-26 Thread Anthony Liguori
beagleboard is not in upstream QEMU. Please do not mark bugs as affects upstream QEMU unless you've actually reproduced the problem with upstream QEMU. ** Changed in: qemu Status: New => Invalid -- apt/dpkg in qemu-system-arm hangs if a big task is installed https://bugs.launchpad.net/bu

Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Kevin Wolf
Am 26.05.2010 15:42, schrieb Anthony Liguori: > On 05/26/2010 03:43 AM, Kevin Wolf wrote: >> Am 26.05.2010 03:31, schrieb Anthony Liguori: >> >>> On 05/25/2010 04:01 PM, Aurelien Jarno wrote: >>> I really think this patch can be useful, in my own case when testing debian-install

Re: [Qemu-devel] RFC: ehci -> uhci handoff suggestions

2010-05-26 Thread David S. Ahern
On 05/26/2010 07:23 AM, Kevin Wolf wrote: > Am 26.05.2010 15:06, schrieb David S. Ahern: >> >> >> On 05/26/2010 06:48 AM, Gerd Hoffmann wrote: >>> >>> Hi, >>> > USB devices can support both 1.1 and 2.0, right? Who decides which > protocol is used then? I think the OS can speak 1.1 to

[Qemu-devel] [Bug 532733] Re: apt/dpkg in qemu-system-arm hangs if a big task is installed

2010-05-26 Thread Oliver Grawert
@Anthony, this bug has nothing to do with beagleboards it happens if qemu is run on x86 systems -- apt/dpkg in qemu-system-arm hangs if a big task is installed https://bugs.launchpad.net/bugs/532733 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

[Qemu-devel] [Bug 532733] Re: apt/dpkg in qemu-system-arm hangs if a big task is installed

2010-05-26 Thread Oliver Grawert
@Anthony please see all the above comments before judging and please reopen it upstream again -- apt/dpkg in qemu-system-arm hangs if a big task is installed https://bugs.launchpad.net/bugs/532733 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed t

Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Anthony Liguori
On 05/26/2010 09:12 AM, Aurelien Jarno wrote: It's hard for me to consider this a performance regression because ultimately, you're getting greater than bare metal performance (because of extremely aggressive caching). It might be a regression from the previous performance, but that was at the c

[Qemu-devel] [PATCH 11/14] introduce more --xyzdir options

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 26 +- 1 files changed, 21 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 4dc75c2..2e59f9b 100755 --- a/configure +++ b/configure @@ -68,6 +68,10 @@ cpu="" prefix="" interp_prefix="/usr/gnemul/qemu-%

[Qemu-devel] Re: migrating guest with msi-x interrupts

2010-05-26 Thread Michael S. Tsirkin
On Tue, May 25, 2010 at 04:09:13PM -0600, Cam Macdonell wrote: > Hi, > > I'm trying to migrate a guest device with MSI-X interrupts. However, > the interrupts are not injected into the guest. I've added some > tracing to msix.c and it seems that the MSI-X vectors are masked when > the guest is r

[Qemu-devel] [PATCH 07/14] rename CONFIG_QEMU_PREFIX

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- bsd-user/main.c |2 +- configure |2 +- linux-user/main.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/bsd-user/main.c b/bsd-user/main.c index 05cc3d9..aff9f13 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @@ -43

Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Anthony Liguori
On 05/26/2010 09:03 AM, Kevin Wolf wrote: Am 26.05.2010 15:42, schrieb Anthony Liguori: On 05/26/2010 03:43 AM, Kevin Wolf wrote: Am 26.05.2010 03:31, schrieb Anthony Liguori: On 05/25/2010 04:01 PM, Aurelien Jarno wrote: I really think this patch can be useful,

[Qemu-devel] [PATCH 13/14] move directory defaults earlier

2010-05-26 Thread Paolo Bonzini
Unify with existing special-purpose configure code for win32. Signed-off-by: Paolo Bonzini --- configure | 47 ++- 1 files changed, 14 insertions(+), 33 deletions(-) diff --git a/configure b/configure index b036c40..488ef07 100755 --- a/configure ++

[Qemu-devel] [PATCH 00/14] configure --xyzdir options cleanup

2010-05-26 Thread Paolo Bonzini
This series cleans up the handling of --xyzdir options and improves the customizability of the directory layout. Patches 1/2/3/14 are somewhat unrelated to the main purpose of the patch, but they conflict with other patches in the series so I sent them together. Paolo Bonzini (14): bail out ear

[Qemu-devel] [Bug 532733] Re: apt/dpkg in qemu-system-arm hangs if a big task is installed

2010-05-26 Thread Oliver Grawert
and just for reference so there isnt coming up any confusion again, the used qemu call that breaks is for a versatilbepb machine using the versatile kernel from http://ports.ubuntu.com/ubuntu- ports/dists/lucid/main/installer- armel/current/images/versatile/netboot/vmlinuz -- apt/dpkg in qemu-sys

Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Kevin Wolf
Am 26.05.2010 16:08, schrieb Anthony Liguori: > On 05/26/2010 09:03 AM, Kevin Wolf wrote: >> Am 26.05.2010 15:42, schrieb Anthony Liguori: >> >>> On 05/26/2010 03:43 AM, Kevin Wolf wrote: >>> Am 26.05.2010 03:31, schrieb Anthony Liguori: > On 05/25/2010 04:01 PM

[Qemu-devel] [PATCH 6/8] enable event_notifier to use pipes

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- event_notifier.c | 69 +++--- event_notifier.h |3 +- 2 files changed, 52 insertions(+), 20 deletions(-) diff --git a/event_notifier.c b/event_notifier.c index 066adb9..a33f3c5 100644 --- a/event_notifier.c ++

[Qemu-devel] [PATCH 7/8] add Win32 implementation of event notifiers

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Compile-tested only. iothread is broken anyway on Win32 due to missing implementation of qemu-threads. event_notifier.c | 33 + event_notifier.h |8 2 files changed, 41 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH 05/14] introduce sysconfsuffix

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/configure b/configure index f96..cf19ebf 100755 --- a/configure +++ b/configure @@ -1972,9 +1972,7 @@ if test "$mingw32" = "yes" ; then confsuffix="" docsuffix=""

[Qemu-devel] [PATCH 06/14] introduce confdir and confsuffix

2010-05-26 Thread Paolo Bonzini
confsuffix was write-only, flesh it out. Signed-off-by: Paolo Bonzini --- configure | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/configure b/configure index cf19ebf..435e765 100755 --- a/configure +++ b/configure @@ -1969,10 +1969,10 @@ if test "$mingw32" = "

[Qemu-devel] [PATCH 1/8] move event_notifier into the main directory

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/event_notifier.c => event_notifier.c |1 - hw/event_notifier.h => event_notifier.h |0 2 files changed, 0 insertions(+), 1 deletions(-) rename hw/event_notifier.c => event_notifier.c (98%) rename hw/event_notifier.h => event_notifier.h (100%) diff --

[Qemu-devel] [PATCH 02/14] avoid using expr in configure

2010-05-26 Thread Paolo Bonzini
Just a personal preference against duplicating hieroglyphics. Signed-off-by: Paolo Bonzini --- configure | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/configure b/configure index e8dd2ef..5a7cb6e 100755 --- a/configure +++ b/configure @@ -928,6 +928,13 @@ if

[Qemu-devel] [PATCH 10/14] expand ${prefix} in create_config

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure |3 +-- create_config |9 + vl.c |2 +- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 9736942..4dc75c2 100755 --- a/configure +++ b/configure @@ -2073,8 +2073,7 @@ echo "mandi

[Qemu-devel] [PATCH 3/8] remove event_notifier_test

2010-05-26 Thread Paolo Bonzini
This is broken; since the eventfd is used in nonblocking mode there is a race between reading and writing. Signed-off-by: Paolo Bonzini --- event_notifier.c | 15 --- event_notifier.h |1 - 2 files changed, 0 insertions(+), 16 deletions(-) diff --git a/event_notifier.c b/event

[Qemu-devel] [PATCH 12/14] ignore unknown --xyzdir options

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 2e59f9b..b036c40 100755 --- a/configure +++ b/configure @@ -673,6 +673,8 @@ for opt do ;; --enable-vhost-net) vhost_net="yes" ;; + --*dir) +

[Qemu-devel] [PATCH 08/14] unify handling of xyzdir variables

2010-05-26 Thread Paolo Bonzini
Making an xyzdir variable for each directory prepares for the next patches introducing config-host.h defines and configure options for them. It also fixes the problem where overriding prefix at "make install" time did not override it for sysconfdir. Removes some of the differences between sysconfd

[Qemu-devel] [PATCH 5/8] add and use event_notifier_set_handler

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- event_notifier.c |7 +++ event_notifier.h |3 +++ hw/virtio-pci.c |9 +++-- 3 files changed, 13 insertions(+), 6 deletions(-) diff --git a/event_notifier.c b/event_notifier.c index 0f7b8da..066adb9 100644 --- a/event_notifier.c +++ b/event_no

[Qemu-devel] Re: [PATCH 3/5] QMP: Introduce MIGRATION events

2010-05-26 Thread Anthony Liguori
On 05/26/2010 05:33 AM, Daniel P. Berrange wrote: I'm not sure why you would need a notification of when migration starts (since you know when you've started migration). But you don't know if the other end "knows" that it has also started. started is needed only in incoming part, becaus

[Qemu-devel] [PATCH 4/8] add and use virtqueue_from_guest_notifier

2010-05-26 Thread Paolo Bonzini
This changes the opaque pointer passed to the handler, from being the virtqueue to being the eventnotifier. It is useful as soon as the eventnotifier will be able to set its own (type-safe) handler. Signed-off-by: Paolo Bonzini --- I don't have a vhost-enabled machine yet. So only compi

[Qemu-devel] [Bug 532733] Re: apt/dpkg in qemu-system-arm hangs if a big task is installed

2010-05-26 Thread Anthony Liguori
If someone reproduces the bug against upstream qemu, feel free to refile the bug with the appropriate information. -- apt/dpkg in qemu-system-arm hangs if a big task is installed https://bugs.launchpad.net/bugs/532733 You received this bug notification because you are a member of qemu- devel-ml,

[Qemu-devel] [PATCH 09/14] move all directory entries in config-host.mak close

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/configure b/configure index fee9665..9736942 100755 --- a/configure +++ b/configure @@ -2067,6 +2067,12 @@ printf "# Configured with:" >> $config_host_mak printf " '%s'

Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Avi Kivity
On 05/26/2010 04:50 PM, Anthony Liguori wrote: In fact, btrfs is currently unusable for virt because O_SYNC writes inflate a guest write to a host write. by a huge factor (50x-100x). cache=writethrough is 100% unusable, cache=writeback is barely tolerable. As of 2.6.32, cache=volatile is prob

[Qemu-devel] [PATCH 0/8] Make event_notifier more useful and more used

2010-05-26 Thread Paolo Bonzini
Hi, this patch adds all the eventfd bells and whistles from vl.c/cpus.c to event_notifier, including pipe emulation and Win32 support. It then modifies the iothread code to use it instead. Paolo Bonzini (8): move event_notifier into the main directory add event_notifier_set remove event_not

[Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Paolo Bonzini
On 05/26/2010 03:48 PM, Anthony Liguori wrote: We might get 100 bug reports about this "regression" but they concern much less than 1 bug report of image corruption because of power failure/host crash. A reputation of being unsafe is very difficult to get rid of and is something that I hear conce

[Qemu-devel] [PATCH 8/8] change ioevent to use event notifiers

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- cpus.c | 95 +--- 1 files changed, 9 insertions(+), 86 deletions(-) diff --git a/cpus.c b/cpus.c index 8341f6c..7a1dd06 100644 --- a/cpus.c +++ b/cpus.c @@ -26,6 +26,7 @@ #include "config-host.h" #

[Qemu-devel] [PATCH 01/14] bail out early on invalid -cpu option

2010-05-26 Thread Paolo Bonzini
It would fail later anyway. Signed-off-by: Paolo Bonzini --- configure |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 3cd2c5f..e8dd2ef 100755 --- a/configure +++ b/configure @@ -232,7 +232,8 @@ case "$cpu" in cpu="sparc" ;; *

[Qemu-devel] [PATCH 2/8] add event_notifier_set

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- event_notifier.c |7 +++ event_notifier.h |1 + 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/event_notifier.c b/event_notifier.c index 2c73555..3f50568 100644 --- a/event_notifier.c +++ b/event_notifier.c @@ -38,6 +38,13 @@ int event_

[Qemu-devel] [PATCH 03/14] dyngen is long time gone

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 5a7cb6e..f96 100755 --- a/configure +++ b/configure @@ -748,7 +748,8 @@ echo "Advanced options (experts only):" echo " --source-path=PATH p

[Qemu-devel] [PATCH 04/14] delete duplicate create_config case stanza

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- create_config |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/create_config b/create_config index 2f052ae..edcad25 100755 --- a/create_config +++ b/create_config @@ -13,11 +13,6 @@ case $line in pkgversion=${line#*=} echo "#d

[Qemu-devel] [PATCH 14/14] move computation of tools and roms outside of config-host.mak generation

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 40 +--- 1 files changed, 21 insertions(+), 19 deletions(-) diff --git a/configure b/configure index 488ef07..d9983b0 100755 --- a/configure +++ b/configure @@ -1991,6 +1991,27 @@ fi confdir=$sysconfdir$confsuf

Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Aurelien Jarno
Anthony Liguori a écrit : > On 05/26/2010 03:52 AM, Aurelien Jarno wrote: >> On Tue, May 25, 2010 at 08:31:20PM -0500, Anthony Liguori wrote: >> >>> On 05/25/2010 04:01 PM, Aurelien Jarno wrote: >>> I really think this patch can be useful, in my own case when testing debian-inst

Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Aurelien Jarno
Kevin Wolf a écrit : > Am 26.05.2010 15:42, schrieb Anthony Liguori: >> On 05/26/2010 03:43 AM, Kevin Wolf wrote: >>> Am 26.05.2010 03:31, schrieb Anthony Liguori: >>> On 05/25/2010 04:01 PM, Aurelien Jarno wrote: > I really think this patch can be useful, in my own case whe

[Qemu-devel] Re: [PATCH 3/5] QMP: Introduce MIGRATION events

2010-05-26 Thread Daniel P. Berrange
On Wed, May 26, 2010 at 09:54:22AM -0500, Anthony Liguori wrote: > On 05/26/2010 05:33 AM, Daniel P. Berrange wrote: > >>>I'm not sure why you would need a notification of when migration > >>>starts (since you know when you've started migration). > >>> > >>But you don't know if the other end

Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Aurelien Jarno
Anthony Liguori a écrit : > On 05/26/2010 09:12 AM, Aurelien Jarno wrote: >>> It's hard for me to consider this a performance regression because >>> ultimately, you're getting greater than bare metal performance (because >>> of extremely aggressive caching). It might be a regression from the >>> p

[Qemu-devel] [PATCH] Add cache=unsafe parameter to -drive

2010-05-26 Thread Alexander Graf
Usually the guest can tell the host to flush data to disk. In some cases we don't want to flush though, but try to keep everything in cache. So let's add a new cache value to -drive that allows us to set the cache policy to most aggressive, disabling flushes. We call this mode "unsafe", as guest d

Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Anthony Liguori
On 05/26/2010 10:40 AM, Aurelien Jarno wrote: I highly doubt that this is even visible on benchmarks without using KVM. The improvement on a microbenchmark was relatively small and the cost from TCG would almost certainly dwarf it. It is something clearly visible. Before fsync() was not u

[Qemu-devel] Re: [PATCH] Add cache=unsafe parameter to -drive

2010-05-26 Thread Anthony Liguori
On 05/26/2010 10:51 AM, Alexander Graf wrote: Usually the guest can tell the host to flush data to disk. In some cases we don't want to flush though, but try to keep everything in cache. So let's add a new cache value to -drive that allows us to set the cache policy to most aggressive, disabling

[Qemu-devel] Re: [PATCH] Add cache=unsafe parameter to -drive

2010-05-26 Thread Alexander Graf
On 26.05.2010, at 18:17, Anthony Liguori wrote: > On 05/26/2010 10:51 AM, Alexander Graf wrote: >> Usually the guest can tell the host to flush data to disk. In some cases we >> don't want to flush though, but try to keep everything in cache. >> >> So let's add a new cache value to -drive that a

  1   2   >