Re: [Qemu-devel] [PATCH 1/3] qemu-nbd: Fix return value handling of bdrv_open

2010-03-20 Thread Markus Armbruster
Ryota Ozaki writes: > bdrv_open may return -errno so we have to check > if the return value is '< 0', not '== -1'. > > Signed-off-by: Ryota Ozaki > --- > qemu-nbd.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/qemu-nbd.c b/qemu-nbd.c > index a393583..b89c361 10

Re: [Qemu-devel] [PATCH 1/3] qemu-nbd: Fix return value handling of bdrv_open

2010-03-20 Thread Ryota Ozaki
On Sat, Mar 20, 2010 at 4:01 PM, Markus Armbruster wrote: > Ryota Ozaki writes: > >> bdrv_open may return -errno so we have to check >> if the return value is '< 0', not '== -1'. >> >> Signed-off-by: Ryota Ozaki >> --- >>  qemu-nbd.c |    2 +- >>  1 files changed, 1 insertions(+), 1 deletions(-)

[Qemu-devel] [PATCH] qemu-io: Fix return value handling of bdrv_open

2010-03-20 Thread Ryota Ozaki
bdrv_open may return -errno so we have to check if the return value is '< 0', not '== -1'. Signed-off-by: Ryota Ozaki --- qemu-io.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index b2f2f5a..2f195bf 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -12

Re: [Qemu-devel] [PATCH] qemu-io: Fix return value handling of bdrv_open

2010-03-20 Thread Markus Armbruster
Ryota Ozaki writes: > bdrv_open may return -errno so we have to check > if the return value is '< 0', not '== -1'. Looks good, thanks!

[Qemu-devel] Re: [PATCH 4/9] virtio-serial: Handle scatter-gather buffers for control messages

2010-03-20 Thread Avi Kivity
On 03/19/2010 01:58 PM, Amit Shah wrote: Current control messages are small enough to not be split into multiple buffers but we could run into such a situation in the future or a malicious guest could cause such a situation. So handle the entire iov request for control messages. Also ensure the

[Qemu-devel] build error in current master

2010-03-20 Thread Paul Bolle
0) Building current master (3290c4aac5b97bb1e3b2b28d94669f2c611ce84a, Introduce a default qmp session) fails here: $ make > /dev/null cc1: warnings being treated as errors curses.c: In function ‘curses_display_init’: curses.c:341: error: initialization from incompatible pointer type make: *** [cur

[Qemu-devel] Re: Completing big real mode emulation

2010-03-20 Thread Avi Kivity
On 03/19/2010 05:29 PM, Mohammed Gamal wrote: Hello all, As some of you might know, I've worked on supporting big real mode emulation on VMX back in GSoC 2008. Looking at the Qemu GSoC ideas list for this year, I found it among the possible ideas for a GSoC project. I'd be interested in driving t

[Qemu-devel] [PATCH] Fix curses_atexit definition for use with exit_notifier.

2010-03-20 Thread Jai Menon
Hello, As in subject. -- Jai Menon 0001-Fix-curses_atexit-definition-for-use-with-exit_notif.patch Description: Binary data

[Qemu-devel] [PATCH] curses: Fix compilation error

2010-03-20 Thread Stefan Weil
d7234f4d7e373a708e1df9ab565a71b71b189025 was incomplete and results in a compilation error when QEMU is configured with curses support. Fix this and clean up the code a little, too. Signed-off-by: Stefan Weil --- curses.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff

Re: [Qemu-devel] build error in current master

2010-03-20 Thread Blue Swirl
On 3/20/10, Paul Bolle wrote: > 0) Building current master (3290c4aac5b97bb1e3b2b28d94669f2c611ce84a, > Introduce a default qmp session) fails here: > > $ make > /dev/null > cc1: warnings being treated as errors > curses.c: In function ‘curses_display_init’: > curses.c:341: error: initializat

[Qemu-devel] Re: Completing big real mode emulation

2010-03-20 Thread Alexander Graf
On 20.03.2010, at 08:49, Avi Kivity wrote: > On 03/19/2010 05:29 PM, Mohammed Gamal wrote: >> Hello all, >> As some of you might know, I've worked on supporting big real mode >> emulation on VMX back in GSoC 2008. Looking at the Qemu GSoC ideas >> list for this year, I found it among the possible

[Qemu-devel] Re: Completing big real mode emulation

2010-03-20 Thread Avi Kivity
On 03/20/2010 10:34 AM, Alexander Graf wrote: Interestingly enough Hannes just tried to boot a Windows 98 VM on SVM yesterday and failed, while the same VM worked (mostly) with -no-kvm. So apparently there's more missing to it than just big real mode. Was there an error message? I'd sa

[Qemu-devel] Re: Completing big real mode emulation

2010-03-20 Thread Alexander Graf
On 20.03.2010, at 09:39, Avi Kivity wrote: > On 03/20/2010 10:34 AM, Alexander Graf wrote: >> >> Interestingly enough Hannes just tried to boot a Windows 98 VM on SVM >> yesterday and failed, while the same VM worked (mostly) with -no-kvm. So >> apparently there's more missing to it than just

[Qemu-devel] Re: Completing big real mode emulation

2010-03-20 Thread Avi Kivity
On 03/20/2010 10:55 AM, Alexander Graf wrote: I'd say that a GSoC project would rather focus on making a guest OS work than working on generic big real mode. Having Windows 98 support is way more visible to the users. And hopefully more fun to implement too, as it's a visible goal :-).

[Qemu-devel] Re: Completing big real mode emulation

2010-03-20 Thread Mohammed Gamal
On Sat, Mar 20, 2010 at 3:18 PM, Avi Kivity wrote: > On 03/20/2010 10:55 AM, Alexander Graf wrote: >>> I'd say that a GSoC project would rather focus on making a guest OS work than working on generic big real mode. Having Windows 98 support is way more visible to the users. An

[Qemu-devel] Re: Completing big real mode emulation

2010-03-20 Thread Alexander Graf
Am 20.03.2010 um 15:02 schrieb Mohammed Gamal : On Sat, Mar 20, 2010 at 3:18 PM, Avi Kivity wrote: On 03/20/2010 10:55 AM, Alexander Graf wrote: I'd say that a GSoC project would rather focus on making a guest OS work than working on generic big real mode. Having Windows 98 support is w

Re: [Qemu-devel] NetBSD qemu block device support

2010-03-20 Thread Christoph Hellwig
On Thu, Mar 18, 2010 at 10:32:36PM +0200, Blue Swirl wrote: > The patch does not apply to current development repository. > > There is no description of the change suitable for changelog without > any editing. > > Signed-off-by: line is missing. > > The patch combines formatting (whitespace) cha

Re: [Qemu-devel] virtio block device and sysfs

2010-03-20 Thread Richard W.M. Jones
On Sat, Mar 06, 2010 at 11:42:34PM +0100, Marc Haber wrote: > My goal is to have a possibility to give a "speaking" name to any > block device handed into a guest instance by the host. That name > should be visible inside the guest, just as a LV is visible with its > name in the system running the